r304499 - [CodeGen] Surround assertion with parentheses.

Author: davide Date: Thu Jun 1 18:55:18 2017 New Revision: 304499 URL: http://llvm.org/viewvc/llvm-project?rev=304499=rev Log: [CodeGen] Surround assertion with parentheses. This should placate GCC's -Wparentheses. Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp Modified:

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

erik.pilkington created this revision. This patch drops support for suppressing -Wunguarded-availability with redeclarations. This was behavior left over from the -Wpartial-availability days, where it was the only way of silencing the diagnostic. Now that we have @available and better support

[PATCH] D33788: Return a canonical path from getClangResourcePath()

bruno added a reviewer: bruno. bruno added a comment. Hi Aaron, Nice catch! Any chance you can add a testcase to this? https://reviews.llvm.org/D33788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 updated this revision to Diff 101167. jyu2 marked an inline comment as done. jyu2 added a comment. Update to address review comments. https://reviews.llvm.org/D3 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/AnalysisBasedWarnings.cpp

r304501 - [ThinLTO] Add x86 requires to thin_link_bitcode. NFC.

Author: timshen Date: Thu Jun 1 19:08:58 2017 New Revision: 304501 URL: http://llvm.org/viewvc/llvm-project?rev=304501=rev Log: [ThinLTO] Add x86 requires to thin_link_bitcode. NFC. It already specifies the triples, so the intention was to test x86 for now (or then). Differential Revision:

Re: r304376 - PR33232: implement support for MSVC's __is_trivially_destructible trait.

On 31 May 2017 at 17:41, Eric Fiselier wrote: > I'm assuming libc++ should move to this trait instead? > Yes, that'd be a good idea. Though now that you mention it, I'm not sure we have a good feature detection story for these builtins. Looks like a bunch of the existing ones are

[PATCH] D33719: Add _Float16 as a C/C++ source language type

bruno added a comment. Hi Sjoerd, Thanks for working on this. Can you add context to your patch? Comment at: test/CodeGenCXX/float16-declarations-error.cpp:1 +// RUN: not %clang -S -emit-llvm --target=aarch64 %s -o - 2>&1 | FileCheck %s --check-prefix=CHECK-ERROR +

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D33703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r304515 - Support lazy stat'ing of files referenced by module maps.

Author: rsmith Date: Thu Jun 1 20:55:39 2017 New Revision: 304515 URL: http://llvm.org/viewvc/llvm-project?rev=304515=rev Log: Support lazy stat'ing of files referenced by module maps. This patch adds support for a `header` declaration in a module map to specify certain `stat` information

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

This revision was automatically updated to reflect the committed changes. Closed by commit rL304515: Support lazy stat'ing of files referenced by module maps. (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D33703?vs=101157=101162#toc Repository: rL LLVM

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 added a comment. In https://reviews.llvm.org/D3#770238, @aaron.ballman wrote: > In https://reviews.llvm.org/D3#768332, @jyu2 wrote: > > > Okay this CFG version of this change. In this change I am basic using same > > algorithm with -Winfinite-recursion. > > > > In addition to my

[PATCH] D33692: [ThinLTO] Wire up ThinLTO and new PM

This revision was automatically updated to reflect the committed changes. Closed by commit rL304496: [ThinLTO] Wire up ThinLTO and new PM (authored by timshen). Changed prior to commit: https://reviews.llvm.org/D33692?vs=101106=101135#toc Repository: rL LLVM https://reviews.llvm.org/D33692

r304496 - [ThinLTO] Wire up ThinLTO and new PM

Author: timshen Date: Thu Jun 1 18:27:51 2017 New Revision: 304496 URL: http://llvm.org/viewvc/llvm-project?rev=304496=rev Log: [ThinLTO] Wire up ThinLTO and new PM Summary: This patch teaches clang to use and propagate new PM in ThinLTO. Reviewers: davide, chandlerc, tejohnson Subscribers:

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

bruno added a comment. Hi Richard, Thanks for improving this further! Questions / comments: - I've noticed in the patch that on the ASTWriter side we serialize the introduced size / mtime, but there are no changes to the ASTReader, so I assume in the reader side you still need the module map

[PATCH] D33706: CodeGen: Cast temporary variable to proper address space

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3805 +Address Addr = +CreateMemTemp(I->Ty, ArgInfo.getIndirectAlign(), "tmp", false); IRCallArgs[FirstIRArg] = Addr.getPointer(); How about "indirect-arg-temp" as the

[PATCH] D33739: [Sema] Improve -Wstrict-prototypes diagnostic message for blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rL304507: [Sema] Improve -Wstrict-prototypes diagnostic message for blocks. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D33739?vs=100916=101155#toc Repository: rL LLVM

r304507 - [Sema] Improve -Wstrict-prototypes diagnostic message for blocks.

Author: ahatanak Date: Thu Jun 1 20:07:08 2017 New Revision: 304507 URL: http://llvm.org/viewvc/llvm-project?rev=304507=rev Log: [Sema] Improve -Wstrict-prototypes diagnostic message for blocks. Print "this block declaration is not a prototype" for non-prototype declarations of blocks instead

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 marked 12 inline comments as done. jyu2 added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6341 +: Warning<"%0 has a non-throwing exception specification but can still " + "throw, may result in unexpected program termination.">, +

[PATCH] D33820: [PowerPC] Pass CPU to assembler with -no-integrated-as

nemanjai updated this revision to Diff 101169. nemanjai added a comment. Initially, forgot to add a test case. Repository: rL LLVM https://reviews.llvm.org/D33820 Files: lib/Driver/ToolChains/Arch/PPC.cpp lib/Driver/ToolChains/Arch/PPC.h lib/Driver/ToolChains/Gnu.cpp

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

rsmith updated this revision to Diff 101157. rsmith marked an inline comment as done. rsmith added a comment. Rebased and added requested test. https://reviews.llvm.org/D33703 Files: docs/Modules.rst include/clang/Basic/DiagnosticLexKinds.td

[PATCH] D33108: Generate extra .ll files before/after optimization when using -save-temps.

jgorbe added inline comments. Comment at: lib/Driver/Driver.cpp:2603-2614 + // lipo-able. + if (!MultiArchUniversalBuild) { +if (isSaveTempsEnabled() && Phase == phases::Compile) { + Actions.push_back( + C.MakeAction(Current,

[PATCH] D32520: Support __fp16 vectors

bruno added a comment. Hi Akira, This is nice, thanks for doing it! Comment at: include/clang/Sema/Sema.h:9270 + QualType RHSType, + bool CompAssign = false); Can

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

compnerd added inline comments. Comment at: test/Driver/linux-ld.c:467-471 +// RUN: %clang %s -### -o %t.o 2>&1 --target=x86_64-everest-linux +// RUN: %clang %s -### -o %t.o 2>&1 --target=x86_64-pure64-linux +// RUN: %clang %s -### -o %t.o 2>&1 --target=i686-isoft-linux +// RUN:

r304519 - Minor fixes to for-loop warning.

Author: rtrieu Date: Thu Jun 1 23:24:46 2017 New Revision: 304519 URL: http://llvm.org/viewvc/llvm-project?rev=304519=rev Log: Minor fixes to for-loop warning. The warning for unchanged loop variables outputted a diagnostic that was dependent on iteration order from a pointer set, which is not

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 marked 8 inline comments as done. jyu2 added inline comments. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:334 + continue; +else + HasThrowOutFunc = true; aaron.ballman wrote: > You can drop the `else` here and just set `HasThrowOutFunc` to

[PATCH] D33703: Support lazy stat'ing of files referenced by module maps

rsmith added a comment. In https://reviews.llvm.org/D33703#770896, @bruno wrote: > - I've noticed in the patch that on the ASTWriter side we serialize the > introduced size / mtime, but there are no changes to the ASTReader, so I > assume in the reader side you still need the module map around

r304506 - PR32848: There isn't necessarily a FileChanged or FileSkipped for every InclusionDirective callback.

Author: rsmith Date: Thu Jun 1 20:05:44 2017 New Revision: 304506 URL: http://llvm.org/viewvc/llvm-project?rev=304506=rev Log: PR32848: There isn't necessarily a FileChanged or FileSkipped for every InclusionDirective callback. In particular, you don't get one if the inclusion directive

[PATCH] D33820: [PowerPC] Pass CPU to assembler with -no-integrated-as

nemanjai created this revision. This just adds the CPU to a list of commands passed to GAS when not using the integrated assembler. Repository: rL LLVM https://reviews.llvm.org/D33820 Files: lib/Driver/ToolChains/Arch/PPC.cpp lib/Driver/ToolChains/Arch/PPC.h

Re: r304459 - [ubsan] Add a check for pointer overflow UB

Taking a look. vedant > On Jun 1, 2017, at 2:45 PM, Galina Kistanova wrote: > > Hello Vedant, > > This commit broke tests on some of our builders: > > Failing Tests (1): > Clang :: CodeGen/ubsan-pointer-overflow.m > >

r304486 - Relax test to try and appease builders. NFC.

Author: vedantk Date: Thu Jun 1 17:27:39 2017 New Revision: 304486 URL: http://llvm.org/viewvc/llvm-project?rev=304486=rev Log: Relax test to try and appease builders. NFC. I'm not sure why, but on some bots, the order of two instructions are swapped (as compared to the output on my machine).

Re: r304459 - [ubsan] Add a check for pointer overflow UB

I checked in r304486 to try and address the issue. thanks, vedant > On Jun 1, 2017, at 3:21 PM, Vedant Kumar via cfe-commits > wrote: > > Taking a look. > > vedant > >> On Jun 1, 2017, at 2:45 PM, Galina Kistanova >

[libcxx] r304487 - [test] Allow non-libc++ coroutine_handle::done to strengthen noexcept

Author: caseycarter Date: Thu Jun 1 17:40:16 2017 New Revision: 304487 URL: http://llvm.org/viewvc/llvm-project?rev=304487=rev Log: [test] Allow non-libc++ coroutine_handle::done to strengthen noexcept Modified:

r304470 - [CGDebugInfo] Finalize SubPrograms when we're done with them

Author: kfischer Date: Thu Jun 1 16:14:03 2017 New Revision: 304470 URL: http://llvm.org/viewvc/llvm-project?rev=304470=rev Log: [CGDebugInfo] Finalize SubPrograms when we're done with them `GenerateVarArgsThunk` in `CGVTables` clones a function before the frontend is done emitting the

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

This revision was automatically updated to reflect the committed changes. Closed by commit rL304470: [CGDebugInfo] Finalize SubPrograms when we're done with them (authored by kfischer). Changed prior to commit: https://reviews.llvm.org/D33705?vs=101092=101107#toc Repository: rL LLVM

r304472 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:15:34 2017 New Revision: 304472 URL: http://llvm.org/viewvc/llvm-project?rev=304472=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseDecl.cpp Modified:

r304478 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:26:38 2017 New Revision: 304478 URL: http://llvm.org/viewvc/llvm-project?rev=304478=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseOpenMP.cpp Modified:

[PATCH] D33692: [ThinLTO] Wire up ThinLTO and new PM

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. This patch LGTM whenever the underlying LLVM change lands, thanks https://reviews.llvm.org/D33692 ___ cfe-commits mailing list

Re: [PATCH] D33424: Lexer: allow imaginary constants in GNU mode (only).

On 26 May 2017 at 11:29, Richard Smith wrote: > If we generally think that distinction is a good thing, then (because this > is a conforming extension) consistency weakly suggests that it should not be > controlled by GNU mode. But I don't find that argument decisive; the >

[PATCH] D33692: [ThinLTO] Migrate ThinLTOBitcodeWriter to the new PM.

timshen updated this revision to Diff 101106. timshen added a comment. Rebase the patch onto https://reviews.llvm.org/D33799. https://reviews.llvm.org/D33692 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thin_link_bitcode.c Index: clang/test/CodeGen/thin_link_bitcode.c

r304473 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:19:06 2017 New Revision: 304473 URL: http://llvm.org/viewvc/llvm-project?rev=304473=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp Modified:

r304475 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:21:49 2017 New Revision: 304475 URL: http://llvm.org/viewvc/llvm-project?rev=304475=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseExpr.cpp Modified:

r304477 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:23:52 2017 New Revision: 304477 URL: http://llvm.org/viewvc/llvm-project?rev=304477=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseInit.cpp Modified:

r304479 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:28:26 2017 New Revision: 304479 URL: http://llvm.org/viewvc/llvm-project?rev=304479=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseStmt.cpp Modified:

r304481 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:29:45 2017 New Revision: 304481 URL: http://llvm.org/viewvc/llvm-project?rev=304481=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseTentative.cpp Modified:

[PATCH] D33721: [ARM] Add support for target("arm") and target("thumb").

echristo added inline comments. Comment at: lib/Basic/Targets.cpp:5439-5442 +// [-|+]thumb-mode target features respectively. +std::vector UpdatedFeaturesVec(FeaturesVec); +for (auto : UpdatedFeaturesVec) { + if (Feature.compare("+arm") == 0)

[PATCH] D33692: [ThinLTO] Wire up ThinLTO and new PM

davide added a comment. LGTM once the other patch lands. https://reviews.llvm.org/D33692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r304391 - Adapt tests after making mcpu=generic the default for armv7-a and armv8-a.

Author: kbeyls Date: Thu Jun 1 02:31:50 2017 New Revision: 304391 URL: http://llvm.org/viewvc/llvm-project?rev=304391=rev Log: Adapt tests after making mcpu=generic the default for armv7-a and armv8-a. Modified: cfe/trunk/test/Driver/arm-cortex-cpus.c cfe/trunk/test/Driver/gold-lto.c

[PATCH] D33398: Mangle __unaligned in Itanium ABI

rogfer01 updated this revision to Diff 100974. rogfer01 added a comment. Changelog: - Fix formatting. - Emit `__unaligned` in the right order (as defined by the Itanium ABI) when there are Objective-C++ ARC vendor qualifiers. - New test for `__unaligned` and ARC's `__weak`, `__strong` and

[PATCH] D33437: Emit available_externally vtables opportunistically

This revision was automatically updated to reflect the committed changes. Closed by commit rL304394: Emit available_externally vtables opportunistically (authored by Prazek). Changed prior to commit: https://reviews.llvm.org/D33437?vs=100641=100976#toc Repository: rL LLVM

r304394 - Emit available_externally vtables opportunistically

Author: prazek Date: Thu Jun 1 03:04:05 2017 New Revision: 304394 URL: http://llvm.org/viewvc/llvm-project?rev=304394=rev Log: Emit available_externally vtables opportunistically Summary: We can emit vtable definition having inline function if they are all emitted. Reviewers: rjmccall, rsmith

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

chrib added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:569 + if (Triple.getEnvironment() == llvm::Triple::EABI) { +switch (Triple.getArch()) { efriedma wrote: > Specifically checking for "llvm::Triple::EABI" is suspicious... what are you

[PATCH] D31830: Emit invariant.group.barrier when using union field

Prazek updated this revision to Diff 100977. Prazek marked an inline comment as done. Prazek added a comment. Extra test https://reviews.llvm.org/D31830 Files: lib/CodeGen/CGExpr.cpp test/CodeGenCXX/strict-vtable-pointers.cpp Index: test/CodeGenCXX/strict-vtable-pointers.cpp

[PATCH] D33398: Mangle __unaligned in Itanium ABI

rogfer01 added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:2210 + if (Quals.hasUnaligned()) + mangleVendorQualifier("__unaligned"); + rsmith wrote: > Too much indentation here. Also, the ABI requires the "unordered" vendor > qualifiers to be

[PATCH] D33412: Add support for #pragma clang section

rogfer01 added a comment. After the docs update this looks good to me. @rnk @jroelofs what do you think? Thanks! https://reviews.llvm.org/D33412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33597: [OpenCL] Fix pipe size in TypeInfo.

yaxunl added a comment. In https://reviews.llvm.org/D33597#770137, @Anastasia wrote: > Use global AS pointer for pipe size. > > @Sam, I am moving you to the reviewer to finish this change. Do you think it > makes sense to add RUN line with some AMD GPU in triple to the test? I would

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

aaron.ballman added a comment. In https://reviews.llvm.org/D3#768332, @jyu2 wrote: > Okay this CFG version of this change. In this change I am basic using same > algorithm with -Winfinite-recursion. > > In addition to my original implementation, I add handler type checking which > basic

[PATCH] D33739: [Sema] Improve -Wstrict-prototypes diagnostic message for blocks

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D33739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxxabi] r304426 - Creating release candidate rc2 from release_401 branch

Author: tstellar Date: Thu Jun 1 11:29:45 2017 New Revision: 304426 URL: http://llvm.org/viewvc/llvm-project?rev=304426=rev Log: Creating release candidate rc2 from release_401 branch Added: libcxxabi/tags/RELEASE_401/rc2/ (props changed) - copied from r304425,

[libunwind] r304432 - Creating release candidate rc2 from release_401 branch

Author: tstellar Date: Thu Jun 1 11:30:02 2017 New Revision: 304432 URL: http://llvm.org/viewvc/llvm-project?rev=304432=rev Log: Creating release candidate rc2 from release_401 branch Added: libunwind/tags/RELEASE_401/rc2/ (props changed) - copied from r304431,

[PATCH] D33108: Generate extra .ll files before/after optimization when using -save-temps.

tra added inline comments. Comment at: lib/Driver/Driver.cpp:2603-2614 + // lipo-able. + if (!MultiArchUniversalBuild) { +if (isSaveTempsEnabled() && Phase == phases::Compile) { + Actions.push_back( + C.MakeAction(Current,

[PATCH] D33597: [OpenCL] Fix pipe size in TypeInfo.

Anastasia updated this revision to Diff 101031. Anastasia edited reviewers, added: yaxunl; removed: echuraev. Anastasia removed a subscriber: yaxunl. Anastasia added a comment. Use global AS pointer for pipe size. @Sam, I am moving you to the reviewer to finish this change. Do you think it

[libcxx] r304425 - Creating release candidate rc2 from release_401 branch

Author: tstellar Date: Thu Jun 1 11:29:42 2017 New Revision: 304425 URL: http://llvm.org/viewvc/llvm-project?rev=304425=rev Log: Creating release candidate rc2 from release_401 branch Added: libcxx/tags/RELEASE_401/rc2/ (props changed) - copied from r304424,

[PATCH] D31830: Emit invariant.group.barrier when using union field

rjmccall accepted this revision. rjmccall added a comment. Thanks, LGTM. https://reviews.llvm.org/D31830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33537: [clang-tidy] Exception Escape Checker

aaron.ballman added a comment. In https://reviews.llvm.org/D33537#765445, @baloghadamsoftware wrote: > In https://reviews.llvm.org/D33537#764834, @Prazek wrote: > > > How is that compared to https://reviews.llvm.org/D19201 and the clang patch > > mentioned in this patch? > > > Actually, this

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

schroedersi added a comment. Ping :) https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33721: [ARM] Add support for target("arm") and target("thumb").

fhahn updated this revision to Diff 100994. fhahn added a comment. Agreed, ARMTargetInfo is a much better place to do the conversion! Moved attribute conversion to ARMTargetInfo::initFeatureMap. Unfortunately FeaturesVec is const, so creating a mutable clone seemed the most straight-forward

r304397 - Fixed warnings

Author: prazek Date: Thu Jun 1 04:24:36 2017 New Revision: 304397 URL: http://llvm.org/viewvc/llvm-project?rev=304397=rev Log: Fixed warnings Modified: cfe/trunk/include/clang/AST/VTableBuilder.h cfe/trunk/lib/CodeGen/CodeGenModule.cpp Modified:

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

krasimir added a comment. I think that what you're trying to solve is not practically that important, is unlikely to improve the handling of comments, and will add a lot of complexity. From a usability perspective, I think that people are happy enough when their comments don't exceed the line

[PATCH] D33765: Show correct column nr. when multi-byte utf8 chars are used.

erikjv created this revision. Previously, the column number in a diagnostic would be the byte position in the line. This results in incorrect column numbers when a multi-byte UTF-8 character would be present in the input. By ignoring all bytes starting with 0b10 the correct column number is

[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

NoQ added a comment. I have just one comment and i think it'd be good to land. Comment at: lib/StaticAnalyzer/Core/CheckerHelpers.cpp:104 + ProgramStateManager = State->getStateManager(); + if (!LHSVal.getAs() && LHSVal.getAs()) { +LHSVal =

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

aaron.ballman added a comment. Can you help me to understand what problem is being solved with this new attribute? Under what circumstances would the first argument be an `ImplicitParamDecl` but not an implicit this or self? https://reviews.llvm.org/D33735

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

ABataev added a comment. In https://reviews.llvm.org/D33735#770333, @rjmccall wrote: > In https://reviews.llvm.org/D33735#770318, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D33735#770296, @ABataev wrote: > > > > > In https://reviews.llvm.org/D33735#770288, @aaron.ballman wrote: > >

Re: r304346 - [modules] When compiling a preprocessed module map, look for headers relative

Hello Richard, This commit broke tests on few of our builders: Failing Tests (2): Clang :: Modules/preprocess-module.cpp Clang :: Modules/preprocess-nested.cpp http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/10199 and

[PATCH] D33726: [driver][netbsd] Build and pass `-L` arguments to the linker

joerg added a comment. A small subset can be found by searching for LINKER_RPATH_FLAG in pkgsrc. A classic offender is Emacs. For more, I would have to systematically search. Repository: rL LLVM https://reviews.llvm.org/D33726 ___ cfe-commits

r304449 - [CodeGen][ObjC] Fix assertion failure in EmitARCStoreStrongCall.

Author: ahatanak Date: Thu Jun 1 13:41:25 2017 New Revision: 304449 URL: http://llvm.org/viewvc/llvm-project?rev=304449=rev Log: [CodeGen][ObjC] Fix assertion failure in EmitARCStoreStrongCall. The assertion fails because EmitValueForIvarAtOffset doesn't get the correct type of the ivar when

[PATCH] D33706: CodeGen: Cast temporary variable to proper address space

yaxunl updated this revision to Diff 101070. yaxunl marked 2 inline comments as done. yaxunl retitled this revision from "[AMDGPU] Fix address space for global and temporary variables in C++" to "CodeGen: Cast temporary variable to proper address space". yaxunl edited the summary of this

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

aaron.ballman added a comment. In https://reviews.llvm.org/D33735#770296, @ABataev wrote: > In https://reviews.llvm.org/D33735#770288, @aaron.ballman wrote: > > > Can you help me to understand what problem is being solved with this new > > attribute? Under what circumstances would the first

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

rjmccall added a comment. In https://reviews.llvm.org/D33735#770318, @aaron.ballman wrote: > In https://reviews.llvm.org/D33735#770296, @ABataev wrote: > > > In https://reviews.llvm.org/D33735#770288, @aaron.ballman wrote: > > > > > Can you help me to understand what problem is being solved with

[PATCH] D33765: Show correct column nr. when multi-byte utf8 chars are used.

efriedma added a comment. Correctly counting columns is a bit more complicated that that... for example, consider what happens if you replace `ideëen` with `idez̈en`. See https://stackoverflow.com/questions/3634627/how-to-know-the-preferred-display-width-in-columns-of-unicode-characters .

Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

On Tue, Mar 14, 2017 at 04:00:53AM -, Akira Hatanaka via cfe-commits wrote: > Author: ahatanak > Date: Mon Mar 13 23:00:52 2017 > New Revision: 297702 > > URL: http://llvm.org/viewvc/llvm-project?rev=297702=rev > Log: > [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded >

[PATCH] D31830: Emit invariant.group.barrier when using union field

This revision was automatically updated to reflect the committed changes. Closed by commit rL304448: Emit invariant.group.barrier when using union field (authored by Prazek). Changed prior to commit: https://reviews.llvm.org/D31830?vs=100977=101058#toc Repository: rL LLVM

r304448 - Emit invariant.group.barrier when using union field

Author: prazek Date: Thu Jun 1 13:39:34 2017 New Revision: 304448 URL: http://llvm.org/viewvc/llvm-project?rev=304448=rev Log: Emit invariant.group.barrier when using union field Summary: We need to emit barrier if the union field is CXXRecordDecl because it might have vptrs. The testcode was

r304451 - [SemaCXX] Add diagnostics to require_constant_initialization

Author: kfischer Date: Thu Jun 1 13:54:16 2017 New Revision: 304451 URL: http://llvm.org/viewvc/llvm-project?rev=304451=rev Log: [SemaCXX] Add diagnostics to require_constant_initialization Summary: This hooks up the detailed diagnostics of why constant initialization was not possible if

r304455 - Fixed broken test (strict-vtable-pointers)

Author: prazek Date: Thu Jun 1 14:08:05 2017 New Revision: 304455 URL: http://llvm.org/viewvc/llvm-project?rev=304455=rev Log: Fixed broken test (strict-vtable-pointers) Modified: cfe/trunk/test/CodeGenCXX/strict-vtable-pointers.cpp Modified:

r304456 - Add compatibility alias for -Wno-#warnings

Author: dblaikie Date: Thu Jun 1 14:08:34 2017 New Revision: 304456 URL: http://llvm.org/viewvc/llvm-project?rev=304456=rev Log: Add compatibility alias for -Wno-#warnings GCC uses -Wno-cpp for this, so seems reasonable to add an alias to match. Modified:

[PATCH] D33774: [CodeGen] Make __attribute__(const) calls speculatable

efriedma added a comment. Consider something like this: define i32 @div(i32 %x, i32 %y) { entry: %div = sdiv i32 %x, %y ret i32 %div } We can mark this function readnone, but not speculatable: it doesn't read or write memory, but could exhibit undefined behavior. Consider

[PATCH] D33788: Return a canonical path from getClangResourcePath()

aaron.ballman created this revision. on POSIX systems, CIndexer::getClangResourcesPath() uses dladdr() to get the path of the shared object. It seems that on some systems (in our case, OS X 10.6.8), dladdr() does not return a canonicalized path. We're getting a path like

[PATCH] D24371: Add diagnostics to require_constant_initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rL304451: [SemaCXX] Add diagnostics to require_constant_initialization (authored by kfischer). Changed prior to commit: https://reviews.llvm.org/D24371?vs=100949=101066#toc Repository: rL LLVM

r304445 - Strip trailing whitespace. NFCI.

Author: rksimon Date: Thu Jun 1 13:17:18 2017 New Revision: 304445 URL: http://llvm.org/viewvc/llvm-project?rev=304445=rev Log: Strip trailing whitespace. NFCI. Modified: cfe/trunk/lib/Sema/SemaOverload.cpp Modified: cfe/trunk/lib/Sema/SemaOverload.cpp URL:

[libcxx] r304450 - Remove ubsan XFAILS in two tests

Author: vedantk Date: Thu Jun 1 13:48:27 2017 New Revision: 304450 URL: http://llvm.org/viewvc/llvm-project?rev=304450=rev Log: Remove ubsan XFAILS in two tests These two tests are ubsan-clean now: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/3553/ Modified:

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

efriedma added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:569 + if (Triple.getEnvironment() == llvm::Triple::EABI) { +switch (Triple.getArch()) { chrib wrote: > efriedma wrote: > > Specifically checking for "llvm::Triple::EABI" is

r304408 - Make the clang-cl test less restrictive.

Author: alexfh Date: Thu Jun 1 06:41:21 2017 New Revision: 304408 URL: http://llvm.org/viewvc/llvm-project?rev=304408=rev Log: Make the clang-cl test less restrictive. Make the test less restrictive to allow directory layout used in our test setup. Modified:

[PATCH] D30489: [analyzer] catch out of bounds for VLA

xazax.hun added a comment. In https://reviews.llvm.org/D30489#769916, @NoQ wrote: > An idea. I believe the safest way to find the bugs you mentioned would be to > replace extent-as-a-symbol with extent-as-a-trait. > > I.e., currently we construct `extent_$3{SymRegion{conj_$1{char *}}}`, assume

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

NoQ added a comment. The code looks good now! A few minor comments and we can commit this :) Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2010 + const Expr *Mem = CE->getArg(0); + const Expr *Const = CE->getArg(1); + const Expr *Size = CE->getArg(2);

r304396 - [OpenCL] spir_kern by defaul: fix old test cases

Author: pjaaskel Date: Thu Jun 1 03:19:43 2017 New Revision: 304396 URL: http://llvm.org/viewvc/llvm-project?rev=304396=rev Log: [OpenCL] spir_kern by defaul: fix old test cases Modified: cfe/trunk/test/CodeGenOpenCL/bool_cast.cl cfe/trunk/test/CodeGenOpenCL/kernel-attributes.cl

[PATCH] D33401: [mips] Add runtime options to enable/disable generation of madd.fmt, msub.fmt

smaksimovic updated this revision to Diff 101010. smaksimovic added a comment. Changed feature name from madd4 to nomadd4 to reflect the change from the dependency. Added macro definition when +nomadd4 is present. https://reviews.llvm.org/D33401 Files: include/clang/Driver/Options.td

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai added a comment. Hi Artem, Long time no see! miss you :) I will update my patch next Thursday! I am doing my work assignment about L4 right now. Regards, Leslie Zhai Repository: rL LLVM

[PATCH] D30489: [analyzer] catch out of bounds for VLA

NoQ added a comment. An idea. I believe the safest way to find the bugs you mentioned would be to replace extent-as-a-symbol with extent-as-a-trait. I.e., currently we construct `extent_$3{SymRegion{conj_$1{char *}}}`, assume that it is equal to `reg_$0` (which produces a `SymSymExpr`) and

Re: r304346 - [modules] When compiling a preprocessed module map, look for headers relative

Hi Richard, This broke the tests on the Windows bot: http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/5266 1. FAIL: Clang::preprocess-nested.cpp

[PATCH] D33774: [CodeGen] Make __attribute__(const) calls speculatable

grosser created this revision. Herald added subscribers: javed.absar, wdng. Today 'const' functions are only marked 'readnone' and 'nounwind', but lack the 'speculatable' attribute for historic reasons. As 'const' functions are known to not have any side effects and are intended to enable loop

  1   2   >