r304411 - Increase the limit for the number of DiagnosticLexKinds.td diags.

Author: yrnkrn Date: Thu Jun 1 07:46:59 2017 New Revision: 304411 URL: http://llvm.org/viewvc/llvm-project?rev=304411=rev Log: Increase the limit for the number of DiagnosticLexKinds.td diags. 300 was reached in r304190, 400 should be enough for a while. Modified:

[PATCH] D33398: Mangle __unaligned in Itanium ABI

rsmith accepted this revision. rsmith added a comment. Looks great, thanks! Comment at: lib/AST/ItaniumMangle.cpp:2210 + if (Quals.hasUnaligned()) + mangleVendorQualifier("__unaligned"); + rogfer01 wrote: > rsmith wrote: > > Too much indentation here.

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

aprantl added a comment. Looks good.. Are you also planning to change DIBuilder to not finalize subprograms automatically any more (and not insert them into AllSubprograms)? (That will be the more impactful change as it will force all non-clang frontends to make a similar change).

[PATCH] D33305: [ubsan] Add a check for pointer overflow UB

This revision was automatically updated to reflect the committed changes. Closed by commit rL304459: [ubsan] Add a check for pointer overflow UB (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D33305?vs=100475=101078#toc Repository: rL LLVM

r304459 - [ubsan] Add a check for pointer overflow UB

Author: vedantk Date: Thu Jun 1 14:22:18 2017 New Revision: 304459 URL: http://llvm.org/viewvc/llvm-project?rev=304459=rev Log: [ubsan] Add a check for pointer overflow UB Check pointer arithmetic for overflow. For some more background on this check, see:

Re: r304346 - [modules] When compiling a preprocessed module map, look for headers relative

On 1 June 2017 at 11:10, Galina Kistanova wrote: > Hello Richard, > > This commit broke tests on few of our builders: > > Failing Tests (2): > Clang :: Modules/preprocess-module.cpp > Clang :: Modules/preprocess-nested.cpp > >

r304463 - [Modules] Handle sanitizer feature mismatches when importing modules

Author: vedantk Date: Thu Jun 1 15:01:01 2017 New Revision: 304463 URL: http://llvm.org/viewvc/llvm-project?rev=304463=rev Log: [Modules] Handle sanitizer feature mismatches when importing modules This patch makes it an error to have a mismatch between the enabled sanitizers in a CU, and in any

[PATCH] D32724: [Modules] Handle sanitizer feature mismatches when importing modules

This revision was automatically updated to reflect the committed changes. Closed by commit rL304463: [Modules] Handle sanitizer feature mismatches when importing modules (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D32724?vs=98371=101088#toc Repository: rL LLVM

[libcxx] r304462 - Mark two coroutine tests as unsupported under ubsan

Author: vedantk Date: Thu Jun 1 15:00:40 2017 New Revision: 304462 URL: http://llvm.org/viewvc/llvm-project?rev=304462=rev Log: Mark two coroutine tests as unsupported under ubsan They appear to crash inside of SelectionDAG on some Linux bots, when ubsan is enabled.

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro updated this revision to Diff 101092. loladiro added a comment. Finalize all subprograms when we're done emitting them. The one we're interested in is a side effect, but doing this uniformly might be cleaner and help avoid similar errors in the future. https://reviews.llvm.org/D33705

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro added a comment. @aprantl @dblaikie See if you like this better. https://reviews.llvm.org/D33705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r304346 - [modules] When compiling a preprocessed module map, look for headers relative

On 1 June 2017 at 12:53, Richard Smith wrote: > On 1 June 2017 at 11:10, Galina Kistanova wrote: > >> Hello Richard, >> >> This commit broke tests on few of our builders: >> >> Failing Tests (2): >> Clang :: Modules/preprocess-module.cpp >>

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. I guess this would need a cross-project test case (ie: it'd have to run LLVM optimizations to fail/pass/demonstrate the fix). I think it'd be OK to add one if there's a neat/clean/obvious

r304465 - Don't assume that a store source is a vector type just because the destination is (PR26099)

Author: rksimon Date: Thu Jun 1 15:13:34 2017 New Revision: 304465 URL: http://llvm.org/viewvc/llvm-project?rev=304465=rev Log: Don't assume that a store source is a vector type just because the destination is (PR26099) Added: cfe/trunk/test/CodeGen/pr26099.c Modified:

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro added a comment. There's already such a test case, but the cloning currently doesn't assert properly (but it can generate incorrect code). https://reviews.llvm.org/D33655 fixes that up, so I think the testing is covered once that LLVM commit goes in. I'll hold off a little while to

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro added a comment. I don't think that change is entirely necessary. I don't have any strong objections to it, but I also don't see a good reason to require it. In any case, let me get this in to be able to re-land https://reviews.llvm.org/D33655 and we can revisit the more disruptive

[PATCH] D33797: [coroutines] Fix rebuilding of dependent coroutine parameters

GorNishanov created this revision. We were not handling correctly rebuilding of parameter and were not creating copies for them. With this checking, we will be always rebuilding parameter moves in TreeTransform's TransformCoroutineBodyStmt. https://reviews.llvm.org/D33797 Files:

r304464 - Escape filenames in module map line marker directives, to unbreak Windows build bots.

Author: rsmith Date: Thu Jun 1 15:10:35 2017 New Revision: 304464 URL: http://llvm.org/viewvc/llvm-project?rev=304464=rev Log: Escape filenames in module map line marker directives, to unbreak Windows build bots. Modified: cfe/trunk/lib/Frontend/FrontendActions.cpp

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

ABataev added a comment. In https://reviews.llvm.org/D33735#770288, @aaron.ballman wrote: > Can you help me to understand what problem is being solved with this new > attribute? Under what circumstances would the first argument be an > `ImplicitParamDecl` but not an implicit this or self?

[PATCH] D33588: Fix two sources of UB in __next_hash_pow2 (from __hash_table)

vsk added inline comments. Comment at: include/__hash_table:139 { -return size_t(1) << (std::numeric_limits::digits - __clz(__n-1)); +return (__n > 1) ? (size_t(1) << (std::numeric_limits::digits - __clz(__n-1))) : __n; } EricWF wrote: > Shouldn't

r304444 - Remove late nullptr pointer test (PR32447)

Author: rksimon Date: Thu Jun 1 13:13:02 2017 New Revision: 30 URL: http://llvm.org/viewvc/llvm-project?rev=30=rev Log: Remove late nullptr pointer test (PR32447) IgnoreNarrowingConversion should never return nullptr, but I've added an assert just in case. Modified:

[PATCH] D33698: [CodeGen][ObjC] Fix assertion failure in CodeGenFunction::EmitARCStoreStrongCall

This revision was automatically updated to reflect the committed changes. Closed by commit rL304449: [CodeGen][ObjC] Fix assertion failure in EmitARCStoreStrongCall. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D33698?vs=100787=101060#toc Repository: rL LLVM

Re: [PATCH] D33424: Lexer: allow imaginary constants in GNU mode (only).

On 1 June 2017 at 14:36, Tim Northover wrote: > On 26 May 2017 at 11:29, Richard Smith wrote: > > If we generally think that distinction is a good thing, then (because > this > > is a conforming extension) consistency weakly suggests that it

Re: r304459 - [ubsan] Add a check for pointer overflow UB

Hello Vedant, This commit broke tests on some of our builders: Failing Tests (1): Clang :: CodeGen/ubsan-pointer-overflow.m http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/2865/steps/test-check-all/logs/stdio

[PATCH] D33774: [CodeGen] Make __attribute__(const) calls speculatable

Meinersbur added a comment. Definition of `__attibute__((const))` from https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#Common-Function-Attributes > Many functions do not examine any values except their arguments, and have no > effects except the return value. Basically this

[PATCH] D33776: [libcxx] LWG2221: No formatted output operator for nullptr

K-ballo created this revision. With effects equivalent to `os << (const void*)nullptr`. https://reviews.llvm.org/D33776 Files: include/ostream test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/nullptr_t.pass.cpp www/cxx1z_status.html

<    1   2