pcc added a comment.
Before looking at this patch in detail, can you please explain the need for
this feature? How difficult would it be to change your code to avoid relying on
invalid casts?
https://reviews.llvm.org/D34233
___
cfe-commits
Author: djasper
Date: Thu Jun 15 04:17:12 2017
New Revision: 305456
URL: http://llvm.org/viewvc/llvm-project?rev=305456=rev
Log:
Revert "Define _GNU_SOURCE for rtems c++"
This reverts commit r305399.
This breaks a build in libcxx:
libcxx/src/system_error.cpp:90:16: error: assigning to 'int'
Author: krasimir
Date: Thu Jun 15 04:11:57 2017
New Revision: 305454
URL: http://llvm.org/viewvc/llvm-project?rev=305454=rev
Log:
[clangd] Add priority to completion item sort text
Summary:
This patch adds the priority of a completion item to the sort text of the
returned LSP result.
Reviewers:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305454: [clangd] Add priority to completion item sort text
(authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D34137?vs=102522=102646#toc
Repository:
rL LLVM
ahatanak added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:997
- // Allow bitcast from vector to integer/fp of the same size.
- if (isa(SrcTy) ||
- isa(DstTy))
-return Builder.CreateBitCast(Src, DstTy, "conv");
+ if (isa(SrcTy) || isa(DstTy)) {
+
rogfer01 added inline comments.
Comment at: include/clang/AST/Type.h:1669
bool isHalfType() const; // OpenCL 6.1.1.1, NEON (IEEE 754-2008 half)
+ bool isFloat16Type() const; // FIXME
bool isRealType() const; // C99 6.2.5p17 (real floating + integer)
bader created this revision.
OpenCL and SPIR version metadata must be generated once per module instead of
once per mangled global value.
https://reviews.llvm.org/D34235
Files:
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
lib/CodeGen/TargetInfo.cpp
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
Sorry for the delay, we got stuck because hard coding a certain file pattern
into the clang source code doesn't seem to be a optimal solution (e.g. every
user that has a
SjoerdMeijer updated this revision to Diff 102649.
SjoerdMeijer added a comment.
Thanks Roger. I did the clean up; there were indeed still a few fixmes there.
The good thing is that it's a self-contained clang patch again: we don't need
https://reviews.llvm.org/D34205, which I have abandoned.
v.g.vassilev added a comment.
I agree with Raphael. If you need to have more fine grained control over the
translation unit (TU) I think we can have suppressing false positives via
comments (@Noq would know more).
Eg.
// File.h defining moc_* yields a lot of false positives
//
szdominik marked 3 inline comments as done.
szdominik added inline comments.
Comment at: www/analyzer/alpha_checks.html:91
+(C, C++)
+Check for logical errors for function calls and Objective-C message
+expressions (e.g., uninitialized arguments, null function pointers,
Author: vvassilev
Date: Thu Jun 15 06:05:32 2017
New Revision: 305460
URL: http://llvm.org/viewvc/llvm-project?rev=305460=rev
Log:
Revert "Load lazily the template specialization in multi-module setups."
This broke our libcxx modules builds.
Modified:
v.g.vassilev added a comment.
Reverted in r305460 because broke libcxx modules builds.
https://reviews.llvm.org/D29951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
szdominik updated this revision to Diff 102650.
szdominik added a comment.
Delete modeling checkers (unix.StdCLibraryFunctions, cplusplus.SelfAssignment).
Delete unix.MallocWithAnnotations.
https://reviews.llvm.org/D33645
Files:
www/analyzer/alpha_checks.html
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: test/CodeGenCoroutines/coro-await.cpp:301
+
+// Verifies that we don't chrash when returning an lvalue from a await_resume()
+// expression.
yaxunl added a comment.
LGTM. Thanks.
https://reviews.llvm.org/D34235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz created this revision.
Herald added a subscriber: klimek.
This patch tries to avoid binpacking when initializing lists/arrays,
to allow things like:
static int types[] = {
registerType1(),
registerType2(),
registerType3(),
};
std::map x = {
{
Typz added a comment.
This patch is probably not complete, though it works fine in all situations I
could think of: nested initializers, "short" statement (properly merged),
column layout is still performed when needed...
static int types[] = {
SourcePrivate::registerTypes(),
malcolm.parsons added a comment.
Some people write
auto x = std::map{
{ 0, "foo fjakfjaklf kljj" },
{ 1, "bar fjakfjaklf kljj" },
{ 2, "stuff fjakfjaklf kljj" },
};
https://reviews.llvm.org/D34238
___
mclow.lists created this revision.
`__wrap_iter` is an internal libc++ class used to, well, wrap other iterators
(such as pointers) when we need or want an object type.
Mark the operations on `__wrap_iter` as constexpr, so that they can be used in
a constexpr context if the underlying iterator
Author: marshall
Date: Thu Jun 15 09:31:11 2017
New Revision: 305469
URL: http://llvm.org/viewvc/llvm-project?rev=305469=rev
Log:
Add missing include to __bsd_locale_fallbacks.h. Fixes
https://bugs.llvm.org/show_bug.cgi?id=33370
Modified:
libcxx/trunk/include/__bsd_locale_fallbacks.h
ahatanak updated this revision to Diff 102642.
ahatanak marked 3 inline comments as done.
ahatanak added a comment.
Herald added a subscriber: kristof.beyls.
Address review comments.
https://reviews.llvm.org/D32520
Files:
include/clang/Sema/Sema.h
lib/CodeGen/CGExprScalar.cpp
dtemirbulatov updated this revision to Diff 102673.
dtemirbulatov added a reviewer: hfinkel.
dtemirbulatov added a comment.
Update after http://lists.llvm.org/pipermail/llvm-dev/2017-June/114120.html.
Added 0x1b(_CMP_FALSE_OS), 0x1f(_CMP_TRUE_US) handling.
https://reviews.llvm.org/D33406
a.sidorin added a comment.
Hello Peter,
`if (!ToDecl) return nullptr;` is used if original node is always non-null.
`if(!ToDecl && FromDecl) return nullptr;` is used if original node can be null.
If the imported node is null, the result of import is null as well so such
import is OK.
GorNishanov added inline comments.
Comment at: test/CodeGenCoroutines/coro-await.cpp:310
+ int& x = co_await a;
+ // CHECK: await2.ready:
+ // CHECK-NEXT: %[[RES2:.+]] = call dereferenceable(4) i32*
Author: pcc
Date: Thu Jun 15 12:26:13 2017
New Revision: 305482
URL: http://llvm.org/viewvc/llvm-project?rev=305482=rev
Log:
Apply summary-based dead stripping to regular LTO modules with summaries.
If a regular LTO module has a summary index, then instead of linking
it into the combined regular
zaks.anna added a comment.
> -(Anna) Scan-build-py integration of the functionality is nearly finished
> (see https://github.com/rizsotto/scan-build/issues/83) (--ctu switch performs
> both analysis phases at once). This I think could go in a different patch,
> but until we could keep the
Author: ericwf
Date: Thu Jun 15 15:18:10 2017
New Revision: 305500
URL: http://llvm.org/viewvc/llvm-project?rev=305500=rev
Log:
Use _LIBCPP_FALLTHROUGH() to avoid warnings about [[gnu::fallthrough]] being
unsupported
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
Modified:
Thanks for the heads up! Fixed in 305491. Turns out a function that
AllocateMacroInfo returns a pointer, but the PP still owns it.
MacroArgs::create returns a pointer, and expects the user to delete it. I
added a unique_ptr with a custom delete to call the macro-args 'destroy'
function.
EricWF updated this revision to Diff 102705.
EricWF added a comment.
- Fix the test when -discard-value-names is present, at least my part of the
test.
https://reviews.llvm.org/D34194
Files:
lib/AST/ExprClassification.cpp
lib/CodeGen/CGCoroutine.cpp
lib/CodeGen/CGExpr.cpp
ajbennieston updated this revision to Diff 102707.
ajbennieston added a comment.
Fixes for review comments.
https://reviews.llvm.org/D34091
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_exception_specification_kind.py
include/clang-c/Index.h
the bots complain about a leak in the new test code.
Please fix/revert ASAP.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/5691/steps/check-clang%20asan/logs/stdio
=28905==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 216 byte(s) in 1 object(s) allocated from:
tobiasvk added a comment.
In https://reviews.llvm.org/D34156#781415, @pcc wrote:
> Please confirm that we can still self host with full LTO now that
> https://reviews.llvm.org/D33922 has landed.
Good point. And the answer seems to be no :/
ld.lld: .../llvm/lib/Linker/IRMover.cpp:242:
yaxunl added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:1041
+default:
+ return LangAS::Default;
+}
bader wrote:
> yaxunl wrote:
> > I think the default (including even_t, clk_event_t, queue_t, reserved_id_t)
> > should be global
https://sarcasm.github.io/notes/dev/compilation-database.html#cmake
If you enable the CMAKE_EXPORT_COMPILE_COMMANDS option in cmake (& have a
sufficiently recent cmake), then CMake will generate a
compile_commands.json in the root of the build tree. The test finds this &
fails, instead of finding
teemperor updated this revision to Diff 102700.
teemperor marked an inline comment as done.
teemperor added a comment.
- made saveHash static.
https://reviews.llvm.org/D34182
Files:
include/clang/Analysis/CloneDetection.h
lib/Analysis/CloneDetection.cpp
Author: ericwf
Date: Thu Jun 15 15:00:54 2017
New Revision: 305498
URL: http://llvm.org/viewvc/llvm-project?rev=305498=rev
Log:
[coroutines] Remove pass-through operator co_await; Replace it with the input
expression
Reviewers: GorNishanov, rsmith
Reviewed By: GorNishanov
Differential
Author: ddcc
Date: Thu Jun 15 12:05:07 2017
New Revision: 305480
URL: http://llvm.org/viewvc/llvm-project?rev=305480=rev
Log:
[analyzer]: Improve test handling with multiple constraint managers
Summary: Modify the test infrastructure to properly handle tests that require
z3, and merge together
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305480: [analyzer]: Improve test handling with multiple
constraint managers (authored by ddcc).
Changed prior to commit:
https://reviews.llvm.org/D33308?vs=99394=102682#toc
Repository:
rL LLVM
Ah, right… This function mallocs, and is usually tossed in the Preprocessor
Cache, but I’m doing an end-run around that this time. I’ll see if it is
better to put it into the PP Cache, or just call ‘free’ on it.
Thanks!
-Erich
From: Kostya Serebryany [mailto:k...@google.com]
Sent: Thursday,
Author: ericwf
Date: Thu Jun 15 14:43:36 2017
New Revision: 305496
URL: http://llvm.org/viewvc/llvm-project?rev=305496=rev
Log:
[coroutines] Allow co_await and co_yield expressions that return an lvalue to
compile
Summary:
The title says it all.
Reviewers: GorNishanov, rsmith
Reviewed By:
GorNishanov requested changes to this revision.
GorNishanov added inline comments.
This revision now requires changes to proceed.
Comment at: lib/CodeGen/CGCoroutine.cpp:255
+
+static QualType getCoroutineSuspendExprReturnType(const ASTContext ,
+ const CoroutineSuspendExpr *E)
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM with changes
https://reviews.llvm.org/D34194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
Please confirm that we can still self host with full LTO now that
https://reviews.llvm.org/D33922 has landed.
LGTM otherwise. Thanks!
https://reviews.llvm.org/D34156
Author: erichkeane
Date: Thu Jun 15 13:34:47 2017
New Revision: 305491
URL: http://llvm.org/viewvc/llvm-project?rev=305491=rev
Log:
LexerTest memory leak fix-
A new LexerTest unittest introduced a memory leak. This patch
uses a unique_ptr with a custom deleter to ensure it is properly
deleted.
kcc added a comment.
the bots complain about a leak in the new test code.
Please fix/revert ASAP.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/5691/steps/check-clang%20asan/logs/stdio
28905==ERROR: LeakSanitizer: detected memory leaks
EricWF updated this revision to Diff 102701.
EricWF added a comment.
- Address most inline comments.
https://reviews.llvm.org/D34194
Files:
lib/AST/ExprClassification.cpp
lib/CodeGen/CGCoroutine.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks fine - thanks
https://reviews.llvm.org/D34052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
On Mon, Jun 12, 2017 at 9:15 PM Dean Michael Berris via Phabricator <
revi...@reviews.llvm.org> wrote:
> dberris added a reviewer: dblaikie.
> dberris added a subscriber: dblaikie.
> dberris added a comment.
>
> @dblaikie -- do you have time to have a look?
>
Sure sure - no need to ping a patch
egoktas added a comment.
To address pcc's questions, I have sent an email to llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2017-June/114168.html.
https://reviews.llvm.org/D34233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
GorNishanov added a comment.
Added John McCall as he made great suggestions last time I touched
emitSuspendExpression
https://reviews.llvm.org/D34194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yawanng updated this revision to Diff 102690.
yawanng added a comment.
Format change.
https://reviews.llvm.org/D33304
Files:
clang-tidy/CMakeLists.txt
clang-tidy/android/AndroidTidyModule.cpp
clang-tidy/android/CMakeLists.txt
clang-tidy/android/FileOpenFlagCheck.cpp
EricWF marked 2 inline comments as done.
EricWF added inline comments.
Comment at: test/CodeGenCoroutines/coro-await.cpp:310
+ int& x = co_await a;
+ // CHECK: await2.ready:
+ // CHECK-NEXT: %[[RES2:.+]] = call dereferenceable(4) i32*
dtemirbulatov updated this revision to Diff 102717.
dtemirbulatov added a comment.
Update formatting, comments
https://reviews.llvm.org/D33406
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/avx-builtins.c
Index: test/CodeGen/avx-builtins.c
Author: gkistanova
Date: Thu Jun 15 16:01:24 2017
New Revision: 305507
URL: http://llvm.org/viewvc/llvm-project?rev=305507=rev
Log:
Added braces to work around gcc warning in googletest: suggest explicit braces
to avoid ambiguous 'else'. NFC.
Modified:
arphaman created this revision.
r300667 added support for editor placeholder to Clang. That commit didn’t take
into account that users who use Clang for preprocessing only (-E) will get the
“editor placeholder in source file” error when preprocessing their source
(PR33394).
This commit
jyu2 marked 7 inline comments as done.
jyu2 added inline comments.
Comment at: lib/Sema/AnalysisBasedWarnings.cpp:296
+
+ if (ThrowType->isReferenceType())
+ThrowType = ThrowType->castAs()
aaron.ballman wrote:
> If `ThrowType` can be null, there should be a
> On Jul 20, 2016, at 22:31, Marshall Clow via cfe-commits
> wrote:
>
> Modified: libcxx/trunk/include/string
> URL:
> http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/string?rev=276238=276237=276238=diff
>
Author: arphaman
Date: Thu Jun 15 16:19:01 2017
New Revision: 305508
URL: http://llvm.org/viewvc/llvm-project?rev=305508=rev
Log:
[index] Record C++17 global binding declarations
The global C++17 binding declarations should be indexed as variable symbols.
Differential Revision:
ahatanak added inline comments.
Comment at: lib/Parse/ParseObjc.cpp:220
CheckNestedObjCContexts(AtLoc);
+ if (isEofOrEom())
+return nullptr;
Do you need this check here (and below)?
Comment at: lib/Parse/ParseObjc.cpp:3674
+
+ //
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305504: [index] Index static_assert declarations (authored
by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D33913?vs=101458=102720#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305508: [index] Record C++17 global binding declarations
(authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D33920?vs=101478=102722#toc
Repository:
rL LLVM
EricWF added inline comments.
Comment at: src/experimental/filesystem/operations.cpp:23-28
+// We can use the presence of UTIME_OMIT to detect platforms that do not
+// provide utimensat, with some exceptions on OS X.
+#if !defined(UTIME_OMIT) || \
+
jyu2 updated this revision to Diff 102759.
jyu2 marked 13 inline comments as done.
https://reviews.llvm.org/D3
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/AnalysisBasedWarnings.cpp
test/CXX/except/except.spec/p11.cpp
test/SemaCXX/warn-throw-out-noexcept-func.cpp
arphaman created this revision.
This patch adds a new warning flag called `-Wunguarded-availability-new`. If
`-Wunguarded-availability` is off, this warning only warns about uses of APIs
that have been introduced in macOS >= 10.13, iOS >= 11, watchOS >= 4 and tvOS
>= 11. This warning is on by
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good, and I did ask Richard about this in person before filing the bug
and he was in favor of it, so feel free to commit. If I'd known how easy it was
to implement and how few tests it would
arphaman updated this revision to Diff 102718.
arphaman added a comment.
Use the 'Eof' token to make sure that the "expected '}'" error is presented not
at the end of the file, but at the start of the `@interface`/`@implementation`.
Repository:
rL LLVM
https://reviews.llvm.org/D34185
bcraig added a comment.
ping
https://reviews.llvm.org/D32411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dciliske created this revision.
Herald added a subscriber: klimek.
The Format library has no way to specify a specific file to be used as the
style source. It climbs the path looking for ‘.clang_format’. This patch adds
the ability to specify a specific file to use for clang Format utilities.
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D33406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
On Tue, Jun 13, 2017 at 8:13 PM, Bruno Cardoso Lopes
wrote:
> On Mon, Jun 12, 2017 at 2:01 PM, Erik Schwiebert via cfe-commits
> wrote:
>> SGTM too. Regarding Duncan's last question -- I can't think of any such
>> customer. :) If you all
arphaman updated this revision to Diff 102764.
arphaman added a comment.
Fair enough. I removed the special checks for `<#>` and `<##>`.
Repository:
rL LLVM
https://reviews.llvm.org/D34256
Files:
include/clang/Lex/PreprocessorOptions.h
lib/Frontend/CompilerInvocation.cpp
ahatanak created this revision.
The option allows disabling just the warning about non-throwing exception
specification in function signature instead of disabling all c++1z
compatibility warnings with -Wno-c++1z-compat.
I'm not sure "-Wc++1z-compat-exception-spec" sounds right.
Maybe
benlangmuir added a comment.
I agree with not detecting these during PP-only, but there's nothing wrong with
`<#>`. It's either not a placeholder, or it's part of a placeholder like
`<#>#>`, which is a placeholder containing the text ">". Similarly, `<##`
could be the start of an empty
vsk created this revision.
Skip checks for null dereference, alignment violation, object size
violation, and dynamic type violation if the pointer points to volatile
data.
https://bugs.llvm.org/show_bug.cgi?id=33081
https://reviews.llvm.org/D34262
Files:
lib/CodeGen/CGExpr.cpp
EricWF added a comment.
Could you re-upload this with a updated diff against trunk, and one with more
context.
https://reviews.llvm.org/D34237
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ddcc added inline comments.
Comment at: lib/StaticAnalyzer/Core/SValBuilder.cpp:356
QualType ResultTy) {
- if (!State->isTainted(RHS) && !State->isTainted(LHS))
-return UnknownVal();
zaks.anna wrote:
> I am concerned that
akyrtzi created this revision.
This is useful for being able to parse the preprocessor directive blocks even
the header that defined the macro that they check for hasn't been included.
https://reviews.llvm.org/D34263
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/PPDirectives.cpp
Author: ericwf
Date: Thu Jun 15 19:36:17 2017
New Revision: 305536
URL: http://llvm.org/viewvc/llvm-project?rev=305536=rev
Log:
Allow coroutine_handle to support creation from const references to
the promise_type
It seems conceivable that a user would need to get a coroutine handle
having only
EricWF created this revision.
This fixes llvm.org/PR33469.
https://reviews.llvm.org/D34249
Files:
src/experimental/filesystem/operations.cpp
Index: src/experimental/filesystem/operations.cpp
===
---
Author: arphaman
Date: Thu Jun 15 15:50:43 2017
New Revision: 305504
URL: http://llvm.org/viewvc/llvm-project?rev=305504=rev
Log:
[index] Index static_assert declarations
static_assert declarations have to be visited while indexing so that we can
gather the references to declarations that are
Author: arphaman
Date: Thu Jun 15 16:40:54 2017
New Revision: 305511
URL: http://llvm.org/viewvc/llvm-project?rev=305511=rev
Log:
[Completion] Code complete the members for a dependent type after a '::'
This commit is a follow up to r302797 which added support for dependent
completions after the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305511: [Completion] Code complete the members for a
dependent type after a '::' (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D34173?vs=102410=102724#toc
Repository:
rL
bcraig abandoned this revision.
bcraig added a comment.
This is very stale at this point, and isn't blocking anything. Closing.
https://reviews.llvm.org/D20596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman added inline comments.
Comment at: include/clang-c/Index.h:213
+ /**
+ * \brief The exception specification has not yet been evaluated
+ */
This comment is now missing the full-stop at the end of the sentence (you
dropped one too many
dexonsmith added a comment.
This is the right idea, although it only covers macOS.
Any ideas for how to test this?
Comment at: src/experimental/filesystem/operations.cpp:23-28
+// We can use the presence of UTIME_OMIT to detect platforms that do not
+// provide utimensat,
jyu2 updated this revision to Diff 102754.
jyu2 added a comment.
Address Aaron's comments.
https://reviews.llvm.org/D3
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/AnalysisBasedWarnings.cpp
test/CXX/except/except.spec/p11.cpp
EricWF added a comment.
A large portion of this patch is UB. Any function that unconditionally calls
`__get_db()` can never be a valid constant expression, hence UB.
Is there a smaller set of operations or `__wrap_iter` that *must* be made
constexpr? Or do they all need to be?
kulpreet created this revision.
- Added in new iOS and macOS APIs that require a localized string
- Ran unit tests
Repository:
rL LLVM
https://reviews.llvm.org/D34266
Files:
lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp
Index: lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp
xiangzhai updated this revision to Diff 102777.
xiangzhai added a comment.
Herald added a subscriber: xazax.hun.
Dear Raphael,
Thanks for your suggestion!
> Would it solve your use case if allow specifying file patterns via the
> command line like this -analyzer-config
Fixed!
alexshap updated this revision to Diff 102781.
alexshap added a comment.
minor update
Repository:
rL LLVM
https://reviews.llvm.org/D34268
Files:
include/clang/Edit/EditedSource.h
lib/Edit/EditedSource.cpp
test/FixIt/fixit-format-darwin.m
Index: test/FixIt/fixit-format-darwin.m
EricWF updated this revision to Diff 102783.
EricWF marked an inline comment as done.
EricWF added a comment.
- Address inline comments.
https://reviews.llvm.org/D34249
Files:
src/experimental/filesystem/operations.cpp
Index: src/experimental/filesystem/operations.cpp
EricWF updated this revision to Diff 102782.
https://reviews.llvm.org/D34249
Files:
src/experimental/filesystem/operations.cpp
Index: src/experimental/filesystem/operations.cpp
===
--- src/experimental/filesystem/operations.cpp
erik.pilkington added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:7315
+ default:
+assert(!Triple.isMacOSX() && "MacOS should be handled in the switch");
+// New targets should always warn about availability.
This assert seems a bit
Ah, also the enable_if for same:
> template
> _LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS
> basic_string(const _Tp& __t, size_type __pos, size_type __n,
> const allocator_type& __a = allocator_type(),
> typename
>
I should mention that depends on C++17
string_view in older dialects :-S
So this change will break that.
I would prefer to fix your specific use case by making
std::experimental::string_view literally be
std::string_view.
/Eric
On Thu, Jun 15, 2017 at 8:42 PM, Eric Fiselier
I would also want to do serious performance analysis on this patch. Does
removing the string_view overloads cause less optimal overloads to be
chosen? Perhaps allocating ones?
That would be really unfortunate, and I'm not sure that's in the best
interest of our users at large.
/Eric
On Thu, Jun
vlad.tsyrklevich updated this revision to Diff 102765.
vlad.tsyrklevich added a comment.
Herald added a subscriber: xazax.hun.
Updates to cleanly rebase on a recent clang master. Ran all tests with ASan to
ensure I avoided a broken build post-merge as with
https://reviews.llvm.org/D30909
Author: vedantk
Date: Thu Jun 15 22:27:36 2017
New Revision: 305546
URL: http://llvm.org/viewvc/llvm-project?rev=305546=rev
Log:
[ubsan] PR33081: Skip the standard type checks for volatile
Skip checks for null dereference, alignment violation, object size
violation, and dynamic type violation if
vsk added a comment.
Thanks for the review. I'll make the suggested test changes and commit.
https://reviews.llvm.org/D34262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 129 matches
Mail list logo