[PATCH] D34277: [analyzer] Bump default performance thresholds?

a.sidorin added a comment. Hi Artem, Could you tell what code bases did you use to collect your statistics? I'll try to check the patch on our code bases. I think we should be careful about default settings. Maybe we should introduce another UMK_* for deeper analysis instead?

[PATCH] D33645: [analyzer] Add missing documentation for static analyzer checkers

zaks.anna added inline comments. Comment at: www/analyzer/alpha_checks.html:91 +(C, C++) +Check for logical errors for function calls and Objective-C message +expressions (e.g., uninitialized arguments, null function pointers, szdominik wrote: > zaks.anna

[PATCH] D34286: [clang-tidy] Fix type names in modernize-use-unique/shared_ptr checks.

hokein created this revision. Herald added a subscriber: xazax.hun. If the class being created in unique_ptr is in anonymous nampespace, the anonymous namespace will be included in the apply-fixes. This patch fix this. namespace { class Foo {}; } std::unique_ptr f; f.reset(new Foo());

[PATCH] D34252: Add arbitrary file/path support to clang-format style file selection

dciliske added a comment. So... how should I get something added? That patch has been sitting for a couple weeks. Should I work on that patch? If so, how do I work on it? This is the first time I'm working on a large OSS project. https://reviews.llvm.org/D34252

[PATCH] D34277: [analyzer] Bump default performance thresholds?

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Once Artem gives more details about the codebase he tested on, I think it would be fine to commit this. We can revert/address concerns later if @a.sidorin or anyone else raises concerns

[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

spyffe added a comment. Hmm, the transforming in place of `SelLocs` reads a little weirdly to me, but other than that the code seems fine. Is your concern that you don't know how to write an Objective-C test that would cover this? It looks to me like an Objective-C interface with a method:

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

akyrtzi added inline comments. Comment at: lib/Lex/PPDirectives.cpp:2774 +// the directive blocks. +CurPPLexer->pushConditionalLevel(CI.IfLoc, /*wasskip*/false, + /*foundnonskip*/true, /*foundelse*/true); benlangmuir

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

arphaman added a comment. I find the change to the diagnostic for enum constants a bit off putting, since the warning can refer to the enum itself when an enum constant is used. I'd rather we say something like `'EnumConstant' is deprecated` and keep the note that this patch uses (`'Enum' has

r305586 - Killing a tab and some other spurious whitespace; NFC.

Author: aaronballman Date: Fri Jun 16 15:52:59 2017 New Revision: 305586 URL: http://llvm.org/viewvc/llvm-project?rev=305586=rev Log: Killing a tab and some other spurious whitespace; NFC. Modified: cfe/trunk/lib/Frontend/FrontendActions.cpp Modified:

r305568 - [ubsan] docs: Add a note about pointers to volatile

Author: vedantk Date: Fri Jun 16 13:38:43 2017 New Revision: 305568 URL: http://llvm.org/viewvc/llvm-project?rev=305568=rev Log: [ubsan] docs: Add a note about pointers to volatile Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst Modified:

[PATCH] D34277: [analyzer] Bump default performance thresholds?

zaks.anna added a comment. > Maybe we should introduce another UMK_* for deeper analysis instead? The difference here is not substantial enough to warrant a new level. The general motivation for bumping these numbers is that we've set the timeouts many years ago and the hardware improved quite

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

aaron.ballman added inline comments. Comment at: test/SemaCXX/warn-throw-out-noexcept-func.cpp:1 +// RUN: %clang_cc1 %s -fdelayed-template-parsing -fcxx-exceptions -fexceptions -fsyntax-only -Wexceptions -verify -std=c++11 +struct A { rnk wrote: >

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

rnk added inline comments. Comment at: test/SemaCXX/warn-throw-out-noexcept-func.cpp:1 +// RUN: %clang_cc1 %s -fdelayed-template-parsing -fcxx-exceptions -fexceptions -fsyntax-only -Wexceptions -verify -std=c++11 +struct A { aaron.ballman wrote: > I believe

[PATCH] D34096: [Sema][C++1z] Ensure structured binding's bindings in dependent foreach have non-null type

bebuch reopened this revision. bebuch added a comment. This revision is now accepted and ready to land. I believe this patch is incomplete, I get a very odd warning: struct A{ int x; }; template < typename > struct B{ A data_[1]; void f(){ for(auto [x]:

Re: r284060 - Implement MS _BitScan intrinsics

We should fix it. We just need a new character code in the builtin function prototype encoding. Currently there is no encoding for a portable int32_t that magically becomes "long" on 32-bit Windows. The closest thing we have is 'W', which is used by Neon intrinsics to select between "long" and

[PATCH] D34287: Moved code hanlding precompiled preamble out of the ASTUnit.

ilya-biryukov created this revision. Herald added a subscriber: mgorny. https://reviews.llvm.org/D34287 Files: include/clang/Frontend/ASTUnit.h include/clang/Frontend/PrecompiledPreamble.h lib/Frontend/ASTUnit.cpp lib/Frontend/CMakeLists.txt lib/Frontend/PrecompiledPreamble.cpp Index:

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

akyrtzi updated this revision to Diff 102859. akyrtzi added a comment. Enhanced doc-comment for the preprocessor option, and fixed indentation on a couple of calls. https://reviews.llvm.org/D34263 Files: include/clang/Lex/Preprocessor.h include/clang/Lex/PreprocessorOptions.h

[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

a.sidorin added a comment. Will anybody object if I commit this change without a test? This bug seems to be pretty obvious but, unfortunately, I'm not familiar with Objective C. https://reviews.llvm.org/D6550 ___ cfe-commits mailing list

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

phosek created this revision. When -no-canonical-prefixes option is used and argv0 contains only a program name, we need to do a PATH lookup to get an executable path, otherwise the return value won't be a valid path and any subsequent uses of it (e.g. invoking -cc1) will fail with an error.

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

aaron.ballman added a comment. A few more nits, but this feels like it's getting close to ready (at least, to me). Comment at: test/SemaCXX/warn-throw-out-noexcept-func.cpp:1 +// RUN: %clang_cc1 %s -fdelayed-template-parsing -fcxx-exceptions -fexceptions -fsyntax-only

[PATCH] D34256: [PR33394] Avoid lexing editor placeholders when running the preprocessor only

This revision was automatically updated to reflect the committed changes. Closed by commit rL305576: [PR33394] Avoid lexing editor placeholders when Clang is used only (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D34256?vs=102764=102862#toc Repository: rL LLVM

r305576 - [PR33394] Avoid lexing editor placeholders when Clang is used only

Author: arphaman Date: Fri Jun 16 15:13:39 2017 New Revision: 305576 URL: http://llvm.org/viewvc/llvm-project?rev=305576=rev Log: [PR33394] Avoid lexing editor placeholders when Clang is used only for preprocessing r300667 added support for editor placeholder to Clang. That commit didn’t take

[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

a.sidorin added a comment. Thank you Sean, I'll try. https://reviews.llvm.org/D6550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

benlangmuir added inline comments. Comment at: lib/Lex/PPDirectives.cpp:2774 +// the directive blocks. +CurPPLexer->pushConditionalLevel(CI.IfLoc, /*wasskip*/false, + /*foundnonskip*/true, /*foundelse*/true); akyrtzi

[PATCH] D34277: [analyzer] Bump default performance thresholds?

NoQ added a comment. This was an mixture of internal apple projects (user apps, drivers, deamons, whatever) with a relatively balanced selection of languages and levels of analyzer adoption. They amounted to ~16 hours of analysis CPU time (i.e. 4 hours on a quad-core machine per run). I've

RE: r284060 - Implement MS _BitScan intrinsics

We (Office developers for Apple platforms at Microsoft) would prefer to have the intrinsics work properly for LP64, as that will generate the most optimal and efficient code. That said, we understand that this may be odd to implement from the compiler's perspective and can work around it if the

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

benlangmuir added a comment. It would be nice if the doc comment for the single file parse mode flag was updated to include this new functionality. Comment at: lib/Lex/PPDirectives.cpp:2709 +CurPPLexer->pushConditionalLevel(IfToken.getLocation(), /*wasskip*/true, +

r305574 - Ignore return value in test.

Author: djasper Date: Fri Jun 16 14:29:20 2017 New Revision: 305574 URL: http://llvm.org/viewvc/llvm-project?rev=305574=rev Log: Ignore return value in test. Modified: cfe/trunk/test/Driver/m_and_mm.c Modified: cfe/trunk/test/Driver/m_and_mm.c URL:

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

hans added a comment. Thanks! Please add to the description that this is for PR9576. Comment at: tools/driver/driver.cpp:58 +SmallString<128> ExecutablePath(Argv0); +// Do a PATH lookup, if there are no directory components. +if

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 added inline comments. Comment at: test/SemaCXX/warn-throw-out-noexcept-func.cpp:1 +// RUN: %clang_cc1 %s -fdelayed-template-parsing -fcxx-exceptions -fexceptions -fsyntax-only -Wexceptions -verify -std=c++11 +struct A { aaron.ballman wrote: >

[PATCH] D34286: [clang-tidy] Fix type names in modernize-use-unique/shared_ptr checks.

hokein updated this revision to Diff 102871. hokein added a comment. Update https://reviews.llvm.org/D34286 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp test/clang-tidy/modernize-make-unique.cpp Index: test/clang-tidy/modernize-make-unique.cpp

[PATCH] D33852: Enable __declspec(selectany) on linux

rnk added inline comments. Comment at: include/clang/Basic/Attr.td:2421 -def SelectAny : InheritableAttr, TargetSpecificAttr { +def SelectAny : InheritableAttr, TargetSpecificAttr { let Spellings = [Declspec<"selectany">, GCC<"selectany">]; Prazek wrote: >

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 updated this revision to Diff 102877. jyu2 added a comment. update patch https://reviews.llvm.org/D3 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/AnalysisBasedWarnings.cpp test/CXX/except/except.spec/p11.cpp test/SemaCXX/warn-throw-out-noexcept-func.cpp Index:

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 added inline comments. Comment at: test/SemaCXX/warn-throw-out-noexcept-func.cpp:27 +} + +struct N : A { aaron.ballman wrote: > jyu2 wrote: > > aaron.ballman wrote: > > > Can you add a test case like: > > > ``` > > > struct Throws { > > > ~Throws()

[PATCH] D34294: Rework libcxx strerror_r handling.

krytarowski added a comment. New one is harder to comprehend and less portable (usage of `__atribute__`). Can we just replace #elif defined(__linux__) && !defined(_LIBCPP_HAS_MUSL_LIBC) && \ (!defined(__ANDROID__) || __ANDROID_API__ >= 23) with `#elif __GLIBC__`?

[PATCH] D34264: Introduce -Wunguarded-availability-new, which is like -Wunguarded-availability, except that it's enabled by default for new deployment targets

arphaman updated this revision to Diff 102891. arphaman marked 2 inline comments as done. arphaman added a comment. Remove the assert and support the other partial availability warnings. Repository: rL LLVM https://reviews.llvm.org/D34264 Files: include/clang/Basic/DiagnosticGroups.td

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

echristo edited reviewers, added: bkramer; removed: echristo. echristo added a comment. Going to let Ben review this. I'd rather not pass the bool down and he might know a way to avoid that here by knowing the code more :) https://reviews.llvm.org/D34304

[PATCH] D34301: [Sema] Make sure the definition of a referenced virtual function is emitted when it is final

vsk added a comment. It looks Comment at: lib/Sema/SemaExpr.cpp:14715 +if (Method->isVirtual() && !(Method->hasAttr() || + Method->getParent()->hasAttr())) OdrUse = false; Do you think it makes sense to eliminate all

[PATCH] D34114: [clang] A better format for unnecessary packed warning.

yawanng added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D34114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34267: do more processing in clang-fuzzer (use EmitAssemblyAction)

kcc added a comment. ignore this for now. I've found how to make it even more interesting (by using llvm::InitializeAllTargets, etc), will send an update later. https://reviews.llvm.org/D34267 ___ cfe-commits mailing list

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

benlangmuir added a comment. Thanks, this looks good to me. I'd appreciate if @klimek could take a quick look though. Comment at: include/clang/Lex/PreprocessorOptions.h:102 + /// in preprocessor directive conditions it causes all blocks to be parsed so + /// that the

[PATCH] D34299: [ubsan] Improve diagnostics for return value checks (clang)

vsk created this revision. This patch makes ubsan's nonnull return value diagnostics more precise, which makes the diagnostics more useful when there are multiple return statements in a function. Example: 1 |__attribute__((returns_nonnull)) char *foo() { 2 | if (...) { 3 |return

Re: r305600 - [Driver] Do a PATH lookup if needed when using -no-canonical-prefixes

On Fri, Jun 16, 2017 at 10:40:18PM -, Petr Hosek via cfe-commits wrote: > @@ -53,8 +53,15 @@ using namespace clang::driver; > using namespace llvm::opt; > > std::string GetExecutablePath(const char *Argv0, bool CanonicalPrefixes) { > - if (!CanonicalPrefixes) > -return Argv0; > + if

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

EricWF added inline comments. Comment at: src/experimental/filesystem/operations.cpp:23-28 +// We can use the presence of UTIME_OMIT to detect platforms that do not +// provide utimensat, with some exceptions on OS X. +#if !defined(UTIME_OMIT) || \ +

r305619 - Call setMustBuildLookupTable on TagDecls in ExternalASTMerger

Author: lhames Date: Fri Jun 16 19:12:38 2017 New Revision: 305619 URL: http://llvm.org/viewvc/llvm-project?rev=305619=rev Log: Call setMustBuildLookupTable on TagDecls in ExternalASTMerger Summary: setMustBuildLookupTable should be called on imported TagDecls otherwise we may fail to import

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

phosek updated this revision to Diff 102881. phosek marked an inline comment as done. phosek edited the summary of this revision. Repository: rL LLVM https://reviews.llvm.org/D34290 Files: tools/driver/driver.cpp Index: tools/driver/driver.cpp

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

phosek added inline comments. Comment at: tools/driver/driver.cpp:58 +SmallString<128> ExecutablePath(Argv0); +// Do a PATH lookup, if there are no directory components. +if (llvm::sys::path::filename(ExecutablePath) == ExecutablePath) hans wrote: >

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

akyrtzi updated this revision to Diff 102885. akyrtzi added a comment. Improving doc comment. https://reviews.llvm.org/D34263 Files: include/clang/Lex/Preprocessor.h include/clang/Lex/PreprocessorOptions.h lib/Lex/PPDirectives.cpp lib/Lex/PPExpressions.cpp

r305600 - [Driver] Do a PATH lookup if needed when using -no-canonical-prefixes

Author: phosek Date: Fri Jun 16 17:40:18 2017 New Revision: 305600 URL: http://llvm.org/viewvc/llvm-project?rev=305600=rev Log: [Driver] Do a PATH lookup if needed when using -no-canonical-prefixes When -no-canonical-prefixes option is used and argv0 contains only a program name, we need to do a

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL305600: [Driver] Do a PATH lookup if needed when using -no-canonical-prefixes (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D34290?vs=102881=102894#toc Repository: rL LLVM

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 updated this revision to Diff 102868. jyu2 added a comment. Update patch https://reviews.llvm.org/D3 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/AnalysisBasedWarnings.cpp test/CXX/except/except.spec/p11.cpp test/SemaCXX/warn-throw-out-noexcept-func.cpp Index:

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

aaron.ballman added inline comments. Comment at: test/SemaCXX/warn-throw-out-noexcept-func.cpp:27 +} + +struct N : A { jyu2 wrote: > aaron.ballman wrote: > > Can you add a test case like: > > ``` > > struct Throws { > > ~Throws() noexcept(false); > > }; > > >

r305588 - [index] Fix typo: inferface -> interface

Author: malaperle Date: Fri Jun 16 15:58:26 2017 New Revision: 305588 URL: http://llvm.org/viewvc/llvm-project?rev=305588=rev Log: [index] Fix typo: inferface -> interface Reviewers: arphaman Reviewed By: arphaman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D33253

[PATCH] D34294: Rework libcxx strerror_r handling.

jyknight created this revision. Herald added subscribers: krytarowski, srhines. The set of #ifdefs used to handle the two incompatible variants of strerror_r were not complete (they didn't handle newlib appropriately). Rather than attempting to make the ifdefs more complex, make them unnecessary

[PATCH] D34294: Rework libcxx strerror_r handling.

krytarowski added a comment. In https://reviews.llvm.org/D34294#782856, @jyknight wrote: > In https://reviews.llvm.org/D34294#782806, @krytarowski wrote: > > > New one is harder to comprehend and less portable (usage of `__atribute__`). > > > I can't disagree more strongly. This is

[PATCH] D34212: docs: Document binary compatibility issue due to bug in gcc

vsk added a comment. Could you add links to this document in index.rst and UsersManual.rst? Comment at: docs/BinaryCompatibilityWithOtherCompilers.rst:39 + +https://llvm.org/PR33161 This link is still showing up as 'insecure'. Mind using this?:

[PATCH] D34264: Introduce -Wunguarded-availability-new, which is like -Wunguarded-availability, except that it's enabled by default for new deployment targets

erik.pilkington added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:6944 -diag = !ObjCPropertyAccess ? diag::err_unavailable - : diag::err_property_method_unavailable; -diag_message = diag::err_unavailable_message;

[PATCH] D34294: Rework libcxx strerror_r handling.

krytarowski added a comment. Or better: #elif __GLIBC__ || (__ANDROID_API__ - 0) >= 23 If I understand correctly, Android adopted GNU version. https://reviews.llvm.org/D34294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34264: Introduce -Wunguarded-availability-new, which is like -Wunguarded-availability, except that it's enabled by default for new deployment targets

arphaman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:6944 -diag = !ObjCPropertyAccess ? diag::err_unavailable - : diag::err_property_method_unavailable; -diag_message = diag::err_unavailable_message;

[PATCH] D34264: Introduce -Wunguarded-availability-new, which is like -Wunguarded-availability, except that it's enabled by default for new deployment targets

arphaman updated this revision to Diff 102902. arphaman marked an inline comment as done. arphaman added a comment. Swap the checking operators and bring back the accidentally deleted code. Repository: rL LLVM https://reviews.llvm.org/D34264 Files: include/clang/Basic/DiagnosticGroups.td

[PATCH] D33253: [index] Fix typo: inferface -> interface

arphaman added a comment. Btw, you can usually commit typo fixes and other similar changes without pre-commit reviews Repository: rL LLVM https://reviews.llvm.org/D33253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Buildbot numbers for the week of 06/04/2017 - 06/10/2017

Hello everyone, Below are some buildbot numbers for the last week of 06/04/2017 - 06/10/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status

Buildbot numbers for the week of 05/28/2017 - 06/03/2017

Hello everyone, Below are some buildbot numbers for the week of 05/28/2017 - 06/03/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D34290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34294: Rework libcxx strerror_r handling.

jyknight added a comment. In https://reviews.llvm.org/D34294#782806, @krytarowski wrote: > New one is harder to comprehend and less portable (usage of `__atribute__`). I can't disagree more strongly. This is fundamentally portable C++ code -- __attribute__((unused)) is simply warning

[PATCH] D34301: [Sema] Make sure the definition of a referenced virtual function is emitted when it is final

ahatanak created this revision. Herald added a subscriber: Prazek. The test case I added used to fail because of a linker error. Linkage failed because Sema::MarkDeclRefReferenced would prevent the virtual method definition from being emitted by setting OdrUse=false and then code-gen would

Re: r284060 - Implement MS _BitScan intrinsics

> On Jun 16, 2017, at 11:02, Reid Kleckner wrote: > > We should fix it. Agreed. > We just need a new character code in the builtin function prototype encoding. > Currently there is no encoding for a portable int32_t that magically becomes > "long" on 32-bit Windows. The

[PATCH] D34266: Static Analyzer - Localizability Checker: New Localizable APIs for macOS High Sierra & iOS 11

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thanks! Do you have commit access? Repository: rL LLVM https://reviews.llvm.org/D34266 ___ cfe-commits mailing list

[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM. Thank you! (Not sure if @NoQ wants to do a final review.) Do you have commit access or should we commit on your behalf? https://reviews.llvm.org/D30406

[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

vlad.tsyrklevich added a comment. Please commit on my behalf. https://reviews.llvm.org/D30406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34102: [analyzer] Add portability package for the checkers.

zaks.anna added a comment. > eg. checkers for portability across linux/bsd should be off on windows by > default, checkers for non-portable C++ APIs should be off in plain C code, etc Is the checker you are moving to portability off and not useful on Windows? https://reviews.llvm.org/D34102

RE: [llvm-dev] Llvm lab resent network issues are resolved

> Hello everyone, > There were network issues with our provider and LLVM buildmaster was > unavailable recently. > Sorry for inconvenience. > Thanks > Galina Hi Galina, Thanks for the note. Still no connectivity from the outside (using several down time checkers (upstrends.com,

[PATCH] D32332: Add support for transparent overloadable functions in clang

george.burgess.iv updated this revision to Diff 102850. george.burgess.iv marked 3 inline comments as done. george.burgess.iv added a comment. Addressed all feedback https://reviews.llvm.org/D32332 Files: include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D34235: [OpenCL] Fix OpenCL and SPIR version metadata generation.

ahatanak added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:516 + llvm::LLVMContext = TheModule.getContext(); + llvm::Type *Int32Ty = llvm::Type::getInt32Ty(Ctx); + // SPIR v2.0 s2.12 - The SPIR version used by the module is stored in the

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

teemperor added a comment. See my inline comments about technical changes, but otherwise this looks ready to land. Please update and I'll give green light ASAP. Thanks! Comment at: lib/Analysis/CloneDetection.cpp:375 +const Decl *D = S.getContainingDecl(); +const

[PATCH] D34252: Add arbitrary file/path support to clang-format style file selection

ioeric added a comment. Hi Dan, thanks for the patch! https://reviews.llvm.org/D33560, which adds the same feature, is already under review :) https://reviews.llvm.org/D34252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34235: [OpenCL] Fix OpenCL and SPIR version metadata generation.

bader updated this revision to Diff 102789. bader added a comment. Applied Akira's comment: re-used cached Int32Ty type. https://reviews.llvm.org/D34235 Files: lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h lib/CodeGen/TargetInfo.cpp test/CodeGenOpenCL/spir_version.cl

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

voskresensky.vladimir added a comment. Hello Argyrios, This is a good addition to simplify reuse of preprocessor in IDEs. Thanks for doing this. From our experience of integrating clang PP into NetBeans, the following change gives more flexibility: - introduce method in PPCallbacks and

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai updated this revision to Diff 102796. xiangzhai added a comment. Dear Raphael, I updated my patch as you suggested, please review it, thanks a lot! And I noticed that you are doing Performance optimizations for the CloneChecker https://reviews.llvm.org/D34182 I will rebase my patch

[PATCH] D33253: [index] Fix typo: inferface -> interface

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D33253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r305549 - Fix potential bug by casting to the POSIX specified type

Author: ericwf Date: Fri Jun 16 01:17:52 2017 New Revision: 305549 URL: http://llvm.org/viewvc/llvm-project?rev=305549=rev Log: Fix potential bug by casting to the POSIX specified type Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp Modified:

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai added a comment. Dear Raphael, Sorry I am not available, I am looking after my little kid, see you next week, rebase perhaps. Thanks, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31320 ___ cfe-commits mailing list

[PATCH] D33676: Place implictly declared functions at block scope

chill added inline comments. Comment at: test/Sema/implicit-decl.c:12 int32_t compCount = 0; - if (_CFCalendarDecomposeAbsoluteTimeV(compDesc, vector, compCount)) { // expected-note {{previous implicit declaration is here}} \ - expected-error {{implicit

[PATCH] D33823: [clang-format] Support sorting using declarations

Typz added inline comments. Comment at: lib/Format/UsingDeclarationsSorter.cpp:66 + } + return HasIdentifier && Tok && Tok->isOneOf(tok::semi, tok::comma); +} could also be followed by an assignment, in case of type alias: using foo = bar::foo;

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Please check the last inline comment and then feel free to commit it with the suggested fix. And I wanted to wait for review on the other performance patches, so you can push this now.

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 102800. yvvan added a comment. Use Lexer::getSourceText https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp Index: lib/Sema/SemaCodeComplete.cpp === ---

r305551 - Expand vector oparation to as IR constants, PR28129.

Author: dinar Date: Fri Jun 16 07:09:52 2017 New Revision: 305551 URL: http://llvm.org/viewvc/llvm-project?rev=305551=rev Log: Expand vector oparation to as IR constants, PR28129. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/test/CodeGen/avx-builtins.c Modified:

[PATCH] D34238: clang-format: Do not binpack initialization lists

Typz updated this revision to Diff 102809. Typz added a comment. fix indent https://reviews.llvm.org/D34238 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D33491: clang-format: Fix C99 designated initializers corner cases

Typz updated this revision to Diff 102803. Typz added a comment. Fix incorrect labelling as ObjCMethodExpr https://reviews.llvm.org/D33491 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index:

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik added inline comments. Comment at: clang-tidy/misc/UndelegatedCopyOfBaseClassesCheck.cpp:92 + // Loop until the beginning of the initialization list. + while (!Tok.is(tok::r_paren)) +Lex.LexFromRawLexer(Tok); aaron.ballman wrote: > This doesn't

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik added inline comments. Comment at: clang-tidy/misc/UndelegatedCopyOfBaseClassesCheck.cpp:92 + // Loop until the beginning of the initialization list. + while (!Tok.is(tok::r_paren)) +Lex.LexFromRawLexer(Tok); aaron.ballman wrote: > szdominik

[PATCH] D33676: Place implictly declared functions at block scope

rogfer01 added a comment. Thanks Momchil, this looks sensible to me. What do you think @aaron.ballman @rsmith ? https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

> On Jun 15, 2017, at 22:22, Eric Fiselier wrote: > > > >> On Thu, Jun 15, 2017 at 11:00 PM, Duncan P. N. Exon Smith >> wrote: >> Your suggestion is essentially to replace experimental/string_view with >> something like: >> >> namespace std { inline

[PATCH] D34269: [clangd] Add "Go to Declaration" functionality

ilya-biryukov added a comment. Hi @malaperle-ericsson. Thanks for the patch. IndexingAction has a very simple interface, exactly what clangd needs and nothing more. BTW, we had a bug open for that: https://bugs.llvm.org/show_bug.cgi?id=33261, feel free to reassign to yourself.

[PATCH] D33676: Place implictly declared functions at block scope

chill updated this revision to Diff 102802. chill added a comment. Update 2: added a testcase involving expression statements https://reviews.llvm.org/D33676 Files: include/clang/Sema/Scope.h lib/Parse/ParseStmt.cpp lib/Sema/SemaDecl.cpp test/Sema/implicit-decl-c90.c

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

bader added inline comments. Comment at: include/clang/Basic/TargetInfo.h:1041 +default: + return LangAS::Default; +} yaxunl wrote: > bader wrote: > > yaxunl wrote: > > > I think the default (including even_t, clk_event_t, queue_t, > > >

[PATCH] D34238: clang-format: Do not binpack initialization lists

Typz updated this revision to Diff 102808. Typz marked an inline comment as done. Typz added a comment. remove special case after assignment https://reviews.llvm.org/D34238 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

aaron.ballman added inline comments. Comment at: clang-tidy/misc/UndelegatedCopyOfBaseClassesCheck.cpp:92 + // Loop until the beginning of the initialization list. + while (!Tok.is(tok::r_paren)) +Lex.LexFromRawLexer(Tok); szdominik wrote: > aaron.ballman

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik updated this revision to Diff 102807. szdominik marked 9 inline comments as done. szdominik added a comment. Rename check. Hoisted matcher, changed warning message & nits. https://reviews.llvm.org/D33722 Files: clang-tidy/misc/CMakeLists.txt

[PATCH] D34102: [analyzer] Add portability package for the checkers.

NoQ added a comment. Here's a version of the patch without `.unix`. I'd still hate it to re-add the subpackages if we decide to turn some portability checkers on and off depending on language/platform (eg. checkers for portability across linux/bsd should be off on windows by default, checkers

  1   2   >