EricWF added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:433
case tok::kw___try:
+ assert(!Tok->is(tok::kw_co_await));
if (!LBraceStack.empty() && LBraceStack.back()->BlockKind == BK_Unknown)
This change is accidental.
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/SValBuilder.cpp:356
QualType ResultTy) {
- if (!State->isTainted(RHS) && !State->isTainted(LHS))
-return UnknownVal();
ddcc wrote:
> zaks.anna wrote:
>
ajbennieston updated this revision to Diff 102934.
ajbennieston added a comment.
V3 with indentation and punctuation fixes.
https://reviews.llvm.org/D34091
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_exception_specification_kind.py
include/clang-c/Index.h
NoQ added a comment.
Hmm, curious, having a look. A couple of blind guesses before i actually
understand what's going on:
(1) The `simplifySVal()` code has its own complexity threshold:
1060 SVal VisitNonLocSymbolVal(nonloc::SymbolVal V) {
1061 // Simplification is much more
yamaguchi updated this revision to Diff 102944.
yamaguchi marked 3 inline comments as done.
yamaguchi added a comment.
Herald added a subscriber: hiraditya.
Update patch and add support for `clang -stdlib=[tab]` case.
In this case we expect to see all possible values.
(Eg. `libc++ libstdc++
yamaguchi added inline comments.
Comment at: clang/test/Driver/autocomplete.c:7
// NONE: foo
+// RUN: %clang --autocomplete=l,=,-stdlib | FileCheck %s -check-prefix=STDLIB
+// STDLIB: libc++ libstdc++
ruiu wrote:
> Why do you want to pass the arguments in the
ruiu added inline comments.
Comment at: clang/utils/bash-autocomplete.sh:10
+ do
+arg="$arg""${COMP_WORDS[$i]},"
+ done
ruiu wrote:
> nit: you don't need double double-quotes. Instead, `"$arg${COMP_WORDS[$i]},"
> should just work.
On second thought, I
yamaguchi marked 2 inline comments as done.
yamaguchi added inline comments.
Comment at: llvm/lib/Option/OptTable.cpp:198
+ continue;
+std::string S = "-" + std::string(In.Name);
+std::string C = (Command[1] == "=") ?
yamaguchi wrote:
> teemperor
ruiu added a comment.
As to the order of Command variable contents, I think I'm not convinced. You
can access the last element as `Command[Command.size() - 1]` (or maybe
`Command.back()`), no? It is slightly awkward than `Command[0]`, but that's not
horribly hard to handle, and passing
yamaguchi updated this revision to Diff 102946.
yamaguchi marked 5 inline comments as done.
yamaguchi added a comment.
Update patch. Rui's comment about the bash part is very reasonable.
https://reviews.llvm.org/D33383
Files:
clang/include/clang/Driver/Options.h
krytarowski added a comment.
We can change NetBSD base libstdc++ in `/usr/include/g++/bits/*/c++config.h`
from
/* Define if __float128 is supported on this host. */
#define _GLIBCXX_USE_FLOAT128 1
to:
#if !defined(__clang__)
/* Define if __float128 is supported on this host. */
krytarowski added a comment.
We can patch libstdc++ to conditionally enable float128 on NetBSD, this works
too. All other systems I'm aware of including cygwin moved to
`this->HasFloat128 = true;`.
Repository:
rL LLVM
https://reviews.llvm.org/D34018
krytarowski added a comment.
In https://reviews.llvm.org/D34018#783218, @joerg wrote:
> As I said, I don't see the point in pretending we support float128 when the
> runtime doesn't contain the necessary pieces.
On the other hand cmake and other packages break now. What's the alternative?
krytarowski added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D34018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joerg added a comment.
As I said, I don't see the point in pretending we support float128 when the
runtime doesn't contain the necessary pieces.
Repository:
rL LLVM
https://reviews.llvm.org/D34018
___
cfe-commits mailing list
Author: compnerd
Date: Sat Jun 17 12:30:31 2017
New Revision: 305638
URL: http://llvm.org/viewvc/llvm-project?rev=305638=rev
Log:
CodeGen: make the type match the comment for a libcall
Fix the type for a (runtime) library call to match both the comment and
the runtime implementation. As it
alexshap added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D34268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jtbandes created this revision.
Herald added a subscriber: klimek.
The original changes for ref qualifiers in https://reviews.llvm.org/rL272537
and https://reviews.llvm.org/rL272548 allowed function const+ref qualifier
spacing to diverge from the spacing used for variables. It seems more
kubamracek added a comment.
Nice!
Repository:
rL LLVM
https://reviews.llvm.org/D34175
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
@rsmith ping. I need this for
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0607r0.html
https://reviews.llvm.org/D32950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
davide added inline comments.
Comment at: include/clang/Basic/Attr.td:2421
-def SelectAny : InheritableAttr, TargetSpecificAttr {
+def SelectAny : InheritableAttr, TargetSpecificAttr {
let Spellings = [Declspec<"selectany">, GCC<"selectany">];
rnk wrote:
>
arphaman added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:248
+/// doesn't restore the state \p CI had before calling AddImplicitPreamble,
only
+/// clears relevant settings, so that preamble is disabled in \p CI.
+} // namespace clang
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D34175
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
23 matches
Mail list logo
