This revision was automatically updated to reflect the committed changes.
Closed by commit rL308584: [AArch64] Produce correct defaultlib directives for
windows in MSVC style (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D35546?vs=107058=107443#toc
Repository:
rL
sgundapa added a comment.
I will try to address the concerns here:
> What exactly is the motivation? I'm trying to narrow down the justification
> for adding yet more flags.
(I just typed this message in https://reviews.llvm.org/D35579)
For backends with "tightly coupled memory", in scenarios
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308496: [Sema] Improve diagnostic message for unavailable
C++17 aligned (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D35520?vs=107140=107336#toc
Repository:
rL LLVM
erichkeane updated this revision to Diff 107310.
erichkeane marked an inline comment as done.
erichkeane added a comment.
Changed fallthrough for Craig
https://reviews.llvm.org/D35572
Files:
include/clang/Basic/TargetInfo.h
lib/Basic/Targets.cpp
Index: lib/Basic/Targets.cpp
kparzysz added a comment.
In https://reviews.llvm.org/D35578#814919, @mcrosier wrote:
> It sounds like to me you have some cases when you do want lookup tables and
> other cases that you don't. What exactly is the determining factor here?
The determining factor is whether the customers want
Anastasia added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:11846
// an address space.
if (T.getAddressSpace() != 0) {
// OpenCL allows function arguments declared to be an array of a type
yaxunl wrote:
> Anastasia wrote:
> > Could we use
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308486: [clangd] Allow specifying -resource-dir (authored by
krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D35617
Files:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
sgundapa added a comment.
> Wouldn't the fix be to make the backend deal with this, then? Either by
> putting the table with the function text, or or opting out of lookup tables?
> It seems that might be a better experience for the user.
That is perfectly reasonable and in fact i have
krasimir added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:489
- nextToken(); // Munch the closing brace.
+ nextToken(InitialLevel); // Munch the closing brace.
djasper wrote:
> krasimir wrote:
> > djasper wrote:
> > > krasimir wrote:
>
Author: ahatanak
Date: Wed Jul 19 10:17:50 2017
New Revision: 308496
URL: http://llvm.org/viewvc/llvm-project?rev=308496=rev
Log:
[Sema] Improve diagnostic message for unavailable C++17 aligned
allocation functions.
This changes the error message Sema prints when an unavailable C++17
aligned
eandrews updated this revision to Diff 107343.
eandrews added a comment.
As per revision comments, I moved the condition for extended precision floating
type to isX86VectorTypeForVectorCall. This update will now alter behavior for
complex long double type under vectorcall calling convention as
krasimir updated this revision to Diff 107314.
krasimir added a comment.
- Adapt the fix from comment suggestion
https://reviews.llvm.org/D35485
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestComments.cpp
Index: unittests/Format/FormatTestComments.cpp
mcrosier added a comment.
In https://reviews.llvm.org/D35578#814817, @sgundapa wrote:
> > Wouldn't the fix be to make the backend deal with this, then? Either by
> > putting the table with the function text, or or opting out of lookup
> > tables? It seems that might be a better experience for
rjmccall added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:1910
+const Decl *D, llvm::GlobalValue *GV, CodeGen::CodeGenModule ,
+ForDefinition_t IsForDefinition) const {
if (const FunctionDecl *FD = dyn_cast_or_null(D)) {
To preserve
mfherbst updated this revision to Diff 107254.
mfherbst added a comment.
Adapt patch to the changes since the initial submission.
Most notably the introduction of clang-tidy-4.0 changed the format in which
clang-tidy dumps the required changes. This needs to be taken into account when
merging
hans added a comment.
I'm also curious about the motivation for this.
LLVM backends can opt out of these kinds of tables if they're not suitable for
the target, but why would a Clang user want to do it?
https://reviews.llvm.org/D35578
___
malhar1995 created this revision.
malhar1995 added a project: clang.
As part of my Google Summer of Code project, I am working on adding support for
Integer Set Library (ISL) annotations to the current RetainCountChecker.
Note about ISL:
ISL has annotations __isl_give and __isl_take which are
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM, Thanks.
https://reviews.llvm.org/D35520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: arphaman
Date: Wed Jul 19 04:30:41 2017
New Revision: 308441
URL: http://llvm.org/viewvc/llvm-project?rev=308441=rev
Log:
Recommit r308327: Add a warning for missing '#pragma pack (pop)'
and suspicious uses of '#pragma pack' in included files
This commit adds a new -Wpragma-pack warning.
atanasyan updated this revision to Diff 107281.
atanasyan added a comment.
- Early return from `setTargetAttributes` methods if `IsForDefinition` is not
true in all cases except handling MIPS "call style" attributes.
Repository:
rL LLVM
https://reviews.llvm.org/D35479
Files:
krasimir updated this revision to Diff 107285.
krasimir marked 2 inline comments as done.
krasimir added a comment.
- Manually messed up tests
https://reviews.llvm.org/D35485
Files:
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
Author: hans
Date: Wed Jul 19 05:31:01 2017
New Revision: 308455
URL: http://llvm.org/viewvc/llvm-project?rev=308455=rev
Log:
Revert r308441 "Recommit r308327: Add a warning for missing '#pragma pack
(pop)' and suspicious uses of '#pragma pack' in included files"
This seems to have broken the
On Wed, Jul 19, 2017 at 2:26 PM, Hans Wennborg wrote:
> On Wed, Jul 19, 2017 at 1:30 PM, Alex Lorenz via cfe-commits
> wrote:
>> Author: arphaman
>> Date: Wed Jul 19 04:30:41 2017
>> New Revision: 308441
>>
>> URL:
Author: hans
Date: Wed Jul 19 05:20:52 2017
New Revision: 308447
URL: http://llvm.org/viewvc/llvm-project?rev=308447=rev
Log:
Creating release_50 branch off revision 308441
Added:
libcxx/branches/release_50/ (props changed)
- copied from r308441, libcxx/trunk/
Propchange:
On Wed, Jul 19, 2017 at 1:22 AM, Tanya Lattner wrote:
>
> On Jul 18, 2017, at 8:07 AM, Nico Weber wrote:
>
> On Mon, Jul 17, 2017 at 8:39 AM, Aaron Ballman
> wrote:
>>
>> On Sun, Jul 16, 2017 at 7:49 PM, Nico Weber
Author: hans
Date: Wed Jul 19 05:20:52 2017
New Revision: 308448
URL: http://llvm.org/viewvc/llvm-project?rev=308448=rev
Log:
Creating release_50 branch off revision 308441
Added:
libcxxabi/branches/release_50/
- copied from r308441, libcxxabi/trunk/
Author: hans
Date: Wed Jul 19 05:20:59 2017
New Revision: 308454
URL: http://llvm.org/viewvc/llvm-project?rev=308454=rev
Log:
Creating release_50 branch off revision 308441
Added:
libunwind/branches/release_50/
- copied from r308441, libunwind/trunk/
On Wed, Jul 19, 2017 at 1:30 PM, Alex Lorenz via cfe-commits
wrote:
> Author: arphaman
> Date: Wed Jul 19 04:30:41 2017
> New Revision: 308441
>
> URL: http://llvm.org/viewvc/llvm-project?rev=308441=rev
> Log:
> Recommit r308327: Add a warning for missing '#pragma pack
Hello everyone,
I'm going on vacation starting from the next week. I will be traveling, so
likely will be slow with my e-mails.
Please feel free to contact Victor Leschuk ()
with the questions or request related to the LLVM Lab and the buildbot
infrastructure.
Thanks
rjmccall added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1336
+if code compiled using ``-mlong-calls`` switch, it forces compiler to use
+the ``jal`` instruction to call the function.
+ }];
sdardis wrote:
> rjmccall wrote:
> > I suggest the
rnk added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:3516
+ // calling convention is used.
if (IsRegCall && FI.getReturnType()->getTypePtr()->isRecordType() &&
!FI.getReturnType()->getTypePtr()->isUnionType()) {
This is incorrect. We
yaxunl marked 6 inline comments as done.
yaxunl added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:11846
// an address space.
if (T.getAddressSpace() != 0) {
// OpenCL allows function arguments declared to be an array of a type
Anastasia wrote:
> On Jun 21, 2017, at 11:32 PM, Andrew Jeffery wrote:
>
> For the tests I've extracted the int5 and int8 cases to cater for
> different alignments for different platform ABIs. For Linux on POWER the
> 5 and 8 element vectors must be naturally aligned with respect to the
> total
sgundapa updated this revision to Diff 107317.
sgundapa added a comment.
Made the changes asked by reviewers
https://reviews.llvm.org/D35577
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CodeGenFunction.cpp
lib/Driver/ToolChains/Clang.cpp
hans added a comment.
In https://reviews.llvm.org/D35578#814590, @sgundapa wrote:
> I will try to address the concerns here:
>
> > What exactly is the motivation? I'm trying to narrow down the justification
> > for adding yet more flags.
>
> (I just typed this message in
sdardis added a comment.
Some comments on the documentation.
Comment at: include/clang/Basic/AttrDocs.td:1336
+if code compiled using ``-mlong-calls`` switch, it forces compiler to use
+the ``jal`` instruction to call the function.
+ }];
rjmccall wrote:
> I
Author: krasimir
Date: Wed Jul 19 08:43:35 2017
New Revision: 308486
URL: http://llvm.org/viewvc/llvm-project?rev=308486=rev
Log:
[clangd] Allow specifying -resource-dir
Summary: This patch allows clangd to specify its -resource-dir.
Reviewers: bkramer, klimek
Reviewed By: bkramer
jordan_rose added a subscriber: modocache.
jordan_rose added a comment.
> The addition of "${path}/.git/HEAD" at line 37 is used only once when repo is
> initially synced "for the first time". This is because ${git_path}/logs/HEAD
> file at line 34 for Git or Git submodule does not exist with
minseong.kim added a comment.
Thanks @jordan_rose @modocache @hintonda for your time and efforts.
This patch does regenerate the version control info correctly (SVNVersion.inc)
every time I re-make clang. Probably I am missing something here.
Could you please be more specific and share your
Author: faisalv
Date: Wed Jul 19 18:10:56 2017
New Revision: 308574
URL: http://llvm.org/viewvc/llvm-project?rev=308574=rev
Log:
[NFC] Update local variable names to upper-case as per LLVM Coding Standards.
Modified:
cfe/trunk/lib/Lex/TokenLexer.cpp
Modified:
ddcc added a comment.
As an aside, I think it'd be good to land https://reviews.llvm.org/D28954 and
https://reviews.llvm.org/D28955 first, since they affect accuracy and precision
of various analyzer parts that this depends on.
> Here are some examples that should all be UNKNOWN (right?) but
Author: hans
Date: Wed Jul 19 02:52:24 2017
New Revision: 308427
URL: http://llvm.org/viewvc/llvm-project?rev=308427=rev
Log:
Update clang-cl options in the users manual
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308431: [mips] Teach the driver to accept -m(no-)gpopt.
(authored by sdardis).
Changed prior to commit:
https://reviews.llvm.org/D35548?vs=107114=107275#toc
Repository:
rL LLVM
Author: sdardis
Date: Wed Jul 19 03:38:03 2017
New Revision: 308431
URL: http://llvm.org/viewvc/llvm-project?rev=308431=rev
Log:
[mips] Teach the driver to accept -m(no-)gpopt.
This patch teaches the driver to pass -mgpopt by default to the backend when it
is supported, i.e. we are using
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D35550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D35549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308433: Add default values for function parameter chunks
(authored by erikjv).
Changed prior to commit:
https://reviews.llvm.org/D33644?vs=107077=107276#toc
Repository:
rL LLVM
Author: sdardis
Date: Wed Jul 19 04:11:02 2017
New Revision: 308436
URL: http://llvm.org/viewvc/llvm-project?rev=308436=rev
Log:
Revert "[mips] Teach the driver to accept -m(no-)gpopt."
Revert r308431 and r308432, these caused broke some buildbots.
Removed:
Author: sdardis
Date: Wed Jul 19 03:39:15 2017
New Revision: 308432
URL: http://llvm.org/viewvc/llvm-project?rev=308432=rev
Log:
[mips] Add warning test for -mgpopt option.
Added:
cfe/trunk/test/Driver/mips-gpopt-warning.c
Added: cfe/trunk/test/Driver/mips-gpopt-warning.c
URL:
Author: erikjv
Date: Wed Jul 19 03:45:40 2017
New Revision: 308433
URL: http://llvm.org/viewvc/llvm-project?rev=308433=rev
Log:
Add default values for function parameter chunks
Append optional chunks with their default values. For example:
before - "int i", after - "int i = 10"
Patch by Ivan
Author: erikjv
Date: Wed Jul 19 04:15:36 2017
New Revision: 308438
URL: http://llvm.org/viewvc/llvm-project?rev=308438=rev
Log:
Fix compilation problem introduced in r308433
Modified:
cfe/trunk/lib/Sema/SemaCodeComplete.cpp
Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp
URL:
Thanks, I'll take a look.
On 19 July 2017 at 13:31, Hans Wennborg wrote:
> On Wed, Jul 19, 2017 at 2:26 PM, Hans Wennborg wrote:
> > On Wed, Jul 19, 2017 at 1:30 PM, Alex Lorenz via cfe-commits
> > wrote:
> >> Author: arphaman
NoQ added a comment.
In https://reviews.llvm.org/D35216#814124, @dcoughlin wrote:
> In this case, I would be fine with some sort of AbstractStorageMemoryRegion
> that meant "here is a memory region and somewhere reachable from here exists
> another region of type T". Or even multiple regions
Author: hans
Date: Wed Jul 19 06:49:39 2017
New Revision: 308465
URL: http://llvm.org/viewvc/llvm-project?rev=308465=rev
Log:
Bump docs version to 6.0
Modified:
libunwind/trunk/docs/conf.py
Modified: libunwind/trunk/docs/conf.py
URL:
Author: hans
Date: Wed Jul 19 06:51:07 2017
New Revision: 308467
URL: http://llvm.org/viewvc/llvm-project?rev=308467=rev
Log:
Bump docs version to 6.0
Modified:
clang-tools-extra/trunk/docs/conf.py
Modified: clang-tools-extra/trunk/docs/conf.py
URL:
mcrosier added a comment.
In https://reviews.llvm.org/D35578#813629, @Quuxplusone wrote:
> If the goal is fine-grained control over the heuristics for compiling switch
> statements, perhaps one should enumerate all the possible ways to lower
> switch statements --- jump-tables, lookup-tables,
Author: sdardis
Date: Wed Jul 19 06:12:37 2017
New Revision: 308458
URL: http://llvm.org/viewvc/llvm-project?rev=308458=rev
Log:
Reland "[mips] Teach the driver to accept -m(no-)gpopt."
This patch teaches the driver to pass -mgpopt by default to the backend when it
is supported, i.e. we are
krasimir added inline comments.
Comment at: clangd/ClangdUnit.cpp:167
+std::move(VFS));
+ CI->getFrontendOpts().DisableFree = false;
+ return CI;
Why `DisableFree`?
Comment at:
Author: sdardis
Date: Wed Jul 19 06:34:08 2017
New Revision: 308459
URL: http://llvm.org/viewvc/llvm-project?rev=308459=rev
Log:
Revert "Reland "[mips] Teach the driver to accept -m(no-)gpopt.""
This reverts r308458. Investigating further buildbot breakage.
Removed:
Author: hans
Date: Wed Jul 19 06:42:18 2017
New Revision: 308461
URL: http://llvm.org/viewvc/llvm-project?rev=308461=rev
Log:
Update version to 6.0.0svn
Modified:
libcxxabi/trunk/CMakeLists.txt
Modified: libcxxabi/trunk/CMakeLists.txt
URL:
Author: hans
Date: Wed Jul 19 06:46:11 2017
New Revision: 308462
URL: http://llvm.org/viewvc/llvm-project?rev=308462=rev
Log:
Bump docs version to 6.0
Modified:
libcxx/trunk/docs/conf.py
Modified: libcxx/trunk/docs/conf.py
URL:
Author: hans
Date: Wed Jul 19 06:50:27 2017
New Revision: 308466
URL: http://llvm.org/viewvc/llvm-project?rev=308466=rev
Log:
Bump docs version to 6.0
Modified:
cfe/trunk/docs/analyzer/conf.py
cfe/trunk/docs/conf.py
Modified: cfe/trunk/docs/analyzer/conf.py
URL:
Author: hans
Date: Wed Jul 19 06:57:10 2017
New Revision: 308468
URL: http://llvm.org/viewvc/llvm-project?rev=308468=rev
Log:
Update _LIBCPP_VERSION and the version in CMakeLists to 6.0
Modified:
libcxx/trunk/CMakeLists.txt
libcxx/trunk/include/__config
arphaman added a comment.
This triggered a warning in LLVM itself, in CoverageMapping.h :
error: non-default #pragma pack value might change the alignment of
struct or union members in the included file [-Werror,-Wpragma-pack]
#include "llvm/ProfileData/InstrProfData.inc"
^
Eric or Marshall, can you double check that I got this right?
Thanks,
Hans
On Wed, Jul 19, 2017 at 3:57 PM, Hans Wennborg via cfe-commits
wrote:
> Author: hans
> Date: Wed Jul 19 06:57:10 2017
> New Revision: 308468
>
> URL:
malhar1995 updated this revision to Diff 107347.
malhar1995 added a comment.
Addressed all comments except the one where I had to remove the test to see if
the return type was null while emitting diagnostics.
Repository:
rL LLVM
https://reviews.llvm.org/D35613
Files:
echristo added a comment.
In https://reviews.llvm.org/D35572#813520, @erichkeane wrote:
> In https://reviews.llvm.org/D35572#813369, @echristo wrote:
>
> > Can you update the code in CGBuiltin to use this as part of this patch? :)
> >
> > Thanks!
>
>
> I'm not sure which you're referring to? I
rnk requested changes to this revision.
rnk added a comment.
This revision now requires changes to proceed.
This doesn't seem like an acceptable workaround, surely this regresses
functionality for arrays with more than UINT_MAX elements.
https://reviews.llvm.org/D34873
echristo added a comment.
LGTM.
-eric
https://reviews.llvm.org/D35572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: erichkeane
Date: Wed Jul 19 14:50:08 2017
New Revision: 308530
URL: http://llvm.org/viewvc/llvm-project?rev=308530=rev
Log:
Add isValidCPUName and isValidFeature to TargetInfo
These two functions are really useful for implementations of attributes
(including attribute-target), so add
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308528: Rework libcxx strerror_r handling. (authored by
jyknight).
Repository:
rL LLVM
https://reviews.llvm.org/D34294
Files:
libcxx/trunk/src/system_error.cpp
Index:
vsk added a subscriber: bruno.
vsk added a comment.
That seems like a nice win and I like the convenience of this approach. That
said I've just remembered that there's a thread on cfe-dev about this:
[RFC] Suppress C++ static destructor registration
I don't think a consensus was reached. From
Author: jyknight
Date: Wed Jul 19 14:48:49 2017
New Revision: 308528
URL: http://llvm.org/viewvc/llvm-project?rev=308528=rev
Log:
Rework libcxx strerror_r handling.
The set of #ifdefs used to handle the two incompatible variants of
strerror_r were not complete (they didn't handle newlib
Author: erichkeane
Date: Wed Jul 19 15:06:33 2017
New Revision: 308539
URL: http://llvm.org/viewvc/llvm-project?rev=308539=rev
Log:
Improve SEMA for attribute-target
Add more diagnosis for the non-multiversioning case.
Differential Revision: https://reviews.llvm.org/D35573
Modified:
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D35546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rjmccall added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1336
+if code compiled using ``-mlong-calls`` switch, it forces compiler to use
+the ``jal`` instruction to call the function.
+ }];
sdardis wrote:
> rjmccall wrote:
> > sdardis wrote:
rjmccall added a comment.
A few more minor tweaks.
Comment at: lib/CodeGen/TargetInfo.cpp:2357
+return;
+ X86_32TargetCodeGenInfo::setTargetAttributes(D, GV, CGM, IsForDefinition);
That function has its own early exit, so do the early exit after calling
Author: ahatanak
Date: Wed Jul 19 10:26:42 2017
New Revision: 308498
URL: http://llvm.org/viewvc/llvm-project?rev=308498=rev
Log:
Add AlignedAllocation.h.
I forgot to "git add" it in r308496.
Added:
cfe/trunk/include/clang/Basic/AlignedAllocation.h
Added:
Author: szepet
Date: Wed Jul 19 16:50:00 2017
New Revision: 308558
URL: http://llvm.org/viewvc/llvm-project?rev=308558=rev
Log:
This feature allows the analyzer to consider loops to completely unroll. New
requirements/rules (for unrolling) can be added easily via ASTMatchers.
The current
Author: szepet
Date: Wed Jul 19 17:05:25 2017
New Revision: 308561
URL: http://llvm.org/viewvc/llvm-project?rev=308561=rev
Log:
[StaticAnalyzer] Completely unrolling specific loops with known bound option
Missing files added to rL308558.
Added:
Author: hans
Date: Wed Jul 19 07:04:19 2017
New Revision: 308470
URL: http://llvm.org/viewvc/llvm-project?rev=308470=rev
Log:
Drop 'svn' suffix from version number.
Modified:
libcxxabi/branches/release_50/CMakeLists.txt
Modified: libcxxabi/branches/release_50/CMakeLists.txt
URL:
Author: hans
Date: Wed Jul 19 07:04:52 2017
New Revision: 308472
URL: http://llvm.org/viewvc/llvm-project?rev=308472=rev
Log:
Drop 'svn' suffix from version number.
Modified:
libunwind/branches/release_50/CMakeLists.txt
Modified: libunwind/branches/release_50/CMakeLists.txt
URL:
Author: hans
Date: Wed Jul 19 07:04:38 2017
New Revision: 308471
URL: http://llvm.org/viewvc/llvm-project?rev=308471=rev
Log:
Drop 'svn' suffix from version number.
Modified:
libcxx/branches/release_50/CMakeLists.txt
Modified: libcxx/branches/release_50/CMakeLists.txt
URL:
Author: hans
Date: Wed Jul 19 07:15:27 2017
New Revision: 308479
URL: http://llvm.org/viewvc/llvm-project?rev=308479=rev
Log:
Clear release notes for 6.0.0
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst
URL:
minseong.kim added a comment.
Thanks for the reviewing this patch. Please correct if I am wrong.
The addition of "${path}/.git/HEAD" at line 37 is used only once when repo is
initially synced "for the first time". This is because ${git_path}/logs/HEAD
file at line 34 for Git or Git submodule
djasper added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:489
- nextToken(); // Munch the closing brace.
+ nextToken(InitialLevel); // Munch the closing brace.
krasimir wrote:
> djasper wrote:
> > krasimir wrote:
> > > djasper wrote:
>
Author: hans
Date: Wed Jul 19 07:14:07 2017
New Revision: 308478
URL: http://llvm.org/viewvc/llvm-project?rev=308478=rev
Log:
Clear release notes for 6.0.0
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
dcoughlin added a comment.
This looks pretty good. There are some minor comments in line.
One thing that is missing: tests for the new diagnostic text. Can you add new
tests that specifically test for the new diagnostic text with //
expected-warning {{ ... }}}. These should probably go in
peter.smith added a comment.
In https://reviews.llvm.org/D35538#814008, @compnerd wrote:
> Can you please add a test that shows that the AEABI functions are not given
> the wrong CC? Also, can you show that if someone also passes `-meabi=gnu`
> with a VFP target, that we still annotate the
Prazek added inline comments.
Comment at: include/clang/Basic/Attr.td:2421
-def SelectAny : InheritableAttr, TargetSpecificAttr {
+def SelectAny : InheritableAttr, TargetSpecificAttr {
let Spellings = [Declspec<"selectany">, GCC<"selectany">];
davide wrote:
rjmccall added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:2356
+ X86_32TargetCodeGenInfo::setTargetAttributes(D, GV, CGM, IsForDefinition);
addStackProbeSizeTargetAttribute(D, GV, CGM);
No, sorry, I must not have been clear. We still need a
sgundapa added a comment.
> Moreover, why can't this determining factor be built into the compiler so the
> user doesn't even have to bother. That would be a more ideal user experience.
Here is a use case : For the code that stays in TCM, the customer doesn't want
the data that the code refers
Author: ctopper
Date: Wed Jul 19 15:58:58 2017
New Revision: 308546
URL: http://llvm.org/viewvc/llvm-project?rev=308546=rev
Log:
[X86] Put avx512vpopcntdq in the right spot in the validateCpuSupports string
switch.
The validateCpuSupports switch is in the order of the enum defined in
alexshap created this revision.
This is a follow-up for https://reviews.llvm.org/D35427
ScanfFormatString.cpp has the same issue (incorrect handling of
the specifiers for ssize_t) and this diff fixes it and adds tests.
Test plan: make check-all
Repository:
rL LLVM
alexshap added inline comments.
Comment at: test/Sema/format-strings-fixit-ssize_t.c:4
+// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -std=c99 -fsyntax-only
-pedantic -Wall -Werror %t
+// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -std=c99 -E -o - %t |
FileCheck %s
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D35617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp:2012
+ } else if (CurrV.getObjKind() == RetEffect::GenericC) {
+if (Sym->getType().isNull()) {
+ os << " returns an object with a ";
I don't think
atanasyan updated this revision to Diff 107381.
atanasyan added a comment.
- New wording of attributes documentation and comments.
- Remove redundant `if-return` statements.
Repository:
rL LLVM
https://reviews.llvm.org/D35479
Files:
include/clang/Basic/Attr.td
sdardis added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1336
+if code compiled using ``-mlong-calls`` switch, it forces compiler to use
+the ``jal`` instruction to call the function.
+ }];
rjmccall wrote:
> sdardis wrote:
> > rjmccall wrote:
1 - 100 of 107 matches
Mail list logo