[PATCH] D34848: Driver: Don't mix system tools with devtoolset tools on RHEL

tstellar added a comment. Ping.u1 https://reviews.llvm.org/D34848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36253: [Sema] Add a comment on an identified bug on default arguments.

timshen created this revision. Herald added a subscriber: sanjoy. The mis-compile is triggered by internal code, but I haven't reduced it to a small piece of code. Add a FIXME here, since a decent fix doesn't seem to be trivial. The decent fix can be changing Decl::Init to PointerUnion, and

[PATCH] D36179: [clang-diff] Move printing of matches and changes to clang-diff

johannes updated this revision to Diff 109417. johannes added a comment. remove unused SubtreeIterator https://reviews.llvm.org/D36179 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h lib/Tooling/ASTDiff/ASTDiff.cpp

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

johannes updated this revision to Diff 109416. johannes added a comment. getSourceRangeOffsets, test https://reviews.llvm.org/D36178 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-json.cpp tools/clang-diff/ClangDiff.cpp Index:

[PATCH] D36184: [clang-diff] Filter AST nodes

johannes added a comment. In https://reviews.llvm.org/D36184#828866, @klimek wrote: > Why? Also, missing tests. implicit nodes are noisy / they generally don't add information; I guess one could also keep them. I excluded nodes outside of the main file are because the visualisation only

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

mcgrathr updated this revision to Diff 109428. mcgrathr added a comment. Added tests. https://reviews.llvm.org/D35922 Files: cmake/caches/Fuchsia-stage2.cmake lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.c Index: test/Driver/fuchsia.c

[PATCH] D34212: docs: Document binary compatibility issue due to bug in gcc

tstellar updated this revision to Diff 109438. tstellar added a comment. Add links to index.rst and UsersManual.rst, and fix link to bug. https://reviews.llvm.org/D34212 Files: docs/BinaryCompatibilityWithOtherCompilers.rst docs/UsersManual.rst docs/index.rst Index: docs/index.rst

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. Hmm. So the documentation is wrong, but not "fully wrong". If you simply try applying this patch and compiling with GCC you'll still encounter a bunch of instances of `warning: type

[PATCH] D36251: [analyzer] Suppress warning when bug path contains noreturn function or return from main in MagentaHandleChecker

haowei created this revision. Herald added a subscriber: xazax.hun. This patch will suppress handle leak warnings if the path of a bug reported by MagentaHandleChecker will reach a no return function or will reach the end of main function. As these two scenarios mean program crash and the

[PATCH] D36250: [coverage] Special-case calls to noreturn functions.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Repository: rL LLVM https://reviews.llvm.org/D36250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34801: [coverage] Make smaller regions for the first case of a switch.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309901: [coverage] Make smaller regions for the first case of a switch. (authored by efriedma). Changed prior to commit: https://reviews.llvm.org/D34801?vs=104581=109456#toc Repository: rL LLVM

r309901 - [coverage] Make smaller regions for the first case of a switch.

Author: efriedma Date: Wed Aug 2 16:22:50 2017 New Revision: 309901 URL: http://llvm.org/viewvc/llvm-project?rev=309901=rev Log: [coverage] Make smaller regions for the first case of a switch. We never overwrite the end location of a region, so we would end up with an overly large region when

[PATCH] D35863: Use the allocator's pointers for deallocation in `std::list`

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. First, this patch would need tests before continuing, Could you please them? The list tests live under `test/std/containers/sequences/list`. Let me know if you have any questions

[PATCH] D36250: [coverage] Special-case calls to noreturn functions.

efriedma created this revision. The code after a noreturn call doesn't execute. The pattern in the testcase is pretty common in LLVM (a switch with a default case that calls llvm_unreachable). Repository: rL LLVM https://reviews.llvm.org/D36250 Files: lib/CodeGen/CoverageMappingGen.cpp

Re: r308996 - [coroutines] Add serialization/deserialization of coroutines

On 31 July 2017 at 09:11, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Richard, Gor asked for this to be merged to 5.0. What do you think? Sounds good to me. On Tue, Jul 25, 2017 at 11:01 AM, Gor Nishanov via cfe-commits > wrote: > > Author:

[PATCH] D36249: Mark tests that need intel 80-bit floats as x86-only

saugustine created this revision. These tests assume intel-80 bit floats, as noted in their comments. Rather than having each target discover the incompatibility and disable them ad-hoc, mark them as requiring x86. Repository: rL LLVM https://reviews.llvm.org/D36249 Files:

r309908 - [Sema] Add a comment on an identified bug on default arguments.

Author: timshen Date: Wed Aug 2 17:18:11 2017 New Revision: 309908 URL: http://llvm.org/viewvc/llvm-project?rev=309908=rev Log: [Sema] Add a comment on an identified bug on default arguments. Summary: The mis-compile is triggered by internal code, but I haven't reduced it to a small piece of

[PATCH] D36254: [Driver][Fuchsia] Pass --hash-style=gnu to the linker

mcgrathr created this revision. The .gnu_hash format is superior, and all versions of the Fuchsia dynamic linker support it. Repository: rL LLVM https://reviews.llvm.org/D36254 Files: lib/Driver/ToolChains/Fuchsia.cpp Index: lib/Driver/ToolChains/Fuchsia.cpp

[PATCH] D36253: [Sema] Add a comment on an identified bug on default arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309908: [Sema] Add a comment on an identified bug on default arguments. (authored by timshen). Changed prior to commit: https://reviews.llvm.org/D36253?vs=109461=109464#toc Repository: rL LLVM

[PATCH] D36252: [diagtool] Add ability to get name from id

hintonda updated this revision to Diff 109472. hintonda added a comment. - Use cat|xargs which should work on window -- used in other tests. https://reviews.llvm.org/D36252 Files: test/Misc/find-diagnostic-id.c tools/diagtool/FindDiagnosticID.cpp Index:

[PATCH] D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix

yamaguchi updated this revision to Diff 109283. yamaguchi added a comment. Fixed typo. https://reviews.llvm.org/D36209 Files: clang/test/Driver/autocomplete.c Index: clang/test/Driver/autocomplete.c === ---

[PATCH] D36154: Adapt clang-tidy checks to changing semantics of hasDeclaration.

klimek updated this revision to Diff 109287. klimek marked an inline comment as done. klimek added a comment. Address review comment. https://reviews.llvm.org/D36154 Files: clang-tidy/google/StringReferenceMemberCheck.cpp clang-tidy/misc/DanglingHandleCheck.cpp

[PATCH] D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix

yamaguchi updated this revision to Diff 109277. yamaguchi added a comment. Update diff. https://reviews.llvm.org/D36209 Files: clang/test/Driver/autocomplete.c Index: clang/test/Driver/autocomplete.c === ---

r309795 - Use VFS operations in FileManager::makeAbsolutePath.

Author: ibiryukov Date: Wed Aug 2 00:25:24 2017 New Revision: 309795 URL: http://llvm.org/viewvc/llvm-project?rev=309795=rev Log: Use VFS operations in FileManager::makeAbsolutePath. Summary: It used to call into llvm::sys::fs::make_absolute. Reviewers: akyrtzi, erikjv, bkramer, krasimir,

[PATCH] D35894: [clangd] Code hover for Clangd

ilya-biryukov added a reviewer: ilya-biryukov. ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. I just wanted to take a step back and discuss what we want to get from code hover in the first place. I would expect a typical code hover to be a bit more involved and

[PATCH] D36155: Use VFS operations in FileManager::makeAbsolutePath.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309795: Use VFS operations in FileManager::makeAbsolutePath. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D36155 Files: cfe/trunk/lib/Basic/FileManager.cpp

[PATCH] D36154: Adapt clang-tidy checks to changing semantics of hasDeclaration.

klimek added a comment. ptal https://reviews.llvm.org/D36154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix

yamaguchi added a comment. @ruiu This test will break for instance, when someone add new value to mrelocation-model because values has to be shown in row 78- 83 order, or when someone made a new flags which start with `-Wno-invalid-pp-` because in row 96 only -Wno-invalid-pp-token is expected

[PATCH] D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix

ruiu added a comment. So, does this comment actually make sense? Looks like you cannot break this test by adding or modifying flags or by changing HelpText. (Theoretically, it'll break if you remove -fsyntax-only, for example, but that is not realistic.) https://reviews.llvm.org/D36209

[PATCH] D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix

yamaguchi updated this revision to Diff 109281. yamaguchi added a comment. Modified comment. https://reviews.llvm.org/D36209 Files: clang/test/Driver/autocomplete.c Index: clang/test/Driver/autocomplete.c === ---

[PATCH] D36155: Use VFS operations in FileManager::makeAbsolutePath.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. Nice catch! lg https://reviews.llvm.org/D36155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix

ruiu accepted this revision. ruiu added a comment. LGTM https://reviews.llvm.org/D36209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r309794 - [Bash-autocompletion] Add comment to test so that it is easier to fix

Author: yamaguchi Date: Wed Aug 2 00:20:27 2017 New Revision: 309794 URL: http://llvm.org/viewvc/llvm-project?rev=309794=rev Log: [Bash-autocompletion] Add comment to test so that it is easier to fix Summary: clang/test/Driver/autocomplete.c is a test for --autocomplete, and this test might

[PATCH] D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix

This revision was automatically updated to reflect the committed changes. Closed by commit rL309794: [Bash-autocompletion] Add comment to test so that it is easier to fix (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D36209?vs=109283=109285#toc Repository: rL

[PATCH] D35743: [clang-format] Handle Structured binding declaration in C++17

djasper added a comment. Generally, please upload patches with full context to phabricator. (or use arc) I think this approach is a bit inside out. We are in a codepath where we try to find a lambda introducer and we the look one or two tokens back to see that we aren't as we have seen "auto".

[PATCH] D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. E.g. If you add a flag that lands in between the results it breaks. Add `-Wmajor-new-feature` and the test goes red. Same with the flag results or changing the help test for `-std=`.

[PATCH] D36156: [rename] Introduce symbol occurrences

kimgr added a comment. I was about to suggest SymbolLocation or even SymbolLoc, but it appears to keep track of more than locations. "Reference" sounds a little open-ended. No more ideas here, I'm afraid. Repository: rL LLVM https://reviews.llvm.org/D36156

r309852 - [docs] Remove accidental unindent to appease the sphinx bot

Author: vedantk Date: Wed Aug 2 11:24:12 2017 New Revision: 309852 URL: http://llvm.org/viewvc/llvm-project?rev=309852=rev Log: [docs] Remove accidental unindent to appease the sphinx bot Bot failure:

[PATCH] D35955: clang-format: Add preprocessor directive indentation

euhlmann added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:383 + Current.Previous->is(tok::hash) && State.FirstIndent > 0) { +// subtract 1 so indent lines up with non-preprocessor code +Spaces += State.FirstIndent; djasper

[PATCH] D36176: [clang-diff] Fix some errors and inconsistencies

johannes updated this revision to Diff 109414. johannes added a comment. move most functional changes to other commits move constructor for Syntaxtree https://reviews.llvm.org/D36176 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h

[PATCH] D34512: Add preliminary Cross Translation Unit support library

rsmith added a comment. Organizationally, this seems fine. Carry on :) Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:229-231 +def err_fnmap_parsing : Error< + "error parsing CrossTU index file: '%0' line: %1 'USR filename' format " + "expected">;

r309873 - [UBSan] Provide default blacklist filename for UBSan

Author: shenhan Date: Wed Aug 2 12:53:38 2017 New Revision: 309873 URL: http://llvm.org/viewvc/llvm-project?rev=309873=rev Log: [UBSan] Provide default blacklist filename for UBSan Summary: This is to provide a default blacklist filename for UBSan. While UBSan is turned on, it's better that

[PATCH] D36181: [clang-diff] Make printing of matches optional

johannes updated this revision to Diff 109420. johannes added a comment. rename to -dump-matches, add a test https://reviews.llvm.org/D36181 Files: test/Tooling/clang-diff-args.sh test/Tooling/clang-diff-basic.cpp tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp

[PATCH] D36180: [clang-diff] Add option to dump the AST, one node per line

johannes updated this revision to Diff 109419. johannes added a comment. Herald added a subscriber: klimek. add a test https://reviews.llvm.org/D36180 Files: test/Tooling/clang-diff-ast.cpp test/Tooling/clang-diff-json.cpp tools/clang-diff/ClangDiff.cpp Index:

[PATCH] D36176: [clang-diff] Fix some errors and inconsistencies

johannes added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:96 : TreeImpl(llvm::make_unique(this, Node, AST)) {} + SyntaxTree(const SyntaxTree ) = delete; ~SyntaxTree(); arphaman wrote: > johannes wrote: > > arphaman wrote: > >

[PATCH] D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings

jmgao updated this revision to Diff 109411. jmgao added a comment. Remove accidental trailing backslash. https://reviews.llvm.org/D36237 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td lib/Analysis/ThreadSafety.cpp lib/Sema/SemaDeclAttr.cpp

[PATCH] D36183: [clang-diff] Simplify mapping

johannes updated this revision to Diff 109422. johannes edited the summary of this revision. johannes added a comment. - https://reviews.llvm.org/D36183 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/Inputs/clang-diff-basic-src.cpp

[PATCH] D36184: [clang-diff] Filter AST nodes

johannes updated this revision to Diff 109423. johannes added a comment. tests https://reviews.llvm.org/D36184 Files: lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-ast.cpp Index: test/Tooling/clang-diff-ast.cpp ===

Re: [libcxx] r309881 - Rename a couple variables to eliminate a shadow warning. No functionality change

Instead of creating two variables, wouldn't it be better to just remove the second definition and clear m_ec? You don't need to use both error codes side by side, as the second usage of m_ec occurs after the first one is finished. So you could remove the second definition and call clear() on it,

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

phosek added a comment. One more thing, would it be possible add a test case to `test/Driver/fuchsia.c` covering this? Repository: rL LLVM https://reviews.llvm.org/D35922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27827: [ObjC] CodeGen support for @available on macOS

thakis added a comment. We just noticed that if you call __builtin_available() for the first time after activating your app's sandbox, the function will fail: SandboxViolation: crdmg(15489) deny file-read-data /System/Library/CoreServices/SystemVersion.plist Violation: deny

[PATCH] D36177: [clang-diff] Add commandline arguments.

johannes updated this revision to Diff 109415. johannes added a comment. add some test, replace -no-compilation-database with -- https://reviews.llvm.org/D36177 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-args.sh

r309885 - Update for llvm change.

Author: rafael Date: Wed Aug 2 13:32:35 2017 New Revision: 309885 URL: http://llvm.org/viewvc/llvm-project?rev=309885=rev Log: Update for llvm change. Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp cfe/trunk/tools/driver/cc1as_main.cpp Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp

[libcxx] r309851 - Fix shadowing warning

Author: marshall Date: Wed Aug 2 11:21:34 2017 New Revision: 309851 URL: http://llvm.org/viewvc/llvm-project?rev=309851=rev Log: Fix shadowing warning Modified: libcxx/trunk/test/std/input.output/string.streams/stringstream.cons/string.pass.cpp Modified:

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl updated this revision to Diff 109406. yaxunl marked 29 inline comments as done. yaxunl added a comment. Revised by reviewers' comments. https://reviews.llvm.org/D28691 Files: docs/LanguageExtensions.rst include/clang/AST/Expr.h include/clang/Basic/Builtins.def

[PATCH] D36185: [clang-diff] Fix similarity computation

johannes updated this revision to Diff 109424. johannes added a comment. add test for Options.MaxSize https://reviews.llvm.org/D36185 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-bottomup.cpp test/Tooling/clang-diff-opt.cpp

[PATCH] D36185: [clang-diff] Fix similarity computation

johannes added inline comments. Comment at: test/Tooling/clang-diff-bottomup.cpp:3 +// RUN: %clang_cc1 -E %s > %t.dst.cpp -DDEST +// RUN: clang-diff -m -no-compilation-database -s=0 %t.src.cpp %t.dst.cpp | FileCheck %s +// klimek wrote: > Instead of using

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev added inline comments. Comment at: lib/CodeGen/CGCXXABI.cpp:43 if (RD->hasNonTrivialDestructor()) return false; rjmccall wrote: > Does canPassInRegisters() not subsume all of these earlier checks? No, if I remove them here I get a lot of

[PATCH] D36182: [clang-diff] Add HTML side-by-side diff output

johannes updated this revision to Diff 109421. johannes added a comment. - https://reviews.llvm.org/D36182 Files: test/Tooling/Inputs/clang-diff-basic-src.cpp test/Tooling/clang-diff-basic.cpp test/Tooling/clang-diff-html.py tools/clang-diff/CMakeLists.txt

[PATCH] D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

thakis created this revision. This helps some tools that do things based on the output's extension. For example, we got reports from users on Windows that have a tool that scan a build output dir (but skip .obj files). The tool would keep the "foo.obj-12345" file open, and then when clang

[PATCH] D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings

jmgao updated this revision to Diff 109412. jmgao added a comment. Fix commit messages. https://reviews.llvm.org/D36237 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td lib/Analysis/ThreadSafety.cpp lib/Sema/SemaDeclAttr.cpp test/Sema/attr-capabilities.c

[libcxx] r309881 - Rename a couple variables to eliminate a shadow warning. No functionality change

Author: marshall Date: Wed Aug 2 13:29:26 2017 New Revision: 309881 URL: http://llvm.org/viewvc/llvm-project?rev=309881=rev Log: Rename a couple variables to eliminate a shadow warning. No functionality change Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp Modified:

[PATCH] D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good, but let's confirm with Richard before we change behavior. https://reviews.llvm.org/D36238 ___ cfe-commits mailing list

[PATCH] D36186: [clang-diff] Improve and test getNodeValue

johannes updated this revision to Diff 109425. johannes added a comment. NFC renames https://reviews.llvm.org/D36186 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-ast.cpp test/Tooling/clang-diff-basic.cpp

[PATCH] D36186: [clang-diff] Improve and test getNodeValue

johannes updated this revision to Diff 109426. johannes added a comment. renamse, NFC https://reviews.llvm.org/D36186 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-ast.cpp test/Tooling/clang-diff-basic.cpp

[PATCH] D36177: [clang-diff] Add commandline arguments.

johannes added a comment. In https://reviews.llvm.org/D36177#828909, @arphaman wrote: > There should be a test that ensures that `stop-after` works and `extra-arg`s > are correctly passed to the compiler. `stop-after` is not tested yet. It is also broken in this patch, I will move it to a

[PATCH] D36186: [clang-diff] Improve and test getNodeValue

johannes added inline comments. Comment at: test/Tooling/clang-diff-ast.cpp:32 + +// CHECK: TypedefDecl: nat;unsigned int;( +typedef unsigned nat; klimek wrote: > For my curiosity: why are there semicolons here? Is the format documented > somewhere? To avoid

r309888 - Remove unused diagnostic. NFC.

Author: d0k Date: Wed Aug 2 14:16:50 2017 New Revision: 309888 URL: http://llvm.org/viewvc/llvm-project?rev=309888=rev Log: Remove unused diagnostic. NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td URL:

[PATCH] D36156: [rename] Introduce symbol occurrences

klimek added inline comments. Comment at: include/clang/Tooling/Refactoring/Rename/SymbolOccurrences.h:32 +/// a macro expansion. +class SymbolOccurrence { +public: I understand the exact vs. non-exact idea, but can you expand a bit on how Obj-C code looks

[PATCH] D36208: [mips] Enable target-specific attributes for MIPS64

sdardis added a comment. Some comments: Currently there is no support in the backend for the interrupt attribute for mips64 / using N32 & N64 abis, it will give a fatal error. Previously the backend lacked support for the static relocation model which is an expected requirement for interrupt

[PATCH] D36208: [mips] Enable target-specific attributes for MIPS64

atanasyan added a comment. In https://reviews.llvm.org/D36208#828853, @sdardis wrote: > Currently there is no support in the backend for the interrupt attribute for > mips64 / using N32 & N64 abis, it will give a fatal error. Previously the > backend lacked support for the static relocation

r309799 - [StaticAnalyzer] Fix false positives for unreachable code in macros.

Author: danielmarjamaki Date: Wed Aug 2 01:26:56 2017 New Revision: 309799 URL: http://llvm.org/viewvc/llvm-project?rev=309799=rev Log: [StaticAnalyzer] Fix false positives for unreachable code in macros. Example: #define MACRO(C) if (C) { static int x; .. } void foo() { MACRO(0); }

[clang-tools-extra] r309800 - [clangd] Capitalized descriptions of clangd options. NFC.

Author: ibiryukov Date: Wed Aug 2 01:53:48 2017 New Revision: 309800 URL: http://llvm.org/viewvc/llvm-project?rev=309800=rev Log: [clangd] Capitalized descriptions of clangd options. NFC. To follow the style of other options shown on `clangd -help`. Modified:

[clang-tools-extra] r309801 - [clangd] Run clang-format on all clangd sources. NFC.

Author: ibiryukov Date: Wed Aug 2 02:08:39 2017 New Revision: 309801 URL: http://llvm.org/viewvc/llvm-project?rev=309801=rev Log: [clangd] Run clang-format on all clangd sources. NFC. Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp

[PATCH] D36141: [StaticAnalyzer] Fix FP in UnreachableCodeChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rL309799: [StaticAnalyzer] Fix false positives for unreachable code in macros. (authored by danielmarjamaki). Changed prior to commit: https://reviews.llvm.org/D36141?vs=109086=109294#toc Repository:

[PATCH] D36154: Adapt clang-tidy checks to changing semantics of hasDeclaration.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good https://reviews.llvm.org/D36154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36191: [CodeGen] Don't make availability attributes imply default visibility on macos

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM. Please document this change in the release notes. https://reviews.llvm.org/D36191 ___ cfe-commits mailing list

[PATCH] D36112: [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't available

arphaman added a comment. That makes sense. It's kinda weird not to report the `null`, but I guess it makes sense if the `null` sanitiser is off. It's not actually UB unless it's dereferenced, right, so casts are allowed? Comment at: test/CodeGenCXX/ubsan-type-checks.cpp:73

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

phosek accepted this revision. phosek added a comment. LGTM https://reviews.llvm.org/D35922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36259: [OpenCL] Remove extra select functions from opencl-c.h

yaxunl created this revision. OpenCL spec v2.0 s6.13.6: gentype select (gentype a, gentype b, igentype c) gentype select (gentype a, gentype b, ugentype c) igentype and ugentype must have the same number of elements and bits as gentype. https://reviews.llvm.org/D36259 Files:

[PATCH] D35820: [Driver] Search compiler-rt paths in -print-file-name=

phosek updated this revision to Diff 109485. Repository: rL LLVM https://reviews.llvm.org/D35820 Files: include/clang/Driver/ToolChain.h lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp Index: lib/Driver/ToolChain.cpp ===

r309912 - Update for llvm change.

Author: rafael Date: Wed Aug 2 19:16:28 2017 New Revision: 309912 URL: http://llvm.org/viewvc/llvm-project?rev=309912=rev Log: Update for llvm change. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp URL:

[libcxx] r309917 - Add system header pragma to BSD locale fallback headers.

Author: ericwf Date: Wed Aug 2 19:50:43 2017 New Revision: 309917 URL: http://llvm.org/viewvc/llvm-project?rev=309917=rev Log: Add system header pragma to BSD locale fallback headers. This prevent leaking warnings to the user about use of C++11 extensions in C++03. Modified:

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

t-tye added inline comments. Comment at: include/clang/Basic/SyncScope.h:23 +enum class SyncScope { + OpenCLWorkItem = 0, + OpenCLWorkGroup = 1, The OpenCL workitem scope is only used for image fences and does not apply to atomic operations so not sure that

[libcxx] r309920 - Fix libcxx build with glibc 2.26+ by removing xlocale.h include.

Author: ericwf Date: Wed Aug 2 21:28:10 2017 New Revision: 309920 URL: http://llvm.org/viewvc/llvm-project?rev=309920=rev Log: Fix libcxx build with glibc 2.26+ by removing xlocale.h include. Patch by Khem Raj. Reviewed as D35697. Also see PR33729. Modified: libcxx/trunk/include/__locale

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

rjmccall added inline comments. Comment at: lib/CodeGen/CGCXXABI.cpp:43 if (RD->hasNonTrivialDestructor()) return false; v.g.vassilev wrote: > rjmccall wrote: > > Does canPassInRegisters() not subsume all of these earlier checks? > No, if I remove them

Buildmaster restart

Hello everyone, LLVM buildmaster will be updated and restarted approximately at 08:00 AM PDT 4th August. -- Best Regards, Victor Leschuk | Software Engineer |Access Softek ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

rjmccall added a comment. The patch generally looks good, but if you need to handle non-constant scopes, you should submit a new patch to address that. Comment at: lib/CodeGen/CGAtomic.cpp:896 +return V; + auto DestAS =

[PATCH] D36208: [mips] Enable target-specific attributes for MIPS64

sdardis added a comment. I think for the interrupt attribute, it should be an error. Currently it's an implementation detail that it errors out in the backend but in principal it can be supported (I haven't gotten around to addressing it.) For the micromips attribute, I believe it should be an

[clang-tools-extra] r309810 - Adapt clang-tidy checks to changing semantics of hasDeclaration.

Author: klimek Date: Wed Aug 2 06:13:11 2017 New Revision: 309810 URL: http://llvm.org/viewvc/llvm-project?rev=309810=rev Log: Adapt clang-tidy checks to changing semantics of hasDeclaration. Differential Revision: https://reviews.llvm.org/D36154 Modified:

[PATCH] D36154: Adapt clang-tidy checks to changing semantics of hasDeclaration.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309810: Adapt clang-tidy checks to changing semantics of hasDeclaration. (authored by klimek). Repository: rL LLVM https://reviews.llvm.org/D36154 Files:

[PATCH] D36176: [clang-diff] Fix some errors and inconsistencies

johannes added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:96 : TreeImpl(llvm::make_unique(this, Node, AST)) {} + SyntaxTree(const SyntaxTree ) = delete; ~SyntaxTree(); arphaman wrote: > It might be better to add a move

[PATCH] D36156: [rename] Introduce symbol occurrences

arphaman updated this revision to Diff 109326. arphaman added a comment. Address review comments. Repository: rL LLVM https://reviews.llvm.org/D36156 Files: include/clang/Tooling/Refactoring/Rename/RenamingAction.h include/clang/Tooling/Refactoring/Rename/SymbolName.h

[PATCH] D36217: Fix parsing of <>-style proto options

krasimir created this revision. This patch fixes the parsing of proto option fields like `option op = <...>`. Previously the parser did not enter the right code path inside the angle braces, causing the contents to be split into several unwrapped lines inside. https://reviews.llvm.org/D36217

[PATCH] D36208: [mips] Enable target-specific attributes for MIPS64

aaron.ballman added a comment. In https://reviews.llvm.org/D36208#828881, @atanasyan wrote: > In https://reviews.llvm.org/D36208#828853, @sdardis wrote: > > > Currently there is no support in the backend for the interrupt attribute > > for mips64 / using N32 & N64 abis, it will give a fatal

[PATCH] D36176: [clang-diff] Fix some errors and inconsistencies

arphaman added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:96 : TreeImpl(llvm::make_unique(this, Node, AST)) {} + SyntaxTree(const SyntaxTree ) = delete; ~SyntaxTree(); johannes wrote: > arphaman wrote: > > It might be better

[PATCH] D27104: Unify and simplify the behavior of the hasDeclaration matcher.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309809: Unify and simplify the behavior of the hasDeclaration matcher. (authored by klimek). Changed prior to commit: https://reviews.llvm.org/D27104?vs=108608=109325#toc Repository: rL LLVM

r309809 - Unify and simplify the behavior of the hasDeclaration matcher.

Author: klimek Date: Wed Aug 2 06:04:44 2017 New Revision: 309809 URL: http://llvm.org/viewvc/llvm-project?rev=309809=rev Log: Unify and simplify the behavior of the hasDeclaration matcher. Originally, we weren't able to match on Type nodes themselves (only QualType), so the hasDeclaration

[PATCH] D36143: [clang-format] Fix indent of 'key <...>' in text protos

krasimir updated this revision to Diff 109322. krasimir added a comment. - Fix similar issue for 'key {...}' https://reviews.llvm.org/D36143 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestProto.cpp unittests/Format/FormatTestTextProto.cpp Index:

[PATCH] D36208: [mips] Enable target-specific attributes for MIPS64

aaron.ballman added a comment. In https://reviews.llvm.org/D36208#828955, @sdardis wrote: > I think for the interrupt attribute, it should be an error. Currently it's an > implementation detail that it errors out in the backend but in principal it > can be supported (I haven't gotten around to

  1   2   >