[PATCH] D36184: [clang-diff] Filter AST nodes

klimek added a comment. Just as a general note: adding cfe-commits after the fact is usually not a good idea, as we lose the history of the review in the email list (which is the source of truth). https://reviews.llvm.org/D36184 ___ cfe-commits

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle added a comment. In https://reviews.llvm.org/D35894#828702, @ilya-biryukov wrote: > I just wanted to take a step back and discuss what we want to get from code > hover in the first place. > > I would expect a typical code hover to be a bit more involved and include: > > - "kind" of a

[PATCH] D36083: [utils] Add a script that runs clang in LLDB and stops it when a specified diagnostic is emitted

hintonda added a comment. In https://reviews.llvm.org/D36083#827745, @arphaman wrote: > Makes sense. I'll see if I can get somewhere with the regex idea. Btw, I created a quick prototype with sed and found that the diag strings aren't unique -- which isn't surprising since there's no

r309815 - Define _GNU_SOURCE for RTEMS c++

Author: waltl Date: Wed Aug 2 07:36:52 2017 New Revision: 309815 URL: http://llvm.org/viewvc/llvm-project?rev=309815=rev Log: Define _GNU_SOURCE for RTEMS c++ Summary: This is required by the libc++ locale support. Reviewers: jyknight Subscribers: fedor.sergeev Differential Revision:

[libclc] r309820 - configure.py: Make python3 friendly

Author: jvesely Date: Wed Aug 2 08:00:59 2017 New Revision: 309820 URL: http://llvm.org/viewvc/llvm-project?rev=309820=rev Log: configure.py: Make python3 friendly mostly prints and exceptions. Few behavioral changes are documented in the text Generated Makefile is identical between python2 and

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle added a comment. In https://reviews.llvm.org/D35894#829109, @ilya-biryukov wrote: > > I think all of those would be great. Our objective is to bring basic but > > correct features that will put us close to parity with Eclipse CDT, so that > > our users can transition. In CDT only the

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle added a comment. @Nebiroth I think it's OK to put this on hold until we make the "semantic" hover and figure out how to have both. From our perspective, this is going beyond parity of what we had before but it's seems like the right thing to do. https://reviews.llvm.org/D35894

[PATCH] D33676: Place implictly declared functions at block scope

chill added inline comments. Comment at: lib/Parse/ParseCXXInlineMethods.cpp:521-522 // to be re-used for method bodies as well. - ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope); + ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope| +

[PATCH] D31814: Add option to add command-line options and version info to output file

christof commandeered this revision. christof added a reviewer: salari01. christof added a comment. Herald added a subscriber: aheejin. With the ok of the author, I'll try to get some movement on this work again. https://reviews.llvm.org/D31814 ___

Lab is down

Hello all, buildbot is currently down due to hardware failure. We are currently working on it. Sorry for the inconvenience. -- Best Regards, Victor ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: Lab is down

There is power outage in the area where the servers are located. They say the power will be restored at 10:45 AM PDT, I'd estimate buildbot online time about ~12:00. On 08/02/2017 06:31 PM, Victor Leschuk wrote: > Hello all, buildbot is currently down due to hardware failure. We are > currently

[PATCH] D36208: [mips] Enable target-specific attributes for MIPS64

sdardis added a comment. @aaron.ballman I missed your first comments when I'd submitted mine. In https://reviews.llvm.org/D36208#828957, @aaron.ballman wrote: > In https://reviews.llvm.org/D36208#828955, @sdardis wrote: > > > I think for the interrupt attribute, it should be an error. Currently

[PATCH] D36208: [mips] Enable target-specific attributes for MIPS64

aaron.ballman added a comment. In https://reviews.llvm.org/D36208#829006, @sdardis wrote: > @aaron.ballman I missed your first comments when I'd submitted mine. > > In https://reviews.llvm.org/D36208#828957, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D36208#828955, @sdardis wrote: >

r309813 - [rename] NFC, extract symbol canonicalization logic into function

Author: arphaman Date: Wed Aug 2 07:15:27 2017 New Revision: 309813 URL: http://llvm.org/viewvc/llvm-project?rev=309813=rev Log: [rename] NFC, extract symbol canonicalization logic into function This function will be used by the clang-refactor's rename actions Modified:

[PATCH] D33676: Place implictly declared functions at block scope

aaron.ballman added inline comments. Comment at: lib/Parse/ParseCXXInlineMethods.cpp:521-522 // to be re-used for method bodies as well. - ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope); + ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope| +

[PATCH] D36156: [rename] Introduce symbol occurrences

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/Rename/SymbolOccurrences.h:65-68 + ArrayRef getNameLocations() const { return Locations; } + ArrayRef getNameLengths() const { +return llvm::makeArrayRef(NameLengths, Locations.size()); + }

[PATCH] D36156: [rename] Introduce symbol occurrences

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/Rename/SymbolOccurrences.h:65-68 + ArrayRef getNameLocations() const { return Locations; } + ArrayRef getNameLengths() const { +return llvm::makeArrayRef(NameLengths, Locations.size()); + }

[PATCH] D36200: [Sema] Improve some -Wunguarded-availability diagnostic messages

arphaman added a comment. This needs a test for the fixits as well, see test/FixIt/fixit-availability* https://reviews.llvm.org/D36200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35894: [clangd] Code hover for Clangd

ilya-biryukov added a comment. > I think all of those would be great. Our objective is to bring basic but > correct features that will put us close to parity with Eclipse CDT, so that > our users can transition. In CDT only the "raw" source is shown, similar to > this patch (except in CDT it

[PATCH] D33676: Place implictly declared functions at block scope

chill updated this revision to Diff 109366. chill added a comment. Updated with only whitespace changes after formating each changed line with clang-format. https://reviews.llvm.org/D33676 Files: include/clang/Sema/Scope.h lib/Parse/ParseCXXInlineMethods.cpp lib/Parse/ParseDecl.cpp

[PATCH] D33676: Place implictly declared functions at block scope

chill added a comment. Thanks for the review, I'll wait a few days. https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36200: [Sema] Improve some -Wunguarded-availability diagnostic messages

erik.pilkington added a comment. In https://reviews.llvm.org/D36200#829104, @arphaman wrote: > This needs a test for the fixits as well, see test/FixIt/fixit-availability* Why? This patch doesn't change the behavior of the fixits, so there isn't any new behavior to test.

[PATCH] D36200: [Sema] Improve some -Wunguarded-availability diagnostic messages

arphaman added a comment. Right, sorry, I didn't realize that code was moved. https://reviews.llvm.org/D36200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36044: [OpenCL] -cl-ext option can overwrite OpenCL features imported from a module

Anastasia added inline comments. Comment at: include/clang/Basic/OpenCLOptions.h:132 - void disableAll() { + void enableAll(bool On = true) { for (llvm::StringMap::iterator I = OptMap.begin(), May be the name could be `setAll` since it's doing both

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

aaron.ballman added inline comments. Comment at: clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:23 + memberExpr(hasDeclaration(anyOf(cxxMethodDecl(isStaticStorageClass()), + varDecl(hasStaticStorageDuration(, +

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

aaron.ballman added a comment. In https://reviews.llvm.org/D33672#827513, @xazax.hun wrote: > Even though it is not undefined behavior in C, it can still cause surprising > behavior for the users. I think maybe putting it into the optin package > instead of cplusplus is better. What do you

[PATCH] D36230: [X86][Asm] Allow negative immediate to appear before bracketed expression

coby created this revision. Herald added a subscriber: eraman. Currently, only non-negative immediate is allowed prior to a brac expression (memory reference). MASM / GAS does not have any problem cope with the left side of the real line, so we should be able to as well. llvm:

[libcxx] r309838 - Fix PR33727: std::basic_stringbuf only works with DefaultConstructible allocators. Thanks to Jonathan Wakely for the report and suggested fix

Author: marshall Date: Wed Aug 2 10:31:09 2017 New Revision: 309838 URL: http://llvm.org/viewvc/llvm-project?rev=309838=rev Log: Fix PR33727: std::basic_stringbuf only works with DefaultConstructible allocators. Thanks to Jonathan Wakely for the report and suggested fix Modified:

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

aaron.ballman added inline comments. Comment at: lib/Driver/ToolChains/Gnu.cpp:1511 + StringRef Suff64 = "/64"; + // Solaris uses platform-specific suffixes instead of /64 + if (TargetTriple.getOS() == llvm::Triple::Solaris) { Add a period at the end of the

[PATCH] D36226: Added a RealFileSystem implementation that does not rely on global CWD.

ilya-biryukov created this revision. Allows to have multiple instances of RealFileSystem that have different working directories. https://reviews.llvm.org/D36226 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp unittests/Basic/VirtualFileSystemTest.cpp

[PATCH] D36226: Added a RealFileSystem implementation that does not rely on global CWD.

ilya-biryukov added a comment. Also tested by temporarily replacing `getRealFileSystem()` body with `return createThreadFriendlyRealFS();` and running `check-all`, all tests passed. To be more specific, there was one crash in clang-format, as there is a piece of code that uses raw pointer from

Re: Lab is down

Buildbot is up and running. Sorry for the delay. On 08/02/2017 06:31 PM, Victor Leschuk wrote: > Hello all, buildbot is currently down due to hardware failure. We are > currently working on it. Sorry for the inconvenience. > -- Best Regards, Victor

[PATCH] D36191: [CodeGen] Don't make availability attributes imply default visibility on macos

thakis added a comment. Awesome, thanks! Maybe mention the PR# for this in the commit message. https://reviews.llvm.org/D36191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D36202: [Driver] Disable static C++ library support on Fuchsia

Should clang warn if you request static libc++ on fuchsia? It now silently ignores the flag, right? On Aug 1, 2017 9:18 PM, "Petr Hosek via Phabricator via cfe-commits" < cfe-commits@lists.llvm.org> wrote: This revision was automatically updated to reflect the committed changes. Closed by commit

[PATCH] D33676: Place implictly declared functions at block scope

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This looks reasonable to me, once it's been formatted. Let's give @rsmith a few days to comment before committing, though. https://reviews.llvm.org/D33676

Re: r309523 - Also pass -pie back to the linker when linking on OpenBSD.

Merged to 5.0 in r309844. On Sun, Jul 30, 2017 at 2:14 PM, Brad Smith via cfe-commits wrote: > Author: brad > Date: Sun Jul 30 14:13:59 2017 > New Revision: 309523 > > URL: http://llvm.org/viewvc/llvm-project?rev=309523=rev > Log: > Also pass -pie back to the linker

[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

bruno added inline comments. Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:136 +if (ThreadPointer == ReadTPMode::Invalid && +!StringRef(A->getValue()).empty()) { + D.Diag(diag::err_drv_invalid_mtp) << A->getAsString(Args); What happens if you

[PATCH] D36112: [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't available

vsk marked an inline comment as done. vsk added a comment. In https://reviews.llvm.org/D36112#828891, @arphaman wrote: > That makes sense. It's kinda weird not to report the `null`, but I guess it > makes sense if the `null` sanitiser is off. It is kinda weird, but any such diagnostic would

Re: r305903 - Function with unparsed body is a definition

At first thank you for the nice test case. This crash is not caused by r305903. The root cause is that instantiation of f is triggered when parse of f is not finished yet. This is the case just addressed by that change. The instantiation is requested by the code (https://github.com/llvm-mirro

r309846 - [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't available

Author: vedantk Date: Wed Aug 2 11:10:31 2017 New Revision: 309846 URL: http://llvm.org/viewvc/llvm-project?rev=309846=rev Log: [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't available In r309007, I made -fsanitize=null a hard prerequisite for -fsanitize=vptr. I did

[PATCH] D36112: [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't available

This revision was automatically updated to reflect the committed changes. Closed by commit rL309846: [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't… (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D36112?vs=108988=109385#toc Repository: rL

<    1   2