[PATCH] D36148: clang-format: [JS] support fields with case/switch/default labels.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D36148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r310030 - Revert r309984, "Use "foo-12345.o" instead of "foo.o-12345" as temporary file name."

Author: chapuni Date: Thu Aug 3 23:35:32 2017 New Revision: 310030 URL: http://llvm.org/viewvc/llvm-project?rev=310030=rev Log: Revert r309984, "Use "foo-12345.o" instead of "foo.o-12345" as temporary file name." It generates MODULE--.pcm, then GlobalModuleIndex.cpp is

[PATCH] D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

chapuni reopened this revision. chapuni added a comment. This revision is now accepted and ready to land. Excuse me, I have reverted this in https://reviews.llvm.org/rL310030 to unbreak -fmodules. See GlobalModuleIndex.cpp. It seeks the suffix ".pcm". https://reviews.llvm.org/D36238

[PATCH] D35955: clang-format: Add preprocessor directive indentation

djasper added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:383 + Current.Previous->is(tok::hash) && State.FirstIndent > 0) { +// subtract 1 so indent lines up with non-preprocessor code +Spaces += State.FirstIndent; euhlmann

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

baloghadamsoftware added a comment. What do you suggest? Should we widen the type of the difference, or abandon this patch and revert back to the local solution I originally used in the iterator checker? https://reviews.llvm.org/D35109 ___

[clang-tools-extra] r310035 - [clang-tidy] Support initializer-list constructor cases in modernize-make-unique.

Author: hokein Date: Fri Aug 4 01:07:05 2017 New Revision: 310035 URL: http://llvm.org/viewvc/llvm-project?rev=310035=rev Log: [clang-tidy] Support initializer-list constructor cases in modernize-make-unique. Reviewers: alexfh Reviewed By: alexfh Subscribers: malcolm.parsons, JDevlieghere,

[PATCH] D36016: [clang-tidy] Support initializer-list constructor cases in modernize-make-unique.

This revision was automatically updated to reflect the committed changes. Closed by commit rL310035: [clang-tidy] Support initializer-list constructor cases in modernize-make… (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D36016 Files:

[PATCH] D35826: [Driver] Error if ARM mode was selected explicitly for M-profile CPUs.

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. This makes sense to me. LGTM. Thanks! https://reviews.llvm.org/D35826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r308619 - Reland "[mips] Teach the driver to accept -m(no-)gpopt."

On Thu, Jul 20, 2017 at 5:04 PM, Simon Dardis via cfe-commits wrote: > Reland "[mips] Teach the driver to accept -m(no-)gpopt." > > This patch teaches the driver to pass -mgpopt by default to the backend when > it > is supported, i.e. we are using -mno-abicalls.

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

martell added a comment. @rnk isn't this related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78936 Assuming this is in fact a gcc bug this will most likely cause a regression with the standalone clang mingw toolchains we are on the verge of having. This is of course assuming clang does not

[PATCH] D36264: [clang-tidy] Ignore macros in make-unique check.

hokein updated this revision to Diff 109701. hokein marked 2 inline comments as done. hokein added a comment. Address review comments. https://reviews.llvm.org/D36264 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/modernize/MakeSmartPtrCheck.h

[PATCH] D36264: [clang-tidy] Ignore macros in make-unique check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL310050: [clang-tidy] Ignore macros in make-unique check. (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D36264 Files:

[clang-tools-extra] r310050 - [clang-tidy] Ignore macros in make-unique check.

Author: hokein Date: Fri Aug 4 04:18:00 2017 New Revision: 310050 URL: http://llvm.org/viewvc/llvm-project?rev=310050=rev Log: [clang-tidy] Ignore macros in make-unique check. Summary: The check doesn't fully support smart-ptr usages inside macros, which may cause incorrect fixes, or even

r310047 - [Driver] Error if ARM mode was selected explicitly for M-profile CPUs.

Author: fhahn Date: Fri Aug 4 03:40:18 2017 New Revision: 310047 URL: http://llvm.org/viewvc/llvm-project?rev=310047=rev Log: [Driver] Error if ARM mode was selected explicitly for M-profile CPUs. Summary: M-class profiles do not support ARM execution mode, so providing -marm/-mno-thumb does

[PATCH] D36264: [clang-tidy] Ignore macros in make-unique check.

alexfh accepted this revision. alexfh added a comment. LG with a couple of nits. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:54 + Options.get("MakeSmartPtrFunction", MakeSmartPtrFunctionName)), + IgnoreMacros(Options.get("IgnoreMacros", true)) {}

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

arphaman added a comment. Don't you need `// UNSUPPORTED: c++98, c++03` since `std::function` is supported in C++11 only? https://reviews.llvm.org/D34331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36019: [clang-format] Fix bug with ENAS_DontAlign and empty lines

djasper added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:650 +for (unsigned i = 0; i < Newlines; ++i) + Text.append(UseCRLF ? " \\\r\n" : " \\\n"); +return; Note that when you have an empty line, this would turn into: #define A

r310038 - [mips] Fix typo (missed space) in the warning message

Author: atanasyan Date: Fri Aug 4 01:25:15 2017 New Revision: 310038 URL: http://llvm.org/viewvc/llvm-project?rev=310038=rev Log: [mips] Fix typo (missed space) in the warning message Modified: cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D36264: [clang-tidy] Ignore macros in make-unique check.

hokein updated this revision to Diff 109691. hokein marked an inline comment as done. hokein added a comment. Add a missing test file. https://reviews.llvm.org/D36264 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/modernize/MakeSmartPtrCheck.h

[PATCH] D35847: clang-format: Fix left pointer alignment after delctype/typeof

krasimir added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1402 +PrevToken->MatchingParen->getPreviousNonComment() && +PrevToken->MatchingParen->getPreviousNonComment()->isOneOf( + tok::kw_typeof, It would be cool if you

[PATCH] D36264: [clang-tidy] Ignore macros in make-unique check.

hokein added a comment. Please take another look. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:114 - if (Construct) + if (Construct && !Construct->getLocation().isMacroID()) checkConstruct(SM, Construct, Type, New); alexfh wrote: > Seems to

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. This is probably not a final version, but I feel my comments should be helpful anyway. Also, we're missing testcases now. Comment at:

[PATCH] D34992: Emit static constexpr member as available_externally definition

mehdi_amini marked 6 inline comments as done. mehdi_amini added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2293 /// If ExcludeCtor is true, the duration when the object's constructor runs -/// will not be considered. The caller will need to verify that the

r310037 - [mips] Code formatting fix. NFC

Author: atanasyan Date: Fri Aug 4 01:25:09 2017 New Revision: 310037 URL: http://llvm.org/viewvc/llvm-project?rev=310037=rev Log: [mips] Code formatting fix. NFC Modified: cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp URL:

[PATCH] D36264: [clang-tidy] Ignore macros in make-unique check.

hokein updated this revision to Diff 109690. hokein added a comment. Add IgnoreMacros option. https://reviews.llvm.org/D36264 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/modernize/MakeSmartPtrCheck.h docs/clang-tidy/checks/modernize-make-unique.rst

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan added a comment. ping. Do you think this is ok now? https://reviews.llvm.org/D34873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r310041 - Fix typo and update documentation.

Author: klimek Date: Fri Aug 4 01:41:42 2017 New Revision: 310041 URL: http://llvm.org/viewvc/llvm-project?rev=310041=rev Log: Fix typo and update documentation. The hasDeclaration documentation was outdated after r288366. Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D34992: Emit static constexpr member as available_externally definition

mehdi_amini updated this revision to Diff 109694. mehdi_amini marked 12 inline comments as done. mehdi_amini added a comment. Address Richard's comment https://reviews.llvm.org/D34992 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGenCXX/cxx11-extern-constexpr.cpp Index:

[PATCH] D35847: clang-format: Fix left pointer alignment after delctype/typeof

euhlmann updated this revision to Diff 109785. euhlmann added a comment. Pulled out `getPreviousNonComment()` into local variable to avoid calling twice. https://reviews.llvm.org/D35847 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index:

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

t.p.northover added a comment. I've added "cfe-commits" as a subscriber since that's how we make sure the review request gets to the mailing list (which is still where review canonically takes place). Repository: rL LLVM https://reviews.llvm.org/D36272

r310120 - [OPENMP] Fix for pacify buildbots, NFC.

Author: abataev Date: Fri Aug 4 13:29:52 2017 New Revision: 310120 URL: http://llvm.org/viewvc/llvm-project?rev=310120=rev Log: [OPENMP] Fix for pacify buildbots, NFC. Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp URL:

r310134 - Revert "[OPENMP] Fix for pacify buildbots, NFC."

Author: abataev Date: Fri Aug 4 14:26:25 2017 New Revision: 310134 URL: http://llvm.org/viewvc/llvm-project?rev=310134=rev Log: Revert "[OPENMP] Fix for pacify buildbots, NFC." This reverts commit r310120. Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp Modified:

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

morehouse added inline comments. Comment at: clang/cmake/modules/ProtobufMutator.cmake:13 +-DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER} +-DCMAKE_BUILD_TYPE=Debug + BUILD_COMMAND ${CMAKE_MAKE_PROGRAM} vitalybuka wrote: > Why this is debug? > I was just

r310121 - Revert "Reland "CFI: blacklist STL allocate() from unrelated-casts""

Author: vlad.tsyrklevich Date: Fri Aug 4 13:37:49 2017 New Revision: 310121 URL: http://llvm.org/viewvc/llvm-project?rev=310121=rev Log: Revert "Reland "CFI: blacklist STL allocate() from unrelated-casts"" This reverts commit r310105. Removed: cfe/trunk/test/CodeGen/cfi-unrelated-cast.cpp

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

vitalybuka added inline comments. Comment at: clang/cmake/modules/ProtobufMutator.cmake:13 +-DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER} +-DCMAKE_BUILD_TYPE=Debug + BUILD_COMMAND ${CMAKE_MAKE_PROGRAM} Why this is debug? Comment at:

r310137 - [Support] Use FILE_SHARE_DELETE to fix RemoveFileOnSignal on Windows

Author: rnk Date: Fri Aug 4 14:52:00 2017 New Revision: 310137 URL: http://llvm.org/viewvc/llvm-project?rev=310137=rev Log: [Support] Use FILE_SHARE_DELETE to fix RemoveFileOnSignal on Windows Summary: Tools like clang that use RemoveFileOnSignal on their output files weren't actually able to

r310138 - [libclang] Determinize order of platform availability attrs

Author: rnk Date: Fri Aug 4 14:52:25 2017 New Revision: 310138 URL: http://llvm.org/viewvc/llvm-project?rev=310138=rev Log: [libclang] Determinize order of platform availability attrs Previously this code was doing std::sort on IdentifierInfo pointers. Now it sorts alphabetically by platform

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

ahatanak updated this revision to Diff 109814. ahatanak added a comment. Include noescape attribute information in the function prototype and modify the AST printer and name mangling accordingly. Also, make changes to allow implicit conversion from a function that takes noescape parameters to

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

ahatanak added inline comments. Comment at: lib/CodeGen/CGCall.cpp:2096 +if (FI.getExtParameterInfo(ArgNo).isNoEscape()) + Attrs.addAttribute(llvm::Attribute::NoCapture); + rjmccall wrote: > ahatanak wrote: > > rjmccall wrote: > > > You should make sure

r310132 - Reland "CFI: blacklist STL allocate() from unrelated-casts"

Author: vlad.tsyrklevich Date: Fri Aug 4 14:21:00 2017 New Revision: 310132 URL: http://llvm.org/viewvc/llvm-project?rev=310132=rev Log: Reland "CFI: blacklist STL allocate() from unrelated-casts" Reland r310097 with a fix for a debug assertion in NamedDecl.getName() Differential Revision:

r310135 - Revert "[OPENMP][DEBUG] Set proper address space info if required by target."

Author: abataev Date: Fri Aug 4 14:27:11 2017 New Revision: 310135 URL: http://llvm.org/viewvc/llvm-project?rev=310135=rev Log: Revert "[OPENMP][DEBUG] Set proper address space info if required by target." This reverts commit r310104. Removed:

r310136 - [libFuzzer] add -fsanitize-coverage-pc-table to -fsanitize=fuzzer

Author: kcc Date: Fri Aug 4 14:35:11 2017 New Revision: 310136 URL: http://llvm.org/viewvc/llvm-project?rev=310136=rev Log: [libFuzzer] add -fsanitize-coverage-pc-table to -fsanitize=fuzzer Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp cfe/trunk/test/Driver/fuzzer.c Modified:

r310070 - clang-format: [JS] support fields with case/switch/default labels.

Author: mprobst Date: Fri Aug 4 10:07:15 2017 New Revision: 310070 URL: http://llvm.org/viewvc/llvm-project?rev=310070=rev Log: clang-format: [JS] support fields with case/switch/default labels. Summary: `case:` and `default:` would normally parse as labels for a `switch` block. However in

[PATCH] D36148: clang-format: [JS] support fields with case/switch/default labels.

This revision was automatically updated to reflect the committed changes. Closed by commit rL310070: clang-format: [JS] support fields with case/switch/default labels. (authored by mprobst). Repository: rL LLVM https://reviews.llvm.org/D36148 Files:

r310098 - [OPENMP] Unify generation of outlined function calls.

Author: abataev Date: Fri Aug 4 12:10:54 2017 New Revision: 310098 URL: http://llvm.org/viewvc/llvm-project?rev=310098=rev Log: [OPENMP] Unify generation of outlined function calls. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D36294: CFI: blacklist STL allocate() from unrelated-casts

This revision was automatically updated to reflect the committed changes. Closed by commit rL310097: CFI: blacklist STL allocate() from unrelated-casts (authored by vlad.tsyrklevich). Repository: rL LLVM https://reviews.llvm.org/D36294 Files: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp

r310099 - Revert "CFI: blacklist STL allocate() from unrelated-casts"

Author: vlad.tsyrklevich Date: Fri Aug 4 12:17:16 2017 New Revision: 310099 URL: http://llvm.org/viewvc/llvm-project?rev=310099=rev Log: Revert "CFI: blacklist STL allocate() from unrelated-casts" This reverts commit r310097. Removed: cfe/trunk/test/CodeGen/cfi-unrelated-cast.cpp Modified:

r310105 - Reland "CFI: blacklist STL allocate() from unrelated-casts"

Author: vlad.tsyrklevich Date: Fri Aug 4 12:50:39 2017 New Revision: 310105 URL: http://llvm.org/viewvc/llvm-project?rev=310105=rev Log: Reland "CFI: blacklist STL allocate() from unrelated-casts" Reland r310097 with a unit test fix for MS ABI build bots. Differential Revision:

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

thakis added a comment. Why should this be part of llvm? This seems to come with very heavy dependencies (protobuf), and LLVM has historically tried to minimize the number of things it depends on. https://reviews.llvm.org/D36324 ___ cfe-commits

[PATCH] D36308: Add handling for DeducedType to HasDeclarationMatcher

This revision was automatically updated to reflect the committed changes. Closed by commit rL310095: [ASTMatcher] Add handling for DeducedType to HasDeclarationMatcher (authored by fgross). Changed prior to commit: https://reviews.llvm.org/D36308?vs=109795=109796#toc Repository: rL LLVM

r310095 - [ASTMatcher] Add handling for DeducedType to HasDeclarationMatcher

Author: fgross Date: Fri Aug 4 11:59:19 2017 New Revision: 310095 URL: http://llvm.org/viewvc/llvm-project?rev=310095=rev Log: [ASTMatcher] Add handling for DeducedType to HasDeclarationMatcher HasDeclarationMatcher did not handle DeducedType, it always returned false for deduced types. So

r310097 - CFI: blacklist STL allocate() from unrelated-casts

Author: vlad.tsyrklevich Date: Fri Aug 4 12:10:11 2017 New Revision: 310097 URL: http://llvm.org/viewvc/llvm-project?rev=310097=rev Log: CFI: blacklist STL allocate() from unrelated-casts Summary: Previously, STL allocators were blacklisted in compiler_rt's cfi_blacklist.txt because they

[PATCH] D35847: clang-format: Fix left pointer alignment after delctype/typeof

euhlmann updated this revision to Diff 109805. euhlmann added a comment. Fix bad formatting https://reviews.llvm.org/D35847 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

yawanng updated this revision to Diff 109778. yawanng marked 13 inline comments as done. https://reviews.llvm.org/D35372 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecCheck.cpp clang-tidy/android/CloexecCheck.h

[clang-tools-extra] r310096 - [clang-tidy] Added clang-tidy test cases related to rL310095

Author: fgross Date: Fri Aug 4 12:01:56 2017 New Revision: 310096 URL: http://llvm.org/viewvc/llvm-project?rev=310096=rev Log: [clang-tidy] Added clang-tidy test cases related to rL310095 Differential Revision: https://reviews.llvm.org/D36308 Modified:

r310082 - Add OpenCL 2.0 atomic builtin functions as Clang builtin

Author: yaxunl Date: Fri Aug 4 11:16:31 2017 New Revision: 310082 URL: http://llvm.org/viewvc/llvm-project?rev=310082=rev Log: Add OpenCL 2.0 atomic builtin functions as Clang builtin OpenCL 2.0 atomic builtin functions have a scope argument which is ideally represented as synchronization scope

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rL310082: Add OpenCL 2.0 atomic builtin functions as Clang builtin (authored by yaxunl). Changed prior to commit:

[PATCH] D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

yawanng added inline comments. Comment at: clang-tidy/android/CloexecCheck.h:72 + StringRef getSpellingArg(const ast_matchers::MatchFinder::MatchResult , + int n); + hokein wrote: > `n` should be capital `N`. I think we can make it a

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

kcc added a comment. In https://reviews.llvm.org/D36324#832271, @thakis wrote: > Why should this be part of llvm? This seems to come with very heavy > dependencies (protobuf), and LLVM has historically tried to minimize the > number of things it depends on. This fuzzer has already uncovered

[PATCH] D36308: Add handling for DeducedType to HasDeclarationMatcher

fgross updated this revision to Diff 109795. fgross added a comment. Changed comment, added some clang-tidy test cases. https://reviews.llvm.org/D36308 Files: include/clang/ASTMatchers/ASTMatchersInternal.h test/clang-tidy/misc-use-after-move.cpp

[PATCH] D36336: [X86] Add support for __builtin_cpu_init

craig.topper created this revision. This adds __builtin_cpu_init which will emit a call to __cpu_indicator_init in libgcc or compiler-rt. This is needed to support __builtin_cpu_supports/__builtin_cpu_is in an ifunc resolver. https://reviews.llvm.org/D36336 Files:

r310104 - [OPENMP][DEBUG] Set proper address space info if required by target.

Author: abataev Date: Fri Aug 4 12:46:10 2017 New Revision: 310104 URL: http://llvm.org/viewvc/llvm-project?rev=310104=rev Log: [OPENMP][DEBUG] Set proper address space info if required by target. Arguments, passed to the outlined function, must have correct address space info for proper Debug

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

vitalybuka added inline comments. Comment at: clang/tools/clang-fuzzer/CMakeLists.txt:12 +# Hack to bypass LLVM's cmake sources check and allow multiple libraries and +# executables from this directory. +set(LLVM_OPTIONAL_SOURCES morehouse wrote: >

r310147 - Debug Info: Set the DICompileUnit's isOptimized flag when compiling with LTO.

Author: adrian Date: Fri Aug 4 16:08:57 2017 New Revision: 310147 URL: http://llvm.org/viewvc/llvm-project?rev=310147=rev Log: Debug Info: Set the DICompileUnit's isOptimized flag when compiling with LTO. rdar://problem/27640939 Added: cfe/trunk/test/CodeGen/debug-info-lto.c Modified:

[PATCH] D35925: [Coverage] Precise region termination with deferred regions

vsk added a comment. Reverted in r310154, because llvm-cov isn't doing a good job of displaying the new regions properly. I'll re-land this after llvm-cov is fixed. https://reviews.llvm.org/D35925 ___ cfe-commits mailing list

r310158 - [ODRHash] Treat some non-templated classes as templated.

Author: rtrieu Date: Fri Aug 4 17:54:19 2017 New Revision: 310158 URL: http://llvm.org/viewvc/llvm-project?rev=310158=rev Log: [ODRHash] Treat some non-templated classes as templated. When using nested classes, if the inner class is not templated, but the outer class is templated, the inner

[PATCH] D30748: [Lexer] Finding beginning of token with escaped new line

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one nit. Do you need someone to commit the patch for you after you address the comment? Comment at: lib/Lex/Lexer.cpp:469-477 +if

Re: r305903 - Function with unparsed body is a definition

Thank you for the analysis! It would be nice if you could implement a short term workaround to avoid crashes. Maybe Richard has ideas on what a proper solution should look like. On Wed, Aug 2, 2017 at 8:05 PM, Serge Pavlov wrote: > At first thank you for the nice test case.

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

phosek created this revision. Herald added a subscriber: mgorny. Repository: rL LLVM https://reviews.llvm.org/D36349 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === ---

r310154 - Revert "[Coverage] Precise region termination with deferred regions"

Author: vedantk Date: Fri Aug 4 17:34:10 2017 New Revision: 310154 URL: http://llvm.org/viewvc/llvm-project?rev=310154=rev Log: Revert "[Coverage] Precise region termination with deferred regions" This reverts commit r310010. I don't think there's anything wrong with this commit, but it's

[libcxx] r310155 - [libcxx] [test] Consistently list "c++98, c++03" in chronological order. NFC.

Author: stl_msft Date: Fri Aug 4 17:44:19 2017 New Revision: 310155 URL: http://llvm.org/viewvc/llvm-project?rev=310155=rev Log: [libcxx] [test] Consistently list "c++98, c++03" in chronological order. NFC. Modified: libcxx/trunk/test/std/iterators/iterator.range/begin-end.pass.cpp

[libcxx] r310157 - [libcxx] [test] Untabify stringstream.cons/string.pass.cpp. NFC.

Author: stl_msft Date: Fri Aug 4 17:44:27 2017 New Revision: 310157 URL: http://llvm.org/viewvc/llvm-project?rev=310157=rev Log: [libcxx] [test] Untabify stringstream.cons/string.pass.cpp. NFC. Modified: libcxx/trunk/test/std/input.output/string.streams/stringstream.cons/string.pass.cpp

[libcxx] r310156 - [libcxx] [test] Fix URLs in comments and make them HTTPS. NFC.

Author: stl_msft Date: Fri Aug 4 17:44:24 2017 New Revision: 310156 URL: http://llvm.org/viewvc/llvm-project?rev=310156=rev Log: [libcxx] [test] Fix URLs in comments and make them HTTPS. NFC. Modified:

[PATCH] D36250: [coverage] Special-case calls to noreturn functions.

vsk added a comment. I tested this out on clang's ItaniumMangle.cpp and the crash is resolved. Comment at: lib/CodeGen/CoverageMappingGen.cpp:723 + this->Visit(Child); +handleFileExit(getEnd(E)); + This is doing the right thing. I think it should just

r310160 - [OpenCL] Remove extra select functions from opencl-c.h

Author: yaxunl Date: Fri Aug 4 19:23:47 2017 New Revision: 310160 URL: http://llvm.org/viewvc/llvm-project?rev=310160=rev Log: [OpenCL] Remove extra select functions from opencl-c.h OpenCL spec v2.0 s6.13.6: gentype select (gentype a, gentype b, igentype c) gentype select (gentype a, gentype

[PATCH] D36259: [OpenCL] Remove extra select functions from opencl-c.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL310160: [OpenCL] Remove extra select functions from opencl-c.h (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D36259?vs=109486=109845#toc Repository: rL LLVM

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

phosek updated this revision to Diff 109852. Repository: rL LLVM https://reviews.llvm.org/D36349 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsia-stage2.cmake +++

[PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

rjmccall edited reviewers, added: jasonmolenda, spyffe; removed: rjmccall. rjmccall added a comment. Since this is fundamentally an LLDB script, I've tagged a couple of LLDB people to review it. Jason, Sean: the idea here is to make it easier for clang developers to debug unexpected

r310145 - Clean up some lambda conversion operator code, NFC

Author: rnk Date: Fri Aug 4 15:38:06 2017 New Revision: 310145 URL: http://llvm.org/viewvc/llvm-project?rev=310145=rev Log: Clean up some lambda conversion operator code, NFC We don't need special handling in CodeGenFunction::GenerateCode for lambda block pointer conversion operators anymore.

[PATCH] D36250: [coverage] Special-case calls to noreturn functions.

efriedma reopened this revision. efriedma added a comment. This revision is now accepted and ready to land. This was reverted. Failing function, from include/clang/AST/Type.h: inline bool Type::isImageType() const { #define IMAGE_TYPE(ImgType, Id, SingletonId, Access, Suffix) is##Id##Type()

[PATCH] D36250: [coverage] Special-case calls to noreturn functions.

efriedma updated this revision to Diff 109838. efriedma added a comment. Add missing call to handleFileExit(). Not sure I'm really calling it in the right place, but this seems to work. Repository: rL LLVM https://reviews.llvm.org/D36250 Files: lib/CodeGen/CoverageMappingGen.cpp

Re: r310057 - Revert r304953 for release 5.0.0

Probably not, r310056 fails as well On Fri, Aug 4, 2017 at 3:19 PM, Vitaly Buka wrote: > Looks like it's causing > http://lab.llvm.org:8011/builders/sanitizer-x86_64- > linux-bootstrap/builds/1969/steps/build%20clang%2Fmsan/logs/stdio > > FAILED:

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

morehouse added inline comments. Comment at: clang/tools/clang-fuzzer/ClangFuzzer.cpp:20 extern "C" int LLVMFuzzerTestOneInput(uint8_t *data, size_t size) { std::string s((const char *)data, size); morehouse wrote: > vitalybuka wrote: > > Do we want

Re: r310057 - Revert r304953 for release 5.0.0

Looks like it's causing http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1969/steps/build%20clang%2Fmsan/logs/stdio FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MIRPrinter.cpp.o /mnt/b/sanitizer-buildbot2/sanitizer-x86_64-linux-bootstrap/build/llvm_build0/bin/clang++

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

vitalybuka added inline comments. Comment at: clang/tools/clang-fuzzer/ClangFuzzer.cpp:20 extern "C" int LLVMFuzzerTestOneInput(uint8_t *data, size_t size) { std::string s((const char *)data, size); morehouse wrote: > morehouse wrote: > > vitalybuka wrote:

Buildmaster restart

Hello everyone, LLVM buildmaster was updated and restarted, downtime was about 2 minutes. -- Best Regards, Victor Leschuk | Software Engineer |Access Softek ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36051: [clang-tidy] List the checkers with autofix

JonasToth added a comment. In my opinion, this list should be available to the executable for two reasons. 1. External tools, that want to integrate clang-tidy in their workflow should be able to get the information about fixits, since they could collidie with their own textual replacements 2.

[PATCH] D36308: Add handling for DeducedType to HasDeclarationMatcher

fgross created this revision. HasDeclarationMatcher did not handle DeducedType, it always returned false for deduced types. So with code like this: struct X{}; auto x = X{}; This did no longer match: varDecl(hasType(recordDecl(hasName("X" Because HasDeclarationMatcher didn't

r310057 - Revert r304953 for release 5.0.0

Author: smaksimovic Date: Fri Aug 4 05:37:34 2017 New Revision: 310057 URL: http://llvm.org/viewvc/llvm-project?rev=310057=rev Log: Revert r304953 for release 5.0.0 This is causing failures when compiling clang with -O3 as one of the structures used by clang is passed by value and uses the

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan added a comment. one more Ping. this is quite a useful fix that does not cost much https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r310051 - [clang-tidy] Add missing documents for "IgnoreMacros" option.

Author: hokein Date: Fri Aug 4 04:25:05 2017 New Revision: 310051 URL: http://llvm.org/viewvc/llvm-project?rev=310051=rev Log: [clang-tidy] Add missing documents for "IgnoreMacros" option. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-make-shared.rst

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

malaperle added inline comments. Comment at: clangd/ProtocolHandlers.cpp:260 + Dispatcher.registerHandler( + "textDocument/switchSourceHeader", + llvm::make_unique(Out, Callbacks)); ilya-biryukov wrote: > ilya-biryukov wrote: > > I don't see this

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl marked 10 inline comments as done. yaxunl added inline comments. Comment at: include/clang/Basic/SyncScope.h:21 +/// \brief Defines the synch scope values used by the atomic builtins and +/// expressions +enum class SyncScope { rjmccall wrote: > If the

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl marked 3 inline comments as done. yaxunl added a comment. Ping. Any other comments? Thanks. Comment at: lib/AST/Expr.cpp:4000-4004 + if (auto AT = T->getAs()) { +return AT->getValueType(); + } else { +return T; + } bader wrote: > No need in

RE: r308619 - Reland "[mips] Teach the driver to accept -m(no-)gpopt."

> -Original Message- > From: Simon Atanasyan [mailto:si...@atanasyan.com] > Sent: 04 August 2017 11:29 > To: Simon Dardis > Cc: Clang Commits > Subject: Re: r308619 - Reland "[mips] Teach the driver to accept -m(no- > )gpopt." > > On Thu, Jul 20, 2017 at 5:04 PM, Simon Dardis via

[PATCH] D30748: [Lexer] Finding beginning of token with escaped new line

idlecode marked 3 inline comments as done. idlecode added inline comments. Comment at: lib/Lex/Lexer.cpp:460 +/// \brief Check if new line pointed by Str is escaped. +bool isNewLineEscaped(const char *BufferStart, const char *Str) { + assert(isVerticalWhitespace(Str[0]));

[PATCH] D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

thakis added a comment. Hm, that's unfortunate. I don't see a good way to rescue this patch. We could keep the lhs of this and always append ".tmp", then tools at least had a way of filtering out the temp files. Hm. https://reviews.llvm.org/D36238

[PATCH] D36191: [CodeGen] Don't make availability attributes imply default visibility on macos

thakis added a comment. Is landing this blocked on internal testing? https://reviews.llvm.org/D36191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36315: [mips] Support implicit gpopt with N64 when using -fno-pic

sdardis created this revision. Herald added a subscriber: arichardson. As clang defaults to -mno-abicalls when using -fno-pic for N64, implicitly use -mgpopt in that case. https://reviews.llvm.org/D36315 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/mips-features.c Index:

[PATCH] D36327: [OpenCL] Allow targets emit optimized pipe functions for power of 2 type sizes

yaxunl created this revision. Herald added a subscriber: tpr. Currently Clang emits call of __read_pipe_2 or __read_pipe_4 for OpenCL read_pipe builtin, with appended type size and alignment arguments, where 2 or 4 indicates the original number of arguments. For certain targets (e.g. amdgpu),

  1   2   >