r310933 - [index] Update indexing to handle CXXDeductionGuideDecls properly

Author: akirtzidis Date: Tue Aug 15 10:20:37 2017 New Revision: 310933 URL: http://llvm.org/viewvc/llvm-project?rev=310933=rev Log: [index] Update indexing to handle CXXDeductionGuideDecls properly CXXDeductionGuideDecls can't be referenced so there's no need to output a symbol occurrence for

[PATCH] D36707: [CodeGen]Refactor CpuSupports/CPUIs Builtin Code Gen to better work with "target" implementation

erichkeane added a comment. Of course, overnight I realized I am probably better off having the 'CpuSupports' validate MULTIPLE features at a time! I'll update this patch with an improvement when I get one that I think is really useful. Sorry for the thrash. https://reviews.llvm.org/D36707

[PATCH] D36755: [clang-tidy] Use CloexecCheck as base class of CloexecCreatCheck.

chh created this revision. Simplify registerMatchers and check functions in CloexecCreatCheck. https://reviews.llvm.org/D36755 Files: clang-tidy/android/CloexecCreatCheck.cpp clang-tidy/android/CloexecCreatCheck.h Index: clang-tidy/android/CloexecCreatCheck.h

r310937 - Attempt to fix failure in CodeGenOpenCL/atomic-ops.cl again

Author: yaxunl Date: Tue Aug 15 10:59:26 2017 New Revision: 310937 URL: http://llvm.org/viewvc/llvm-project?rev=310937=rev Log: Attempt to fix failure in CodeGenOpenCL/atomic-ops.cl again Modified: cfe/trunk/test/CodeGenOpenCL/atomic-ops.cl Modified:

[PATCH] D36580: [OpenCL] Support variable memory scope in atomic builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL310924: [OpenCL] Support variable memory scope in atomic builtins (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D36580?vs=60=85#toc Repository: rL LLVM

r310924 - [OpenCL] Support variable memory scope in atomic builtins

Author: yaxunl Date: Tue Aug 15 09:02:49 2017 New Revision: 310924 URL: http://llvm.org/viewvc/llvm-project?rev=310924=rev Log: [OpenCL] Support variable memory scope in atomic builtins Differential Revision: https://reviews.llvm.org/D36580 Modified: cfe/trunk/include/clang/AST/Expr.h

Re: r310382 - [Availability] Don't make an availability attribute imply default visibility on macOS

Do we want to merge this to 5.0? On Tue, Aug 8, 2017 at 1:09 PM, Erik Pilkington via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: epilk > Date: Tue Aug 8 10:09:09 2017 > New Revision: 310382 > > URL: http://llvm.org/viewvc/llvm-project?rev=310382=rev > Log: > [Availability] Don't

[PATCH] D36641: [index] Update indexing to handle CXXDeductionGuideDecls properly

This revision was automatically updated to reflect the committed changes. Closed by commit rL310933: [index] Update indexing to handle CXXDeductionGuideDecls properly (authored by akirtzidis). Changed prior to commit: https://reviews.llvm.org/D36641?vs=110829=99#toc Repository: rL LLVM

[PATCH] D36759: [clang-tidy] Use CloexecCheck as base class of CloexecFopenCheck.

chh created this revision. Simplify registerMatchers and check functions in CloexecFopenCheck. https://reviews.llvm.org/D36759 Files: clang-tidy/android/CloexecFopenCheck.cpp clang-tidy/android/CloexecFopenCheck.h Index: clang-tidy/android/CloexecFopenCheck.h

r310927 - Remove -finclude-default-header in OpenCL atomic tests

Author: yaxunl Date: Tue Aug 15 09:30:31 2017 New Revision: 310927 URL: http://llvm.org/viewvc/llvm-project?rev=310927=rev Log: Remove -finclude-default-header in OpenCL atomic tests Differential Revision: https://reviews.llvm.org/D36676 Modified:

[PATCH] D36676: Remove -finclude-default-header in OpenCL atomic tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL310927: Remove -finclude-default-header in OpenCL atomic tests (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D36676?vs=110953=91#toc Repository: rL LLVM

[PATCH] D36750: [analyzer] RetainCount: When diagnosing overrelease, mention if it's coming from a nested block.

NoQ created this revision. Herald added a subscriber: xazax.hun. RetainCountChecker's warning message "`Incorrect decrement of the reference count of an object that is not owned at this point by the caller`" does not explicitly mention the caller, which may be confusing when there is a nested

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

Ugh, I'm not sure that last email made it through. Here's the IR with -Xclang -disable-llvm-passes, at r310400 and r310401: https://goo.gl/4n84SR https://goo.gl/gxhxp9 The diff between them is small enough so I don't think there's much point in reducing it further. Hope that helps. On 15 August

[PATCH] D36492: [time-report] Add preprocessor timer

modocache added subscribers: vsk, mzolotukhin. modocache added a comment. Oops, sorry, didn't mean to remove the subscribers. `arc diff --verbatim` strikes again. https://reviews.llvm.org/D36492 ___ cfe-commits mailing list

r310932 - Attempt to fix failure in CodeGenOpenCL/atomic-ops.cl

Author: yaxunl Date: Tue Aug 15 10:16:44 2017 New Revision: 310932 URL: http://llvm.org/viewvc/llvm-project?rev=310932=rev Log: Attempt to fix failure in CodeGenOpenCL/atomic-ops.cl Modified: cfe/trunk/test/CodeGenOpenCL/atomic-ops.cl Modified: cfe/trunk/test/CodeGenOpenCL/atomic-ops.cl

[PATCH] D36759: [clang-tidy] Use CloexecCheck as base class of CloexecFopenCheck.

Eugene.Zelenko added a comment. I think you could combine this refactoring into single change. https://reviews.llvm.org/D36759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36492: [time-report] Add preprocessor timer

modocache updated this revision to Diff 95. modocache retitled this revision from "[RFC][time-report] Add preprocessor timer" to "[time-report] Add preprocessor timer". modocache edited the summary of this revision. modocache removed subscribers: vsk, mzolotukhin. modocache added a comment.

[PATCH] D36678: [OpenCL] Do not use vararg in emitted functions for enqueue_kernel

Anastasia added inline comments. Comment at: test/CodeGenOpenCL/cl20-device-side-enqueue.cl:64 + // B32: call i32 @__enqueue_kernel_vaargs(%opencl.queue_t{{.*}}* [[DEF_Q]], i32 [[FLAGS]], %struct.ndrange_t* [[NDR]]{{(.[0-9]+)?}}, i8 addrspace(4)* addrspacecast (i8

[PATCH] D36756: [clang-tidy] Use CloexecCheck as base class of CloexecSocketCheck.

chh created this revision. Simplify registerMatchers and check functions in CloexecSocketCheck. https://reviews.llvm.org/D36756 Files: clang-tidy/android/CloexecSocketCheck.cpp clang-tidy/android/CloexecSocketCheck.h Index: clang-tidy/android/CloexecSocketCheck.h

r310946 - PR33082: Improve tracking of unexpanded parameter packs within variadic generic lambdas.

Author: rsmith Date: Tue Aug 15 12:11:21 2017 New Revision: 310946 URL: http://llvm.org/viewvc/llvm-project?rev=310946=rev Log: PR33082: Improve tracking of unexpanded parameter packs within variadic generic lambdas. Modified: cfe/trunk/include/clang/Sema/ScopeInfo.h

r310952 - Fixup for r310950: Also remove the new instance of %T from html-diags.c

Author: kuba.brecka Date: Tue Aug 15 12:54:04 2017 New Revision: 310952 URL: http://llvm.org/viewvc/llvm-project?rev=310952=rev Log: Fixup for r310950: Also remove the new instance of %T from html-diags.c Modified: cfe/trunk/test/Analysis/html-diags.c Modified:

[PATCH] D36764: The following functions and tests work fine for powerpc64, so enable them.

saugustine created this revision. These functions were disabled for powerpc in the initial checkin all the way back in 2009. The reasons why are lost to history, but they work fine with modern clang and powerpc64. I have no way to test them on 32-bit systems, but will clean this up if the

[PATCH] D36728: Switch to consumeError(), since this can crash otherwise.

This revision was automatically updated to reflect the committed changes. Closed by commit rL310958: Switch to consumeError(), since this can crash otherwise. (authored by srhines). Repository: rL LLVM https://reviews.llvm.org/D36728 Files: cfe/trunk/lib/Tooling/Core/Replacement.cpp

r310958 - Switch to consumeError(), since this can crash otherwise.

Author: srhines Date: Tue Aug 15 14:20:41 2017 New Revision: 310958 URL: http://llvm.org/viewvc/llvm-project?rev=310958=rev Log: Switch to consumeError(), since this can crash otherwise. Summary: If assertions are disabled, but LLVM_ABI_BREAKING_CHANGES is enabled, this will cause an issue with

[PATCH] D36769: Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""

This revision was automatically updated to reflect the committed changes. Closed by commit rL310960: Revert "Revert "Fix LLVMgold plugin name/path for non-Linux."" (authored by danalbert). Repository: rL LLVM https://reviews.llvm.org/D36769 Files:

r310960 - Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""

Author: danalbert Date: Tue Aug 15 14:31:17 2017 New Revision: 310960 URL: http://llvm.org/viewvc/llvm-project?rev=310960=rev Log: Revert "Revert "Fix LLVMgold plugin name/path for non-Linux."" Summary: Relanding https://reviews.llvm.org/D35739 which was reverted because it broke the tests on

[PATCH] D36755: [clang-tidy] Use CloexecCheck as base class of CloexecCreatCheck.

chh abandoned this revision. chh added a comment. Included in https://reviews.llvm.org/D36761. https://reviews.llvm.org/D36755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36767: Implement the standard for timeouts for std::condition_variable

tomcherry added a comment. This is mostly an RFC. The underlying issue is that we cannot use timed waits based on CLOCK_REALTIME on Android. In trying to fix that, I figured I might as well try implementing the standard as described, though I understand that there'd be resistance to such a

[PATCH] D36771: AMDGPU: add missing amdgcn processors and tests

kzhuravl created this revision. Herald added subscribers: tpr, dstuttard, yaxunl, nhaehnle, wdng. - gfx600 - gfx601 - gfx703 - gfx902 - gfx903 https://reviews.llvm.org/D36771 Files: lib/Basic/Targets/AMDGPU.cpp test/Driver/r600-mcpu.cl Index: test/Driver/r600-mcpu.cl

[PATCH] D36759: [clang-tidy] Use CloexecCheck as base class of CloexecFopenCheck.

chh added a comment. Okay, 3 changes are combined into https://reviews.llvm.org/D36761. https://reviews.llvm.org/D36759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36642: [Lexer] Report more precise skipped regions (PR34166)

efriedma added inline comments. Comment at: lib/Lex/PPDirectives.cpp:570 + // We'll warn about reaching the end of file later. + if (C == '\0' || C == '\r' || C == '\n') +break; This doesn't really handle backslash-escaped newlines correctly.

[PATCH] D36715: [clang] minor cleanup in clang/tooling/refactoring

This revision was automatically updated to reflect the committed changes. Closed by commit rL310948: [clang] Code cleanup in clang/tooling (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D36715?vs=111078=111229#toc Repository: rL LLVM

r310948 - [clang] Code cleanup in clang/tooling

Author: alexshap Date: Tue Aug 15 12:23:54 2017 New Revision: 310948 URL: http://llvm.org/viewvc/llvm-project?rev=310948=rev Log: [clang] Code cleanup in clang/tooling 1. Add missing explicit for SymbolName constructor. 2. Add missing std::move in createRenameReplacements. Differential

[PATCH] D36767: Implement the standard for timeouts for std::condition_variable

tomcherry created this revision. The C++ standard calls for wait_for() to use steady clock and wait_until() to use the clock that is provided as an argument. This is not currently done in libc++ and is not possible with the pthreads API, however it is possible with the underlying futex system

[PATCH] D36728: Switch to consumeError(), since this can crash otherwise.

srhines added a comment. In https://reviews.llvm.org/D36728#842644, @lhames wrote: > The preferred solution to this is actually to wrap the call with cantFail > (See > http://llvm.org/docs/ProgrammersManual.html#using-cantfail-to-simplify-safe-callsites) > -- it will handle both the assertion

[libclc] r310968 - configure.py: Drop explicit import of int builtin

Author: jvesely Date: Tue Aug 15 15:24:05 2017 New Revision: 310968 URL: http://llvm.org/viewvc/llvm-project?rev=310968=rev Log: configure.py: Drop explicit import of int builtin I can't reproduce the error that made me add this. Reported-by: Kim Gräsman Signed-off-by:

[PATCH] D36761: [clang-tidy] Use CloexecCheck as base class.

chh created this revision. Simplify registerMatchers and check functions in CloexecCreatCheck, CloexecSocketCheck, and CloexecFopenCheck. https://reviews.llvm.org/D36761 Files: clang-tidy/android/CloexecCreatCheck.cpp clang-tidy/android/CloexecCreatCheck.h

[PATCH] D36712: Emit section information for extern variables

efriedma added a comment. > The other side of the problem is, what if the declarations don't have any > section information, but the definition does? Is that also an undefined > behavior? I can't see how "undefined behavior" could possibly be the right answer in that case. Every definition

[PATCH] D36712: Emit section information for extern variables

eandrews added inline comments. Comment at: docs/LangRef.rst:629 +corresponding to the LLVM module, section information specified in the +declaration is retained in LLVM IR to enable OpenCL processes. + kparzysz wrote: > sdardis wrote: > > efriedma wrote: > > >

[PATCH] D36759: [clang-tidy] Use CloexecCheck as base class of CloexecFopenCheck.

Eugene.Zelenko added a comment. Please abandon this and other similar revisions as obsoleted by https://reviews.llvm.org/D36761. https://reviews.llvm.org/D36759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36761: [clang-tidy] Use CloexecCheck as base class.

chh updated this revision to Diff 111243. chh edited the summary of this revision. https://reviews.llvm.org/D36761 Files: clang-tidy/android/CloexecCheck.cpp clang-tidy/android/CloexecCheck.h clang-tidy/android/CloexecCreatCheck.cpp clang-tidy/android/CloexecCreatCheck.h

[PATCH] D36728: Switch to consumeError(), since this can crash otherwise.

lhames added a comment. The preferred solution to this is actually to wrap the call with cantFail (See http://llvm.org/docs/ProgrammersManual.html#using-cantfail-to-simplify-safe-callsites) -- it will handle both the assertion and consumption of the value for you, and will simplify calls that

r310964 - Extract IRGen's constant-emitter into its own helper class and clean up

Author: rjmccall Date: Tue Aug 15 14:42:52 2017 New Revision: 310964 URL: http://llvm.org/viewvc/llvm-project?rev=310964=rev Log: Extract IRGen's constant-emitter into its own helper class and clean up the interface. The ultimate goal here is to make it easier to do some more interesting things

r310963 - Allow the target field of a CK_ToUnion to be more easily recovered.

Author: rjmccall Date: Tue Aug 15 14:42:47 2017 New Revision: 310963 URL: http://llvm.org/viewvc/llvm-project?rev=310963=rev Log: Allow the target field of a CK_ToUnion to be more easily recovered. Modified: cfe/trunk/include/clang/AST/Expr.h cfe/trunk/lib/AST/Expr.cpp

r310962 - Allow StmtVisitor visitation to be parameterized. NFC.

Author: rjmccall Date: Tue Aug 15 14:42:42 2017 New Revision: 310962 URL: http://llvm.org/viewvc/llvm-project?rev=310962=rev Log: Allow StmtVisitor visitation to be parameterized. NFC. Modified: cfe/trunk/include/clang/AST/StmtVisitor.h Modified: cfe/trunk/include/clang/AST/StmtVisitor.h

r310966 - Add a target for new LTO plugin name tests.

Author: danalbert Date: Tue Aug 15 15:10:44 2017 New Revision: 310966 URL: http://llvm.org/viewvc/llvm-project?rev=310966=rev Log: Add a target for new LTO plugin name tests. Not all targets will use -plugin with -flto. Pick a fixed target so this works regardless of the default target

[PATCH] D36759: [clang-tidy] Use CloexecCheck as base class of CloexecFopenCheck.

chh added a comment. Eugene, do you mean combining this one, https://reviews.llvm.org/D36756, and https://reviews.llvm.org/D36755 into one? I don't mind either way. https://reviews.llvm.org/D36759 ___ cfe-commits mailing list

Re: r310672 - [Sema][ObjC] Fix spurious -Wcast-qual warnings.

Hans, is it okay to merge this to 5.0? > On Aug 10, 2017, at 5:06 PM, Akira Hatanaka via cfe-commits > wrote: > > Author: ahatanak > Date: Thu Aug 10 17:06:49 2017 > New Revision: 310672 > > URL: http://llvm.org/viewvc/llvm-project?rev=310672=rev > Log: >

[PATCH] D36712: Emit section information for extern variables

eandrews updated this revision to Diff 111227. eandrews added a comment. I updated the documentation to include Simon's comments. I wasn't sure whether to include the line about section information being retained in LLVM IR, since Eli mentioned it could vary for different front-ends. I have

r310950 - [clang] Get rid of "%T" expansions

Author: kuba.brecka Date: Tue Aug 15 12:47:06 2017 New Revision: 310950 URL: http://llvm.org/viewvc/llvm-project?rev=310950=rev Log: [clang] Get rid of "%T" expansions The %T lit expansion expands to a common directory shared between all the tests in the same directory, which is unexpected and

[PATCH] D35955: clang-format: Add preprocessor directive indentation

euhlmann added inline comments. Comment at: unittests/Format/FormatTest.cpp:2405-2408 + // Defect: We currently do not deal with cases where legitimate lines may be + // outside an include guard. Examples are #pragma once and + // #pragma GCC diagnostic, or anything else that

[PATCH] D36759: [clang-tidy] Use CloexecCheck as base class of CloexecFopenCheck.

Eugene.Zelenko added a comment. In https://reviews.llvm.org/D36759#842367, @chh wrote: > Eugene, do you mean combining this one, https://reviews.llvm.org/D36756, and > https://reviews.llvm.org/D36755 into one? > I don't mind either way. Sure. All three diffs are of same kind.

[PATCH] D36712: Emit section information for extern variables

kparzysz added a comment. In https://reviews.llvm.org/D36712#842433, @efriedma wrote: > I can't see how "undefined behavior" could possibly be the right answer in > that case. Every definition has to end up in some section eventually, and in > many cases we don't know what section that will

[PATCH] D36759: [clang-tidy] Use CloexecCheck as base class of CloexecFopenCheck.

chh abandoned this revision. chh added a comment. Included in https://reviews.llvm.org/D36761. https://reviews.llvm.org/D36759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36437: [clang] Get rid of "%T" expansions

This revision was automatically updated to reflect the committed changes. Closed by commit rL310950: [clang] Get rid of "%T" expansions (authored by kuba.brecka). Changed prior to commit: https://reviews.llvm.org/D36437?vs=110113=111232#toc Repository: rL LLVM

[PATCH] D36756: [clang-tidy] Use CloexecCheck as base class of CloexecSocketCheck.

chh abandoned this revision. chh added a comment. Included in https://reviews.llvm.org/D36761. https://reviews.llvm.org/D36756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36769: Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""

danalbert created this revision. Herald added subscribers: eraman, mehdi_amini, emaste. Relanding https://reviews.llvm.org/D35739 which was reverted because it broke the tests on non-Linux. The tests have been fixed to be platform agnostic, and additional tests have been added to make sure that

[PATCH] D36712: Emit section information for extern variables

efriedma added inline comments. Comment at: docs/LangRef.rst:628 +information. Attaching section information to an external declaration is an +assertion that it's definition is located in the specified section. If the +definition is located in a different section, the behavior

[PATCH] D36773: Fix for internal compiler error when calling __builtin_signbit with invalid arguments

jseba created this revision. jseba added a project: clang. Clang has had a regression since version 3.8 where calls to __builtin_signbit (and friends signbitf & signbitl) without passing any arguments would cause it to segfault because it didn't abort compilation, even though it would properly

r310976 - Revert "Add a target for new LTO plugin name tests."

Author: danalbert Date: Tue Aug 15 16:57:32 2017 New Revision: 310976 URL: http://llvm.org/viewvc/llvm-project?rev=310976=rev Log: Revert "Add a target for new LTO plugin name tests." Modified: cfe/trunk/test/Driver/lto-plugin-darwin.c cfe/trunk/test/Driver/lto-plugin-linux.c

r310977 - Revert "Revert "Revert "Fix LLVMgold plugin name/path for non-Linux."""

Author: danalbert Date: Tue Aug 15 16:57:34 2017 New Revision: 310977 URL: http://llvm.org/viewvc/llvm-project?rev=310977=rev Log: Revert "Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""" Removed: cfe/trunk/test/Driver/lto-plugin-darwin.c

[PATCH] D36580: [OpenCL] Support variable memory scope in atomic builtins

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: cfe/trunk/lib/Frontend/InitPreprocessor.cpp:581 // Define macros for the OpenCL memory scope. // The values should match clang SyncScope enum. + static_assert( t-tye wrote:

r310986 - Fix comments about __OPENCL_MEMORY_SCOPE_* macros

Author: yaxunl Date: Tue Aug 15 21:15:28 2017 New Revision: 310986 URL: http://llvm.org/viewvc/llvm-project?rev=310986=rev Log: Fix comments about __OPENCL_MEMORY_SCOPE_* macros Modified: cfe/trunk/lib/Frontend/InitPreprocessor.cpp Modified: cfe/trunk/lib/Frontend/InitPreprocessor.cpp URL:

[PATCH] D36777: [Sema] Don't emit -Wunguarded-availability for switch cases

erik.pilkington created this revision. Currently, this has pretty terrible ergonomics for the fairly common case of switching over an enum which has some entries that are partial. Thanks to Nico Weber for pointing this out! Thanks, Erik https://reviews.llvm.org/D36777 Files:

Re: r310382 - [Availability] Don't make an availability attribute imply default visibility on macOS

Probably not, this might be a risky change. - Erik On 8/15/17 9:15 AM, Nico Weber wrote: Do we want to merge this to 5.0? On Tue, Aug 8, 2017 at 1:09 PM, Erik Pilkington via cfe-commits > wrote: Author: epilk Date: Tue

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

rsmith added inline comments. Comment at: docs/ClangCommandLineReference.rst:3-4 --- NOTE: This file is automatically generated by running clang-tblgen -gen-opt-docs. Do not edit this file by hand!!

[PATCH] D36728: Switch to consumeError(), since this can crash otherwise.

lhames added a comment. > Is it ok to drop the assertion in that case (and convert it to a comment)? I > didn't want to alter too much of this check, since perhaps the original > author(s) were more skeptical about this breaking (hence the assertion). > Something like: > > // Replacements

r310982 - Add test that we get the correct calling convention and mangling for va_list.

Author: rsmith Date: Tue Aug 15 18:46:46 2017 New Revision: 310982 URL: http://llvm.org/viewvc/llvm-project?rev=310982=rev Log: Add test that we get the correct calling convention and mangling for va_list. Added: cfe/trunk/test/Headers/stdarg.cpp Added: cfe/trunk/test/Headers/stdarg.cpp

r310983 - PR19668, PR23034: Fix handling of move constructors and deleted copy

Author: rsmith Date: Tue Aug 15 18:49:53 2017 New Revision: 310983 URL: http://llvm.org/viewvc/llvm-project?rev=310983=rev Log: PR19668, PR23034: Fix handling of move constructors and deleted copy constructors when deciding whether classes should be passed indirectly. This fixes ABI differences

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

On 15 August 2017 at 08:56, Diana Picus via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Ugh, I'm not sure that last email made it through. > > Here's the IR with -Xclang -disable-llvm-passes, at r310400 and r310401: > https://goo.gl/4n84SR > https://goo.gl/gxhxp9 > > The diff between them

[PATCH] D36779: [Driver] SafeStack does not need a runtime library on Fuchsia

mcgrathr created this revision. mcgrathr added a project: Sanitizers. Repository: rL LLVM https://reviews.llvm.org/D36779 Files: include/clang/Driver/SanitizerArgs.h lib/Driver/SanitizerArgs.cpp test/Driver/fuchsia.c Index: test/Driver/fuchsia.c

RE: r310960 - Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""

Hi Dan, I don't know if you are aware, but the tests you added/changed in this commit are causing failures on the PS4 Windows bot. The root cause seems to be that you are looking for a forward slash, but Windows generates double backslashes, so the match fails:

[PATCH] D36771: AMDGPU: add missing amdgcn processors and tests

arsenm added a comment. We should also be defining __devicename__ macros. I opened a bug for this last week https://reviews.llvm.org/D36771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36678: [OpenCL] Do not use vararg in emitted functions for enqueue_kernel

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: test/CodeGenOpenCL/cl20-device-side-enqueue.cl:64 + // B32: call i32 @__enqueue_kernel_vaargs(%opencl.queue_t{{.*}}* [[DEF_Q]], i32 [[FLAGS]], %struct.ndrange_t* [[NDR]]{{(.[0-9]+)?}}, i8

[PATCH] D36580: [OpenCL] Support variable memory scope in atomic builtins

t-tye added inline comments. Comment at: cfe/trunk/lib/Frontend/InitPreprocessor.cpp:581 // Define macros for the OpenCL memory scope. // The values should match clang SyncScope enum. + static_assert( // The values should match clang

[PATCH] D35678: Omit sumbodule semantics for TS modules

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D35678#840092, @boris wrote: > My understanding of your comment is that the rest is ok for now (since there > will probably be a redesign in this area). If,

r310972 - Do not look through pack expansions when looking for unexpanded parameter packs.

Author: rsmith Date: Tue Aug 15 15:58:45 2017 New Revision: 310972 URL: http://llvm.org/viewvc/llvm-project?rev=310972=rev Log: Do not look through pack expansions when looking for unexpanded parameter packs. Fixes a selection of rejects-valids when pack-expanding a lambda that itself contains a

[PATCH] D36713: [libc++] Add a persistent way to disable availability

smeenai added a comment. @mclow.lists does this seem reasonable to you? https://reviews.llvm.org/D36713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r310978 - Add missing test for warning added in r310803.

Author: rsmith Date: Tue Aug 15 17:06:07 2017 New Revision: 310978 URL: http://llvm.org/viewvc/llvm-project?rev=310978=rev Log: Add missing test for warning added in r310803. Added: cfe/trunk/test/Lexer/cxx2a_keyword_as_cxx17.cpp Added: cfe/trunk/test/Lexer/cxx2a_keyword_as_cxx17.cpp URL:

[PATCH] D36678: [OpenCL] Do not use vararg in emitted functions for enqueue_kernel

yaxunl updated this revision to Diff 111302. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by Anastasia's comments. https://reviews.llvm.org/D36678 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/cl20-device-side-enqueue.cl Index:

[PATCH] D36712: Emit section information for extern variables

kparzysz added inline comments. Comment at: docs/LangRef.rst:629 +corresponding to the LLVM module, section information specified in the +declaration is retained in LLVM IR to enable OpenCL processes. + sdardis wrote: > efriedma wrote: > > This doesn't really

r310920 - [OPENMP] Fix compiler crash on argument translate for NVPTX.

Author: abataev Date: Tue Aug 15 07:34:04 2017 New Revision: 310920 URL: http://llvm.org/viewvc/llvm-project?rev=310920=rev Log: [OPENMP] Fix compiler crash on argument translate for NVPTX. When translating arguments for NVPTX target it is not taken into account that function may have variable

[PATCH] D36610: [Tooling] Add option to getFullyQualifiedName using a custom PritingPolicy

mikhail.ramalho updated this revision to Diff 63. mikhail.ramalho added a comment. Updated QualTypeNamesTest.cpp to use multiline string in all tests. Also ran clang-format -style=LLVM for code style. https://reviews.llvm.org/D36610 Files: include/clang/Tooling/Core/QualTypeNames.h

r310921 - Allow pretty platform names in availability attributes

Author: arphaman Date: Tue Aug 15 07:42:01 2017 New Revision: 310921 URL: http://llvm.org/viewvc/llvm-project?rev=310921=rev Log: Allow pretty platform names in availability attributes rdar://32076651 Modified: cfe/trunk/lib/Parse/ParseDecl.cpp

[PATCH] D36580: [OpenCL] Support variable memory scope in atomic builtins

rjmccall accepted this revision. rjmccall added a comment. Thanks, that looks great. https://reviews.llvm.org/D36580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

On 15 August 2017 at 01:25, Richard Smith wrote: > On 14 August 2017 at 03:27, Diana Picus via cfe-commits > wrote: >> >> Hi, >> >> Strangely enough, it turns out that if I run >> Asan-armhf-with-calls-Noinst-Test on the command line it fails,

[PATCH] D36728: Switch to consumeError(), since this can crash otherwise.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36686: [clang-diff] Add option to compare files across git revisions

arphaman added a comment. That would be nice. Temporary checkouts are a way to solve the problem. But they might not work for all projects, like when some translation unit includes a file that's not in git using a relative path. Another solution is to use virtual file systems. A custom vfs

[PATCH] D36664: [analyzer] Make StmtDataCollector customizable

teemperor added a comment. Very well done, I really like this patch! I added a few remarks mostly about the comments that need some small adjusting. I'm wondering what would be a nice way of creating a StmtDataCollector that is faster but only works for single translation units (e.g. it only

r310911 - [OpenCL] Allow targets to select address space per type

Author: svenvh Date: Tue Aug 15 02:38:18 2017 New Revision: 310911 URL: http://llvm.org/viewvc/llvm-project?rev=310911=rev Log: [OpenCL] Allow targets to select address space per type Generalize getOpenCLImageAddrSpace into getOpenCLTypeAddrSpace, such that targets can select the address space

[PATCH] D36664: [analyzer] Make StmtDataCollector customizable

arphaman added a subscriber: rsmith. arphaman added a comment. In https://reviews.llvm.org/D36664#841758, @teemperor wrote: > Very well done, I really like this patch! I added a few remarks mostly about > the comments that need some small adjusting. > > I'm wondering what would be a nice way of

[PATCH] D33719: Add _Float16 as a C/C++ source language type

SjoerdMeijer added a comment. Ping https://reviews.llvm.org/D33719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

This revision was automatically updated to reflect the committed changes. Closed by commit rL310911: [OpenCL] Allow targets to select address space per type (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D33989?vs=110947=37#toc Repository: rL LLVM

[PATCH] D36670: misc-misplaced-widening-cast: fix assertion

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Repository: rL LLVM https://reviews.llvm.org/D36670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36670: misc-misplaced-widening-cast: fix assertion

xazax.hun added inline comments. Comment at: test/clang-tidy/misc-misplaced-widening-cast-explicit-only.cpp:63 + enum Type {}; + static char *m_fn1() { char p = (Type)( - m_fn1()); } +}; Isn't this testcase a bit overcomplicated to demonstrate the issue?

[PATCH] D35955: clang-format: Add preprocessor directive indentation

mzeren-vmw added inline comments. Comment at: unittests/Format/FormatTest.cpp:2281 TEST_F(FormatTest, LayoutMacroDefinitionsStatementsSpanningBlocks) { verifyFormat("#define A \\\n" mzeren-vmw wrote: > Experimenting with the patch locally I found that

[PATCH] D36731: [ARM][AArch64] Cortex-A75 and Cortex-A55 support

samparker created this revision. Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. This patch introduces support for Cortex-A75 and Cortex-A55, Arm's latest big.LITTLE A-class cores. They implement the ARMv8.2-A architecture, including the cryptography and RAS

[PATCH] D24461: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds

edward-jones added a comment. No, this doesn't seem to have been committed yet. https://reviews.llvm.org/D24461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36715: [clang] minor cleanup in clang/tooling/refactoring

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D36715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36737: [analyzer] Store design discussions in docs/analyzer for future use.

NoQ created this revision. Because i tend to raise important design questions in weird places like tiny phabricator patches, we had a thought that it's better to archive them in `docs/analyzer` for future reference. We should be able to pick them up whenever time comes to solve these problems.

  1   2   >