SjoerdMeijer added a comment.
Ping
https://reviews.llvm.org/D33719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a subscriber: rsmith.
arphaman added a comment.
In https://reviews.llvm.org/D36664#841758, @teemperor wrote:
> Very well done, I really like this patch! I added a few remarks mostly about
> the comments that need some small adjusting.
>
> I'm wondering what would be a nice way of
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310911: [OpenCL] Allow targets to select address space per
type (authored by svenvh).
Changed prior to commit:
https://reviews.llvm.org/D33989?vs=110947=37#toc
Repository:
rL LLVM
Author: svenvh
Date: Tue Aug 15 02:38:18 2017
New Revision: 310911
URL: http://llvm.org/viewvc/llvm-project?rev=310911=rev
Log:
[OpenCL] Allow targets to select address space per type
Generalize getOpenCLImageAddrSpace into getOpenCLTypeAddrSpace, such
that targets can select the address space
teemperor added a comment.
Very well done, I really like this patch! I added a few remarks mostly about
the comments that need some small adjusting.
I'm wondering what would be a nice way of creating a StmtDataCollector that is
faster but only works for single translation units (e.g. it only
arphaman added a comment.
That would be nice. Temporary checkouts are a way to solve the problem. But
they might not work for all projects, like when some translation unit includes
a file that's not in git using a relative path.
Another solution is to use virtual file systems. A custom vfs
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D36728
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
101 - 107 of 107 matches
Mail list logo