[PATCH] D33719: Add _Float16 as a C/C++ source language type

2017-08-15 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer added a comment. Ping https://reviews.llvm.org/D33719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36664: [analyzer] Make StmtDataCollector customizable

2017-08-15 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a subscriber: rsmith. arphaman added a comment. In https://reviews.llvm.org/D36664#841758, @teemperor wrote: > Very well done, I really like this patch! I added a few remarks mostly about > the comments that need some small adjusting. > > I'm wondering what would be a nice way of

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

2017-08-15 Thread Sven van Haastregt via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL310911: [OpenCL] Allow targets to select address space per type (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D33989?vs=110947=37#toc Repository: rL LLVM

r310911 - [OpenCL] Allow targets to select address space per type

2017-08-15 Thread Sven van Haastregt via cfe-commits
Author: svenvh Date: Tue Aug 15 02:38:18 2017 New Revision: 310911 URL: http://llvm.org/viewvc/llvm-project?rev=310911=rev Log: [OpenCL] Allow targets to select address space per type Generalize getOpenCLImageAddrSpace into getOpenCLTypeAddrSpace, such that targets can select the address space

[PATCH] D36664: [analyzer] Make StmtDataCollector customizable

2017-08-15 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor added a comment. Very well done, I really like this patch! I added a few remarks mostly about the comments that need some small adjusting. I'm wondering what would be a nice way of creating a StmtDataCollector that is faster but only works for single translation units (e.g. it only

[PATCH] D36686: [clang-diff] Add option to compare files across git revisions

2017-08-15 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. That would be nice. Temporary checkouts are a way to solve the problem. But they might not work for all projects, like when some translation unit includes a file that's not in git using a relative path. Another solution is to use virtual file systems. A custom vfs

[PATCH] D36728: Switch to consumeError(), since this can crash otherwise.

2017-08-15 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

<    1   2