[PATCH] D36782: [Bash-autocompletion] Add support for static analyzer flags

yamaguchi created this revision. Herald added a subscriber: hiraditya. This is a patch for clang autocomplete feature. It will collect values which -analyzer-checker takes, which is defined in clang/StaticAnalyzer/Checkers/Checkers.inc, dynamically. First, from ValuesCode class in Options.td,

r310994 - Fix a UBSan failure where this boolean was copied when uninitialized.

Author: chandlerc Date: Wed Aug 16 00:22:49 2017 New Revision: 310994 URL: http://llvm.org/viewvc/llvm-project?rev=310994=rev Log: Fix a UBSan failure where this boolean was copied when uninitialized. When r310905 moved the pointer and bool out of a PointerIntPair, it made them end up

[PATCH] D36782: [Bash-autocompletion] Add support for static analyzer flags

teemperor added a comment. That's a really nice approach to this problem, good job Yuka! See my inline comments for some minor remarks. Comment at: clang/include/clang/Driver/CC1Options.td:104 + const char* Values = +#define GET_CHECKERS +#define CHECKER(FULLNAME, CLASS,

[PATCH] D36664: [analyzer] Make StmtDataCollector customizable

johannes updated this revision to Diff 111316. johannes edited the summary of this revision. johannes removed a subscriber: rsmith. johannes added a comment. - fix comments - add unittest for the new node kinds - make `addData()` take a const reference https://reviews.llvm.org/D36664 Files:

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan abandoned this revision. yvvan added a comment. In https://reviews.llvm.org/D34873#841624, @rnk wrote: > This shouldn't be necessary after https://reviews.llvm.org/rL310905. https://reviews.llvm.org/D34873 ___ cfe-commits mailing list

[PATCH] D35955: clang-format: Add preprocessor directive indentation

djasper added inline comments. Comment at: unittests/Format/FormatTest.cpp:2281 TEST_F(FormatTest, LayoutMacroDefinitionsStatementsSpanningBlocks) { verifyFormat("#define A \\\n" mzeren-vmw wrote: > mzeren-vmw wrote: > > Experimenting with the patch

[PATCH] D36782: [Bash-autocompletion] Add support for static analyzer flags

yamaguchi updated this revision to Diff 111318. yamaguchi marked 7 inline comments as done. yamaguchi added a comment. Update diff according to Raphael's comments. https://reviews.llvm.org/D36782 Files: clang/include/clang/Driver/CC1Options.td clang/lib/Driver/DriverOptions.cpp

[PATCH] D36782: [Bash-autocompletion] Add support for static analyzer flags

teemperor added inline comments. Comment at: clang/lib/Driver/DriverOptions.cpp:14 #include "llvm/Option/Option.h" +#include I think the C++ version of the assert header is more consistent: `#include ` Comment at:

[PATCH] D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements

m.ostapenko updated this revision to Diff 111322. m.ostapenko added a comment. Ping^3 Repository: rL LLVM https://reviews.llvm.org/D16403 Files: include/clang/Analysis/AnalysisContext.h include/clang/Analysis/CFG.h include/clang/StaticAnalyzer/Core/AnalyzerOptions.h

[PATCH] D36664: [analyzer] Make StmtDataCollector customizable

johannes updated this revision to Diff 111317. johannes added a subscriber: rsmith. johannes added a comment. add https://reviews.llvm.org/D36664 Files: include/clang/AST/DataCollection.h include/clang/Analysis/CloneDetection.h lib/AST/CMakeLists.txt lib/AST/DataCollection.cpp

[PATCH] D36664: [analyzer] Make StmtDataCollector customizable

johannes added a comment. In https://reviews.llvm.org/D36664#841758, @teemperor wrote: > Very well done, I really like this patch! I added a few remarks mostly about > the comments that need some small adjusting. > > I'm wondering what would be a nice way of creating a StmtDataCollector that >

[PATCH] D36786: [clang-tidy] Don't generate fixes for initializer_list constructor in make_unique check.

hokein created this revision. Herald added subscribers: xazax.hun, JDevlieghere. The current fix will break the compilation -- because braced list is not deducible in std::make_unique (with the use of forwarding) without specifying the type explicitly. We could support it in the future.

[PATCH] D36761: [clang-tidy] Use CloexecCheck as base class.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM with a few nits. Comment at: clang-tidy/android/CloexecCheck.h:95 + /// Binding name of the FuncDecl of a function call. + static const char *FuncDeclBindingStr; +

[PATCH] D34440: [Clang] Expand response files before loading compilation database

alexfh added a comment. In https://reviews.llvm.org/D34440#825924, @vladimir.plyashkun wrote: > > Many build systems normally generate response files on-fly in some > > circumstances (e.g. if command line is longer than some platform-imposed > > limit). So IMO response files should be a

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

hamzasood added a comment. Ping https://reviews.llvm.org/D36527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34440: [Clang] Expand response files before loading compilation database

vladimir.plyashkun added a comment. @alexf Thanks for the response! Yes, we re-implemented logic and now use JSON compilation database to pass compiler options to Clang-Tidy. Anyway, i think in general it's useful to support @response_files, see my comment:

[PATCH] D36686: [clang-diff] Add option to compare files across git revisions

johannes updated this revision to Diff 111328. johannes edited the summary of this revision. johannes added a comment. accept a commit range https://reviews.llvm.org/D36686 Files: tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp

[PATCH] D34440: [Clang] Expand response files before loading compilation database

alexfh added a comment. In https://reviews.llvm.org/D34440#843192, @vladimir.plyashkun wrote: > @alexfh > Thanks for the response! > Yes, we re-implemented logic and now use JSON compilation database to pass > compiler options to Clang-Tidy. > Anyway, i think in general it's useful to

[PATCH] D36790: [ObjC] Messages to 'self' in class methods should use class method dispatch to avoid multiple method ambiguities

rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. Class methods can be inherited; this entire approach is bogus. Repository: rL LLVM https://reviews.llvm.org/D36790 ___

[PATCH] D35678: Omit sumbodule semantics for TS modules

boris added a comment. In https://reviews.llvm.org/D35678#842891, @rsmith wrote: > I'd still like the id flattening moved to the caller. [...] I'm fine with > that being done as a separate change after this one, though, if you'd prefer. Yes, that would probably be easier. > Do you need

[PATCH] D35362: [clang-tidy] Add a close-on-exec check on accept() in Android module.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a nit. Comment at: clang-tidy/android/CloexecAcceptCheck.cpp:42 + "prefer accept4() to accept() because accept4() allows SOCK_CLOEXEC", +

[PATCH] D35365: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D35365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35363: [clang-tidy] Add a close-on-exec check on accept4() in Android module.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D35363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

rjmccall resigned from this revision. rjmccall added a comment. I don't think I'm best-equipped to review this, sorry. https://reviews.llvm.org/D36527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a nit. Comment at: clang-tidy/android/CloexecEpollCreateCheck.cpp:27-31 + replaceFunc(Result, /*WarningMsg=*/ + "prefer epoll_create() to

[PATCH] D36786: [clang-tidy] Don't generate fixes for initializer_list constructor in make_unique check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: test/clang-tidy/modernize-make-unique.cpp:253 // CHECK-MESSAGES: :[[@LINE-1]]:28: warning: use std::make_unique instead - // CHECK-FIXES: std::unique_ptr

[PATCH] D36712: Emit section information for extern variables

eandrews added a comment. In https://reviews.llvm.org/D36712#842477, @kparzysz wrote: > In the cases when the section is explicitly given on a definition, it was > likely imposed by something like the "section" attribute in the source. I > don't think it's unreasonable to expect that the

[PATCH] D36410: [OpenCL] Handle taking address of block captures

Anastasia added a comment. Ping! :) https://reviews.llvm.org/D36410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp:191 + // Initialization of owners. + else if (OwnerInitialization != nullptr) { +diag(OwnerInitialization->getLocStart(), aaron.ballman wrote: > No else

[PATCH] D36794: Fixups to FE tests affected by D36793

coby created this revision. Herald added a subscriber: eraman. Repository: rL LLVM https://reviews.llvm.org/D36794 Files: test/CodeGen/mozilla-ms-inline-asm.c test/CodeGen/ms-inline-asm-64.c test/CodeGen/ms-inline-asm.c test/CodeGen/ms-inline-asm.cpp

[PATCH] D36790: [ObjC] Messages to 'self' in class methods should use class method dispatch to avoid multiple method ambiguities

arphaman created this revision. Prior to this patch, messages to `self` in class methods were treated as instance methods to a `Class` value. When these methods returned `instancetype` the compiler only saw `id` through the `instancetype`, and not the `Interface *`. This caused problems when

[PATCH] D36672: [clang-tidy] readability-non-const-parameter: fixit on all function declarations

aaron.ballman added inline comments. Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:146 + +if (const auto *Parent = Par->getParentFunctionOrMethod()) { + if (const auto *F = dyn_cast(Parent)) { Please do not use `auto` here, as the type

r311007 - [OPRNMP] Fix for PR33445: ICE: OpenMP target containing ordered for.

Author: abataev Date: Wed Aug 16 07:01:00 2017 New Revision: 311007 URL: http://llvm.org/viewvc/llvm-project?rev=311007=rev Log: [OPRNMP] Fix for PR33445: ICE: OpenMP target containing ordered for. If exceptions are enabled, there may be a problem with the codegen of the finalization functions

[PATCH] D35200: Don't use mmap on Windows

nik added a reviewer: ilya-biryukov. nik added a comment. Ping. I guess locking the file less helps also clangd?! https://reviews.llvm.org/D35200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36410: [OpenCL] Handle taking address of block captures

yaxunl added a comment. Sorry for the delay. I feel forbidding user taking address of captured variable is too restrictive and make blocks less useful. A block is quite like a normal function with a generic pointer argument. Users take the responsibility to make sure the cast of a generic

[PATCH] D36737: [analyzer] Store design discussions in docs/analyzer for future use.

dcoughlin added a comment. Thanks for doing this! https://reviews.llvm.org/D36737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36712: Emit section information for extern variables

eandrews updated this revision to Diff 111341. eandrews added a comment. Corrected spelling error. https://reviews.llvm.org/D36712 Files: docs/LangRef.rst Index: docs/LangRef.rst === --- docs/LangRef.rst +++ docs/LangRef.rst

[PATCH] D36712: Emit section information for extern variables

kparzysz added a comment. In https://reviews.llvm.org/D36712#843387, @eandrews wrote: > Does this result in unexpected behavior though? Won't this just result in the > global being defined in the specified section? If there is no section given explicitly, there is function

[PATCH] D36790: [ObjC] Messages to 'self' in class methods should use class method dispatch to avoid multiple method ambiguities

arphaman added a comment. Of course, right. I will change the approach. Repository: rL LLVM https://reviews.llvm.org/D36790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r311013 - [OPENMP] Fix for PR28581: OpenMP linear clause - wrong results.

Author: abataev Date: Wed Aug 16 08:58:46 2017 New Revision: 311013 URL: http://llvm.org/viewvc/llvm-project?rev=311013=rev Log: [OPENMP] Fix for PR28581: OpenMP linear clause - wrong results. If worksharing construct has at least one linear item, an implicit synchronization point must be

[PATCH] D36712: Emit section information for extern variables

kparzysz added a comment. The problem is that the mismatch between sections does not have to lead to any undesirable behavior. Whether it does or not depends on a particular case. I think we should be consistent though---if we decide that a mismatch between the section for a declaration and

[PATCH] D36750: [analyzer] RetainCount: When diagnosing overrelease, mention if it's coming from a nested block.

dcoughlin added a comment. > By the way, plist-based tests in retain-release.m are disabled since r163536 > (~2012), and need to be updated. It's trivial to re-enable them but annoying > to maintain - would we prefer to re-enable or delete them or replace with > -analyzer-output=text tests?

[PATCH] D36790: [ObjC] Messages to 'self' in class methods should use class method dispatch to avoid multiple method ambiguities

arphaman added a comment. @rjmccall Do you think that the rules for the return types in overridden methods that return `instancetype` should be strengthened first? For example, if we have the following code: @interface Unrelated - (void)method:(int)x; @end @interface CallsSelfSuper:

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

Nebiroth updated this revision to Diff 111368. Nebiroth marked 8 inline comments as done. Nebiroth added a comment. Fixed diff comments. https://reviews.llvm.org/D36150 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ProtocolHandlers.cpp

[PATCH] D36782: [Bash-autocompletion] Add support for static analyzer flags

yamaguchi updated this revision to Diff 111457. yamaguchi marked 2 inline comments as done. yamaguchi added a comment. Update diff. https://reviews.llvm.org/D36782 Files: clang/include/clang/Driver/CC1Options.td clang/lib/Driver/DriverOptions.cpp clang/test/Driver/autocomplete.c

[PATCH] D36790: [ObjC] Messages to 'self' in class methods should use class method dispatch to avoid multiple method ambiguities

rjmccall added a comment. I think it's fair to treat instancetype as an inherited requirement — that is, the rules of covariant override always apply, which essentially means that overriders of instance-returning methods must also return instancetype whether they say so explicitly or not. But

r311065 - Further refactoring of the constant emitter. NFC.

Author: rjmccall Date: Wed Aug 16 22:03:55 2017 New Revision: 311065 URL: http://llvm.org/viewvc/llvm-project?rev=311065=rev Log: Further refactoring of the constant emitter. NFC. Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp URL:

[PATCH] D36782: [Bash-autocompletion] Add support for static analyzer flags

yamaguchi added a comment. @ruiu I understand your concern. However by doing this (rather than building functions for each flag), we will be able to get all information in OptTable itself. It is true that this is quite fragile, but adding ValuesCode to new flag is not complicated, so I

r311063 - [analyzer] Add support for reference counting of parameters on the callee side

Author: dcoughlin Date: Wed Aug 16 21:19:07 2017 New Revision: 311063 URL: http://llvm.org/viewvc/llvm-project?rev=311063=rev Log: [analyzer] Add support for reference counting of parameters on the callee side This commit adds the functionality of performing reference counting on the callee side

[PATCH] D36441: Add Support for Reference Counting of Parameters on the Callee Side in RetainCountChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rL311063: [analyzer] Add support for reference counting of parameters on the callee side (authored by dcoughlin). Changed prior to commit: https://reviews.llvm.org/D36441?vs=111420=111463#toc

[PATCH] D36441: Add Support for Reference Counting of Parameters on the Callee Side in RetainCountChecker

dcoughlin added a comment. Thanks Malhar! Committed in r311063. Repository: rL LLVM https://reviews.llvm.org/D36441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36782: [Bash-autocompletion] Add support for static analyzer flags

ruiu added a comment. This patch allows us to embed a piece of C++ code to each command line option to construct a list of argument candidates at runtime. With this patch, .inc files generated by OptParserEmitter contain C macros that in turn include other .inc files. That is a flexible

r311043 - Don't use -no-integrated-as in test/Driver/opt-record.c

Author: hfinkel Date: Wed Aug 16 14:51:31 2017 New Revision: 311043 URL: http://llvm.org/viewvc/llvm-project?rev=311043=rev Log: Don't use -no-integrated-as in test/Driver/opt-record.c -no-integrated-as is not supported on some targets (e.g., x86_64-pc-windows-msvc). Testing using -save-temps is

[PATCH] D36802: AMDGPU: Insert __devicename__ macros

t-tye added inline comments. Comment at: lib/Basic/Targets/AMDGPU.cpp:364-367 + if (GPUName.empty()) +return; + + Builder.defineMacro(Twine("__") + Twine(GPUName) + Twine("__")); Should this be the following since extra macros could be after it in the

[PATCH] D35955: clang-format: Add preprocessor directive indentation

euhlmann updated this revision to Diff 111433. euhlmann marked 13 inline comments as done. euhlmann edited the summary of this revision. euhlmann added a comment. Allows comments before the include guard opens. However, if there's a single non-comment line before an include-guard-like structure

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL311033: [CMake] Build sanitized C++ runtimes for Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D36349?vs=110311=111399#toc Repository: rL LLVM

r311033 - [CMake] Build sanitized C++ runtimes for Fuchsia

Author: phosek Date: Wed Aug 16 12:06:04 2017 New Revision: 311033 URL: http://llvm.org/viewvc/llvm-project?rev=311033=rev Log: [CMake] Build sanitized C++ runtimes for Fuchsia Differential Revision: https://reviews.llvm.org/D36349 Modified: cfe/trunk/cmake/caches/Fuchsia-stage2.cmake

r311034 - [Driver] SafeStack does not need a runtime library on Fuchsia

Author: phosek Date: Wed Aug 16 12:06:05 2017 New Revision: 311034 URL: http://llvm.org/viewvc/llvm-project?rev=311034=rev Log: [Driver] SafeStack does not need a runtime library on Fuchsia Patch by Roland McGrath Differential Revision: https://reviews.llvm.org/D36779 Modified:

[PATCH] D35362: [clang-tidy] Add a close-on-exec check on accept() in Android module.

chh updated this revision to Diff 111377. https://reviews.llvm.org/D35362 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecAcceptCheck.cpp clang-tidy/android/CloexecAcceptCheck.h docs/ReleaseNotes.rst

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

twoh added a comment. Friendly ping. @davidxl, I think there's no harm to make clang consistent with gcc for compiler options, and I wonder if you have any concerns that I may miss. Thanks! https://reviews.llvm.org/D34796 ___ cfe-commits mailing

[PATCH] D36712: Emit section information for extern variables

eandrews updated this revision to Diff 111388. eandrews added a comment. Updated the patch to include Krzysztof's comment about explicitly stating undefined behavior for section information mismatch in global variable declaration and definition. This should cover the case where section is

r311037 - Use the file name from linemarker for debug info if an input is preprocessed source.

Author: twoh Date: Wed Aug 16 12:36:24 2017 New Revision: 311037 URL: http://llvm.org/viewvc/llvm-project?rev=311037=rev Log: Use the file name from linemarker for debug info if an input is preprocessed source. Summary: Even in the case of the input file is a preprocessed source, clang uses the

[PATCH] D36474: Use the file name from linemarker for debug info if an input is preprocessed source.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311037: Use the file name from linemarker for debug info if an input is preprocessed… (authored by twoh). Repository: rL LLVM https://reviews.llvm.org/D36474 Files:

[PATCH] D36761: [clang-tidy] Use CloexecCheck as base class.

chh updated this revision to Diff 111372. chh marked 3 inline comments as done. https://reviews.llvm.org/D36761 Files: clang-tidy/android/CloexecCheck.cpp clang-tidy/android/CloexecCheck.h clang-tidy/android/CloexecCreatCheck.cpp clang-tidy/android/CloexecCreatCheck.h

[PATCH] D35362: [clang-tidy] Add a close-on-exec check on accept() in Android module.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311024: [clang-tidy] Add a close-on-exec check on accept() in Android module. (authored by chh). Changed prior to commit: https://reviews.llvm.org/D35362?vs=111377=111378#toc Repository: rL LLVM

[clang-tools-extra] r311024 - [clang-tidy] Add a close-on-exec check on accept() in Android module.

Author: chh Date: Wed Aug 16 10:18:16 2017 New Revision: 311024 URL: http://llvm.org/viewvc/llvm-project?rev=311024=rev Log: [clang-tidy] Add a close-on-exec check on accept() in Android module. Summary: accept() is better to be replaced by accept4() with SOCK_CLOEXEC flag to avoid file

[PATCH] D35363: [clang-tidy] Add a close-on-exec check on accept4() in Android module.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311027: [clang-tidy] Add a close-on-exec check on accept4() in Android module. (authored by chh). Changed prior to commit: https://reviews.llvm.org/D35363?vs=110755=111383#toc Repository: rL LLVM

[clang-tools-extra] r311027 - [clang-tidy] Add a close-on-exec check on accept4() in Android module.

Author: chh Date: Wed Aug 16 10:46:18 2017 New Revision: 311027 URL: http://llvm.org/viewvc/llvm-project?rev=311027=rev Log: [clang-tidy] Add a close-on-exec check on accept4() in Android module. Summary: accept4() is better to set SOCK_CLOEXEC flag to avoid file descriptor leakage.

[PATCH] D36790: [ObjC] Messages to 'self' in class methods should use class method dispatch to avoid multiple method ambiguities

rjmccall added a reviewer: doug.gregor. rjmccall added a comment. Tagging Doug. Repository: rL LLVM https://reviews.llvm.org/D36790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r311028 - [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module.

Author: chh Date: Wed Aug 16 10:53:12 2017 New Revision: 311028 URL: http://llvm.org/viewvc/llvm-project?rev=311028=rev Log: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module. Summary: epoll_create1() is better to set EPOLL_CLOEXEC flag to avoid file descriptor

[PATCH] D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311029: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module. (authored by chh). Changed prior to commit: https://reviews.llvm.org/D35367?vs=110751=111386#toc Repository: rL

[PATCH] D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module.

chh added inline comments. Comment at: clang-tidy/android/CloexecEpollCreateCheck.cpp:27-31 + replaceFunc(Result, /*WarningMsg=*/ + "prefer epoll_create() to epoll_create1() " + "because epoll_create1() allows " + "EPOLL_CLOEXEC",

[PATCH] D36761: [clang-tidy] Use CloexecCheck as base class.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311020: [clang-tidy] Use CloexecCheck as base class. (authored by chh). Changed prior to commit: https://reviews.llvm.org/D36761?vs=111372=111373#toc Repository: rL LLVM

[clang-tools-extra] r311020 - [clang-tidy] Use CloexecCheck as base class.

Author: chh Date: Wed Aug 16 09:59:26 2017 New Revision: 311020 URL: http://llvm.org/viewvc/llvm-project?rev=311020=rev Log: [clang-tidy] Use CloexecCheck as base class. Summary: Simplify registerMatchers and check functions in CloexecCreatCheck, CloexecSocketCheck, CloexecFopenCheck, and

[PATCH] D35365: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311028: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module. (authored by chh). Changed prior to commit: https://reviews.llvm.org/D35365?vs=110752=111385#toc Repository: rL

[PATCH] D36492: [time-report] Add preprocessor timer

modocache added a comment. Friendly ping! I think this is ready to be reviewed. It adds an additional row, `Preprocessing`, to the `Miscellaneous Ungrouped Timers` section of the `clang -ftime-report` output: ===-===

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

faisalv added a comment. I'll try and get you some feedback on this over the next couple of days (unless someone else jumps in). Thanks for working on this! https://reviews.llvm.org/D36527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35362: [clang-tidy] Add a close-on-exec check on accept() in Android module.

chh commandeered this revision. chh added a reviewer: yawanng. chh added inline comments. Comment at: clang-tidy/android/CloexecAcceptCheck.cpp:42 + "prefer accept4() to accept() because accept4() allows SOCK_CLOEXEC", + /*FixMsg=*/ReplacementText); +}

[PATCH] D36474: Use the file name from linemarker for debug info if an input is preprocessed source.

twoh added a comment. Ping. Thanks! https://reviews.llvm.org/D36474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36712: Emit section information for extern variables

eandrews added a comment. In https://reviews.llvm.org/D36712#843414, @kparzysz wrote: > The problem is that the mismatch between sections does not have to lead to > any undesirable behavior. Whether it does or not depends on a particular > case. I think we should be consistent though---if we

[PATCH] D36492: [time-report] Add preprocessor timer

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D36492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r311035 - [clang-tidy] Use const char* to compile with VC cl.exe.

Author: chh Date: Wed Aug 16 12:13:35 2017 New Revision: 311035 URL: http://llvm.org/viewvc/llvm-project?rev=311035=rev Log: [clang-tidy] Use const char* to compile with VC cl.exe. Summary: cl.exe does not accept constexpr char FuncBindingStr[] = ... Differential Revision:

[libclc] r311021 - amdgcn: Implement {read_, write_, }mem_fence builtin

Author: jvesely Date: Wed Aug 16 10:08:56 2017 New Revision: 311021 URL: http://llvm.org/viewvc/llvm-project?rev=311021=rev Log: amdgcn: Implement {read_,write_,}mem_fence builtin v2: add more detailed comment about waitcnt instruction Signed-off-by: Jan Vesely

[libclc] r311022 - amdgcn: rewrite barrier() using fence and clang __builtin_amdgcn_s_barrier

Author: jvesely Date: Wed Aug 16 10:09:00 2017 New Revision: 311022 URL: http://llvm.org/viewvc/llvm-project?rev=311022=rev Log: amdgcn: rewrite barrier() using fence and clang __builtin_amdgcn_s_barrier Specs require using fences when barrier() is invoked: "The barrier function will either

[PATCH] D36802: AMDGPU: Insert __devicename__ macros

kzhuravl created this revision. Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng. https://reviews.llvm.org/D36802 Files: lib/Basic/Targets/AMDGPU.cpp lib/Basic/Targets/AMDGPU.h test/Driver/amdgcn-mcpu-macro.cl test/Driver/r600-mcpu-macro.cl

[PATCH] D36771: AMDGPU: add missing amdgcn processors and tests

kzhuravl added a comment. In https://reviews.llvm.org/D36771#842837, @arsenm wrote: > We should also be defining __devicename__ macros. I opened a bug for this > last week https://reviews.llvm.org/D36802 https://reviews.llvm.org/D36771 ___

[PATCH] D36802: AMDGPU: Insert __devicename__ macros

kzhuravl added a comment. Do we need this for r600? https://reviews.llvm.org/D36802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36779: [Driver] SafeStack does not need a runtime library on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL311034: [Driver] SafeStack does not need a runtime library on Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D36779?vs=111301=111400#toc Repository: rL LLVM

[PATCH] D36474: Use the file name from linemarker for debug info if an input is preprocessed source.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D36474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r311029 - [clang-tidy] Add a close-on-exec check on epoll_create() in Android module.

Author: chh Date: Wed Aug 16 11:02:49 2017 New Revision: 311029 URL: http://llvm.org/viewvc/llvm-project?rev=311029=rev Log: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module. Summary: epoll_create() is better to be replaced by epoll_create1() with EPOLL_CLOEXEC flag to

Re: [clang-tools-extra] r311020 - [clang-tidy] Use CloexecCheck as base class.

Hi, this change breaks build: clang-tools-extra/clang-tidy/android/CloexecSocketCheck.cpp:20:30: error: unused variable 'SOCK_CLOEXEC' [-Werror,-Wunused-const-variable] static constexpr const char *SOCK_CLOEXEC = "SOCK_CLOEXEC"; Please test with LLVM_ENABLE_WERROR=ON before submitting! On Wed,

[PATCH] D36492: [time-report] Add preprocessor timer

modocache planned changes to this revision. modocache added inline comments. Comment at: lib/Lex/Preprocessor.cpp:746 void Preprocessor::Lex(Token ) { + llvm::TimeRegion(PPOpts->getTimer()); + erik.pilkington wrote: > Doesn't this just start a timer and

[PATCH] D36492: [time-report] Add preprocessor timer

erik.pilkington added a comment. This looks really usefull, thanks for working on this! Comment at: lib/Lex/Preprocessor.cpp:746 void Preprocessor::Lex(Token ) { + llvm::TimeRegion(PPOpts->getTimer()); + Doesn't this just start a timer and immediately end

[PATCH] D36441: Add Support for Reference Counting of Parameters on the Callee Side in RetainCountChecker

malhar1995 updated this revision to Diff 111420. malhar1995 added a comment. This patch adds the functionality of performing reference counting on the callee side for Integer Set Library (ISL) to Clang Static Analyzer's RetainCountChecker. Reference counting on the callee side can be

r311051 - Fix typos in comments; NFC

Author: gbiv Date: Wed Aug 16 15:44:17 2017 New Revision: 311051 URL: http://llvm.org/viewvc/llvm-project?rev=311051=rev Log: Fix typos in comments; NFC Modified: cfe/trunk/include/clang/Lex/MultipleIncludeOpt.h cfe/trunk/lib/Sema/SemaExpr.cpp Modified:

[PATCH] D36764: The following functions and tests work fine for powerpc64, so enable them.

aheejin resigned from this revision. aheejin added a comment. I don't have enough context or knowledge on this code base. Sorry! https://reviews.llvm.org/D36764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxxabi] r311045 - [libcxxabi] When built with ASan, __cxa_throw calls __asan_handle_no_return

Author: phosek Date: Wed Aug 16 14:58:09 2017 New Revision: 311045 URL: http://llvm.org/viewvc/llvm-project?rev=311045=rev Log: [libcxxabi] When built with ASan, __cxa_throw calls __asan_handle_no_return The ASan runtime on many systems intercepts cxa_throw just so it can call

[clang-tools-extra] r311040 - [clang-tidy] Remove unused static variable.

Author: chh Date: Wed Aug 16 14:00:06 2017 New Revision: 311040 URL: http://llvm.org/viewvc/llvm-project?rev=311040=rev Log: [clang-tidy] Remove unused static variable. Differential Revision: https://reviews.llvm.org/D36761 Modified:

r311041 - Base optimization-record file names on the final output

Author: hfinkel Date: Wed Aug 16 14:34:27 2017 New Revision: 311041 URL: http://llvm.org/viewvc/llvm-project?rev=311041=rev Log: Base optimization-record file names on the final output Using Output.getFilename() to construct the file name used for optimization recording in Clang::ConstructJob,

[libcxxabi] r311047 - Revert "[libcxxabi] When built with ASan, __cxa_throw calls __asan_handle_no_return"

Author: phosek Date: Wed Aug 16 15:05:54 2017 New Revision: 311047 URL: http://llvm.org/viewvc/llvm-project?rev=311047=rev Log: Revert "[libcxxabi] When built with ASan, __cxa_throw calls __asan_handle_no_return" This reverts commit r311045 because it's causing an error on

  1   2   >