Re: [clang-tools-extra] r314808 - [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise

Hi Juergen, i did already work on fixing the issue I introduced with the commits. I am currently waiting for the buildbot to catch up with the committed fix. As far as i can see, the newer commits did actually fix (at least chapunis buildbot did go green again), but i have my eye on it. Cheers,

[PATCH] D37542: [ubsan] Save a ptrtoint when emitting alignment checks

vsk closed this revision. vsk added a comment. Landed as r314749 https://reviews.llvm.org/D37542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r314831 - Revert r314820 "[Analyzer] More granular special casing in RetainCountChecker"

Author: timshen Date: Tue Oct 3 12:39:02 2017 New Revision: 314831 URL: http://llvm.org/viewvc/llvm-project?rev=314831=rev Log: Revert r314820 "[Analyzer] More granular special casing in RetainCountChecker" The test retain-release.m fails with this patch. Differential Revision:

[PATCH] D37442: [C++17] Disallow lambdas in template parameters (PR33696).

Rakete updated this revision to Diff 117568. Rakete added a comment. - rebased Does anyone have a better name than `ExpressionType`? I don't really like it. https://reviews.llvm.org/D37442 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h

[PATCH] D38503: [CodeGen] Unify generation of scalar and struct-path TBAA tags

kosarev added a comment. Just in case, please let me know if you think this change should further be broken down into smaller pieces. Thanks. Repository: rL LLVM https://reviews.llvm.org/D38503 ___ cfe-commits mailing list

r314820 - [Analyzer] More granular special casing in RetainCountChecker

Author: george.karpenkov Date: Tue Oct 3 11:12:15 2017 New Revision: 314820 URL: http://llvm.org/viewvc/llvm-project?rev=314820=rev Log: [Analyzer] More granular special casing in RetainCountChecker Only assume that IOBSDNameMatching and friends increment a reference counter if their return

r314833 - [OPENMP] Allow use of declare target directive inside struct

Author: abataev Date: Tue Oct 3 13:00:00 2017 New Revision: 314833 URL: http://llvm.org/viewvc/llvm-project?rev=314833=rev Log: [OPENMP] Allow use of declare target directive inside struct declaration. Patch allows using of the `#pragma omp declare target`| `#pragma omp end declare target`

[PATCH] D37903: Fix assume-filename handling in clang-format.el

werbitt updated this revision to Diff 117574. werbitt added a comment. Use uppercase when referring to arguments https://reviews.llvm.org/D37903 Files: tools/clang-format/clang-format.el Index: tools/clang-format/clang-format.el

[PATCH] D38048: [clangd] Add textDocument/signatureHelp

rwols marked an inline comment as done. rwols added a comment. Thinking ahead, it's probably best if we change the behavior of `SnippetCompletionItemCollector` as follows: 1. If it finds a callable, provide the name of the callable, followed by an opening parenthesis, followed by `$0`,

[PATCH] D38483: [ExprConstant] Allow constexpr ctor to modify non static data members in body

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: lib/AST/ExprConstant.cpp:3127 // During the construction of an object, it is not yet 'const'. // FIXME: We don't set up EvaluatingDecl for

r314838 - Suppress -Wmissing-braces warning when aggregate-initializing a struct with a single field that is itself an aggregate.

Author: rsmith Date: Tue Oct 3 13:36:00 2017 New Revision: 314838 URL: http://llvm.org/viewvc/llvm-project?rev=314838=rev Log: Suppress -Wmissing-braces warning when aggregate-initializing a struct with a single field that is itself an aggregate. In C++, such initialization of std::array

[PATCH] D38473: Include getting generated struct offsets in CodegenABITypes

mppf updated this revision to Diff 117579. mppf added a comment. Herald added a subscriber: mgorny. - Add a test of getFieldNumber (and others) https://reviews.llvm.org/D38473 Files: include/clang/CodeGen/CodeGenABITypes.h lib/CodeGen/CodeGenABITypes.cpp unittests/CodeGen/CMakeLists.txt

[PATCH] D38048: [clangd] Add textDocument/signatureHelp

rwols updated this revision to Diff 117580. rwols added a comment. Reword the documentation of the signature help structures in Protocol.h https://reviews.llvm.org/D38048 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/ClangdServer.h

[libunwind] r314834 - build: use POSITION_INDEPENDENT_CODE instead of -fPIC

Author: compnerd Date: Tue Oct 3 13:22:26 2017 New Revision: 314834 URL: http://llvm.org/viewvc/llvm-project?rev=314834=rev Log: build: use POSITION_INDEPENDENT_CODE instead of -fPIC Rather than hardcode the flag and check if the compiler supports it, use the CMake property to get the right

[clang-tools-extra] r314840 - Fix hicpp-signed-bitwise.cpp test on Windows, where the MSVC ABI changes enum underlying types

Author: rnk Date: Tue Oct 3 13:37:06 2017 New Revision: 314840 URL: http://llvm.org/viewvc/llvm-project?rev=314840=rev Log: Fix hicpp-signed-bitwise.cpp test on Windows, where the MSVC ABI changes enum underlying types Modified:

[PATCH] D38517: Enabling new pass manager in LTO (and thinLTO) link step via -fexperimental-new-pass-manager option

gyiu created this revision. Herald added subscribers: inglorion, mehdi_amini. Modifications to driver and gold plugin code to get the new pass manager path enabled in LTO (and thinLTO). Repository: rL LLVM https://reviews.llvm.org/D38517 Files: lib/Driver/ToolChains/CommonArgs.cpp

Re: [clang-tools-extra] r314808 - [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise

Hi Jonas, this new test is failing on Green Dragon: http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA/39223/consoleFull#11207350448254eaf0-7326-4999-85b0-388101f2d404 Could you please take a look? Thanks Cheers, Juergen On Tue, Oct 3, 2017 at 9:25 AM, Jonas Toth via cfe-commits <

Re: [clang-tools-extra] r314808 - [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise

Great! Thanks Jonas > On Oct 3, 2017, at 10:54 AM, Jonas Toth wrote: > > Hi Juergen, > > i did already work on fixing the issue I introduced with the commits. I am > currently waiting for the buildbot to catch up with the committed fix. > > As far as i can see, the

[PATCH] D38522: [libc++] Support Microsoft ABI without vcruntime headers

smeenai added inline comments. Comment at: src/support/runtime/exception_msvc.ipp:31 +extern "C" { +typedef void(__CRTDECL* terminate_handler)(); +_ACRTIMP terminate_handler __cdecl set_terminate( smeenai wrote: > compnerd wrote: > > Really? clang-format

[PATCH] D37826: Refine generation of TBAA information in clang

rjmccall added a comment. I assume I should wait on reviewing this until all of these smaller TBAA patches land? https://reviews.llvm.org/D37826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r314871 - PR34822: Fix a collection of related bugs with our handling of C89 implicit function declarations.

Author: rsmith Date: Tue Oct 3 18:49:22 2017 New Revision: 314871 URL: http://llvm.org/viewvc/llvm-project?rev=314871=rev Log: PR34822: Fix a collection of related bugs with our handling of C89 implicit function declarations. We were injecting the function into the wrong semantic context,

r314872 - We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case.

Author: rsmith Date: Tue Oct 3 18:58:22 2017 New Revision: 314872 URL: http://llvm.org/viewvc/llvm-project?rev=314872=rev Log: We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case. Modified:

[PATCH] D38473: Include getting generated struct offsets in CodegenABITypes

rjmccall added inline comments. Comment at: include/clang/CodeGen/CodeGenABITypes.h:81 +// Returns a field number for a struct suitable for GEP'ing +unsigned getFieldNumber(CodeGenModule , "Given a non-bitfield struct field, return its index within the

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

rjmccall added a comment. Why is most of this patch necessary under the design of adding a non-canonical __private address space? Comment at: include/clang/AST/Type.h:336 + /// space makes difference. + bool getImplicitAddressSpaceFlag() const { return Mask & IMask; } +

r314854 - [CMake] Minor updates to Apple CMake caches

Author: cbieneman Date: Tue Oct 3 14:59:53 2017 New Revision: 314854 URL: http://llvm.org/viewvc/llvm-project?rev=314854=rev Log: [CMake] Minor updates to Apple CMake caches * Turn off embedded compiler-rt builds in stage1 * Support generating Xcode toolchains from Stage2 build configurations

[PATCH] D38210: [ubsan] Port the function sanitizer to C

pcc added a comment. Wouldn't we get false positives if there is an indirect call in C++ code that calls into C code (or vice versa)? I think I'd prefer it if we came up with a precise encoding of function types that was independent of RTTI, and use it in all languages. One possibility would

[PATCH] D38473: Include getting generated struct offsets in CodegenABITypes

rsmith added a comment. I have no philosophical objection to exposing this, but defer to @rjmccall on that. As is usual with our C++ API, there's no guarantee that we will keep this working in future versions. (Eg, if we move to an IR representation using something non-GEPable to represent a

[PATCH] D38210: [ubsan] Port the function sanitizer to C

vsk added a reviewer: arphaman. vsk added a comment. Ping. https://reviews.llvm.org/D38210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38210: [ubsan] Port the function sanitizer to C

vsk planned changes to this revision. vsk added a comment. In https://reviews.llvm.org/D38210#887635, @pcc wrote: > Wouldn't we get false positives if there is an indirect call in C++ code that > calls into C code (or vice versa)? Ah, right, I'm surprised I didn't hit that while testing. > I

r314859 - [Analyzer] Re-apply r314820 with a fix for StringRef lifetime.

Author: george.karpenkov Date: Tue Oct 3 16:15:35 2017 New Revision: 314859 URL: http://llvm.org/viewvc/llvm-project?rev=314859=rev Log: [Analyzer] Re-apply r314820 with a fix for StringRef lifetime. Fixes the test failure: temporary is now bound to std::string, tests fully pass on Linux. This

r314780 - [CodeGen] Introduce generic TBAA access descriptors

Author: kosarev Date: Tue Oct 3 03:52:39 2017 New Revision: 314780 URL: http://llvm.org/viewvc/llvm-project?rev=314780=rev Log: [CodeGen] Introduce generic TBAA access descriptors With this patch we implement a concept of TBAA access descriptors that are capable of representing both scalar and

[PATCH] D38460: [CodeGen] Fix propagation of TBAA info for atomic accesses

This revision was automatically updated to reflect the committed changes. Closed by commit rL314784: [CodeGen] Fix propagation of TBAA info for atomic accesses (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D38460?vs=117349=117498#toc Repository: rL LLVM

r314784 - [CodeGen] Fix propagation of TBAA info for atomic accesses

Author: kosarev Date: Tue Oct 3 04:31:42 2017 New Revision: 314784 URL: http://llvm.org/viewvc/llvm-project?rev=314784=rev Log: [CodeGen] Fix propagation of TBAA info for atomic accesses This patch fixes clang to propagate complete TBAA information for atomic accesses and not just the final

[PATCH] D38456: [CodeGen] Introduce generic TBAA access descriptors

This revision was automatically updated to reflect the committed changes. Closed by commit rL314780: [CodeGen] Introduce generic TBAA access descriptors (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D38456?vs=117339=117494#toc Repository: rL LLVM

[clang-tools-extra] r314785 - [clang-tidy] Fixed a small code example in docs. NFC.

Author: xazax Date: Tue Oct 3 04:40:07 2017 New Revision: 314785 URL: http://llvm.org/viewvc/llvm-project?rev=314785=rev Log: [clang-tidy] Fixed a small code example in docs. NFC. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-string-constructor.rst Modified:

[PATCH] D38463: [OpenCL] Fix checking of vector type casting

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D38463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37903: Fix assume-filename handling in clang-format.el

werbitt updated this revision to Diff 117500. werbitt added a comment. Thanks, I was too hasty when I tried to fix the mess I created when I diffed against an updated master and uploaded it without noticing. I believe this diff gets me back to where I intended. https://reviews.llvm.org/D37903

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr added a comment. In https://reviews.llvm.org/D31417#886441, @hfinkel wrote: > Is this still being worked on? Hi, yes it is. Sorry for the delay in posting new changes but priorities shifted a bit and I had to work on something else for a while. I do have a new version that's just

[PATCH] D38402: [clang-refactor] Apply source replacements

ioeric added inline comments. Comment at: test/Refactor/tool-apply-replacements.cpp:6 + +class RenameMe { // CHECK: class { +}; Why is the result `class {`? Comment at: tools/clang-refactor/ClangRefactor.cpp:319 - // FIXME: Consume atomic

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

lebedev.ri added a comment. Ping :) Does this need more, different tests? Should i rewrite that lengthy if-else-if chain somehow differently? Repository: rL LLVM https://reviews.llvm.org/D38101 ___ cfe-commits mailing list

[PATCH] D38502: allow access decl without using keyword when emulate msvc

comicfans44 created this revision. comicfans44 added a project: clang. msvc allow such code construction in vs2010 / vs2017 , needs someone check this behavior in VS2012/VS2013/VS2015 Repository: rL LLVM https://reviews.llvm.org/D38502 Files: clang/lib/Sema/SemaDeclCXX.cpp Index:

[PATCH] D37903: Fix assume-filename handling in clang-format.el

phst accepted this revision. phst added inline comments. Comment at: tools/clang-format/clang-format.el:126 +no active region. If no style is given uses `clang-format-style'. Use +ASSUME-FILE-NAME to locate a style config file, if no assume-file-name is given +uses the

[PATCH] D38460: [CodeGen] Fix propagation of TBAA info for atomic accesses

kosarev added a comment. Answering your question: it's just to keep functional changes apart from purely refactoring patches. Repository: rL LLVM https://reviews.llvm.org/D38460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r314802 - [OpenCL] Fix checking of vector type casting

Author: yaxunl Date: Tue Oct 3 07:34:29 2017 New Revision: 314802 URL: http://llvm.org/viewvc/llvm-project?rev=314802=rev Log: [OpenCL] Fix checking of vector type casting Currently clang allows the following code int a; int b = (const int) a; However it does not the following code int4 a;

[PATCH] D38463: [OpenCL] Fix checking of vector type casting

This revision was automatically updated to reflect the committed changes. Closed by commit rL314802: [OpenCL] Fix checking of vector type casting (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D38463?vs=117357=117524#toc Repository: rL LLVM

[PATCH] D38483: [ExprConstant] Allow constexpr ctor to modify non static data members in body

erik.pilkington updated this revision to Diff 117529. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. Thanks for the feedback, in this new patch: - insert EvaluatingDecl into EvaluatingConstructors instead of checking it in isEvaluatingDecl() - Add a comment

[PATCH] D38483: [ExprConstant] Allow constexpr ctor to modify non static data members in body

erik.pilkington added inline comments. Comment at: lib/AST/ExprConstant.cpp:588 + : EI(EI), Object(Object) { +DidInsert = EI.EvaluatingConstructors.insert(Object).second; + } rsmith wrote: > Can the `DidInsert == false` case actually

[PATCH] D38503: [CodeGen] Unify generation of scalar and struct-path TBAA tags

kosarev created this revision. kosarev added a project: clang. This patch makes it possible to produce access tags in a uniform manner regardless whether the resulting tag will be a scalar or a struct-path one. getAccessTagInfo() now takes care of the actual translation of access descriptors

[PATCH] D35046: [coroutines] Include "this" type when looking up coroutine_traits

GorNishanov added a comment. @toby-allsopp: You mentioned that @EricWF already got this in. Can you close ("abandon") this patch if it is no longer needed. https://reviews.llvm.org/D35046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38473: Include getting generated struct offsets in CodegenABITypes

aprantl added a comment. This needs some kind of testcase. Either a unittest or a test-only executable similar to, for example, clang-index-test. https://reviews.llvm.org/D38473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

rnk accepted this revision. rnk added a comment. Sorry for the delay, thank you, this looks good! @martell, do you mind landing this? https://reviews.llvm.org/D38123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

hfinkel added a comment. In https://reviews.llvm.org/D31417#886826, @huntergr wrote: > In https://reviews.llvm.org/D31417#886441, @hfinkel wrote: > > > Is this still being worked on? > > > Hi, yes it is. Sorry for the delay in posting new changes but priorities > shifted a bit and I had to work

[clang-tools-extra] r314808 - [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise

Author: jonastoth Date: Tue Oct 3 09:25:01 2017 New Revision: 314808 URL: http://llvm.org/viewvc/llvm-project?rev=314808=rev Log: [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise The bug happened with stream operations, that were not recognized in all cases. Even there

[clang-tools-extra] r314811 - [clang-tidy] Remove target specification hicpp-signed-bitwise

Author: jonastoth Date: Tue Oct 3 09:27:41 2017 New Revision: 314811 URL: http://llvm.org/viewvc/llvm-project?rev=314811=rev Log: [clang-tidy] Remove target specification hicpp-signed-bitwise This patch removes the targetspecification of a testcase, that broke for ARM. The underlying problem

[clang-tools-extra] r314812 - [clang-tidy] potentially fix buildbot

Author: jonastoth Date: Tue Oct 3 09:53:56 2017 New Revision: 314812 URL: http://llvm.org/viewvc/llvm-project?rev=314812=rev Log: [clang-tidy] potentially fix buildbot I tried to silence lit with `| count 0`, which did not work. Other testcases did not have `-- --` but only `--` in the RUN

[clang-tools-extra] r314816 - [clang-tidy] fix buildbot hicpp-signed-bitwise

Author: jonastoth Date: Tue Oct 3 10:08:57 2017 New Revision: 314816 URL: http://llvm.org/viewvc/llvm-project?rev=314816=rev Log: [clang-tidy] fix buildbot hicpp-signed-bitwise To finally fix the buildbot I added one single warning testcase. Modified:

[PATCH] D38522: [libc++] Support Microsoft ABI without vcruntime headers

smeenai created this revision. Herald added a subscriber: mgorny. The vcruntime headers are hairy and clash with both libc++ headers themselves and other libraries. libc++ normally deals with the clashes by deferring to the vcruntime headers and silencing its own definitions, but for clients

[PATCH] D38525: Cleanup and generalize -shared-libasan.

eugenis created this revision. Herald added a subscriber: srhines. - Add -static-libasan for targets that default to shared. - Remove an Android special case. It is now possible (but untested) to use static compiler-rt libraries there. - Support libclang_rt.ubsan_standalone as a shared library.

[PATCH] D38522: [libc++] Support Microsoft ABI without vcruntime headers

smeenai added a comment. In https://reviews.llvm.org/D38522#887768, @compnerd wrote: > Why do we expect the tests to fail without vcruntime headers? msvcrt's implementations of the various new/delete operators call `__scrt_throw_std_bad_alloc` and `__scrt_throw_std_bad_array_new_length`,

[libcxx] r314864 - Add C++17 explicit deduction guides to std::pair.

Author: ericwf Date: Tue Oct 3 17:04:26 2017 New Revision: 314864 URL: http://llvm.org/viewvc/llvm-project?rev=314864=rev Log: Add C++17 explicit deduction guides to std::pair. This patch adds the newly standardized deduction guides for std::pair, allowing it to work class template deduction.

[PATCH] D38517: Enabling new pass manager in LTO (and thinLTO) link step via -fexperimental-new-pass-manager option

tejohnson added a comment. Thanks for adding this. Please add a test like the one for -ffunction-sections (tools/clang/test/Driver/gold-lto-sections.c). Repository: rL LLVM https://reviews.llvm.org/D38517 ___ cfe-commits mailing list

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

rsmith added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8583-8586 +// Checks whether Expr 'Constant' may be the +// std::numeric_limits<>::max() or std::numeric_limits<>::min() +// of the Expr 'Other'. If true, then returns the limit type (min or max). +// Does not

[PATCH] D38483: [ExprConstant] Allow constexpr ctor to modify non static data members in body

This revision was automatically updated to reflect the committed changes. Closed by commit rL314865: [ExprConstant] Allow constexpr ctor to modify non static data members (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D38483?vs=117529=117605#toc Repository: rL LLVM

r314865 - [ExprConstant] Allow constexpr ctor to modify non static data members

Author: epilk Date: Tue Oct 3 17:18:55 2017 New Revision: 314865 URL: http://llvm.org/viewvc/llvm-project?rev=314865=rev Log: [ExprConstant] Allow constexpr ctor to modify non static data members Fixes PR19741. Differential revision: https://reviews.llvm.org/D38483 Modified:

[PATCH] D38522: [libc++] Support Microsoft ABI without vcruntime headers

smeenai updated this revision to Diff 117613. smeenai added a comment. Remove SAL annotations as well; they're unneeded and add a header dependency https://reviews.llvm.org/D38522 Files: CMakeLists.txt docs/UsingLibcxx.rst include/__config_site.in include/exception include/new

[PATCH] D38522: [libc++] Support Microsoft ABI without vcruntime headers

compnerd added a comment. Why do we expect the tests to fail without vcruntime headers? Comment at: src/support/runtime/exception_msvc.ipp:31 +extern "C" { +typedef void(__CRTDECL* terminate_handler)(); +_ACRTIMP terminate_handler __cdecl set_terminate(

[PATCH] D38372: [OpenMP] Fix passing of -m arguments correctly

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

hfinkel updated this revision to Diff 117619. hfinkel added a comment. Herald added a subscriber: kosarev. Rebased. https://reviews.llvm.org/D32199 Files: include/clang/Basic/Sanitizers.def include/clang/Driver/SanitizerArgs.h lib/CodeGen/BackendUtil.cpp lib/CodeGen/CGDecl.cpp

r314873 - Move verbosity check for opt remarks to the diag handler.

Author: anemet Date: Tue Oct 3 21:25:31 2017 New Revision: 314873 URL: http://llvm.org/viewvc/llvm-project?rev=314873=rev Log: Move verbosity check for opt remarks to the diag handler. Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp URL: