[PATCH] D38921: [analyzer] LoopUnrolling: update the matched assignment operators

szepet updated this revision to Diff 123176. szepet added a reviewer: klimek. szepet added a comment. Herald added subscribers: a.sidorin, rnkovacs. isAssignmentOp matcher moved to ASTMatchers.h (Manuel added to reviewers as the code owner of ASTMatchers) https://reviews.llvm.org/D38921 Files:

r318414 - Update tests for llvm.invariant.group.barrier becoming mangled

Author: yaxunl Date: Thu Nov 16 08:33:04 2017 New Revision: 318414 URL: http://llvm.org/viewvc/llvm-project?rev=318414=rev Log: Update tests for llvm.invariant.group.barrier becoming mangled Differential Revision: https://reviews.llvm.org/D40062 Modified:

r318411 - Allow to store precompiled preambles in memory.

Author: ibiryukov Date: Thu Nov 16 08:25:01 2017 New Revision: 318411 URL: http://llvm.org/viewvc/llvm-project?rev=318411=rev Log: Allow to store precompiled preambles in memory. Summary: These preambles are built by ASTUnit and clangd. Previously, preambles were always stored on disk.

[clang-tools-extra] r318412 - [clangd] Use in-memory preambles in clangd.

Author: ibiryukov Date: Thu Nov 16 08:25:18 2017 New Revision: 318412 URL: http://llvm.org/viewvc/llvm-project?rev=318412=rev Log: [clangd] Use in-memory preambles in clangd. Reviewers: klimek, bkramer, sammccall Reviewed By: sammccall Subscribers: cfe-commits Differential Revision:

[PATCH] D39918: [libunwind] Remove a FIXME about truncated section names

mstorsjo added a comment. @rnk I guess this is ok now as https://reviews.llvm.org/D40025 is committed and done? https://reviews.llvm.org/D39918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40132: [clangd] Tracing improvements

sammccall created this revision. [clangd] Tracing improvements Compose JSON using JSONExpr Allow attaching metadata to spans (and avoid it if tracing is off) Attach IDs and responses of JSON RPCs to their spans The downside is that large responses make the trace viewer sluggish. We should make

[PATCH] D39842: Allow to store precompiled preambles in memory.

mgorny added a comment. Please revert this commit. You've just broken all the stand-alone builds of clang. Comment at: cfe/trunk/lib/Frontend/PrecompiledPreamble.cpp:27 #include "llvm/ADT/StringSet.h" +#include "llvm/Config/config.h" #include

[PATCH] D38921: [analyzer] LoopUnrolling: update the matched assignment operators

lebedev.ri added a comment. Not sure how `clang/docs/LibASTMatchersReference.html` is supposed to be updated. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3931 + +/// \brief Matches all kind of assignment operators. +/// Maybe ``` -/// \brief Matches

[PATCH] D39842: Allow to store precompiled preambles in memory.

This revision was automatically updated to reflect the committed changes. Closed by commit rL318411: Allow to store precompiled preambles in memory. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D39842 Files: cfe/trunk/include/clang/Frontend/FrontendActions.h

[PATCH] D39843: [clangd] Use in-memory preambles in clangd.

This revision was automatically updated to reflect the committed changes. Closed by commit rL318412: [clangd] Use in-memory preambles in clangd. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D39843 Files: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp

[PATCH] D40062: Update tests for llvm.invariant.group.barrier becoming mangled

This revision was automatically updated to reflect the committed changes. Closed by commit rL318414: Update tests for llvm.invariant.group.barrier becoming mangled (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D40062?vs=122959=123193#toc Repository: rL LLVM

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

ilya-biryukov added inline comments. Comment at: clangd/Protocol.h:295 + +struct ClangdConfigurationParams { + malaperle wrote: > ilya-biryukov wrote: > > Maybe call it `ClangdConfigurationParamsChange` to make it clear those are > > diffs, not the actual

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

malaperle added inline comments. Comment at: clangd/Protocol.h:295 + +struct ClangdConfigurationParams { + ilya-biryukov wrote: > malaperle wrote: > > ilya-biryukov wrote: > > > Maybe call it `ClangdConfigurationParamsChange` to make it clear those > > > are

[PATCH] D38921: [analyzer] LoopUnrolling: update the matched assignment operators

szepet updated this revision to Diff 123187. szepet marked 2 inline comments as done. szepet added a comment. Testfiles added and HTML updated. https://reviews.llvm.org/D38921 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.cpp:580 +void ClangdServer::reparseOpenedFiles() { + for (auto Draft : DraftMgr.getDrafts().keys()) { +forceReparse(Draft); Could we have a method in `DraftStore` that returns all active

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

malaperle added inline comments. Comment at: clangd/Protocol.h:295 + +struct ClangdConfigurationParams { + ilya-biryukov wrote: > Maybe call it `ClangdConfigurationParamsChange` to make it clear those are > diffs, not the actual params? The idea was that we can

[PATCH] D39842: Allow to store precompiled preambles in memory.

ilya-biryukov updated this revision to Diff 123172. ilya-biryukov added a comment. - Removed redundant #include. https://reviews.llvm.org/D39842 Files: include/clang/Frontend/FrontendActions.h include/clang/Frontend/PrecompiledPreamble.h lib/Frontend/ASTUnit.cpp

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

koldaniel added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:382 +DescFile<"CheckSecuritySyntaxOnly.cpp">; + def DeprecatedBufferHandling : Checker<"DeprecatedBufferHandling">, +HelpText<"Warn on uses of deprecated buffer manipulating

[PATCH] D39842: Allow to store precompiled preambles in memory.

ilya-biryukov added inline comments. Comment at: lib/Frontend/PrecompiledPreamble.cpp:44 +SmallString<64> Path; +llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/true, Path); +llvm::sys::path::append(Path, "___clang_inmemory_preamble___");

[PATCH] D39842: Allow to store precompiled preambles in memory.

ilya-biryukov added inline comments. Comment at: lib/Frontend/PrecompiledPreamble.cpp:44 +SmallString<64> Path; +llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/true, Path); +llvm::sys::path::append(Path, "___clang_inmemory_preamble___");

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from two minor nits, the check LGTM. Whether we put it in misc or bugprone can be answered by @alexfh or by your best judgement. Comment at:

[PATCH] D39842: Allow to store precompiled preambles in memory.

ilya-biryukov updated this revision to Diff 123171. ilya-biryukov added a comment. - Use a hard-coded virtual path for in-memory PCHs instead of system_temp_directory. https://reviews.llvm.org/D39842 Files: include/clang/Frontend/FrontendActions.h

[PATCH] D40127: [Driver][ARM] For assembler files recognize -Xassembler or -Wa, -mthumb

peter.smith created this revision. Herald added subscribers: kristof.beyls, javed.absar, aemerson. The Unified Arm Assembler Language is designed so that the majority of assembler files can be assembled for both Arm and Thumb with the choice made as a compilation option. The way this is done in

[PATCH] D40062: Update tests for llvm.invariant.group.barrier becoming mangled

Prazek accepted this revision. Prazek added a comment. LGTM https://reviews.llvm.org/D40062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39842: Allow to store precompiled preambles in memory.

klimek added inline comments. Comment at: lib/Frontend/PrecompiledPreamble.cpp:44 +SmallString<64> Path; +llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/true, Path); +llvm::sys::path::append(Path, "___clang_inmemory_preamble___");

[PATCH] D40120: [clang-format] Add text proto filename detection

klimek added a comment. Should that be configured? METADATA seems pretty domain specific ;) https://reviews.llvm.org/D40120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39842: Allow to store precompiled preambles in memory.

klimek added inline comments. Comment at: lib/Frontend/PrecompiledPreamble.cpp:44 +SmallString<64> Path; +llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/true, Path); +llvm::sys::path::append(Path, "___clang_inmemory_preamble___");

[PATCH] D39842: Allow to store precompiled preambles in memory.

ilya-biryukov added inline comments. Comment at: lib/Frontend/PrecompiledPreamble.cpp:44 +SmallString<64> Path; +llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/true, Path); +llvm::sys::path::append(Path, "___clang_inmemory_preamble___");

[PATCH] D39842: Allow to store precompiled preambles in memory.

ilya-biryukov added inline comments. Comment at: lib/Frontend/PrecompiledPreamble.cpp:44 +SmallString<64> Path; +llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/true, Path); +llvm::sys::path::append(Path, "___clang_inmemory_preamble___");

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik added a comment. Ping, please review :) https://reviews.llvm.org/D39903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r318435 - Resubmit "Refactor debuginfo-tests"

Author: zturner Date: Thu Nov 16 10:26:20 2017 New Revision: 318435 URL: http://llvm.org/viewvc/llvm-project?rev=318435=rev Log: Resubmit "Refactor debuginfo-tests" This was reverted due to some failures on specific darwin buildbots, the issue being that the new lit configuration was not setting

r318434 - [OPENMP] Add support for cancelling inside target parallel for

Author: abataev Date: Thu Nov 16 10:20:21 2017 New Revision: 318434 URL: http://llvm.org/viewvc/llvm-project?rev=318434=rev Log: [OPENMP] Add support for cancelling inside target parallel for directive. Added missed support for cancelling of target parallel for construct. Modified:

[PATCH] D40141: [ObjC][ARC] Honor noescape attribute for -Warc-retain-cycles

arphaman created this revision. This patch ensures that -Warc-retain-cycles doesn't warn about captures in blocks that are passed into parameters that have a `noescape` attribute. Repository: rL LLVM https://reviews.llvm.org/D40141 Files: lib/Sema/SemaChecking.cpp

[PATCH] D39347: Fix __has_unique_object_representations based on rsmith's input

erichkeane added a comment. Ping? This fixes a number of bugs with the previous implementation, so I'd like to see if we can get this in. https://reviews.llvm.org/D39347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40140: [VirtualFileSystem] Support creating directories then adding files inside

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Basic/VirtualFileSystem.cpp:535 ResolvedPerms); -Dir->addChild(Name, llvm::make_unique( -

[PATCH] D39918: [libunwind] Remove a FIXME about truncated section names

This revision was automatically updated to reflect the committed changes. Closed by commit rL318446: Remove a FIXME about truncated section names (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D39918?vs=122498=123223#toc Repository: rL LLVM

[libunwind] r318446 - Remove a FIXME about truncated section names

Author: mstorsjo Date: Thu Nov 16 11:36:48 2017 New Revision: 318446 URL: http://llvm.org/viewvc/llvm-project?rev=318446=rev Log: Remove a FIXME about truncated section names If the linker chose to store the full section name instead of truncating it, this field doesn't contain a truncated name,

r318440 - [MS] Apply adjustments after storing 'this'

Author: rnk Date: Thu Nov 16 11:09:36 2017 New Revision: 318440 URL: http://llvm.org/viewvc/llvm-project?rev=318440=rev Log: [MS] Apply adjustments after storing 'this' Summary: The MS ABI convention is that the 'this' pointer on entry is the address of the vfptr that was used to make the

[PATCH] D40109: [MS] Apply adjustments after storing 'this'

This revision was automatically updated to reflect the committed changes. Closed by commit rL318440: [MS] Apply adjustments after storing 'this' (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D40109?vs=123104=123218#toc Repository: rL LLVM

[PATCH] D40140: [VirtualFileSystem] Support creating directories then adding files inside

This revision was automatically updated to reflect the committed changes. Closed by commit rL318445: [VirtualFileSystem] Support creating directories then adding files inside (authored by benhamilton). Repository: rL LLVM https://reviews.llvm.org/D40140 Files:

[PATCH] D39438: [analyzer] Diagnose stack leaks via block captures

alexshap added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D39438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r318445 - [VirtualFileSystem] Support creating directories then adding files inside

Author: benhamilton Date: Thu Nov 16 11:34:08 2017 New Revision: 318445 URL: http://llvm.org/viewvc/llvm-project?rev=318445=rev Log: [VirtualFileSystem] Support creating directories then adding files inside Summary: In https://reviews.llvm.org/D39572 , I added support for specifying `Type` when

[PATCH] D40144: Implement `std::launder`

efriedma added inline comments. Comment at: include/new:174 +_LIBCPP_NODISCARD_AFTER_CXX17 inline _LIBCPP_INLINE_VISIBILITY +constexpr _Tp* launder(_Tp* __p) noexcept { return __p;} +#endif How is the compiler supposed to know that "std::__1::launder()" has

[PATCH] D40109: [MS] Apply adjustments after storing 'this'

rnk added a comment. In https://reviews.llvm.org/D40109#926975, @rnk wrote: > This seems to cause a crash on startup in some gtest binaries when I > self-host, so I guess I should debug that tomorrow before committing. The > rest of clang's tests pass. I guess we don't use virtual inheritance.

[PATCH] D40142: [cmake] Use llvm-lit directory when provided for stand-alone build

mgorny created this revision. After the recent lit test changes, clang attempts to run its tests via llvm-lit by default. However, the llvm-lit binary is not present when performing stand-alone build resulting in a failure out of the box. To solve that, add the llvm-lit directory to CMake when

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

cameron314 marked an inline comment as done. cameron314 added a comment. - Well that's odd, because the test definitely fails for me without the patch. I'm only a few days behind the trunk. - I'm looking at your test case now. I can reproduce it even with the patch; I'm investigating what's

[libcxx] r318432 - Mark free functions size/empty/data conditionally noexcept.

Author: marshall Date: Thu Nov 16 09:55:41 2017 New Revision: 318432 URL: http://llvm.org/viewvc/llvm-project?rev=318432=rev Log: Mark free functions size/empty/data conditionally noexcept. Modified: libcxx/trunk/include/iterator Modified: libcxx/trunk/include/iterator URL:

[PATCH] D39918: [libunwind] Remove a FIXME about truncated section names

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Yep, no need for this. https://reviews.llvm.org/D39918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40144: Implement `std::launder`

mclow.lists created this revision. `std::launder` was introduced into c++17 as a compiler optimization barrier. It's something that the compiler 'knows about', and affects codegen. See https://wg21.link/p0137r1 for more. https://reviews.llvm.org/D40144 Files: include/new

[PATCH] D40144: Implement `std::launder`

Quuxplusone added inline comments. Comment at: test/std/language.support/support.dynamic/ptr.launder/launder.fail.cpp:26 +int *p = nullptr; +std::launder(p); // expected-error {{ignoring return value of function declared with 'nodiscard' attribute}} +}

[PATCH] D39963: [RISCV][RFC] Add initial RISC-V target and driver support

asb marked 4 inline comments as done. asb added inline comments. Comment at: lib/Driver/ToolChains/RISCV.cpp:86 +CmdArgs.push_back("-lc"); +CmdArgs.push_back("-lgloss"); +CmdArgs.push_back("--end-group"); asb wrote: > apazos wrote: > > mgrang wrote:

[PATCH] D40144: Implement `std::launder`

efriedma added inline comments. Comment at: include/new:174 +_LIBCPP_NODISCARD_AFTER_CXX17 inline _LIBCPP_INLINE_VISIBILITY +constexpr _Tp* launder(_Tp* __p) noexcept { return __p;} +#endif efriedma wrote: > How is the compiler supposed to know that

[PATCH] D40140: [VirtualFileSystem] Support creating directories then adding files inside

benhamilton updated this revision to Diff 123221. benhamilton added a comment. - Fix style. https://reviews.llvm.org/D40140 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp unittests/Basic/VirtualFileSystemTest.cpp Index:

[PATCH] D39588: Distro: initial support for alpine

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D39588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r318456 - Issue -Wempty-body warnings for else blocks

This is kicking up false positives on code that does the following: #define USED(x) if(x);else // ... assert(x); USED(x); It's a bit of a weird pattern, but it occurs in some open-source code and seems easy enough for us to detect (if the semicolon and the preceding token aren't from the same

[PATCH] D39050: Add index-while-building support to Clang

akyrtzi added a comment. > To be honest, I want this functionality to get in as much as you do, and I'm > more than happy to prioritize the code review for it :) But the current patch > size makes the reviewing really hard (e.g. I would never have caught the > BLOCK issues hadn't I tried

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

cameron314 added a comment. Well, it seems like preamble PCH source location translation is fundamentally broken. The entry file has a single, positive file ID. The preamble PCH is treated as an imported module, so it has a negative file ID for the part that overlaps the preamble of the entry

[PATCH] D38216: [C++17] Fix class template argument deduction for default constructors without an initializer

rsmith added a comment. In https://reviews.llvm.org/D38216#924039, @lichray wrote: > So gcc got this wrong? > > https://wandbox.org/permlink/RVApvaca1ebUfInn Yes, the declaration `extern A a;` in that example is ill-formed. https://reviews.llvm.org/D38216

[PATCH] D40151: [CUDA] [test-suite] Remove references to nexttoward in CUDA tests.

jlebar created this revision. Herald added a subscriber: sanjoy. This function never worked -- the only reason the tests passed is because calls to this function were being DCE'ed. We're going to remove this broken function from clang, but first we need to remove it from the test-suite.

[PATCH] D40144: Implement `std::launder`

rsmith added a comment. In https://reviews.llvm.org/D40144#927866, @hfinkel wrote: > In https://reviews.llvm.org/D40144#927828, @tcanens wrote: > > > At least for GCC, it should use `__builtin_launder`. > > > I presume we'll need to add something similar for Clang as well. Yes, we agreed to

Re: [cfe-commits] r124613 - /cfe/trunk/lib/Frontend/FrontendActions.cpp

Daniel Dunbar writes: > Author: ddunbar > Date: Mon Jan 31 16:00:44 2011 > New Revision: 124613 > > URL: http://llvm.org/viewvc/llvm-project?rev=124613=rev > Log: > libclang: Don't allow RemoveFileOnSignal to be called via libclang, badness > can > ensue. Sorry for digging

[PATCH] D40152: [CUDA] Remove implementations of nexttoward.

jlebar created this revision. __builtin_nexttoward lowers to a libcall, e.g. nexttowardf(), that CUDA does not have. Rather than try to implement it, we simply remove these functions -- nvcc doesn't support them either, and nextafter, which does work, does essentially the same thing on GPUs,

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 123231. juliehockett marked an inline comment as done. juliehockett edited the summary of this revision. https://reviews.llvm.org/D40108 Files: clang-tidy/CMakeLists.txt clang-tidy/fuchsia/CMakeLists.txt

[PATCH] D39963: [RISCV][RFC] Add initial RISC-V target and driver support

mgrang added inline comments. Comment at: lib/Driver/ToolChains/Gnu.cpp:1823 + "riscv64-unknown-linux-gnu", + "riscv32-unknown-elf"}; + I suppose we need riscv64-unknown-elf

r318507 - Change path used in a test from r318503 to work on windows

Author: bruno Date: Thu Nov 16 20:26:07 2017 New Revision: 318507 URL: http://llvm.org/viewvc/llvm-project?rev=318507=rev Log: Change path used in a test from r318503 to work on windows http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13565 Modified:

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

sdardis added a comment. @compnerd, ping? https://reviews.llvm.org/D38110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40120: [clang-format] Add text proto filename detection

krasimir created this revision. Adds text proto filename detection. https://reviews.llvm.org/D40120 Files: lib/Format/Format.cpp Index: lib/Format/Format.cpp === --- lib/Format/Format.cpp +++ lib/Format/Format.cpp @@ -2084,6

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

aaron.ballman added a comment. For background: what is Fuchsia and where do these requirements come from (are they documented publicly somewhere)? We tend to prefer concise patches over code dumps, so I think it would make sense to split this review into multiple patches. The first one can be

[PATCH] D39963: [RISCV][RFC] Add initial RISC-V target and driver support

asb updated this revision to Diff 123229. asb marked an inline comment as done. asb added a comment. Consider this a WIP update. This is not yet ready for merging, but could still benefit from feedback. This update adds support for RISC-V to the Linux toolchain driver, which includes support

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 + Prevent use of default arguments in declared or called functions in Fuchsia. + Check name and link was accidentally removed. Comment at:

[PATCH] D40144: Implement `std::launder`

hfinkel added a comment. In https://reviews.llvm.org/D40144#927828, @tcanens wrote: > At least for GCC, it should use `__builtin_launder`. I presume we'll need to add something similar for Clang as well. > Also needs to implement "The program is ill-formed if `T` is a function type > or

Re: [libcxx] r313643 - Resubmit "Fix llvm-lit script generation in libcxx."

Hi Zachery: I'm seeing a breakage when cross-compiling and including libcxx in the runtimes directory. The problem is that `include(AddLLVM)`, guarded by LIBCXX_INCLUDE_TESTS, comes after your change to call `configure_lit_site_cfg`. I've fixed this locally by adding `include(AddLLVM)` to the

r318456 - Issue -Wempty-body warnings for else blocks

Author: rnk Date: Thu Nov 16 13:26:18 2017 New Revision: 318456 URL: http://llvm.org/viewvc/llvm-project?rev=318456=rev Log: Issue -Wempty-body warnings for else blocks This looks like it was just an oversight. Fixes http://llvm.org/pr35319 Modified:

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

yaxunl added inline comments. Comment at: cfe/trunk/lib/Basic/TargetInfo.cpp:351 +LangAS::ID TargetInfo::getOpenCLTypeAddrSpace(const Type *T) const { + auto BT = dyn_cast(T); rsmith wrote: > Anastasia wrote: > > chapuni wrote: > > > Excuse me for old commit,

Re: [PATCH] D33989: [OpenCL] Allow targets to select address space per type

Ping on this layering violation. A simple way to demonstrate this is to move the definition of clang::Type::getTypeClass out of line: This results in an unresolved symbol due to incorrect/broken dependencies. Richard? Anyone else? Ideas on how to address this layering violation? Anastasia: Could

[PATCH] D39050: Add index-while-building support to Clang

ioeric added a comment. In https://reviews.llvm.org/D39050#922597, @akyrtzi wrote: > Hey Eric, > > In https://reviews.llvm.org/D39050#921748, @ioeric wrote: > > > >> - I think the implementation of the index output logic (e.g. > > >> `IndexUnitWriter` and bit format file) can be abstracted away

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

rsmith added inline comments. Comment at: cfe/trunk/lib/Basic/TargetInfo.cpp:351 +LangAS::ID TargetInfo::getOpenCLTypeAddrSpace(const Type *T) const { + auto BT = dyn_cast(T); Anastasia wrote: > chapuni wrote: > > Excuse me for old commit, I think it might be

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

cameron314 added a comment. Alright, with my patch the `c-index-test` *does* correctly serialize and restore the skipped ranges; the problem is that it searches for only ranges matching the target file. When there's a preamble, it's seen as a different file than the main file, even though

[PATCH] D40144: Implement `std::launder`

tcanens added a comment. At least for GCC, it should use `__builtin_launder`. Also needs to implement "The program is ill-formed if `T` is a function type or //cv// `void`." https://reviews.llvm.org/D40144 ___ cfe-commits mailing list

[PATCH] D39963: [RISCV][RFC] Add initial RISC-V target and driver support

mgrang added inline comments. Comment at: test/Driver/riscv64-toolchain.c:1 +// A basic clang -cc1 command-line, and simple environment check. + mgrang wrote: > I just saw that this test fails with the error: > > error: backend data layout

[PATCH] D40115: Driver: remove `SupportsObjCGC`

rjmccall added a comment. This isn't changing the actual driver interface in any way, it's just dead-code removal. Seems fine to me. Repository: rL LLVM https://reviews.llvm.org/D40115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r318474 - PR22763: if a defaulted (non-user-provided) special member function is

Author: rsmith Date: Thu Nov 16 15:54:56 2017 New Revision: 318474 URL: http://llvm.org/viewvc/llvm-project?rev=318474=rev Log: PR22763: if a defaulted (non-user-provided) special member function is explicitly instantiated, still emit it with each use. We don't emit a definition of the member

[PATCH] D40023: [RISCV] Implement ABI lowering

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:1937 +RetAttrs.addAttribute(llvm::Attribute::ZExt); +} // FALL THROUGH I feel like a better design would be to record whether to do a sext or a zext in the ABIArgInfo. Add

[PATCH] D40152: [CUDA] Remove implementations of nexttoward.

This revision was automatically updated to reflect the committed changes. Closed by commit rL318494: [CUDA] Remove implementations of nexttoward. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D40152?vs=123257=123275#toc Repository: rL LLVM

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett updated this revision to Diff 123278. juliehockett edited the summary of this revision. juliehockett added a comment. Updated docs https://reviews.llvm.org/D40108 Files: clang-tidy/CMakeLists.txt clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/DefaultArgumentsCheck.cpp

Re: [cfe-commits] r124613 - /cfe/trunk/lib/Frontend/FrontendActions.cpp

IIRC, and I can hardly guarantee I do, the issue is that libclang installing signal handlers doesn’t play well with the arbitrary applications which can be linking libclang. - Daniel On Thu, Nov 16, 2017 at 3:26 PM Rafael Avila de Espindola < rafael.espind...@gmail.com> wrote: > Daniel Dunbar

r318486 - Re-revert "Refactor debuginfo-tests"

Author: zturner Date: Thu Nov 16 16:41:18 2017 New Revision: 318486 URL: http://llvm.org/viewvc/llvm-project?rev=318486=rev Log: Re-revert "Refactor debuginfo-tests" This is still broken because it causes certain tests to be run twice with slightly different configurations, which is wrong in

r318491 - Update for layering fix in LLVM CodeGen<>Target

Author: dblaikie Date: Thu Nov 16 17:07:20 2017 New Revision: 318491 URL: http://llvm.org/viewvc/llvm-project?rev=318491=rev Log: Update for layering fix in LLVM CodeGen<>Target Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp URL:

[PATCH] D40151: [CUDA] [test-suite] Remove references to nexttoward in CUDA tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rL318492: [CUDA] [test-suite] Remove references to nexttoward in CUDA tests. (authored by jlebar). Repository: rL LLVM https://reviews.llvm.org/D40151 Files: test-suite/trunk/External/CUDA/cmath.cu

r318494 - [CUDA] Remove implementations of nexttoward.

Author: jlebar Date: Thu Nov 16 17:15:43 2017 New Revision: 318494 URL: http://llvm.org/viewvc/llvm-project?rev=318494=rev Log: [CUDA] Remove implementations of nexttoward. Summary: __builtin_nexttoward lowers to a libcall, e.g. nexttowardf(), that CUDA does not have. Rather than try to

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

Eugene.Zelenko added a comment. In https://reviews.llvm.org/D40108#928212, @juliehockett wrote: > We do need to figure out what the right prefix for these checks is (whether > fuchsia-* since they'll be used under the Fuchsia umbrella, zircon-* since > the follow the Zircon section of the

[PATCH] D39050: Add index-while-building support to Clang

ioeric added a comment. >> If the index action is already flexible enough, would you mind splitting the >> code for the index action out so that we can start reviewing it? Given that >> the current patch has very few tests, I guess it wouldn't be too much worse >> to split out the action

[PATCH] D40141: [ObjC][ARC] Honor noescape attribute for -Warc-retain-cycles

rjmccall added inline comments. Comment at: lib/Sema/SemaChecking.cpp:11661 if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) return diagnoseRetainCycle(*this, capturer, owner); + } Failing to find a capturing expression will

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

juliehockett marked 2 inline comments as done. juliehockett added a comment. We do need to figure out what the right prefix for these checks is (whether fuchsia-* since they'll be used under the Fuchsia umbrella, zircon-* since the follow the Zircon section of the style guide linked above, or

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

Eugene.Zelenko added a comment. Does Fuchsia coding conventions allows default parameters in class methods? If not, test should reflect this Comment at: docs/ReleaseNotes.rst:63 + + Prevent use of default arguments in declared or called functions in Fuchsia. +

[PATCH] D40068: Implement more accurate penalty & trade-offs while breaking protruding tokens.

klimek added inline comments. Comment at: unittests/Format/FormatTest.cpp:8007 +"\"aaabbbcc ddde \"\n" +"\"efff\");", format("someFunction(\"aaabbbcc ddde efff\");", krasimir wrote: > Why did the string got on a

[PATCH] D40068: Implement more accurate penalty & trade-offs while breaking protruding tokens.

klimek updated this revision to Diff 123139. klimek marked 4 inline comments as done. klimek added a comment. Address review comments. https://reviews.llvm.org/D40068 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp

[PATCH] D39049: [analyzer] Fix wrong calculation of offset in ArrayBoundsV2

xazax.hun added a comment. In https://reviews.llvm.org/D39049#926597, @danielmarjamaki wrote: > > Could you do a similar analysis that I did above to check why does this not > > work for the multidimensional case? (I.e.: checking what constraints are > > generated and what the analyzer does

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

nik added a comment. Here are my observations: - Your test case works fine for me even without having this change applied/build. Looks like this is already fixed in current trunk. Please confirm/test. - Can you come up with another test case that fixes something that is not yet addressed in

r318503 - [PCH+Modules] Improve diagnosticts to help out users pass an extra header search path

Author: bruno Date: Thu Nov 16 19:24:11 2017 New Revision: 318503 URL: http://llvm.org/viewvc/llvm-project?rev=318503=rev Log: [PCH+Modules] Improve diagnosticts to help out users pass an extra header search path When mixing PCH and Implicit Modules, missing a header search path can lead to the

  1   2   >