[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D39947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] Ensure std::getline always 0-terminates string.

On Nov 19, 2017, at 08:07, Reimar Döffinger wrote: > > On Wed, Nov 15, 2017 at 11:35:56AM -0800, Volodymyr Sapsai wrote: >> On Nov 12, 2017, at 12:37, Reimar Döffinger wrote: >> libc++ can be built with exceptions enabled or disabled (see >>

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

mgrang added a comment. Ping for reviews please. Repository: rL LLVM https://reviews.llvm.org/D39947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40234: [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering

This revision was automatically updated to reflect the committed changes. Closed by commit rL318681: [AutoComplete] Use stronger sort predicate for autocomplete candidates to… (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D40234?vs=123546=123623#toc Repository: rL

r318681 - [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering

Author: mgrang Date: Mon Nov 20 10:49:14 2017 New Revision: 318681 URL: http://llvm.org/viewvc/llvm-project?rev=318681=rev Log: [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering Summary: This fixes the failure in

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

tra added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:5341-5344 +if (const auto *OA = dyn_cast(JA.getInputs()[I])) { + OA->doOnEachDependence( + [&](Action *, const ToolChain *TC, const char *) { CurTC = TC; }); +} Can we

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:431 -SmallString<256> Name(II.getFilename()); -llvm::sys::path::replace_extension(Name, "cubin"); - -const char *CubinF = -C.addTempFile(C.getArgs().MakeArgString(Name)); +const

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

K-ballo created this revision. Implement LWG2993, `reference_wrapper` conversion from `T&&`. The conversion fail test currently fails to fail (passes), due to https://bugs.llvm.org/show_bug.cgi?id=35332. Flagging it `XFAIL` does not seem to have any effect. https://reviews.llvm.org/D40259

r318672 - [Docs] Regenerate the command line option reference.

Author: ctopper Date: Mon Nov 20 10:07:43 2017 New Revision: 318672 URL: http://llvm.org/viewvc/llvm-project?rev=318672=rev Log: [Docs] Regenerate the command line option reference. Modified: cfe/trunk/docs/ClangCommandLineReference.rst Modified: cfe/trunk/docs/ClangCommandLineReference.rst

[clang-tools-extra] r318670 - [clang-tidy] revert hicpp-multiway-paths-covered

Author: jonastoth Date: Mon Nov 20 10:01:35 2017 New Revision: 318670 URL: http://llvm.org/viewvc/llvm-project?rev=318670=rev Log: [clang-tidy] revert hicpp-multiway-paths-covered The address sanitizer found a stackoverflow with this patch. There is no obvious fix. This patch will be reapplied

[PATCH] D40230: Add -mprefer-vector-width driver option and attribute during CodeGen.

craig.topper updated this revision to Diff 123614. craig.topper added a comment. Address comments. The value of 'none' is intended to cancel out any other option specified. I've changed it so that we no longer pass 'none' to llvm and instead suppress the attribute.

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

This revision was automatically updated to reflect the committed changes. Closed by commit rL318669: For Linux/gnu compatibility, preinclude if the file is available (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D34158?vs=120581=123613#toc Repository: rL LLVM

[PATCH] D34624: extra test modifications for D34158

This revision was automatically updated to reflect the committed changes. Closed by commit rL318668: extra test modifications for D34158 (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D34624?vs=120584=123612#toc Repository: rL LLVM

r318669 - For Linux/gnu compatibility, preinclude if the file is available

Author: erichkeane Date: Mon Nov 20 09:57:42 2017 New Revision: 318669 URL: http://llvm.org/viewvc/llvm-project?rev=318669=rev Log: For Linux/gnu compatibility, preinclude if the file is available As reported in llvm bugzilla 32377. Here’s a patch to add preinclude of stdc-predef.h. The gcc

[clang-tools-extra] r318668 - extra test modifications for D34158

Author: erichkeane Date: Mon Nov 20 09:57:20 2017 New Revision: 318668 URL: http://llvm.org/viewvc/llvm-project?rev=318668=rev Log: extra test modifications for D34158 When adding support for D34158 which changes preprocessed output, I needed to make tiny test corrections for these. Adding the

Re: r318456 - Issue -Wempty-body warnings for else blocks

Reverted in r318667. See coments on the r318556 thread. On Thu, Nov 16, 2017 at 3:32 PM, Richard Smith via cfe-commits wrote: > This is kicking up false positives on code that does the following: > > #define USED(x) if(x);else > // ... > assert(x); > USED(x); > >

Re: r318556 - Loosen -Wempty-body warning

Reverted the original patch too, in r318667 since I assume that was breaking Ilya's build. Hopefully this is easy to fix and they can be re-landed together. On Mon, Nov 20, 2017 at 9:39 AM, Hans Wennborg wrote: > I've reverted in r318665 to get the buildbots green until this

r318667 - Revert r318456 "Issue -Wempty-body warnings for else blocks"

Author: hans Date: Mon Nov 20 09:48:54 2017 New Revision: 318667 URL: http://llvm.org/viewvc/llvm-project?rev=318667=rev Log: Revert r318456 "Issue -Wempty-body warnings for else blocks" This caused warnings also when the if or else comes from macros. There was an attempt to fix this in r318556,

[PATCH] D39114: [XRay][darwin] Initial XRay in Darwin Support

kubamracek added a comment. And we should probably introduce files named `xray_linux.cc` and `xray_mac.cc` to contain platform-specific functions. https://reviews.llvm.org/D39114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r318556 - Loosen -Wempty-body warning

I've reverted in r318665 to get the buildbots green until this is figured out. On Sat, Nov 18, 2017 at 11:55 AM, Hans Wennborg wrote: > We're still seeing some in macro-related code. From Chromium: > > ../../third_party/ffmpeg/libavcodec/bitstream.c(169,5): error: if >

r318665 - Revert r318556 "Loosen -Wempty-body warning"

Author: hans Date: Mon Nov 20 09:38:16 2017 New Revision: 318665 URL: http://llvm.org/viewvc/llvm-project?rev=318665=rev Log: Revert r318556 "Loosen -Wempty-body warning" It seems this somehow made -Wempty-body fire in some macro cases where it didn't before, e.g.

[PATCH] D40073: [Analyzer] Non-determinism: don't sort indirect goto LabelDecl's by addresses

a.sidorin added a comment. Thank you, Devin! Ilya doesn't have commit access so please commit the patch (or leave it for me, I'm going to commit some patches tomorrow). By the way, is there a common way to write tests for non-determinism for LLVM test suite? https://reviews.llvm.org/D40073

Re: [clang-tools-extra] r318600 - [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches

Hi, We are seeing a bot failure with this commit. Please see the bot page here: http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/5470/consoleFull#17462642768254eaf0-7326-4999-85b0-388101f2d404 Please let me know if you will be able to provide a patch for this in the next couple of

[PATCH] D39114: [XRay][darwin] Initial XRay in Darwin Support

kubamracek added a comment. Hi, can you split the patch and send individual changes as separate patches? It's getting hard to follow. And I think we should land the parts that are "safe to land", e.g. the ASM changes or some of the NFC whitespace changes. The Darwin-specific changes in tests

[PATCH] D40226: [CodeGen] Move Reciprocals option from TargetOptions to CodeGenOptions

craig.topper closed this revision. craig.topper added a comment. Committed in r318662, but I botched the "Differential Revision" in the commit message. https://reviews.llvm.org/D40226 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40073: [Analyzer] Non-determinism: don't sort indirect goto LabelDecl's by addresses

dcoughlin added a comment. Thanks! Do you have commit access, or do you need someone to commit this for you? https://reviews.llvm.org/D40073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r318662 - [CodeGen] Move Reciprocals option from TargetOptions to CodeGenOptions

Author: ctopper Date: Mon Nov 20 09:09:22 2017 New Revision: 318662 URL: http://llvm.org/viewvc/llvm-project?rev=318662=rev Log: [CodeGen] Move Reciprocals option from TargetOptions to CodeGenOptions Diffrential Revision: https://reviews.llvm.org/D40226 Modified:

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

Hahnfeld marked 2 inline comments as done. Hahnfeld added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:431 -SmallString<256> Name(II.getFilename()); -llvm::sys::path::replace_extension(Name, "cubin"); - -const char *CubinF = -

[PATCH] D40258: [CMake] Support side-by-side checkouts in multi-stage build

phosek created this revision. Herald added a subscriber: mgorny. Passthrough LLVM_ENABLE_{PROJECTS,RUNTIMES} to followup stages to support the side-by-side checkouts (aka monorepo layout). Repository: rL LLVM https://reviews.llvm.org/D40258 Files: CMakeLists.txt Index: CMakeLists.txt

[PATCH] D40257: [CMake] Use LIST_SEPARATOR rather than escaping in ExternalProject_Add

phosek created this revision. Herald added a subscriber: mgorny. Escaping ; in list arguments passed to ExternalProject_Add doesn't seem to be working in newer versions of CMake (see https://public.kitware.com/Bug/view.php?id=16137 for more details). Use a custom LIST_SEPARATOR instead which is

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:431 -SmallString<256> Name(II.getFilename()); -llvm::sys::path::replace_extension(Name, "cubin"); - -const char *CubinF = -C.addTempFile(C.getArgs().MakeArgString(Name)); +const

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

keith.walker.arm created this revision. Herald added subscribers: kristof.beyls, javed.absar, aemerson. To be compatible with GCC if soft floating point is in effect any FPU specified is effectively ignored, eg, -mfloat-abi=soft -fpu=neon If any floating point features which require FPU

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

Hahnfeld marked 2 inline comments as done. Hahnfeld added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:431 -SmallString<256> Name(II.getFilename()); -llvm::sys::path::replace_extension(Name, "cubin"); - -const char *CubinF = -

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:5340 + +const ToolChain *CurTC = (); +if (const auto *OA = dyn_cast(JA.getInputs()[I])) { Please add a comment here describing what this entire code snippet is doing.

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

cameron314 added a comment. In https://reviews.llvm.org/D20124#928552, @ilya-biryukov wrote: > Why do we store raw source locations in `PPSkippedRange`? Would storing > `SourceLocation` and using `ASTWriter::AddSourceLocation` and `ASTReader:: > ReadSourceLocation` do the trick? I followed

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

Hahnfeld created this revision. This was previously done in some places, but for example not for bundling so that single object compilation with -c failed. In addition cubin was used for all file types during unbundling which is incorrect for assembly files that are passed to ptxas. Tighten up

[PATCH] D39834: [clang] -foptimization-record-file= should imply -fsave-optimization-record

JDevlieghere added a comment. I think you can achieve the same result with less code by checking for the flag's presence higher up, where currently `OPT_fsave_optimization_record` is handled (Clang.cpp:4329). Something like: if (Args.hasFlag(options::OPT_fsave_optimization_record,

[PATCH] D39834: [clang] -foptimization-record-file= should imply -fsave-optimization-record

JDevlieghere added a comment. This also ensures that if `fno_save_optimization_record` is specified, you don't overwrite it by setting the file. This is definitely something you'd want to add to your test case. https://reviews.llvm.org/D39834 ___

[PATCH] D39438: [analyzer] Diagnose stack leaks via block captures

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks, looks great, please commit!~ Repository: rL LLVM https://reviews.llvm.org/D39438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

Hahnfeld added a comment. A different approach would be to completely replace the type in `Driver::ConstructPhaseAction` but 1. this was previously considered a too radical change, 2. we currently don't have the necessary information (ToolChain, OffloadKind) to take that decision, 3. this

Re: Clang-format: add finer-grained options for putting all arguments on one line.

Hi - Just pinging this after a week; let me know if there's a better way to submit patches, I'm a first time contributor. On Mon, Nov 13, 2017 at 6:55 PM, Russell McClellan wrote: > Attached is a patch that adds two new options, > AllowAllArgumentsOnNextLine and >

[PATCH] D39834: [clangd] -foptimization-record-file= should imply -fsave-optimization-record

Quolyk added a comment. In https://reviews.llvm.org/D39834#930165, @malaperle wrote: > Hi! You put "[clangd]" in the title, but I don't believe it's related to > clangd but rather just "clang"? I thought patch to clang option is supposed to be marked as "clangd".

[PATCH] D38976: [OpenMP] Add implicit data sharing support when offloading to NVIDIA GPUs using OpenMP device offloading

ABataev accepted this revision. ABataev added a comment. LG Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:474 CodeGenFunction CGF(CGM, /*suppressNewContext=*/true); CGF.disableDebugInfo(); CGF.StartFunction(GlobalDecl(), Ctx.VoidTy, WST.WorkerFn, *WST.CGFI, {});

[PATCH] D39857: [AMDGPU] Late parsed / dependent arguments for AMDGPU kernel attributes

AlexVlx updated this revision to Diff 123577. AlexVlx added a comment. Apologies for the delayed update. The new version tries to deal with two issues: 1. the non-compliant style identified by Aaron in various spots, hopefully this is correct now; 2. there was an issue with the existing logic,

[PATCH] D40242: Do not perform the analysis based warning if all warnings are ignored

ogoffart marked an inline comment as done. ogoffart added inline comments. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:2084 + // Do not do any analysis if we are going to just ignore them. + if (Diags.getIgnoreAllWarnings() || + (Diags.getSuppressSystemWarnings() &&

[PATCH] D40226: [CodeGen] Move Reciprocals option from TargetOptions to CodeGenOptions

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D40226 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38425: [clangd] Document highlights for clangd

malaperle added a comment. Hi William, can you quickly go over the diff before I do a review? There are a few more-obvious things that can be addressed, i.e. commented lines, extra new/deleted lines, temporary code, lower case variable names, etc. https://reviews.llvm.org/D38425

[PATCH] D40230: Add -mprefer-vector-width driver option and attribute during CodeGen.

spatel added a reviewer: hfinkel. spatel added inline comments. Comment at: include/clang/Frontend/CodeGenOptions.h:254 + /// The prefered vector width. + std::string PreferVectorWidth; typo - 'preferred'. Should add a bit more to the explanation. "The

[PATCH] D39834: [clangd] -foptimization-record-file= should imply -fsave-optimization-record

malaperle added a comment. Hi! You put "[clangd]" in the title, but I don't believe it's related to clangd but rather just "clang"? https://reviews.llvm.org/D39834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r318648 - [ARM] For assembler files recognize -Xassembler or -Wa, -mthumb

Author: psmith Date: Mon Nov 20 05:53:55 2017 New Revision: 318648 URL: http://llvm.org/viewvc/llvm-project?rev=318648=rev Log: [ARM] For assembler files recognize -Xassembler or -Wa, -mthumb Attempt to fix warning picked up by buildbot. Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp

[PATCH] D40127: [Driver][ARM] For assembler files recognize -Xassembler or -Wa, -mthumb

peter.smith added a comment. In https://reviews.llvm.org/D40127#929578, @compnerd wrote: > Would be nice to rename the variable prior to commit. Thanks for the review, I've renamed the variable as suggested. https://reviews.llvm.org/D40127 ___

r318647 - [ARM] For assembler files recognize -Xassembler or -Wa, -mthumb

Author: psmith Date: Mon Nov 20 05:43:55 2017 New Revision: 318647 URL: http://llvm.org/viewvc/llvm-project?rev=318647=rev Log: [ARM] For assembler files recognize -Xassembler or -Wa, -mthumb The Unified Arm Assembler Language is designed so that the majority of assembler files can be assembled

[PATCH] D40127: [Driver][ARM] For assembler files recognize -Xassembler or -Wa, -mthumb

This revision was automatically updated to reflect the committed changes. Closed by commit rL318647: [ARM] For assembler files recognize -Xassembler or -Wa, -mthumb (authored by psmith). Changed prior to commit: https://reviews.llvm.org/D40127?vs=123310=123571#toc Repository: rL LLVM

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

tstellar added inline comments. Comment at: lib/Driver/ToolChains/Gnu.cpp:1840 +// Yet, still look for RHEL devtoolsets +// (should it be done Linux-only??) +Prefixes.push_back("/opt/rh/devtoolset-6/root/usr"); fedor.sergeev wrote: > aaron.ballman

[PATCH] D39953: [CodeGen] Generate TBAA type descriptors in a more reliable manner

kosarev added a comment. In https://reviews.llvm.org/D39953#929144, @rjmccall wrote: > I think there might be some cases that intentionally don't cache their normal > result, though, so it might be harder than you think. My understanding is that conceptually every canonical type has a single

[PATCH] D39953: [CodeGen] Generate TBAA type descriptors in a more reliable manner

kosarev updated this revision to Diff 123563. kosarev retitled this revision from "[CodeGen] Do not lookup for cached TBAA metadata nodes twice" to "[CodeGen] Generate TBAA type descriptors in a more reliable manner". kosarev edited the summary of this revision. kosarev added a comment.

[PATCH] D40242: Do not perform the analysis based warning if all warnings are ignored

lebedev.ri added a comment. In https://reviews.llvm.org/D40242#930125, @ogoffart wrote: > I do not know how to add a test: there is no real visible change for clang. > It just should be faster when passing "-w". Oh right, i was thinking of something else there. Comment at:

[PATCH] D38445: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob

coby added a comment. Reid, can you please have a look? Repository: rL LLVM https://reviews.llvm.org/D38445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37903: Fix assume-filename handling in clang-format.el

phi added a comment. The patch doesn't apply any more to upstream head: $ arc patch D37903 patching file tools/clang-format/clang-format.el Hunk #1 FAILED at 122. Hunk #2 FAILED at 193. Could you please rebase it? https://reviews.llvm.org/D37903

[PATCH] D40242: Do not perform the analysis based warning if all warnings are ignored

ogoffart added a comment. I do not know how to add a test: there is no real visible change for clang. It just should be faster when passing "-w". https://reviews.llvm.org/D40242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40242: Do not perform the analysis based warning if all warnings are ignored

lebedev.ri added a comment. You probably want to add a test for this. https://reviews.llvm.org/D40242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37903: Fix assume-filename handling in clang-format.el

phi added a comment. Hi, do you need anything more from us? This patch looks fine and can be submitted. https://reviews.llvm.org/D37903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40242: Do not perform the analysis based warning if all warnings are ignored

ogoffart created this revision. Do not perform the analysis based warning if all warnings are ignored. This saves some cycles when compiling with "-w". But more importantly, for my tool, this fixes a potential crash which may happen on invalid code. Because the analysis might compute the CFG

[PATCH] D39834: [clangd] -foptimization-record-file= should imply -fsave-optimization-record

Quolyk updated this revision to Diff 123559. https://reviews.llvm.org/D39834 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/opt-record.c Index: test/Driver/opt-record.c === --- test/Driver/opt-record.c +++

[PATCH] D40182: [clangd] Add parsing and value inspection to JSONExpr.

ioeric added a comment. Code looks good. Just some nits. Comment at: clangd/JSONExpr.h:62 +// Array and Object also have typed indexing accessors for easy traversal: +// if (json::obj* Opts = O.array("options")) +// if (Optional Font = Opts->string("font"))

[PATCH] D40073: [Analyzer] Non-determinism: don't sort indirect goto LabelDecl's by addresses

ilya-palachev updated this revision to Diff 123558. ilya-palachev added a comment. Ok, I agree, this test file is rather better. https://reviews.llvm.org/D40073 Files: lib/Analysis/CFG.cpp test/Analysis/cfg-indirect-goto-determinism.cpp Index:

[PATCH] D39955: [Driver] Add a cc1 flag for the new TBAA metadata format

This revision was automatically updated to reflect the committed changes. Closed by commit rL318644: [Driver] Add a cc1 flag for the new TBAA metadata format (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D39955?vs=123320=123555#toc Repository: rL LLVM

r318644 - [Driver] Add a cc1 flag for the new TBAA metadata format

Author: kosarev Date: Mon Nov 20 03:16:16 2017 New Revision: 318644 URL: http://llvm.org/viewvc/llvm-project?rev=318644=rev Log: [Driver] Add a cc1 flag for the new TBAA metadata format This patch starts a series of changes to add support for the new TBAA metadata format proposed in this

[PATCH] D37813: clang-format: better handle namespace macros

Typz added a comment. ping? https://reviews.llvm.org/D37813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33440: clang-format: better handle statement macros

Typz added a comment. ping? https://reviews.llvm.org/D33440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39430: [clangd] formatting: don't ignore style

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.h:289 + llvm::Expected + formatRange(llvm::StringRef Code, PathRef File, Range Rng); + rwols wrote: > rwols wrote: > > ilya-biryukov wrote: > > > rwols wrote: > > > >

[PATCH] D40185: Loosen -Wempty-body warning.

ilya-biryukov added a comment. In https://reviews.llvm.org/D40185#928845, @rnk wrote: > Why does passing the rparen location for the if condition fix the warning for > IF_ELSE? I assumed that would refer to the else clause semicolon. Using spelling locations fixes the `else` case, but breaks

Notice: The buildbot bb.pgr.jp will be suspended within a few days

Due to resource issue, I have to terminate it. As you know, it has been working for several years and I am certain it has been useful and helpful to guys. I am not sure whether I could restart it or not. I loved it. Thank you, Takumi Nakamura ___

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

ro added a comment. What's the status here? This patch is required for my WIP sanitizers-on-Solaris work. https://reviews.llvm.org/D35755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39722: [ASTImporter] Support TypeTraitExpr Importing

a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D39722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40234: [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering

ruiu accepted this revision. ruiu added a comment. LGTM Comment at: lib/Driver/Driver.cpp:1204 +return X < 0; + return A.compare(B) > 0; }); I believe that if you use clang-format, `});` will be put to a separate line like this.

[PATCH] D40234: [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering

mgrang added a comment. In https://reviews.llvm.org/D40234#929943, @ruiu wrote: > Perhaps, this is a bit more straightforward. > > if (int X = A.compare_lower(B)) > return X < 0; > return A.compare(B) < 0; Thanks. Done. https://reviews.llvm.org/D40234

[PATCH] D40234: [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering

mgrang updated this revision to Diff 123546. https://reviews.llvm.org/D40234 Files: lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === --- lib/Driver/Driver.cpp +++ lib/Driver/Driver.cpp @@ -1197,8 +1197,11 @@ //

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

mstorsjo added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:684 +else if (TI.getTriple().isThumb() || TI.getTriple().isARM()) + Builder.defineMacro("__ARM_DWARF_EH__"); + } martell wrote: > mstorsjo wrote: > > Won't this start setting

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

mstorsjo added a comment. In https://reviews.llvm.org/D39673#929536, @martell wrote: > When doing that I noticed there is something really strange about the > existing macro defines. I assume they should only be defined when exceptions > is enabled. > This is by default in c++ mode of with

<    1   2