[PATCH] D40478: Added control flow architecture protection Flag

oren_ben_simhon added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D40478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40381: Parse concept definition

changyu marked 6 inline comments as done. changyu added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7735 + ActOnDocumentableDecl(NewDecl); + CurContext->addDecl(NewDecl); + return NewDecl; faisalv wrote: > Why not use 'PushOnScopeChains' onto the

[PATCH] D41452: [CodeGen] Fix access sizes in new-format TBAA tags

This revision was automatically updated to reflect the committed changes. Closed by commit rL321250: [CodeGen] Fix access sizes in new-format TBAA tags (authored by kosarev, committed by ). Changed prior to commit: https://reviews.llvm.org/D41452?vs=127724=127834#toc Repository: rL LLVM

r321250 - [CodeGen] Fix access sizes in new-format TBAA tags

Author: kosarev Date: Thu Dec 21 00:14:16 2017 New Revision: 321250 URL: http://llvm.org/viewvc/llvm-project?rev=321250=rev Log: [CodeGen] Fix access sizes in new-format TBAA tags The new format requires to specify both the type of the access and its size. This patch fixes setting access sizes

[PATCH] D41391: [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd` extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rL321252: [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd`… (authored by hokein, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41391 Files:

[clang-tools-extra] r321252 - [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd` extension.

Author: hokein Date: Thu Dec 21 00:45:18 2017 New Revision: 321252 URL: http://llvm.org/viewvc/llvm-project?rev=321252=rev Log: [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd` extension. Summary: Previously, we use a separate GitHub repository

[PATCH] D39457: [OPENMP] Current status of OpenMP support.

Hahnfeld added a comment. @hfinkel I think you requested this documentation on the mailing list. Can you take a look if it matches your expectations so we can get this bundled in the 6.0 release? Comment at: docs/OpenMPSupport.rst:17 + +Clang fully supports OpenMP 3.1 + some

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

JonasToth added inline comments. Comment at: docs/clang-tidy/checks/fuchsia-overloaded-operator.rst:17 + +See the features disallowed in Fuchsia at https://fuchsia.googlesource.com/zircon/+/master/docs/cxx.md juliehockett wrote: > JonasToth wrote: > > Could you

[PATCH] D41454: [clangd] Add ClangdUnit diagnostics tests using annotated code.

sammccall updated this revision to Diff 127843. sammccall added a comment. Tighten preprocessor test Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41454 Files: clangd/Protocol.cpp clangd/Protocol.h test/clangd/diagnostics-preamble.test unittests/clangd/CMakeLists.txt

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

ro added a comment. ping Repository: rC Clang https://reviews.llvm.org/D41241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41345: [clangd] Add more symbol information for code completion.

sammccall added inline comments. Comment at: clangd/index/Index.h:122 + + llvm::Optional Detail; + ioeric wrote: > sammccall wrote: > > I think you probably want a raw pointer rather than optional: > > - reduce the size of the struct when it's absent > > -

[PATCH] D41242: [Solaris] Silence -pthread warning on Solaris

ro added a comment. ping Repository: rC Clang https://reviews.llvm.org/D41242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41394: [CodeGen] Support generation of TBAA info in the new format

kosarev updated this revision to Diff 127838. kosarev added a comment. Updated as suggested. https://reviews.llvm.org/D41394 Files: lib/CodeGen/CodeGenTBAA.cpp test/CodeGen/tbaa.cpp Index: test/CodeGen/tbaa.cpp === ---

[PATCH] D41456: [clang-tidy] readability-else-after-return: also diagnose noreturn function calls.

malcolm.parsons added a comment. This check could also handle else after goto. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41486: [OpenMP][Clang] Add missing argument to runtime functions.

gtbercea created this revision. gtbercea added reviewers: ABataev, carlo.bertolli, hfinkel, Hahnfeld, caomhin. Herald added a subscriber: jholewinski. This patch adds a missing argument to the runtime interface. Tests are adjusted accordingly. Repository: rL LLVM

[PATCH] D38124: Hide some symbols to avoid a crash on shutdown when using code coverage

sylvestre.ledru added a comment. I added two more reviewers as we would like to get that in trunk before 6.0 branches. https://reviews.llvm.org/D38124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41444: [ASTImporterTest] Make testing under '-fdelayed-template-parsing' mandatory

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Comment at: unittests/AST/ASTImporterTest.cpp:32 + +static RunOptions getRunOptionsForLanguage(Language Lang) { + ArgVector BasicArgs; I wonder

[PATCH] D41486: [OpenMP][Clang] Add missing argument to runtime functions.

gtbercea added a comment. In https://reviews.llvm.org/D41486#961981, @Hahnfeld wrote: > https://reviews.llvm.org/D41012? This patch doesn't update the documentation > with function signatures. Ok so I see that your patch uses a different order of the arguments. I've just added the data

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, ilya-biryukov, klimek. Symbols are not self-contained - it's only safe to hand them out if you guarantee the lifetime of the underlying data. Before this lands, I'm going to measure the

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

sammccall updated this revision to Diff 127849. sammccall added a comment. Don't intern unless the symbol was actually inserted. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41483 Files: clangd/index/Index.cpp clangd/index/Index.h unittests/clangd/FileIndexTests.cpp

[PATCH] D41485: [OpenMP][libomptarget] Add data sharing support in libomptarget

gtbercea created this revision. gtbercea added reviewers: carlo.bertolli, ABataev, Hahnfeld, grokos, caomhin, hfinkel. This patch extends the libomptarget functionality in patch https://reviews.llvm.org/D14254 with support for the data sharing scheme for supporting implicitly shared variables.

[PATCH] D41485: [OpenMP][libomptarget] Add data sharing support in libomptarget

Hahnfeld added inline comments. Comment at: libomptarget/deviceRTLs/nvptx/src/interface.h:1290-1291 EXTERN void __kmpc_spmd_kernel_deinit(); -EXTERN void __kmpc_kernel_prepare_parallel(void *WorkFn, int16_t IsOMPRuntimeInitialized); -EXTERN bool __kmpc_kernel_parallel(void

[PATCH] D41486: [OpenMP][Clang] Add missing argument to runtime functions.

Hahnfeld requested changes to this revision. Hahnfeld added a comment. This revision now requires changes to proceed. https://reviews.llvm.org/D41012? This patch doesn't update the documentation with function signatures. Repository: rL LLVM https://reviews.llvm.org/D41486

r321343 - [X86] Add missing check lines for the silvermont cases in predefined-arch-macros.c test.

Author: ctopper Date: Thu Dec 21 21:09:38 2017 New Revision: 321343 URL: http://llvm.org/viewvc/llvm-project?rev=321343=rev Log: [X86] Add missing check lines for the silvermont cases in predefined-arch-macros.c test. Modified: cfe/trunk/test/Preprocessor/predefined-arch-macros.c Modified:

[PATCH] D41495: [clangd] Skip function bodies when building the preamble

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Those are some impressive numbers! Excited to see this land, thanks for tracking down all the weird problems. Comment at: clangd/ClangdUnit.cpp:536 + // so we set

[PATCH] D40705: Diagnose invalid decl-specifiers in non-type template parameter declarations (original author miyuki!)

faisalv closed this revision. faisalv added a comment. Added via https://reviews.llvm.org/rC321339 Repository: rC Clang https://reviews.llvm.org/D40705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r321342 - [Modules] Map missing private submodules from Foo.Private to Foo_Private

Author: bruno Date: Thu Dec 21 21:04:43 2017 New Revision: 321342 URL: http://llvm.org/viewvc/llvm-project?rev=321342=rev Log: [Modules] Map missing private submodules from Foo.Private to Foo_Private In case `@import Foo.Private` fails because the submodule doesn't exist, look for `Foo_Private`

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

vladimir.plyashkun created this revision. vladimir.plyashkun added reviewers: alexfh, benlangmuir. vladimir.plyashkun added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. These changes introduce support for -vfsoverlay option in Clang-Tidy The main reason for it: In IDE

r321346 - Fix unused variable warning in SemaTemplate. NFC

Author: sammccall Date: Thu Dec 21 23:09:51 2017 New Revision: 321346 URL: http://llvm.org/viewvc/llvm-project?rev=321346=rev Log: Fix unused variable warning in SemaTemplate. NFC Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp URL:

r321341 - [X86] Add 'prfchw' to the correct CPUs to match the backend.

Author: ctopper Date: Thu Dec 21 20:51:00 2017 New Revision: 321341 URL: http://llvm.org/viewvc/llvm-project?rev=321341=rev Log: [X86] Add 'prfchw' to the correct CPUs to match the backend. Modified: cfe/trunk/lib/Basic/Targets/X86.cpp cfe/trunk/test/Preprocessor/predefined-arch-macros.c

[PATCH] D41433: Unit tests for TBAA metadata generation.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Interesting. Okay, LGTM. Repository: rC Clang https://reviews.llvm.org/D41433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r321339 - Diagnose the various invalid decl-specifiers on nontype template parameters.

Author: faisalv Date: Thu Dec 21 19:50:55 2017 New Revision: 321339 URL: http://llvm.org/viewvc/llvm-project?rev=321339=rev Log: Diagnose the various invalid decl-specifiers on nontype template parameters. The standard correctly forbids various decl-specifiers that dont make sense on non-type

[PATCH] D41514: [Index] Reduce size of SymbolInfo struct.

sammccall updated this revision to Diff 127986. sammccall added a comment. Avoid repeating uint8_t type for SymbolProperty/SymbolPropertySet. Repository: rC Clang https://reviews.llvm.org/D41514 Files: include/clang/Index/IndexSymbol.h lib/Index/IndexSymbol.cpp

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

aaron.ballman added a comment. Are the Fuchsia library headers intended to also comply with this rule? I notice there's mention of a unique_ptr class, and I can't imagine that working without overloading more operators than just assignment. Perhaps this check should not be triggered for system

r321318 - Suppress "redundant parens" warning for "A (::B())".

Author: rsmith Date: Thu Dec 21 14:26:47 2017 New Revision: 321318 URL: http://llvm.org/viewvc/llvm-project?rev=321318=rev Log: Suppress "redundant parens" warning for "A (::B())". This is a slightly odd construct (it's more common to see "A (::B)()") but can happen in friend declarations, and

[PATCH] D41526: [libclang] Avoid builtin trap for __debug parser_crash pragma

benlangmuir added a comment. Did you consider just using a different pragma that triggers this behaviour instead of avoiding the crash? I don't really have a strong preference but I'd be interested to hear what you think the pros/cons are. Comment at:

r321325 - [X86] Allow _mm_prefetch (both the header implementation and the builtin) to accept bit 2 which is supposed to indicate the prefetched addresses will be written to

Author: ctopper Date: Thu Dec 21 15:50:22 2017 New Revision: 321325 URL: http://llvm.org/viewvc/llvm-project?rev=321325=rev Log: [X86] Allow _mm_prefetch (both the header implementation and the builtin) to accept bit 2 which is supposed to indicate the prefetched addresses will be written to

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

juliehockett updated this revision to Diff 127960. juliehockett marked 5 inline comments as done. juliehockett added a comment. Fixing comments https://reviews.llvm.org/D41363 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

[PATCH] D41151: [analyzer] Adding LoopContext and improve loop modeling

NoQ added a comment. Or not. Loop counter has its own whole-loop scope. I guess `LoopContext` can be treated as a sub-class of `ScopeContext`. And i don't mind having `ScopeContext` be split into small distinct sub-classes. Because we're stuck in cornercases for covering all possible scopes,

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

juliehockett added a comment. > Are the Fuchsia library headers intended to also comply with this rule? I > notice there's mention of a unique_ptr class, and I can't imagine that > working without overloading more operators than just assignment. Perhaps this > check should not be triggered for

[PATCH] D41521: [CUDA] fixes for __shfl_* intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rC321326: [CUDA] More fixes for __shfl_* intrinsics. (authored by tra, committed by ). Changed prior to commit: https://reviews.llvm.org/D41521?vs=127950=127962#toc Repository: rC Clang

[PATCH] D41528: [Sema] Don't emit the -Wstrict-prototypes warning for variadic functions.

vsapsai created this revision. vsapsai added reviewers: arphaman, ahatanak. rdar://problem/33251668 https://reviews.llvm.org/D41528 Files: clang/lib/Sema/SemaType.cpp clang/test/Sema/warn-strict-prototypes.c Index: clang/test/Sema/warn-strict-prototypes.c

r321314 - [scudo] Add -fsanitize=scudo option to Fuchsia

Author: phosek Date: Thu Dec 21 14:04:31 2017 New Revision: 321314 URL: http://llvm.org/viewvc/llvm-project?rev=321314=rev Log: [scudo] Add -fsanitize=scudo option to Fuchsia Apparently the -fsanitize flag hadn't been added for Scudo upstream yet. Patch By: flowerhack Reviewers: cryptoad,

[PATCH] D41413: [scudo] Add -fsanitize=scudo option to Fuchsia.

This revision was automatically updated to reflect the committed changes. Closed by commit rC321314: [scudo] Add -fsanitize=scudo option to Fuchsia (authored by phosek, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D41413 Files:

[PATCH] D41520: smmintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fix formatting issue due to hyphenated terms at line breaks. 2. Fix typo These patches were

[PATCH] D41521: [CUDA] fixes for __shfl_* intrinsics.

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Since this is tricky and we've seen it affecting user code, do you think it's a bad idea to add tests to the test-suite? https://reviews.llvm.org/D41521

[PATCH] D41151: [analyzer] Adding LoopContext and improve loop modeling

NoQ added a comment. So, essentially, `LoopContext` is per-loop, while `ScopeContext` is per-iteration? Comment at: lib/StaticAnalyzer/Core/LoopUnrolling.cpp:28-46 struct LoopState { private: enum Kind { Normal, Unrolled } K; - const Stmt *LoopStmt; - const

r321326 - [CUDA] More fixes for __shfl_* intrinsics.

Author: tra Date: Thu Dec 21 15:52:09 2017 New Revision: 321326 URL: http://llvm.org/viewvc/llvm-project?rev=321326=rev Log: [CUDA] More fixes for __shfl_* intrinsics. * __shfl_{up,down}* uses unsigned int for the third parameter. * added [unsigned] long overloads for non-sync shuffles.

[PATCH] D41514: [Index] Reduce size of SymbolInfo struct.

sammccall created this revision. sammccall added a reviewer: akyrtzi. Herald added subscribers: cfe-commits, ilya-biryukov. This is currently 16 bytes, the patch reduces it to 4. (Building with clang on linux x84, I guess others are similar) The only subfield that might need a bigger type is

[PATCH] D41516: emmintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fixed innaccurate instruction mappings for various intrinsics. 2. Fixed description of NaN

[PATCH] D41498: [libcxx] Add clang negative thread safety assertions to std::mutex

lhchavez added inline comments. Comment at: include/__mutex_base:65 void unlock() _NOEXCEPT _LIBCPP_THREAD_SAFETY_ANNOTATION(release_capability()); +#ifdef _LIBCPP_HAS_THREAD_SAFETY_ANNOTATIONS +const mutex& operator!() const { return *this; }

r321320 - [analyzer] Add Javascript to analyzer HTML output to allow keyboard navigation.

Author: george.karpenkov Date: Thu Dec 21 14:57:51 2017 New Revision: 321320 URL: http://llvm.org/viewvc/llvm-project?rev=321320=rev Log: [analyzer] Add Javascript to analyzer HTML output to allow keyboard navigation. Differential Revision: https://reviews.llvm.org/D41414 Modified:

[PATCH] D41414: [analyzer] Add keyboard j/k navigation to HTML reports

This revision was automatically updated to reflect the committed changes. Closed by commit rL321320: [analyzer] Add Javascript to analyzer HTML output to allow keyboard navigation. (authored by george.karpenkov, committed by ). Changed prior to commit:

[PATCH] D41514: [Index] Reduce size of SymbolInfo struct.

akyrtzi added a comment. Nice one! One minor change I'd suggest is to change `SymbolProperty` to `enum class SymbolProperty : SymbolPropertySet`, so that if it needs to increase we only change the type in one place. Repository: rC Clang https://reviews.llvm.org/D41514

[PATCH] D41526: [libclang] Avoid builtin trap for __debug parser_crash pragma

arphaman abandoned this revision. arphaman added a comment. It turns out there's already something that works much better: `#pragma clang __debug handle_crash`. Sorry about the redundant patch! Repository: rC Clang https://reviews.llvm.org/D41526

Re: r321099 - [driver][darwin] Take the OS version specified in "-target" as the target

On 21 December 2017 at 12:34, James Y Knight wrote: > I totally agree with moving towards eliminating the -m-version-min > flags, it's much better to put it in the target, and will clean up a lot of > cruft in the driver, eventually. > > Now -- we (or anyone else who runs

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fix instruction mappings/listings for various intrinsics These patches were made by Craig

[PATCH] D41521: [CUDA] fixes for __shfl_* intrinsics.

tra created this revision. tra added a reviewer: jlebar. Herald added a subscriber: sanjoy. - __shfl_{up,down}* uses `unsigned int` for the third parameter. - added [unsigned] long overloads for non-sync shuffles. Augments r319908 which added long overload for sync shuffles.

r321321 - Delete dead code.

Author: adrian Date: Thu Dec 21 15:03:05 2017 New Revision: 321321 URL: http://llvm.org/viewvc/llvm-project?rev=321321=rev Log: Delete dead code. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL:

[clang-tools-extra] r321323 - Update test after r321312

Author: probinson Date: Thu Dec 21 15:19:25 2017 New Revision: 321323 URL: http://llvm.org/viewvc/llvm-project?rev=321323=rev Log: Update test after r321312 Modified: clang-tools-extra/trunk/unittests/change-namespace/ChangeNamespaceTests.cpp Modified:

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

erichkeane added a comment. I'm sure most of you have taken off for the year, but if anyone had time, *ping* :D https://reviews.llvm.org/D40819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41528: [Sema] Don't emit the -Wstrict-prototypes warning for variadic functions.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, thank you https://reviews.llvm.org/D41528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41507: avxintrin.h documentation fixes and updates

kromanova added inline comments. Comment at: lib/Headers/avxintrin.h:1668 ///operation to use: \n -///0x00 : Equal (ordered, non-signaling) -///0x01 : Less-than (ordered, signaling) -///0x02 : Less-than-or-equal (ordered, signaling) -///0x03 : Unordered

Re: r315984 - [CodeGen] EmitPointerWithAlignment() to generate TBAA info along with LValue base info

Hi, This commit has caused a new regression in LLVM 6. I filed the following PR: https://bugs.llvm.org/show_bug.cgi?id=35724 . Could you please take a look? Thanks, Alex On 17 October 2017 at 02:12, Ivan A. Kosarev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: kosarev > Date:

[PATCH] D41507: avxintrin.h documentation fixes and updates

lebedev.ri added inline comments. Comment at: lib/Headers/avxintrin.h:1668 ///operation to use: \n -///0x00 : Equal (ordered, non-signaling) -///0x01 : Less-than (ordered, signaling) -///0x02 : Less-than-or-equal (ordered, signaling) -///0x03 : Unordered

[PATCH] D41518: pmmintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fix incorrect wording in various intrinsic descriptions. Previously the descriptions used

r321319 - [ODRHash] Canonicalize Decl's before processing.

Author: rtrieu Date: Thu Dec 21 14:38:29 2017 New Revision: 321319 URL: http://llvm.org/viewvc/llvm-project?rev=321319=rev Log: [ODRHash] Canonicalize Decl's before processing. Canonicalizing the Decl before processing it as part of the hash should reduce issues with non-canonical types showing

[PATCH] D41523: xmmintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fix inaccurate instruction listings. 2. Fix small issues in _mm_getcsr and _mm_setcsr. 3. Fix

r321324 - Correct hasFeature/isValidFeatureName's handling of shstk/adx/mwaitx

Author: erichkeane Date: Thu Dec 21 15:27:36 2017 New Revision: 321324 URL: http://llvm.org/viewvc/llvm-project?rev=321324=rev Log: Correct hasFeature/isValidFeatureName's handling of shstk/adx/mwaitx https://bugs.llvm.org/show_bug.cgi?id=35721 reports that x86intrin.h is issuing a few warnings.

[PATCH] D41521: [CUDA] fixes for __shfl_* intrinsics.

tra added a comment. Added to my todo list. There are few more gaps that I want to test in order to make sure we don't regress on compatibility with older CUDA versions while changing these wrappers. https://reviews.llvm.org/D41521 ___

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

This revision was automatically updated to reflect the committed changes. Closed by commit rC321312: [AST] Incorrectly qualified unscoped enumeration as template actual parameter. (authored by probinson, committed by ). Changed prior to commit:

r321312 - [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

Author: probinson Date: Thu Dec 21 13:47:22 2017 New Revision: 321312 URL: http://llvm.org/viewvc/llvm-project?rev=321312=rev Log: [AST] Incorrectly qualified unscoped enumeration as template actual parameter. An unscoped enumeration used as template argument, should not have any qualified

r321316 - [CMake][Fuchsia] Enable assertions

Author: phosek Date: Thu Dec 21 14:10:27 2017 New Revision: 321316 URL: http://llvm.org/viewvc/llvm-project?rev=321316=rev Log: [CMake][Fuchsia] Enable assertions Enable assertions in both stages. Release+Asserts is fast enough. No need to let insanity through. Patch By: mcgrathr Reviewers:

[PATCH] D41471: [CMake][Fuchsia] Enable assertions

This revision was automatically updated to reflect the committed changes. Closed by commit rL321316: [CMake][Fuchsia] Enable assertions (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D41471?vs=127801=127943#toc Repository: rL LLVM

Re: r321301 - [AArch64] Enable fp16 data type for the Builtin for AArch64 only.

On Thu, Dec 21, 2017 at 12:10 PM, Abderrazek Zaafrani via cfe-commits wrote: > Author: az > Date: Thu Dec 21 12:10:03 2017 > New Revision: 321301 > > URL: http://llvm.org/viewvc/llvm-project?rev=321301=rev > Log: > [AArch64] Enable fp16 data type for the Builtin for

[PATCH] D41526: [libclang] Avoid builtin trap for __debug parser_crash pragma

arphaman created this revision. arphaman added a reviewer: benlangmuir. Herald added a subscriber: JDevlieghere. This patch allows libclang to report a parser crash that's caused by `#pragma clang __debug parser_crash` without using the `LLVM_BUILTIN_TRAP`. Instead a new flag in PPOpts is used

[PATCH] D41486: [OpenMP][Clang] Add missing argument to runtime functions.

gtbercea updated this revision to Diff 127865. gtbercea added a comment. Address comments. Repository: rL LLVM https://reviews.llvm.org/D41486 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_data_sharing.cpp test/OpenMP/nvptx_target_teams_codegen.cpp Index:

[PATCH] D40451: [OpenMP] Add function attribute for triggering shared memory lowering in the LLVM backend

gtbercea closed this revision. gtbercea added a comment. Committed here https://reviews.llvm.org/D41123 Repository: rL LLVM https://reviews.llvm.org/D40451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41444: [ASTImporterTest] Make testing under '-fdelayed-template-parsing' mandatory

a.sidorin added inline comments. Comment at: unittests/AST/ASTImporterTest.cpp:32 + +static RunOptions getRunOptionsForLanguage(Language Lang) { + ArgVector BasicArgs; xazax.hun wrote: > I wonder if in the future it would be worth to use something else, like >

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

sammccall updated this revision to Diff 127877. sammccall marked 4 inline comments as done. sammccall added a comment. Comment changes requiested in review. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41483 Files: clangd/index/Index.cpp clangd/index/Index.h

[PATCH] D40720: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

sberg updated this revision to Diff 127863. sberg added a comment. As suggested, solve the issue instead by removing any "noexcept" from the typeinfo emitted for the -fsanitize=function checks. https://reviews.llvm.org/D40720 Files: clang/lib/CodeGen/CGExpr.cpp

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

ilya-biryukov added inline comments. Comment at: clangd/index/Index.h:136 + // Intern table for strings. Not StringPool as we don't refcount, just insert. + llvm::StringSet Strings; llvm::DenseMap Symbols; A comment on why we use

[PATCH] D40705: Diagnose invalid decl-specifiers in non-type template parameter declarations (original author miyuki!)

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM, thanks a lot for fixing the patch. Repository: rC Clang https://reviews.llvm.org/D40705 ___ cfe-commits mailing list

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clangd/index/Index.h:136 + // Intern table for strings. Not StringPool as we don't refcount, just insert. + llvm::StringSet Strings; llvm::DenseMap Symbols;

r321266 - Added helper to get size of PrecompiledPreamble

Author: ibiryukov Date: Thu Dec 21 06:04:39 2017 New Revision: 321266 URL: http://llvm.org/viewvc/llvm-project?rev=321266=rev Log: Added helper to get size of PrecompiledPreamble Modified: cfe/trunk/include/clang/Frontend/PrecompiledPreamble.h

[PATCH] D41456: [clang-tidy] readability-else-after-return: also diagnose noreturn function calls.

lebedev.ri added a comment. In https://reviews.llvm.org/D41456#961826, @malcolm.parsons wrote: > This check could also handle else after goto. Yes, certainly. Though i'm not too sure on the restrictions. The obvious precondition is, the label can to be defined anywhere **except** after the

[clang-tools-extra] r321267 - [clangd] Log more info about preambles

Author: ibiryukov Date: Thu Dec 21 06:05:28 2017 New Revision: 321267 URL: http://llvm.org/viewvc/llvm-project?rev=321267=rev Log: [clangd] Log more info about preambles Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp URL:

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Nice, LGTM. Comment at: clangd/index/Index.h:108 // // FIXME: Use a space-efficient implementation, a lot of Symbol fields could // share the same storage.

[clang-tools-extra] r321272 - [clangd] Index symbols share storage within a slab.

Author: sammccall Date: Thu Dec 21 06:58:44 2017 New Revision: 321272 URL: http://llvm.org/viewvc/llvm-project?rev=321272=rev Log: [clangd] Index symbols share storage within a slab. Summary: Symbols are not self-contained - it's only safe to hand them out if you guarantee the lifetime of the

[PATCH] D41483: [clangd] Index symbols share storage within a slab.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE321272: [clangd] Index symbols share storage within a slab. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D41483?vs=127877=127879#toc Repository: rCTE

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

klimek added inline comments. Comment at: lib/Format/Format.cpp:893 for (int i = Styles.size() - 1; i >= 0; --i) { -if (Styles[i].Language == Language || -Styles[i].Language == FormatStyle::LK_None) { +if (!LanguageFound && (Styles[i].Language == Language || +

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

krasimir created this revision. krasimir added reviewers: klimek, djasper. This patch adds a FormatStyleSet for storing per-language FormatStyles for the purposes of formatting code blocks inside the main code. Repository: rC Clang https://reviews.llvm.org/D41487 Files:

[PATCH] D41444: [ASTImporterTest] Make testing under '-fdelayed-template-parsing' mandatory

szepet accepted this revision. szepet added a comment. In https://reviews.llvm.org/D41444#961110, @a.sidorin wrote: > Test both with and without '-fdelayed-template-parsing' in C++ mode. This solution LGTM as well. Just a small nit added inline. Comment at:

[PATCH] D41534: Don't add empty InstalledDir as a candidate GCC location

jackoalan created this revision. jackoalan added a reviewer: cfe-commits. I maintain a couple build tools based on Clang's Tooling framework. The tools are built and used directly out of the CMake binary directory (i.e. not installed in a meaningful way). This non-installed setup causes issues

[PATCH] D41536: Provide public getter for OverlayFileSystem

vladimir.plyashkun created this revision. vladimir.plyashkun added a reviewer: alexfh. vladimir.plyashkun added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, klimek. This is part of review - https://reviews.llvm.org/D41535 Repository: rC Clang

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

vladimir.plyashkun added a comment. Second part of review - https://reviews.llvm.org/D41536 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

rjmccall added inline comments. Comment at: include/clang/AST/Type.h:1152 +NTFK_Struct, // non-trivial C struct. +NTFK_Array// array that has non-trivial elements. + }; ahatanak wrote: > rjmccall wrote: > > ahatanak wrote: > > > rjmccall wrote: > >

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

xgsa added a comment. Ping. https://reviews.llvm.org/D41326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

ahatanak added inline comments. Comment at: include/clang/AST/Type.h:1152 +NTFK_Struct, // non-trivial C struct. +NTFK_Array// array that has non-trivial elements. + }; rjmccall wrote: > ahatanak wrote: > > rjmccall wrote: > > > We don't actually

[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

lebedev.ri created this revision. lebedev.ri added reviewers: aaron.ballman, rsmith, smeenai, rjmccall, rnk, mclow.lists. lebedev.ri added a project: clang. The diagnostic was mostly introduced in https://reviews.llvm.org/D38101 by me, as a reaction to wasting a lot of time, see mail

  1   2   >