xazax.hun added a comment.
In https://reviews.llvm.org/D42301#984713, @a.sidorin wrote:
> > I do not see a test for the following changes:
> >
> > - ASTImporter: don't add templated declarations into DeclContext
>
> It's in ASTImporterTest. It checks that the templated decl cannot be found in
xazax.hun added a comment.
I do not see a test for the following changes:
- ASTImporter: don't add templated declarations into DeclContext
- ASTImporter: proper set ParmVarDecls for imported FunctionProtoTypeLoc
Comment at: lib/AST/ASTImporter.cpp:2085
+ case
a.sidorin added a comment.
> I do not see a test for the following changes:
>
> - ASTImporter: don't add templated declarations into DeclContext
It's in ASTImporterTest. It checks that the templated decl cannot be found in
the enclosing TU.
> - ASTImporter: proper set ParmVarDecls for
xazax.hun added a comment.
High level note: `clang::TypeAliasDecl` has the same issue as `CXXRecordDecl`,
so templated versions should not be added to the DeclContext. Could you add
that just for the sake of completeness?
Repository:
rC Clang
https://reviews.llvm.org/D42301
djasper added a comment.
I am not sure we should actually do this. I agree that badly reflowing
multiline string literals is not ideal, but neither is violating the column
limit. In any case, proper reflowing would probably the best solution. How hard
would it be to implement that (for proto
hokein updated this revision to Diff 131014.
hokein added a comment.
Cleanup tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42073
Files:
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCompleteTests.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323185: [ARM] Pass _Float16 as int or float (authored by
SjoerdMeijer, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: sjoerdmeijer
Date: Tue Jan 23 02:13:49 2018
New Revision: 323185
URL: http://llvm.org/viewvc/llvm-project?rev=323185=rev
Log:
[ARM] Pass _Float16 as int or float
Pass and return _Float16 as if it were an int or float for ARM, but with the
top 16 bits unspecified, similarly like we
hokein added inline comments.
Comment at: clangd/CodeComplete.cpp:653
+// Get all scopes that will be queried in indexes.
+std::vector getQueryScopes(Sema ,
+CodeCompletionContext ) {
sammccall wrote:
> as Ilya pointed out
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D42363#983769, @hokein wrote:
> Yeah, we should fix the clang bug (root cause). But I think this patch still
> makes sense -- as we usually ignore
hokein updated this revision to Diff 131013.
hokein marked 5 inline comments as done.
hokein added a comment.
Address remaining comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42073
Files:
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index:
SjoerdMeijer updated this revision to Diff 131009.
SjoerdMeijer added a comment.
Moved the tests to the existing file (and fixed a few typos in the tests).
https://reviews.llvm.org/D42318
Files:
include/clang/AST/Type.h
lib/CodeGen/TargetInfo.cpp
test/CodeGen/arm-fp16-arguments.c
samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.
Thanks for the explanation, LGTM, thanks!
https://reviews.llvm.org/D42318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
lebedev.ri added inline comments.
Comment at: test/std/utilities/meta/meta.type.synop/endian.pass.cpp:10
+
+// UNSUPPORTED: c++98, c++03, c++11, c++14, c++1z
+
c++17, not c++1z
At least grep says there are no c++1z left in the libc++ tests.
krasimir updated this revision to Diff 131012.
krasimir added a comment.
- Address review comments
Repository:
rC Clang
https://reviews.llvm.org/D42376
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationIndenter.cpp
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1579
(Text.startswith(Prefix = "_T(\"") && Text.endswith(Postfix = "\")")))
{
+ unsigned UnbreakableTailLength = (State.NextToken &&
Author: fedor.sergeev
Date: Tue Jan 23 04:23:52 2018
New Revision: 323193
URL: http://llvm.org/viewvc/llvm-project?rev=323193=rev
Log:
[Solaris] gcc toolchain handling revamp
Summary:
General idea is to utilize generic (mostly Generic_GCC) code
and get rid of Solaris-specific handling as much as
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323193: [Solaris] gcc toolchain handling revamp (authored by
fedor.sergeev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: fedor.sergeev
Date: Tue Jan 23 04:24:01 2018
New Revision: 323194
URL: http://llvm.org/viewvc/llvm-project?rev=323194=rev
Log:
[Solaris] Make RHEL devtoolsets handling Linux-specific
Summary:
This patch is meant to address the last outstanding review comment on the
already approved
(but
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323194: [Solaris] Make RHEL devtoolsets handling
Linux-specific (authored by fedor.sergeev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323195: [Tooling] Added a VFS parameter to ClangTool
(authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41947?vs=130573=131045#toc
Repository:
rC Clang
Author: ibiryukov
Date: Tue Jan 23 04:30:02 2018
New Revision: 323195
URL: http://llvm.org/viewvc/llvm-project?rev=323195=rev
Log:
[Tooling] Added a VFS parameter to ClangTool
Summary:
The parameter overrides the underlying vfs used by ClangTool for
filesystem operations.
Patch by Vladimir
Author: ibiryukov
Date: Tue Jan 23 04:31:06 2018
New Revision: 323196
URL: http://llvm.org/viewvc/llvm-project?rev=323196=rev
Log:
[clang-tidy] Add -vfsoverlay flag
Summary:
It allows to remap and override files and directories on disk when
running clang-tidy. The intended use case for the flag
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323196: [clang-tidy] Add -vfsoverlay flag (authored by
ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41535?vs=130891=131046#toc
Repository:
rCTE Clang Tools Extra
hokein updated this revision to Diff 131019.
hokein added a comment.
Format the test code.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42073
Files:
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCompleteTests.cpp
krasimir updated this revision to Diff 131023.
krasimir marked 3 inline comments as done.
krasimir added a comment.
- Update comment
Repository:
rC Clang
https://reviews.llvm.org/D42376
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Happy to go forward with this. I think we might also wanna investigate whether
entirely removing UnbreakableTailLength would be beneficial. I think we
implemented it as an optimization, but
krasimir added a comment.
Let's not do this then. For reflowing string literals, it could take a
two-three months.
Repository:
rC Clang
https://reviews.llvm.org/D42373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323189: [clangd] Use accessible scopes to query indexes for
global code completion. (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh.
Herald added subscribers: cfe-commits, xazax.hun, klimek.
C++2a allows bitfields to have default member initializers.
Add support for this to clang-tidy's modernize-use-default-member-init check.
Author: hokein
Date: Tue Jan 23 03:43:18 2018
New Revision: 323191
URL: http://llvm.org/viewvc/llvm-project?rev=323191=rev
Log:
[clang-tidy] Don't generate fixes for invalid new expr location in
modernize-make-unique.
Reviewers: ilya-biryukov
Reviewed By: ilya-biryukov
Subscribers: klimek,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323191: [clang-tidy] Dont generate fixes for invalid
new expr location in modernize… (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
jkorous-apple added inline comments.
Comment at: Parse/ParseTemplate.cpp:492
+ // Is there just a typo in the input code? ('typedef' instead of 'typename')
+ if (Tok.is(tok::kw_typedef)) {
+Diag(Tok.getLocation(), diag::err_expected_template_parameter);
jkorous-apple updated this revision to Diff 131041.
jkorous-apple added a comment.
Changes based on Volodymyr's comments.
https://reviews.llvm.org/D42170
Files:
FixIt/fixit-typedef-instead-of-typename-typo.cpp
Parse/ParseTemplate.cpp
clang/Basic/DiagnosticParseKinds.td
Index:
hokein updated this revision to Diff 131018.
hokein added a comment.
remove the leading "::".
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42073
Files:
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCompleteTests.cpp
hokein added inline comments.
Comment at: clangd/CodeComplete.cpp:695
+ Info.UnresolvedQualifier =
+ Lexer::getSourceText(CharSourceRange::getCharRange((*SS)->getRange()),
+ S.getSourceManager(), clang::LangOptions());
hokein
djasper added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1579
(Text.startswith(Prefix = "_T(\"") && Text.endswith(Postfix = "\")")))
{
+ unsigned UnbreakableTailLength = (State.NextToken && canBreak(State))
+
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1579
(Text.startswith(Prefix = "_T(\"") && Text.endswith(Postfix = "\")")))
{
+ unsigned UnbreakableTailLength = (State.NextToken && canBreak(State))
+
Author: krasimir
Date: Tue Jan 23 03:26:19 2018
New Revision: 323188
URL: http://llvm.org/viewvc/llvm-project?rev=323188=rev
Log:
[clang-format] Ignore UnbreakableTailLength sometimes during breaking
Summary:
This patch fixes an issue where the UnbreakableTailLength would be counted
towards
the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323188: [clang-format] Ignore UnbreakableTailLength
sometimes during breaking (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
miyuki added a comment.
ping^2
https://reviews.llvm.org/D41629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Tue Jan 23 03:37:26 2018
New Revision: 323189
URL: http://llvm.org/viewvc/llvm-project?rev=323189=rev
Log:
[clangd] Use accessible scopes to query indexes for global code completion.
Summary:
* For qualified completion (foo::a^)
* unresolved qualifier - use global
sdardis created this revision.
sdardis added reviewers: cryptoad, atanasyan.
Herald added a subscriber: arichardson.
r317337 missed that scudo is supported on MIPS32, so permit that option for
MIPS32.
Repository:
rC Clang
https://reviews.llvm.org/D42416
Files:
mclow.lists closed this revision.
mclow.lists added a comment.
Committed as revision 323296
https://reviews.llvm.org/D35472
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
- If we are unable to determine a good target region for a C++ constructor
call, we come up with a temporary region and construct into that.
aemerson updated this revision to Diff 131191.
aemerson added a comment.
I've added two kinds of warnings, one for targets which have incomplete GISel
support, and another for unsupported optimisation levels (for ARM64
-O{1,2,3,s,z}).
Repository:
rC Clang
https://reviews.llvm.org/D42276
Wizard created this revision.
Herald added subscribers: cfe-commits, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42464
Files:
clang-tidy/objc/PropertyDeclarationCheck.cpp
docs/clang-tidy/checks/objc-property-declaration.rst
hintonda created this revision.
hintonda added reviewers: beanz, compnerd, phosek, EricWF.
Herald added subscribers: cfe-commits, mgorny.
Clang and llvm already use llvm_setup_rpath(), so this change will
help standarize rpath usage across all projects.
Repository:
rCXX libc++
hintonda created this revision.
hintonda added reviewers: beanz, compnerd, phosek, EricWF.
Herald added subscribers: cfe-commits, mgorny.
Clang and llvm already use llvm_setup_rpath(), so this change will
help standarize rpath usage across all projects.
Repository:
rCXXA libc++abi
Author: marshall
Date: Tue Jan 23 21:38:51 2018
New Revision: 323306
URL: http://llvm.org/viewvc/llvm-project?rev=323306=rev
Log:
include to get uint32_t
Modified:
libcxx/trunk/test/std/utilities/meta/meta.type.synop/endian.pass.cpp
Modified:
Currently, herald doesn't subscribe libunwind to any group. Should it be
added to cfe-commits?
https://reviews.llvm.org/H268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
WeiChungChang added a comment.
Here gives the comparison between GCC & LLVM's std c++ library.
It is shown that libc++ soon suffers from rotate speed under limited allocated
buffer and slower than GCC's corresponding version.
Both LLVM & GCC run the same test program.
F5782010: 0124.png
tra created this revision.
tra added a reviewer: jlebar.
Herald added a subscriber: sanjoy.
NVPTX does not have runtime support necessary for profiling to work
and even call arc collection is prohibitively expensive. Furthermore,
there's no easy way to collect the samples. NVPTX also does not
Author: pcc
Date: Tue Jan 23 20:30:19 2018
New Revision: 323300
URL: http://llvm.org/viewvc/llvm-project?rev=323300=rev
Log:
libcxx: Allow auto-linking to be disabled with a macro.
Some users may have a custom build system which gives a different
name to the libc++ archive (or does not create an
Hello everyone,
Below are some buildbot numbers for the week of 1/07/2018 - 1/13/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
Hello everyone,
Below are some buildbot numbers for the last week of 1/14/2018 - 1/20/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from
Author: nico
Date: Tue Jan 23 17:45:57 2018
New Revision: 323293
URL: http://llvm.org/viewvc/llvm-project?rev=323293=rev
Log:
Fix typo in comment.
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp
URL:
Author: marshall
Date: Tue Jan 23 17:53:24 2018
New Revision: 323296
URL: http://llvm.org/viewvc/llvm-project?rev=323296=rev
Log:
Implement P0463R1: 'Endian just Endian'. Reviewed as
https://reviews.llvm.org/D35472
Added:
libcxx/trunk/test/std/utilities/meta/meta.type.synop/endian.pass.cpp
Does 323294 help?
On Tue, Jan 23, 2018 at 4:58 PM, Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hello Nico,
>
> This commit broke one of our builders:
>
> http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/4701
> . . .
> FAILED:
Author: nico
Date: Tue Jan 23 17:47:22 2018
New Revision: 323294
URL: http://llvm.org/viewvc/llvm-project?rev=323294=rev
Log:
Attempt to fix implicit-fallthrough warning after r323218.
Modified:
cfe/trunk/lib/Format/UnwrappedLineParser.cpp
Modified:
colden added a comment.
Confirmed, this fixes my issue! Thanks!
https://reviews.llvm.org/D42455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dyung added a comment.
LGTM!
https://reviews.llvm.org/D41888
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:570
+ struct EvalCallFlags {
+bool IsConstructorWithImproperlyModeledTargetRegion : 1;
Those are not really flags. Perhaps options?
Author: djg
Date: Tue Jan 23 09:04:04 2018
New Revision: 323224
URL: http://llvm.org/viewvc/llvm-project?rev=323224=rev
Log:
[WebAssembly] Add mem.* builtin functions.
This corresponds to r323222 in LLVM. The new names are not yet
finalized, so use them at your own risk.
Modified:
Author: nico
Date: Tue Jan 23 09:10:25 2018
New Revision: 323226
URL: http://llvm.org/viewvc/llvm-project?rev=323226=rev
Log:
clang-format: Support macros in front of @interface / @protocol for ObjC code.
Modified:
cfe/trunk/lib/Format/UnwrappedLineParser.cpp
Author: nico
Date: Tue Jan 23 09:29:41 2018
New Revision: 323228
URL: http://llvm.org/viewvc/llvm-project?rev=323228=rev
Log:
Name two bool parameters. No behavior change.
Modified:
cfe/trunk/lib/Format/FormatToken.h
Modified: cfe/trunk/lib/Format/FormatToken.h
URL:
Author: abataev
Date: Tue Jan 23 10:12:38 2018
New Revision: 323232
URL: http://llvm.org/viewvc/llvm-project?rev=323232=rev
Log:
[OPENMP] Remove more empty SourceLocations() from the code.
Removed more empty SourceLocations() from the OpenMP code and replaced
with the correct locations for
Author: hahnfeld
Date: Tue Jan 23 10:12:12 2018
New Revision: 323231
URL: http://llvm.org/viewvc/llvm-project?rev=323231=rev
Log:
test/Driver: Add some --stdlib=platform, NFC.
This fixes the failing test when building with CLANG_DEFAULT_CXX_STDLIB.
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323239: [CUDA] CUDA has no device-side library builtins.
(authored by tra, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: compnerd
Date: Tue Jan 23 11:35:51 2018
New Revision: 323247
URL: http://llvm.org/viewvc/llvm-project?rev=323247=rev
Log:
CodeGen: use `llvm.used` for ObjC protocols
These symbols are supposed to be preserved even by the linker. Use the
`llvm.used` to ensure that the symbols are not
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323227: [clang-tidy] Handle bitfields in
cppcoreguidelines-pro-type-member-init if… (authored by malcolm.parsons,
committed by ).
Changed prior to commit:
ilya-biryukov updated this revision to Diff 131105.
ilya-biryukov marked 4 inline comments as done.
ilya-biryukov added a comment.
- Renamed SimpleThreadPool to ThreadPool
- Removed PCHs from Scheduler's constructor
- Renamed waitFor(AST|Preamble)Action to blocking(AST|Preamble)Read
- Updates
-
qcolombet added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:4699
+else
+ CmdArgs.push_back("-global-isel=0");
+ }
aemerson wrote:
> qcolombet wrote:
> > qcolombet wrote:
> > > I think that it would be useful to also set
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: ioeric, jkorous-apple, klimek.
It allows to get rid of CppFile::getLastCommand and simplify the
code in the upcoming threading patch.
Repository:
rCTE Clang Tools Extra
mclow.lists updated this revision to Diff 131102.
mclow.lists added a comment.
Find *all* the places that we are using `exception_class` and wrap them in
helper routines.
https://reviews.llvm.org/D42242
Files:
src/cxa_default_handlers.cpp
src/cxa_exception.cpp
src/cxa_exception.hpp
Author: ctopper
Date: Tue Jan 23 10:40:15 2018
New Revision: 323235
URL: http://llvm.org/viewvc/llvm-project?rev=323235=rev
Log:
[Docs] Re-generate command line documentation.
Modified:
cfe/trunk/docs/ClangCommandLineReference.rst
Modified: cfe/trunk/docs/ClangCommandLineReference.rst
URL:
Author: abataev
Date: Tue Jan 23 10:44:14 2018
New Revision: 323236
URL: http://llvm.org/viewvc/llvm-project?rev=323236=rev
Log:
[OPENMP] Replace call of EmitLoadOfLValue() by EmitLoadOfScalar(), NFC.
Replace calls of EmitLoadOfLValue() by EmitLoadOfScalar() functions if
it is known that the
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.h:164
+/// Handles running tasks for ClangdServer and managing the resources (e.g.,
+/// preambles and ASTs) for opened files.
sammccall wrote:
> This is a nice abstraction, so much better
vsapsai added inline comments.
Comment at: Parse/ParseTemplate.cpp:492
+ // Is there just a typo in the input code? ('typedef' instead of 'typename')
+ if (Tok.is(tok::kw_typedef)) {
+Diag(Tok.getLocation(), diag::err_expected_template_parameter);
Author: malcolm.parsons
Date: Tue Jan 23 09:13:57 2018
New Revision: 323227
URL: http://llvm.org/viewvc/llvm-project?rev=323227=rev
Log:
[clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if
using C++2a
Summary:
C++2a allows bitfields to have default member initializers.
Author: compnerd
Date: Tue Jan 23 11:17:25 2018
New Revision: 323241
URL: http://llvm.org/viewvc/llvm-project?rev=323241=rev
Log:
AST: adjust ObjC MS mangling to work with typedefs
Rather than hardcode the pointerness of the `id` and `class` types,
handle them generically. This allows for the
simark updated this revision to Diff 131051.
simark added a comment.
Herald added subscribers: ioeric, jkorous-apple.
I just got familiar with the patch, I cleaned up the bits that I thought were
unnecessary for this change. For example, we don't need a toJSON function for
m.ostapenko updated this revision to Diff 131091.
m.ostapenko added a comment.
Herald added a subscriber: llvm-commits.
Rebased and ping.
Repository:
rL LLVM
https://reviews.llvm.org/D16403
Files:
include/clang/Analysis/AnalysisDeclContext.h
include/clang/Analysis/CFG.h
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:222
+ }
+ // We currently do all the reads of the AST on a running thread to avoid
+ // inconsistent states coming from subsequent updates.
sammccall wrote:
> Having trouble with this
Author: compnerd
Date: Tue Jan 23 09:57:04 2018
New Revision: 323230
URL: http://llvm.org/viewvc/llvm-project?rev=323230=rev
Log:
test: simplify the matching logic a bit (NFC)
Use CHECK-SAME directives to simplify the test conditions a bit. This
makes it easier to see what is being checked.
Author: pcc
Date: Tue Jan 23 10:53:33 2018
New Revision: 323237
URL: http://llvm.org/viewvc/llvm-project?rev=323237=rev
Log:
libcxx: Rename vasprintf function to __libcpp_vasprintf.
The language standard does not define a function with this name,
so it is part of the user's namespace. This
Author: george.karpenkov
Date: Tue Jan 23 12:01:31 2018
New Revision: 323251
URL: http://llvm.org/viewvc/llvm-project?rev=323251=rev
Log:
[analyzer] Mark lines as relevant even if they weren't executed but have a
label attached
Differential Revision: https://reviews.llvm.org/D42320
Added:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323251: [analyzer] Mark lines as relevant even if they
werent executed but have a… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
vsapsai added a comment.
Checked that suggested change also fixes another OSS-Fuzz bug
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4664
https://reviews.llvm.org/D41834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexshap added a comment.
Herald added a reviewer: george.karpenkov.
switched to checking (*I)->getType()
Repository:
rL LLVM
https://reviews.llvm.org/D42396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: compnerd
Date: Tue Jan 23 12:56:52 2018
New Revision: 323257
URL: http://llvm.org/viewvc/llvm-project?rev=323257=rev
Log:
AST: correct mangling for SEL on MS ABI
We would previously treat `SEL` as a pointer-only type. This is not the
case. It should be treated similarly to `id` and
Author: compnerd
Date: Tue Jan 23 09:05:57 2018
New Revision: 323225
URL: http://llvm.org/viewvc/llvm-project?rev=323225=rev
Log:
test: adjust the target for some Windows tests
The tests are targeting Windows but do not specify an environment. When
executed on Linux, they would use an ELF
mclow.lists added inline comments.
Comment at: include/algorithm:2515
+{
+pointer __buff_end = __move(__first, __middle, __buff);
+__move(__middle, __last, __first);
mclow.lists wrote:
> Probably a good idea to qualify these calls with
Author: tra
Date: Tue Jan 23 11:08:18 2018
New Revision: 323239
URL: http://llvm.org/viewvc/llvm-project?rev=323239=rev
Log:
[CUDA] CUDA has no device-side library builtins.
We should (almost) never consider a device-side declaration to match a
library builtin functio. Otherwise clang may
Author: george.karpenkov
Date: Tue Jan 23 11:28:43 2018
New Revision: 323244
URL: http://llvm.org/viewvc/llvm-project?rev=323244=rev
Log:
[html] [NFC] Use raw strings to dump the style table.
Modified:
cfe/trunk/lib/Rewrite/HTMLRewrite.cpp
Modified: cfe/trunk/lib/Rewrite/HTMLRewrite.cpp
Author: george.karpenkov
Date: Tue Jan 23 11:28:52 2018
New Revision: 323245
URL: http://llvm.org/viewvc/llvm-project?rev=323245=rev
Log:
[analyzer] Show full analyzer invocation for reproducibility in HTML reports
Analyzing problems which appear in scan-build results can be very
difficult, as
Author: djg
Date: Tue Jan 23 12:22:12 2018
New Revision: 323253
URL: http://llvm.org/viewvc/llvm-project?rev=323253=rev
Log:
[WebAssembly] Factor out settings common to wasm32 and wasm64. NFC.
MaxAtomicPromoteWidth and MaxAtomicInlineWidth are 64 on both
wasm32 and wasm64, so they can be set in
Nebiroth added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:78
{"documentHighlightProvider", true},
+{"configurationChangeProvider", true},
{"renameProvider", true},
simark wrote:
> I find
simark added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:78
{"documentHighlightProvider", true},
+{"configurationChangeProvider", true},
{"renameProvider", true},
Nebiroth wrote:
> simark wrote:
> > I find
simark updated this revision to Diff 131131.
simark added a comment.
Fix formatting, remove capability
- Fix some formatting nits
- Remove the entry in the capabilities object
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39571
Files:
clangd/ClangdLSPServer.cpp
1 - 100 of 133 matches
Mail list logo
