[PATCH] D42719: [CFG] [analyzer] Add construction context when constructor is wrapped into ExprWithCleanups.

NoQ updated this revision to Diff 132699. NoQ added a comment. Rebase. Add direct tests, though one was already there since https://reviews.llvm.org/D42699 as a fixme. https://reviews.llvm.org/D42719 Files: lib/Analysis/CFG.cpp test/Analysis/cfg-rich-constructors.cpp

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r324161 - [analyzer] Do not infer nullability inside function-like macros, even when macro is explicitly returning NULL

Author: george.karpenkov Date: Fri Feb 2 16:55:21 2018 New Revision: 324161 URL: http://llvm.org/viewvc/llvm-project?rev=324161=rev Log: [analyzer] Do not infer nullability inside function-like macros, even when macro is explicitly returning NULL We already suppress such reports for inlined

[PATCH] D42404: [analyzer] Do not infer nullability inside function-like macros, even when macro is explicitly returning NULL

This revision was automatically updated to reflect the committed changes. Closed by commit rC324161: [analyzer] Do not infer nullability inside function-like macros, even when… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. In https://reviews.llvm.org/D42645#996668, @NoQ wrote: > All right, so the code looks good now, but in order to commit this, we also > need tests. We've got those automatic tests of ours in `test/Analysis/` that > feed small code snippets into the analyzer and verify

[PATCH] D42645: New simple Checker for mmap calls

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Fantastic, thanks! I'll commit. Repository: rC Clang https://reviews.llvm.org/D42645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42876: [analyzer] Support returning objects by value.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. NoQ added dependencies: D42875: [analyzer] Add construction context for ReturnStmt., D42779: [analyzer] NFC: Make sure we don't ever inline

[libcxx] r324153 - Fix has_unique_object_representation after Clang commit r324134.

Author: ericwf Date: Fri Feb 2 14:39:59 2018 New Revision: 324153 URL: http://llvm.org/viewvc/llvm-project?rev=324153=rev Log: Fix has_unique_object_representation after Clang commit r324134. Clang previously reported an empty union as having a unique object representation. This was incorrect

[PATCH] D42874: [hwasan] Add a paragraph on stack instrumentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324163: [hwasan] Add a paragraph on stack instrumentation. (authored by eugenis, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

Re: r324062 - [Sema] Add implicit members even for invalid CXXRecordDecls

This causes some stray diagnostics to be emitted in certian cases where a base class is already invalid: Reproducer: https://gist.github.com/EricWF/588a361030edeaebbbc1155b8347cab0 On Fri, Feb 2, 2018 at 1:40 AM, Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author:

Re: r294872 - CodeGen: annotate ObjC ARC functions with ABI constraints

> On Jan 31, 2018, at 9:15 AM, Akira Hatanaka wrote: > > > >> On Jan 30, 2018, at 4:32 PM, Saleem Abdulrasool > > wrote: >> >> Thanks for the note here. I’ll try to take a look at that, but, yes, the >> frontend

[PATCH] D42645: New simple Checker for mmap calls

NoQ added a comment. Wonderful! Could you also add a `// no-warning` kind of test, i.e. when the respective flags are not set, no warning is emitted? Repository: rC Clang https://reviews.llvm.org/D42645 ___ cfe-commits mailing list

[libcxx] r324164 - Work around Clang bug introduced in r324062

Author: ericwf Date: Fri Feb 2 17:45:35 2018 New Revision: 324164 URL: http://llvm.org/viewvc/llvm-project?rev=324164=rev Log: Work around Clang bug introduced in r324062 When Clang encounters an already invalid class declaration, it can emit incorrect diagnostics about the exception

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

erichkeane added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1717 +Out << '8'; +for (const char *NS : {"__swift_cc", "__Swift"}) + mangleSourceName(NS); compnerd wrote: > erichkeane wrote: > > rsmith wrote: > > > erichkeane

[PATCH] D41039: Add support for attribute "trivial_abi"

rsmith accepted this revision. rsmith added inline comments. Comment at: include/clang/Sema/Sema.h:2240-2241 + enum TrivialityKind { +TK_NoTrivialABI, // The triviality of a method unaffected by "trivial_abi". +TK_TrivialABI // The triviality of a method affected by

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka added a comment. PTAL https://reviews.llvm.org/D42680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 132702. vitalybuka marked an inline comment as done. vitalybuka added a comment. comment https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D42721: [analyzer] NFC: Use construction contexts for finding the target region for the construction.

NoQ updated this revision to Diff 132707. NoQ added a comment. Rebase. https://reviews.llvm.org/D42721 Files: include/clang/Analysis/CFG.h include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/ExprEngineCXX.cpp Index:

[PATCH] D42404: [analyzer] Do not infer nullability inside function-like macros, even when macro is explicitly returning NULL

NoQ added a comment. Woohoo even better. Repository: rC Clang https://reviews.llvm.org/D42404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42874: [hwasan] Add a paragraph on stack instrumentation.

eugenis created this revision. eugenis added a reviewer: kcc. https://reviews.llvm.org/D42874 Files: clang/docs/HardwareAssistedAddressSanitizerDesign.rst Index: clang/docs/HardwareAssistedAddressSanitizerDesign.rst === ---

r324163 - [hwasan] Add a paragraph on stack instrumentation.

Author: eugenis Date: Fri Feb 2 17:06:21 2018 New Revision: 324163 URL: http://llvm.org/viewvc/llvm-project?rev=324163=rev Log: [hwasan] Add a paragraph on stack instrumentation. Reviewers: kcc Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D42874 Modified:

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132715. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

compnerd added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1717 +Out << '8'; +for (const char *NS : {"__swift_cc", "__Swift"}) + mangleSourceName(NS); erichkeane wrote: > compnerd wrote: > > erichkeane wrote: > > > rsmith

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

dblaikie accepted this revision. dblaikie added a comment. Few things that could tidy up the tests a bit, but otherwise looks good :) Comment at: test/CodeGen/debug-info-enum.cpp:6-10 +// CHECK: !DICompositeType(tag: DW_TAG_enumeration_type, name: "E0" +// CHECK-SAME: flags:

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132713. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[libcxx] r324165 - Work around GCC constexpr initialization bug

Author: ericwf Date: Fri Feb 2 17:48:21 2018 New Revision: 324165 URL: http://llvm.org/viewvc/llvm-project?rev=324165=rev Log: Work around GCC constexpr initialization bug Modified: libcxx/trunk/test/std/algorithms/alg.sorting/alg.lex.comparison/lexicographical_compare_comp.pass.cpp

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ updated this revision to Diff 132685. NoQ added a comment. Rename the method, add comments. https://reviews.llvm.org/D42672 Files: include/clang/Analysis/AnalysisDeclContext.h include/clang/Analysis/CFG.h include/clang/StaticAnalyzer/Core/AnalyzerOptions.h

r324151 - Add missing direct-init / parameter-declaration-clause disambiguation when

Author: rsmith Date: Fri Feb 2 14:24:54 2018 New Revision: 324151 URL: http://llvm.org/viewvc/llvm-project?rev=324151=rev Log: Add missing direct-init / parameter-declaration-clause disambiguation when parsing a trailing-return-type of a (function pointer) variable declaration. Modified:

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

compnerd added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1061 +if (Ty->getAs()->getCallConv() == CC_Swift) + for (const char *NS : {"__swift_cc", "__Swift"}) +mangleSourceName(NS); rsmith wrote: > Do we really need both of these

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb added a comment. @sdardis Can you confirm if the existing N64 bits work fine for you or if the tests crash similarly? https://reviews.llvm.org/D39074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42680: [ThinLTO] Ignore -fthinlto-index= for non-ThinLTO files

vitalybuka updated this revision to Diff 132701. vitalybuka added a comment. skip full LTO objects https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp

r324160 - Fix crash when trying to pack-expand a GNU statement expression.

Author: rsmith Date: Fri Feb 2 16:44:57 2018 New Revision: 324160 URL: http://llvm.org/viewvc/llvm-project?rev=324160=rev Log: Fix crash when trying to pack-expand a GNU statement expression. We could in principle support such pack expansion, using techniques similar to what we do for pack

[PATCH] D42874: [hwasan] Add a paragraph on stack instrumentation.

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM++ https://reviews.llvm.org/D42874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42875: [analyzer] Add construction context for ReturnStmt.

NoQ created this revision. NoQ added reviewers: rsmith, dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. This one's new, the analyzer didn't enjoy this before. This patch adds construction context for `ReturnStmt`, which means that we'd

[PATCH] D42841: [docs] Improve help for OpenMP options

Hahnfeld created this revision. Hahnfeld added reviewers: ABataev, gtbercea. Herald added subscribers: cfe-commits, guansong. - Add HelpText for -fopenmp so that it appears in clang --help. - Hide -fopenmp-relocatable-target from there. - Hide -fno-openmp-simd, other options only list the

[PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

ioeric updated this revision to Diff 132549. ioeric marked 2 inline comments as done. ioeric edited the summary of this revision. ioeric added a comment. Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42796 Files: clangd/index/SymbolCollector.cpp

[clang-tools-extra] r324073 - [clangd] Remove a unused include. NFC

Author: ioeric Date: Fri Feb 2 03:25:38 2018 New Revision: 324073 URL: http://llvm.org/viewvc/llvm-project?rev=324073=rev Log: [clangd] Remove a unused include. NFC Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp Modified:

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

Hahnfeld resigned from this revision. Hahnfeld added a comment. In https://reviews.llvm.org/D42755#995593, @vsapsai wrote: > Good suggestion for explaining the problem with `file_time_type::min()` in > more detail. Also PR35990 has > some details

[PATCH] D42810: [Sema] Add implicit members even for invalid CXXRecordDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rC324062: [Sema] Add implicit members even for invalid CXXRecordDecls (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D42810?vs=132443=132546#toc Repository:

r324062 - [Sema] Add implicit members even for invalid CXXRecordDecls

Author: ibiryukov Date: Fri Feb 2 00:40:08 2018 New Revision: 324062 URL: http://llvm.org/viewvc/llvm-project?rev=324062=rev Log: [Sema] Add implicit members even for invalid CXXRecordDecls Summary: It should be safe, since other code paths are already generating implicit members even in

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

avt77 added a comment. In https://reviews.llvm.org/D42530#995227, @rjmccall wrote: > That's still just const-propagation. The const qualifier on the pointee type > of this should propagate to the l-value resulting from the member access, and > the vector-specific projection logic should

[PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

ilya-biryukov added inline comments. Comment at: clangd/index/SymbolCollector.cpp:74 +if (llvm::isa(Context) || +llvm::isa(Context)) + break; I may not know enough about the AST, sorry if the question is obvious. `TranslationUnitDecl` is the

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:302 +// FIXME: This function needs to be properly tested. +void ClangdLSPServer::onChangeConfiguration( simark wrote: > simark wrote: > > ilya-biryukov wrote: > > > simark wrote: > > >

[PATCH] D42812: [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value-param

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

alexfh added inline comments. Comment at: clang-tidy/modernize/AvoidFunctionalCheck.cpp:22 + Finder->addMatcher( + cxxRecordDecl(allOf(anyOf(isDerivedFrom("std::binary_function"), +isDerivedFrom("std::unary_function")),

[PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

ioeric added inline comments. Comment at: clangd/index/SymbolCollector.cpp:69 +// qualifier. Inline namespaces and unscoped enums are skipped. +llvm::Expected getScope(const NamedDecl *ND) { + llvm::SmallVector Contexts; hokein wrote: >

[PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

ioeric updated this revision to Diff 132552. ioeric added a comment. - clang-format Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42796 Files: clangd/index/SymbolCollector.cpp unittests/clangd/SymbolCollectorTests.cpp Index: unittests/clangd/SymbolCollectorTests.cpp

[PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

ilya-biryukov added inline comments. Comment at: clangd/index/SymbolCollector.cpp:73 + Context = Context->getParent()) { +if (llvm::isa(Context) || +llvm::isa(Context)) ioeric wrote: > sammccall wrote: > > I'm not sure this is always correct:

[clang-tools-extra] r324065 - [clangd] Skip inline namespace when collecting scopes for index symbols.

Author: ioeric Date: Fri Feb 2 02:31:42 2018 New Revision: 324065 URL: http://llvm.org/viewvc/llvm-project?rev=324065=rev Log: [clangd] Skip inline namespace when collecting scopes for index symbols. Summary: Some STL symbols are defined in inline namespaces. For example, ``` namespace std {

[PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324065: [clangd] Skip inline namespace when collecting scopes for index symbols. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

Re: r323155 - Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target

Thanks! I've merged them to 6.0 as below and they will be part of rc2, scheduled for next week. Chandler, do you want to write release notes for this? On Thu, Feb 1, 2018 at 8:09 PM, Chandler Carruth wrote: > +Hans Wennborg +tstel...@redhat.com > > So the retpoline patch

[PATCH] D42840: [docs] Fix duplicate arguments for JoinedAndSeparate

Hahnfeld created this revision. Hahnfeld added reviewers: rsmith, craig.topper. Herald added a subscriber: cfe-commits. We can't see how many arguments are in the meta var name, so just assume that is the right number. Repository: rC Clang https://reviews.llvm.org/D42840 Files:

<    1   2