[PATCH] D42708: [clang-format] Set ObjCBinPackProtocolList to Never for google style

stephanemoore added a comment. I believe that I have consensus from Google to be able to approve this. I sent out a last call for dissenting opinions. If I don't hear anything I plan on approving tomorrow. Repository: rC Clang https://reviews.llvm.org/D42708

[PATCH] D41834: [Lex] Fix handling numerical literals ending with ' and signed exponent.

This revision was automatically updated to reflect the committed changes. Closed by commit rC324419: [Lex] Fix handling numerical literals ending with and signed exponent. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D41834?vs=129125=133085#toc

[PATCH] D42882: [Myriad] Define __ma2x5x and __ma2x8x

This revision was automatically updated to reflect the committed changes. Closed by commit rC324420: [Myriad] Define __ma2x5x and __ma2x8x (authored by waltl, committed by ). Changed prior to commit: https://reviews.llvm.org/D42882?vs=132739=133086#toc Repository: rC Clang

[PATCH] D42983: [clang-tidy] Add `readability-simd-intrinsics` check.

MaskRay updated this revision to Diff 133091. MaskRay added a comment. Move CHECK-MESSAGES: to comform to the prevaling style Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

r324433 - [NFC] Change odd cast-through-unknown behavior to an Optional

Author: erichkeane Date: Tue Feb 6 16:37:19 2018 New Revision: 324433 URL: http://llvm.org/viewvc/llvm-project?rev=324433=rev Log: [NFC] Change odd cast-through-unknown behavior to an Optional This bit of code in the driver uses '~0U' as a sentinel value. The result is an odd mishmash of casts

[PATCH] D42768: AST: support SwiftCC on MS ABI

compnerd updated this revision to Diff 133114. compnerd retitled this revision from "AST: add an extension to support SwiftCC on MS ABI" to "AST: support SwiftCC on MS ABI". compnerd edited the summary of this revision. compnerd added a comment. Update to what Microsoft has communicated offline

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

rsmith added a comment. Looks fine to me. Repository: rC Clang https://reviews.llvm.org/D42768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42993: [AArch64] Fixes for ARMv8.2-A FP16 scalar intrinsic

az created this revision. az added a reviewer: SjoerdMeijer. Herald added subscribers: hiraditya, kristof.beyls, javed.absar, rengolin, aemerson. A couple of fixes on top of https://reviews.llvm.org/D41792: - Fixes for freceprical, and fsqrt instructions in the backend. - The intrinsics that

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 133111. vitalybuka added a comment. Create valid empty object file https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D42983: [clang-tidy] Add `readability-simd-intrinsics` check.

MaskRay added a comment. I haven't used clang-tidy before :) Do you have any suggestions on my workflow? % ninja -C ~/Dev/llvm/build clangTidyReadabilityModule % ~/Dev/llvm/build/bin/clang-tidy -checks='-*,readability-simd-intrinsics' a.cc # for local testing # Ensure tests are

[PATCH] D41834: [Lex] Fix handling numerical literals ending with ' and signed exponent.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324419: [Lex] Fix handling numerical literals ending with and signed exponent. (authored by vsapsai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D41834: [Lex] Fix handling numerical literals ending with ' and signed exponent.

vsapsai added a comment. Thanks for the review. https://reviews.llvm.org/D41834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42864: [clang-format] Add more tests for Objective-C 2.0 generic alignment

stephanemoore added a comment. Looks reasonable  Repository: rL LLVM https://reviews.llvm.org/D42864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

compnerd updated this revision to Diff 133087. compnerd added a comment. address design changes Repository: rC Clang https://reviews.llvm.org/D42768 Files: lib/AST/MicrosoftMangle.cpp test/CodeGenCXX/msabi-swiftcall-cc.cpp Index: test/CodeGenCXX/msabi-swiftcall-cc.cpp

[PATCH] D42991: [analyzer] NFC: Use EvalCallOptions for destructors as well.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. In https://reviews.llvm.org/D42457 we added the `EvalCallOptions` structure to notify `evalCall()` when some other code believes that

[PATCH] D42991: [analyzer] Use EvalCallOptions for destructors as well.

NoQ updated this revision to Diff 133106. NoQ added a comment. Remove a couple of accidental blank lines. https://reviews.llvm.org/D42991 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/ExprEngine.cpp lib/StaticAnalyzer/Core/ExprEngineCXX.cpp

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133107. MaskRay marked 5 inline comments as done. MaskRay added a comment. LLVM Style Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 133108. juliehockett marked 27 inline comments as done. juliehockett edited the summary of this revision. juliehockett edited projects, added clang-tools-extra; removed clang. juliehockett added a comment. 1. Moved the tool to clang-tools-extra 1.

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: tools/clang-doc/ClangDoc.h:29 +struct ClangDocContext { + // Which format in which to emit representation. + OutFormat EmitFormat; sammccall wrote: > juliehockett wrote: > > sammccall wrote: > > > Is this the

[PATCH] D42645: New simple Checker for mmap calls

NoQ added a comment. > What I propose is "two" separated checkers one using same but the value of > PROT_EXEC will depend on the checker name e.g. security.MmapWriteExecGen vs > security.MmapWriteExecGlibc ... or by default we keep PROT_EXEC as is and we > would allow to override the value via

[PATCH] D41834: [Lex] Fix handling numerical literals ending with ' and signed exponent.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D41834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r324399 - Mark P0777 as complete

Author: marshall Date: Tue Feb 6 13:00:58 2018 New Revision: 324399 URL: http://llvm.org/viewvc/llvm-project?rev=324399=rev Log: Mark P0777 as complete Modified: libcxx/trunk/www/cxx2a_status.html Modified: libcxx/trunk/www/cxx2a_status.html URL:

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:142 - return StartMatcher + "((" + - llvm::join(EscapedAcronyms.begin(), EscapedAcronyms.end(), "|") + - ")[A-Z]?)?[a-z]+[a-z0-9]*([A-Z][a-z0-9]+)*" + "(" + -

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

benhamilton accepted this revision. benhamilton added inline comments. This revision is now accepted and ready to land. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:144 + "[A-Z]?)?[a-z]+[a-z0-9]*(" + + AcronymsGroupRegex(EscapedAcronyms, true) +

[libcxx] r324385 - Fix building libc++ with the macOS 10.13 SDK with -mmacosx-version-min=10.12 or lower.

Author: nico Date: Tue Feb 6 11:17:41 2018 New Revision: 324385 URL: http://llvm.org/viewvc/llvm-project?rev=324385=rev Log: Fix building libc++ with the macOS 10.13 SDK with -mmacosx-version-min=10.12 or lower. The 10.13 SDK always defines utimensat() (with an availability(macosx=10.13)

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

thakis added a comment. I went ahead and landed this with the comments requested by Duncan in r324385. (http://llvm.org/viewvc/llvm-project?view=revision=324385) I'm also quoting Duncan's email reply to my comment, since that's not showing up on phab: """ Using runtime availability checking

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE324407: Support special acronyms inside property names and allow plural forms (authored by Wizard, committed by ). Changed prior to commit: https://reviews.llvm.org/D42947?vs=133069=133071#toc

[libcxx] r324398 - Implement P0777: Treating unnecessay decay

Author: marshall Date: Tue Feb 6 12:56:55 2018 New Revision: 324398 URL: http://llvm.org/viewvc/llvm-project?rev=324398=rev Log: Implement P0777: Treating unnecessay decay Modified: libcxx/trunk/include/optional libcxx/trunk/include/tuple libcxx/trunk/include/type_traits

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

Wizard updated this revision to Diff 133069. Wizard added a comment. minor fix according to comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42947 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index:

[clang-tools-extra] r324389 - [clangd] Make the premble tremble.

Author: d0k Date: Tue Feb 6 12:08:23 2018 New Revision: 324389 URL: http://llvm.org/viewvc/llvm-project?rev=324389=rev Log: [clangd] Make the premble tremble. No functionality change. Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified:

[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:436-437 assert(Output.isNothing() && "Invalid output."); - if (Args.hasArg(options::OPT_g_Flag)) + if (mustEmitDebugInfo(Args) == FullDebug) CmdArgs.push_back("-g"); tra

[PATCH] D42942: [clangd] Collect definitions when indexing.

ioeric added inline comments. Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:67 + // XXX this is just to make running the tool fast during dev! + bool BeginInvocation(CompilerInstance ) override { +const auto =

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

Wizard updated this revision to Diff 133066. Wizard added a comment. resolve comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42947 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index:

[PATCH] D42983: [clang-tidy] Add `readability-simd-intrinsics` check.

MaskRay created this revision. Herald added subscribers: cfe-commits, hintonda, kristof.beyls, xazax.hun, mgorny, aemerson, klimek. Many architectures provide SIMD operations (e.g. x86 SSE/AVX, Power AltiVec/VSX, ARM NEON). It is common that SIMD code implementing the same algorithm, is written

[PATCH] D42573: [clangd] The new threading implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rL324356: [clangd] The new threading implementation (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42573 Files:

[clang-tools-extra] r324361 - [clangd] Fixed compilation on Windows buildbot.

Author: ibiryukov Date: Tue Feb 6 08:32:36 2018 New Revision: 324361 URL: http://llvm.org/viewvc/llvm-project?rev=324361=rev Log: [clangd] Fixed compilation on Windows buildbot. Modified: clang-tools-extra/trunk/unittests/clangd/ThreadingTests.cpp Modified:

[PATCH] D42640: [clangd] Prototype: collect symbol #include & insert #include in global code completion.

ioeric updated this revision to Diff 133021. ioeric marked 10 inline comments as done. ioeric added a comment. - Merge with origin/master - Renamed and moved a bunch files according to review comments. - Merge remote-tracking branch 'origin/master' into include - Half way - Merge with uri

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:50 +CheckFactories.registerCheck( +"modernize-avoid-functional"); CheckFactories.registerCheck( alexfh wrote: > aaron.ballman wrote: > > I'm not keen

[PATCH] D42964: [clangd] Add Revision field to Symbol.

hokein created this revision. hokein added reviewers: sammccall, ioeric. Herald added subscribers: jkorous-apple, ilya-biryukov, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42964 Files: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp

[PATCH] D42573: [clangd] The new threading implementation

ilya-biryukov updated this revision to Diff 133003. ilya-biryukov added a comment. - Addressed the last review comment Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42573 Files: clangd/CMakeLists.txt clangd/ClangdServer.h clangd/ClangdUnit.h clangd/ClangdUnitStore.cpp

[PATCH] D42972: Look for 32-bit libraries in /usr/lib32 for MIPS O32 on FreeBSD.

bsdjhb created this revision. Herald added subscribers: krytarowski, arichardson, sdardis, emaste. FreeBSD N64 MIPS systems can include 32-bit libraries for O32 in /usr/lib32 similar to the 32-bit compatibility libraries provided for FreeBSD/amd64 and FreeBSD/powerpc64. Repository: rC Clang

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

alexfh added inline comments. Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:50 +CheckFactories.registerCheck( +"modernize-avoid-functional"); CheckFactories.registerCheck( aaron.ballman wrote: > I'm not keen on this name -- it

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall added a comment. OK, I think this is good to go now. Rebased against Eric's URI change and added tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42813: [Debug] Annotate compiler generated range-for loop variables.

mattd added inline comments. Comment at: lib/Sema/SemaStmt.cpp:2346 +// Assume the variables are nested in the inner scope (loop body). +const auto DepthStr = std::to_string(S->getDepth() >> 1); VarDecl *BeginVar = BuildForRangeVarDecl(*this, ColonLoc, AutoType,

[PATCH] D42915: [clangd] Use URIs in index symbols.

ioeric updated this revision to Diff 133000. ioeric added a comment. - s/Uri/URI/ - Address review comments. Support multiple schemes. - Merged with origin/master - Merge branch 'master' of http://llvm.org/git/clang-tools-extra into uri Repository: rCTE Clang Tools Extra

[clang-tools-extra] r324356 - [clangd] The new threading implementation

Author: ibiryukov Date: Tue Feb 6 07:53:42 2018 New Revision: 324356 URL: http://llvm.org/viewvc/llvm-project?rev=324356=rev Log: [clangd] The new threading implementation Summary: In the new threading model clangd creates one thread per file to manage the AST and one thread to process each of

[PATCH] D32525: [clang-format] Add SpaceBeforeColon option

karies added a comment. Does this qualify? https://github.com/root-project/root/blob/master/.clang-format#L84 # You want this : enable it if you have https://reviews.llvm.org/D32525 # SpaceBeforeColon: false in ROOT's `.clang-format`. https://reviews.llvm.org/D32525

[PATCH] D42915: [clangd] Use URIs in index symbols.

ioeric updated this revision to Diff 133009. ioeric added a comment. - removed leftover logs. - Merge branch 'master' of http://llvm.org/git/clang-tools-extra into uri Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42915 Files: clangd/index/Index.cpp clangd/index/Index.h

[PATCH] D32525: [clang-format] Add SpaceBeforeColon option

djasper added a comment. No. The reason for us generally asking for a style guide is because it unambiguously clarifies the exact style that is to be preferred. Projects that don't have a style guide written down also often do not agree on what the style should be. That said, I think the

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

sabel83 marked an inline comment as done. sabel83 added inline comments. Comment at: include/clang/Driver/CC1Options.td:537 +def templight_dump : Flag<["-"], "templight-dump">, + HelpText<"Dump templight information to stdout">; def ast_dump_lookups : Flag<["-"],

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall updated this revision to Diff 133024. sammccall added a comment. Add tests for SymbolCollector (finding def/decl locations) and merge. Found some bugs in SymbolCollector's locations - added fixmes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42942 Files:

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

robot updated this revision to Diff 132990. robot added a comment. - Reformatted using clang-format - Fixed copy error CHECK(REAL(__cxa_throw)) - moved test from asan unit test to lit tests Repository: rCRT Compiler Runtime https://reviews.llvm.org/D42644 Files:

[clang-tools-extra] r324358 - [clangd] Use URIs in index symbols.

Author: ioeric Date: Tue Feb 6 08:10:35 2018 New Revision: 324358 URL: http://llvm.org/viewvc/llvm-project?rev=324358=rev Log: [clangd] Use URIs in index symbols. Reviewers: hokein, sammccall Reviewed By: sammccall Subscribers: klimek, ilya-biryukov, jkorous-apple, cfe-commits Differential

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 133010. devnexen added a comment. Will work on most modern Linux/Glibc versions, BSD variants and Illumos. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

sabel83 added a comment. This pull requests consists of two parts: a) a hook, which is called during template instantiation events b) a callback, which dumps the details of the events out to standard output Tools like Templight (https://github.com/mikael-s-persson/templight) rely on the hook.

[PATCH] D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF

compnerd added a comment. @jhenderson I believe that the first one is what this is implementing. I believe that adding the last two as a patch following this one is preferable as that is specific to the needs for PS4, but, both of those should be possible to accommodate. I would love to see

r324438 - Support `#pragma comment(lib, "name")` in the frontend for ELF

Author: compnerd Date: Tue Feb 6 17:46:46 2018 New Revision: 324438 URL: http://llvm.org/viewvc/llvm-project?rev=324438=rev Log: Support `#pragma comment(lib, "name")` in the frontend for ELF This adds the frontend support required to support the use of the comment pragma to enable auto linking

r324439 - AST: support SwiftCC on MS ABI

Author: compnerd Date: Tue Feb 6 17:55:08 2018 New Revision: 324439 URL: http://llvm.org/viewvc/llvm-project?rev=324439=rev Log: AST: support SwiftCC on MS ABI Microsoft has reserved the identifier 'S' as the swift calling convention. Decorate the symbols appropriately. This enables swift on

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133120. MaskRay added a comment. if (!Result.Context->getLangOpts().CPlusPlus11) return; Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D42768: AST: support SwiftCC on MS ABI

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, ship it :) Repository: rC Clang https://reviews.llvm.org/D42768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133126. MaskRay added a comment. docs/ReleaseNotes.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

timshen added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:22 + +static StringRef CheckPPC(StringRef Name) { + if (Name.startswith("vec_")) "Check" usually indicates to return a bool, but what it actually returns is a possible

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

timshen added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:34 +// [simd.binary] +{"add", "std::experimental::simd::operator+"}, +{"sub", "std::experimental::simd::operator-"}, Technically,

[PATCH] D42719: [CFG] [analyzer] Add construction context when constructor is wrapped into ExprWithCleanups.

NoQ updated this revision to Diff 133142. NoQ added a comment. Rebase. https://reviews.llvm.org/D42719 Files: lib/Analysis/CFG.cpp test/Analysis/cfg-rich-constructors.cpp test/Analysis/temp-obj-dtors-cfg-output.cpp Index: test/Analysis/temp-obj-dtors-cfg-output.cpp

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 133116. vitalybuka added a comment. set triple https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp clang/test/CodeGen/thinlto_backend.ll Index:

[PATCH] D42606: [Coroutines] Use allocator overload when available

modocache updated this revision to Diff 133129. modocache added a comment. Prevent coroutine parameter stores from being moved, rely on https://reviews.llvm.org/D43000 instead. Repository: rC Clang https://reviews.llvm.org/D42606 Files: lib/Sema/SemaCoroutine.cpp

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

timshen added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:24 + if (Name.startswith("vec_")) +Name = Name.substr(4); + else Can you either find or create a wrapper for this? bool StripPrefix(StringRef Prefix, StringRef& S)

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133134. MaskRay marked 2 inline comments as done. MaskRay added a comment. Warning messages of operator+ as operator+ operator- .. are free functions on simd objects. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files:

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133133. MaskRay marked an inline comment as done. MaskRay added a comment. docs/ReleaseNotes.rst and use StringRef::consume_front Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt

[PATCH] D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF

compnerd closed this revision. compnerd added a comment. SVN r324438 Repository: rC Clang https://reviews.llvm.org/D42758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42768: AST: support SwiftCC on MS ABI

compnerd closed this revision. compnerd added a comment. SVN r324439 Repository: rC Clang https://reviews.llvm.org/D42768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42995: [ThinLTO] Ignore object files with empty ThinLTO index

tejohnson added a comment. > Empty ThinLTOIndexFile signals that we don't need this module during > linking. Not the only case actually. We now also pass an empty index file when we want to compile the bitcode down to object without applying any LTO optimization (there are a few cases where

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ updated this revision to Diff 133139. NoQ added a comment. Make CFGConstructor a sub-class of CFGStmt. I failed to notice any compile time regressions for now; if any, they must be super bottlenecked on CFG construction or analysis-based warnings. After poking @rsmith in the chat a little

[PATCH] D42995: [ThinLTO] Ignore object files with empty ThinLTO index

vitalybuka created this revision. vitalybuka added reviewers: pcc, tejohnson. Herald added subscribers: eraman, inglorion, mehdi_amini. Empty ThinLTOIndexFile signals that we don't need this module during linking. So we should not run ThinLTO backend even if it contains the ThinLTO module.

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:97 +- New `readability-simd-intrinsics + `_ check Please move it new checks section. Repository: rCTE

[clang-tools-extra] r324441 - test: use target triple for the test

Author: compnerd Date: Tue Feb 6 18:27:34 2018 New Revision: 324441 URL: http://llvm.org/viewvc/llvm-project?rev=324441=rev Log: test: use target triple for the test Now that `pragma comment` is also used on ELF-ish targets with a restricted set of options, we need to specify the full target

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

timshen added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:24 + if (Name.startswith("vec_")) +Name = Name.substr(4); + else timshen wrote: > Can you either find or create a wrapper for this? > > bool StripPrefix(StringRef

Re: r324439 - AST: support SwiftCC on MS ABI

On Tue, Feb 6, 2018 at 5:55 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Tue Feb 6 17:55:08 2018 > New Revision: 324439 > > URL: http://llvm.org/viewvc/llvm-project?rev=324439=rev > Log: > AST: support SwiftCC on MS ABI > > Microsoft has

[PATCH] D42606: [Coroutines] Use allocator overload when available

modocache updated this revision to Diff 133154. modocache added a comment. Update the tests to work with scalar parameter copies. Repository: rC Clang https://reviews.llvm.org/D42606 Files: lib/Sema/SemaCoroutine.cpp test/CodeGenCoroutines/coro-alloc.cpp

[PATCH] D42933: [Sema] Avoid -Wformat warning for NSInteger/NSUInteger 'int' values with %zu/%zi long specifiers

compnerd added a comment. @aaron.ballman, yeah, I believe that the warning is working as intended, it just so happens that at runtime things just happened to work out. Repository: rC Clang https://reviews.llvm.org/D42933 ___ cfe-commits mailing

[PATCH] D42987: [libc++abi] fix compilation in C++17 mode

mclow.lists added a comment. I'm fine with this, though I wonder if using the more specific `_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS` might be a better thing to define. Repository: rCXXA libc++abi https://reviews.llvm.org/D42987 ___

[PATCH] D40903: [Sanitizers] Basic Solaris sanitizer support (PR 33274)

ro added a comment. In https://reviews.llvm.org/D40903#998474, @alekseyshl wrote: > Rainer, check https://reviews.llvm.org/rC324302 out, you probably want to add > test cases for Solaris to test/Driver/sanitizer-ld.c too. Sorry about that! I certainly will, but it'll be some time because I'm

r324338 - Test commit - fixing a comment.

Author: jolesiak Date: Tue Feb 6 04:12:00 2018 New Revision: 324338 URL: http://llvm.org/viewvc/llvm-project?rev=324338=rev Log: Test commit - fixing a comment. Summary: A test commit. Reviewers: krasimir, benhamilton Reviewed By: krasimir Subscribers: klimek, cfe-commits Differential

[PATCH] D42561: [PR36008] Avoid -Wsign-compare warning for enum constants in typeof expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, aside from a minor commenting nit. Comment at: lib/Sema/SemaChecking.cpp:8960 +// Avoid warning about comparison of integers with different signs

r324201 - Recommit rL323890: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions

Author: dfukalov Date: Sun Feb 4 14:32:07 2018 New Revision: 324201 URL: http://llvm.org/viewvc/llvm-project?rev=324201=rev Log: Recommit rL323890: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions Fixed asserts in tests. Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def

[PATCH] D42933: [Sema] Avoid -Wformat warning for NSInteger/NSUInteger 'int' values with %zu/%zi long specifiers

aaron.ballman added a comment. It sounds to me like the check is working as designed and that the user code was already broken, but it happened to work at runtime because the stars aligned properly for the user. Am I misunderstanding something? Repository: rC Clang

r324342 - Unittests misc. typos

Author: sylvestre Date: Tue Feb 6 05:12:29 2018 New Revision: 324342 URL: http://llvm.org/viewvc/llvm-project?rev=324342=rev Log: Unittests misc. typos By luz.paz Modified: cfe/trunk/unittests/Format/CleanupTest.cpp cfe/trunk/unittests/Rename/RenameMemberTest.cpp

[PATCH] D41242: [Solaris] Silence -pthread warning on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rC324344: [Solaris] Silence -pthread warning on Solaris (authored by fedor.sergeev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41242 Files: lib/Driver/ToolChains/Solaris.cpp

r324344 - [Solaris] Silence -pthread warning on Solaris

Author: fedor.sergeev Date: Tue Feb 6 05:21:12 2018 New Revision: 324344 URL: http://llvm.org/viewvc/llvm-project?rev=324344=rev Log: [Solaris] Silence -pthread warning on Solaris Summary: During make check-all on Solaris, I see several instances of this warning: clang-6.0: warning: argument

[PATCH] D42957: [clang-format] Do not break before long string literals in protos

krasimir updated this revision to Diff 132978. krasimir added a comment. - Update comment Repository: rC Clang https://reviews.llvm.org/D42957 Files: lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestProto.cpp

[PATCH] D42573: [clangd] The new threading implementation

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This is really great. Just one test nit. Comment at: unittests/clangd/ThreadingTests.cpp:34 + +scheduleIncrements(); +Tasks.waitForAll(); The

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

miyuki updated this revision to Diff 132974. miyuki added a comment. Removed the changes that are unrelated to the 'enum->float' case from the test. https://reviews.llvm.org/D42545 Files: lib/Sema/SemaOverload.cpp test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp Index:

[libcxx] r324345 - Merging r324153:

Author: hans Date: Tue Feb 6 05:22:33 2018 New Revision: 324345 URL: http://llvm.org/viewvc/llvm-project?rev=324345=rev Log: Merging r324153: r324153 | ericwf | 2018-02-02 23:39:59 +0100 (Fri, 02 Feb 2018) | 6 lines Fix

Re: [libcxx] r324153 - Fix has_unique_object_representation after Clang commit r324134.

Merged to 6.0 in r324345. On Fri, Feb 2, 2018 at 11:39 PM, Eric Fiselier via cfe-commits wrote: > Author: ericwf > Date: Fri Feb 2 14:39:59 2018 > New Revision: 324153 > > URL: http://llvm.org/viewvc/llvm-project?rev=324153=rev > Log: > Fix

[PATCH] D42957: [clang-format] Do not break before long string literals in protos

krasimir created this revision. Herald added subscribers: cfe-commits, klimek. This patch is a follow-up to r323319 (which disables string literal breaking for text protos) and it disables breaking before long string literals. For example this: key: "long string literal" used to get

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: clang-tidy/modernize/AvoidFunctionalCheck.h:19 + +/// Check for several deprecated types and classes from header +/// aaron.ballman wrote: >

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall updated this revision to Diff 132985. sammccall marked 3 inline comments as done. sammccall added a comment. [clangd] Prefer data from TUs with symbol defn to data from TUs without. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42942 Files:

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall added a comment. Thanks for comments! (Still not done, adding tests) Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:67 + // XXX this is just to make running the tool fast during dev! + bool BeginInvocation(CompilerInstance ) override {

[PATCH] D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF

jhenderson added a comment. In https://reviews.llvm.org/D42758#997880, @erichkeane wrote: > I'd like to see @probinson s PS4 discussion bottom out, but I don't see any > reason to hold this up otherwise. The PS4 compiler uses its linker options mechanism to communicate three different things

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. A few comments were not applied, and I'd like a more descriptive name for the check (especially if we plan to generalize this). Comment at:

<    1   2   3   >