[PATCH] D43547: [NameMangling] Make ASTContext owning the ManglingContext during entire compilation

pacxx created this revision. pacxx added reviewers: rnk, rsmith. Herald added a subscriber: cfe-commits. The ASTContext is only used to create a Mangling Context and forwards ownership to everyone who requests a ManglingContext. The problem fixed by this commit is located in the handling of the

[PATCH] D43497: [analyzer] Introduce correct lifetime extension behavior in simple cases.

a.sidorin accepted this revision. a.sidorin added a comment. Thank you! Just some of nits inline. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:394 + +bool ExprEngine::areTemporaryMaterializationsClear( +ProgramStateRef State, const LocationContext *FromLC,

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

This revision was automatically updated to reflect the committed changes. Closed by commit rC325668: [Sema] Classify conversions from enum to float as narrowing (authored by miyuki, committed by ). Repository: rC Clang https://reviews.llvm.org/D42545 Files: lib/Sema/SemaOverload.cpp

r325678 - [ASTMatchers] isTemplateInstantiation: also match explicit instantiation declaration.

Author: ioeric Date: Wed Feb 21 05:51:27 2018 New Revision: 325678 URL: http://llvm.org/viewvc/llvm-project?rev=325678=rev Log: [ASTMatchers] isTemplateInstantiation: also match explicit instantiation declaration. Summary: Example: template class X {}; class A {}; // Explicit instantiation

[PATCH] D43550: [clangd] Not collect include headers for dynamic index for now.

ioeric created this revision. ioeric added reviewers: ilya-biryukov, sammccall, hokein. Herald added subscribers: cfe-commits, jkorous-apple, klimek. The new behaviors introduced by this patch: o When include collection is enabled, we always set IncludeHeader field in Symbol even if it's the

[PATCH] D43569: [clangd] Correct setting ignoreWarnings in CodeCompletion.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: ioeric, jkorous-apple, klimek. We should set the flag before creating ComplierInstance -- when CopmilerInstance gets initialized, it also initializes the DiagnosticsEngine using the DiagnosticOptions.

[PATCH] D43550: [clangd] Not collect include headers for dynamic index for now.

ioeric added a comment. In https://reviews.llvm.org/D43550#1014319, @ilya-biryukov wrote: > Is there a way to still enable include insertion but in a restricted manner, > e.g. only for the current project? I'm not sure if this is currently supported, as we don't have a good definition of a

[PATCH] D43567: [ASTMatchers] isTemplateInstantiation: also match explicit instantiation declaration.

This revision was automatically updated to reflect the committed changes. Closed by commit rL325678: [ASTMatchers] isTemplateInstantiation: also match explicit instantiation… (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D43570: [OpenCL] Add '-cl-uniform-work-group-size' compile option

krisb created this revision. Herald added subscribers: cfe-commits, Anastasia, yaxunl. krisb added reviewers: yaxunl, Anastasia. OpenCL 2.0 specification defines '-cl-uniform-work-group-size' option, which requires that the global work-size be a multiple of the work-group size specified to

Re: r325678 - [ASTMatchers] isTemplateInstantiation: also match explicit instantiation declaration.

Oops, I only saw this after landing the patch. I'll send another one to update the doc. Sorry about that! On Wed, Feb 21, 2018 at 2:54 PM Aaron Ballman wrote: > On Wed, Feb 21, 2018 at 8:51 AM, Eric Liu via cfe-commits > wrote: > > Author:

Re: r325678 - [ASTMatchers] isTemplateInstantiation: also match explicit instantiation declaration.

On Wed, Feb 21, 2018 at 8:56 AM, Eric Liu wrote: > Oops, I only saw this after landing the patch. I'll send another one to > update the doc. Sorry about that! No worries! I didn't see the patch until after the commit anyway. Thanks for taking care of it! ~Aaron > > On Wed,

[PATCH] D42645: New simple Checker for mmap calls

emaste added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419 +// Operating systems specific PROT_READ/PROT_WRITE values is not implemented, +// thus ought to be overriden with the proper analyser-config variables +// remain in alpha until

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

emaste accepted this revision. emaste added a comment. In https://reviews.llvm.org/D43378#1010574, @devnexen wrote: > As I see only x86_64 arch implements everything (e.g. custom event), making > things easier maybe. arm family might be enabled, power pc might need to > rewrite as x86_64 arch

[PATCH] D43550: [clangd] Not collect include headers for dynamic index for now.

ioeric added inline comments. Comment at: clangd/index/FileIndex.cpp:18 -const CanonicalIncludes *canonicalIncludesForSystemHeaders() { - static const auto *Includes = [] { ilya-biryukov wrote: > Should we also remove the mutex from `CanonicalIncludes` now? I

[PATCH] D43550: [clangd] Not collect include headers for dynamic index for now.

ioeric updated this revision to Diff 135244. ioeric marked 2 inline comments as done. ioeric added a comment. Properly use toURI. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43550 Files: clangd/CodeComplete.cpp clangd/index/FileIndex.cpp clangd/index/Index.h

[PATCH] D42645: New simple Checker for mmap calls

devnexen added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419 +// Operating systems specific PROT_READ/PROT_WRITE values is not implemented, +// thus ought to be overriden with the proper analyser-config variables +// remain in alpha until

Re: r325678 - [ASTMatchers] isTemplateInstantiation: also match explicit instantiation declaration.

On Wed, Feb 21, 2018 at 8:51 AM, Eric Liu via cfe-commits wrote: > Author: ioeric > Date: Wed Feb 21 05:51:27 2018 > New Revision: 325678 > > URL: http://llvm.org/viewvc/llvm-project?rev=325678=rev > Log: > [ASTMatchers] isTemplateInstantiation: also match explicit

[PATCH] D43572: [Sema] Improve test coverage of narrowing conversion diagnostics

miyuki created this revision. miyuki added reviewers: faisalv, rsmith. This patch adds tests of narrowing conversion diagnostics for the 'unscoped enum -> integer' case.q https://reviews.llvm.org/D43572 Files: test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp Index:

r325682 - [ASTMatchers] Regenerate documentation after r325678

Author: ioeric Date: Wed Feb 21 06:22:42 2018 New Revision: 325682 URL: http://llvm.org/viewvc/llvm-project?rev=325682=rev Log: [ASTMatchers] Regenerate documentation after r325678 Modified: cfe/trunk/docs/LibASTMatchersReference.html Modified: cfe/trunk/docs/LibASTMatchersReference.html

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule added a comment. In https://reviews.llvm.org/D43500#1013558, @malcolm.parsons wrote: > In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote: > > > Is there a way to make clang-apply-replacements smarter rather than forcing > > every check to jump through hoops? I'm worried

[PATCH] D43579: [libcxx] Do not include the C math.h header before __config

mclow.lists added inline comments. Comment at: include/math.h:1499 +// has previously been included. +#if defined(_LIBCPP_MSVCRT) && defined(_USE_MATH_DEFINES) +#include_next pcc wrote: > Nit: you don't actually need the ` && defined(_USE_MATH_DEFINES)` part. I

[PATCH] D43423: [SimplifyCFG] Create flag to disable simplifyCFG.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:6056 SmallPtrSetImpl *LoopHeaders) { + const Function *Fn = BB->getParent(); + if (Fn && Fn->getMetadata("no_simplify_cfg")) So maybe

[PATCH] D41102: Setup clang-doc frontend framework

jakehehrlich added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:407 + +void ClangDocBinaryWriter::writeBitstream(const EnumInfo , + BitstreamWriter , juliehockett wrote: > jakehehrlich wrote: > > lebedev.ri

Re: r324308 - Fix crash on invalid.

Hi Hans, If there's still time for rc3, I'd like to get this crash fix in. This adds a null check to prevent a crash on invalid. Richard On Mon, Feb 5, 2018 at 6:58 PM, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Mon Feb 5 18:58:21 2018 > New

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

aaron.ballman added a comment. In https://reviews.llvm.org/D43500#1015208, @jdemeule wrote: > In https://reviews.llvm.org/D43500#1013558, @malcolm.parsons wrote: > > > In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote: > > > > > Is there a way to make clang-apply-replacements

[PATCH] D43598: [clang-format] Tidy up new API guessLanguage()

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Thank you for doing these follow up changes! Repository: rC Clang https://reviews.llvm.org/D43598 ___ cfe-commits mailing list

[PATCH] D43602: [CUDA] Added missing functions.

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. For my information, how are we verifying that we've caught everything? https://reviews.llvm.org/D43602 ___ cfe-commits mailing list

[PATCH] D43579: [libcxx] Do not include the C math.h header before __config

pcc added inline comments. Comment at: include/math.h:1499 +// has previously been included. +#if defined(_LIBCPP_MSVCRT) && defined(_USE_MATH_DEFINES) +#include_next Nit: you don't actually need the ` && defined(_USE_MATH_DEFINES)` part.

[PATCH] D43522: [clang-format] New API guessLanguage()

benhamilton added inline comments. Comment at: cfe/trunk/lib/Format/Format.cpp:2308 + Guesser.process(); + if (Guesser.isObjC()) { +result = FormatStyle::LK_ObjC; djasper wrote: > benhamilton wrote: > > djasper wrote: > > > In LLVM, we

[PATCH] D43602: [CUDA] Added missing functions.

tra created this revision. tra added a reviewer: jlebar. Herald added a subscriber: sanjoy. Initial commit missed sincos(float), llabs() and few atomics that we used to pull in from device_functions.hpp, which we no longer include. https://reviews.llvm.org/D43602 Files:

[PATCH] D43522: [clang-format] New API guessLanguage()

djasper added inline comments. Comment at: cfe/trunk/lib/Format/Format.cpp:2308 + Guesser.process(); + if (Guesser.isObjC()) { +result = FormatStyle::LK_ObjC; benhamilton wrote: > djasper wrote: > > In LLVM, we generally don't add braces for

[PATCH] D43602: [CUDA] Added missing functions.

tra updated this revision to Diff 135348. tra added a comment. Added missing __threadfence_system(). https://reviews.llvm.org/D43602 Files: clang/lib/Headers/__clang_cuda_device_functions.h Index: clang/lib/Headers/__clang_cuda_device_functions.h

[PATCH] D42503: libcxx: Unbreak external thread library configuration.

eastig added a comment. Just validated that it has fixed the issue. Thank you, Peter. Repository: rCXX libc++ https://reviews.llvm.org/D42503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r325733 - [Driver] Generate .eh_frame_hdr for static executables too.

Author: danalbert Date: Wed Feb 21 14:36:51 2018 New Revision: 325733 URL: http://llvm.org/viewvc/llvm-project?rev=325733=rev Log: [Driver] Generate .eh_frame_hdr for static executables too. Summary: libgcc won't unwind without an .eh_frame_hdr section. Reviewers: srhines, chandlerc Reviewed

[PATCH] D43203: [Driver] Generate .eh_frame_hdr for static executables too.

This revision was automatically updated to reflect the committed changes. Closed by commit rC325733: [Driver] Generate .eh_frame_hdr for static executables too. (authored by danalbert, committed by ). Changed prior to commit: https://reviews.llvm.org/D43203?vs=133907=135336#toc Repository:

[PATCH] D43522: [clang-format] New API guessLanguage()

benhamilton added a comment. Follow-ups (aside from the case, which I already fixed) in https://reviews.llvm.org/D43598. Repository: rL LLVM https://reviews.llvm.org/D43522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43598: [clang-format] Tidy up new API guessLanguage()

benhamilton created this revision. benhamilton added a reviewer: djasper. Herald added subscribers: cfe-commits, klimek. This fixes a few issues djasper@ brought up in his review of https://reviews.llvm.org/D43522. Test Plan: make -j12 FormatTests &&

r325753 - [NFC] fix trivial typos in comments

Author: inouehrs Date: Wed Feb 21 23:49:13 2018 New Revision: 325753 URL: http://llvm.org/viewvc/llvm-project?rev=325753=rev Log: [NFC] fix trivial typos in comments "a a"->"a" Modified: cfe/trunk/include/clang/Sema/ScopeInfo.h cfe/trunk/test/SemaCXX/ms-uuid.cpp Modified:

[PATCH] D43602: [CUDA] Added missing functions.

tra added a comment. In https://reviews.llvm.org/D43602#1015370, @jlebar wrote: > For my information, how are we verifying that we've caught everything? for v in 8.0 9.0 9.1 ; do /usr/local/cuda-$v/bin/nvcc -c -x cu /dev/null -o /tmp/null.o -arch=sm_60 -keep-dir=nvcc-$v -keep -v

[PATCH] D43273: [libcxx] [test] Fix MSVC warnings and errors.

STL_MSFT updated this revision to Diff 135352. STL_MSFT added a comment. Update based on code review feedback. https://reviews.llvm.org/D43273 Files: test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp

[libcxx] r325740 - Add another test case to the deduction guide for basic_string.

Author: marshall Date: Wed Feb 21 21:14:20 2018 New Revision: 325740 URL: http://llvm.org/viewvc/llvm-project?rev=325740=rev Log: Add another test case to the deduction guide for basic_string. Modified: libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.pass.cpp

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 135342. juliehockett marked 6 inline comments as done. juliehockett added a comment. Updating location creation and adding mapping from type to BlockId https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:407 + +void ClangDocBinaryWriter::writeBitstream(const EnumInfo , + BitstreamWriter , jakehehrlich wrote: > lebedev.ri wrote: > > juliehockett

[PATCH] D43547: [NameMangling] Make ASTContext owning the ManglingContext during entire compilation

rnk added a comment. Can you update the description to clarify that this is fixing a bug in the indexing library? From the description it sounds like we have a serious bug in FUNCDNAME codegen, which is not the case. CodeGen does the right thing. The ASTContext API is just crappy, so the Index

[PATCH] D42498: [ExprConstant] Fix crash when initialize an indirect field with another field.

vsapsai added a comment. Thanks for response, Richard. I'll look into using `CXXDefaultInitExpr`. As for In https://reviews.llvm.org/D42498#1007028, @rsmith wrote: > […] your approach will still go wrong if the `This` pointer is used in other > ways, such as an explicit mention of `this` or a

r325746 - FreeBSD driver / Xray flags moving pthread to compile flags.

Author: kamil Date: Wed Feb 21 22:31:40 2018 New Revision: 325746 URL: http://llvm.org/viewvc/llvm-project?rev=325746=rev Log: FreeBSD driver / Xray flags moving pthread to compile flags. Summary: - Using -lpthread instead, with -pthread the linkage does not work. -Warning about the

r325748 - Revert part of r. 325746 D43378

Author: kamil Date: Wed Feb 21 22:48:34 2018 New Revision: 325748 URL: http://llvm.org/viewvc/llvm-project?rev=325748=rev Log: Revert part of r. 325746 D43378 test/Driver/XRay/xray-shared-noxray.cpp fails on !Linux hosts. Modified: cfe/trunk/test/Driver/XRay/xray-shared-noxray.cpp

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

krytarowski added inline comments. Comment at: cfe/trunk/test/Driver/XRay/xray-shared-noxray.cpp:11 // -// REQUIRES: linux, enable_shared +// REQUIRES: enable_shared int foo() { return 42; } ``` FAIL: Clang :: Driver/XRay/xray-shared-noxray.cpp (6820 of 38122)

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

krytarowski added inline comments. Comment at: cfe/trunk/test/Driver/XRay/xray-instrument-os.c:2 // RUN: not %clang -o /dev/null -v -fxray-instrument -c %s -// XFAIL: -linux- // REQUIRES-ANY: amd64, x86_64, x86_64h, arm, aarch64, arm64 ```

r325749 - Revert part of D43378 in this file

Author: kamil Date: Wed Feb 21 23:00:29 2018 New Revision: 325749 URL: http://llvm.org/viewvc/llvm-project?rev=325749=rev Log: Revert part of D43378 in this file It causes failure on clang-x86_64-debian-fast. Modified: cfe/trunk/test/Driver/XRay/xray-instrument-os.c Modified:

[PATCH] D43606: [Driver] Add SafeStack to a map of incompatible sanitizers

phosek created this revision. phosek added reviewers: kcc, vitalybuka. Herald added a subscriber: cfe-commits. This allows reporting an error when user tries to use SafeStack with incompatible sanitizers. Repository: rC Clang https://reviews.llvm.org/D43606 Files:

r325741 - [ODRHash] Handle some template weirdness.

Author: rtrieu Date: Wed Feb 21 21:32:25 2018 New Revision: 325741 URL: http://llvm.org/viewvc/llvm-project?rev=325741=rev Log: [ODRHash] Handle some template weirdness. Build the index off of DeclarationName instead of Decl pointers. When finding an UnresolvedLookupExprClass, hash it as if it

r325742 - [ODRHash] Fix hashing for friend functions.

Author: rtrieu Date: Wed Feb 21 21:50:29 2018 New Revision: 325742 URL: http://llvm.org/viewvc/llvm-project?rev=325742=rev Log: [ODRHash] Fix hashing for friend functions. When hashing a templated function, use the hash of the function it was instantiated from. Added:

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

This revision was automatically updated to reflect the committed changes. Closed by commit rL325746: FreeBSD driver / Xray flags moving pthread to compile flags. (authored by kamil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 135258. devnexen added a comment. Rephrasing Checkers.td comment https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp

[PATCH] D43522: [clang-format] New API guessLanguage()

This revision was automatically updated to reflect the committed changes. Closed by commit rC325691: [clang-format] New API guessLanguage() (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D43522?vs=135121=135261#toc Repository: rC Clang

[PATCH] D43522: [clang-format] New API guessLanguage()

This revision was automatically updated to reflect the committed changes. Closed by commit rL325691: [clang-format] New API guessLanguage() (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43522 Files:

[PATCH] D43579: [libcxx] Do not include the C math.h header before __config

miyuki created this revision. miyuki added a reviewer: mclow.lists. Herald added a reviewer: EricWF. Certain C libraries require configuration macros defined in __config to provide the correct functionality for libc++. This patch ensures that the C header math.h is always included after the

[PATCH] D43579: [libcxx] Do not include the C math.h header before __config

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This LGTM. https://reviews.llvm.org/D43579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a few additional test cases. It'd be nice if the style guide linked actually described what a "good" prefix is rather than make the reader guess.

[PATCH] D42645: New simple Checker for mmap calls

devnexen added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419 +// Operating systems specific PROT_READ/PROT_WRITE values is not implemented, +// thus ought to be overriden with the proper analyser-config variables +// remain in alpha until

[PATCH] D16403: Add scope information to CFG

szepet added a comment. In https://reviews.llvm.org/D16403#1011218, @NoQ wrote: > Yeah, i mean, like, if we change the scope markers to also appear even when > no variables are present in the scope, then it would be possible to replace > loop markers with some of the scope markers, right?

[PATCH] D42645: New simple Checker for mmap calls

emaste added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419 +// Operating systems specific PROT_READ/PROT_WRITE values is not implemented, +// thus ought to be overriden with the proper analyser-config variables +// remain in alpha until

r325691 - [clang-format] New API guessLanguage()

Author: benhamilton Date: Wed Feb 21 07:54:31 2018 New Revision: 325691 URL: http://llvm.org/viewvc/llvm-project?rev=325691=rev Log: [clang-format] New API guessLanguage() Summary: For clients which don't have a filesystem, calling getStyle() doesn't make much sense (there's no .clang-format

[PATCH] D43570: [OpenCL] Add '-cl-uniform-work-group-size' compile option

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang https://reviews.llvm.org/D43570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3505 +if (AS != LangAS::Default && AS != LangAS::opencl_private && +AS != CGM.getASTAllocaAddressSpace()) + Flag = CallArg::ByValArgNeedsCopy; This is an odd condition. What are

r325692 - Remove use of the 'gmlt' term from the -fsplit-dwarf-inlining flag description to make it more readily legible

Author: dblaikie Date: Wed Feb 21 08:00:50 2018 New Revision: 325692 URL: http://llvm.org/viewvc/llvm-project?rev=325692=rev Log: Remove use of the 'gmlt' term from the -fsplit-dwarf-inlining flag description to make it more readily legible Modified:

[PATCH] D42366: [CodeGen] Fix generation of TBAA tags for may-alias accesses

rjmccall added a comment. In https://reviews.llvm.org/D42366#1014157, @kosarev wrote: > I think zero would serve better as the unknown-size value. People who are not > aware of TBAA internals would guess that since zero-sized accesses make no > sense, they are likely to have some special

r325693 - [analyzer] Prevent AnalyzerStatsChecker from crash

Author: szepet Date: Wed Feb 21 08:06:56 2018 New Revision: 325693 URL: http://llvm.org/viewvc/llvm-project?rev=325693=rev Log: [analyzer] Prevent AnalyzerStatsChecker from crash The checker marks the locations where the analyzer creates sinks. However, it can happen that the sink was created

[PATCH] D42266: [analyzer] Prevent AnalyzerStatsChecker from crash

This revision was automatically updated to reflect the committed changes. Closed by commit rC325693: [analyzer] Prevent AnalyzerStatsChecker from crash (authored by szepet, committed by ). Changed prior to commit: https://reviews.llvm.org/D42266?vs=130501=135266#toc Repository: rC Clang

[clang-tools-extra] r325694 - [clangd] Update canonical header mapping for STL

Author: ioeric Date: Wed Feb 21 08:17:25 2018 New Revision: 325694 URL: http://llvm.org/viewvc/llvm-project?rev=325694=rev Log: [clangd] Update canonical header mapping for STL Modified: clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp Modified:

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 

stephanemoore created this revision. Herald added a subscriber: cfe-commits. The current Objective-C global variable declaration check restricts naming that is permitted by the Objective-C style guide. The Objective-C style guide states the following: "Global and file scope constants should

[PATCH] D40731: Integrate CHash into CLang

stettberger updated this revision to Diff 135227. stettberger added a comment. Rebased to HEAD, Run (external) clang-hash testsuite and ASTTest Repository: rC Clang https://reviews.llvm.org/D40731 Files: include/clang/AST/AttrDataCollectors.td include/clang/AST/CHashVisitor.h

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark updated this revision to Diff 135229. simark added a comment. New version Address comments in https://reviews.llvm.org/D39571#1014237 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D39571 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark marked an inline comment as done. simark added inline comments. Comment at: unittests/clangd/ClangdTests.cpp:492 + + EXPECT_TRUE(DiagConsumer.contains(FooCpp)); + EXPECT_TRUE(DiagConsumer.contains(BarCpp)); simark wrote: > ilya-biryukov wrote: > > Maybe

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark marked 5 inline comments as done. simark added inline comments. Comment at: unittests/clangd/ClangdTests.cpp:492 + + EXPECT_TRUE(DiagConsumer.contains(FooCpp)); + EXPECT_TRUE(DiagConsumer.contains(BarCpp)); ilya-biryukov wrote: > Maybe expose a copy of

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:23-25 + // if (const auto *D = Node.getDefinition()) { + // return D->getExplicitVisibility(NamedDecl::VisibilityForType) == V; + // } Can remove these comments.

[PATCH] D43518: [clangd] Allow embedders some control over when diagnostics are generated.

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.h:282 scheduleReparseAndDiags(PathRef File, VersionedDraft Contents, + WantDiagnostics, Tagged TaggedFS); Maybe add a

Re: r325655 - [X86] Disable CLWB in Cannon Lake

Merged to 6.0 in r325672. On Wed, Feb 21, 2018 at 1:16 AM, Craig Topper via cfe-commits wrote: > Author: ctopper > Date: Tue Feb 20 16:16:50 2018 > New Revision: 325655 > > URL: http://llvm.org/viewvc/llvm-project?rev=325655=rev > Log: > [X86] Disable CLWB in Cannon

[PATCH] D43550: [clangd] Not collect include headers for dynamic index for now.

ilya-biryukov added a comment. Is there a way to still enable include insertion but in a restricted manner, e.g. only for the current project? File of canonical declaration is usually a pretty good guess and it would be nice to have it. Maybe we could allowing to disable the include insertion

[PATCH] D43567: [ASTMatchers] isTemplateInstantiation: also match explicit instantiation declaration.

ioeric created this revision. ioeric added a reviewer: bkramer. Herald added subscribers: cfe-commits, klimek. Example: template class X {}; class A {}; // Explicit instantiation declaration. extern template class X; Repository: rC Clang https://reviews.llvm.org/D43567 Files:

[PATCH] D42366: [CodeGen] Fix generation of TBAA tags for may-alias accesses

kosarev added a comment. I think zero would serve better as the unknown-size value. People who are not aware of TBAA internals would guess that since zero-sized accesses make no sense, they are likely to have some special meaning. Similarly, for code that is supposed to process the size fields

[PATCH] D43533: [CFG] [analyzer] NFC: Refactor ConstructionContext into a finite set of cases.

a.sidorin accepted this revision. a.sidorin added inline comments. Comment at: include/clang/Analysis/ConstructionContext.h:119 + static const ConstructionContext * + finalize(BumpVectorContext , const ConstructionContextLayer *TopLayer); + Maybe just

[PATCH] D42645: New simple Checker for mmap calls

a.sidorin accepted this revision. a.sidorin added a comment. Looks good to me as an 'alpha' checker. Thank you David! I'd prefer this patch to be accepted by somebody else as well before committing it. https://reviews.llvm.org/D42645 ___

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. I've already added hints in this patch and it also do not add extra completions unless the flag IncludeCorrections is set. So this will not force editors to use corrections. Did you mean that you think it's good to have extra fixit hints even if this flag is not set?

r325668 - [Sema] Classify conversions from enum to float as narrowing

Author: miyuki Date: Wed Feb 21 02:08:18 2018 New Revision: 325668 URL: http://llvm.org/viewvc/llvm-project?rev=325668=rev Log: [Sema] Classify conversions from enum to float as narrowing Summary: According to [dcl.init.list]p7: A narrowing conversion is an implicit conversion - ... - from

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

ilya-biryukov added inline comments. Comment at: unittests/clangd/ClangdTests.cpp:83 +// least one error. +class MultipleErrorCHeckingDiagConsumer : public DiagnosticsConsumer { +public: NIT: misspelling: ErrorCHecking instead of ErrorChecking

[PATCH] D43550: [clangd] Not collect include headers for dynamic index for now.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. As discussed offline, properly supporting IWYU pragma in the dynamic index seems like too much design work for now and it's not gonna get fixed soon. So opting for disabling the

[PATCH] D43567: [ASTMatchers] isTemplateInstantiation: also match explicit instantiation declaration.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D43567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43538: [clang-tidy] Update run-clang-tidy.py with config arg

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a nit with the help text, this LGTM. Comment at: clang-tidy/tool/run-clang-tidy.py:188-189 + '

[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

bsdjhb updated this revision to Diff 135285. bsdjhb added a comment. - Unexpand tabs. Repository: rUNW libunwind https://reviews.llvm.org/D43585 Files: CMakeLists.txt test/lit.site.cfg.in Index: test/lit.site.cfg.in ===

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 

stephanemoore updated this revision to Diff 135291. stephanemoore added a comment. Added excerpts from the Google Objective-C style guide section on constant naming (http://google.github.io/styleguide/objcguide#constants) as additional test cases. Repository: rCTE Clang Tools Extra

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added a comment. Nice! Comment at: clang-doc/BitcodeWriter.cpp:33 + llvm::IndexedMap BlockIdNameMap; + BlockIdNameMap.resize(BI_LAST - BI_FIRST + 1); + So here's the thing. We know how many enumerators we

[PATCH] D42217: Set Module Metadata "AvoidPLT" when -fno-plt is used.

tmsriram added a comment. Ping. This patch goes with https://reviews.llvm.org/D42216, Rafael can you approve this too if you think it is ok? Thanks. https://reviews.llvm.org/D42217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43522: [clang-format] New API guessLanguage()

djasper added inline comments. Comment at: cfe/trunk/lib/Format/Format.cpp:2298 +FormatStyle::LanguageKind guessLanguage(StringRef FileName, StringRef Code) { + FormatStyle::LanguageKind result = getLanguageByFileName(FileName); + if (result == FormatStyle::LK_Cpp) {

[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

bsdjhb added a comment. @sdardis requested this functionality in the review of https://reviews.llvm.org/D39074. Simon, can you confirm that this works for you in your testing? Repository: rUNW libunwind https://reviews.llvm.org/D43585 ___

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

yaxunl added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3505 +if (AS != LangAS::Default && AS != LangAS::opencl_private && +AS != CGM.getASTAllocaAddressSpace()) + Flag = CallArg::ByValArgNeedsCopy; rjmccall wrote: > This is an odd

[PATCH] D43522: [clang-format] New API guessLanguage()

benhamilton added inline comments. Comment at: cfe/trunk/lib/Format/Format.cpp:2298 +FormatStyle::LanguageKind guessLanguage(StringRef FileName, StringRef Code) { + FormatStyle::LanguageKind result = getLanguageByFileName(FileName); + if (result == FormatStyle::LK_Cpp) {

[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

bsdjhb created this revision. bsdjhb added a reviewer: sdardis. Herald added subscribers: christof, mgorny. This is done via a new LIBUNWIND_TEST_CFLAGS variable. Repository: rUNW libunwind https://reviews.llvm.org/D43585 Files: CMakeLists.txt test/lit.site.cfg.in Index:

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:407 + +void ClangDocBinaryWriter::writeBitstream(const EnumInfo , + BitstreamWriter , juliehockett wrote: > lebedev.ri wrote: > > Hmm, common

  1   2   >