r326590 - [OPENMP] Treat local variables in CUDA mode as thread local.

Author: abataev Date: Fri Mar 2 09:17:12 2018 New Revision: 326590 URL: http://llvm.org/viewvc/llvm-project?rev=326590=rev Log: [OPENMP] Treat local variables in CUDA mode as thread local. In CUDA mode all local variables are actually thread local|threadprivate, not private, and, thus, they

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

aaron.ballman added a comment. In https://reviews.llvm.org/D43248#1025495, @jdenny wrote: > Aaron, thanks for the review. I've applied your suggestions and am ready to > commit. You're correct that we have a lot of freedom with the commit message, but the important piece is in describing

[PATCH] D42938: [Sema] Emit -Winteger-overflow for arguments in function calls, ObjC messages.

vsapsai added a comment. In https://reviews.llvm.org/D42938#1025151, @jkorous-apple wrote: > Maybe a stupid idea but in case it makes sense to add these expression types > could we also add integer template arguments? The idea isn't stupid but I think it is already handled. For template

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added a comment. Aaron, thanks for the review. I've applied your suggestions and am ready to commit. I've noticed a variety of styles in commit logs, I've read the coding standards, and it seems there's a lot of freedom here. Below are the two commit logs I'm planning to use. Please

[PATCH] D43814: [x86][CET] Introduce _get_ssp, _inc_ssp intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Headers/cetintrin.h:45 +static __inline__ void __DEFAULT_FN_ATTRS _inc_ssp(unsigned int __a) { + __builtin_ia32_incsspq(__a); +}

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 136793. juliehockett added a comment. Updating for parent diff & refactoring reader. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h

r326594 - [OPENMP] Scan all redeclarations looking for `declare simd` attribute.

Author: abataev Date: Fri Mar 2 10:07:00 2018 New Revision: 326594 URL: http://llvm.org/viewvc/llvm-project?rev=326594=rev Log: [OPENMP] Scan all redeclarations looking for `declare simd` attribute. Patch fixes the problem with the functions marked as `declare simd`. If the canonical

[clang-tools-extra] r326598 - [clangd] Use higher timoout values in TUSchedulerTest::Debounce

Author: ibiryukov Date: Fri Mar 2 10:23:41 2018 New Revision: 326598 URL: http://llvm.org/viewvc/llvm-project?rev=326598=rev Log: [clangd] Use higher timoout values in TUSchedulerTest::Debounce Should unbreak windows buildbots. Modified:

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added inline comments. Comment at: test/Sema/attr-ownership.cpp:1 +// RUN: %clang_cc1 %s -verify + aaron.ballman wrote: > Please pass `-fsyntax-only` as well. Sure. Would you like me to change test/Sema/attr-ownership.c while we're thinking about it?

Re: r326590 - [OPENMP] Treat local variables in CUDA mode as thread local.

Hi Alexey, Am 2018-03-02 18:17, schrieb Alexey Bataev via cfe-commits: Author: abataev Date: Fri Mar 2 09:17:12 2018 New Revision: 326590 URL: http://llvm.org/viewvc/llvm-project?rev=326590=rev Log: [OPENMP] Treat local variables in CUDA mode as thread local. In CUDA mode all local variables

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

aaron.ballman added inline comments. Comment at: test/Sema/attr-ownership.cpp:1 +// RUN: %clang_cc1 %s -verify + jdenny wrote: > aaron.ballman wrote: > > Please pass `-fsyntax-only` as well. > Sure. Would you like me to change test/Sema/attr-ownership.c while

Re: [clang-tools-extra] r326546 - [clangd] Debounce streams of updates.

The TUSchedulerTest::Debounce breaks on Windows buildbots. Probably because the timeouts of 50ms/10ms/40ms are too low to be scheduled properly. Increased the timeouts in r326598 to 1s/200ms/2s, hopefully that would unbreak the buildbots. We could tweak them back to lower values that work on

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 136791. juliehockett marked 11 inline comments as done. juliehockett added a comment. Addressing comments https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added inline comments. Comment at: clang-doc/Representation.h:117 + bool IsDefinition = false; + llvm::Optional DefLoc; + llvm::SmallVector Loc; I meant that `IsDefinition` controls whether `DefLoc` will be set/used or not. So with

[PATCH] D44032: Remove -i command line option, add -imultilib

erichkeane created this revision. erichkeane added reviewers: rsmith, chandlerc, aaron.ballman, echristo. I discovered that '-i' is a command line option for the driver, however it actually does not do anything and is not supported by any other compiler. In fact, it is completely undocumented

r326604 - Fix the hasType() AST matcher to not assert when the QualType is invalid.

Author: aaronballman Date: Fri Mar 2 11:14:21 2018 New Revision: 326604 URL: http://llvm.org/viewvc/llvm-project?rev=326604=rev Log: Fix the hasType() AST matcher to not assert when the QualType is invalid. There's not a particularly good way to test this with the AST matchers unit tests

[clang-tools-extra] r326605 - Adds a clang-tidy test for a failing assertion in the misc-misplaced-const check.

Author: aaronballman Date: Fri Mar 2 11:14:34 2018 New Revision: 326605 URL: http://llvm.org/viewvc/llvm-project?rev=326605=rev Log: Adds a clang-tidy test for a failing assertion in the misc-misplaced-const check. The test case previously triggered an assertion in the AST matchers because the

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

niko added a comment. Thanks everyone for your comments! I renamed the namespace and filenames to 'abseil'. @Eugene.Zelenko, definitely interested in extending this to a C++20 modernize check and adding `absl::EndsWith()` support, would it be OK though to do this in a later patch?

[PATCH] D43911: [AMDGPU] Clean up old address space mapping and fix constant address space value

b-sumner added a comment. Looks fine to me. https://reviews.llvm.org/D43911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43995: Do not generate calls to fentry with __attribute__((no_instrument_function))

rnk added a comment. This looks right to me, but we should check with @hans since I think he touched this code last. Repository: rC Clang https://reviews.llvm.org/D43995 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40737: [clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test

lebedev.ri added a comment. In https://reviews.llvm.org/D40737#1024120, @JonasToth wrote: > After long inactivity (sorry!) i had a chance to look at it again: > > switch(i) { > case 0:; > case 1:; > case 2:; > ... > } > > > does *NOT* lead to the stack overflow. This is most likely

[PATCH] D43818: Better OpenBSD frontend support

devnexen updated this revision to Diff 136804. devnexen added a comment. backtrace on OpenBSD is not base library but a package. Plus not needed for the UBsan subset. https://reviews.llvm.org/D43818 Files: lib/Driver/ToolChain.cpp lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D42938: [Sema] Emit -Winteger-overflow for arguments in function calls, ObjC messages.

jkorous-apple added a comment. Sorry, my bad, I tried just older clang version which didn't produce any error. With reasonably up to date clang I get these: > cat tmpl_overflow.hpp template struct foo { short a; }; template<> struct foo<100 * 10240> { bool a; };

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

niko updated this revision to Diff 136821. niko marked 23 inline comments as done. niko added a comment. Renamed 'absl' to 'abseil', applied reviewer suggestions Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43847 Files: clang-tidy/CMakeLists.txt

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

Eugene.Zelenko added a comment. In https://reviews.llvm.org/D43847#1025833, @niko wrote: > Thanks everyone for your comments! I renamed the namespace and filenames to > 'abseil'. > > @Eugene.Zelenko, definitely interested in extending this to a C++20 modernize > check and adding

r326602 - [Attr] Fix parameter indexing for several attributes

Author: jdenny Date: Fri Mar 2 11:03:22 2018 New Revision: 326602 URL: http://llvm.org/viewvc/llvm-project?rev=326602=rev Log: [Attr] Fix parameter indexing for several attributes The patch fixes a number of bugs related to parameter indexing in attributes: * Parameter indices in some

r326603 - [Attr] Use -fsyntax-only in test

Author: jdenny Date: Fri Mar 2 11:03:27 2018 New Revision: 326603 URL: http://llvm.org/viewvc/llvm-project?rev=326603=rev Log: [Attr] Use -fsyntax-only in test Suggested at: https://reviews.llvm.org/D43248 Modified: cfe/trunk/test/Sema/attr-ownership.c Modified:

[PATCH] D43911: [AMDGPU] Clean up old address space mapping and fix constant address space value

yaxunl added a comment. Ping https://reviews.llvm.org/D43911 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44039: [Sema] Make getCurFunction() return null outside function parsing

rnk created this revision. rnk added a reviewer: rsmith. Before this patch, Sema pre-allocated a FunctionScopeInfo and kept it in the first, always present element of the FunctionScopes stack. This meant that Sema::getCurFunction would return a pointer to this pre-allocated object when parsing

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rL326602: [Attr] Fix parameter indexing for several attributes (authored by jdenny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 136809. juliehockett marked an inline comment as done. juliehockett added a comment. Removing IsDefinition field. https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/Representation.h:117 + bool IsDefinition = false; + llvm::Optional DefLoc; + llvm::SmallVector Loc; lebedev.ri wrote: > I meant that `IsDefinition` controls whether `DefLoc` will be

[PATCH] D40737: [clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test

aaron.ballman added a comment. In https://reviews.llvm.org/D40737#1025777, @lebedev.ri wrote: > In https://reviews.llvm.org/D40737#1024120, @JonasToth wrote: > > > After long inactivity (sorry!) i had a chance to look at it again: > > > > switch(i) { > > case 0:; > > case 1:; > > case

r326607 - Range-ify a for loop. NFC

Author: gbiv Date: Fri Mar 2 12:10:38 2018 New Revision: 326607 URL: http://llvm.org/viewvc/llvm-project?rev=326607=rev Log: Range-ify a for loop. NFC Modified: cfe/trunk/lib/CodeGen/CGBlocks.cpp Modified: cfe/trunk/lib/CodeGen/CGBlocks.cpp URL:

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

ahatanak updated this revision to Diff 136895. ahatanak added a comment. Add a flag to OpaqeuValueExpr that indicates whether it is a unique reference to its subexpression. If the flag is set, IRGen will avoid binding the OVE and copying the result to the destination and instead just visit the

[PATCH] D44044: [analyzer] Don't throw NSNumberObjectConversion warning on object initialization in if-expression

This revision was automatically updated to reflect the committed changes. Closed by commit rC326619: [analyzer] Dont throw NSNumberObjectConversion warning on object… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

uohcsemaj added a comment. Ping! https://reviews.llvm.org/D40988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r326623 - Remove -i command line option, add -imultilib

Author: erichkeane Date: Fri Mar 2 13:53:25 2018 New Revision: 326623 URL: http://llvm.org/viewvc/llvm-project?rev=326623=rev Log: Remove -i command line option, add -imultilib I discovered that '-i' is a command line option for the driver, however it actually does not do anything and is not

[PATCH] D44032: Remove -i command line option, add -imultilib

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D44032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43995: Do not generate calls to fentry with __attribute__((no_instrument_function))

This revision was automatically updated to reflect the committed changes. Closed by commit rC326639: Do not generate calls to fentry with __attribute__((no_instrument_function)) (authored by manojgupta, committed by ). Changed prior to commit:

r326622 - Don't claim that va_start has special semantic checks

Author: rnk Date: Fri Mar 2 13:41:08 2018 New Revision: 326622 URL: http://llvm.org/viewvc/llvm-project?rev=326622=rev Log: Don't claim that va_start has special semantic checks We don't have special checks for BI_va_start in Sema::CheckBuiltinFunctionCall, so setting the 't' flag for va_start

r326624 - PR36581: Support data recursion over Stmts in AST matchers.

Author: rsmith Date: Fri Mar 2 13:55:03 2018 New Revision: 326624 URL: http://llvm.org/viewvc/llvm-project?rev=326624=rev Log: PR36581: Support data recursion over Stmts in AST matchers. Modified: cfe/trunk/lib/ASTMatchers/ASTMatchFinder.cpp Modified:

[PATCH] D43995: Do not generate calls to fentry with __attribute__((no_instrument_function))

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Seems reasonable to me. Repository: rC Clang https://reviews.llvm.org/D43995 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

aaron.ballman added inline comments. Comment at: clang-tidy/absl/StringFindStartswithCheck.cpp:17-19 + auto stringClassMatcher = anyOf(cxxRecordDecl(hasName("string")), + cxxRecordDecl(hasName("__versa_string")), +

r326619 - [analyzer] Don't throw NSNumberObjectConversion warning on object initialization in if-expression

Author: george.karpenkov Date: Fri Mar 2 13:34:24 2018 New Revision: 326619 URL: http://llvm.org/viewvc/llvm-project?rev=326619=rev Log: [analyzer] Don't throw NSNumberObjectConversion warning on object initialization in if-expression ``` if (NSNumber* x = ...) ``` is a reasonable pattern in

[PATCH] D44032: Remove -i command line option, add -imultilib

erichkeane updated this revision to Diff 136845. erichkeane added a comment. Talked to Aaron and came up with a way of covering with a testcase. https://reviews.llvm.org/D44032 Files: include/clang/Driver/Options.td test/Driver/unknown-arg.c Index: include/clang/Driver/Options.td

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

ioeric added inline comments. Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:207 + llvm::DenseMap> + GroupedReplacements; + jdemeule wrote: > ioeric wrote: > > I don't think we need to do the deduplication here anymore. AtomicChange

r326639 - Do not generate calls to fentry with __attribute__((no_instrument_function))

Author: manojgupta Date: Fri Mar 2 15:52:44 2018 New Revision: 326639 URL: http://llvm.org/viewvc/llvm-project?rev=326639=rev Log: Do not generate calls to fentry with __attribute__((no_instrument_function)) Summary: Currently only calls to mcount were suppressed with no_instrument_function

[PATCH] D44032: Remove -i command line option, add -imultilib

aaron.ballman added a comment. testcase Repository: rC Clang https://reviews.llvm.org/D44032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43741: [Analyzer] More accurate modeling about the increment operator of the operand with type bool.

NoQ added a comment. Nice catch, thanks! Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:1078-1080 +// The use of an operand of type bool with the ++ operators is deprecated +// but valid untill C++17. And if the operand of the increment operator is +// of type

[PATCH] D43911: [AMDGPU] Clean up old address space mapping and fix constant address space value

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM except minor comment. Comment at: lib/Basic/Targets/AMDGPU.cpp:41-49 0, // Default 1, // opencl_global 3, // opencl_local 4, // opencl_constant

[PATCH] D44051: [CFG] [analyzer] Add construction context for implicit constructor conversions.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. Implicit constructor conversions such as `A a = B()` are represented by surrounding the constructor for `B()` with an `ImplicitCastExpr` of

Re: r313729 - Implement C++ [basic.link]p8.

Hi Richard, This commit has caused a second regression in Clang which triggers a new invalid -Wunused-function warning. I filed https://bugs.llvm.org/show_bug.cgi?id=36584 which contains the minimized test case for this issue. Do you mind taking a look at it? Thanks, Alex On 19 December 2017 at

[PATCH] D44032: Remove -i command line option, add -imultilib

This revision was automatically updated to reflect the committed changes. Closed by commit rL326623: Remove -i command line option, add -imultilib (authored by erichkeane, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r326633 - [StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Fri Mar 2 15:11:49 2018 New Revision: 326633 URL: http://llvm.org/viewvc/llvm-project?rev=326633=rev Log: [StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified:

[PATCH] D43423: [SimplifyCFG] Create flag to disable simplifyCFG.

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. I assume this is going to be abandoned in favor of https://reviews.llvm.org/D44057 https://reviews.llvm.org/D43423 ___

[PATCH] D44064: [Driver] Automatically disable incompatible default sanitizers

phosek created this revision. phosek added reviewers: kcc, vitalybuka, mcgrathr. Herald added subscribers: cfe-commits, cryptoad. phosek added a dependent revision: D44065: [Driver] Enable SafeStack by default on Fuchsia. When a sanitizer incompatible with one of the default sanitizers is

[PATCH] D44065: [Driver] Enable SafeStack by default on Fuchsia

phosek created this revision. phosek added reviewers: mcgrathr, kcc, vitalybuka. Herald added subscribers: cfe-commits, cryptoad. phosek added a dependency: D44064: [Driver] Automatically disable incompatible default sanitizers. This is already used throughout the entire system, so make it a

[PATCH] D43898: Preliminary refactoring in service of -Wreturn-std-move. NFC.

Quuxplusone added a comment. @rtrieu please take a look? Also, I would need someone to commit this for me, as I don't have commit privs. Repository: rC Clang https://reviews.llvm.org/D43898 ___ cfe-commits mailing list

[PATCH] D43648: [clangd] Debounce streams of updates.

This revision was automatically updated to reflect the committed changes. Closed by commit rL326546: [clangd] Debounce streams of updates. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43648 Files:

[clang-tools-extra] r326547 - [clangd:vscode] check empty/null string correctly.

Author: ioeric Date: Fri Mar 2 01:21:41 2018 New Revision: 326547 URL: http://llvm.org/viewvc/llvm-project?rev=326547=rev Log: [clangd:vscode] check empty/null string correctly. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts Modified:

[clang-tools-extra] r326548 - [clangd:vscode] Bump clangd-vscode version to 0.0.4.

Author: ioeric Date: Fri Mar 2 01:26:17 2018 New Revision: 326548 URL: http://llvm.org/viewvc/llvm-project?rev=326548=rev Log: [clangd:vscode] Bump clangd-vscode version to 0.0.4. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/package.json Modified:

[clang-tools-extra] r326546 - [clangd] Debounce streams of updates.

Author: sammccall Date: Fri Mar 2 00:56:37 2018 New Revision: 326546 URL: http://llvm.org/viewvc/llvm-project?rev=326546=rev Log: [clangd] Debounce streams of updates. Summary: Don't actually start building ASTs for new revisions until either: - 500ms have passed since the last revision, or -

[PATCH] D43183: clang-format: introduce `CaseBlockIndent` to control indent in switch

djasper added a comment. Got two responses so far. 1. Having to closing braces in the same column is weird, but not that weird. Consider namespace n { void f() { ... } } 2. Richard Smith (code owner of Clang) says that he doesn't really like the two closing braces in the same

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

xazax.hun abandoned this revision. xazax.hun added a comment. Resubmitted in https://reviews.llvm.org/rL326439 Phabricator did not display the mailing list conversation. The point is, the circular dependency does not exist in the upstream version of clang. The reason is that CMake does not

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

ahedberg added a comment. In https://reviews.llvm.org/D43847#1024018, @aaron.ballman wrote: > In https://reviews.llvm.org/D43847#1023452, @hokein wrote: > > > In https://reviews.llvm.org/D43847#1021967, @aaron.ballman wrote: > > > > > I need a bit more context because I'm unfamiliar with `absl`.

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

djasper added a comment. In https://reviews.llvm.org/D42787#1025117, @Typz wrote: > If people don't care about this case, we might as well merge this :-) Just > kidding. > > The tweak matches both our expectation, the auto-indent behaviour of IDE (not > to be trusted, but still probably of

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

Typz added a comment. > Also double-checked with Richard Smith and he agrees that the current > behavior is preferable. For comma and plus this doesn't seem overly > important, but making it: > > aa(b + ccc * > d); > > > seems

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

djasper added a comment. We have talked about that and none of us agree. Repository: rC Clang https://reviews.llvm.org/D42787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43572: [Sema] Improve test coverage of narrowing conversion diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rC326551: [Sema] Improve test coverage of narrowing conversion diagnostics (authored by miyuki, committed by ). Repository: rC Clang https://reviews.llvm.org/D43572 Files:

[PATCH] D43995: Do not generate calls to fentry with __attribute__((no_instrument_function))

chandlerc edited reviewers, added: rnk, rsmith, rjmccall; removed: chandlerc. chandlerc added a comment. Adding more Clang CodeGen folks to this review rather than myself... Repository: rC Clang https://reviews.llvm.org/D43995 ___ cfe-commits

[PATCH] D44000: [clang] Fix use-after-free on code completion

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: ioeric, jkorous-apple, klimek. Found by asan. Fiddling with code completion AST after FrontendAction::Exceute can lead to errors. Calling the callback in ProcessCodeCompleteResults to make

[PATCH] D43814: [x86][CET] Introduce _get_ssp, _inc_ssp intrinsics

GBuella added inline comments. Comment at: lib/Headers/cetintrin.h:45 +static __inline__ void __DEFAULT_FN_ATTRS _inc_ssp(unsigned int __a) { + __builtin_ia32_incsspq(__a); +} craig.topper wrote: > Where is the zeroing behavior for older CPUs coming from? This

[PATCH] D43741: [Analyzer] More accurate modeling about the increment operator of the operand with type bool.

MTC added a comment. In https://reviews.llvm.org/D43741#1024949, @alexshap wrote: > i see, but just in case - what about the decrement operator ? @alexshap, If I'm not wrong, decrement operation is not allowed on bool type in C++98 and C++14. > 5.2.6 Increment and decrement [expr.post.incr]

[PATCH] D44000: [clang] Fix use-after-free on code completion

ilya-biryukov updated this revision to Diff 136707. ilya-biryukov added a comment. Remove code refactoring from the patch. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44000 Files: clangd/CodeComplete.cpp Index: clangd/CodeComplete.cpp

[PATCH] D44000: [clang] Fix use-after-free on code completion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This feels like a bug in the underlying clang libraries, but since none of the lifetimes are documented and everyone just does it this way... Comment at:

[PATCH] D43814: [x86][CET] Introduce _get_ssp, _inc_ssp intrinsics

GBuella updated this revision to Diff 136703. https://reviews.llvm.org/D43814 Files: lib/Headers/cetintrin.h test/CodeGen/cetintrin.c Index: test/CodeGen/cetintrin.c === --- test/CodeGen/cetintrin.c +++

[PATCH] D44000: [clang] Fix use-after-free on code completion

ilya-biryukov updated this revision to Diff 136710. ilya-biryukov added a comment. Remove a trace for "sema cleanup", it is not very informative now that we run the callback under the "sema completion" trace Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44000 Files:

[PATCH] D43928: [analyzer] Correctly measure array size in security.insecureAPI.strcpy

leanil added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp:517 if (const auto *Array = dyn_cast(DeclRef->getType())) { - uint64_t ArraySize = BR.getContext().getTypeSize(Array) / 8; + auto ArraySize =

[PATCH] D37057: [clang] Require address space to be specified when creating functions (3/3)

dylanmckay updated this revision to Diff 136734. dylanmckay added a comment. Rebase Repository: rC Clang https://reviews.llvm.org/D37057 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGBuiltin.cpp lib/CodeGen/CGCUDANV.cpp lib/CodeGen/CGDeclCXX.cpp lib/CodeGen/CGException.cpp

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

alexfh added a comment. A late comment here: should this check start a new "portability" module? This seems to be the main focus of the check rather than making code more readable. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

Typz added a comment. If people don't care about this case, we might as well merge this :-) Just kidding. The tweak matches both our expectation, the auto-indent behaviour of IDE (not to be trusted, but still probably of 'default' behaviour for many people, esp. when you don't yet use a

[PATCH] D44000: [clang] Fix use-after-free on code completion

ilya-biryukov updated this revision to Diff 136714. ilya-biryukov marked 7 inline comments as done. ilya-biryukov added a comment. Addressed review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44000 Files: clangd/CodeComplete.cpp Index: clangd/CodeComplete.cpp

[clang-tools-extra] r326569 - [clang] Fix use-after-free on code completion

Author: ibiryukov Date: Fri Mar 2 04:28:27 2018 New Revision: 326569 URL: http://llvm.org/viewvc/llvm-project?rev=326569=rev Log: [clang] Fix use-after-free on code completion Summary: Found by asan. Fiddling with code completion AST after FrontendAction::Exceute can lead to errors. Calling the

[PATCH] D44003: [clangd] Fix unintentionally loose fuzzy matching, and the tests masking it.

sammccall updated this revision to Diff 136719. sammccall added a comment. test tweaks Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44003 Files: clangd/FuzzyMatch.cpp clangd/FuzzyMatch.h unittests/clangd/FuzzyMatchTests.cpp unittests/clangd/IndexTests.cpp Index:

[libunwind] r326565 - Creating release candidate final from release_600 branch

Author: hans Date: Fri Mar 2 04:08:51 2018 New Revision: 326565 URL: http://llvm.org/viewvc/llvm-project?rev=326565=rev Log: Creating release candidate final from release_600 branch Added: libunwind/tags/RELEASE_600/final/ - copied from r326564, libunwind/branches/release_60/

[libcxx] r326558 - Creating release candidate final from release_600 branch

Author: hans Date: Fri Mar 2 04:07:59 2018 New Revision: 326558 URL: http://llvm.org/viewvc/llvm-project?rev=326558=rev Log: Creating release candidate final from release_600 branch Added: libcxx/tags/RELEASE_600/final/ (props changed) - copied from r326557,

[libcxxabi] r326559 - Creating release candidate final from release_600 branch

Author: hans Date: Fri Mar 2 04:08:05 2018 New Revision: 326559 URL: http://llvm.org/viewvc/llvm-project?rev=326559=rev Log: Creating release candidate final from release_600 branch Added: libcxxabi/tags/RELEASE_600/final/ - copied from r326558, libcxxabi/branches/release_60/

[PATCH] D43809: Add possibility to specify output stream for CompilerInstance

This revision was automatically updated to reflect the committed changes. Closed by commit rC326566: Add possibility to specify output stream for CompilerInstance (authored by AlexeySotkin, committed by ). Changed prior to commit: https://reviews.llvm.org/D43809?vs=136252=136715#toc

[PATCH] D44000: [clang] Fix use-after-free on code completion

This revision was automatically updated to reflect the committed changes. Closed by commit rL326569: [clang] Fix use-after-free on code completion (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44000 Files:

Re: r326542 - [Frontend] Avoid including default system header paths on Fuchsia

On Fri, Mar 2, 2018 at 2:19 AM, Petr Hosek via cfe-commits wrote: > Author: phosek > Date: Thu Mar 1 23:19:42 2018 > New Revision: 326542 > > URL: http://llvm.org/viewvc/llvm-project?rev=326542=rev > Log: > [Frontend] Avoid including default system header paths on

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

chandlerc added a comment. In https://reviews.llvm.org/D42787#1000687, @krasimir wrote: > We could adapt the single-argument version instead, turning: > > foo(bb + > c); > > > into: > > foo(bb + > c); > I have

[PATCH] D44003: [clangd] Fix unintentionally loose fuzzy matching, and the tests masking it.

sammccall created this revision. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, klimek. sammccall updated this revision to Diff 136719. sammccall added a comment. test tweaks The intent was that [ar] doesn't match "FooBar"; the first character must match a Head

r326551 - [Sema] Improve test coverage of narrowing conversion diagnostics

Author: miyuki Date: Fri Mar 2 02:03:02 2018 New Revision: 326551 URL: http://llvm.org/viewvc/llvm-project?rev=326551=rev Log: [Sema] Improve test coverage of narrowing conversion diagnostics Summary: This patch adds tests of narrowing conversion diagnostics for the 'unscoped enum -> integer'

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from two minor nits, this LGTM. Thank you for working on it! Comment at: test/Sema/attr-ownership.cpp:1 +// RUN: %clang_cc1 %s -verify +

r326566 - Add possibility to specify output stream for CompilerInstance

Author: AlexeySotkin Date: Fri Mar 2 04:11:40 2018 New Revision: 326566 URL: http://llvm.org/viewvc/llvm-project?rev=326566=rev Log: Add possibility to specify output stream for CompilerInstance Patch by: krisb Reviewers: teemperor Reviewed By: teemperor Subscribers: klimek, mgorny,

[PATCH] D42938: [Sema] Emit -Winteger-overflow for arguments in function calls, ObjC messages.

jkorous-apple added a comment. Maybe a stupid idea but in case it makes sense to add these expression types could we also add integer template arguments? https://reviews.llvm.org/D42938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added a comment. Could some other people please review this differential, too? I'm sure i have missed things. --- Some more nitpicking. For this differential as standalone, i'we mostly run out of things to nitpick. Some things can probably be done better (the blockid/recordid stuff

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov updated this revision to Diff 136752. dfukalov edited the summary of this revision. dfukalov set the repository for this revision to rC Clang. dfukalov added a comment. addrspace specifications are kept in descriptions strings Repository: rC Clang https://reviews.llvm.org/D43281