[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

ahatanak added a comment. In https://reviews.llvm.org/D45382#1060163, @rjmccall wrote: > Hmm. I'm not actually sure *why* it's not okay to forward callee-cleanup > arguments. Do we just not have the necessary logic to disable the cleanup in > the caller? It seems that it would be OK if ther

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

DHowett-MSFT added a comment. Thanks! I don't have the means to check this in myself. Repository: rC Clang https://reviews.llvm.org/D44646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D45305: ObjCGNU: Fix empty v3 protocols being emitted two fields short

DHowett-MSFT updated this revision to Diff 141450. DHowett-MSFT added a comment. Added a test per @rjmccall's suggestion. I chose to test this by emitting assembly because the llvm ir is significantly harder to pick apart for the true _size_ of the protocol. Repository: rC Clang https://rev

[PATCH] D45384: [ObjC++] Never pass structs with `__weak` fields in registers

rjmccall added a comment. In https://reviews.llvm.org/D45384#1060369, @ahatanak wrote: > Yes. I intended it as a property that propagates to classes that contain or > derive from the type. > > Would it make it less confusing if I merged CXXRecordDecl::CanPassInRegisters > and RecordDecl::Cannot

r329464 - Remove two unnecessary -I flags passed to clang-tblgen.

Author: nico Date: Fri Apr 6 16:36:50 2018 New Revision: 329464 URL: http://llvm.org/viewvc/llvm-project?rev=329464&view=rev Log: Remove two unnecessary -I flags passed to clang-tblgen. Modified: cfe/trunk/include/clang/Basic/CMakeLists.txt Modified: cfe/trunk/include/clang/Basic/CMakeLists

[PATCH] D42893: [libclang] Add clang_File_tryGetRealPathName

MaskRay added a comment. There is no unittest but I have verified with a C++ language server on Arch Linux. Without using this function, cquery/ccls will not be able to index system header files because of excessive .. in the path returned by clang_getFileName. Repository: rC Clang https:/

r329465 - Recommit r329442: Generate Libclang invocation reproducers using a new

Author: arphaman Date: Fri Apr 6 17:03:27 2018 New Revision: 329465 URL: http://llvm.org/viewvc/llvm-project?rev=329465&view=rev Log: Recommit r329442: Generate Libclang invocation reproducers using a new -cc1gen-reproducer driver option The recommit fixes: - An MSAN failure (CCPrintOptions wasn

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Eugene.Zelenko added a comment. If this is Apple guideline, check name should reflect this. I think will be good idea to have general check for Apple naming conventions instead of separate checks for specific situations like //objc-ivar-declaration// and //objc-property-declaration//. ==

r329467 - Generalize test for 32-bit targets.

Author: rsmith Date: Fri Apr 6 17:28:32 2018 New Revision: 329467 URL: http://llvm.org/viewvc/llvm-project?rev=329467&view=rev Log: Generalize test for 32-bit targets. Modified: cfe/trunk/test/CodeGenCXX/tail-padding.cpp Modified: cfe/trunk/test/CodeGenCXX/tail-padding.cpp URL: http://llvm

[PATCH] D43957: Fixing issue where a space was not added before a global namespace variable when SpacesInParentheses is set

dpayne added a comment. Hi Bumping this commit. I do not have commit access so I cannot merge myself, if you have the time could you merge this commit? Repository: rC Clang https://reviews.llvm.org/D43957 ___ cfe-commits mailing list cfe-commit

[libcxx] r329474 - Work around missing braces in init warning

Author: ericwf Date: Fri Apr 6 18:28:54 2018 New Revision: 329474 URL: http://llvm.org/viewvc/llvm-project?rev=329474&view=rev Log: Work around missing braces in init warning Modified: libcxx/trunk/include/compare Modified: libcxx/trunk/include/compare URL: http://llvm.org/viewvc/llvm-proj

r329476 - Remove another unnecessary -I flag passed to clang-tblgen.

Author: nico Date: Fri Apr 6 18:34:36 2018 New Revision: 329476 URL: http://llvm.org/viewvc/llvm-project?rev=329476&view=rev Log: Remove another unnecessary -I flag passed to clang-tblgen. Modified: cfe/trunk/include/clang/StaticAnalyzer/Checkers/CMakeLists.txt cfe/trunk/include/clang/St

[PATCH] D45384: [ObjC++] Never pass structs with `__weak` fields in registers

ahatanak updated this revision to Diff 141471. ahatanak added a comment. Replace flags CanPassInRegisters and CannotPassInRegisters with a 2-bit enum in RecordDecl. Repository: rC Clang https://reviews.llvm.org/D45384 Files: include/clang/AST/Decl.h include/clang/AST/Type.h lib/AST/De

[PATCH] D44988: [Sema] Fix decrement availability for built-in types

vsapsai added inline comments. Comment at: test/SemaCXX/overloaded-builtin-operators.cpp:95-99 // C++ [over.built]p3 long l1 = lr--; + // C++ [over.built]p4 + float f1 = fr--; Looks like p3 for `lr--` is a typo because p3 is about `++` while p4 is about

RE: [clang-tools-extra] r329454 - [clang-tidy] One more fix compilation for ParentVirtualCallCheck.cpp: find_if predicate

Hi Zinovy, The PS4 Windows bot is still failing to compile this file after your latest change. Can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/16316 FAILED: tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/clangTidyBugproneMo

Re: r311958 - Revert "Revert r311552: [Bash-autocompletion] Add support for static analyzer flags"

Hi Yuka, sorry about the late review comment on this. I just happened to see that this lets Driver's Option.inc depend on StaticAnalyzer/Checker's Checker.inc. However, Driver does not depend on StaticAnalyzer/Checker. In practice, it works ok because of all tablegen targets being collected into c

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

rjmccall added a comment. This looks okay to me, but I think it would better if someone with more expertise in the design of the driver and frontend code could review this. Comment at: lib/Driver/Driver.cpp:2267 +if ((IA->getType() != types::TY_CUDA) && +IA

r329477 - Make CodeGen depend just once on clangAnalysis.

Author: nico Date: Fri Apr 6 20:29:47 2018 New Revision: 329477 URL: http://llvm.org/viewvc/llvm-project?rev=329477&view=rev Log: Make CodeGen depend just once on clangAnalysis. Modified: cfe/trunk/lib/CodeGen/CMakeLists.txt Modified: cfe/trunk/lib/CodeGen/CMakeLists.txt URL: http://llvm.o

[PATCH] D45384: [ObjC++] Never pass structs with `__weak` fields in registers

rjmccall added a comment. Just a couple minor requests; if you accept them, feel free to commit. Comment at: include/clang/AST/Decl.h:3556 +/// indirectly. This value is used only in C++. +APK_CannotPassInRegs, + I think it's probably worth spelling out

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

rjmccall added a comment. If that's the problem, then I think the right design is for CallArg to include an optional cleanup reference for a cleanup that can be deactivated at the instant of the call (we should assert that this exists for parameters that are destroyed in the callee), and then f

r329481 - Sort source lists in lib/StaticAnalyzer.

Author: nico Date: Fri Apr 6 21:25:01 2018 New Revision: 329481 URL: http://llvm.org/viewvc/llvm-project?rev=329481&view=rev Log: Sort source lists in lib/StaticAnalyzer. Modified: cfe/trunk/lib/StaticAnalyzer/Core/CMakeLists.txt cfe/trunk/lib/StaticAnalyzer/Frontend/CMakeLists.txt Modi

[libcxx] r329484 - Use void() to create a void expression type

Author: ericwf Date: Fri Apr 6 21:28:11 2018 New Revision: 329484 URL: http://llvm.org/viewvc/llvm-project?rev=329484&view=rev Log: Use void() to create a void expression type Modified: libcxx/trunk/include/compare Modified: libcxx/trunk/include/compare URL: http://llvm.org/viewvc/llvm-pro

[PATCH] D45401: Fix 31480 - warn more aggressively when assignments get used as a boolean values

incertia created this revision. incertia added reviewers: rjmccall, rsmith. incertia added a project: clang. Herald added a subscriber: cfe-commits. To my understanding, the contents of a condition will always be implicitly casted to an rvalue before evaluation. Thus, moving the check to Perform

[PATCH] D45401: Fix 31480 - warn more aggressively when assignments get used as a boolean values

incertia updated this revision to Diff 141477. incertia added a comment. Pulled the check outside of the case statement. https://reviews.llvm.org/D45401 Files: lib/Sema/SemaExpr.cpp lib/Sema/SemaExprCXX.cpp Index: lib/Sema/SemaExprCXX.cpp ==

<    1   2