[PATCH] D47050: MC: Change the streamer ctors to take an object writer instead of a stream. NFCI.

This revision was automatically updated to reflect the committed changes. Closed by commit rC332749: MC: Change the streamer ctors to take an object writer instead of a stream. (authored by pcc, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r332749 - MC: Change the streamer ctors to take an object writer instead of a stream. NFCI.

Author: pcc Date: Fri May 18 11:26:45 2018 New Revision: 332749 URL: http://llvm.org/viewvc/llvm-project?rev=332749=rev Log: MC: Change the streamer ctors to take an object writer instead of a stream. NFCI. The idea is that a client that wants split dwarf would create a specific kind of object

[PATCH] D47007: [Sanitizer] CStringChecker fix for strlcpy when no bytes are copied to the dest buffer

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I've been thinking if we could de-duplicate this whole set of branches that computes the return value so that we didn't have to fix every bug twice. Maybe move it to an auxiliary function.

[PATCH] D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file

mikerice added inline comments. Comment at: test/SemaOpenCL/with_openmp.cl:1 +// RUN: %clang_cc1 -verify -fopenmp -ast-dump -x cl %s 2>&1 | FileCheck %s +// expected-no-diagnostics ABataev wrote: > Still the same question, do we really want to support full

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan updated this revision to Diff 147560. Repository: rC Clang https://reviews.llvm.org/D46084 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def include/clang/Basic/DiagnosticCommonKinds.td include/clang/Basic/Specifiers.h

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

arsenm added a comment. I'm looking at how the address space mapping works for builtins, and I think what's there is just uselessly broken and needs to be fixed. It seems to be operating under the assumption that the address spaces the target defines are totally disjoint from the language

[PATCH] D47070: [CUDA] Upgrade linked bitcode to enable inlining

tra added a subscriber: echristo. tra added a comment. This was not intended. :-( I was unaware that GetCPUAndFeaturesAttributes() would add any feature that looks like a valid CPU name to the target-cpu attribute. All I needed is to make builtins available or not. Setting them as function

Re: [PATCH] D47067: Update NRVO logic to support early return

On Fri, May 18, 2018 at 8:47 PM, tzik via cfe-commits wrote: > Ah, sorry. It's still work in progress for now. > I'll resend this soon after adding tests and updating comments there. See Herald rules for exact syntax, but i think adding "[private]" into the subject

[PATCH] D47070: [CUDA] Upgrade linked bitcode to enable inlining

jlebar added a comment. I defer to Art on this one. Repository: rC Clang https://reviews.llvm.org/D47070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

Sorry, I'll look into it right now. Will revert it if I can't find a quick fix. On Fri, May 18, 2018, 19:49 Amara Emerson wrote: > Hi Eric, > > Green dragon buildbots have started failing too, e.g.: > http://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/10222/ > > If

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

Hi Eric, Green dragon buildbots have started failing too, e.g.: http://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/10222/ If you don’t have a quick fix can you please revert it. Thanks, Amara > On May 18, 2018, at 7:46 PM, Eric Liu wrote: > > Hi Vedant, > > It

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan updated this revision to Diff 147549. Repository: rC Clang https://reviews.llvm.org/D46084 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def include/clang/Basic/DiagnosticCommonKinds.td include/clang/Basic/Specifiers.h

Re: [PATCH] D47067: Update NRVO logic to support early return

Ah, sorry. It's still work in progress for now. I'll resend this soon after adding tests and updating comments there. 2018年5月19日(土) 2:41 Arthur O'Dwyer : > https://reviews.llvm.org/D47067 is a "Restricted Differential Revision", > which I've never seen before! > Peanut

[PATCH] D46910: [Support] Avoid normalization in sys::getDefaultTargetTriple

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D46910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D47067: Update NRVO logic to support early return

https://reviews.llvm.org/D47067 is a "Restricted Differential Revision", which I've never seen before! Peanut gallery says: This sounds awesome. How does this change interact with the diagnostics issued by -Wpessimizing-move and -Wreturn-std-move? Should any new test cases be added for those

[PATCH] D46982: Do not enable RTTI with -fexceptions, for PS4

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. So on PS4, `-fsanitize=vptr` without an explicit `-frtti` will warn and disable the sanitizer, rather than implicitly enabling RTTI. As well as exceptions no longer implicitly enabling

[PATCH] D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file

ABataev added inline comments. Comment at: test/SemaOpenCL/with_openmp.cl:1 +// RUN: %clang_cc1 -verify -fopenmp -ast-dump -x cl %s 2>&1 | FileCheck %s +// expected-no-diagnostics Still the same question, do we really want to support full OpenMP for OpenCL or

r332738 - [X86] Fix a bad cast from mask16 to mask8 in _mm256_mask_cvtepi16_epi8 introduced in r332266.

Author: ctopper Date: Fri May 18 10:18:46 2018 New Revision: 332738 URL: http://llvm.org/viewvc/llvm-project?rev=332738=rev Log: [X86] Fix a bad cast from mask16 to mask8 in _mm256_mask_cvtepi16_epi8 introduced in r332266. Modified: cfe/trunk/lib/Headers/avx512vlbwintrin.h Modified:

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

I wiped my build directory, updated to r332734 and rebuilt, but hit the same error while building check-clang. For completeness, I did: $ cmake -G Ninja /Users/vsk/src/llvm.org-master/llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=On -DCLANG_ENABLE_ARCMT=Off -DCLANG_

[PATCH] D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file

mikerice updated this revision to Diff 147538. mikerice added a comment. Sorry for the delay in getting back to this. I've found that we are using many OpenMP directives not just simd. We'd like to continue doing that. I updated the patch to provide TypeSourceInfo for OMPCapturedExprDecls. I

[PATCH] D47065: [clangd] Enable parsing of non-doxygen comments in global-symbol-builder

ioeric added a comment. Should we also change the behavior in dynamic index? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents

leonardchan updated this revision to Diff 147541. leonardchan added a comment. Updated formatting Repository: rC Clang https://reviews.llvm.org/D46911 Files: include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def include/clang/Basic/DiagnosticSemaKinds.td

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

Hi Vedant, It seems that your build was not using cmake files in the source tree? lib/Tooling/Inclusions/ is a (new) standalone library (clangToolingInclusions, similar to clangToolingCore). You might need update your build to reflect this change. Let me know if you have any further question.

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

Hi Eric, I think there might be a cyclic dependency issue here, possibly one that's only visible with LLVM_ENABLE_MODULES=On. I see: While building module 'Clang_Tooling' imported from /Users/vsk/src/llvm.org-master/llvm/tools/clang/lib/Tooling/Execution.cpp:10:

r332734 - Fix unused variable warning in r332724

Author: ioeric Date: Fri May 18 09:29:42 2018 New Revision: 332734 URL: http://llvm.org/viewvc/llvm-project?rev=332734=rev Log: Fix unused variable warning in r332724 Modified: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp Modified: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp URL:

[PATCH] D47044: Ensure that we only visit a destructor for a reference if type information is available.

ormris added a comment. That could work. Is the implementation similar? Repository: rC Clang https://reviews.llvm.org/D47044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47058: [ASTImporter] Fix ClassTemplateSpecialization in wrong DC

a.sidorin requested changes to this revision. a.sidorin added a comment. This revision now requires changes to proceed. (Sorry, accepted accidentially). Repository: rC Clang https://reviews.llvm.org/D47058 ___ cfe-commits mailing list

[PATCH] D47058: [ASTImporter] Fix ClassTemplateSpecialization in wrong DC

a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. Hi Gabor! I have a question. Comment at: lib/AST/ASTImporter.cpp:4305 +// Add to the DC only if it was an explicit specialization/instantiation. +if

[PATCH] D47074: [Tooling] Add an overload of runToolOnCodeWithArgs that takes VFS

This revision was automatically updated to reflect the committed changes. Closed by commit rC332731: [Tooling] Add an overload of runToolOnCodeWithArgs that takes VFS (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D47074?vs=147526=147529#toc Repository:

[clang-tools-extra] r332732 - Trying to fix clang-move tests on windows build bot broken by r332717

Author: ioeric Date: Fri May 18 09:08:18 2018 New Revision: 332732 URL: http://llvm.org/viewvc/llvm-project?rev=332732=rev Log: Trying to fix clang-move tests on windows build bot broken by r332717 http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10702 Modified:

r332731 - [Tooling] Add an overload of runToolOnCodeWithArgs that takes VFS

Author: ioeric Date: Fri May 18 09:06:19 2018 New Revision: 332731 URL: http://llvm.org/viewvc/llvm-project?rev=332731=rev Log: [Tooling] Add an overload of runToolOnCodeWithArgs that takes VFS Summary: ... to support purely VFS-based tools. Reviewers: bkramer Subscribers: klimek, cfe-commits

[PATCH] D47074: [Tooling] Add an overload of runToolOnCodeWithArgs that takes VFS

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D47074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47074: [Tooling] Add an overload of runToolOnCodeWithArgs that takes VFS

ioeric created this revision. ioeric added a reviewer: bkramer. Herald added subscribers: cfe-commits, klimek. ... to support purely VFS-based tools. Repository: rC Clang https://reviews.llvm.org/D47074 Files: include/clang/Tooling/Tooling.h lib/Tooling/Tooling.cpp Index:

[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

QF5690 added a comment. It's been a couple of months now, @rjmccall any ETA's? Repository: rC Clang https://reviews.llvm.org/D44539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r332728 - [ASTImporter] Enable disabled but passing test

Author: martong Date: Fri May 18 08:46:18 2018 New Revision: 332728 URL: http://llvm.org/viewvc/llvm-project?rev=332728=rev Log: [ASTImporter] Enable disabled but passing test Summary: There is a test which passes since D32947, but it was forgotten to be enabled. This patch enables that disabled

[PATCH] D47069: [ASTImporter] Enable disabled but passing test

This revision was automatically updated to reflect the committed changes. Closed by commit rC332728: [ASTImporter] Enable disabled but passing test (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D47069?vs=147506=147524#toc Repository: rC Clang

[PATCH] D47069: [ASTImporter] Enable disabled but passing test

a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. Nice! Repository: rC Clang https://reviews.llvm.org/D47069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46940: [ASTImporter] make sure that ACtx::getParents still works

a.sidorin accepted this revision. a.sidorin added a comment. LGTM. Aaron, could you please confirm that AST changes are fine? Comment at: include/clang/AST/ASTContext.h:638 +ReleaseParentMapEntries(); +PointerParents = nullptr; + } I'd prefer to call

[PATCH] D47028: [clang-format/ObjC] Correctly annotate single-component ObjC method invocations

This revision was automatically updated to reflect the committed changes. Closed by commit rC332727: [clang-format/ObjC] Correctly annotate single-component ObjC method invocations (authored by benhamilton, committed by ). Changed prior to commit:

[PATCH] D47028: [clang-format/ObjC] Correctly annotate single-component ObjC method invocations

benhamilton added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:510 +CurrentToken->Previous->Type = TT_SelectorName; + } // determineStarAmpUsage() thinks that '*' '[' is allocating an jolesiak wrote: > I'd remove

[PATCH] D47028: [clang-format/ObjC] Correctly annotate single-component ObjC method invocations

benhamilton updated this revision to Diff 147516. benhamilton marked an inline comment as done. benhamilton added a comment. Style Repository: rC Clang https://reviews.llvm.org/D47028 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestObjC.cpp Index:

r332727 - [clang-format/ObjC] Correctly annotate single-component ObjC method invocations

Author: benhamilton Date: Fri May 18 08:27:02 2018 New Revision: 332727 URL: http://llvm.org/viewvc/llvm-project?rev=332727=rev Log: [clang-format/ObjC] Correctly annotate single-component ObjC method invocations Summary: Previously, clang-format's parser would fail to annotate the selector in a

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

courbet added a comment. Great, thanks for the review ! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46472: [HIP] Support offloading by linker script

This revision was automatically updated to reflect the committed changes. Closed by commit rL332724: [HIP] Support offloading by linker script (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r332724 - [HIP] Support offloading by linker script

Author: yaxunl Date: Fri May 18 08:07:56 2018 New Revision: 332724 URL: http://llvm.org/viewvc/llvm-project?rev=332724=rev Log: [HIP] Support offloading by linker script To support linking device code in different source files, it is necessary to embed fat binary at host linking stage. This

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this generally LGTM. You should wait a bit to see if @alexfh has any other concerns. Comment at:

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

courbet added inline comments. Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:35 + hasSourceExpression(IsFloatExpr), + unless(hasParent(castExpr( +

[PATCH] D46940: [ASTImporter] make sure that ACtx::getParents still works

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Ok, thanks for the explanation. Now it looks good to me. https://reviews.llvm.org/D46940 ___ cfe-commits

[PATCH] D46940: [ASTImporter] make sure that ACtx::getParents still works

r.stahl added inline comments. Comment at: lib/AST/ASTImporter.cpp:6776 + // been invalidated to avoid repeatedly calling this. + ToContext.invalidateParents(); + martong wrote: > Can an `Expr` has a parent too? If yes, why not invalidate the parents in >

[PATCH] D47070: [CUDA] Upgrade linked bitcode to enable inlining

Hahnfeld created this revision. Hahnfeld added reviewers: tra, jlebar. Herald added a subscriber: cfe-commits. Revision https://reviews.llvm.org/rC329829 added the architecture to "target-features". This prevents inlining of previously generated bitcode because the feature sets don't match. Thus

[clang-tools-extra] r332723 - Silence more truncation warnings; NFC.

Author: aaronballman Date: Fri May 18 07:53:32 2018 New Revision: 332723 URL: http://llvm.org/viewvc/llvm-project?rev=332723=rev Log: Silence more truncation warnings; NFC. Modified: clang-tools-extra/trunk/unittests/clangd/QualityTests.cpp Modified:

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle added a comment. In https://reviews.llvm.org/D44954#1104178, @ilya-biryukov wrote: > In https://reviews.llvm.org/D44954#1103664, @malaperle wrote: > > > It's probably better to consider this in a future patch. Maybe something > > like the first suggestion: vector::push_back and match

[PATCH] D47063: [clangd] Keep only a limited number of idle ASTs in memory

malaperle added subscribers: arphaman, malaperle. malaperle added a comment. In https://reviews.llvm.org/D47063#1104417, @ilya-biryukov wrote: > Maybe we can even store enough information to not need the AST for navigation > at all and build it only for features like refactorings. >

[PATCH] D46940: [ASTImporter] make sure that ACtx::getParents still works

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:6776 + // been invalidated to avoid repeatedly calling this. + ToContext.invalidateParents(); + Can an `Expr` has a parent too? If yes, why not invalidate the parents in `Import(Expr*)` ? I am

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:35 + hasSourceExpression(IsFloatExpr), + unless(hasParent(castExpr( +

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

courbet added a comment. Thanks. Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:35 + hasSourceExpression(IsFloatExpr), + unless(hasParent(castExpr( +

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

courbet updated this revision to Diff 147508. courbet marked 2 inline comments as done. courbet added a comment. - More explicit documentation. - Do not trigger in template and macro contexts. - More tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38455 Files:

[PATCH] D47028: [clang-format/ObjC] Correctly annotate single-component ObjC method invocations

jolesiak accepted this revision. jolesiak added inline comments. This revision is now accepted and ready to land. Comment at: lib/Format/TokenAnnotator.cpp:510 +CurrentToken->Previous->Type = TT_SelectorName; + } // determineStarAmpUsage() thinks

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

yaxunl added a comment. Hi Artem, I've addressed your comments. Any further changes are needed? Thanks. https://reviews.llvm.org/D45212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r332721 - [clangd] Adapt file migration in r332720

Author: ioeric Date: Fri May 18 07:17:36 2018 New Revision: 332721 URL: http://llvm.org/viewvc/llvm-project?rev=332721=rev Log: [clangd] Adapt file migration in r332720 Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt clang-tools-extra/trunk/clangd/Headers.h Modified:

[PATCH] D47068: Move #include manipulation code to new lib/Tooling/Inclusions.

This revision was automatically updated to reflect the committed changes. ioeric marked an inline comment as done. Closed by commit rL332720: Move #include manipulation code to new lib/Tooling/Inclusions. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Changed prior

r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

Author: ioeric Date: Fri May 18 07:16:37 2018 New Revision: 332720 URL: http://llvm.org/viewvc/llvm-project?rev=332720=rev Log: Move #include manipulation code to new lib/Tooling/Inclusions. Summary: clangToolingCore is linked into almost everything (incl. clang), but not few tools need #include

[PATCH] D47069: [ASTImporter] Enable disabled but passing test

martong created this revision. martong added reviewers: a.sidorin, r.stahl, xazax.hun. Herald added subscribers: cfe-commits, dkrupp, rnkovacs. There is a test which passes since https://reviews.llvm.org/D32947, but it was forgotten to be enabled. This patch enables that disabled test.

[PATCH] D47068: Move #include manipulation code to new lib/Tooling/Inclusions.

ioeric marked an inline comment as done. ioeric added inline comments. Comment at: include/clang/Format/Format.h:20 #include "clang/Tooling/Core/Replacement.h" +#include "clang/Tooling/Inclusions/IncludeStyle.h" #include "llvm/ADT/ArrayRef.h" ilya-biryukov

[PATCH] D47068: Move #include manipulation code to new lib/Tooling/Inclusions.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM with a minor naming suggestion. Comment at: include/clang/Format/Format.h:20 #include "clang/Tooling/Core/Replacement.h" +#include

[PATCH] D47068: Move #include manipulation code to new lib/Tooling/Inclusions.

ioeric created this revision. ioeric added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, mgorny, klimek. clangToolingCore is linked into almost everything (incl. clang), but not few tools need #include manipulation at this point. So pull this into a separate library in

[PATCH] D47067: Update NRVO logic to support early return

tzik created this revision. Herald added a subscriber: cfe-commits. The previous implementation misses an opportunity to apply NRVO (Named Return Value Optimization) below. That discourages user to write early return code. --

[PATCH] D47066: [clangd] Remove ignored Preamble::CanReuse call from completion

ilya-biryukov created this revision. ilya-biryukov added reviewers: ioeric, sammccall. Herald added subscribers: jkorous, MaskRay, klimek. Now that the clients who relied on stats for files from preamble are gone. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47066 Files:

[PATCH] D47065: [clangd] Enable parsing of non-doxygen comments in global-symbol-builder

ilya-biryukov created this revision. ilya-biryukov added reviewers: ioeric, sammccall. Herald added subscribers: jkorous, MaskRay, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47065 Files: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp Index:

[PATCH] D47063: [clangd] Keep only a limited number of idle ASTs in memory

ilya-biryukov added a comment. Another alternative that I've considered was evicting the ASTs from memory after a certain period of time, e.g. after 30 seconds of inactivity for some file. This might be simpler and also cover the use-case of speeding up multiple code navigation requests

[PATCH] D46472: [HIP] Support offloading by linker script

yaxunl added a comment. In https://reviews.llvm.org/D46472#1103577, @t-tye wrote: > LGTM except for minor suggestions. Thanks. Will make changes when committing. https://reviews.llvm.org/D46472 ___ cfe-commits mailing list

[PATCH] D47063: [clangd] Keep only a limited number of idle ASTs in memory

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: jkorous, MaskRay, ioeric, javed.absar, klimek. After this commit, clangd will only keep the last 3 accessed ASTs in memory. Preambles for each of the opened files are still kept in memory to

Re: r294879 - [Driver] Use stem() and not filename().

I think this code is probably dead since the stem is "ld.lld" for lld, not "lld". On Sat, Feb 11, 2017 at 7:22 PM, Davide Italiano via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Sat, Feb 11, 2017 at 4:19 PM, Rui Ueyama wrote: > > On Sat, Feb 11, 2017 at 3:44 PM,

[PATCH] D47060: [VFS] Implement getRealPath for OverlayFileSystem.

This revision was automatically updated to reflect the committed changes. Closed by commit rL332717: [VFS] Implement getRealPath for OverlayFileSystem. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47060 Files:

r332717 - [VFS] Implement getRealPath for OverlayFileSystem.

Author: ioeric Date: Fri May 18 06:22:49 2018 New Revision: 332717 URL: http://llvm.org/viewvc/llvm-project?rev=332717=rev Log: [VFS] Implement getRealPath for OverlayFileSystem. Reviewers: bkramer Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D47060 Modified:

[PATCH] D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types

zinovy.nis marked an inline comment as done. zinovy.nis added a comment. Alexander, can you please have a look at the latest patch? Thanks. https://reviews.llvm.org/D45927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus marked 28 inline comments as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:181-182 +/// Returns whether FD can be (transitively) dereferenced to a void pointer type +/// (void*, void**, ...). The type of

[clang-tools-extra] r332716 - Silence a truncation warning; NFC.

Author: aaronballman Date: Fri May 18 06:18:41 2018 New Revision: 332716 URL: http://llvm.org/viewvc/llvm-project?rev=332716=rev Log: Silence a truncation warning; NFC. Modified: clang-tools-extra/trunk/clangd/Quality.cpp Modified: clang-tools-extra/trunk/clangd/Quality.cpp URL:

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:35 + hasSourceExpression(IsFloatExpr), + unless(hasParent(castExpr( +

[PATCH] D47060: [VFS] Implement getRealPath for OverlayFileSystem.

ioeric updated this revision to Diff 147491. ioeric marked an inline comment as done. ioeric added a comment. - Add and use const_iterator. Repository: rC Clang https://reviews.llvm.org/D47060 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus updated this revision to Diff 147485. Szelethus added a comment. In this diff, I preferred placing `TODO`s in places where the logic of the checker would have changed too much. While I didn't have a strict rule for this in mind, I tried changing as little as possible in order to

[PATCH] D47060: [VFS] Implement getRealPath for OverlayFileSystem.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Basic/VirtualFileSystem.cpp:387 + SmallVectorImpl ) const { + // Not using overlays_begin/end because this method is

[PATCH] D47060: [VFS] Implement getRealPath for OverlayFileSystem.

ioeric updated this revision to Diff 147488. ioeric added a comment. Fix test... Repository: rC Clang https://reviews.llvm.org/D47060 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp unittests/Basic/VirtualFileSystemTest.cpp Index:

[PATCH] D47060: [VFS] Implement getRealPath for OverlayFileSystem.

ioeric updated this revision to Diff 147487. ioeric added a comment. Minor cleanup Repository: rC Clang https://reviews.llvm.org/D47060 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp unittests/Basic/VirtualFileSystemTest.cpp Index:

[PATCH] D47060: [VFS] Implement getRealPath for OverlayFileSystem.

ioeric created this revision. ioeric added a reviewer: bkramer. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D47060 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp unittests/Basic/VirtualFileSystemTest.cpp Index:

[PATCH] D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement.

aaron.ballman added inline comments. Comment at: clang-tidy/utils/ExprMutationAnalyzer.cpp:21-25 + for (const auto *Init : Node.capture_inits()) { +if (Init == E) + return true; + } + return false; This can be replaced with `return

r332704 - This patch aims to match the changes introduced

Author: aivchenk Date: Fri May 18 04:56:21 2018 New Revision: 332704 URL: http://llvm.org/viewvc/llvm-project?rev=332704=rev Log: This patch aims to match the changes introduced in gcc by https://gcc.gnu.org/ml/gcc-cvs/2018-04/msg00534.html. The -mibt feature flag is being removed, and the

[PATCH] D46881: [X86][CET] Changing -fcf-protection behavior to comply with gcc (clang part)

This revision was automatically updated to reflect the committed changes. Closed by commit rC332704: This patch aims to match the changes introduced (authored by aivchenk, committed by ). Changed prior to commit: https://reviews.llvm.org/D46881?vs=147292=147476#toc Repository: rC Clang

[PATCH] D46871: [AMDGPU] Add interpolation builtins

timcorringham updated this revision to Diff 147460. timcorringham added a comment. [AMDGPU] Add interpolation builtins Updated LIT test so that it only tests for the existence of the builtins by checking the IR. Repository: rC Clang https://reviews.llvm.org/D46871 Files:

r332699 - Do not try to remove invisible Decls from DeclContext

Author: martong Date: Fri May 18 02:08:47 2018 New Revision: 332699 URL: http://llvm.org/viewvc/llvm-project?rev=332699=rev Log: Do not try to remove invisible Decls from DeclContext Modified: cfe/trunk/lib/AST/DeclBase.cpp cfe/trunk/unittests/AST/ASTImporterTest.cpp Modified:

[PATCH] D46871: [AMDGPU] Add interpolation builtins

arsenm added inline comments. Comment at: include/clang/Basic/BuiltinsAMDGPU.def:103-107 +BUILTIN(__builtin_amdgcn_interp_p1_f16, "ffUiUibUi", "nc") +BUILTIN(__builtin_amdgcn_interp_p2_f16, "hffUiUibUi", "nc") +BUILTIN(__builtin_amdgcn_interp_p1, "ffUiUiUi", "nc")

[PATCH] D47058: [ASTImporter] Fix ClassTemplateSpecialization in wrong DC

martong created this revision. martong added reviewers: a.sidorin, r.stahl, xazax.hun. Herald added subscribers: cfe-commits, dkrupp, rnkovacs. ClassTemplateSpecialization is put in the wrong DeclContex if implicitly instantiated. This patch fixes it. Repository: rC Clang

[PATCH] D47057: [ASTImporter] Fix missing implict CXXRecordDecl in ClassTemplateSpecializationDecl

martong created this revision. martong added reviewers: a.sidorin, xazax.hun, r.stahl. Herald added subscribers: cfe-commits, dkrupp, rnkovacs. Currently we do not import the implicit CXXRecordDecl of a ClassTemplateSpecializationDecl. This patch fixes it. Repository: rC Clang

[PATCH] D46998: [XRay][compiler-rt] Limit reliance on C++ ABI features

dberris updated this revision to Diff 147453. dberris added a comment. - fixup: revert unnecessary change to clang https://reviews.llvm.org/D46998 Files: compiler-rt/lib/xray/xray_basic_logging.cc compiler-rt/test/xray/TestCases/Posix/c-test.cc Index:

[PATCH] D46998: [XRay][compiler-rt] Limit reliance on C++ ABI features

dberris updated this revision to Diff 147451. dberris retitled this revision from "[XRay][clang+compiler-rt] Make XRay depend on a C++ standard lib" to "[XRay][compiler-rt] Limit reliance on C++ ABI features". dberris edited the summary of this revision. dberris added a comment. Retitle, and

[clang-tools-extra] r332701 - Re-enable a clang-move test on windows.

Author: ioeric Date: Fri May 18 02:25:36 2018 New Revision: 332701 URL: http://llvm.org/viewvc/llvm-project?rev=332701=rev Log: Re-enable a clang-move test on windows. This was fixed by r332612. Modified: clang-tools-extra/trunk/test/clang-move/move-class.cpp Modified:

[PATCH] D44954: [clangd] Add "member" symbols to the index

ilya-biryukov added a comment. In https://reviews.llvm.org/D44954#1103664, @malaperle wrote: > It's probably better to consider this in a future patch. Maybe something like > the first suggestion: vector::push_back and match both. Otherwise, I would > think it might be a bit too verbose to

[PATCH] D46835: [ASTImporter] Do not try to remove invisible Decls from DeclContext

martong closed this revision. martong added a comment. Closed by commit: https://reviews.llvm.org/rL332699 Repository: rC Clang https://reviews.llvm.org/D46835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. In https://reviews.llvm.org/D45177#1103781, @alexfh wrote: > In https://reviews.llvm.org/D45177#1103774, @devnexen wrote: > > > In https://reviews.llvm.org/D45177#1103162, @alexfh wrote: > > > > > See https://bugs.llvm.org/show_bug.cgi?id=37503 for a test case. > > > >

<    1   2