jolesiak added a comment.
Herald added a subscriber: acoomans.
I think we should reconsider applying this change, at least for a very common
"#import ".
Repository:
rC Clang
https://reviews.llvm.org/D44634
___
cfe-commits mailing list
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D49074#1156110, @george.karpenkov wrote:
> @baloghadamsoftware @dkrupp @xazax.hun Interesting. What do you think about
> instead using Z3 cross-check functionality recently added, to solve this and
> all other similar problems
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D49074#1156609, @george.karpenkov wrote:
> The overall point is that writing this kind of code is *extremely*
> error-prone.
Every modifications on the core is extremely error-prone. That is why we must
cross check it and only
ilya-biryukov added a comment.
In https://reviews.llvm.org/D48903#1157600, @simark wrote:
> Thanks. I have seen no failures in `check-clang` and `check-clang-tools`, so
> I will push it.
LG! We can always revert the change is anything breaks...
Repository:
rC Clang
JonasToth added inline comments.
Comment at: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:44
bool ) const {
- StringRef Name = Node->getIdentifier()->getName();
- llvm::StringMapConstIterator Pair =
JonasToth added a comment.
Is there a way to add a test, that would trigger the old segfault and show that
it does not happen anymore with this fix?
https://reviews.llvm.org/D49158
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
CarlosAlbertoEnciso added a comment.
@rsmith Is there anything I can add to this patch?
The review
https://reviews.llvm.org/D44826
is already approved and it is dependent on this patch being reviewed.
Thanks very much
https://reviews.llvm.org/D46190
sammccall updated this revision to Diff 154959.
sammccall added a comment.
Add workaround for formatv+error issues.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49008
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdUnit.cpp
omtcyfz updated this revision to Diff 154956.
omtcyfz marked 3 inline comments as done.
omtcyfz added a comment.
Address few comments, add test for macro definition, slightly reformat
`QualityTests.cpp`
https://reviews.llvm.org/D49012
Files:
clang-tools-extra/clangd/Quality.cpp
r.stahl added a comment.
@rsmith Yes, this should generally better be handled outside of the ASTContext.
That would be out of scope of this patch. Is it fine to proceed with this one
for now?
For my usage scenario it actually is convenient this way. In my checker I use
getParents, but if I
baloghadamsoftware added a comment.
Any news regarding this?
https://reviews.llvm.org/D33537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin accepted this revision.
a.sidorin added a comment.
Hello Zoltán,
Sorry for the delay. I think the patch is fine, just some minor nits inline.
Comment at: unittests/AST/ASTImporterTest.cpp:234
+assert(ToAST);
+createVirtualFileIfNeeded(ToAST.get(),
Author: sammccall
Date: Wed Jul 11 03:35:11 2018
New Revision: 336785
URL: http://llvm.org/viewvc/llvm-project?rev=336785=rev
Log:
[clangd] Upgrade logging facilities with levels and formatv.
Summary:
log() is split into four functions:
- elog()/log()/vlog() have different severity levels,
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D49074#1156110, @george.karpenkov wrote:
> @baloghadamsoftware @dkrupp @xazax.hun Interesting. What do you think about
> instead using Z3 cross-check functionality recently added, to solve this and
> all other similar problems
Author: balazske
Date: Wed Jul 11 02:37:24 2018
New Revision: 336776
URL: http://llvm.org/viewvc/llvm-project?rev=336776=rev
Log:
[AST] Structural equivalence of methods
Summary:
Added structural equivalence check for C++ methods.
Improved structural equivalence tests.
Added related ASTImporter
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336776: [AST] Structural equivalence of methods (authored by
balazske, committed by ).
Herald added a subscriber:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336785: [clangd] Upgrade logging facilities with levels and
formatv. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
CaseyCarter added inline comments.
Comment at: include/concepts:175
+template
+_LIBCPP_CONCEPT_DECL Same = __same_impl<_Tp, _Up> && __same_impl<_Up, _Tp>;
+
Quuxplusone wrote:
> CaseyCarter wrote:
> > Quuxplusone wrote:
> > > Peanut gallery asks: From lines
ABataev added a comment.
Tests?
Repository:
rC Clang
https://reviews.llvm.org/D49188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
lgtm assuming you ran this on some large code base to make sure it doesn't have
false positives.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:659
+def
Author: balazske
Date: Wed Jul 11 08:26:26 2018
New Revision: 336817
URL: http://llvm.org/viewvc/llvm-project?rev=336817=rev
Log:
[AST] Fix for structural equivalence tests in rL336776.
Modified:
cfe/trunk/unittests/AST/StructuralEquivalenceTest.cpp
Modified:
Sounds good. Thanks for the suggestion!
On Wed, Jul 11, 2018 at 3:45 PM Sam McCall wrote:
>
>
> On Wed, Jul 11, 2018, 15:18 Eric Liu via Phabricator <
> revi...@reviews.llvm.org> wrote:
>
>> ioeric added a comment.
>>
>> In https://reviews.llvm.org/D49175#1158562, @sammccall wrote:
>>
>> > I
ABataev added a comment.
What about the check for the new function call?
Repository:
rC Clang
https://reviews.llvm.org/D49188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gtbercea updated this revision to Diff 155002.
gtbercea added a comment.
Fix test.
Repository:
rC Clang
https://reviews.llvm.org/D49188
Files:
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
test/OpenMP/nvptx_data_sharing.cpp
Index: test/OpenMP/nvptx_data_sharing.cpp
benhamilton created this revision.
benhamilton added reviewers: Wizard, hokein.
Herald added a subscriber: cfe-commits.
SQL is a common acronym.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49190
Files:
clang-tidy/objc/PropertyDeclarationCheck.cpp
Index:
manojgupta added a comment.
@efriedma @jyknight Does the change match your expectations where warnings are
still generated but codeGen does not emit nonnull attribute?
Comment at: test/Sema/nonnull.c:2
// RUN: %clang_cc1 -fsyntax-only -verify %s
+// RUN: %clang_cc1
ioeric created this revision.
ioeric added reviewers: sammccall, ilya-biryukov.
Herald added subscribers: cfe-commits, jkorous, MaskRay.
Sema code complete in the recovery mode is generally useless. For many
cases, sema first completes in recovery context and then recovers to more useful
context,
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336798: [mips] Add -mvirt,
-mno-virt, -mginv, -mno-ginv options
(authored by vstefanovic, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48982
Files:
ioeric added a comment.
In https://reviews.llvm.org/D49175#1158562, @sammccall wrote:
> I like this idea, of course hard to know how it will affect all practical
> cases.
>
> Is it easy to get have internal stats on how many wins/losses this has?
This would fix bad completion results when
gtbercea created this revision.
gtbercea added reviewers: ABataev, carlo.bertolli, caomhin.
Herald added subscribers: cfe-commits, guansong, jholewinski.
In the SPMD case, we need to initialize the data sharing and globalization
infrastructure. This covers the case when an SPMD region calls a
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE336810: [clangd] Uprank delcarations when using
q::name is present in the main file (authored by omtcyfz, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49012?vs=154969=155001#toc
Author: omtcyfz
Date: Wed Jul 11 07:49:49 2018
New Revision: 336810
URL: http://llvm.org/viewvc/llvm-project?rev=336810=rev
Log:
[clangd] Uprank delcarations when "using q::name" is present in the main file
Having `using qualified::name;` for some symbol is an important signal
for clangd code
Author: omtcyfz
Date: Wed Jul 11 07:49:49 2018
New Revision: 336810
URL: http://llvm.org/viewvc/llvm-project?rev=336810=rev
Log:
[clangd] Uprank delcarations when "using q::name" is present in the main file
Having `using qualified::name;` for some symbol is an important signal
for clangd code
Hahnfeld added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:84-85
OMPRTL_NVPTX__kmpc_data_sharing_init_stack,
+ /// Call to void __kmpc_data_sharing_init_stack_spmd();
+ OMPRTL_NVPTX__kmpc_data_sharing_init_stack_spmd,
/// Call to void*
simark created this revision.
Herald added a subscriber: cfe-commits.
I noticed that when getVirtualFile is called for a file, subsequent
calls to getFile will return a FileEntry without the RealPathName
computed:
const FileEntry *VFE = Mgr->getVirtualFile("/foo/../bar", ...);
const
simark updated this revision to Diff 155027.
simark added a comment.
Update commit message.
Repository:
rC Clang
https://reviews.llvm.org/D49197
Files:
lib/Basic/FileManager.cpp
unittests/Basic/FileManagerTest.cpp
Index: unittests/Basic/FileManagerTest.cpp
simark added a comment.
I'm not sure who should review this patch, please add anybody you think is
qualified/responsible.
Repository:
rC Clang
https://reviews.llvm.org/D49197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
simark added a comment.
Background: I'm trying to fix the cases why we receive a FileEntry without a
real path computed in clangd, so we can avoid having to compute it ourselves.
Repository:
rC Clang
https://reviews.llvm.org/D49197
___
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49190
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ioeric added a comment.
In https://reviews.llvm.org/D48903#1155403, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D48903#1154846, @simark wrote:
>
> > With the `InMemoryFileSystem`, this now returns a non-real path. The
> > result is that we fill `RealPathName` with that non-real path.
Hello Balazs,
This commit broke at least one of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/10897
. . .
Failing Tests (1):
Clang-Unit :: AST/./ASTTests.exe/StructuralEquivalenceRecordTest.Name
Please have a look?
It is not good idea to keep
ioeric added a comment.
In https://reviews.llvm.org/D48903#1159023, @ioeric wrote:
> In https://reviews.llvm.org/D48903#1155403, @ilya-biryukov wrote:
>
> > In https://reviews.llvm.org/D48903#1154846, @simark wrote:
> >
> > > With the `InMemoryFileSystem`, this now returns a non-real path. The
Hello Simon,
This commit added broken tests to one of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/18386/steps/test/logs/stdio
. . .
Failing Tests (4):
Clang :: PCH/case-insensitive-include.c
Clang-Unit ::
gtbercea updated this revision to Diff 155037.
gtbercea added a comment.
Add test for spmd stack init function.
Repository:
rC Clang
https://reviews.llvm.org/D49188
Files:
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
test/OpenMP/nvptx_data_sharing.cpp
test/OpenMP/nvptx_data_sharing_spmd.cpp
simark added a comment.
In https://reviews.llvm.org/D48903#1159023, @ioeric wrote:
> Would you mind reverting this patch for now so that we can come up with a
> solution to address those use cases?
>
> Sorry again about missing the discussion earlier!
Of course, feel free to revert if needed
ioeric added a comment.
In https://reviews.llvm.org/D48903#1159046, @simark wrote:
> In https://reviews.llvm.org/D48903#1159023, @ioeric wrote:
>
> > Would you mind reverting this patch for now so that we can come up with a
> > solution to address those use cases?
> >
> > Sorry again about
martong added a comment.
@gerazo, Do you have commit rights, or should I help with the commit?
https://reviews.llvm.org/D47946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added inline comments.
Comment at: lib/Basic/FileManager.cpp:395
+ SmallString<128> RealPathName;
+ if (!FS->getRealPath(InterndFileName, RealPathName))
+UFE->RealPathName = RealPathName.str();
It seems that at this point, we have failed to find
gtbercea marked 2 inline comments as done.
gtbercea added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:84-85
OMPRTL_NVPTX__kmpc_data_sharing_init_stack,
+ /// Call to void __kmpc_data_sharing_init_stack_spmd();
+
martong added a comment.
Hi Aleksei, could you pleas take an other quick look, there were only minor
changes since your last comments. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D47632
___
cfe-commits mailing list
mstorsjo abandoned this revision.
mstorsjo added a comment.
Herald added a subscriber: chrib.
I choose not to commit this one after all, I managed to work around the issue
with Windows Store apps in a much simpler way by providing a Windows Store
compatible version of EnumProcessModules, see
Author: ioeric
Date: Wed Jul 11 11:43:07 2018
New Revision: 336831
URL: http://llvm.org/viewvc/llvm-project?rev=336831=rev
Log:
Revert "[VirtualFileSystem] InMemoryFileSystem::status: Return a Status with
the requested name"
This reverts commit r336807. This breaks users of
mstorsjo abandoned this revision.
mstorsjo added a comment.
Herald added a subscriber: chrib.
FWIW, I'm not going to put any more effort into this one at the moment, I
managed to fix my use case in a much simpler way by providing a Windows Store
compatible version of EnumProcessModules, see
Hi,
I am aware of the problem, there should be already a commit to (hopefully)
correct the failure.
Balázs Kéri
Galina Kistanova ezt írta (időpont: 2018. júl. 11.,
Sze, 20:01):
> Hello Balazs,
>
> This commit broke at least one of our builders:
>
>
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
This diff fixes a long debated issues with pointers/references not being
dereferenced according to their
fyi, I've reverted this commit with r336831 due to some other issues.
On Wed, Jul 11, 2018 at 8:23 PM Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hello Simon,
>
> This commit added broken tests to one of our builders:
>
>
george.karpenkov added a comment.
> What issues could it cause since it is guarded by an option?
I've meant the rearrangement. Actually, I would like to apologize for that
point, I thought it was causing some issues, but it wasn't, we've just checked
it yesterday.
> As far as I know the
arphaman added a comment.
Thanks for working on this! Please upload the patch with the full context (git
diff -U9). It helps the reviewers :)
In https://reviews.llvm.org/D48845#1158103, @alexshap wrote:
> I'm kind of interested in this fixit, but one thought which i have - probably
> it
simark added inline comments.
Comment at: lib/Basic/FileManager.cpp:395
+ SmallString<128> RealPathName;
+ if (!FS->getRealPath(InterndFileName, RealPathName))
+UFE->RealPathName = RealPathName.str();
ioeric wrote:
> It seems that at this point, we have
Author: rkovacs
Date: Wed Jul 11 12:08:02 2018
New Revision: 336835
URL: http://llvm.org/viewvc/llvm-project?rev=336835=rev
Log:
[analyzer] Track multiple raw pointer symbols in DanglingInternalBufferChecker.
Previously, the checker only tracked one raw pointer symbol for each
container object.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336835: [analyzer] Track multiple raw pointer symbols in
DanglingInternalBufferChecker. (authored by rkovacs, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49057
Files:
Author: erichkeane
Date: Wed Jul 11 12:09:21 2018
New Revision: 336836
URL: http://llvm.org/viewvc/llvm-project?rev=336836=rev
Log:
[NFC] Replace usage of QualType.getTypePtr()-> with operator->
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
URL:
xazax.hun added a comment.
In https://reviews.llvm.org/D49074#1159095, @george.karpenkov wrote:
> > This may remove false-positives (like the example above), but we surely
> > cannot find new errors where multiplicative operations are used.
>
> Do you have examples of those? In my
Author: vstefanovic
Date: Wed Jul 11 05:45:25 2018
New Revision: 336798
URL: http://llvm.org/viewvc/llvm-project?rev=336798=rev
Log:
[mips] Add '-mvirt', '-mno-virt', '-mginv', '-mno-ginv' options
'-mvirt'/'-mno-virt' enables/disables Virtualization ASE.
'-mginv'/'-mno-ginv' enables/disables
Author: ioeric
Date: Wed Jul 11 06:15:31 2018
New Revision: 336801
URL: http://llvm.org/viewvc/llvm-project?rev=336801=rev
Log:
[clangd] Ignore sema code complete callback with recovery context.
Summary:
Sema code complete in the recovery mode is generally useless. For many
cases, sema first
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336807: [VirtualFileSystem] InMemoryFileSystem::status:
Return a Status with the… (authored by simark, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48903?vs=154835=154995#toc
Author: simark
Date: Wed Jul 11 07:08:17 2018
New Revision: 336807
URL: http://llvm.org/viewvc/llvm-project?rev=336807=rev
Log:
[VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the
requested name
Summary:
InMemoryFileSystem::status behaves differently than
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
I like this idea, of course hard to know how it will affect all practical cases.
Is it easy to get have internal stats on how many wins/losses this has?
Comment at:
ioeric updated this revision to Diff 154979.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49175
Files:
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index:
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
Thanks! That's a simple fix that makes things better overall!
LGTM with a NIT about the comment in the test.
Comment at: unittests/clangd/CodeCompleteTests.cpp:797
#if 0
+ // In recorvery mode,
gerazo updated this revision to Diff 154991.
gerazo marked an inline comment as done.
gerazo added a comment.
Minor fixes for Aleksei's comments.
https://reviews.llvm.org/D47946
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
omtcyfz updated this revision to Diff 154969.
omtcyfz added a comment.
Slightly refactor code by making lambda only used once anonymous.
https://reviews.llvm.org/D49012
Files:
clang-tools-extra/clangd/Quality.cpp
clang-tools-extra/unittests/clangd/QualityTests.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336801: [clangd] Ignore sema code complete callback with
recovery context. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
On Wed, Jul 11, 2018, 15:18 Eric Liu via Phabricator <
revi...@reviews.llvm.org> wrote:
> ioeric added a comment.
>
> In https://reviews.llvm.org/D49175#1158562, @sammccall wrote:
>
> > I like this idea, of course hard to know how it will affect all
> practical cases.
> >
> > Is it easy to get
gerazo marked 2 inline comments as done.
gerazo added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:234
+assert(ToAST);
+createVirtualFileIfNeeded(ToAST.get(), It->FileName, It->Code);
+return &*It;
a.sidorin wrote:
> Can we move the
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
As per the previous comment: I have no concerns as long as the documentation is
updated and at least one existing test is changed to use this feature (see the
list in the previous
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with one comment.
Comment at: test/clang-tidy/bugprone-exception-escape.cpp:178
+void indirect_implicit() noexcept {
+ // CHECK-MESSAGES: :[[@LINE-1]]:6:
jkorous added a comment.
Ping. Added reviewers suggestion.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
juliehockett accepted this revision.
juliehockett added a comment.
This revision is now accepted and ready to land.
Remember to mark comments as done when they are. Otherwise, LGTM unless @ioeric
has any concerns.
https://reviews.llvm.org/D48395
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
(removing from my dashboard)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42682
___
cfe-commits mailing list
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:591-609
+// TODO: This function constructs an incorrect string if a void pointer is a
+// part of the chain:
+//
+// struct B { int x; }
+//
+// struct A {
+// void
alexshap added a comment.
> Are you talking about a more conservative warning or a more conservative
> fixit? If it doesn't make sense for us to have a fixit for a particular
> capture, does it make sense for us to have a warning for that >capture in the
> first place?
to be honest i'm more
Author: jfb
Date: Wed Jul 11 12:51:40 2018
New Revision: 336840
URL: http://llvm.org/viewvc/llvm-project?rev=336840=rev
Log:
[NFC] typo
Modified:
cfe/trunk/lib/CodeGen/ConstantEmitter.h
Modified: cfe/trunk/lib/CodeGen/ConstantEmitter.h
URL:
vsk added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1694
// handle things like function to ptr-to-function decay etc.
Value *ScalarExprEmitter::VisitCastExpr(CastExpr *CE) {
Expr *E = CE->getSubExpr();
lebedev.ri wrote:
> vsk wrote:
> > I
Author: petr.pavlu
Date: Wed Jul 11 13:17:54 2018
New Revision: 336842
URL: http://llvm.org/viewvc/llvm-project?rev=336842=rev
Log:
Fix setting of empty implicit-section-name attribute
Code in `CodeGenModule::SetFunctionAttributes()` could set an empty
attribute `implicit-section-name` on a
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336842: Fix setting of empty implicit-section-name attribute
(authored by petr.pavlu, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48916
Files:
lib/CodeGen/CodeGenModule.cpp
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware.
@alexfh provided an example that demonstrates that elided copy constructors may
get agglutinated due
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware.
Copy/move constructors may have additional default arguments and still be
treated as normal copy/move
Author: marshall
Date: Wed Jul 11 19:55:01 2018
New Revision: 336880
URL: http://llvm.org/viewvc/llvm-project?rev=336880=rev
Log:
Turns out that wide literals U"xxx" and u"xxx" are c++11 and later.
Modified:
libcxx/trunk/test/std/strings/string.view/string.view.cons/assign.pass.cpp
NoQ added inline comments.
Comment at: test/Analysis/nullability_nullonly.mm:103
void testObjCARCExplicitZeroInitialization() {
- TestObject * _Nonnull explicitlyZeroInitialized = nil; // expected-warning
{{nil assigned to a pointer which is expected to have non-null value}}
mgrang updated this revision to Diff 155112.
mgrang added a reviewer: hfinkel.
mgrang added a comment.
Added tests for C++ headers search.
https://reviews.llvm.org/D48862
Files:
lib/Driver/ToolChains/Gnu.cpp
lib/Driver/ToolChains/Linux.cpp
jtbandes marked 2 inline comments as done.
jtbandes added a comment.
If I understood your comment correctly, you meant to remove the diagnostic
completely (regardless of whether `-fdigraphs` or `-fno-digraphs` is given, and
regardless of whether digraphs were enabled for the selected language)?
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:432-433
ConstructedObjectKey Key(Item, LC->getCurrentStackFrame());
// FIXME: Currently the state might already contain the marker due to
// incorrect handling of temporaries bound to default
george.karpenkov added a comment.
@rnkovacs Do you have evaluation statistics handy for this checker? How many
bugs it finds, on which projects? How many of those are real bugs?
https://reviews.llvm.org/D49058
___
cfe-commits mailing list
jtbandes updated this revision to Diff 155115.
jtbandes added a comment.
- remove diagnostic; fix formatting
Repository:
rC Clang
https://reviews.llvm.org/D48266
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/Clang.cpp
lib/Frontend/CompilerInvocation.cpp
ioeric added a comment.
After looking at a few more use cases of the in-memory file system, I think a
problem we need to address is the consistency of file paths you get from clang
when using in-mem vfs. The clang-move tests that you have mitigated in
https://reviews.llvm.org/D48951 could be
Quuxplusone added inline comments.
Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:11
+
+ double circleArea = 3.1415926535 * radius * radius;
+
0x8000- wrote:
> Quuxplusone wrote:
> > 0x8000- wrote:
> > > Eugene.Zelenko wrote:
> > > >
0x8000- updated this revision to Diff 155084.
0x8000- added a comment.
Update documentation to clean up formatting
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49114
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/MagicNumbersCheck.cpp
jfb created this revision.
Herald added subscribers: cfe-commits, dexonsmith.
Automatic variable initialization was generating default-aligned stores (which
are deprecated) instead of using the known alignment from the alloca.
Repository:
rC Clang
https://reviews.llvm.org/D49209
Files:
NoQ abandoned this revision.
NoQ added a comment.
Herald added subscribers: mikhail.ramalho, rnkovacs, szepet.
Herald added a reviewer: george.karpenkov.
Outdated by https://reviews.llvm.org/D44131.
https://reviews.llvm.org/D27202
___
cfe-commits
1 - 100 of 137 matches
Mail list logo
