[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

2018-08-06 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D48903#1187605, @simark wrote: > In https://reviews.llvm.org/D48903#1187596, @ilya-biryukov wrote: > > > This revision got 'reopened' and is now in

[PATCH] D48661: [Fixed Point Arithmetic] Fixed Point Constant

2018-08-06 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan added a comment. Sorry for the late response, I've been away. LGTM, although my browser doesn't want to let me set Accepted on this. Comment at: unittests/Basic/FixedPointTest.cpp:380 +} + +// Check the value in a given fixed point sema overflows to the saturated max

[PATCH] D50307: [clang-rename] make clang-rename.py vim integration python3 compatible

2018-08-06 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rC Clang https://reviews.llvm.org/D50307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50211: [analyzer] Fix displayed checker name for InnerPointerChecker

2018-08-06 Thread Reka Kovacs via Phabricator via cfe-commits
rnkovacs updated this revision to Diff 159244. rnkovacs marked an inline comment as done. rnkovacs added a comment. Replace empty `Optional`s with `None`s. https://reviews.llvm.org/D50211 Files: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

2018-08-06 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan added a comment. When I try the test case on our downstream (and when compiling for our target with an extra flag that enables a bunch of OpenCL-related address space code), I get: ascrash.c:5:12: error: comparison between ('__attribute__((address_space(1))) char *' and

[PATCH] D50321: AMDGPU: Add builtin for s_dcache_wb

2018-08-06 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added reviewers: yaxunl, kzhuravl. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng. https://reviews.llvm.org/D50321 Files: include/clang/Basic/BuiltinsAMDGPU.def test/CodeGenOpenCL/builtins-amdgcn-vi.cl

[PATCH] D50320: AMDGPU: Add builtin for s_dcache_inv_vol

2018-08-06 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added reviewers: kzhuravl, yaxunl. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng. https://reviews.llvm.org/D50320 Files: include/clang/Basic/BuiltinsAMDGPU.def test/CodeGenOpenCL/builtins-amdgcn-ci.cl

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

2018-08-06 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak updated this revision to Diff 159250. ahatanak marked 2 inline comments as done. ahatanak added a comment. Address review comments. Repository: rC Clang https://reviews.llvm.org/D50152 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGBlocks.h lib/CodeGen/CGDecl.cpp

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

2018-08-06 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1691 + +Name += "_" + llvm::to_string(E.Capture->getOffset().getQuantity()); + } rjmccall wrote: > I feel like this reads a little better if you write the quantity first. Also > I think

[PATCH] D49945: [Fixed Point Arithmetic] Fix for FixedPointValueToString

2018-08-06 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan accepted this revision. ebevhan added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D49945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44352: [Concepts] Constrained template parameters

2018-08-06 Thread Saar Raz via Phabricator via cfe-commits
saar.raz updated this revision to Diff 159378. saar.raz added a comment. Split TryParseConstrainedParameter and ParseConstrainedTemplateParameter in preparation for requries expressions. Repository: rC Clang https://reviews.llvm.org/D44352 Files: include/clang/AST/DeclTemplate.h

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

2018-08-06 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse added inline comments. Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:129 +<< "br i1 %5, label %6, label %8\n" +<< "; :6:\n" +<< "br label %9\n" emmettneyman wrote: > morehouse wrote: > >

[PATCH] D50361: [NFC] Test automatic variable initialization

2018-08-06 Thread JF Bastien via Phabricator via cfe-commits
jfb created this revision. Herald added subscribers: cfe-commits, dexonsmith. r337887 started using memset for automatic variable initialization where sensible. A follow-up discussion leads me to believe that we should better test automatic variable initialization, and that there are probably

[PATCH] D50211: [analyzer] Fix displayed checker name for InnerPointerChecker

2018-08-06 Thread Reka Kovacs via Phabricator via cfe-commits
rnkovacs added a comment. In https://reviews.llvm.org/D50211#1190146, @NoQ wrote: > Welcome to the club! :D Thanks, makes me feel better. https://reviews.llvm.org/D50211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50281: [lit, python] Always add quotes around the python path in lit

2018-08-06 Thread Stella Stamenova via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL339074: [lit, python] Always add quotes around the python path in lit (authored by stella.stamenova, committed by ).

[PATCH] D50363: [analyzer] pr37204: Take signedness into account in BasicValueFactory::getTruthValue().

2018-08-06 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 159435. NoQ added a comment. Whoops, how did this `T, ` thing get in there. https://reviews.llvm.org/D50363 Files: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h test/Analysis/casts.c test/Analysis/std-c-library-functions-inlined.c

[PATCH] D49952: Check for NULL Destination-Type when creating ArrayConstant

2018-08-06 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer marked an inline comment as done. bviyer added a comment. John, I have updated the test case as you requested (I think). I am a bit new to Clang, so apologize if I mistook your request. https://reviews.llvm.org/D49952 ___ cfe-commits

[PATCH] D50347: Add getBeginLoc API to replace getStartLoc

2018-08-06 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor resigned from this revision. teemperor added a comment. This revision now requires review to proceed. Woops, I wanted to resign actually (and not accept this). Repository: rC Clang https://reviews.llvm.org/D50347 ___ cfe-commits

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

2018-08-06 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. In https://reviews.llvm.org/D50278#1189919, @rjmccall wrote: > I would expect this to replace the existing warning, not to appear together > with it. Will do. Comment at: test/Sema/conditional-expr.c:78 + //

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

2018-08-06 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1643 +if (Ctx.getBlockVarCopyInits(VD)) + return true; + return false; ahatanak wrote: > rjmccall wrote: > > Can you just ask Sema to check `canThrow` for the expression and pass it

r339067 - [analyzer] InnerPointerChecker: fix displayed checker name.

2018-08-06 Thread Reka Kovacs via cfe-commits
Author: rkovacs Date: Mon Aug 6 15:03:42 2018 New Revision: 339067 URL: http://llvm.org/viewvc/llvm-project?rev=339067=rev Log: [analyzer] InnerPointerChecker: fix displayed checker name. For InnerPointerChecker to function properly, both the checker itself and parts of MallocChecker that

[PATCH] D43357: [Concepts] Function trailing requires clauses

2018-08-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. Looking promising, but this patch will need some rework: you need to track the trailing requires clause on the `Declarator` itself, not on the `DeclChunk`, because it's not part of the `DeclChunk` (and may appear in contexts where there is no function chunk).

[PATCH] D40381: Parse concept definition

2018-08-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: include/clang/AST/DeclTemplate.h:3007 +/// \brief Definition of concept, not just declaration actually. +class ConceptDecl : public TemplateDecl { This comment isn't appropriate. Please just describe what the node is.

[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

2018-08-06 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. I mean, which of the callers of startFrontendTimer() is calling it with a pointer to std::declval()? https://reviews.llvm.org/D47196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

2018-08-06 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added a comment. > I think what pointer chasing should do, is check whether that pointer owns > the pointee But ownership is a convention, and it's not always deducible from a codebase. I think of those as two separate checks, and I think we should only talk about enabling the

r339044 - Fix for broken build on clang-hexagon-elf for ambiguous call to

2018-08-06 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Mon Aug 6 12:31:00 2018 New Revision: 339044 URL: http://llvm.org/viewvc/llvm-project?rev=339044=rev Log: Fix for broken build on clang-hexagon-elf for ambiguous call to std::abs. Modified: cfe/trunk/lib/Basic/FixedPoint.cpp Modified:

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

2018-08-06 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak updated this revision to Diff 159388. ahatanak marked 2 inline comments as done. ahatanak added a comment. Address review comments. Repository: rC Clang https://reviews.llvm.org/D50152 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGBlocks.h lib/CodeGen/CGDecl.cpp

[PATCH] D50349: Port getStartLoc -> getBeginLoc

2018-08-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. +Hans (release manager for LLVM 7) Hans, this patch series will affect the API of common Clang classes, resulting in patches to Clang SVN needing some (mechanical) modifications to be applied to the Clang 7 release branch if we land it now. What do you think about that?

[PATCH] D50211: [analyzer] Fix displayed checker name for InnerPointerChecker

2018-08-06 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Welcome to the club! https://reviews.llvm.org/D50211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50352: Mark up deprecated methods as such

2018-08-06 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor added a comment. I don't think Clang/LLVM use `[[deprecated]]` anywhere. Just change the API and people have to migrate their code. Repository: rC Clang https://reviews.llvm.org/D50352 ___ cfe-commits mailing list

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

2018-08-06 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman updated this revision to Diff 159389. emmettneyman added a comment. Added back more descriptive variable and loop names Repository: rC Clang https://reviews.llvm.org/D50342 Files: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp Index:

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

2018-08-06 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:147 + // Example: `int i = 10`, `int i` (will be used if program is correct) + const auto LocalValDecl = varDecl(unless(anyOf( +

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

2018-08-06 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. In https://reviews.llvm.org/D45444#1189262, @aaron.ballman wrote: > However, I'm wondering how this should integrate with other const-correctness > efforts like `readability-non-const-parameter`? I think this check/functionality will kinda replace the

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

2018-08-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. You might want to ask Richard on IRC if there are caveats when using that for these purposes. Repository: rC Clang https://reviews.llvm.org/D50152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50211: [analyzer] Fix displayed checker name for InnerPointerChecker

2018-08-06 Thread Reka Kovacs via Phabricator via cfe-commits
rnkovacs closed this revision. rnkovacs added a comment. Committed in r339067, I just messed up the revision-closing line in the commit message. https://reviews.llvm.org/D50211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

2018-08-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. I would expect this to replace the existing warning, not to appear together with it. Repository: rC Clang https://reviews.llvm.org/D50278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

2018-08-06 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 159409. leonardchan marked 3 inline comments as done. leonardchan added a comment. - Changed tick to single quote in diagnostic Repository: rC Clang https://reviews.llvm.org/D49511 Files: include/clang/AST/Type.h include/clang/Basic/Attr.td

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

2018-08-06 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse added inline comments. Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:127 +<< "define void @foo(i32* %a, i32* %b, i32* %c, i64 %s) {\n" +<< "%1 = icmp sgt i64 %s, 0\n" +<< "br i1 %1, label %start, label

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

2018-08-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:6522 +bool HasDifferingLAddrSpace = LAddrSpace != ResultAddrSpace; +bool HasDifferingRAddrSpace = RAddrSpace != ResultAddrSpace; + I was going to tell you to use the predicate

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

2018-08-06 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman updated this revision to Diff 159421. emmettneyman added a comment. Some small fixes to improve simplicity of generated IR Repository: rC Clang https://reviews.llvm.org/D50342 Files: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp Index:

r339080 - Changed how LLVM IR was generated to increase vectorization

2018-08-06 Thread Emmett Neyman via cfe-commits
Author: emmettneyman Date: Mon Aug 6 16:11:38 2018 New Revision: 339080 URL: http://llvm.org/viewvc/llvm-project?rev=339080=rev Log: Changed how LLVM IR was generated to increase vectorization Summary: Changed the structure of the generated IR to make it easier to vectorize Reviewers:

[PATCH] D50111: [analyzer] Add ASTContext to CheckerManager

2018-08-06 Thread George Karpenkov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC339079: [analyzer] Add ASTContext to CheckerManager (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

2018-08-06 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman updated this revision to Diff 159425. emmettneyman added a comment. Rebased and ready to land Repository: rC Clang https://reviews.llvm.org/D50342 Files: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp Index:

[PATCH] D50348: :Add getEndLoc API to replace getLocEnd

2018-08-06 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D50348 Files: include/clang/AST/Comment.h include/clang/AST/Decl.h include/clang/AST/DeclBase.h include/clang/AST/DeclCXX.h include/clang/AST/DeclObjC.h

[PATCH] D50349: Port getStartLoc -> getBeginLoc

2018-08-06 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. Herald added a reviewer: teemperor. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D50349 Files: include/clang/AST/Decl.h lib/AST/ASTImporter.cpp lib/Analysis/CloneDetection.cpp lib/CodeGen/CoverageMappingGen.cpp

[PATCH] D50347: Add getBeginLoc API to replace getStartLoc

2018-08-06 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. Herald added a reviewer: teemperor. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D50347 Files: include/clang/AST/ExprCXX.h include/clang/AST/Stmt.h include/clang/Analysis/CloneDetection.h

[PATCH] D50346: Add getBeginLoc API to replace getLocStart

2018-08-06 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D50346 Files: include/clang/AST/Comment.h include/clang/AST/Decl.h include/clang/AST/DeclBase.h include/clang/AST/DeclCXX.h include/clang/AST/DeclObjC.h

[PATCH] D50350: Port getLocStart -> getBeginLoc

2018-08-06 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. Herald added subscribers: cfe-commits, jfb, whisperity, jholewinski. Herald added a reviewer: teemperor. Repository: rC Clang https://reviews.llvm.org/D50350 Files: docs/RAVFrontendAction.rst include/clang/AST/Comment.h include/clang/AST/Decl.h

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

2018-08-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: test/Sema/conditional-expr.c:78 + // expected-error@-1{{converting '__attribute__((address_space(2))) int *' to type 'void *' changes address space of pointer}} + //

[PATCH] D50359: Add a new library, libclang-cxx

2018-08-06 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama created this revision. Herald added a subscriber: mgorny. The current libclang.so exports only the symbols required for the stable C api. This is opposed to libLLVM.so, which exports all the symbols from the LLVM libraries, including those from the C++ API. This patch adds

[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

2018-08-06 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus added a comment. If we ignore references, check whether the pointee was constructed within the constructor, and maybe add some other clever heuristics, I'm very much in favor of enabling pointer chasing by enabled. But I totally support disabling it for now.

[PATCH] D50359: Add a new library, libclang-cxx

2018-08-06 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama added a comment. This implements the new library proposed in http://lists.llvm.org/pipermail/cfe-dev/2018-August/058736.html. Repository: rC Clang https://reviews.llvm.org/D50359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

2018-08-06 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:183 + // TODO Implement automatic code transformation to add the 'const'. + diag(Variable->getLocStart(), "variable %0 of type %1 can

[PATCH] D50281: [lit, python] Always add quotes around the python path in lit

2018-08-06 Thread Stella Stamenova via Phabricator via cfe-commits
stella.stamenova updated this revision to Diff 159395. Repository: rC Clang https://reviews.llvm.org/D50281 Files: test/Tooling/clang-diff-json.cpp Index: test/Tooling/clang-diff-json.cpp === ---

[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

2018-08-06 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added a comment. @Szelethus in any case, could you commit this change for now? I'm very keen on seeing the results on a few of our internal projects, and it's much easier to do that once the change is committed. https://reviews.llvm.org/D49438

[PATCH] D50361: [NFC] Test automatic variable initialization

2018-08-06 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. I'm honestly not sure there's anything to review here since it's just showing us what the current behavior is. LMK if I'm not testing something that I should. I'd much rather test current behavior as one patch first, because then the follow-ups show a clear before / after

r339074 - [lit, python] Always add quotes around the python path in lit

2018-08-06 Thread Stella Stamenova via cfe-commits
Author: stella.stamenova Date: Mon Aug 6 15:37:45 2018 New Revision: 339074 URL: http://llvm.org/viewvc/llvm-project?rev=339074=rev Log: [lit, python] Always add quotes around the python path in lit Summary: The issue with the python path is that the path to python on Windows can contain

[PATCH] D50353: Remove deprecated API

2018-08-06 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. Herald added a reviewer: teemperor. Herald added a subscriber: cfe-commits. Herald added a reviewer: teemperor. Repository: rC Clang https://reviews.llvm.org/D50353 Files: include/clang/AST/Comment.h include/clang/AST/Decl.h include/clang/AST/DeclBase.h

[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

2018-08-06 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus added a comment. In https://reviews.llvm.org/D49438#1189772, @george.karpenkov wrote: > > I think what pointer chasing should do, is check whether that pointer owns > > the pointee > > But ownership is a convention, and it's not always deducible from a codebase. How about the

[PATCH] D48661: [Fixed Point Arithmetic] Fixed Point Constant

2018-08-06 Thread Bruno Ricci via Phabricator via cfe-commits
bricci added a comment. Added some comments inline. However I have not looked at the logic too closely and have not looked at the tests at all. Comment at: cfe/trunk/include/clang/AST/ASTContext.h:1966 unsigned char getFixedPointIBits(QualType Ty) const; +

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

2018-08-06 Thread Emmett Neyman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL339080: Changed how LLVM IR was generated to increase vectorization (authored by emmettneyman, committed by ). Changed prior to commit: https://reviews.llvm.org/D50342?vs=159425=159427#toc Repository:

[PATCH] D49952: Check for NULL Destination-Type when creating ArrayConstant

2018-08-06 Thread Balaji Iyer via Phabricator via cfe-commits
bviyer updated this revision to Diff 159353. https://reviews.llvm.org/D49952 Files: lib/CodeGen/CGExprConstant.cpp test/CodeGenCXX/empty-struct-init-list.cpp Index: test/CodeGenCXX/empty-struct-init-list.cpp === --- /dev/null

r339048 - [MinGW] Predefine UNICODE if -municode is specified during compilation

2018-08-06 Thread Martin Storsjo via cfe-commits
Author: mstorsjo Date: Mon Aug 6 12:48:44 2018 New Revision: 339048 URL: http://llvm.org/viewvc/llvm-project?rev=339048=rev Log: [MinGW] Predefine UNICODE if -municode is specified during compilation Differential Revision: https://reviews.llvm.org/D50199 Modified:

[PATCH] D50199: [MinGW] Predefine UNICODE if -municode is specified during compilation

2018-08-06 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC339048: [MinGW] Predefine UNICODE if -municode is specified during compilation (authored by mstorsjo, committed by ). Repository: rC Clang https://reviews.llvm.org/D50199 Files:

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

2018-08-06 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman updated this revision to Diff 159373. emmettneyman added a comment. Changed pc to unknown Repository: rC Clang https://reviews.llvm.org/D50342 Files: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp Index:

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

2018-08-06 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman added inline comments. Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:125 std::ostream <<(std::ostream , const LoopFunction ) { - return os << "define void @foo(i32* %a, i32* %b, i32* noalias %c, i64 %s) {\n" -<< "%i =

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

2018-08-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: test/Sema/conditional-expr.c:78 + // expected-error@-1{{converting '__attribute__((address_space(2))) int *' to type 'void *' changes address space of pointer}} + //

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

2018-08-06 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 159405. leonardchan marked an inline comment as done. leonardchan added a comment. - Replaced instances of a `pointer type mismatch` warning involving 2 conditional operands with different address spaces with a new error specifically for this situation.

r339079 - [analyzer] Add ASTContext to CheckerManager

2018-08-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Aug 6 16:09:07 2018 New Revision: 339079 URL: http://llvm.org/viewvc/llvm-project?rev=339079=rev Log: [analyzer] Add ASTContext to CheckerManager Some checkers require ASTContext. Having it in the constructor saves a lot of boilerplate of having to pass it

[PATCH] D41217: [Concepts] Concept Specialization Expressions

2018-08-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: include/clang/AST/ExprCXX.h:4420 + /// \brief The concept named. + ConceptDecl *NamedConcept; + You should also track the `FoundDecl` and the optional `NestedNameSpecifierLoc` (just like a `DeclRefExpr` would).

[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

2018-08-06 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus added a comment. I think what pointer chasing should do, is check whether that pointer owns the pointee. In that case, it should be fine to analyze it. Do you mind if I put a TODO around flag's description stating that this should be implemented and pointer chasing should be enabled

[PATCH] D50355: Port getLocEnd -> getEndLoc

2018-08-06 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. Herald added subscribers: cfe-commits, kbarton, ioeric, nemanjai. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50355 Files: change-namespace/ChangeNamespace.cpp clang-move/ClangMove.cpp clang-tidy/android/CloexecCheck.cpp

[PATCH] D49952: Check for NULL Destination-Type when creating ArrayConstant

2018-08-06 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Sure, that's fine. https://reviews.llvm.org/D49952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

2018-08-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1630 +if (const CXXDestructorDecl *DD = RD->getDestructor()) + if (const auto FPT = DD->getType()->getAs()) +// Conservatively assume the destructor can throw if the exception

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

2018-08-06 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth updated this revision to Diff 159390. JonasToth marked 4 inline comments as done. JonasToth added a comment. - address review issues, todos/fixmes and diag nit Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

Re: r337005 - [NFC] Rename clang::AttributeList to clang::ParsedAttr

2018-08-06 Thread Michael Kruse via cfe-commits
Thank you. Michael 2018-08-06 13:13 GMT-05:00 Keane, Erich : > Good grief... I even made a note to remove this 'TODO' on my whiteboard! > > I discussed the name with AaronBallman who preferred ParsedAttr over > ParsedAttribute (since ParsedAttributes is also a type). > > Fixed in r339039. > >

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

2018-08-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1643 +if (Ctx.getBlockVarCopyInits(VD)) + return true; + return false; ahatanak wrote: > ahatanak wrote: > > rjmccall wrote: > > > Can you just ask Sema to check `canThrow` for the

[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

2018-08-06 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus added a comment. I'll be back in office tomorrow, about ~13 hours later. But feel free to commit it on my behalf if it's urgent. https://reviews.llvm.org/D49438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r339063 - [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

2018-08-06 Thread Simon Marchi via cfe-commits
Author: simark Date: Mon Aug 6 14:48:20 2018 New Revision: 339063 URL: http://llvm.org/viewvc/llvm-project?rev=339063=rev Log: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name Summary: InMemoryFileSystem::status behaves differently than

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

2018-08-06 Thread Simon Marchi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC339063: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the… (authored by simark, committed by ). Changed prior to commit: https://reviews.llvm.org/D48903?vs=158625=159401#toc

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

2018-08-06 Thread Simon Marchi via Phabricator via cfe-commits
simark added a comment. In https://reviews.llvm.org/D48903#1189056, @ilya-biryukov wrote: > I see, thanks for the explanation. > > LGTM for the update revision, given we have confirmation the tests pass on > Windows. Thanks, I'll push it, let's hope this time is the right time! Repository:

[PATCH] D50363: [analyzer] pr37204: Take signedness into account in BasicValueFactory::getTruthValue().

2018-08-06 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware, eraman. I don't see why BasicValueFactory::getTruthValue(bool, QualType) always returns an unsigned

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

2018-08-06 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman added inline comments. Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:127 +<< "define void @foo(i32* %a, i32* %b, i32* %c, i64 %s) {\n" +<< "%1 = icmp sgt i64 %s, 0\n" +<< "br i1 %1, label %start, label

[PATCH] D50291: [C++] Delay checking of constexpr-ness for special members.

2018-08-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:6045 // Inform the class that we've finished declaring this member. Record->finishedDefaultedOrDeletedMember(M); M->setTrivialForCall( Your new handling should go

[PATCH] D50372: Introduce the VTable interleaving scheme to the CFI design documentation

2018-08-06 Thread Zhaomo Yang via Phabricator via cfe-commits
zhaomo created this revision. zhaomo added reviewers: pcc, vlad.tsyrklevich. Herald added a subscriber: cfe-commits. Dimitar et. al. in [1] proposed a novel VTable layout scheme that enables efficient implementation of virtual call CFI. This patch adds an introduction of this scheme to the CFI

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

2018-08-06 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. In https://reviews.llvm.org/D45045#1189201, @vext01 wrote: > Hi, > > I've been experimenting some more with this patch. > > It seems to me that if a label is optimised away, but you've requested it be > preserved, then you get a DWARF label with a zero offset. Is that

[PATCH] D50088: [Sema] Fix an error with C++17 auto non-type template parameters

2018-08-06 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington updated this revision to Diff 159449. erik.pilkington retitled this revision from "[Sema] Dig through AutoTypes that have been deduced to an undeduced AutoType in Type::isUndeducedType" to "[Sema] Fix an error with C++17 auto non-type template parameters". erik.pilkington edited

Re: r338301 - Avoid returning an invalid end source loc

2018-08-06 Thread David Blaikie via cfe-commits
test case? On Mon, Jul 30, 2018 at 1:39 PM Stephen Kelly via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: steveire > Date: Mon Jul 30 13:39:14 2018 > New Revision: 338301 > > URL: http://llvm.org/viewvc/llvm-project?rev=338301=rev > Log: > Avoid returning an invalid end source loc

[PATCH] D49627: [CFG] [analyzer] Constructors of member CXXOperatorCallExpr's argument 0 are not argument constructors.

2018-08-06 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC339087: [analyzer] NFC: Document that we support implicit argument constructors. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D49627 Files:

r339087 - [analyzer] NFC: Document that we support implicit argument constructors.

2018-08-06 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Mon Aug 6 19:22:59 2018 New Revision: 339087 URL: http://llvm.org/viewvc/llvm-project?rev=339087=rev Log: [analyzer] NFC: Document that we support implicit argument constructors. The change in the AST in r338135 caused us to accidentally support inlining constructors of

[PATCH] D50363: [analyzer] pr37204: Take signedness into account in BasicValueFactory::getTruthValue().

2018-08-06 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC339088: [analyzer] pr37204: Take signedness into account in getTruthValue(). (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D50363?vs=159435=159446#toc

r339088 - [analyzer] pr37204: Take signedness into account in getTruthValue().

2018-08-06 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Mon Aug 6 19:27:38 2018 New Revision: 339088 URL: http://llvm.org/viewvc/llvm-project?rev=339088=rev Log: [analyzer] pr37204: Take signedness into account in getTruthValue(). It now actually produces a signed APSInt when the QualType passed into it is signed, which is

[PATCH] D50361: [NFC] Test automatic variable initialization

2018-08-06 Thread JF Bastien via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC339089: [NFC] Test automatic variable initialization (authored by jfb, committed by ). Changed prior to commit: https://reviews.llvm.org/D50361?vs=159397=159448#toc Repository: rC Clang

r339089 - [NFC] Test automatic variable initialization

2018-08-06 Thread JF Bastien via cfe-commits
Author: jfb Date: Mon Aug 6 20:12:52 2018 New Revision: 339089 URL: http://llvm.org/viewvc/llvm-project?rev=339089=rev Log: [NFC] Test automatic variable initialization Summary: r337887 started using memset for automatic variable initialization where sensible. A follow-up discussion leads me

r339093 - Auto var init test fix #2

2018-08-06 Thread JF Bastien via cfe-commits
Author: jfb Date: Mon Aug 6 21:44:13 2018 New Revision: 339093 URL: http://llvm.org/viewvc/llvm-project?rev=339093=rev Log: Auto var init test fix #2 It turns out that the AVX bots have different alignment for their vectors, and my test mistakenly assumed a particular vector alignent on the

[PATCH] D50372: Introduce the VTable interleaving scheme to the CFI design documentation

2018-08-06 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. Please upload patches with context. `arc diff` will do this for you. Comment at: clang/docs/ControlFlowIntegrityDesign.rst:277 +Forward-Edge CFI for Virtual Calls by Interleaving Virtual Tables

r339090 - Remove broken command flag

2018-08-06 Thread JF Bastien via cfe-commits
Author: jfb Date: Mon Aug 6 21:03:03 2018 New Revision: 339090 URL: http://llvm.org/viewvc/llvm-project?rev=339090=rev Log: Remove broken command flag I was using it for testing, r339089 shouldn't have contained it. Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp Modified:

[PATCH] D49658: [clangd] Index Interfaces for Xrefs

2018-08-06 Thread Haojian Wu via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL339011: [clangd] Index Interfaces for Xrefs (authored by hokein, committed by ). Herald added a subscriber: llvm-commits.

[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

2018-08-06 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus updated this revision to Diff 159291. Szelethus added a comment. Fixed the comments. https://reviews.llvm.org/D49438 Files: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp test/Analysis/cxx-uninitialized-object-inheritance.cpp

[PATCH] D50144: Add Windows support for the GNUstep Objective-C ABI V2.

2018-08-06 Thread David Chisnall via Phabricator via cfe-commits
theraven updated this revision to Diff 159293. theraven added a comment. - Fix an issue in protocol generation. Repository: rC Clang https://reviews.llvm.org/D50144 Files: include/clang/Driver/Options.td lib/AST/MicrosoftMangle.cpp lib/CodeGen/CGBlocks.cpp

  1   2   >