[libcxx] r339218 - [libcxx] [test] Avoid -Wunused-local-typedef in node_handle.pass.cpp.

Author: bion Date: Tue Aug 7 21:24:47 2018 New Revision: 339218 URL: http://llvm.org/viewvc/llvm-project?rev=339218=rev Log: [libcxx] [test] Avoid -Wunused-local-typedef in node_handle.pass.cpp. Modified: libcxx/trunk/test/std/containers/container.node/node_handle.pass.cpp Modified:

[PATCH] D50144: Add Windows support for the GNUstep Objective-C ABI V2.

theraven added a comment. I'd like to commit this, unless @rjmccall has any objections. Repository: rC Clang https://reviews.llvm.org/D50144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

JonasToth added a comment. No nothing. I think it is barely noticable in general. From prior long runs i notices the scrambled messages, but it was only a small fraction. So most of the time the threads dont seem to interfere, which makes the lock kinda low-cost. Am 07.08.2018 um 19:17 schrieb

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 159537. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/clang-tidy/checks/abseil-duration-division.rst

[PATCH] D50154: [clangd] capitalize diagnostic messages

arphaman added a comment. In https://reviews.llvm.org/D50154#1191002, @dblaikie wrote: > What's the motivation for clangd to differ from clang here? (& if the first > letter is going to be capitalized, should there be a period at the end? But > also the phrasing of most/all diagnostic text

[PATCH] D50168: [Builtins] Implement __builtin_clrsb to be compatible with gcc

craig.topper added a comment. Ping https://reviews.llvm.org/D50168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r339158 - [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp)

Author: greened Date: Tue Aug 7 10:44:43 2018 New Revision: 339158 URL: http://llvm.org/viewvc/llvm-project?rev=339158=rev Log: [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp) lld is the only supported linker that works for WebAssembly, so ensure clang is using it for this

[PATCH] D49897: [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp)

This revision was automatically updated to reflect the committed changes. Closed by commit rC339158: [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp) (authored by greened, committed by ). Repository: rC Clang https://reviews.llvm.org/D49897 Files:

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

ahatanak updated this revision to Diff 159546. ahatanak marked an inline comment as done. ahatanak added a reviewer: rsmith. ahatanak added a comment. Herald added a subscriber: jfb. Address review comments. Repository: rC Clang https://reviews.llvm.org/D50152 Files:

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

On Tue, Aug 7, 2018 at 10:33 AM Alex Lorenz via Phabricator < revi...@reviews.llvm.org> wrote: > arphaman added a comment. > > In https://reviews.llvm.org/D50154#1191002, @dblaikie wrote: > > > What's the motivation for clangd to differ from clang here? (& if the > first > > letter is going to

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

ahatanak added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1643 +if (Ctx.getBlockVarCopyInits(VD)) + return true; + return false; rjmccall wrote: > ahatanak wrote: > > ahatanak wrote: > > > rjmccall wrote: > > > > Can you just ask Sema to

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

ahatanak updated this revision to Diff 159553. ahatanak added a comment. Remove a stale comment and add an assertion to check the destructor's exception specification has been resolved. Repository: rC Clang https://reviews.llvm.org/D50152 Files: include/clang/AST/ComputeExceptionSpec.h

[PATCH] D50118: [VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks for the clean up! LGTM https://reviews.llvm.org/D50118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50395: [WebAssembly] Remove use of lld -flavor flag

ruiu accepted this revision. ruiu added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D50395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

On Tue, Aug 7, 2018 at 11:22 AM Alex L wrote: > On Tue, 7 Aug 2018 at 10:52, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> >> On Tue, Aug 7, 2018 at 10:33 AM Alex Lorenz via Phabricator < >> revi...@reviews.llvm.org> wrote: >> >>> arphaman added a comment. >>> >>>

[PATCH] D50395: [WebAssembly] Remove use of lld -flavor flag

sbc100 updated this revision to Diff 159562. sbc100 added a comment. - update tests Repository: rC Clang https://reviews.llvm.org/D50395 Files: lib/Driver/ToolChains/WebAssembly.cpp lib/Driver/ToolChains/WebAssembly.h test/Driver/wasm-toolchain.c test/Driver/wasm-toolchain.cpp

[PATCH] D50403: AlignConsecutiveAssignments

PDoakORNL created this revision. PDoakORNL added a project: clang. Herald added a subscriber: cfe-commits. Expanding AlignConsecutiveAssignments to compound assignments. Repository: rC Clang https://reviews.llvm.org/D50403 Files: include/clang/Format/Format.h

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

gtbercea updated this revision to Diff 159574. gtbercea added a comment. Prevent math builtins from being used for nvptx toolchain. Repository: rC Clang https://reviews.llvm.org/D47849 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChains/Clang.cpp

[PATCH] D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM

hans added a comment. What do you other reviewers say? I'm not familiar with this code, but this seems reasonable to me. Repository: rCXXA libc++abi https://reviews.llvm.org/D50170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50349: Port getStartLoc -> getBeginLoc

hans added a comment. In https://reviews.llvm.org/D50349#1190029, @rsmith wrote: > +Hans (release manager for LLVM 7) > > Hans, this patch series will affect the API of common Clang classes, > resulting in patches to Clang SVN needing some (mechanical) modifications to > be applied to the

[PATCH] D49223: [AST] Check described template at structural equivalence check.

balazske updated this revision to Diff 159458. balazske marked an inline comment as done. balazske added a comment. - Renamed methods, simplified code, comments updated. Repository: rC Clang https://reviews.llvm.org/D49223 Files: include/clang/AST/ASTStructuralEquivalence.h

[PATCH] D50321: AMDGPU: Add builtin for s_dcache_wb

arsenm closed this revision. arsenm added a comment. r339110 https://reviews.llvm.org/D50321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50320: AMDGPU: Add builtin for s_dcache_inv_vol

arsenm closed this revision. arsenm added a comment. r339109 https://reviews.llvm.org/D50320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r338627 - [test] Fix %hmaptool path for standalone builds

Merged to 7.0 in r339102. On Wed, Aug 1, 2018 at 10:38 PM, Michal Gorny via cfe-commits wrote: > Author: mgorny > Date: Wed Aug 1 13:38:22 2018 > New Revision: 338627 > > URL: http://llvm.org/viewvc/llvm-project?rev=338627=rev > Log: > [test] Fix %hmaptool path for standalone builds > > Fix

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

ebevhan added a comment. I think the solution to a lot of diagnostic and behavior issues with address spaces is to remove predication on OpenCL. It's a bit odd to have a language feature that is enabled out of the box regardless of langoptions (address spaces) but won't actually work properly

r339109 - AMDGPU: Add builtin for s_dcache_inv_vol

Author: arsenm Date: Tue Aug 7 00:49:04 2018 New Revision: 339109 URL: http://llvm.org/viewvc/llvm-project?rev=339109=rev Log: AMDGPU: Add builtin for s_dcache_inv_vol Added: cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn-ci.cl cfe/trunk/test/SemaOpenCL/builtins-amdgcn-error-ci.cl

r339110 - AMDGPU: Add builtin for s_dcache_wb

Author: arsenm Date: Tue Aug 7 00:49:13 2018 New Revision: 339110 URL: http://llvm.org/viewvc/llvm-project?rev=339110=rev Log: AMDGPU: Add builtin for s_dcache_wb Added: cfe/trunk/test/SemaOpenCL/builtins-amdgcn-error-vi.cl Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def

[PATCH] D46892: [X86] Lowering adds/addus/subs/subus intrinsics to native IR (Clang part)

tkrupa updated this revision to Diff 159461. tkrupa added a comment. Removed signed intrinsics lowering due to the pattern being too complicated - instead some minor optimizations were introduced on LLVM side. Repository: rC Clang https://reviews.llvm.org/D46892 Files:

[PATCH] D50341: [libcxx] Mark aligned allocation tests as XFAIL on old OSX versions

vsapsai added inline comments. Comment at: libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align.fail.cpp:15 // UNSUPPORTED: c++98, c++03, c++11, c++14, c++17 // UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7,

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

shuaiwang added a comment. > - there seems to be a false positive with array-to-pointer decay. > ExprMutAnalyzer does think of it, but maybe there is a bug in it. Could you give a concrete example of this? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444

[PATCH] D50421: [libcxx] [test] Remove assertion that includes and .

BillyONeal updated this revision to Diff 159632. BillyONeal added a comment. Remove comma. https://reviews.llvm.org/D50421 Files: test/std/utilities/template.bitset/includes.pass.cpp Index: test/std/utilities/template.bitset/includes.pass.cpp

[libcxx] r339212 - [libcxx] [test] Remove asserts that and are included by

Author: bion Date: Tue Aug 7 17:43:38 2018 New Revision: 339212 URL: http://llvm.org/viewvc/llvm-project?rev=339212=rev Log: [libcxx] [test] Remove asserts that and are included by Reviewed as https://reviews.llvm.org/D50421 Modified:

[PATCH] D50421: [libcxx] [test] Remove assertion that includes and .

BillyONeal closed this revision. BillyONeal marked 2 inline comments as done. BillyONeal added a comment. Committed r339212 https://reviews.llvm.org/D50421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

On 7 August 2018 at 17:40, Fangrui Song wrote: > > On 2018-08-07, David Blaikie wrote: > >> >> On Tue, Aug 7, 2018 at 4:02 PM Alex L wrote: >> >>On Tue, 7 Aug 2018 at 11:38, David Blaikie wrote: >> >>On Tue, Aug 7, 2018 at 11:22 AM Alex L wrote: >> >>On Tue, 7 Aug 2018

[PATCH] D50415: [clangd] extend the publishDiagnostics response to send back fixits to the client directly as well (if requested)

sammccall added subscribers: ilya-biryukov, jkorous. sammccall added a comment. Couple of thoughts. (Technically I'm out on leave so will let Jan/Ilya review implementation and happy with whatever you decide) Enabling - negotiating LSP extensions is probably better done in the "capabilities"

Re: [PATCH] D50415: [clangd] extend the publishDiagnostics response to send back fixits to the client directly as well (if requested)

Couple of thoughts. (Technically I'm out on leave so will let Jan/Ilya review implementation and happy with whatever you decide) Enabling - negotiating LSP extensions is probably better done in the "capabilities" message exchange than as a command-line flag. Generally, we want this extension on

[PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

george.karpenkov added a comment. @rnk As discussed, would it be acceptable for you to just have empty sanitizer runtime files in the resource directory? Repository: rL LLVM https://reviews.llvm.org/D15225 ___ cfe-commits mailing list

[PATCH] D43357: [Concepts] Function trailing requires clauses

saar.raz added inline comments. Comment at: lib/Sema/SemaDecl.cpp:8377-8381 + } else if (D.hasTrailingRequiresClause()) { +// C++2a [class.virtual]p6 +// A virtual method shall not have a requires-clause. +

r339188 - Fix one hard coded value I missed in r339185.

Author: dyung Date: Tue Aug 7 14:37:14 2018 New Revision: 339188 URL: http://llvm.org/viewvc/llvm-project?rev=339188=rev Log: Fix one hard coded value I missed in r339185. Modified: cfe/trunk/test/CodeGenOpenCL/enqueue-kernel-non-entry-block.cl Modified:

Re: r338301 - Avoid returning an invalid end source loc

Hi David, I'm happy to add a test case, but I don't know how to catch this case. It's not obvious to me if any code path intentionally creates a DeclarationNameInfo with a valid start loc and an invalid end loc. Can you suggest a test case? Thanks, Stephen. On 07/08/18 03:23, David

[PATCH] D50412: Fix pointer-to-integer cast warnings on LLP64.

cdavis5x updated this revision to Diff 159607. cdavis5x added a comment. Rebasing against HEAD. Repository: rUNW libunwind https://reviews.llvm.org/D50412 Files: src/UnwindLevel1-gcc-ext.c src/UnwindLevel1.c Index: src/UnwindLevel1.c

r339196 - [NFC] Improve auto-var-init alignment check

Author: jfb Date: Tue Aug 7 15:43:44 2018 New Revision: 339196 URL: http://llvm.org/viewvc/llvm-project?rev=339196=rev Log: [NFC] Improve auto-var-init alignment check We're not actually testing for alignment, we just want to know that whatever incoming alignment got propagated. Do that by

[PATCH] D50418: [Sema] Support for P0961R1: Relaxing the structured bindings customization point finding rules

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1118-1130 +// ... and if that finds at least one declaration that is a function +// template whose first template parameter is a non-type parameter ... +LookupResult::Filter Filter =

[libcxx] r339209 - [libcxx] [test] Add missing in several tests.

Author: bion Date: Tue Aug 7 17:40:32 2018 New Revision: 339209 URL: http://llvm.org/viewvc/llvm-project?rev=339209=rev Log: [libcxx] [test] Add missing in several tests. Reviewed as https://reviews.llvm.org/D50420 Modified:

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

On 2018-08-07, David Blaikie wrote: On Tue, Aug 7, 2018 at 4:02 PM Alex L wrote: On Tue, 7 Aug 2018 at 11:38, David Blaikie wrote: On Tue, Aug 7, 2018 at 11:22 AM Alex L wrote: On Tue, 7 Aug 2018 at 10:52, David Blaikie via cfe-commits <

[PATCH] D50420: [libcxx] [test] Add missing to several tests.

BillyONeal closed this revision. BillyONeal added a comment. Committed r339209 https://reviews.llvm.org/D50420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50413: [libunwind][include] Add some missing definitions to .

cdavis5x created this revision. cdavis5x added reviewers: mstorsjo, rnk, compnerd, smeenai. Herald added subscribers: cfe-commits, chrib, christof, krytarowski. Add these declarations which should be present in ``, but aren't. Not that it matters, since most of the time we'll be using Clang's ``

r339199 - [VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended.

Author: vsapsai Date: Tue Aug 7 16:00:40 2018 New Revision: 339199 URL: http://llvm.org/viewvc/llvm-project?rev=339199=rev Log: [VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended. First and subsequent iteration steps are similar, capture this similarity. Reviewers: bruno,

[PATCH] D50118: [VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended.

This revision was automatically updated to reflect the committed changes. Closed by commit rC339199: [VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D50118?vs=158420=159614#toc

[PATCH] D50421: [libcxx] [test] Remove assertion that includes and .

BillyONeal created this revision. BillyONeal added reviewers: mclow.lists, EricWF. [template.bitset] says only that and are included by , but libcxx tests are asserting that and are also included. Note that libcxx's nonstandard assertion of this is already handled by

r339207 - [CodeGen] IncompleteArray Support

Author: bviyer Date: Tue Aug 7 17:01:21 2018 New Revision: 339207 URL: http://llvm.org/viewvc/llvm-project?rev=339207=rev Log: [CodeGen] IncompleteArray Support Added code to support ArrayType that is not ConstantArray. https://reviews.llvm.org/D49952 rdar://42476155 Added:

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

ahatanak added a comment. Since BlockVarCopyInits is a map with key `VarDecl *`, I think we want to add a flag to VarDecl (NonParmVarDeclBits) that indicates whether the copy expression can throw or not. Or is there a reason to store the bit in `BlockDecl::Capture` instead? Repository: rC

r339216 - Fixed a breaking test case

Author: bviyer Date: Tue Aug 7 19:47:28 2018 New Revision: 339216 URL: http://llvm.org/viewvc/llvm-project?rev=339216=rev Log: Fixed a breaking test case Modified: cfe/trunk/test/CodeGenCXX/empty-struct-init-list.cpp Modified: cfe/trunk/test/CodeGenCXX/empty-struct-init-list.cpp URL:

[PATCH] D50412: [libunwind] Fix pointer-to-integer cast warnings on LLP64.

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM Repository: rUNW libunwind https://reviews.llvm.org/D50412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r338301 - Avoid returning an invalid end source loc

Ok, I can look into adding the assertion and run the tests with it to see if anything comes up. I made a tool which dumps SourceLocations reachable from an AST node (I intend to integrate it into clang-query), and I noticed the large amount of mixing of get{Start,End}Loc and

[PATCH] D50412: Fix pointer-to-integer cast warnings on LLP64.

cdavis5x created this revision. cdavis5x added reviewers: mstorsjo, rnk, compnerd, smeenai. Herald added subscribers: cfe-commits, christof. `long` is too short on LLP64. We have to use `intptr_t` to avoid truncating pointers. Repository: rUNW libunwind https://reviews.llvm.org/D50412

[PATCH] D50344: [libc++] Enable aligned allocation based on feature test macro, irrespective of standard

vsapsai added inline comments. Comment at: libcxx/include/__config:993 +!defined(_LIBCPP_BUILDING_LIBRARY) && \ +!defined(__cpp_aligned_new) +# define _LIBCPP_HAS_NO_ALIGNED_ALLOCATION I think I'd rather keep `__cpp_aligned_new >= 201606` check. I don't

[PATCH] D50372: Introduce the VTable interleaving scheme to the CFI design documentation

zhaomo updated this revision to Diff 159606. zhaomo added a comment. Updated version of the patch https://reviews.llvm.org/D50372 Files: clang/docs/ControlFlowIntegrityDesign.rst Index: clang/docs/ControlFlowIntegrityDesign.rst

r339198 - [Sema] Ensure an auto non-type template parameter is dependent

Author: epilk Date: Tue Aug 7 15:59:02 2018 New Revision: 339198 URL: http://llvm.org/viewvc/llvm-project?rev=339198=rev Log: [Sema] Ensure an auto non-type template parameter is dependent The dependent auto was getting stripped away while rebuilding the template parameter type, so substitute

[PATCH] D50088: [Sema] Fix an error with C++17 auto non-type template parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rL339198: [Sema] Ensure an auto non-type template parameter is dependent (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D50088: [Sema] Fix an error with C++17 auto non-type template parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rC339198: [Sema] Ensure an auto non-type template parameter is dependent (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D50088?vs=159449=159612#toc Repository:

[PATCH] D50168: [Builtins] Implement __builtin_clrsb to be compatible with gcc

craig.topper updated this revision to Diff 159627. craig.topper added a comment. Add the test case that I failed to pick up in the original diff. https://reviews.llvm.org/D50168 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtin_clrsb.c Index:

[PATCH] D50421: [libcxx] [test] Remove assertion that includes and .

BillyONeal added inline comments. Comment at: test/std/utilities/template.bitset/includes.pass.cpp:11 +// test that includes , and #include template void test_typedef() {} Quuxplusone wrote: > grammar nit: comma NP: Oxford Comma by Vampire Weekend

Re: r339210 - PR38286: Don't crash when attempting to define a constructor for an

Would be good to get this into the Clang 7 release. On Tue, 7 Aug 2018 at 17:43, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Tue Aug 7 17:42:42 2018 > New Revision: 339210 > > URL: http://llvm.org/viewvc/llvm-project?rev=339210=rev > Log: >

[libcxx] r339213 - [libcxx] [test] Remove nonportable locale assumption in basic.ios.members/narrow.pass.cpp

Author: bion Date: Tue Aug 7 17:47:29 2018 New Revision: 339213 URL: http://llvm.org/viewvc/llvm-project?rev=339213=rev Log: [libcxx] [test] Remove nonportable locale assumption in basic.ios.members/narrow.pass.cpp I'm not sure if libcxx is asserting UTF-8 here; but on Windows the full char

[PATCH] D47395: [libcxx] [test] Remove nonportable locale assumption in basic.ios.members/narrow.pass.cpp

BillyONeal added a comment. Committed r339213 (If there are changes requested I'll do them in a follow up commit) https://reviews.llvm.org/D47395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47395: [libcxx] [test] Remove nonportable locale assumption in basic.ios.members/narrow.pass.cpp

BillyONeal added a reviewer: ldionne. BillyONeal added a comment. Adding ldionne as suggested by Eric. https://reviews.llvm.org/D47395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47400: [libcxx] [test] Allow a standard library that implements LWG 1203 in istream.rvalue/rvalue.pass.cpp

BillyONeal added a reviewer: ldionne. BillyONeal added a comment. Adding ldionne as suggested by Eric. https://reviews.llvm.org/D47400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r338301 - Avoid returning an invalid end source loc

*nod* Maybe consistency's enough for now. But yeah, if you can test whether the assertion fires (though for invalid locs, that usually means invalid code - and we don't have nice big repositories of weird invalid code - just the clang regression tests). On Tue, Aug 7, 2018 at 3:27 PM Stephen

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

On Tue, 7 Aug 2018 at 11:38, David Blaikie wrote: > > > On Tue, Aug 7, 2018 at 11:22 AM Alex L wrote: > >> On Tue, 7 Aug 2018 at 10:52, David Blaikie via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> >>> >>> On Tue, Aug 7, 2018 at 10:33 AM Alex Lorenz via Phabricator < >>>

[PATCH] D50418: [Sema] Support for P0961R1: Relaxing the structured bindings customization point finding rules

erik.pilkington created this revision. erik.pilkington added a reviewer: rsmith. Herald added a subscriber: dexonsmith. http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0961r1.html I don't believe an actual defect report was filed for this, but the paper (in the "wording" section)

[PATCH] D50420: [libcxx] [test] Add missing to several tests.

BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. https://reviews.llvm.org/D50420 Files: test/std/strings/basic.string/string.capacity/over_max_size.pass.cpp test/std/strings/string.conversions/stod.pass.cpp test/std/strings/string.conversions/stof.pass.cpp

[PATCH] D50421: [libcxx] [test] Remove assertion that includes and .

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. This looks fine to me. https://reviews.llvm.org/D50421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50418: [Sema] Support for P0961R1: Relaxing the structured bindings customization point finding rules

erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1118-1130 +// ... and if that finds at least one declaration that is a function +// template whose first template parameter is a non-type parameter ... +LookupResult::Filter Filter

[PATCH] D50418: [Sema] Support for P0961R1: Relaxing the structured bindings customization point finding rules

erik.pilkington updated this revision to Diff 159629. erik.pilkington added a comment. Address review comments. https://reviews.llvm.org/D50418 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CXX/dcl.decl/dcl.decomp/p3.cpp clang/www/cxx_status.html Index: clang/www/cxx_status.html

[libcxx] r339214 - [libcxx] [test] Allow a standard library that implements LWG 1203 in istream.rvalue/rvalue.pass.cpp

Author: bion Date: Tue Aug 7 17:49:02 2018 New Revision: 339214 URL: http://llvm.org/viewvc/llvm-project?rev=339214=rev Log: [libcxx] [test] Allow a standard library that implements LWG 1203 in istream.rvalue/rvalue.pass.cpp (Still pending review at https://reviews.llvm.org/D47400 which has

[PATCH] D47400: [libcxx] [test] Allow a standard library that implements LWG 1203 in istream.rvalue/rvalue.pass.cpp

BillyONeal added a comment. Committed r339214 (If there are changes requested I'll do them in a follow up commit) https://reviews.llvm.org/D47400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r339215 - [NFC][VFS] Fix typos in comments.

Author: vsapsai Date: Tue Aug 7 18:28:37 2018 New Revision: 339215 URL: http://llvm.org/viewvc/llvm-project?rev=339215=rev Log: [NFC][VFS] Fix typos in comments. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp URL:

[PATCH] D50415: [clangd] extend the publishDiagnostics response to send back fixits to the client directly as well (if requested)

arphaman created this revision. arphaman added reviewers: jkorous, sammccall, ilya-biryukov. Herald added subscribers: dexonsmith, MaskRay, ioeric. This change extends the 'textDocument/publishDiagnostics' notification sent from Clangd to the client. The extension can be enabled using the

[PATCH] D50414: [libunwind][include] Add SEH declarations to .

cdavis5x created this revision. cdavis5x added reviewers: mstorsjo, rnk, compnerd, smeenai. Herald added subscribers: cfe-commits, chrib, christof. Make the `_Unwind_Exception` struct correct under SEH. Add a declaration of `_GCC_specific_handler()`, which is used by SEH versions of Itanium

[PATCH] D50408: [analyzer] Avoid querying this-pointers for static-methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rC339201: [analyzer] Avoid querying this-pointers for static-methods. (authored by mattd, committed by ). Repository: rC Clang https://reviews.llvm.org/D50408 Files:

r339201 - [analyzer] Avoid querying this-pointers for static-methods.

Author: mattd Date: Tue Aug 7 16:13:28 2018 New Revision: 339201 URL: http://llvm.org/viewvc/llvm-project?rev=339201=rev Log: [analyzer] Avoid querying this-pointers for static-methods. Summary: The loop-widening code processes c++ methods looking for `this` pointers. In the case of static

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

On Tue, Aug 7, 2018 at 4:02 PM Alex L wrote: > On Tue, 7 Aug 2018 at 11:38, David Blaikie wrote: > >> >> >> On Tue, Aug 7, 2018 at 11:22 AM Alex L wrote: >> >>> On Tue, 7 Aug 2018 at 10:52, David Blaikie via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> On Tue, Aug 7,

[PATCH] D50413: [libunwind][include] Add some missing definitions to .

krytarowski added a comment. NetBSD uses `typedef void *_Unwind_Ptr;` unconditionally in its ``... if that has to be matched. Additionally: `typedef long _Unwind_Word;`. Repository: rUNW libunwind https://reviews.llvm.org/D50413 ___

[PATCH] D50421: [libcxx] [test] Remove assertion that includes and .

Quuxplusone added inline comments. Comment at: test/std/utilities/template.bitset/includes.pass.cpp:11 +// test that includes , and #include template void test_typedef() {} grammar nit: comma https://reviews.llvm.org/D50421

r339210 - PR38286: Don't crash when attempting to define a constructor for an

Author: rsmith Date: Tue Aug 7 17:42:42 2018 New Revision: 339210 URL: http://llvm.org/viewvc/llvm-project?rev=339210=rev Log: PR38286: Don't crash when attempting to define a constructor for an incomplete class template. Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp

[PATCH] D50372: Introduce the VTable interleaving scheme to the CFI design documentation

zhaomo updated this revision to Diff 159636. zhaomo added a comment. Fix mistakes and provide more information about the interleaving algorithm https://reviews.llvm.org/D50372 Files: clang/docs/ControlFlowIntegrityDesign.rst Index: clang/docs/ControlFlowIntegrityDesign.rst

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 159550. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/ReleaseNotes.rst

[PATCH] D50361: [NFC] Test automatic variable initialization

jfb added a comment. Further fixes in r339090 and r339093. Repository: rC Clang https://reviews.llvm.org/D50361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

On Tue, 7 Aug 2018 at 10:52, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Tue, Aug 7, 2018 at 10:33 AM Alex Lorenz via Phabricator < > revi...@reviews.llvm.org> wrote: > >> arphaman added a comment. >> >> In https://reviews.llvm.org/D50154#1191002, @dblaikie wrote:

r339163 - [WebAssembly] Remove use of lld -flavor flag

Author: sbc Date: Tue Aug 7 11:55:41 2018 New Revision: 339163 URL: http://llvm.org/viewvc/llvm-project?rev=339163=rev Log: [WebAssembly] Remove use of lld -flavor flag This flag is deprecated. The preferred way to select the lld flavor is by calling it by one of its aliases. Differential

[PATCH] D49518: [VFS] Emit an error when a file isn't located in any directory.

vsapsai added a comment. Thanks for the review, Bruno. Repository: rC Clang https://reviews.llvm.org/D49518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48436: [analyzer][UninitializedObjectChecker] Fixed a false negative by no longer filtering out certain constructor calls

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok, let's commit this and see how to fix it later. I still think it's more important to come up with clear rules of who is responsible for initializing fields than making sure our warnings are

[PATCH] D49355: Thread safety analysis: Allow lock upgrading and downgrading

aaronpuchert added a comment. It seems @phosek was able to fix the issue in https://github.com/flutter/engine/pull/5944. By the way, a nice way to think about the attributes is that they encode state transitions as shown in the following table. This change fills the remaining two gaps. |

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. For reference, here is the output for llvm/lib. F6896569: const_correctness_2_llvm_lib_references F6896567: const_correctness_2_llvm_lib_values_pointers Things i noticed: - lambdas are warned

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz added inline comments. Comment at: lib/Sema/SemaConcept.cpp:34 + Diag(ConstraintExpression->getExprLoc(), + diag::err_non_bool_atomic_constraint) + << ConstraintExpression << ConstraintExpression->getType(); saar.raz wrote: >

[PATCH] D50380: [Headers] Expand _Unwind_Exception for SEH on MinGW/x86_64

mstorsjo added a comment. @hans Can you merge this for 7.0? This is necessary for https://reviews.llvm.org/D49638 (merged well before the branch) to work properly without causing heap corruption. Repository: rL LLVM https://reviews.llvm.org/D50380

Re: r338732 - [analyzer] Make RegionVector use const reference

On 2018-08-07, David Blaikie wrote: Looks good! Though it may be useful in the future to describe, in the commit message, the motivation for a change - how'd you find this? What motivated you to make this particular fix just now, etc? ("identified using clang-tidy" or "spotted during post-commit

r339183 - [analyzer] [tests] Do not be verbose by default when updating reference results.

Author: george.karpenkov Date: Tue Aug 7 14:14:35 2018 New Revision: 339183 URL: http://llvm.org/viewvc/llvm-project?rev=339183=rev Log: [analyzer] [tests] Do not be verbose by default when updating reference results. Modified: cfe/trunk/utils/analyzer/SATestUpdateDiffs.py Modified:

RE: r339185 - Make test more robust by not checking hard coded debug info values, but instead check the relationships between them.

> -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Douglas Yung via cfe-commits > Sent: Tuesday, August 07, 2018 5:23 PM > To: cfe-commits@lists.llvm.org > Subject: r339185 - Make test more robust by not checking hard coded debug > info

  1   2   3   >