[PATCH] D51996: [clangd] Simplify cancellation public API

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51847: Print correctly dependency paths on Windows

xbolva00 updated this revision to Diff 165204. xbolva00 added a comment. Adjusted regexes in two more tests https://reviews.llvm.org/D51847 Files: lib/Frontend/DependencyFile.cpp test/Frontend/dependency-gen-escaping.c test/Frontend/dependency-gen.c test/Modules/relative-dep-gen.cpp

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:45 + if (!JSONArray) { +llvm::errs() << "Couldn't parse request.\n"; + } Return from function after error? Comment at:

[PATCH] D51996: [clangd] Simplify cancellation public API

ilya-biryukov added a comment. Will let Kadir finish the review, consider lgtm'ed from me ;-) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52015: [XRay][clang] Always emit XRay attributes for LLVM IR

dberris created this revision. dberris added reviewers: mboerger, eizan. Herald added subscribers: dexonsmith, mehdi_amini. Before this change, we only emit the XRay attributes in LLVM IR when the -fxray-instrument flag is provided. This may cause issues with thinlto when the final binary is

r342116 - [clang-format] Wrapped block after case label should not be merged into one line

Author: owenpan Date: Thu Sep 13 00:27:15 2018 New Revision: 342116 URL: http://llvm.org/viewvc/llvm-project?rev=342116=rev Log: [clang-format] Wrapped block after case label should not be merged into one line PR38854 Differential Revision: http://reviews.llvm.org/D51719 Modified:

[PATCH] D51719: Wrapped block after case label should not be merged into a single line (Bug 38854)

This revision was automatically updated to reflect the committed changes. Closed by commit rL342116: [clang-format] Wrapped block after case label should not be merged into one line (authored by owenpan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D51725: Allow un-setting the compilation database path

ilya-biryukov added a comment. If this setting exposed directly the users in Theia or is it something that is exposed via a custom UI (e.g. choosing named build configs or something similar)? In https://reviews.llvm.org/D51725#1232171, @simark wrote: > I was assuming that restarting clangd

[PATCH] D51996: [clangd] Simplify cancellation public API

ilya-biryukov added a comment. > but the thing you're spending the CPU on is checking for cancellation... Unless checking for cancellation is really cheap (which is doable, I think). We should probably hit some of those in practice before doing something, though. Comment at:

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

kbobyrev updated this revision to Diff 165210. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D51297 Files: clang-tools-extra/docs/clangd.rst Index: clang-tools-extra/docs/clangd.rst === ---

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

ioeric added inline comments. Comment at: clang-tools-extra/docs/clangd.rst:111 +Editor Integration +== While we are here, would you mind including some other editors/plugins that are known to work with clangd (just so that people don't think

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165209. kbobyrev marked 2 inline comments as done. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/test/clangd/Inputs/requests.json clang-tools-extra/test/clangd/Inputs/requests.log

[PATCH] D52016: [clangd] Don't create child AND and OR iterators with one posting list

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. `AND( AND( Child ) ... )` -> `AND( Child ... )` `AND( OR( Child) ... )` -> `AND( Child ... )`

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:45 + if (!JSONArray) { +llvm::errs() << "Couldn't parse request.\n"; + } ilya-biryukov wrote: > Return from function after error? I thought that this should

[PATCH] D52016: [clangd] Don't create child AND and OR iterators with one posting list

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:148 + if (TrigramIterators.size() > 1) TopLevelChildren.push_back(createAnd(move(TrigramIterators))); + else if (TrigramIterators.size() == 1) Maybe special-case a

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:45 + if (!JSONArray) { +llvm::errs() << "Couldn't parse request.\n"; + } kbobyrev wrote: > ilya-biryukov wrote: > > Return from function after error? >

[PATCH] D52015: [XRay][clang] Always emit XRay attributes for LLVM IR

dberris planned changes to this revision. dberris added a comment. This change is still incomplete -- we should really only convey that the 'never' attribute gets preserved. Otherwise we're going to have to invent a way to communicate to the XRay pass in LLVM that we should ignore the XRay

[PATCH] D52015: [XRay][clang] Always emit XRay attributes for LLVM IR

mboerger accepted this revision. mboerger added a comment. LGTM https://reviews.llvm.org/D52015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth added a comment. In https://reviews.llvm.org/D51949#1232443, @kbobyrev wrote: > I've been thinking about corner-cases (e.g. don't split `DeclStmt`s within > init-statement declaration) a while and it seems that there might be many of > them. Yes, things I am currently thinnking of:

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

ilya-biryukov added inline comments. Comment at: clang-tools-extra/docs/clangd.rst:135 + +:program:`VSCode` provides `vscode-clangd +` Maybe mention it is

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

kbobyrev updated this revision to Diff 165238. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D51297 Files: clang-tools-extra/docs/clangd.rst Index: clang-tools-extra/docs/clangd.rst === ---

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

kbobyrev added inline comments. Comment at: clang-tools-extra/docs/clangd.rst:135 + +:program:`VSCode` provides `vscode-clangd +` ilya-biryukov wrote: > Maybe

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

ilya-biryukov accepted this revision. ilya-biryukov added a comment. LGTM https://reviews.llvm.org/D51297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51990: [DebugInfo] Fix emitting of bit offset for ObjC

JDevlieghere added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2369 + ? CGM.getObjCRuntime().ComputeBitfieldBitOffset(CGM, ID, Field) + : 0; } else { aprantl wrote: > JDevlieghere wrote: > > JDevlieghere wrote: >

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165235. kbobyrev added a comment. Fix the diff after rebase. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/test/clangd/Inputs/requests.json

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165234. kbobyrev added a comment. Rebase on top of https://reviews.llvm.org/rL342123. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/test/clangd/Inputs/requests.json

[PATCH] D51418: [AArch64] Enable return address signing for static ctors

This revision was automatically updated to reflect the committed changes. Closed by commit rC342126: [AArch64] Enable return address signing for static ctors (authored by olista01, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D51418

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev updated this revision to Diff 165224. kbobyrev added a comment. Add documentation, don't expose `PostingList` interface implementations in the public API (similarly to `Iterator`). https://reviews.llvm.org/D51982 Files: clang-tools-extra/clangd/CMakeLists.txt

r342125 - Fix MSVC "illegal conversion; more than one user-defined conversion has been implicitly applied" warning. NFCI.

Author: rksimon Date: Thu Sep 13 03:10:18 2018 New Revision: 342125 URL: http://llvm.org/viewvc/llvm-project?rev=342125=rev Log: Fix MSVC "illegal conversion; more than one user-defined conversion has been implicitly applied" warning. NFCI. Modified: cfe/trunk/lib/Driver/Driver.cpp

[PATCH] D52020: [OpenCL] Improve extension-version.cl and to_addr_builtin.cl tests

AlistairD created this revision. AlistairD added a reviewer: yaxunl. Adds cl_khr_depth_images to extension-version.cl, and extends to_addr_builtin.cl. https://reviews.llvm.org/D52020 Files: test/SemaOpenCL/extension-version.cl test/SemaOpenCL/to_addr_builtin.cl Index:

r342126 - [AArch64] Enable return address signing for static ctors

Author: olista01 Date: Thu Sep 13 03:25:36 2018 New Revision: 342126 URL: http://llvm.org/viewvc/llvm-project?rev=342126=rev Log: [AArch64] Enable return address signing for static ctors Functions generated by clang and included in the .init_array section (such as static constructors) do not

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

kbobyrev updated this revision to Diff 165228. kbobyrev added a comment. Create different sections for few editors, link web page with the complete list of LSP clients. https://reviews.llvm.org/D51297 Files: clang-tools-extra/docs/clangd.rst Index: clang-tools-extra/docs/clangd.rst

[PATCH] D52016: [clangd] Don't create child AND and OR iterators with one posting list

ilya-biryukov added a comment. Great improvement for such a simple change! https://reviews.llvm.org/D52016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52016: [clangd] Don't create child AND and OR iterators with one posting list

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM with a nit. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:148 + if (TrigramIterators.size() > 1)

[clang-tools-extra] r342124 - [clangd] Don't create child AND and OR iterators with one posting list

Author: omtcyfz Date: Thu Sep 13 03:02:48 2018 New Revision: 342124 URL: http://llvm.org/viewvc/llvm-project?rev=342124=rev Log: [clangd] Don't create child AND and OR iterators with one posting list `AND( AND( Child ) ... )` -> `AND( Child ... )` `AND( OR( Child ) ... )` -> `AND( Child ... )`

[PATCH] D52016: [clangd] Don't create child AND and OR iterators with one posting list

kbobyrev updated this revision to Diff 165236. kbobyrev marked an inline comment as done. kbobyrev added a comment. Move assertion back to ctors. https://reviews.llvm.org/D52016 Files: clang-tools-extra/clangd/index/dex/Iterator.cpp Index: clang-tools-extra/clangd/index/dex/Iterator.cpp

[PATCH] D52016: [clangd] Don't create child AND and OR iterators with one posting list

This revision was automatically updated to reflect the committed changes. Closed by commit rL342124: [clangd] Dont create child AND and OR iterators with one posting list (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52008: [analyzer] Handle forwarding reference better in ExprMutationAnalyzer.

JonasToth added a comment. The new functionality looks very good. It can be used in a readability check that suggests `const` for parameters. Comment at: include/clang/Analysis/Analyses/ExprMutationAnalyzer.h:32 const Stmt *findMutation(const Expr *Exp); + const Stmt

[PATCH] D52021: Fix Bug 38926: don't merge short case labels if followed by a block

owenpan created this revision. owenpan added reviewers: djasper, klimek, sammccall, krasimir. Herald added a subscriber: cfe-commits. https://bugs.llvm.org/show_bug.cgi?id=38926 Repository: rC Clang https://reviews.llvm.org/D52021 Files: lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

ioeric added inline comments. Comment at: clang-tools-extra/docs/clangd.rst:114 + +There are multiple editors and plugins that are known to work with Clangd, such +as :program:`VSCode` and ``vscode-clangd`` extension, :program:`Emacs` and Thanks! I would be

[PATCH] D51297: [docs] Create a guide for Vim users on how to set up Clangd

ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/docs/clangd.rst:114 + +There are multiple editors and plugins that are known to work with Clangd, such +as :program:`VSCode` and

[PATCH] D52015: [XRay][clang] Always emit XRay attributes for LLVM IR

dberris updated this revision to Diff 165220. dberris edited the summary of this revision. dberris added a comment. Revise description. https://reviews.llvm.org/D52015 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D52015: [XRay][clang] Always emit XRay attributes for LLVM IR

dberris updated this revision to Diff 165219. dberris added a subscriber: llvm-commits. dberris added a comment. This revision is now accepted and ready to land. Adding an end-to-end test in compiler-rt to ensure that we are not suddenly instrumenting functions that must not be instrumented.

[PATCH] D52016: [clangd] Don't create child AND and OR iterators with one posting list

kbobyrev updated this revision to Diff 165229. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D52016 Files: clang-tools-extra/clangd/index/dex/Iterator.cpp Index: clang-tools-extra/clangd/index/dex/Iterator.cpp

[PATCH] D52016: [clangd] Don't create child AND and OR iterators with one posting list

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:148 + if (TrigramIterators.size() > 1) TopLevelChildren.push_back(createAnd(move(TrigramIterators))); + else if (TrigramIterators.size() == 1) ilya-biryukov wrote: >

[PATCH] D52008: [analyzer] Handle forwarding reference better in ExprMutationAnalyzer.

lebedev.ri added a comment. Thanks for working on this! I tried, and it appears to not fix the issue at hand. - struct C1 { C1(const C1* c, int num); }; int x = 0; auto y = std::make_unique(nullptr, x); // <- still considered a mutation? - struct C3 {}; // some class

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:45 + if (!JSONArray) { +llvm::errs() << "Couldn't parse request.\n"; + } ilya-biryukov wrote: > kbobyrev wrote: > > ilya-biryukov wrote: > > > Return from

[clang-tools-extra] r342123 - [clangd] Rename global-symbol-builder to clangd-indexer.

Author: ibiryukov Date: Thu Sep 13 02:44:11 2018 New Revision: 342123 URL: http://llvm.org/viewvc/llvm-project?rev=342123=rev Log: [clangd] Rename global-symbol-builder to clangd-indexer. Summary: Given that the indexer binary is put directly into ./bin directory when built, 'clangd-' prefix

[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-indexer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342123: [clangd] Rename global-symbol-builder to clangd-indexer. (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165232. kbobyrev marked 3 inline comments as done. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/test/clangd/Inputs/requests.json clang-tools-extra/test/clangd/Inputs/requests.log

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:47 + if (!JSONArray || !JSONArray->getAsArray()) { +llvm::errs() << "FATAL ERROR: Couldn't parse request.\n"; +exit(1); If there was a json parsing

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165240. kbobyrev added a comment. Fix empty scope in `requests.json`: `%s/"::"/""/g`. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/test/clangd/Inputs/requests.json

Re: [PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

On Tue, Sep 11, 2018 at 3:43 PM Ilya Biryukov via Phabricator < revi...@reviews.llvm.org> wrote: > ilya-biryukov added a comment. > > In https://reviews.llvm.org/D51747#1229066, @sammccall wrote: > > > A few thoughts here: > > > > - does CDB describe user or project preferences? unclear. > > >

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165248. kbobyrev marked 3 inline comments as done. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/clangd/index/dex/Iterator.cpp clang-tools-extra/test/clangd/Inputs/requests.json

[PATCH] D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status

sammccall added inline comments. Comment at: include/clang/Basic/VirtualFileSystem.h:135 + // For compatibility with old Status-based API. Prefer using Path directly. + StringRef getName() const { return Path; } +}; sammccall wrote: > bkramer wrote: > >

[PATCH] D51432: [AArch64] Unwinding support for return address signing

olista01 added inline comments. Comment at: src/DwarfInstructions.hpp:210 +register unsigned long long x16 __asm("x16") = cfa; +asm("autia1716": "+r"(x17): "r"(x16)); +returnAddress = x17; I don't think this will work for cross-unwinding

[PATCH] D52004: [clangd] Allow all LSP methods to signal cancellation via $/cancelRequest

sammccall updated this revision to Diff 165255. sammccall added a comment. Update ClangdLSPServer comment, document cancelRequest further. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52004 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D52004: [clangd] Allow all LSP methods to signal cancellation via $/cancelRequest

sammccall added a comment. In https://reviews.llvm.org/D52004#1232512, @kadircet wrote: > Wonder if we can still keep the onCancelRequest registry within > ProtocolHandler's scope, so that it is clear that we implement it. Other than > that seems fascinating, thanks! Hmm, I'm not sure how to

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

sammccall added inline comments. Comment at: clangd/ClangdServer.cpp:537 C->CommandLine.push_back("-resource-dir=" + ResourceDir); + C->CommandLine.push_back("-Wdeprecated-declarations"); return std::move(*C); kadircet wrote: > sammccall wrote: > > as

[PATCH] D51977: [clangd] Clarify and hide -index flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342134: [clangd] Clarify and hide -index flag. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51977 Files:

[PATCH] D51333: Diagnose likely typos in include statements

sammccall added a comment. (No action needed, but curious on your thoughts) One thing I'd like to do sometime is add code completion of filenames in #include directives. This would mean listing the relevant directories from the include path. (VFS is slow for this today, but I have a patch out

[PATCH] D51982: [clangd] Introduce PostingList interface

ioeric added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:125 + for (const auto : TempInvertedIndex) +InvertedIndex.insert( +{TokenToPostingList.first, nit: `InvertedIndex[TokenToPostingList.first] =

[PATCH] D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status

kristina added a comment. Added inline comments regarding code style and internal/external naming. Comment at: include/clang/Basic/VirtualFileSystem.h:135 + +public: + directory_entry() = default; The consistency is mostly related to naming of class members

[PATCH] D51429: [AArch64] Return Address Signing B Key Support

olista01 added a comment. This looks like it has the same problem as https://reviews.llvm.org/D51418 (doesn't get applied to C++ static constructor functions). Repository: rC Clang https://reviews.llvm.org/D51429 ___ cfe-commits mailing list

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

kadircet added a comment. As discussed offline with Ilya, decided to keep the compile flag addition since it would be easier to pass the logic of a command line flag to that point. Also not changing the severity level, since they will show up on diagnostics lists in anyway it doesn't save

[PATCH] D51297: [docs] Provide pointers to known editor plugins and extensions

kbobyrev closed this revision. kbobyrev added a comment. Unfortunately, forgot to add the revision link in the commit message of https://reviews.llvm.org/rCTE342129. https://reviews.llvm.org/D51297 ___ cfe-commits mailing list

[PATCH] D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status

bkramer added inline comments. Comment at: include/clang/Basic/VirtualFileSystem.h:135 + // For compatibility with old Status-based API. Prefer using Path directly. + StringRef getName() const { return Path; } +}; sammccall wrote: > sammccall wrote: > >

[PATCH] D51982: [clangd] Introduce PostingList interface

sammccall added a comment. At a high level: making posting lists an abstract type adds another layer of indirection, which we can use to solve problems. It also has costs, mostly conceptual complexity. What problems are we solving? - if **we want to dynamically use a different representation

[PATCH] D52028: [clangd] Cleanup FuzzyFindRequest filtering limit semantics

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. As discussed during https://reviews.llvm.org/D51860 review, it is better to use

[PATCH] D52030: [clangd] Test benchmark if we can build it

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52030 Files: test/CMakeLists.txt

[clang-tools-extra] r342135 - [clangd] Allow all LSP methods to signal cancellation via $/cancelRequest

Author: sammccall Date: Thu Sep 13 05:58:36 2018 New Revision: 342135 URL: http://llvm.org/viewvc/llvm-project?rev=342135=rev Log: [clangd] Allow all LSP methods to signal cancellation via $/cancelRequest Summary: The cancelable scopes are managed by JSONRPCDispatcher so that all Handlers run in

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

kadircet updated this revision to Diff 165266. kadircet marked an inline comment as done. kadircet added a comment. - Do not show up as errors even on codebases with -Werror. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51747 Files: clangd/ClangdServer.cpp

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

kadircet added inline comments. Comment at: clangd/ClangdServer.cpp:537 C->CommandLine.push_back("-resource-dir=" + ResourceDir); + C->CommandLine.push_back("-Wdeprecated-declarations"); return std::move(*C); sammccall wrote: > kadircet wrote: > >

[PATCH] D52004: [clangd] Allow all LSP methods to signal cancellation via $/cancelRequest

This revision was automatically updated to reflect the committed changes. Closed by commit rL342135: [clangd] Allow all LSP methods to signal cancellation via $/cancelRequest (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D51747: [clangd] Show deprecation diagnostics

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/ClangdServer.cpp:534 - // Inject the resource dir. + // Inject the resource dir. These flags are working for both gcc and clang-cl + //

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev updated this revision to Diff 165268. kbobyrev marked 2 inline comments as done. https://reviews.llvm.org/D51982 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/Dex.cpp clang-tools-extra/clangd/index/dex/Dex.h

[PATCH] D52028: [clangd] Cleanup FuzzyFindRequest filtering limit semantics

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/index/Index.h:477 /// - /// Returns true if there may be more results (limited by MaxCandidateCount). + /// Returns

[clang-tools-extra] r342130 - [clangd] Simplify cancellation public API

Author: sammccall Date: Thu Sep 13 04:47:48 2018 New Revision: 342130 URL: http://llvm.org/viewvc/llvm-project?rev=342130=rev Log: [clangd] Simplify cancellation public API Summary: Task is no longer exposed: - task cancellation is hidden as a std::function - task creation returns the new

[PATCH] D51996: [clangd] Simplify cancellation public API

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342130: [clangd] Simplify cancellation public API (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D51996?vs=165158=165251#toc Repository: rCTE Clang Tools

[PATCH] D52004: [clangd] Allow all LSP methods to signal cancellation via $/cancelRequest

sammccall updated this revision to Diff 165253. sammccall marked 2 inline comments as done. sammccall added a comment. rebase and address comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52004 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D51982: [clangd] Introduce PostingList interface

kbobyrev updated this revision to Diff 165256. kbobyrev marked 3 inline comments as done. https://reviews.llvm.org/D51982 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/Dex.cpp clang-tools-extra/clangd/index/dex/Dex.h

[PATCH] D52004: [clangd] Allow all LSP methods to signal cancellation via $/cancelRequest

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51725: Allow un-setting the compilation database path

simark added a comment. In https://reviews.llvm.org/D51725#1232748, @ilya-biryukov wrote: > If this setting exposed directly the users in Theia or is it something that > is exposed via a custom UI (e.g. choosing named build configs or something > similar)? It is through a custom UI, that we

[PATCH] D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status

sammccall updated this revision to Diff 165250. sammccall added a comment. Path/getName() -> path(), Type -> type() for consistency with fs::directory_entry Repository: rC Clang https://reviews.llvm.org/D51921 Files: include/clang/Basic/VirtualFileSystem.h

[clang-tools-extra] r342129 - [docs] Provide pointers to known editor plugins and extensions

Author: omtcyfz Date: Thu Sep 13 04:40:12 2018 New Revision: 342129 URL: http://llvm.org/viewvc/llvm-project?rev=342129=rev Log: [docs] Provide pointers to known editor plugins and extensions Many editors provide extensions and plugins with LSP Client functionality. Many of these are known to

[PATCH] D51996: [clangd] Simplify cancellation public API

sammccall added a comment. In https://reviews.llvm.org/D51996#1232770, @ilya-biryukov wrote: > > but the thing you're spending the CPU on is checking for cancellation... > > Unless checking for cancellation is really cheap (which is doable, I think). > We should probably hit some of those in

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

kadircet updated this revision to Diff 165252. kadircet marked 5 inline comments as done. kadircet added a comment. - Resolve discussions. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51747 Files: clangd/ClangdServer.cpp unittests/clangd/ClangdUnitTests.cpp Index:

[PATCH] D51977: [clangd] Clarify and hide -index flag.

ioeric updated this revision to Diff 165263. ioeric marked an inline comment as done. ioeric added a comment. - Remove `static`. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51977 Files: clangd/tool/ClangdMain.cpp Index: clangd/tool/ClangdMain.cpp

[clang-tools-extra] r342134 - [clangd] Clarify and hide -index flag.

Author: ioeric Date: Thu Sep 13 05:53:23 2018 New Revision: 342134 URL: http://llvm.org/viewvc/llvm-project?rev=342134=rev Log: [clangd] Clarify and hide -index flag. Summary: The wording implies global index support, which is confusing. As most users shouldn't care about this flag, also make it

[PATCH] D52028: [clangd] Cleanup FuzzyFindRequest filtering limit semantics

kbobyrev updated this revision to Diff 165272. kbobyrev added a comment. Don't modify benchmarks since it'd clash with the parent patch in this case. https://reviews.llvm.org/D52028 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/FindSymbols.cpp

[PATCH] D51747: [clangd] Show deprecation diagnostics

kadircet updated this revision to Diff 165275. kadircet marked 2 inline comments as done. kadircet added a comment. - Convert unit tests to lit tests and address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51747 Files: clangd/ClangdServer.cpp

[PATCH] D52030: [clangd] Test benchmark if we can build it

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Looks good, thanks! While we're here: I'm wondering whether we should also introduce very basic test which would just run `clangd-indexer` since it doesn't depend on benchmarks and would

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165277. kbobyrev added a comment. Fix a typo in test comments. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/test/clangd/Inputs/requests.json

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

kbobyrev updated this revision to Diff 165280. kbobyrev marked 2 inline comments as done. https://reviews.llvm.org/D51971 Files: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp clang-tools-extra/test/clangd/Inputs/requests.json clang-tools-extra/test/clangd/Inputs/requests.log

[clang-tools-extra] r342137 - [clangd] Use JSON format in benchmark requests reader

Author: omtcyfz Date: Thu Sep 13 07:21:50 2018 New Revision: 342137 URL: http://llvm.org/viewvc/llvm-project?rev=342137=rev Log: [clangd] Use JSON format in benchmark requests reader After `FuzzyFindRequest` JSON (de)serialization was introduced, it should replace ad-hoc fuzzy-find request

[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342137: [clangd] Use JSON format in benchmark requests reader (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D51971?vs=165280=165281#toc Repository: rCTE

[PATCH] D51747: [clangd] Show deprecation diagnostics

kadircet added a comment. In https://reviews.llvm.org/D51747#1233371, @sammccall wrote: > Sorry for all the back and forth on this patch, but I have to ask... what's > up with switching to lit tests? > > We've mostly started avoiding these as they're hard to maintain and debug > (not to

[clang-tools-extra] r342138 - [clangd] Cleanup FuzzyFindRequest filtering limit semantics

Author: omtcyfz Date: Thu Sep 13 07:27:03 2018 New Revision: 342138 URL: http://llvm.org/viewvc/llvm-project?rev=342138=rev Log: [clangd] Cleanup FuzzyFindRequest filtering limit semantics As discussed during D51860 review, it is better to use `llvm::Optional` here as it has clear semantics

[PATCH] D52028: [clangd] Cleanup FuzzyFindRequest filtering limit semantics

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342138: [clangd] Cleanup FuzzyFindRequest filtering limit semantics (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D52028?vs=165283=165284#toc Repository:

[PATCH] D52028: [clangd] Cleanup FuzzyFindRequest filtering limit semantics

kbobyrev updated this revision to Diff 165283. kbobyrev added a comment. Update `requests.json` to comply with the new format. https://reviews.llvm.org/D52028 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/FindSymbols.cpp

  1   2   3   >