r346951 - [AST] Pack UnaryOperator

Author: brunoricci Date: Thu Nov 15 05:30:38 2018 New Revision: 346951 URL: http://llvm.org/viewvc/llvm-project?rev=346951=rev Log: [AST] Pack UnaryOperator Use the newly available space in the bit-fields of Stmt to store some data from UnaryOperator. This saves 8 bytes per UnaryOperator.

[PATCH] D54524: [AST] Pack UnaryOperator

This revision was automatically updated to reflect the committed changes. Closed by commit rL346951: [AST] Pack UnaryOperator (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54524?vs=174024=174195#toc

r346953 - [AST] Pack MemberExpr

Author: brunoricci Date: Thu Nov 15 05:56:22 2018 New Revision: 346953 URL: http://llvm.org/viewvc/llvm-project?rev=346953=rev Log: [AST] Pack MemberExpr Use the newly available space in the bit-fields of Stmt to store some data from MemberExpr. This saves one pointer per MemberExpr.

[PATCH] D54525: [AST] Pack MemberExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC346953: [AST] Pack MemberExpr (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D54525?vs=174026=174196#toc Repository: rC Clang

[PATCH] D54579: [clang-tidy] Update checks to play nicely with limited traversal scope added in r346847

sammccall updated this revision to Diff 174203. sammccall added a comment. Address comments from the last round of review in https://reviews.llvm.org/D54204. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54579 Files: clang-tidy/misc/UnusedParametersCheck.cpp

[PATCH] D54204: [clangd] Initial clang-tidy diagnostics support.

sammccall added a comment. Moved the clang-tidy changes to https://reviews.llvm.org/D54579. Sorry for mixing everything up! Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:518 void SimplifyBooleanExprCheck::registerMatchers(MatchFinder *Finder) { -

[PATCH] D54526: [AST] Pack BinaryOperator

This revision was automatically updated to reflect the committed changes. Closed by commit rC346954: [AST] Pack BinaryOperator (authored by brunoricci, committed by ). Repository: rC Clang https://reviews.llvm.org/D54526 Files: include/clang/AST/Expr.h include/clang/AST/Stmt.h Index:

[PATCH] D54553: [clangd] Fix crash hovering on non-decltype trailing return

malaperle updated this revision to Diff 174202. malaperle added a comment. Address comment. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54553 Files: clangd/XRefs.cpp unittests/clangd/XRefsTests.cpp Index: unittests/clangd/XRefsTests.cpp

[PATCH] D54204: [clangd] Initial clang-tidy diagnostics support.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r346954 - [AST] Pack BinaryOperator

Author: brunoricci Date: Thu Nov 15 06:12:51 2018 New Revision: 346954 URL: http://llvm.org/viewvc/llvm-project?rev=346954=rev Log: [AST] Pack BinaryOperator Use the newly available space in the bit-fields of Stmt. This saves 8 bytes per BinaryOperator. Differential Revision:

[PATCH] D54579: [clang-tidy] Update checks to play nicely with limited traversal scope added in r346847

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, xazax.hun. (See https://reviews.llvm.org/D54204 for original review) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54579 Files:

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai added a comment. In https://reviews.llvm.org/D45045#1299507, @tyb0807 wrote: > Hello all, > > This commit has been reverted by https://reviews.llvm.org/rC345026. It was > reported that this broke the Chromium build (again). Have you had a look to > fix this, @HsiangKai? I have

[PATCH] D54557: [analyzer] MoveChecker Pt.2: Restrict the warning to STL objects and locals.

Szelethus added a comment. Alpha checkers, at least to developers, are clearly stating "Please finish me!", but a non-alpha, enabled-by-default checker with a flag that you'd never know about unless you looked at the source code (at least up until I fix these) sounds like it'll be forgotten

[PATCH] D54526: [AST] Pack BinaryOperator

riccibruno marked 6 inline comments as done. riccibruno added a comment. Marked the inline comments as done since I believe I answered each of them. If not I can fix it in a subsequent commit. Repository: rC Clang https://reviews.llvm.org/D54526

[PATCH] D54556: [analyzer] MoveChecker Pt.1: Give MisusedMovedObject checker a more consistent name.

Szelethus accepted this revision. Szelethus added a comment. LGTM, both the concept and the patch! I have read your followup patches up to part 4, I'll leave some thoughts there. Repository: rC Clang https://reviews.llvm.org/D54556 ___

[PATCH] D54563: [analyzer] MoveChecker Pt.4: Add a few more state reset methods.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. How about `std::list::splice`? Repository: rC Clang https://reviews.llvm.org/D54563 ___ cfe-commits mailing list

[PATCH] D54547: PTH-- Remove feature entirely-

riccibruno added a comment. In https://reviews.llvm.org/D54547#1299883, @erichkeane wrote: > Added to the release notes. Also, an email was sent out to cfe-dev. > > @riccibruno and I are separately looking into IdentifierInfo, because it > seems that there are some pretty massive optimization

[PATCH] D52273: [clangd] Initial implementation of expected types

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clangd/ExpectedTypes.cpp:12 + +static llvm::Optional toEquivClass(ASTContext , QualType T) { + if (T.isNull() || T->isDependentType()) sammccall wrote: > returning

[PATCH] D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'

astrelni updated this revision to Diff 174218. astrelni marked an inline comment as done. astrelni added a comment. Fix to use `hasAnyName` everywhere https://reviews.llvm.org/D53830 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt

[PATCH] D54204: [clangd] Initial clang-tidy diagnostics support.

sammccall updated this revision to Diff 174204. sammccall added a comment. Remove clang-tidy changes, add FIXME comment. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54204 Files: clangd/CMakeLists.txt clangd/ClangdUnit.cpp clangd/XRefs.cpp

r346957 - [AST][NFC] Re-add comment in BinaryOperator which was removed by r346954

Author: brunoricci Date: Thu Nov 15 06:30:18 2018 New Revision: 346957 URL: http://llvm.org/viewvc/llvm-project?rev=346957=rev Log: [AST][NFC] Re-add comment in BinaryOperator which was removed by r346954 Modified: cfe/trunk/include/clang/AST/Stmt.h Modified:

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Awesome! :D Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:385-386 + } + // Provide the caller with the classification of the object + // we've obtained

r346952 - [AST][NFC] Move the friend decls to the top of MemberExpr

Author: brunoricci Date: Thu Nov 15 05:49:32 2018 New Revision: 346952 URL: http://llvm.org/viewvc/llvm-project?rev=346952=rev Log: [AST][NFC] Move the friend decls to the top of MemberExpr The norm is to have them at the top, and having them at the bottom is painful for the reader. Modified:

[PATCH] D54579: [clang-tidy] Update checks to play nicely with limited traversal scope added in r346847

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:567 replaceCompoundReturnWithCondition(Result, Compound, true); - else if (const auto TU =

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet updated this revision to Diff 174215. kadircet marked 13 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54269 Files: clangd/CMakeLists.txt clangd/index/Background.cpp

[PATCH] D54557: [analyzer] MoveChecker Pt.2: Restrict the warning to STL objects and locals.

Szelethus added a comment. I think we should either remove the non-default functionality (which wouldn't be ideal), or emphasise somewhere (open projects?) that there is still work to be done, but leaving it to be forgotten and essentially making it an extra maintenance work would be, in my

[PATCH] D53807: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ctor_dtor, so it can be turned into an error using Werror

ArnaudBienner added a comment. @rsmith do you have any thoughts about this change? Repository: rC Clang https://reviews.llvm.org/D53807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r346955 - [clangd] global-symbol-builder => clangd-indexer

Author: hokein Date: Thu Nov 15 06:15:19 2018 New Revision: 346955 URL: http://llvm.org/viewvc/llvm-project?rev=346955=rev Log: [clangd] global-symbol-builder => clangd-indexer Modified: clang-tools-extra/trunk/clangd/index/dex/dexp/Dexp.cpp Modified:

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

scott.linder added inline comments. Comment at: docs/ClangCommandLineReference.rst:797 + +Generate a section .LLVM.command.line containing the clang driver command line. + rjmccall wrote: > 1. Is this section always called `.LLVM.command.line`, or does it differ

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits added a comment. Hi Vit, The register spilling bug is being addressed in https://reviews.llvm.org/D54409 now. Repository: rC Clang https://reviews.llvm.org/D49754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

scott.linder added a comment. Looking a bit further, it seems some other object-file formats have conventions for naming (e.g. Mach-O sections are `_snake_case`) and so `.LLVM.command.line` may not end up being what we want universally. Additionally it seems things like `.ident` are not

[PATCH] D54579: [clang-tidy] Update checks to play nicely with limited traversal scope added in r346847

This revision was automatically updated to reflect the committed changes. Closed by commit rL346961: [clang-tidy] Update checks to play nicely with limited traversal scope added in… (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r346961 - [clang-tidy] Update checks to play nicely with limited traversal scope added in r346847

Author: sammccall Date: Thu Nov 15 07:06:11 2018 New Revision: 346961 URL: http://llvm.org/viewvc/llvm-project?rev=346961=rev Log: [clang-tidy] Update checks to play nicely with limited traversal scope added in r346847 Summary: (See D54204 for original review) Reviewers: hokein Subscribers:

[PATCH] D52273: [clangd] Initial implementation of expected types

ilya-biryukov updated this revision to Diff 174217. ilya-biryukov marked 10 inline comments as done. ilya-biryukov added a comment. - Address comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52273 Files: clangd/CMakeLists.txt clangd/ExpectedTypes.cpp

r346967 - [AST][NFC] Various NFCs in StringLiteral

Author: brunoricci Date: Thu Nov 15 08:42:14 2018 New Revision: 346967 URL: http://llvm.org/viewvc/llvm-project?rev=346967=rev Log: [AST][NFC] Various NFCs in StringLiteral Factored out of D54166 ([AST] Store the string data in StringLiteral in a trailing array of chars): * For-range loops in

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan updated this revision to Diff 174235. leonardchan marked 13 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D53738 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h clang/include/clang/Basic/FixedPoint.h

[PATCH] D54592: [CStringChecker] evaluate explicit_bzero

devnexen created this revision. devnexen added reviewers: george.karpenkov, dergachev.a. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. - explicit_bzero has limited scope/usage only for security/crypto purposes but is non-optimisable version of

[PATCH] D54441: [OPENMP] Support relational-op !- (not-equal) as one of the canonical forms of random access iterator

kkwli0 added a comment. Please do a rebase. The test case teams_distribute_simd_loop_messages.cpp needs to update too. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3707 /// UB >= Var - bool TestIsLessOp = false; + /// This will has no value when the condition is != +

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

rjmccall added inline comments. Comment at: docs/ClangCommandLineReference.rst:797 + +Generate a section .LLVM.command.line containing the clang driver command line. + scott.linder wrote: > rjmccall wrote: > > 1. Is this section always called

[PATCH] D53702: [ASTImporter] Set redecl chain of functions before any other import

shafik added a comment. Did you ever resolve the issue of libcxx tests not running https://reviews.llvm.org/D53697 Repository: rC Clang https://reviews.llvm.org/D53702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54324: [AST] Store the value of CharacterLiteral in the bit-fields of Stmt if possible

shafik added inline comments. Comment at: include/clang/AST/Expr.h:1407 public: - enum CharacterKind { -Ascii, -Wide, -UTF8, -UTF16, -UTF32 - }; + enum CharacterKind { Ascii, Wide, UTF8, UTF16, UTF32 }; riccibruno wrote: > shafik wrote:

r346969 - [AST] Store the string data in StringLiteral in a trailing array of chars

Author: brunoricci Date: Thu Nov 15 09:31:16 2018 New Revision: 346969 URL: http://llvm.org/viewvc/llvm-project?rev=346969=rev Log: [AST] Store the string data in StringLiteral in a trailing array of chars Use the newly available space in the bit-fields of Stmt and store the string data in a

[PATCH] D54438: [analyzer][WIP] Reimplement dependencies between checkers

Szelethus added a comment. Herald added a subscriber: gamesh411. In https://reviews.llvm.org/D54438#1297602, @NoQ wrote: > Hmm, makes sense. Maybe `static bool BlahBlahChecker::isApplicable(const > LangOpts )` or something like that. > > Btw, maybe instead of default constructor and

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. In https://reviews.llvm.org/D53738#1299557, @ebevhan wrote: > I'd be interested in seeing tests for two saturating unsigned _Fract with and > without padding. > > If the padding case emits a uadd_sat, that seems wrong; uadd_sat doesn't > saturate on the padding

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri created this revision. lebedev.ri added reviewers: ABataev, craig.topper, vsk, rsmith, rnk, Sanitizers, erichkeane, filcab, rjmccall. lebedev.ri added a project: Sanitizers. lebedev.ri added a dependency: D54588: [llvm][IRBuilder] Introspection for CreateAlignmentAssumption*()

[PATCH] D51223: Update tests for new YAMLIO polymorphic traits

scott.linder accepted this revision. scott.linder added a comment. This revision is now accepted and ready to land. r346884 https://reviews.llvm.org/D51223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51223: Update tests for new YAMLIO polymorphic traits

scott.linder closed this revision. scott.linder added a comment. r346884 https://reviews.llvm.org/D51223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'

astrelni updated this revision to Diff 174226. astrelni added a comment. Fix incorrect uploaded diff. https://reviews.llvm.org/D53830 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

jkorous planned changes to this revision. jkorous added a comment. In https://reviews.llvm.org/D54428#1297147, @sammccall wrote: > A question about the high-level build target setup (I don't know much about > XPC services/frameworks, bear with me...): > > This is set up so that the clangd

[PATCH] D54576: [clang] - Simplify tools::SplitDebugName.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Agreed - looks like this went in untested in r175813 & has never been used. https://reviews.llvm.org/D54576 ___ cfe-commits mailing list

[PATCH] D52578: Thread safety analysis: Allow scoped releasing of capabilities

delesley added inline comments. Comment at: lib/Analysis/ThreadSafety.cpp:951 +} } else { +// We're removing the underlying mutex. Warn on double unlocking. aaronpuchert wrote: > aaronpuchert wrote: > > delesley wrote: > > > aaronpuchert

[PATCH] D54245: [VFS] Implement `RedirectingFileSystem::getRealPath`.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jkorous. LGTM https://reviews.llvm.org/D54245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r346996 - Fix parens warning in assert in ASTMatchFinder

Author: erichkeane Date: Thu Nov 15 13:35:35 2018 New Revision: 346996 URL: http://llvm.org/viewvc/llvm-project?rev=346996=rev Log: Fix parens warning in assert in ASTMatchFinder Change-Id: Ie34f9c6846b98fba87449e73299519fc2346bac1 Modified: cfe/trunk/lib/ASTMatchers/ASTMatchFinder.cpp

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. bump! Thanks for your consideration. https://reviews.llvm.org/D40988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53764: [OpenCL] Enable address spaces for references in C++

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. https://reviews.llvm.org/D53764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan updated this revision to Diff 174279. Repository: rC Clang https://reviews.llvm.org/D53738 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h clang/include/clang/Basic/FixedPoint.h clang/lib/AST/ASTContext.cpp clang/lib/Basic/FixedPoint.cpp

[PATCH] D54598: [CMake] Explicitly list Linux targets for Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rC346997: [CMake] Explicitly list Linux targets for Fuchsia toolchain (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D54598?vs=174273=174280#toc Repository: rC

[clang-tools-extra] r346998 - Remove myself as owner of clang-query.

Author: pcc Date: Thu Nov 15 14:02:10 2018 New Revision: 346998 URL: http://llvm.org/viewvc/llvm-project?rev=346998=rev Log: Remove myself as owner of clang-query. I haven't been involved with the project for years, so it's probably best for someone else to be the code owner. Differential

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

rjmccall added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1749-1750 +On 64-bit ARM targets, this argument causes the function to obey the vector +procedural call standard (VPCS) rules as described in the Vector ABI for +AArch64. In particular, the register

r347005 - [WebAssembly] Change type of wake count to unsigned int

Author: aheejin Date: Thu Nov 15 16:48:58 2018 New Revision: 347005 URL: http://llvm.org/viewvc/llvm-project?rev=347005=rev Log: [WebAssembly] Change type of wake count to unsigned int Summary: We discussed this at the Nov 12th CG meeting, and decided to use the unsigned semantics for the wake

[PATCH] D54572: [WebAssembly] Change type of wake count to unsigned int

This revision was automatically updated to reflect the committed changes. Closed by commit rL347005: [WebAssembly] Change type of wake count to unsigned int (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54572

[PATCH] D54572: [WebAssembly] Change type of wake count to unsigned int

This revision was automatically updated to reflect the committed changes. Closed by commit rC347005: [WebAssembly] Change type of wake count to unsigned int (authored by aheejin, committed by ). Changed prior to commit: https://reviews.llvm.org/D54572?vs=174169=174302#toc Repository: rL

[PATCH] D52674: [AST] Add Obj-C discriminator to MS ABI RTTI

smeenai planned changes to this revision. smeenai added a comment. In https://reviews.llvm.org/D52674#1298115, @rjmccall wrote: > In https://reviews.llvm.org/D52674#1297893, @smeenai wrote: > > > In https://reviews.llvm.org/D52674#1297879, @rjmccall wrote: > > > > > I'm not worried about the

[PATCH] D53329: Generate DIFile with main program if source is not available

dblaikie added a subscriber: scott.linder. dblaikie added a comment. Thanks! So I can see where/how this fails now - the LLVM backend seems to require that if any file has embedded source, they all do. Would you be able to/would you mind adding a debug info verifier check for this? That'd help

[PATCH] D54453: Remove myself as owner of clang-query.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE346998: Remove myself as owner of clang-query. (authored by pcc, committed by ). Changed prior to commit: https://reviews.llvm.org/D54453?vs=173776=174282#toc Repository: rCTE Clang Tools Extra

[PATCH] D54604: Automatic variable initialization

jfb created this revision. jfb added reviewers: kcc, rjmccall, rsmith. Herald added subscribers: dexonsmith, jkorous, JDevlieghere. Add an option to initialize automatic variables with either a pattern or with zeroes. The default is still that automatic variables are uninitialized. Also add

[clang-tools-extra] r347000 - [clang-tidy] Fix reference to -[NSError init] in AvoidNSErrorInitCheck.h

Author: stephanemoore Date: Thu Nov 15 14:38:39 2018 New Revision: 347000 URL: http://llvm.org/viewvc/llvm-project?rev=347000=rev Log: [clang-tidy] Fix reference to -[NSError init] in AvoidNSErrorInitCheck.h Modified: clang-tools-extra/trunk/clang-tidy/objc/AvoidNSErrorInitCheck.h Modified:

[PATCH] D52730: [analyzer] ConversionChecker: handle floating point

This revision was automatically updated to reflect the committed changes. Closed by commit rC347006: [analyzer] ConversionChecker: handle floating point (authored by Szelethus, committed by ). Changed prior to commit: https://reviews.llvm.org/D52730?vs=172922=174306#toc Repository: rC Clang

[PATCH] D54426: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

thakis added a comment. Thanks! Repository: rC Clang https://reviews.llvm.org/D54426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added inline comments. Comment at: lib/Driver/Driver.cpp:392 +static void replaceString(std::string , + const char *Other, Same as previous comment regarding this type of function. Repository: rC Clang

[PATCH] D52730: [analyzer] ConversionChecker: handle floating point

Szelethus added a comment. Herald added a subscriber: gamesh411. In https://reviews.llvm.org/D52730#1289989, @donat.nagy wrote: > Could someone with commit rights commit this patch (if it is acceptable)? I > don't have commit rights myself. I'll do the honors. Thanks! Repository: rC Clang

r347006 - [analyzer] ConversionChecker: handle floating point

Author: szelethus Date: Thu Nov 15 17:00:55 2018 New Revision: 347006 URL: http://llvm.org/viewvc/llvm-project?rev=347006=rev Log: [analyzer] ConversionChecker: handle floating point Extend the alpha.core.Conversion checker to handle implicit converions where a too large integer value is

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. > Good case to bring up. For addition, I think we just need to add an extra > condition that checks for unsigned padding in the result. Added this test > also. Actually this was wrong. Updated and instead dictate how the appropriate number of bits to

r346997 - [CMake] Explicitly list Linux targets for Fuchsia toolchain

Author: phosek Date: Thu Nov 15 13:55:59 2018 New Revision: 346997 URL: http://llvm.org/viewvc/llvm-project?rev=346997=rev Log: [CMake] Explicitly list Linux targets for Fuchsia toolchain Not all Linux targets use the ${arch}-linux-gnu spelling, so instead specify the list of Linux explicitly.

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added a comment. Added first batch of comments regarding the patch. Some style, some semantics-related. Comment at: lib/Basic/Targets/OSTargets.h:283 +Builder.defineMacro("__GLIBC__"); +Builder.defineMacro("__ELF__"); +if (Opts.POSIXThreads)

[PATCH] D54604: Automatic variable initialization

jfb added a comment. In https://reviews.llvm.org/D54604#1300544, @t.p.northover wrote: > > This isn't meant to change the semantics of C and C++. > > As I said in the cfe-dev thread, that's exactly what it does. Specifically I > think this is essentially defining a new dialect of C++, which I

[PATCH] D54600: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov (after revert https://reviews.llvm.org/rL346659)

calixte created this revision. calixte added a reviewer: marco-c. Herald added a subscriber: cfe-commits. the previous patch (https://reviews.llvm.org/rC346642) has been reverted because of test failure under windows. So this patch fix the test cfe/trunk/test/CodeGen/code-coverage-filter.c.

[PATCH] D54604: Automatic variable initialization

t.p.northover added a comment. > This isn't meant to change the semantics of C and C++. As I said in the cfe-dev thread, that's exactly what it does. Specifically I think this is essentially defining a new dialect of C++, which I have massive concerns about. Additionally, as much as we might

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added reviewers: aaron.ballman, erik.pilkington, rsmith. kristina added a comment. Alright, once this is fully reviewed, if accepted, I can land the LLVMSupport change and add your new target and close the stack. In the meantime, adding some more reviewers who have more experience with

[PATCH] D54604: Automatic variable initialization

kcc added reviewers: glider, vitalybuka, pcc, eugenis, vlad.tsyrklevich. kcc added a comment. exciting. adding more folks FYI and to help review Repository: rC Clang https://reviews.llvm.org/D54604 ___ cfe-commits mailing list

[PATCH] D54557: [analyzer] MoveChecker Pt.2: Restrict the warning to STL objects and locals.

NoQ added a comment. In https://reviews.llvm.org/D54557#1299899, @Szelethus wrote: > Whenever I compile `Rtags`, I get a bunch of move related warnings, I'm > curious how this patch behaves on that project. I'll take a look. Whoops, sry, i accidentally had a look because i misread your

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added a comment. Phab lost this inline command for some reason, but please leave some comment regarding why that part in `Driver.cpp` does what it does (summarize the conclusion of the discussion in https://reviews.llvm.org/D54378). Comment at:

r347012 - [VFS] Implement `RedirectingFileSystem::getRealPath`.

Author: vsapsai Date: Thu Nov 15 17:18:04 2018 New Revision: 347012 URL: http://llvm.org/viewvc/llvm-project?rev=347012=rev Log: [VFS] Implement `RedirectingFileSystem::getRealPath`. It fixes the case when Objective-C framework is added as a subframework through a symlink. When parent framework

[PATCH] D54557: [analyzer] MoveChecker Pt.2: Restrict the warning to STL objects and locals.

Szelethus added a comment. In https://reviews.llvm.org/D54557#1300581, @NoQ wrote: > In https://reviews.llvm.org/D54557#1299899, @Szelethus wrote: > > > Whenever I compile `Rtags`, I get a bunch of move related warnings, I'm > > curious how this patch behaves on that project. I'll take a look.

[PATCH] D54613: [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rC347021: [CMake] Use the correct spelling for armv7 in Fuchsias toolchain (authored by phosek, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D54245: [VFS] Implement `RedirectingFileSystem::getRealPath`.

This revision was automatically updated to reflect the committed changes. Closed by commit rL347009: [VFS] Implement `RedirectingFileSystem::getRealPath`. (authored by vsapsai, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

[PATCH] D54557: [analyzer] MoveChecker Pt.2: Restrict the warning to STL objects and locals.

NoQ added a comment. In https://reviews.llvm.org/D54557#1299899, @Szelethus wrote: > I think we should either remove the non-default functionality (which wouldn't > be ideal), or emphasise somewhere (open projects?) that there is still work > to be done, but leaving it to be forgotten and

[PATCH] D54557: [analyzer] MoveChecker Pt.2: Restrict the warning to STL objects and locals.

NoQ added a comment. In https://reviews.llvm.org/D54557#1299736, @xazax.hun wrote: > It would be great to have a way to extend the list of (possibly non-stl) > types to check. But I do understand that the analyzer does not have a great > way to set such configuration options right now. Do

[PATCH] D54473: [sanitizers] Initial implementation for -fsanitize=init-locals

kcc added a comment. I think you can safely abandon this change in favor of https://reviews.llvm.org/D54604 -- please join the review there. Repository: rC Clang https://reviews.llvm.org/D54473 ___ cfe-commits mailing list

r347026 - [CMake] Support cross-compiling with Fuchsia toolchain build

Author: phosek Date: Thu Nov 15 20:50:12 2018 New Revision: 347026 URL: http://llvm.org/viewvc/llvm-project?rev=347026=rev Log: [CMake] Support cross-compiling with Fuchsia toolchain build When second stage is being cross-compiled for a different platform we need to build enough of first stage

r347019 - [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

Author: wuzish Date: Thu Nov 15 19:00:00 2018 New Revision: 347019 URL: http://llvm.org/viewvc/llvm-project?rev=347019=rev Log: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error There are 2 function

[PATCH] D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

This revision was automatically updated to reflect the committed changes. wuzish marked an inline comment as done. Closed by commit rC347019: [Clang][Sema]Choose a better candidate in overload function call if there is a… (authored by wuzish, committed by ). Changed prior to commit:

[PATCH] D54461: [CMake] Support cross-compiling with multi-stage builds

This revision was automatically updated to reflect the committed changes. Closed by commit rC347025: [CMake] Support cross-compiling with multi-stage builds (authored by phosek, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

Re: [llvm-dev] mips builders on LLVM buildbot?

Hi Galina, a) "llvm-mips-linux" buildbot is active now. There are some failed tests but I'm working to make the buildbot "green". b) For now "clang-cmake-mips" and "clang-cmake-mipsel" can be removed. Later we probably restore these buildbots. On Sat, Nov 3, 2018 at 11:26 AM Simon Atanasyan

[PATCH] D53891: [LTO] Pass down LTOUnit codegen flag to bitcode writer

tejohnson updated this revision to Diff 174329. tejohnson added a comment. - As discussed off-patch, will use a new, separate option to control this splitting, here I am using -f[no]split-lto-unit. - Switch the default of splitting lto units to off by default, unless compiled with CFI or

r347021 - [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain

Author: phosek Date: Thu Nov 15 20:09:47 2018 New Revision: 347021 URL: http://llvm.org/viewvc/llvm-project?rev=347021=rev Log: [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain We need to explicitly specify the architecture version. Differential Revision:

[PATCH] D54463: [CMake] Support cross-compiling with Fuchsia toolchain build

This revision was automatically updated to reflect the committed changes. Closed by commit rL347026: [CMake] Support cross-compiling with Fuchsia toolchain build (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

lonico added a comment. > The second way to handle this use case is possible on a different level: one > can run clang-tidy over the whole project with `-header-filter=.*` and then > filter the results and use a specialized tool to display them, e.g. >

r347025 - [CMake] Support cross-compiling with multi-stage builds

Author: phosek Date: Thu Nov 15 20:46:48 2018 New Revision: 347025 URL: http://llvm.org/viewvc/llvm-project?rev=347025=rev Log: [CMake] Support cross-compiling with multi-stage builds When using multi-stage builds, we would like support cross-compilation. Example is 2-stage build when the first

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay added a comment. I'd like feedback on the new AVR-specific warnings, and the new warning group. I have not added a warning or error to clang before, but this seems consistent with how the other targets implement it. Repository: rC Clang https://reviews.llvm.org/D54334

  1   2   >