[PATCH] D52790: [analyzer][PlistMacroExpansion] New flag to convert macro expansions to events

Szelethus planned changes to this revision. Szelethus added a comment. Herald added subscribers: gamesh411, baloghadamsoftware. Since the way how these macro events are created as a whole changed in part 1, this path will need a big overhaul. CHANGES SINCE LAST ACTION

r348408 - Add dump tests for inherited default template parameters

Author: steveire Date: Wed Dec 5 12:21:13 2018 New Revision: 348408 URL: http://llvm.org/viewvc/llvm-project?rev=348408=rev Log: Add dump tests for inherited default template parameters Modified: cfe/trunk/test/AST/ast-dump-decl.cpp Modified: cfe/trunk/test/AST/ast-dump-decl.cpp URL:

[PATCH] D55189: Extract TextNodeDumper class

steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:90 // Utilities -void dumpPointer(const void *Ptr); -void dumpSourceRange(SourceRange R); -void dumpLocation(SourceLocation Loc); -void

r348410 - NFC: Extract TextTreeStructure class

Author: steveire Date: Wed Dec 5 12:53:14 2018 New Revision: 348410 URL: http://llvm.org/viewvc/llvm-project?rev=348410=rev Log: NFC: Extract TextTreeStructure class Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55188 Added:

Re: [cfe-dev] r347339 - [clang][Parse] Diagnose useless null statements / empty init-statements

Nobody should be using "-Weverything" in their default build flags! It should only be used as a way to find the names of interesting warning flags. I'd note that "-Weverything" even has warnings that _conflict_ with each-other... It's unworkable for clang to have a policy which prevents the

Re: r348408 - Add dump tests for inherited default template parameters

Surely all of the tests specifically about template decls should be moved? On 05/12/2018 20:31, Aaron Ballman wrote: On Wed, Dec 5, 2018 at 3:24 PM Stephen Kelly via cfe-commits wrote: Author: steveire Date: Wed Dec 5 12:21:13 2018 New Revision: 348408 URL:

r348412 - NFC: Extract TextNodeDumper class

Author: steveire Date: Wed Dec 5 13:12:39 2018 New Revision: 348412 URL: http://llvm.org/viewvc/llvm-project?rev=348412=rev Log: NFC: Extract TextNodeDumper class Summary: Start by moving some utilities to it. It will eventually house dumping of individual nodes (after indentation etc has

[PATCH] D55189: Extract TextNodeDumper class

This revision was automatically updated to reflect the committed changes. Closed by commit rC348412: NFC: Extract TextNodeDumper class (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D55189?vs=176478=176872#toc Repository: rC Clang CHANGES SINCE

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan updated this revision to Diff 176907. leonardchan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49511/new/ https://reviews.llvm.org/D49511 Files: clang/include/clang/Basic/Attr.td

[PATCH] D55289: [analyzer] MoveChecker Pt.5: Improve invalidation policies.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:540-542 +// Explicit regions are the regions passed into the call directly, but +// not all of them end up being invalidated. The ones that do appear in +// the Regions array as well.

Re: [cfe-dev] r347339 - [clang][Parse] Diagnose useless null statements / empty init-statements

On Wed, Dec 5, 2018 at 2:14 PM Alex L via cfe-commits wrote: > > We have about 100k unique occurrences of this warning across a slice of our > software stack. It's simply not feasible to us to adopt it, so we would > prefer for it to be reverted to avoid downstream divergence in Apple's clang.

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1304 +RHSTy = ResultTy; + } + ebevhan wrote: > rjmccall wrote: > > ebevhan wrote: > > > rjmccall wrote: > > > > leonardchan wrote: > > > > > rjmccall wrote: > > > > > > leonardchan

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

jyknight added a comment. In D55150#1318082 , @chandlerc wrote: > I think this should be `internal-driver-option` and the text updated? I don't > think these are necessarily experimental, they're internals of the compiler > implementation, and not a

r348409 - NFC: Inline handling of DependentSizedArrayType

Author: steveire Date: Wed Dec 5 12:34:07 2018 New Revision: 348409 URL: http://llvm.org/viewvc/llvm-project?rev=348409=rev Log: NFC: Inline handling of DependentSizedArrayType Summary: Re-order handling of getElementType and getBracketsRange. It is necessary to perform all printing before any

[PATCH] D55257: Inline handling of DependentSizedArrayType

This revision was automatically updated to reflect the committed changes. Closed by commit rL348409: NFC: Inline handling of DependentSizedArrayType (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D55340: NFC: Move dump of individual Stmts to TextNodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55340 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index:

[PATCH] D55339: NFC: Move VisitExpr code to dumpStmt

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. The call is duplicated in the handlers of all Expr subclasses. This change makes it easy to split statement handling out to TextNodeDumper. Repository: rC Clang

[PATCH] D55280: [CTU] Make loadExternalAST return with non nullptr on success

a_sidorin requested changes to this revision. a_sidorin added a comment. This revision now requires changes to proceed. Hi Gabor, There is a code in getExternalAST: std::unique_ptr LoadedUnit(ASTUnit::LoadFromASTFile( ASTFileName, CI.getPCHContainerOperations()->getRawReader(),

[PATCH] D55289: [analyzer] MoveChecker Pt.5: Improve invalidation policies.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:540-542 +// Explicit regions are the regions passed into the call directly, but +// not all of them end up being invalidated. The ones that do appear

[PATCH] D55289: [analyzer] MoveChecker Pt.5: Improve invalidation policies.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:528 ArrayRef ExplicitRegions, ArrayRef Regions, const LocationContext *LCtx, const CallEvent *Call) const { Szelethus wrote: > This isn't specific to this revision,

r348425 - Fix test change from r348365 to deal with Windows paths correctly.

Author: dyung Date: Wed Dec 5 15:10:14 2018 New Revision: 348425 URL: http://llvm.org/viewvc/llvm-project?rev=348425=rev Log: Fix test change from r348365 to deal with Windows paths correctly. Modified: cfe/trunk/test/Driver/darwin-stdlib.cpp Modified:

r348429 - Update ARC docs as objc_storeStrong returns void not id

Author: pete Date: Wed Dec 5 15:49:52 2018 New Revision: 348429 URL: http://llvm.org/viewvc/llvm-project?rev=348429=rev Log: Update ARC docs as objc_storeStrong returns void not id Modified: cfe/trunk/docs/AutomaticReferenceCounting.rst Modified:

[PATCH] D55188: Extract TextChildDumper class

This revision was automatically updated to reflect the committed changes. Closed by commit rL348410: NFC: Extract TextTreeStructure class (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D54309: [AST] Allow limiting the scope of common AST traversals (getParents, RAV).

JonasToth added a comment. Hi Sam, this patch "broke" `ExprMutAnalyzer`, at least it creates an assertion failure that seems harmless. Your thought on it would be great! The assertion in: `ASTMatchFinder.cpp +680` is triggered in the Analysis to figure out if something is mutated, because

[PATCH] D55289: [analyzer] MoveChecker Pt.5: Improve invalidation policies.

NoQ updated this revision to Diff 176877. NoQ marked 5 inline comments as done. NoQ added a comment. Address comments :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55289/new/ https://reviews.llvm.org/D55289 Files: lib/StaticAnalyzer/Checkers/MoveChecker.cpp

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

rsmith accepted this revision. rsmith added a comment. Thanks for your patience. Comment at: clang/lib/Sema/SemaInit.cpp:7838-7854 + if (const auto *FromPtrType = SourceType->getAs()) { +if (const auto *ToPtrType = Step->Type->getAs()) { + if

[PATCH] D55067: [HIP] Fix offset of kernel argument for AMDGPU target

arsenm added a comment. I think if we can just declare something simple to follow that doesn't depend on the IR type alignment, we could pack any basic type and align any aggregates to 4 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55067/new/ https://reviews.llvm.org/D55067

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan updated this revision to Diff 176862. leonardchan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53738/new/ https://reviews.llvm.org/D53738 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

Szelethus added inline comments. Comment at: test/Analysis/diagnostics/explicit-suppression.cpp:22 #ifndef SUPPRESSED - // expected-warning@../Inputs/system-header-simulator-cxx.h:670 {{Called C++ object pointer is null}} + //

[PATCH] D54014: [Sema] Push and Pop Expression Evaluation Context Records at the start and end of function definitions

leonardchan updated this revision to Diff 176893. leonardchan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54014/new/ https://reviews.llvm.org/D54014 Files: clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaDeclObjC.cpp

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus added a comment. In D54401#1318282 , @alexfh wrote: > In D54401#1315354 , @NoQ wrote: > > > The code looks good, but i vaguely remember that we might accidentally > > break clang-tidy integration that

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rC348442: [Sema/Attribute] Check for noderef attribute (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D49511?vs=176907=176908#toc Repository: rC Clang

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

rjmccall added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:1507 +Qualifiers MethodQuals = Qualifiers::fromCVRUMask( +Method->getTypeQualifiers().getCVRUQualifiers()); // We do not consider restrict a distinguishing attribute for overloading

[PATCH] D55349: Convert some ObjC alloc msgSends to runtime calls

rjmccall added inline comments. Comment at: include/clang/Basic/ObjCRuntime.h:189 + /// When this method returns true, Clang will turn non-super message sends of + /// certain selectors into calls to the correspond entrypoint: + /// alloc => objc_alloc

[PATCH] D55346: [clang-tidy] check for using declaration scope and qualification

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/AnonymousEnclosedAliasesCheck.cpp:31 + + +void AnonymousEnclosedAliasesCheck::check(const MatchFinder::MatchResult ) { Please remove unnecessary empty line. Comment at:

[PATCH] D55346: [clang-tidy] check for using declaration scope and qualification

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/abseil-anonymous-enclosed-aliases.rst:20 + + } // foo Are there guidelines? Comment at: docs/clang-tidy/checks/abseil-qualified-aliases.rst:22 + +See

r348443 - [attributes] Add more tests for os_returns_retained

Author: george.karpenkov Date: Wed Dec 5 17:21:38 2018 New Revision: 348443 URL: http://llvm.org/viewvc/llvm-project?rev=348443=rev Log: [attributes] Add more tests for os_returns_retained Modified: cfe/trunk/test/Sema/attr-osobject.mm Modified: cfe/trunk/test/Sema/attr-osobject.mm URL:

[PATCH] D55349: Convert some ObjC alloc msgSends to runtime calls

pete created this revision. pete added reviewers: ahatanak, rjmccall, erik.pilkington. Herald added a subscriber: cfe-commits. It is faster to directly call the ObjC runtime for methods such as alloc/allocWithZone instead of sending a message to those functions. This patch adds support for

r348458 - Remove CodeGen dependencies on Sema.

Author: rtrieu Date: Wed Dec 5 22:12:20 2018 New Revision: 348458 URL: http://llvm.org/viewvc/llvm-project?rev=348458=rev Log: Remove CodeGen dependencies on Sema. Move diagnostics from Sema to Frontend (or Common) so that CodeGen no longer needs to include the Sema diagnostic IDs. Modified:

r348442 - [Sema/Attribute] Check for noderef attribute

Author: leonardchan Date: Wed Dec 5 17:05:54 2018 New Revision: 348442 URL: http://llvm.org/viewvc/llvm-project?rev=348442=rev Log: [Sema/Attribute] Check for noderef attribute This patch adds the noderef attribute in clang and checks for dereferences of types that have this attribute. This

r348448 - [darwin] remove version number check when enabling -fobjc-subscripting-legacy-runtime

Author: arphaman Date: Wed Dec 5 18:44:23 2018 New Revision: 348448 URL: http://llvm.org/viewvc/llvm-project?rev=348448=rev Log: [darwin] remove version number check when enabling -fobjc-subscripting-legacy-runtime This subscripting feature actually works on older OS versions anyway.

[PATCH] D55067: [HIP] Fix offset of kernel argument for AMDGPU target

yaxunl added a comment. In D55067#1320691 , @arsenm wrote: > I think if we can just declare something simple to follow that doesn't depend > on the IR type alignment, we could pack any basic type and align any > aggregates to 4 From the user point of

r348459 - Remove unnecessary include.

Author: rtrieu Date: Wed Dec 5 22:32:40 2018 New Revision: 348459 URL: http://llvm.org/viewvc/llvm-project?rev=348459=rev Log: Remove unnecessary include. Modified: cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperations.cpp Modified:

[PATCH] D55269: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu

jdenny updated this revision to Diff 176916. jdenny retitled this revision from "[CUDA][OpenMP] Fix nvidia-cuda-toolkit detection on Debian/Ubuntu" to "[CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu". jdenny edited the summary of this revision. jdenny added a comment. Apply reviewer

r348447 - Reapply fix from r348062 to fix test on Windows.

Author: dyung Date: Wed Dec 5 18:13:09 2018 New Revision: 348447 URL: http://llvm.org/viewvc/llvm-project?rev=348447=rev Log: Reapply fix from r348062 to fix test on Windows. Modified: cfe/trunk/test/CodeGenCXX/debug-prefix-map-lambda.cpp Modified:

r348454 - ARM, AArch64: support `__attribute__((__swiftcall__))`

Author: compnerd Date: Wed Dec 5 19:28:37 2018 New Revision: 348454 URL: http://llvm.org/viewvc/llvm-project?rev=348454=rev Log: ARM, AArch64: support `__attribute__((__swiftcall__))` Support the Swift calling convention on Windows ARM and AArch64. Both of these conform to the AAPCS, AAPCS64

[PATCH] D51554: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support.

echristo added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:282-285 enum DebugInfoKind { - NoDebug, /// No debug info. - LineTableOnly, /// Line tables only. - FullDebug /// Full debug info. + NoDebug, /// No debug info. +

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

rjmccall added a comment. Okay, thanks, that makes sense to me. I'll ask around to find a way to contact the C committee. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53738/new/ https://reviews.llvm.org/D53738 ___

[PATCH] D55085: Avoid emitting redundant or unusable directories in DIFile metadata entries

ilya-biryukov added a comment. Ah, sorry, I incorrectly checked that the old revision landed without problems. Have no data on whether the new revision breaks anything, will have to wait for the input from the US timezone buildcop CHANGES SINCE LAST ACTION

Re: [cfe-dev] r347339 - [clang][Parse] Diagnose useless null statements / empty init-statements

We have about 100k unique occurrences of this warning across a slice of our software stack. It's simply not feasible to us to adopt it, so we would prefer for it to be reverted to avoid downstream divergence in Apple's clang. Granted, these occur in projects that use -Weverything but those

r348402 - Revert "[RISCV] Mark unit tests as "requires: riscv-registered-target""

Author: mgrang Date: Wed Dec 5 11:19:38 2018 New Revision: 348402 URL: http://llvm.org/viewvc/llvm-project?rev=348402=rev Log: Revert "[RISCV] Mark unit tests as "requires: riscv-registered-target"" This reverts commit 8908dd12e7bbfc74e264233e900206ad31e285f0. Modified:

Re: r347720 - [RISCV] Mark unit tests as "requires: riscv-registered-target"

Hi Alex, Sorry, I missed this thread. I guess I was too quick to commit my patch. The actual problem seems to be something else due to which riscv32-toolchain.c fails on Windows. The fact that upstream bots seem to be fine could point to a bug in our internal code. Basically it is not able

[PATCH] D21508: Diagnose friend function template redefinitions

rsmith accepted this revision. rsmith marked an inline comment as done. rsmith added a comment. This revision is now accepted and ready to land. Thanks (and sorry for dropping the ball on this review). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D21508/new/

[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

This revision was automatically updated to reflect the committed changes. Closed by commit rC348384: [Basic] Cleanups in IdentifierInfo following the removal of PTH (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D54866?vs=175143=176843#toc

[PATCH] D55131: [CTU] Add more lit tests and better error handling

Szelethus added inline comments. Comment at: test/Analysis/ctu-main.c:4 +// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -emit-pch -o %t/ctudir2/ctu-other.c.ast %S/Inputs/ctu-other.c +// RUN: cp %S/Inputs/externalFnMap2.txt %t/ctudir2/externalFnMap.txt +// RUN: %clang_cc1

[PATCH] D55322: Mention changes to libc++ include dir lookup in release notes.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55322/new/ https://reviews.llvm.org/D55322 ___

[PATCH] D55269: [CUDA][OpenMP] Fix nvidia-cuda-toolkit detection on Debian/Ubuntu

tra added a comment. In D55269#1320207 , @Hahnfeld wrote: > I think there are some misunderstandings here, or at least I understand > things differently than @tra is describing them: AFAICS this change is NOT > about replacing `nvcc` by `clang` in any

Re: [clang-tools-extra] r348176 - Fix compilation failure on Windows.

Just noticed this. Really sorry that I submitted the broken version (made the rename at the last minute) and many thanks for fixing this! On Mon, Dec 3, 2018 at 9:01 PM Zachary Turner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: zturner > Date: Mon Dec 3 11:59:00 2018 > New

[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55321/new/ https://reviews.llvm.org/D55321 ___ cfe-commits

[PATCH] D55289: [analyzer] MoveChecker Pt.5: Improve invalidation policies.

Szelethus added a comment. Cool! Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:528 ArrayRef ExplicitRegions, ArrayRef Regions, const LocationContext *LCtx, const CallEvent *Call) const { This isn't specific to this revision, but I find

[PATCH] D54796: [clangd] C++ API for emitting file status

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, still have a few NITs and suggestions (see the comment about emitting "queued" on waiting for diagnostics and **not** emitting queued if the lock was acquired from the

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

Szelethus marked an inline comment as done. Szelethus added a comment. This looks great! > Had to pass the checker into the visitor and make some methods non-static > because globals with constructors are discouraged. How about making the set `constexpr`? Comment at:

r348400 - Do not check for parameters shadowing fields in function declarations.

Author: aaronballman Date: Wed Dec 5 10:56:57 2018 New Revision: 348400 URL: http://llvm.org/viewvc/llvm-project?rev=348400=rev Log: Do not check for parameters shadowing fields in function declarations. We would issue a false-positive diagnostic for parameters in function declarations

r348394 - Mention changes to libc++ include dir lookup in release notes.

Author: ibiryukov Date: Wed Dec 5 10:32:05 2018 New Revision: 348394 URL: http://llvm.org/viewvc/llvm-project?rev=348394=rev Log: Mention changes to libc++ include dir lookup in release notes. Summary: The change itself landed as r348365, see the comment for more details. Reviewers: arphaman,

[PATCH] D55322: Mention changes to libc++ include dir lookup in release notes.

This revision was automatically updated to reflect the committed changes. Closed by commit rC348394: Mention changes to libc++ include dir lookup in release notes. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D55322?vs=176809=176854#toc Repository:

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

Szelethus added a comment. I like what I'm seeing. In D55226#1320281 , @Pierre-vh wrote: > Hi again! > > As I'm quite new to this, I don't know what the next step is. Do we need to > wait for more people to review this diff? > What happens when it's

r348396 - [analyzer] Attribute for RetainCountChecker for OSObject should propagate with inheritance

Author: george.karpenkov Date: Wed Dec 5 10:34:54 2018 New Revision: 348396 URL: http://llvm.org/viewvc/llvm-project?rev=348396=rev Log: [analyzer] Attribute for RetainCountChecker for OSObject should propagate with inheritance rdar://46388388 Differential Revision:

r348397 - Honor -fdebug-prefix-map when creating function names for the debug info.

Author: adrian Date: Wed Dec 5 10:37:44 2018 New Revision: 348397 URL: http://llvm.org/viewvc/llvm-project?rev=348397=rev Log: Honor -fdebug-prefix-map when creating function names for the debug info. This adds a callback to PrintingPolicy to allow CGDebugInfo to remap file paths according to

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

ilya-biryukov added inline comments. Comment at: clangd/XRefs.cpp:578 +bool Invalid; +StringRef Buffer = SM.getBufferData(SM.getFileID(StartLoc), ); +if (!Invalid) { Unfortunately we can't get the buffer here, because for the preamble macros the

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

NoQ added inline comments. Comment at: test/Analysis/diagnostics/explicit-suppression.cpp:22 #ifndef SUPPRESSED - // expected-warning@../Inputs/system-header-simulator-cxx.h:670 {{Called C++ object pointer is null}} + //

Re: [cfe-dev] r347339 - [clang][Parse] Diagnose useless null statements / empty init-statements

On Wed, 5 Dec 2018, 10:01 George Karpenkov via cfe-commits < cfe-commits@lists.llvm.org wrote: > These are the cases I get: > > #define unexpected(a) { kprintf("unexpected %s:%d\n", __FILE__, __LINE__); > a; } > > and > > #if 0 > #define DEBG(fmt, args...) { IOLog(fmt, ## args); kprintf(fmt,

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

NoQ updated this revision to Diff 176856. NoQ marked an inline comment as done. NoQ added a comment. Convert the pointer to a reference. In D55307#1320434 , @Szelethus wrote: > > Had to pass the checker into the visitor and make some methods non-static

[PATCH] D53866: [Preamble] Stop generating preamble for circular #includes

ilya-biryukov added inline comments. Comment at: include/clang/Lex/Preprocessor.h:391 } PreambleConditionalStack; + bool PreambleGenerationFailed = false; nik wrote: > ilya-biryukov wrote: > > There's a mechanism to handle preamble with errors, see > >

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. AFAIK `constexpr` arrays can be `std::sort`-ed, but it probably isn't worth the effort, I tried it myself when I was working with non-checker configs, and it's a big hassle for

r348399 - Adding tests for -ast-dump; NFC.

Author: aaronballman Date: Wed Dec 5 10:53:57 2018 New Revision: 348399 URL: http://llvm.org/viewvc/llvm-project?rev=348399=rev Log: Adding tests for -ast-dump; NFC. This adds tests for various function and class template declarations. Added: cfe/trunk/test/AST/ast-dump-template-decls.cpp

[PATCH] D55315: [clangd] Only reduce priority of a thread for indexing.

ilya-biryukov added inline comments. Comment at: clangd/Threading.h:124 }; -void setThreadPriority(std::thread , ThreadPriority Priority); +// Sets scheduling priority for the calling thread. +void setCurrentThreadPriority(ThreadPriority Priority); The comment

[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in r348400. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55321/new/ https://reviews.llvm.org/D55321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r348384 - [Basic] Cleanups in IdentifierInfo following the removal of PTH

Author: brunoricci Date: Wed Dec 5 09:16:55 2018 New Revision: 348384 URL: http://llvm.org/viewvc/llvm-project?rev=348384=rev Log: [Basic] Cleanups in IdentifierInfo following the removal of PTH The Entry pointer in IdentifierInfo was only null for IdentifierInfo created from a PTH. Now that

[PATCH] D55334: [AST] Pass the ASTContext to one of the ctor of DeclRefExpr

riccibruno created this revision. riccibruno added a reviewer: aaron.ballman. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Pass the `ASTContext` to one of the constructor of `DeclRefExpr` since in most cases the appropriate `ASTContext` is readily available.

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

romanovvlad updated this revision to Diff 176850. romanovvlad added a comment. Added new test case + formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262 Files: lib/CodeGen/CGExpr.cpp test/CodeGenOpenCLCXX/address-space-deduction2.cl

[PATCH] D55085: Avoid emitting redundant or unusable directories in DIFile metadata entries

ilya-biryukov added a comment. It looks like the integrate went smoothly with the new change, thanks for fixing it! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55085/new/ https://reviews.llvm.org/D55085 ___ cfe-commits mailing list

r348387 - [CodeComplete] Fix a crash in access checks of inner classes

Author: ibiryukov Date: Wed Dec 5 09:38:39 2018 New Revision: 348387 URL: http://llvm.org/viewvc/llvm-project?rev=348387=rev Log: [CodeComplete] Fix a crash in access checks of inner classes Summary: The crash was introduced in r348135. Reviewers: kadircet Reviewed By: kadircet Subscribers:

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

This revision was automatically updated to reflect the committed changes. Closed by commit rC348387: [CodeComplete] Fix a crash in access checks of inner classes (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D55260?vs=176823=176847#toc Repository:

Re: r348325 - [Sema] Remove some conditions of a failing assert

On 12/4/18 7:07 PM, Richard Smith wrote: On Tue, 4 Dec 2018 at 16:46, Erik Pilkington via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: epilk Date: Tue Dec  4 16:43:11 2018 New Revision: 348325 URL: http://llvm.org/viewvc/llvm-project?rev=348325=rev Log:

r348388 - Address a post-commit review comment on r348325.

Author: epilk Date: Wed Dec 5 09:43:26 2018 New Revision: 348388 URL: http://llvm.org/viewvc/llvm-project?rev=348388=rev Log: Address a post-commit review comment on r348325. Modified: cfe/trunk/test/SemaCXX/friend-template-redecl.cpp Modified:

Re: [cfe-dev] r347339 - [clang][Parse] Diagnose useless null statements / empty init-statements

These are the cases I get: #define unexpected(a) { kprintf("unexpected %s:%d\n", __FILE__, __LINE__); a; } and #if 0 #define DEBG(fmt, args...) { IOLog(fmt, ## args); kprintf(fmt, ## args); } #else #define DEBG(fmt, args...) {} #endif Now calls `DEBG(‘x’);` and `unexpected(‘msg’);`

<    1   2