[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay added a comment. @curdeius Thanks, I don't have commit access so I'm happy wait for a CODE_OWNER, they could likely have more input. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55433/new/ https://reviews.llvm.org/D55433

RE: r348665 - [tests] Fix the FileManagerTest getVirtualFile test on Windows

The failure that you are getting when you run on the d:\ drive is what we were seeing before this change in our testing. What do you get without this change? Thanks, -Stella -Original Message- From: Aaron Ballman Sent: Monday, December 10, 2018 10:11 AM To: Stella Stamenova Cc:

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM. Do you have commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55508/new/ https://reviews.llvm.org/D55508 ___

Re: [PATCH] D55377: Allow forwarding -fdebug-compilation-dir to cc1as

Would it be worth considering whether -fdebug-compilation-dir and -fdebug-prefix-map could be unified, perhaps by having a placeholder that could be used in -fdebug-prefix-map for the current directory? I guess they're low-maintenance enough that it's probably not, but figured I'd ask. On Thu,

r348786 - Adding tests for -ast-dump; NFC.

Author: aaronballman Date: Mon Dec 10 10:37:47 2018 New Revision: 348786 URL: http://llvm.org/viewvc/llvm-project?rev=348786=rev Log: Adding tests for -ast-dump; NFC. This adds tests for expressions in C. Added: cfe/trunk/test/AST/ast-dump-expr.c Added: cfe/trunk/test/AST/ast-dump-expr.c

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson marked an inline comment as done. arichardson added inline comments. Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:15 +// FIXME: After changing the subject from Function to HasFunctionProto, AllocSize is no longer listed (similar to Format,

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay updated this revision to Diff 177532. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. Addressing review comments, - additional unit tests for no ReplacementString and C++ 11 case - more expressive hasNonConstReferenceOrPointerArguments matcher -

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

ahatanak added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47757/new/ https://reviews.llvm.org/D47757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

MyDeveloperDay updated this revision to Diff 177538. MyDeveloperDay added a comment. Fix review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55508/new/ https://reviews.llvm.org/D55508 Files: clang-tidy/add_new_check.py Index: clang-tidy/add_new_check.py

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

JonasToth added a comment. Hi MyDeveloperDay, thanks for the patch! Mostly stylistic comments. Would it make sense to attach the attribute to the implementation of the functions too? This check is definitly useful, but noisy. Do you see a change of another heuristic that could be applied to

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

JonasToth added a comment. I think this patch is fine, AFAIK these utility scripts are not tested directly but are just adjusted if they dont work as expected :) Did you test it with a fake new-check? If it does what we expect its fine :) CHANGES SINCE LAST ACTION

[PATCH] D55484: ComputeLineNumbers: delete SSE2 vectorization

MaskRay added a comment. In D55484#1324983 , @bkramer wrote: > The performance difference on preprocessing huge files was tiny back then, > doesn't surprise me that it disappeared. What did you test this on? I tested it on cat lib/Sema/*.cpp

[PATCH] D55097: [constexpr][c++2a] Try-catch blocks in constexpr functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL348789: [constexpr][c++2a] Try-catch blocks in constexpr functions (authored by bruno, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

ldionne added inline comments. Comment at: libcxx/include/memory:1645 -template +template _LIBCPP_INLINE_VISIBILITY Quuxplusone wrote: > ldionne wrote: > > Coming at it from a slightly different angle, I would think this is what we > >

[PATCH] D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

bruno added a comment. Hi Eric, Thanks for working on this! Comment at: include/clang/Basic/Builtins.def:759 +// Random C++ builtins. +LANGBUILTIN(__builtin_is_constant_evaluated, "b", "ncu", CXX_LANG) + Name bikeshedding : perhaps the builtin name could be

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

JonasToth added a comment. In D55508#1325960 , @Eugene.Zelenko wrote: > By the word, will be good idea to have script which check alphabetical order > and use it during build. Sometimes alphabetical order may be violated after > merge with trunk. I

Re: r348665 - [tests] Fix the FileManagerTest getVirtualFile test on Windows

On Mon, Dec 10, 2018 at 12:30 PM Stella Stamenova wrote: > > Our tests run on drive E:\ (not C:\) which is why we saw this test failing. > After this change, the test can now run successfully for us because the > temporary files are created and checked for on the C:\ drive. Before this >

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

JonasToth added a comment. In D55508#1325834 , @MyDeveloperDay wrote: > In D55508#1325758 , @JonasToth wrote: > > > LGTM. Do you have commit access? > > > I do not I'm afraid I will commit for you. CHANGES

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. But I'm not a code owner here and I don't know if you need an acceptance of one of them. Great job. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55433/new/

[PATCH] D47111: : Implement monotonic_buffer_resource.

Quuxplusone updated this revision to Diff 177540. Quuxplusone marked 5 inline comments as done. Quuxplusone added a comment. @ericwf ping! Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47111/new/ https://reviews.llvm.org/D47111 Files:

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. In D55508#1325670 , @JonasToth wrote: > I think this patch is fine, AFAIK these utility scripts are not tested > directly but are just adjusted if they dont work as expected

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan updated this revision to Diff 177561. leonardchan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55447/new/ https://reviews.llvm.org/D55447 Files: clang/include/clang/Sema/Sema.h clang/lib/AST/TypePrinter.cpp

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. In D53738#1320936 , @rjmccall wrote: > Okay, thanks, that makes sense to me. > > I'll ask around to find a way to contact the C committee. @rjmccall Any updates on this? If we aren't able to find a way to contact anyone

[PATCH] D55212: Handle alloc_size attribute on function pointers

aaron.ballman added inline comments. Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:15 +// FIXME: After changing the subject from Function to HasFunctionProto, AllocSize is no longer listed (similar to Format, etc) +// FIXME-NEXT: AllocSize

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

rjmccall added a comment. We sent the question out, but we haven't gotten a response yet. I think going forward under the idea that this just changes the type but does the operation on the original operand types is the right way to go forward in the short term. Repository: rC Clang

[PATCH] D54438: [analyzer] Reimplement dependencies between checkers

Szelethus added a comment. I can't fix these right away, but I don't want myself to forget it before commiting. Pay no attention. Comment at: include/clang/StaticAnalyzer/Checkers/CheckerBase.td:51-56 +/// relies on information MallocBase gathers. +/// Example: +/// def

RE: r348665 - [tests] Fix the FileManagerTest getVirtualFile test on Windows

Our tests run on drive E:\ (not C:\) which is why we saw this test failing. After this change, the test can now run successfully for us because the temporary files are created and checked for on the C:\ drive. Before this change, the temporary files were created on the E:\ drive and checked for

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

aaron.ballman added inline comments. Comment at: lib/AST/ExprConstant.cpp:6151 +Info.Ctx.getBaseElementType(getType(Result.getLValueBase())); +const bool IsRawByte = BuiltinOp == Builtin::BImemchr || + BuiltinOp ==

r348789 - [constexpr][c++2a] Try-catch blocks in constexpr functions

Author: bruno Date: Mon Dec 10 11:03:12 2018 New Revision: 348789 URL: http://llvm.org/viewvc/llvm-project?rev=348789=rev Log: [constexpr][c++2a] Try-catch blocks in constexpr functions Implement support for try-catch blocks in constexpr functions, as proposed in http://wg21.link/P1002 and voted

r348790 - Add an explicit triple to this test to fix failing test bots.

Author: aaronballman Date: Mon Dec 10 11:18:11 2018 New Revision: 348790 URL: http://llvm.org/viewvc/llvm-project?rev=348790=rev Log: Add an explicit triple to this test to fix failing test bots. Modified: cfe/trunk/test/AST/ast-dump-expr.c Modified: cfe/trunk/test/AST/ast-dump-expr.c URL:

[PATCH] D55488: Add utility for dumping a label with child nodes

aaron.ballman added inline comments. Comment at: include/clang/AST/ASTDumperUtils.h:115 + template + void addChild(const std::string , Fn doAddChild) { +if (label.empty()) label -> Label doAddChild -> DoAddChild Comment at:

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

Eugene.Zelenko added a comment. By the word, will be good idea to have script which check alphabetical order and use it during build. Sometimes alphabetical order may be violated after merge with trunk. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55508/new/

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

aaron.ballman added inline comments. Comment at: clang/test/Sema/address_space_attribute.cpp:1 +// RUN: %clang_cc1 %s -ast-dump | FileCheck %s + This test should be moved to the AST directory instead of Sema. Comment at:

[PATCH] D55484: ComputeLineNumbers: delete SSE2 vectorization

This revision was automatically updated to reflect the committed changes. Closed by commit rL348777: ComputeLineNumbers: delete SSE2 vectorization (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D55229: [COFF] Statically link certain runtime library functions

mgrang added a comment. Ping for reviews please. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55229/new/ https://reviews.llvm.org/D55229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r348665 - [tests] Fix the FileManagerTest getVirtualFile test on Windows

On Mon, Dec 10, 2018 at 1:18 PM Stella Stamenova wrote: > > The failure that you are getting when you run on the d:\ drive is what we > were seeing before this change in our testing. What do you get without this > change? When I reverted the change, I got the same behavior -- so then I

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

MyDeveloperDay added a comment. In D55508#1325758 , @JonasToth wrote: > LGTM. Do you have commit access? I do not I'm afraid CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55508/new/ https://reviews.llvm.org/D55508

[clang-tools-extra] r348793 - [clang-tidy] insert release notes for new checkers alphabetically

Author: jonastoth Date: Mon Dec 10 11:41:53 2018 New Revision: 348793 URL: http://llvm.org/viewvc/llvm-project?rev=348793=rev Log: [clang-tidy] insert release notes for new checkers alphabetically Summary: Almost all code review comments on new checkers {D55433} {D48866} {D54349} seem to ask

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

This revision was automatically updated to reflect the committed changes. Closed by commit rL348793: [clang-tidy] insert release notes for new checkers alphabetically (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

scott.linder added a comment. There may be changes to some details in the LLVM patch; once they are finalized I will update the Clang patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54489/new/ https://reviews.llvm.org/D54489 ___

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. This is missing all of the Sema and SemaCXX tests. Should have tests for member functions, variadic functions, incorrect arguments, incorrect subjects, etc.

r348777 - ComputeLineNumbers: delete SSE2 vectorization

Author: maskray Date: Mon Dec 10 10:10:35 2018 New Revision: 348777 URL: http://llvm.org/viewvc/llvm-project?rev=348777=rev Log: ComputeLineNumbers: delete SSE2 vectorization Summary: SSE2 vectorization was added in 2012, but it is 2018 now and I can't observe any performance boost (testing

Re: r348685 - Move diagnostic enums into Basic.

Hey Richard, Thanks for cleaning up some of the layering here! I /think/ I vaguely recall having a conversation with Richard Smith about a different direction to fix the layering of the diagnostics system - but it was/is more involved. Ah, here, apparently I sent out a WIP patch & must've got

[PATCH] D55525: [Driver] Add support for -fembed-bitcode for assembly file

steven_wu created this revision. steven_wu added reviewers: compnerd, dexonsmith. Herald added a subscriber: jkorous. Handle -fembed-bitcode for assembly inputs. When the input file is assembly, write a marker as "__LLVM,__asm" section. Fix llvm.org/pr39659 Repository: rC Clang

[PATCH] D21230: Do not embed all the cc1 options in bitcode commandline

steven_wu abandoned this revision. steven_wu added a comment. Herald added subscribers: jkorous, mehdi_amini. This is upstreamed by Saleem already CHANGES SINCE LAST ACTION https://reviews.llvm.org/D21230/new/ https://reviews.llvm.org/D21230 ___

[PATCH] D55527: Normalize GlobalDecls when used with CPUDispatch

erichkeane created this revision. erichkeane added reviewers: rsmith, aaron.ballman. Previously, CPUDispatch functionality did some wacky things with GlobalDecls, which resulted in multiple GlobalDecls having the same mangled name. This patch corrects this in a few ways: First, it Moves the

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay updated this revision to Diff 177584. MyDeveloperDay marked 11 inline comments as done. MyDeveloperDay added a comment. Addressing review comments - grammatical errors in documentation and comments - prevent adding [[nodiscard]] to macros - clean up list.rst CHANGES SINCE LAST

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. In D53738#1325998 , @rjmccall wrote: > We sent the question out, but we haven't gotten a response yet. I think > going forward under the idea that this just changes the type but does the > operation on the original operand

[PATCH] D55495: Change InitListExpr dump to label and pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL348794: Change InitListExpr dump to label and pointer (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r348794 - Change InitListExpr dump to label and pointer

Author: steveire Date: Mon Dec 10 12:53:32 2018 New Revision: 348794 URL: http://llvm.org/viewvc/llvm-project?rev=348794=rev Log: Change InitListExpr dump to label and pointer Summary: Don't add a child just for the label. Reviewers: aaron.ballman Subscribers: cfe-commits Differential

[PATCH] D55395: Re-order content in OMPDeclareReductionDecl dump

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL348795: Re-order content in OMPDeclareReductionDecl dump (authored by steveire, committed by ). Herald added a

r348795 - Re-order content in OMPDeclareReductionDecl dump

Author: steveire Date: Mon Dec 10 12:53:39 2018 New Revision: 348795 URL: http://llvm.org/viewvc/llvm-project?rev=348795=rev Log: Re-order content in OMPDeclareReductionDecl dump Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55395 Modified:

[PATCH] D55245: [clang-tidy] Add the abseil-duration-subtraction check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationRewriter.cpp:77 + getInverseForScale(Scale); + if (const auto *MaybeCallArg = selectFirst( + "e", hwright wrote: > JonasToth wrote: > > In Principle the `Node` could have

Re: r348794 - Change InitListExpr dump to label and pointer

I'll revert it to allow for further discussion. On 10/12/2018 21:12, Richard Smith wrote: On Mon, 10 Dec 2018 at 12:56, Stephen Kelly via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: steveire Date: Mon Dec 10 12:53:32 2018 New Revision: 348794 URL:

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 

benhamilton accepted this revision. benhamilton added a comment. This revision is now accepted and ready to land. Thanks, just minor suggestions. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:114-118 diag(MatchedDecl->getLocation(), - "function name %0 not

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 

stephanemoore marked 4 inline comments as done. stephanemoore added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:114-118 diag(MatchedDecl->getLocation(), - "function name %0 not using function naming conventions described by " - "Google

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added inline comments. Comment at: lib/AST/ExprConstant.cpp:6147-6148 + return ZeroInitialization(E); +if (!Result.checkNullPointerForFoldAccess(Info, E, AK_Read)) + return false; +

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan added inline comments. Comment at: clang/tools/libclang/CXType.cpp:132 + if (!(TU->ParsingOptions & CXTranslationUnit_IncludeAttributedTypes) && + ATT->getAttrKind() != attr::AddressSpace) { return MakeCXType(ATT->getModifiedType(), TU);

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan updated this revision to Diff 177620. leonardchan marked 2 inline comments as done. leonardchan added a comment. - Added the CXX11 test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55447/new/ https://reviews.llvm.org/D55447 Files:

[PATCH] D55405: [CMake] Use hidden visibility for static libc++ in Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55405/new/ https://reviews.llvm.org/D55405 ___

[PATCH] D55393: Re-order content of template parameter dumps

This revision was automatically updated to reflect the committed changes. Closed by commit rL348797: Re-order content of template parameter dumps (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r348797 - Re-order content of template parameter dumps

Author: steveire Date: Mon Dec 10 13:03:00 2018 New Revision: 348797 URL: http://llvm.org/viewvc/llvm-project?rev=348797=rev Log: Re-order content of template parameter dumps Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55393 Modified:

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

JonasToth added inline comments. Comment at: clang-tidy/modernize/UseNodiscardCheck.cpp:29 +AST_MATCHER(CXXMethodDecl, isOverloadedOperator) { + // Don't put [[nodiscard]] front of operators. + return Node.isOverloadedOperator(); s/front/in front/

Re: r348794 - Change InitListExpr dump to label and pointer

On Mon, 10 Dec 2018 at 12:56, Stephen Kelly via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: steveire > Date: Mon Dec 10 12:53:32 2018 > New Revision: 348794 > > URL: http://llvm.org/viewvc/llvm-project?rev=348794=rev > Log: > Change InitListExpr dump to label and pointer > >

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

rsmith added inline comments. Comment at: lib/AST/ExprConstant.cpp:6147-6148 + return ZeroInitialization(E); +if (!Result.checkNullPointerForFoldAccess(Info, E, AK_Read)) + return false; +QualType CharTy = Why do we need to do this explicitly,

[PATCH] D55488: Add utility for dumping a label with child nodes

steveire updated this revision to Diff 177594. steveire marked an inline comment as done. steveire added a comment. Update with new approach Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55488/new/ https://reviews.llvm.org/D55488 Files:

Re: r348794 - Change InitListExpr dump to label and pointer

On Mon, Dec 10, 2018 at 4:13 PM Richard Smith via cfe-commits wrote: > > On Mon, 10 Dec 2018 at 12:56, Stephen Kelly via cfe-commits > wrote: >> >> Author: steveire >> Date: Mon Dec 10 12:53:32 2018 >> New Revision: 348794 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=348794=rev >> Log: >>

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast added inline comments. Comment at: lib/AST/ExprConstant.cpp:6159-6160 +// Give up on byte-oriented matching against multibyte elements. +if (IsRawByte && Info.Ctx.getTypeSize(CharTy) > Info.Ctx.getCharWidth()) + return false; // Figure

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast updated this revision to Diff 177597. hubert.reinterpretcast marked 11 inline comments as done. hubert.reinterpretcast added a comment. Make an initial pass at addressing the review comments Address comments on style and code comments Repository: rC Clang CHANGES

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

EricWF created this revision. EricWF added reviewers: fowles, rsmith, klimek. Herald added a reviewer: shafik. Currently the Clang AST doesn't store information about how the callee of a CallExpr was found. Specifically if it was found using ADL. However, this information is invaluable to

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

Quuxplusone added inline comments. Comment at: libcxx/include/memory:1645 -template +template _LIBCPP_INLINE_VISIBILITY ldionne wrote: > Quuxplusone wrote: > > ldionne wrote: > > > Coming at it from a slightly different angle, I would think

Re: r348798 - Fix nits

On Tue, Dec 11, 2018 at 12:07 AM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Mon Dec 10 13:04:04 2018 > New Revision: 348798 > > URL: http://llvm.org/viewvc/llvm-project?rev=348798=rev > Log: > Fix nits Can you *please* write proper commit messages, pretty please? I have

[PATCH] D54604: Automatic variable initialization

jfb updated this revision to Diff 177600. jfb added a comment. - Make sure uninit-variables.c doesn't break. - Address Peter's comments, improve tests. - Add an ugly option to enable zero init - Update warning-flags.c - Fix typo - Use negative NaN with repeated 0xFF payload for all floating-point

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 

stephanemoore updated this revision to Diff 177609. stephanemoore marked 4 inline comments as done. stephanemoore added a comment. Use the select modifier to customize diagnostics for static and non-static function instead of branching diagnostic code paths for static and non-static functions.

[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

NoQ added a comment. Should we also pass `CheckerManager` into `shouldRegister...`? Or is it entirely useless? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55424/new/ https://reviews.llvm.org/D55424 ___

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan updated this revision to Diff 177587. leonardchan marked 3 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55447/new/ https://reviews.llvm.org/D55447 Files: clang/include/clang/Sema/Sema.h clang/lib/AST/TypePrinter.cpp

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan added inline comments. Comment at: clang/test/Sema/address_space_attribute.cpp:9 + // CHECK: VarDecl {{.*}} x '__attribute__((address_space(1))) int *' + __attribute__((address_space(1))) int *x; + aaron.ballman wrote: > Can you also add a test

[PATCH] D55245: [clang-tidy] Add the abseil-duration-subtraction check

hwright updated this revision to Diff 177590. hwright marked 9 inline comments as done. hwright added a comment. Add tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55245/new/ https://reviews.llvm.org/D55245 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D55245: [clang-tidy] Add the abseil-duration-subtraction check

hwright added inline comments. Comment at: clang-tidy/abseil/DurationRewriter.cpp:21 +struct DurationScale2IndexFunctor { + using argument_type = DurationScale; + unsigned operator()(DurationScale Scale) const { JonasToth wrote: > Are you using

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert marked 2 inline comments as done. jdoerfert added a comment. In D55483#1326029 , @aaron.ballman wrote: > This is missing all of the Sema and SemaCXX tests. Should have tests for > member functions, variadic functions, incorrect arguments,

[PATCH] D55488: Add utility for dumping a label with child nodes

steveire updated this revision to Diff 177595. steveire added a comment. Clean up API a bit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55488/new/ https://reviews.llvm.org/D55488 Files: include/clang/AST/ASTDumperUtils.h lib/AST/ASTDumper.cpp

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

rsmith added inline comments. Comment at: lib/AST/ExprConstant.cpp:8465 +return false; + uint64_t LengthPerElement{CharTy1Width / Info.Ctx.getCharWidth()}; + assert(MaxLength && "MaxLength should not be zero: the following loop " Use

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/modernize-use-nodiscard.rst:49 + + +.. code-block:: c++ Unnecessary empty line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55433/new/ https://reviews.llvm.org/D55433

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

rjmccall added a comment. I'm fine with making this change under the assumption that we've gotten the language rule right. Even if that weren't abstractly reasonable for general language work — and I do think it's reasonable when we have a good-faith question about the right semantics — this

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

ldionne added inline comments. Comment at: libcxx/include/memory:1658 +|| !__has_construct::value) && + is_trivially_move_constructible<_DestTp>::value, void Quuxplusone wrote: > Shouldn't this be something like

Re: r348794 - Change InitListExpr dump to label and pointer

I suggest continuing this discussion here: https://reviews.llvm.org/D55488 On 10/12/2018 21:42, Aaron Ballman wrote: On Mon, Dec 10, 2018 at 4:13 PM Richard Smith via cfe-commits wrote: On Mon, 10 Dec 2018 at 12:56, Stephen Kelly via cfe-commits wrote: Author: steveire Date: Mon Dec 10

[PATCH] D15881: [DWARF] Omitting the explicit import of an anonymous namespace is a debugger-tuning decision, not a target decision.

probinson abandoned this revision. probinson added a comment. Herald added a subscriber: JDevlieghere. Abandoning dead patch. This wound up being done a different way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15881/new/ https://reviews.llvm.org/D15881

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast updated this revision to Diff 177618. hubert.reinterpretcast marked 6 inline comments as done. hubert.reinterpretcast added a comment. Use lvalue designator, add assertions for type matching Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

aaron.ballman added inline comments. Comment at: clang/test/Sema/address_space_attribute.cpp:9 + // CHECK: VarDecl {{.*}} x '__attribute__((address_space(1))) int *' + __attribute__((address_space(1))) int *x; + leonardchan wrote: > aaron.ballman wrote: > >

r348799 - Revert "Change InitListExpr dump to label and pointer"

Author: steveire Date: Mon Dec 10 13:20:05 2018 New Revision: 348799 URL: http://llvm.org/viewvc/llvm-project?rev=348799=rev Log: Revert "Change InitListExpr dump to label and pointer" This reverts commit r348794. Modified: cfe/trunk/lib/AST/ASTDumper.cpp

[PATCH] D55488: Add utility for dumping a label with child nodes

steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:89 void dumpDecl(const Decl *D); -void dumpStmt(const Stmt *S); +void dumpStmt(const Stmt *S, const std::string = {}); aaron.ballman wrote: > Label > > Rather than using `{}`, how

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong added a comment. Alexey, good news! I have finished the testing of the above patch applied on top of 174545. Neither is a regression on Linux nor on macOS. (ASTTests, check-clang-astmerge, check-clang-import, check-clang-analysis, check-lldb). Repository: rC Clang CHANGES SINCE

r348809 - Update test for instcombine change

Author: arsenm Date: Mon Dec 10 15:02:40 2018 New Revision: 348809 URL: http://llvm.org/viewvc/llvm-project?rev=348809=rev Log: Update test for instcombine change Modified: cfe/trunk/test/CodeGen/vector.c Modified: cfe/trunk/test/CodeGen/vector.c URL:

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 

stephanemoore added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:114-125 + if (MatchedDecl->getStorageClass() == SC_Static) { +diag(MatchedDecl->getLocation(), + "static function name %0 must be in Pascal case as required by " +

r348798 - Fix nits

Author: steveire Date: Mon Dec 10 13:04:04 2018 New Revision: 348798 URL: http://llvm.org/viewvc/llvm-project?rev=348798=rev Log: Fix nits Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

[PATCH] D55066: [ASan] Minor documentation fix: clarify static linking limitation.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55066/new/ https://reviews.llvm.org/D55066 ___ cfe-commits

r348820 - [analyzer] Display a diagnostics when an inlined function violates its os_consumed summary

Author: george.karpenkov Date: Mon Dec 10 17:13:40 2018 New Revision: 348820 URL: http://llvm.org/viewvc/llvm-project?rev=348820=rev Log: [analyzer] Display a diagnostics when an inlined function violates its os_consumed summary This is currently a diagnostics, but might be upgraded to an error

r348822 - [analyzer] Remove memoization from RunLoopAutoreleaseLeakChecker

Author: george.karpenkov Date: Mon Dec 10 17:14:17 2018 New Revision: 348822 URL: http://llvm.org/viewvc/llvm-project?rev=348822=rev Log: [analyzer] Remove memoization from RunLoopAutoreleaseLeakChecker Memoization dose not seem to be necessary, as other statement visitors run just fine without

r348821 - [analyzer] Hack for backwards compatibility for options for RetainCountChecker.

Author: george.karpenkov Date: Mon Dec 10 17:13:58 2018 New Revision: 348821 URL: http://llvm.org/viewvc/llvm-project?rev=348821=rev Log: [analyzer] Hack for backwards compatibility for options for RetainCountChecker. To be removed once the clients update. Modified:

[PATCH] D54921: [analyzer] Remove memoization from RunLoopAutoreleaseLeakChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC348822: [analyzer] Remove memoization from RunLoopAutoreleaseLeakChecker (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

  1   2   >