[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

ruiu added a comment. But that's only adding missing `-L` and perhaps a few more, no? That doesn't seem too hard to do in gcc. I don't want to repeat what compiler drivers do in the linker. Also, even with this patch, you need to make a change to gcc to pass `--target` parameter to the linker,

[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

Charusso added a comment. Thanks you @NoQ! Luckily it is rely on `ProgramPoints` now. The only problem as I see the mentioned Z3-test, where I have no idea what happened. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53076/new/ https://reviews.llvm.org/D53076

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

ruiu added a comment. If you still need to patch GNU ld, it doesn't seems like this patch makes things easier for you. (But even if this would make it easier for you, this patch's approach is not okay by design though.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56650/new/

r352656 - [ASTDump] NFC: Inline vestigial methods

Author: steveire Date: Wed Jan 30 11:41:04 2019 New Revision: 352656 URL: http://llvm.org/viewvc/llvm-project?rev=352656=rev Log: [ASTDump] NFC: Inline vestigial methods This was a porting aid. Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

r352663 - [ASTDump] Make method definition order matches declaration order

Author: steveire Date: Wed Jan 30 12:06:52 2019 New Revision: 352663 URL: http://llvm.org/viewvc/llvm-project?rev=352663=rev Log: [ASTDump] Make method definition order matches declaration order This will make follow-up changes easier to review. Modified: cfe/trunk/lib/AST/ASTDumper.cpp

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

krytarowski added a comment. In D56650#1377546 , @ruiu wrote: > If you still need to patch GNU ld, it doesn't seems like this patch makes > things easier for you. (But even if this would make it easier for you, this > patch's approach is not okay by

[PATCH] D56760: Add a new builtin: __builtin_dynamic_object_size

This revision was automatically updated to reflect the committed changes. Closed by commit rL352665: Add a new builtin: __builtin_dynamic_object_size (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

Re: r352672 - Don't define __has_feature(objc_fixed_enum) in non-objc mode

Hans, can you cherry-pick this into LLVM 8? Thanks! On 1/30/19 1:14 PM, Erik Pilkington via cfe-commits wrote: Author: epilk Date: Wed Jan 30 13:14:08 2019 New Revision: 352672 URL: http://llvm.org/viewvc/llvm-project?rev=352672=rev Log: Don't define __has_feature(objc_fixed_enum) in non-objc

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

erik.pilkington added a comment. In D52339#1377527 , @arphaman wrote: > @erik.pilkington the change to make `objc_fixed_enum` true in non-ObjC mode > turned out to be problematic for our adoption. Could you please fix it before > LLVM8 is wrapped up so

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Dor1s created this revision. Dor1s added a reviewer: morehouse. Herald added a subscriber: cfe-commits. There is a bug for this: https://bugs.llvm.org/show_bug.cgi?id=34636 But it would be also helpful to leave a note in the docs to prevent users from running into issues, e.g.

[PATCH] D57278: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

This revision was automatically updated to reflect the committed changes. Closed by commit rC352690: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of… (authored by yln, committed by ). Changed prior to commit: https://reviews.llvm.org/D57278?vs=184168=184393#toc

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

domdom marked an inline comment as not done. domdom added inline comments. Comment at: clang/include/clang/AST/Stmt.h:1259 + // the index of the last one. + unsigned getLastNonNullStmt() const { +assert(!body_empty() && "getLastNonNullStmt"); aaron.ballman

[PATCH] D57488: [CUDA] add support for the new kernel launch API in CUDA-9.2+.

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. LGTM, mostly nits. Comment at: clang/include/clang/Sema/Sema.h:10316 + /// Returns the name of the launch configuration function. + std::string

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 184431. Dosi-Dough marked 11 inline comments as done. Dosi-Dough added a comment. fixed white space/ formatting issues. removed .DS_Store. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files:

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:80 + if (cons) { +if (cons->isListInitialization()) { + return; Please elide braces. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/

[PATCH] D57343: lit: Let lit.util.which() return a normcase()ed path

This revision was automatically updated to reflect the committed changes. Closed by commit rL352704: lit: Let lit.util.which() return a normcase()ed path (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D57343?vs=183912=184408#toc Repository: rL LLVM

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

domdom updated this revision to Diff 184414. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57086/new/ https://reviews.llvm.org/D57086 Files: clang/include/clang/AST/Stmt.h clang/lib/CodeGen/CGStmt.cpp clang/lib/Parse/ParseStmt.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

domdom updated this revision to Diff 184413. domdom marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57086/new/ https://reviews.llvm.org/D57086 Files: clang/include/clang/AST/Stmt.h clang/lib/CodeGen/CGStmt.cpp Index: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D57497: [RISCV] Passing -G value to RISCV backend

shiva0217 created this revision. shiva0217 added reviewers: asb, apazos. Herald added subscribers: jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar. Passing -G value to

r352733 - Revert "[CMake] Unify scripts for generating VCS headers"

Author: phosek Date: Wed Jan 30 23:12:43 2019 New Revision: 352733 URL: http://llvm.org/viewvc/llvm-project?rev=352733=rev Log: Revert "[CMake] Unify scripts for generating VCS headers" This reverts commits r352729 and r352731: this broke Sanitizer Windows bots Modified:

r352693 - [analyzer] Make NullReturnedFromNonnullChecker depend on NullabilityBase

Author: szelethus Date: Wed Jan 30 15:48:37 2019 New Revision: 352693 URL: http://llvm.org/viewvc/llvm-project?rev=352693=rev Log: [analyzer] Make NullReturnedFromNonnullChecker depend on NullabilityBase Accidentally left this dependency out after D54438. Added:

[PATCH] D57487: [CUDA] Propagate detected version of CUDA to cc1

tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: bixia, sanjoy. ..and use it to control that parts of CUDA compilation that depend on the specific version of CUDA SDK. This patch has a placeholder for a 'new launch API' support which is in a separate patch (I'll

[PATCH] D57487: [CUDA] Propagate detected version of CUDA to cc1

jlebar accepted this revision. jlebar added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/Cuda.h:108 +enum class CudaFeature { + CUDA_USES_NEW_LAUNCH, +}; Should this enum be documented?

[PATCH] D57487: [CUDA] Propagate detected version of CUDA to cc1

tra updated this revision to Diff 184412. tra added a comment. Updated the comment about SDKVersion use. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57487/new/ https://reviews.llvm.org/D57487 Files: clang/include/clang/Basic/Cuda.h clang/include/clang/Basic/TargetOptions.h

[PATCH] D57487: [CUDA] Propagate detected version of CUDA to cc1

tra updated this revision to Diff 184416. tra added a comment. Addressed Justin's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57487/new/ https://reviews.llvm.org/D57487 Files: clang/include/clang/Basic/Cuda.h clang/include/clang/Basic/TargetOptions.h

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 184437. Dosi-Dough added a comment. based on feedback: fixed whitespacing / formatting. Removed .DS_Store Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files:

[PATCH] D56581: [ASTImporter] Set the described template if not set

shafik added a comment. @martong have you had a chance to look at this some more? We ran into another problem that this fixes partially. Can I help in any way? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56581/new/ https://reviews.llvm.org/D56581

r352690 - [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

Author: yln Date: Wed Jan 30 15:42:13 2019 New Revision: 352690 URL: http://llvm.org/viewvc/llvm-project?rev=352690=rev Log: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls Summary: UBSan wants to detect when unreachable code is actually reached, so it

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan updated this revision to Diff 184439. leonardchan marked 15 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51329/new/ https://reviews.llvm.org/D51329 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan added inline comments. Comment at: clang/lib/AST/Type.cpp:382-386 +QualType QualType::IgnoreMacroDefinitions(QualType T) { + while (const auto *MDT = T->getAs()) +T = MDT->getUnderlyingType(); + return T; +} rsmith wrote: > This doesn't seem

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

tra added a comment. > I would be ok with reusing that option, as long as it's documented that there > is a difference in terms of how it can be used. The patch is in https://reviews.llvm.org/D57487 It does not look like we're formally documenting CC1 options anywhere. I've added some comments

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

craig.topper updated this revision to Diff 184447. craig.topper added a comment. Pass FunctionType into the IRBuilder::CreateCallBr to avoid needing to make an opaque pointer update later CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files:

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver added a comment. Gentle ping. Need someone to land this on my behalf, as I do not have commit access. Many thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56935/new/ https://reviews.llvm.org/D56935 ___ cfe-commits mailing

[PATCH] D57488: [CUDA] add support for the new kernel launch API in CUDA-9.2+.

tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: bixia, sanjoy. Instead of calling CUDA runtime to arrange function arguments, the new API constructs arguments in a local array and the kernels are launched with __cudaLaunchKernel(). The old API has been

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

craig.topper commandeered this revision. craig.topper edited reviewers, added: jyu2; removed: craig.topper. craig.topper added a comment. Commandeering so I can update to match an IRBuilder interface change in the llvm patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/

r352729 - [CMake] Unify scripts for generating VCS headers

Author: phosek Date: Wed Jan 30 22:21:01 2019 New Revision: 352729 URL: http://llvm.org/viewvc/llvm-project?rev=352729=rev Log: [CMake] Unify scripts for generating VCS headers Previously, there were two different scripts for generating VCS headers: one used by LLVM and one used by Clang. They

r352622 - [clang-format] Fix line parsing for noexcept lambdas

Author: benhamilton Date: Wed Jan 30 05:54:32 2019 New Revision: 352622 URL: http://llvm.org/viewvc/llvm-project?rev=352622=rev Log: [clang-format] Fix line parsing for noexcept lambdas Summary: > $ echo "int c = [b]() mutable noexcept { return [] { return b++; }(); }();" > |clang-format ```

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Stmt.h:1259 + // the index of the last one. + unsigned getLastNonNullStmt() const { +assert(!body_empty() && "getLastNonNullStmt"); How about `getIndexOfLastNonNullStmt()` since it

[PATCH] D56909: [clang-format] Fix line parsing for noexcept lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rL352622: [clang-format] Fix line parsing for noexcept lambdas (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D56909?vs=182514=184281#toc Repository: rL

[PATCH] D56909: [clang-format] Fix line parsing for noexcept lambdas

benhamilton added a comment. Herald added a subscriber: llvm-commits. So sorry for the delay. I've landed this diff as rC352622 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56909/new/ https://reviews.llvm.org/D56909

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

aaron.ballman added inline comments. Comment at: lib/AST/Expr.cpp:2562 +static Expr *IgnoreImpCastsSingleStep(Expr *E) { + if (auto *ICE = dyn_cast_or_null(E)) +return ICE->getSubExpr(); riccibruno wrote: > aaron.ballman wrote: > > Do we really need to

[clang-tools-extra] r352624 - [clangd] Drop fixes if replying with tweaks resulted in an error

Author: ibiryukov Date: Wed Jan 30 06:24:17 2019 New Revision: 352624 URL: http://llvm.org/viewvc/llvm-project?rev=352624=rev Log: [clangd] Drop fixes if replying with tweaks resulted in an error This should not happen in normal operation, as it implies that the diagnostics with some available

<    1   2