[libunwind] r353208 - [CMake] Support compiler-rt builtins library in tests

Author: phosek Date: Tue Feb 5 11:50:47 2019 New Revision: 353208 URL: http://llvm.org/viewvc/llvm-project?rev=353208=rev Log: [CMake] Support compiler-rt builtins library in tests We're building tests with -nostdlib which means that we need to explicitly include the builtins library. When

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay added inline comments. Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:228-236 +static bool isStringLiteral(const Expr *Arg) { + const auto *Cast = dyn_cast(Arg); + return Cast ? isa(Cast->getSubExpr()) : false; +} + +static bool isNullPtrLiteral(const

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay updated this revision to Diff 185385. MyDeveloperDay marked 6 inline comments as done. MyDeveloperDay added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57674/new/ https://reviews.llvm.org/D57674 Files:

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:257 Ctx->getLangOpts()); }; @aaron.ballman, slight aside (and not in the

r353219 - Fix a missing word in comment

Author: adrian Date: Tue Feb 5 13:21:01 2019 New Revision: 353219 URL: http://llvm.org/viewvc/llvm-project?rev=353219=rev Log: Fix a missing word in comment Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL:

[PATCH] D57771: [CUDA] Add basic support for CUDA-10.1

jlebar accepted this revision. jlebar added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:620 + +// CUDA version requires calling __cudaRegisterFatBinaryEnd(Handle); +if

[PATCH] D57230: [analyzer] Toning down invalidation a bit

NoQ added a comment. Herald added a project: LLVM. Hmm. `writes_to_superobject`? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57230/new/ https://reviews.llvm.org/D57230 ___ cfe-commits mailing list

[PATCH] D56925: Do not use frame pointer by default for MSP430

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. Herald added a project: clang. Ok now Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56925/new/ https://reviews.llvm.org/D56925

r353214 - [DOCS]Support for emission of the debug info for the Cuda devices, NFC.

Author: abataev Date: Tue Feb 5 12:38:36 2019 New Revision: 353214 URL: http://llvm.org/viewvc/llvm-project?rev=353214=rev Log: [DOCS]Support for emission of the debug info for the Cuda devices, NFC. Modified: cfe/trunk/docs/OpenMPSupport.rst cfe/trunk/docs/ReleaseNotes.rst Modified:

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

steveire accepted this revision. steveire added a comment. Sorry, this fell off my radar :). LGTM too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56850/new/ https://reviews.llvm.org/D56850 ___ cfe-commits mailing list

r353212 - Do not use frame pointer by default for MSP430

Author: asl Date: Tue Feb 5 12:15:03 2019 New Revision: 353212 URL: http://llvm.org/viewvc/llvm-project?rev=353212=rev Log: Do not use frame pointer by default for MSP430 This is suggested by 3.3.9 of MSP430 EABI document. We do allow user to manually enable frame pointer. GCC toolchain uses

r353199 - [opaque pointer types] More trivial changes to pass FunctionType to CallInst.

Author: jyknight Date: Tue Feb 5 11:17:50 2019 New Revision: 353199 URL: http://llvm.org/viewvc/llvm-project?rev=353199=rev Log: [opaque pointer types] More trivial changes to pass FunctionType to CallInst. Change various functions to use FunctionCallee or Function*. Pass function type through

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:228-236 +static bool isStringLiteral(const Expr *Arg) { + const auto *Cast = dyn_cast(Arg); + return Cast ? isa(Cast->getSubExpr()) : false; +} + +static bool isNullPtrLiteral(const

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 marked 2 inline comments as done. jyu2 added inline comments. Comment at: lib/AST/Stmt.cpp:457-460 this->NumOutputs = NumOutputs; this->NumInputs = NumInputs; this->NumClobbers = NumClobbers; + this->NumLabels = NumLabels; rsmith wrote: > jyu2

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

tra added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:4621-4638 +auto CUDATarget = IdentifyCUDATarget(FD); +if (CUDATarget == CFT_HostDevice) { + A = TI.checkCallingConvention(CC); + if (A == TargetInfo::CCCR_OK && Aux) +A =

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

keryell accepted this revision. keryell added a comment. This revision is now accepted and ready to land. That looks good. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57768/new/ https://reviews.llvm.org/D57768

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

aaron.ballman added inline comments. Comment at: lib/AST/Expr.cpp:2562 +return ICE->getSubExpr(); + + else if (auto *FE = dyn_cast_or_null(E)) riccibruno wrote: > It is something that is actually possible to audit. I did look at where each > of the skipped

[PATCH] D57771: [CUDA] Add basic support for CUDA-10.1

tra updated this revision to Diff 185353. tra added a comment. Make the function object local. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57771/new/ https://reviews.llvm.org/D57771 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/CodeGen/CGCUDANV.cpp

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman wrote: > > > > On Fri, Feb 1, 2019 at 2:31 PM Aaron Ballman wrote: >> >> On Fri, Feb 1, 2019 at 5:25 PM Dan Gohman via cfe-commits >> wrote: >> > >> > Author: djg >> > Date: Fri Feb 1 14:25:23 2019 >> > New Revision: 352930 >> > >> > URL:

Re: [PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

What sort of outputs, specifically? Memory outputs are easy; I think the LLVM IR patch actually supports them already. Register outputs are complicated... I guess they're also possible, but we would need to come up with some frontend rule that allows sane code generation. Consider the case

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 185360. jyu2 added a comment. 1>emit better error for use of output constraints. 2> Add assert for NumLabels and NumOutputs are both larger than 0. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files:

r353204 - [DEBUG_INFO][NVPTX] Generate correct data about variable address class.

Author: abataev Date: Tue Feb 5 11:45:57 2019 New Revision: 353204 URL: http://llvm.org/viewvc/llvm-project?rev=353204=rev Log: [DEBUG_INFO][NVPTX] Generate correct data about variable address class. Summary: Added ability to generate correct debug info data about the variable address class.

[PATCH] D57162: [DEBUG_INFO][NVPTX] Generate correct data about variable address class.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353204: [DEBUG_INFO][NVPTX] Generate correct data about variable address class. (authored by ABataev, committed by ). Changed prior to commit: https://reviews.llvm.org/D57162?vs=183325=185364#toc

[PATCH] D56925: Do not use frame pointer by default for MSP430

This revision was automatically updated to reflect the committed changes. Closed by commit rL353212: Do not use frame pointer by default for MSP430 (authored by asl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

yaxunl updated this revision to Diff 185375. yaxunl retitled this revision from "Let AMDGPU compile MSVC headers containing vectorcall" to "[CUDA][HIP] Check calling convention based on function target". yaxunl edited the summary of this revision. yaxunl added a reviewer: tra. yaxunl added a

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

lhames accepted this revision. lhames added a comment. This revision is now accepted and ready to land. Looks like this was LGTM'd but never applied. Stephen -- do you have commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36806/new/ https://reviews.llvm.org/D36806

[PATCH] D57771: [CUDA] Add basic support for CUDA-10.1

tra updated this revision to Diff 185398. tra added a comment. Made a comment more readable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57771/new/ https://reviews.llvm.org/D57771 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/CodeGen/CGCUDANV.cpp

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: lib/AST/Expr.cpp:2562 +return ICE->getSubExpr(); + + else if (auto *FE = dyn_cast_or_null(E)) aaron.ballman wrote: > riccibruno wrote: > > It is something that is

r353229 - [analyzer] Document RetainCountChecker behavior and annotations

Author: george.karpenkov Date: Tue Feb 5 14:27:10 2019 New Revision: 353229 URL: http://llvm.org/viewvc/llvm-project?rev=353229=rev Log: [analyzer] Document RetainCountChecker behavior and annotations Differential Revision: https://reviews.llvm.org/D57721 Modified:

r353227 - [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX method calls

Author: george.karpenkov Date: Tue Feb 5 14:26:44 2019 New Revision: 353227 URL: http://llvm.org/viewvc/llvm-project?rev=353227=rev Log: [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX method calls Differential Revision: https://reviews.llvm.org/D57782 Modified:

[PATCH] D57782: [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX method calls

This revision was automatically updated to reflect the committed changes. george.karpenkov marked an inline comment as done. Closed by commit rC353227: [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX… (authored by george.karpenkov, committed by ). Herald added a

r353228 - [analyzer] [testing] Inside CmpRuns.py output also print the filename of the first item in the path

Author: george.karpenkov Date: Tue Feb 5 14:26:57 2019 New Revision: 353228 URL: http://llvm.org/viewvc/llvm-project?rev=353228=rev Log: [analyzer] [testing] Inside CmpRuns.py output also print the filename of the first item in the path Differential Revision: https://reviews.llvm.org/D57783

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

jrtc27 requested changes to this revision. jrtc27 added a comment. This revision now requires changes to proceed. Please update `docs/ClangCommandLineReference.rst`. Also, in my limited testing, GCC just seems to pass the `-msmall-data-limit=...` flag straight through to the linker through

[PATCH] D57794: Fix MSVC constructor call extension after b92d290e48e9 (r353181).

This revision was automatically updated to reflect the committed changes. Closed by commit rL353246: Fix MSVC constructor call extension after b92d290e48e9 (r353181). (authored by jyknight, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D57797: Variable auto-init: fix __block initialization

jfb created this revision. jfb added reviewers: rjmccall, pcc, kcc. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. Automatic initialization [1] of __block variables was happening too late, which caused self-init usage to crash, such as here: typedef

[PATCH] D57798: [WebAssembly] Add atomics target option

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D57798 Files: include/clang/Driver/Options.td

[PATCH] D57771: [CUDA] Add basic support for CUDA-10.1

This revision was automatically updated to reflect the committed changes. Closed by commit rL353232: Basic CUDA-10 support. (authored by tra, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r353232 - Basic CUDA-10 support.

Author: tra Date: Tue Feb 5 14:38:58 2019 New Revision: 353232 URL: http://llvm.org/viewvc/llvm-project?rev=353232=rev Log: Basic CUDA-10 support. Differential Revision: https://reviews.llvm.org/D57771 Modified: cfe/trunk/include/clang/Basic/Cuda.h cfe/trunk/lib/Basic/Cuda.cpp

[PATCH] D57795: [RISCV] Add FreeBSD targets

jrtc27 created this revision. jrtc27 added a reviewer: asb. Herald added subscribers: cfe-commits, rkruppe, rogfer01, shiva0217, kito-cheng, emaste. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D57795 Files: lib/Basic/Targets.cpp

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

srhines added a comment. In D36806#1385936 , @lhames wrote: > Looks like this was LGTM'd but never applied. Stephen -- do you have commit > access? Yeah, I was waiting on someone with approval for this area of the code to comment and then lost track

r353231 - [Preprocessor] Add a note with framework location for "file not found" error.

Author: vsapsai Date: Tue Feb 5 14:34:55 2019 New Revision: 353231 URL: http://llvm.org/viewvc/llvm-project?rev=353231=rev Log: [Preprocessor] Add a note with framework location for "file not found" error. When a framework with the same name is available at multiple framework search paths, we

[PATCH] D56561: [Preprocessor] For missing file in framework add note about framework location.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353231: [Preprocessor] Add a note with framework location for file not found error. (authored by vsapsai, committed by ). Herald added a project: clang. Changed prior to commit:

r353240 - [modules] Fix handling of initializers for templated global variables.

Author: rsmith Date: Tue Feb 5 15:37:13 2019 New Revision: 353240 URL: http://llvm.org/viewvc/llvm-project?rev=353240=rev Log: [modules] Fix handling of initializers for templated global variables. For global variables with unordered initialization that are instantiated within a module, we

[PATCH] D55659: [Sema][ObjC] Disallow non-trivial C struct fields in unions

ahatanak planned changes to this revision. ahatanak added a comment. This patch is unnecessarily complicated and is not correct. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55659/new/ https://reviews.llvm.org/D55659

[PATCH] D57766: [opaque pointer types] Cleanup CGBuilder's Create*GEP.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Cool :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57766/new/ https://reviews.llvm.org/D57766

[PATCH] D57767: [opaque pointer types] Cleanup CGBuilder's Create*GEP.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57767/new/ https://reviews.llvm.org/D57767

[PATCH] D57798: [WebAssembly] Add atomics target option

tlively added inline comments. Comment at: lib/Basic/Targets/WebAssembly.cpp:172 +} +if (Feature == "0atomics") { + HasAtomics = false; -atomics Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57798/new/

[PATCH] D57798: [WebAssembly] Add atomics target option

aheejin updated this revision to Diff 185454. aheejin added a comment. - Fix typo Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57798/new/ https://reviews.llvm.org/D57798 Files: include/clang/Driver/Options.td lib/Basic/Targets/WebAssembly.cpp

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri created this revision. lebedev.ri added reviewers: JonasToth, aaron.ballman. lebedev.ri added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Herald added a project: clang. The check should ignore the main function, the program entry point. It is not possible to use

[PATCH] D57794: Fix MSVC constructor call extension after b92d290e48e9 (r353181).

jyknight created this revision. jyknight added reviewers: thakis, rsmith. Herald added subscribers: cfe-commits, mstorsjo. Herald added a project: clang. The assert added to EmitCall there was triggering in Windows Chromium builds, due to a mismatch of the return type. The MSVC constructor call

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

apazos added a comment. So Eli is concerned we might end up with many globals in the small data section or not picking the best candidates if we pass -G to all files in LTO. I don’t know if anyone has experimented with a heuristic to selectively pick which globals and of which size will be

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

ahatanak marked 2 inline comments as done. ahatanak added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2953 + "have bases of non-trivial class types|have virtual bases|" + "have __weak fields under ARC|have fields of non-trivial class types}0">;

[PATCH] D57794: Fix MSVC constructor call extension after b92d290e48e9 (r353181).

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57794/new/ https://reviews.llvm.org/D57794 ___

r353246 - Fix MSVC constructor call extension after b92d290e48e9 (r353181).

Author: jyknight Date: Tue Feb 5 16:06:03 2019 New Revision: 353246 URL: http://llvm.org/viewvc/llvm-project?rev=353246=rev Log: Fix MSVC constructor call extension after b92d290e48e9 (r353181). The assert added to EmitCall there was triggering in Windows Chromium builds, due to a mismatch of

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

rsmith added inline comments. Comment at: lib/AST/Stmt.cpp:457-458 + this->NumLabels = NumLabels; + assert((NumLabels != 0 && NumOutputs == 0) || + (NumOutputs != 0 && NumLabels == 0)); This can be simplified a little: ``` assert(!(NumOutputs &&

[PATCH] D57798: [WebAssembly] Add atomics target option

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Basic/Targets/WebAssembly.cpp:172 +} +if (Feature == "0atomics") { + HasAtomics = false; tlively wrote: > -atomics You

r353260 - [WebAssembly] Add atomics target option

Author: aheejin Date: Tue Feb 5 17:41:26 2019 New Revision: 353260 URL: http://llvm.org/viewvc/llvm-project?rev=353260=rev Log: [WebAssembly] Add atomics target option Reviewers: tlively Subscribers: dschuff, sbc100, jgravelle-google, sunfish, jfb, cfe-commits Tags: #clang Differential

[PATCH] D57798: [WebAssembly] Add atomics target option

This revision was automatically updated to reflect the committed changes. Closed by commit rL353260: [WebAssembly] Add atomics target option (authored by aheejin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D57801: [opaque pointer types] Pass through function types for TLS initialization and global destructor calls.

jyknight created this revision. jyknight added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D57801 Files: clang/lib/CodeGen/CGCXX.cpp clang/lib/CodeGen/CGCXXABI.h

[PATCH] D55659: [Sema][ObjC] Disallow non-trivial C struct fields in unions

ahatanak updated this revision to Diff 185466. ahatanak added a comment. Make sure that volatile trivial fields in a struct don't cause Sema to emit a diagnostic. Simplify the code in `Sema::ActOnFields` . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55659/new/

r353268 - [CMake] Unify scripts for generating VCS headers

Author: phosek Date: Tue Feb 5 19:51:00 2019 New Revision: 353268 URL: http://llvm.org/viewvc/llvm-project?rev=353268=rev Log: [CMake] Unify scripts for generating VCS headers Previously, there were two different scripts for generating VCS headers: one used by LLVM and one used by Clang and

[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

This revision was automatically updated to reflect the committed changes. Closed by commit rC353268: [CMake] Unify scripts for generating VCS headers (authored by phosek, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D57797: Variable auto-init: fix __block initialization

rjmccall added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1611 drillIntoBlockVariable(*this, Dst, ); +} defaultInitNonTrivialCStructVar(Dst); Why don't you just initialize the payload right here, after we've drilled down to it?

[PATCH] D57797: Variable auto-init: fix __block initialization

rjmccall added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1611 drillIntoBlockVariable(*this, Dst, ); +} defaultInitNonTrivialCStructVar(Dst); rjmccall wrote: > Why don't you just initialize the payload right here, after we've drilled >

[PATCH] D57798: [WebAssembly] Add atomics target option

sbc100 added a comment. How does this relate to the existing ` -mattr=+atomics` of llc? Will it also result in `attributes #0 = { "target-features"="+atomics" }` in the bitcode? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57798/new/

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 added inline comments. Comment at: lib/AST/Stmt.cpp:457-458 + this->NumLabels = NumLabels; + assert((NumLabels != 0 && NumOutputs == 0) || + (NumOutputs != 0 && NumLabels == 0)); rsmith wrote: > This can be simplified a little: > ``` >

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits updated this revision to Diff 185487. jhibbits added a comment. Herald added a project: clang. Add feedback from @vit9696, and VAARG fix from @kthomsen. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754/new/ https://reviews.llvm.org/D49754 Files:

[PATCH] D57798: [WebAssembly] Add atomics target option

aheejin added a comment. In D57798#1386470 , @sbc100 wrote: > How does this relate to the existing ` -mattr=+atomics` of llc? Will it also > result in `attributes #0 = { "target-features"="+atomics" }` in the bitcode? Yes Repository: rL LLVM

[PATCH] D57804: [opaque pointer types] Make EmitCall pass Function Types to CreateCall/Invoke.

jyknight created this revision. jyknight added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also, remove the getFunctionType() function from CGCallee, since it accesses the pointee type of the value. The only use was in EmitCall, so just inline it

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 185477. jyu2 marked 4 inline comments as done. jyu2 added a comment. More change from review. Add scope checking for asm-goto. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Stmt.h

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 185489. jyu2 added a comment. small fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Stmt.h include/clang/Basic/DiagnosticASTKinds.td

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Tue, Feb 5, 2019 at 11:20 AM Aaron Ballman wrote: > On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman wrote: > > > > > > Indeed, and the existing import_module attribute needs these tests as > well. I'll write some and add them in a follow-up patch. > > > > Thanks for the review! > > Any time! I

[PATCH] D57464: Generalize method overloading on addr spaces to C++

rjmccall added a comment. Moving parsed attributes between lists isn't unreasonable if that's what you have to do; we already do that when processing the ObjC ARC qualifiers. The ambiguity with function attributes is pretty much inherent. Alternatively, you shouldn't feel like you can't

[PATCH] D57746: [clangd] Add CLI flag "-clang-tidy" to enable/disable running clang-tidy checks.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/tool/ClangdMain.cpp:214 +llvm::cl::desc("Enable clang-tidy diagnostics."), +llvm::cl::init(true)); + I thought we

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri updated this revision to Diff 185492. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. Address review notes, adjust docs. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57787/new/ https://reviews.llvm.org/D57787

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

JonasToth added inline comments. Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:35 + const clang::DeclContext *DC = Node.getDeclContext(); + const clang::FunctionDecl *FD = llvm::dyn_cast(DC); + if (!FD) There is `FunctionDecl->castToDeclContext()`

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 updated this revision to Diff 185491. shiva0217 added a comment. 1. Remove passing path for LTO because Eli raised the concern that whether it would appropriate to assign the same limitation for all files when LTO enabled. 2. Add -msmall-data-limitation= as James pointed out it's the

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri added inline comments. Comment at: test/clang-tidy/modernize-avoid-c-arrays.cpp:90 + +int not_main(int argc, char *argv[]) { + // CHECK-MESSAGES: :[[@LINE-1]]:24: warning: do not declare C-style arrays, use std::array<> instead JonasToth wrote: >

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri added inline comments. Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:35 + const clang::DeclContext *DC = Node.getDeclContext(); + const clang::FunctionDecl *FD = llvm::dyn_cast(DC); + if (!FD) JonasToth wrote: > There is

Re: [PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

Note that kernel developers are requesting output support with ASM goto. Doesn't need to be in V1 of ASM go-to support, but we should expect it to be implemented in the future. We should help users with diagnostics that this is not supported, and add asserts that will help us implement such a

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

Szelethus added inline comments. Comment at: docs/analyzer/checkers.rst:1946 +Checkers used for debugging the analyzer. +:doc:`DebugChecks` page contains a detailed description. + NoQ wrote: > The error is on this line. It might be that this link should mention

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clangd/ClangdServer.cpp:366 + auto Style = getFormatStyle(Code, File); + if (!Style) +return; not sure the err-handling strategy here -- maybe if this is failed, we still

[PATCH] D57739: [clangd] Format tweak's replacements.

ilya-biryukov added a comment. Could we move the code to the `Tweak` itself, so that all the callers would get the formatting? I.e. class Tweak { Replacements apply() { // This is now non-virtual. auto Replacements = doApply(); return cleanupAndFormat(Replacements); }

[PATCH] D57739: [clangd] Format tweak's replacements.

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.cpp:366 + auto Style = getFormatStyle(Code, File); + if (!Style) +return; ioeric wrote: > hokein wrote: > > not sure the err-handling strategy here -- maybe if this is failed, we > >

[PATCH] D57581: Explicitly add language standard option to test cases that rely on the C++14 default

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57581/new/ https://reviews.llvm.org/D57581 ___

[PATCH] D57732: Correct inf typo

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57732/new/ https://reviews.llvm.org/D57732

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57739 Files: clangd/ClangdLSPServer.cpp

[PATCH] D57740: [ASTImporter] Import every Decl in lambda record

gamesh411 created this revision. gamesh411 added reviewers: a.sidorin, shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously only the fields were imported. Now every Decl is imported. This way the destructor decl is not missing after import. Patch by balazske

[PATCH] D57524: Fix ICE on attempt to add an addr space qual to a type qualified by an addr space

This revision was automatically updated to reflect the committed changes. Closed by commit rC353160: Fix ICE on reference binding with mismatching addr spaces. (authored by stulova, committed by ). Herald added a project: clang. Changed prior to commit:

[PATCH] D57464: Generalize method overloading on addr spaces to C++

ebevhan added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:2313 +} + } Anastasia wrote: > ebevhan wrote: > > Anastasia wrote: > > > ebevhan wrote: > > > > Anastasia wrote: > > > > > Anastasia wrote: > > > > > > ebevhan wrote: > > > > > > > Is

r353160 - Fix ICE on reference binding with mismatching addr spaces.

Author: stulova Date: Tue Feb 5 03:32:58 2019 New Revision: 353160 URL: http://llvm.org/viewvc/llvm-project?rev=353160=rev Log: Fix ICE on reference binding with mismatching addr spaces. When we attempt to add an addr space qual to a type already qualified by an addr space ICE is triggered.

r353150 - Fix the sphinx buildbot after D54429

Author: szelethus Date: Tue Feb 5 02:19:39 2019 New Revision: 353150 URL: http://llvm.org/viewvc/llvm-project?rev=353150=rev Log: Fix the sphinx buildbot after D54429 Modified: cfe/trunk/docs/analyzer/checkers.rst Modified: cfe/trunk/docs/analyzer/checkers.rst URL:

[PATCH] D57739: [clangd] Format tweak's replacements.

ioeric added inline comments. Comment at: clangd/ClangdServer.cpp:366 + auto Style = getFormatStyle(Code, File); + if (!Style) +return; hokein wrote: > not sure the err-handling strategy here -- maybe if this is failed, we still > apply replacements

[PATCH] D56003: [RFC] [CFE] Allocatable Global Register Variables for ARM

carwil updated this revision to Diff 185277. carwil added a comment. Removed the complicated frame pointer/ffixed combination errors in favour of an always on warning (in a new group, so it can be silenced). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56003/new/

[PATCH] D57746: [clangd] Add CLI flag "-clang-tidy" to enable/disable running clang-tidy checks.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57746 Files: clangd/tool/ClangdMain.cpp

[PATCH] D57055: [RISCV] Mark TLS as supported

lewis-revill updated this revision to Diff 185283. lewis-revill added a comment. Herald added a project: clang. Added RISC-V to thread specifier test as a means of checking TLS is supported. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57055/new/

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno created this revision. riccibruno added reviewers: aaron.ballman, rsmith. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. The current handling of the operators `||`, `&&` and `?:` has a number of false positive and false negative. The issues for operator

[PATCH] D57464: Generalize method overloading on addr spaces to C++

ebevhan added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:2313 +} + } Anastasia wrote: > ebevhan wrote: > > Anastasia wrote: > > > ebevhan wrote: > > > > Anastasia wrote: > > > > > ebevhan wrote: > > > > > > Anastasia wrote: > > > > > > >

r353163 - [NFC] Explicitly add -std=c++14 option to tests that rely on the C++14 default

Author: nemanjai Date: Tue Feb 5 04:05:53 2019 New Revision: 353163 URL: http://llvm.org/viewvc/llvm-project?rev=353163=rev Log: [NFC] Explicitly add -std=c++14 option to tests that rely on the C++14 default When Clang/LLVM is built with the CLANG_DEFAULT_STD_CXX CMake macro that sets the

r353116 - [OBJC] Add attribute to mark Objective C class as non-lazy

Author: joseph_daniels Date: Mon Feb 4 15:32:55 2019 New Revision: 353116 URL: http://llvm.org/viewvc/llvm-project?rev=353116=rev Log: [OBJC] Add attribute to mark Objective C class as non-lazy A non-lazy class will be initialized eagerly when the Objective-C runtime is loaded. This is required

  1   2   >