[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

This revision was automatically updated to reflect the committed changes. Closed by commit rL354799: Release notes for OpenCL (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58638: [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58638/new/ https://reviews.llvm.org/D58638 ___ cfe-commits

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. In D50488#1407884 , @Szelethus wrote: > In D50488#1405094 , @mgrang wrote: > > > So I was able compile a couple of C++ code bases through csa-testbench. I > > built cppcheck and tinyxml2

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang marked an inline comment as done. mgrang added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:97 +def NonDeterminismAlpha : Package<"nondeterminism">, ParentPackage; + Szelethus wrote: > Hmmm, okay, so your checker ks C++

[PATCH] D58091: Customize warnings for missing built-in type

bcain added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:592 +: Warning<"declaration of built-in function '%0' requires the declaration" +" of the 'jmp_buf' type, commonly proived in the header .">, + InGroup>;

[PATCH] D56933: [Tooling][RFC] Introduce Stencil library to simplify source code generation in refactorings.

lebedev.ri added subscribers: ilya-biryukov, gribozavr, lebedev.ri. lebedev.ri added a comment. See also: https://lists.llvm.org/pipermail/cfe-dev/2019-February/061414.html How are these two RFC's/API's supposed to interact/coexist/etc? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

Re: r354795 - Make static counters in ASTContext non-static.

I've reverted this commit in r354812, it was causing MSan failures like http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/29886/steps/check-clang%20msan/logs/stdio Though these error reports don't clearly implicate this change, from your change it seems like the failure is

[PATCH] D58570: [libclang] Expose warn_unused and warn_unused_result attributes.

This revision was automatically updated to reflect the committed changes. Closed by commit rC354824: [libclang] Expose warn_unused and warn_unused_result attributes. (authored by emilio, committed by ). Herald added a reviewer: serge-sans-paille. Changed prior to commit:

r354824 - [libclang] Expose warn_unused and warn_unused_result attributes.

Author: emilio Date: Mon Feb 25 13:24:52 2019 New Revision: 354824 URL: http://llvm.org/viewvc/llvm-project?rev=354824=rev Log: [libclang] Expose warn_unused and warn_unused_result attributes. This is helpful to properly detect them, and fixing issues like

[PATCH] D58634: [PR40778] Generate address space conversion when binding reference to a temporary value in different address space

Anastasia created this revision. Anastasia added reviewers: rjmccall, ebevhan. This is fixing one of the issues reported in the bug: https://bugs.llvm.org/show_bug.cgi?id=40778 https://reviews.llvm.org/D58634 Files: lib/CodeGen/CGCall.cpp test/CodeGenOpenCLCXX/addrspace-references.cl

[PATCH] D58634: [PR40778] Generate address space conversion when binding reference to a temporary value in different address space

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/CodeGen/CGCall.cpp:4067 + IRFuncTy->getParamType(FirstIRArg)->isPointerTy()) +V = Builder.CreatePointerBitCastOrAddrSpaceCast( +V,

[PATCH] D58569: [libclang] Avoid crashing when getting layout info of an undeduced type.

Anastasia added inline comments. Comment at: clang/tools/c-index-test/c-index-test.c:1695 +CXType RT = clang_getResultType(T); +if (RT.kind != CXType_Invalid) + PrintSingleTypeSize(RT, " [resulttype=%s] [resulttypekind=%s]", emilio wrote: >

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

ilya-biryukov updated this revision to Diff 188226. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58541/new/ https://reviews.llvm.org/D58541 Files:

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:494 default: assert(false && "unhnalded unary op"); return QualType(); xbolva00 wrote: > Typo? Fixed it. Thanks. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang updated this revision to Diff 188232. mgrang set the repository for this revision to rC Clang. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50488/new/ https://reviews.llvm.org/D50488 Files: docs/analyzer/checkers.rst

[PATCH] D58638: [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier

lildmh created this revision. lildmh added reviewers: ABataev, hfinkel, Meinersbur, kkwli0. lildmh added a project: OpenMP. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. This patch implements the parsing and sema support for OpenMP from clause with

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

mgrang added a comment. In D50488#1407975 , @Szelethus wrote: > But, as a work-in-progress alpha checker, the direction is set and looks > great. Please let @NoQ have the final say. Thanks a lot @Szelethus! I will wait for @NoQ 's comments.

r354823 - [libclang] Fix a trivial error introduced in D57946.

Author: emilio Date: Mon Feb 25 13:15:34 2019 New Revision: 354823 URL: http://llvm.org/viewvc/llvm-project?rev=354823=rev Log: [libclang] Fix a trivial error introduced in D57946. The value for CXCursor_ConvergentAttr is not 420. I'm not really sure how easy it is to test this, and I'm not

[PATCH] D58571: [libclang] Fix a trivial error introduced in D57946.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354823: [libclang] Fix a trivial error introduced in D57946. (authored by emilio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D57892: [analyzer] Fix macro printer crash when macro comes from another translation unit

Szelethus added a comment. Whoops, incorrect commit title and description. Anyways, the committed code and the revision number is OK... Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57892/new/ https://reviews.llvm.org/D57892

[PATCH] D58638: [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL354817: [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier. (authored by Meinersbur, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. In D56924#1407836 , @arphaman wrote: > Please add a test that covers the '(class extension)' output as well. Removed the `(class extension)` output as the property getter if statement should now handle this. Repository: rC

[PATCH] D58556: [LibTooling] Add "smart" retrieval of AST-node source to FixIt library

ilya-biryukov added a comment. Thanks, the APIs totally make sense. And seem to fit into the other functions we have in `FixIt.h`, although the name of the file is somewhat misleading. Mostly comments about naming and one comment about the necessity of using matchers from my side.

r354812 - Revert "Make static counters in ASTContext non-static."

Author: vlad.tsyrklevich Date: Mon Feb 25 11:53:13 2019 New Revision: 354812 URL: http://llvm.org/viewvc/llvm-project?rev=354812=rev Log: Revert "Make static counters in ASTContext non-static." This reverts commit r354795, I suspect it is causing test failures on MSan sanitizer bots. Modified:

Re: [PATCH] D56933: [Tooling][RFC] Introduce Stencil library to simplify source code generation in refactorings.

We're working out the details, but the intent is that the Tree-transformation library would support the implementation of Transformer. That is, this library is targeted at a lower-level/more advanced user than Transformer. Currently, Transformer is implemented directly on the clang AST API, but

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman updated this revision to Diff 188213. dgoldman added a comment. - Remove (class extension) as it's no longer needed Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 188224. tmroeder added a comment. Changed to use llvm::find. Given the disagreement about the destructuring assignment, I didn't make that change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

ilya-biryukov updated this revision to Diff 188225. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. - Check in the middle and at the end of identifiers. - Add a test for the second parameter and a class member function Repository: rG LLVM Github Monorepo

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

ilya-biryukov added inline comments. Comment at: clang/include/clang/Sema/Sema.h:294 + /// function_ref, clients should make sure all calls to get() with the same + /// location happen while function_ref is alive. + void enterFunctionArgument(SourceLocation Tok,

[PATCH] D58091: Customize warnings for missing built-in type

jdoerfert added a comment. I did address the comments but I will wait until I hear back on the "warning vs warning + note question". In D58091#1397586 , @jyknight wrote: > I think this warning (-Wbuiltin-requires-header) doesn't really make sense as >

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

efriedma added a subscriber: hfinkel. efriedma added a comment. Chandler, when you have a chance, can you look at the LangRef changes, since you put some thought into the design? I think the DataLayout/LangRef changes look correct. I agree it isn't necessary to fix every target in the initial

[PATCH] D58091: Customize warnings for missing built-in type

jdoerfert updated this revision to Diff 188238. jdoerfert marked 3 inline comments as done. jdoerfert added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58091/new/ https://reviews.llvm.org/D58091 Files:

r354817 - [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier.

Author: meinersbur Date: Mon Feb 25 12:34:15 2019 New Revision: 354817 URL: http://llvm.org/viewvc/llvm-project?rev=354817=rev Log: [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier. This patch implements the parsing and sema support for the OpenMP 'from'-clause with

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

Anastasia added a comment. Committed to the release branch r354799. FYI, I did a couple of formatting changes and typo fixes. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58504/new/ https://reviews.llvm.org/D58504

r354806 - [analyzer] Fix infinite recursion in printing macros

Author: szelethus Date: Mon Feb 25 10:49:42 2019 New Revision: 354806 URL: http://llvm.org/viewvc/llvm-project?rev=354806=rev Log: [analyzer] Fix infinite recursion in printing macros #define f(y) x #define x f(x) int main() { x; } This example results a compilation error since "x" in the first

[PATCH] D57892: [analyzer] Fix macro printer crash when macro comes from another translation unit

This revision was automatically updated to reflect the committed changes. Closed by commit rL354806: [analyzer] Fix infinite recursion in printing macros (authored by Szelethus, committed by ). Herald added subscribers: llvm-commits, Charusso. Herald added a project: LLVM. Changed prior to

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

michaelplatings marked 4 inline comments as done. michaelplatings added inline comments. Comment at: llvm/lib/IR/ConstantFold.cpp:1087 + if (GVAlign == 0U && isa(GV)) +GVAlign = 4U; efriedma wrote: > Using "4" as a default is dangerous; on

[PATCH] D58612: Make the static counters in ASTContext non-static

alexfh added a comment. In D58612#1409216 , @riccibruno wrote: > In D58612#1409215 , @alexfh wrote: > > > > In D58612#1409024 , @riccibruno > > > wrote: > > > > > >> ... >

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay updated this revision to Diff 188239. MyDeveloperDay added a subscriber: llvm-commits. MyDeveloperDay added a comment. Fix a crash running clang-format over large C# code base Add support for C# Null Coalescing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58404/new/

[PATCH] D58569: [libclang] Avoid crashing when getting layout info of an undeduced type.

emilio updated this revision to Diff 188254. emilio marked an inline comment as done. emilio added a comment. Add CHECK tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58569/new/ https://reviews.llvm.org/D58569 Files:

[PATCH] D41950: Fix for Bug 8446. Template instantiation without a 'typename' keyword.

rnk added a comment. In D41950#1409332 , @zahiraam wrote: > I don't think I have commit right can you please commit it. Thanks. Sure, done! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41950/new/

[PATCH] D58658: [OpenCL] Fix assertion due to blocks

yaxunl created this revision. yaxunl added a reviewer: Anastasia. Herald added subscribers: kristof.beyls, javed.absar. A recent change caused assertion in CodeGenFunction::EmitBlockCallExpr when a block is called. There is code if (!isa(E->getCalleeDecl())) Func =

[PATCH] D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute.

vsapsai created this revision. vsapsai added reviewers: rsmith, arphaman. Herald added subscribers: jdoerfert, dexonsmith, jkorous. Fixes the assertion > no Attr* for AttributedType* > UNREACHABLE executed at llvm-project/clang/lib/Sema/SemaType.cpp:298! In

r354839 - Revert r354832 "[ASTImporter] Add support for importing ChooseExpr AST nodes."

Author: rnk Date: Mon Feb 25 18:22:22 2019 New Revision: 354839 URL: http://llvm.org/viewvc/llvm-project?rev=354839=rev Log: Revert r354832 "[ASTImporter] Add support for importing ChooseExpr AST nodes." Test does not pass on Windows Removed: cfe/trunk/test/ASTMerge/ Modified:

r354838 - [MS] Fix for Bug 8446, template instantiation without a 'typename' keyword

Author: rnk Date: Mon Feb 25 18:22:17 2019 New Revision: 354838 URL: http://llvm.org/viewvc/llvm-project?rev=354838=rev Log: [MS] Fix for Bug 8446, template instantiation without a 'typename' keyword Patch by Zahira Ammarguellat! Differential Revision: https://reviews.llvm.org/D41950 Added:

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan updated this revision to Diff 188256. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/ https://reviews.llvm.org/D58321 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/VTableBuilder.h

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan added a comment. In D58321#1407362 , @pcc wrote: > Can we start with a patch that just exposes a flag that enables the relative > ABI unconditionally, and remove all the platform ABI compatibility stuff? Done. Removed the checks requiring

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 188262. tmroeder added a comment. Updating after switching to the git monorepo model. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/ https://reviews.llvm.org/D58292 Files:

[PATCH] D58089: Add missing library dependencies in CMakeLists.txt

comex added a comment. Ping. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58089/new/ https://reviews.llvm.org/D58089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58541/new/ https://reviews.llvm.org/D58541

r354826 - [CodeGenObjC] Fix a nullptr dyn_cast

Author: epilk Date: Mon Feb 25 13:35:14 2019 New Revision: 354826 URL: http://llvm.org/viewvc/llvm-project?rev=354826=rev Log: [CodeGenObjC] Fix a nullptr dyn_cast ObjCMessageExpr::getInstanceReceiver returns nullptr if the receiver is 'super'. Make this check more strict, since we don't care

[PATCH] D41950: Fix for Bug 8446. Template instantiation without a 'typename' keyword.

This revision was automatically updated to reflect the committed changes. Closed by commit rC354838: [MS] Fix for Bug 8446, template instantiation without a typename keyword (authored by rnk, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

rnk added a comment. I had to revert this in rL354839 because one of the tests didn't pass on Windows: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/4641 Repository: rL LLVM CHANGES SINCE LAST ACTION

Re: r354795 - Make static counters in ASTContext non-static.

Thank you for taking care of this! That's a bug indeed. Will recommit with a fix. On Mon, Feb 25, 2019 at 9:25 PM Vlad Tsyrklevich wrote: > I've reverted this commit in r354812, it was causing MSan failures like >

r354831 - [NFC] Reorder some mis-ordered tests

Author: jfb Date: Mon Feb 25 15:09:34 2019 New Revision: 354831 URL: http://llvm.org/viewvc/llvm-project?rev=354831=rev Log: [NFC] Reorder some mis-ordered tests I somehow had misaligned some of the tests when I originally wrote this. Re-order them properly. Modified:

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354832: [ASTImporter] Add support for importing ChooseExpr AST nodes. (authored by tmroeder, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D58649: Fix inline assembler constraint validation

joerg created this revision. joerg added a reviewer: compnerd. Herald added a subscriber: eraman. The current constraint logic is both too lax and too strict. It fails for input outside the [INT_MIN..INT_MAX] range, but it also implicitly accepts 0 as value when it should not. Adjust logic to

r354827 - Reapply "Make static counters in ASTContext non-static." with fixes.

Author: alexfh Date: Mon Feb 25 14:22:09 2019 New Revision: 354827 URL: http://llvm.org/viewvc/llvm-project?rev=354827=rev Log: Reapply "Make static counters in ASTContext non-static." with fixes. This reverts commit e50038e4dc53caee1acc811362ac0b15e00ef5eb. Modified:

Re: r354795 - Make static counters in ASTContext non-static.

Done. r354827 should be better. On Mon, Feb 25, 2019 at 11:18 PM Alexander Kornienko wrote: > Thank you for taking care of this! That's a bug indeed. Will recommit with > a fix. > > On Mon, Feb 25, 2019 at 9:25 PM Vlad Tsyrklevich > wrote: > >> I've reverted this commit in r354812, it was

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

hwright added inline comments. Comment at: clang-tidy/abseil/TimeSubtractionCheck.cpp:97 +void TimeSubtractionCheck::check(const MatchFinder::MatchResult ) { + const auto *BinOp = Result.Nodes.getNodeAs("binop"); + std::string inverse_name = JonasToth wrote: >

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

hwright updated this revision to Diff 188289. hwright marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58137/new/ https://reviews.llvm.org/D58137 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt

[PATCH] D58570: [libclang] Expose warn_unused and warn_unused_result attributes.

emilio added a comment. Landed with that change, thanks for the review @anastasia! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58570/new/ https://reviews.llvm.org/D58570 ___ cfe-commits mailing list

[PATCH] D57898: CodeGen: Fix PR40605: split constant structures generated by -ftrivial-auto-var-init when emitting initializators

jfb added a comment. I think (with test updates) this will be good to go once D58188 lands. Comment at: tools/clang/lib/CodeGen/CGDecl.cpp:1158 + llvm::StructType *STy = dyn_cast(Ty); + if (STy && (STy == Loc.getElementType()) && +

[PATCH] D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute.

vsapsai added a comment. Have doubts that checking only the outermost type for being `AttributedType` after `Sema::ReplaceAutoType` is sufficient but haven't found a counterexample yet. Decided to post the proposed fix to see if others have any ideas. CHANGES SINCE LAST ACTION

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

rnk added a comment. Looks good and thorough, but it needs tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58530/new/ https://reviews.llvm.org/D58530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58634: [PR40778] Generate address space conversion when binding reference to a temporary value in different address space

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:4067 + IRFuncTy->getParamType(FirstIRArg)->isPointerTy()) +V = Builder.CreatePointerBitCastOrAddrSpaceCast( +V, IRFuncTy->getParamType(FirstIRArg));

[PATCH] D58569: [libclang] Avoid crashing when getting layout info of an undeduced type.

emilio marked 2 inline comments as done. emilio added a comment. Huh, somehow forgot to press "Submit" this morning :) Comment at: clang/tools/c-index-test/c-index-test.c:1695 +CXType RT = clang_getResultType(T); +if (RT.kind != CXType_Invalid) +

[PATCH] D58321: [WIP] Support for relative vtables

rjmccall added inline comments. Comment at: clang/include/clang/Driver/Options.td:1250 + Group, Flags<[CC1Option]>, + HelpText<"Use the unstable C++ class ABI for classes with hidden LTO visibility">; def flto_jobs_EQ : Joined<["-"], "flto-jobs=">, Please

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. In D56411#1406212 , @yaxunl wrote: > I would like to fix the validation issue only and leave the overload > resolution issue for future. As I understand it, the "validation issue" is just that you'd like a diagnostic to be

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 188307. tmroeder added a comment. Dropped the C++ part of the ImportChooseExpr test entirely. This is the part that was breaking the tests on Windows, and after further experimentation, it turns out that clang on Windows never expands the template under

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

rjmccall added a comment. Okay, one last minor request, then LGTM. Comment at: lib/CodeGen/CGObjC.cpp:2953 + return asImpl().visitExpr(e); +} + Oh, I'd forgotten this wasn't a normal expression visitor. Well, okay, this isn't too bad.

r354832 - [ASTImporter] Add support for importing ChooseExpr AST nodes.

Author: tmroeder Date: Mon Feb 25 15:24:58 2019 New Revision: 354832 URL: http://llvm.org/viewvc/llvm-project?rev=354832=rev Log: [ASTImporter] Add support for importing ChooseExpr AST nodes. Summary: This allows ASTs to be merged when they contain ChooseExpr (the GNU __builtin_choose_expr

r354843 - [CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial

Author: asmith Date: Mon Feb 25 19:49:05 2019 New Revision: 354843 URL: http://llvm.org/viewvc/llvm-project?rev=354843=rev Log: [CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial This goes with https://reviews.llvm.org/D44406 Modified:

[PATCH] D37994: Implement LWG2946: More ambiguity in `string` vs. `string_view`

mclow.lists abandoned this revision. mclow.lists added a comment. Herald added a subscriber: jdoerfert. This appears to have been applied in a slightly different form. Certainly the functionality is there. Closing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37994/new/

[PATCH] D52956: Support `-fno-visibility-inlines-hidden`

smeenai added a comment. I tried committing this for you, but it doesn't apply to master. Could you rebase? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52956/new/ https://reviews.llvm.org/D52956 ___ cfe-commits

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

tmroeder created this revision. tmroeder added reviewers: shafik, a_sidorin, martong, aaron.ballman, rnk. tmroeder added a project: clang. Herald added a reviewer: a.sidorin. This allows ASTs to be merged when they contain ChooseExpr (the GNU __builtin_choose_expr construction). This is needed,

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

courbet updated this revision to Diff 188316. courbet added a comment. - more tests Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58609/new/ https://reviews.llvm.org/D58609 Files: clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp

[PATCH] D57590: [ASTImporter] Improve import of FileID.

martong added a comment. Herald added a reviewer: martong. Ping. Please raise your objections if you have any until the 4th of March (that date we are going to commit if there are no objections). Also, please let us know if you find this deadline too strict. Repository: rC Clang CHANGES

[PATCH] D58612: Use std::atomic<> for static counters.

alexfh added a comment. > In D58612#1409024 , @riccibruno > wrote: > >> ... >> For example in `DeclBase.cpp` >> >> #define DECL(DERIVED, BASE) static int n##DERIVED##s = 0; >> #define ABSTRACT_DECL(DECL) >> #include "clang/AST/DeclNodes.inc" >> >>

[PATCH] D58612: Use std::atomic<> for static counters.

riccibruno added a comment. In D58612#1409215 , @alexfh wrote: > > In D58612#1409024 , @riccibruno > > wrote: > > > >> ... > >> For example in `DeclBase.cpp` > >> > >> #define DECL(DERIVED, BASE) static int

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro marked an inline comment as done. djtodoro added a comment. > I'm not quite sure what this differential is about, but i feel like > mentioning ExprMutationAnalyzer lib in clang-tidy / clang-tools-extra. >> Alternatively perhaps you could re-use getMemoryLocation() from D57660 >>

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

bjope added subscribers: dyung, bjope. bjope added inline comments. Herald added a subscriber: Charusso. Comment at: clang-tidy/utils/ExceptionAnalyzer.h:112 +/// throw, if it's unknown or if it won't throw. +enum State Behaviour : 2; + (post-commit

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 188110. djtodoro added a comment. Herald added a subscriber: jdoerfert. - Handle all kinds of expressions when mark a param's modification CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files:

[PATCH] D58600: [clangd] Emit source to Diagnostic.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Set "clang", "clang-tidy" as the source to the diagnostics, so that client can distinguish diagnostics from clang-tidy.

[PATCH] D58570: [libclang] Expose warn_unused and warn_unused_result attributes.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Although for consistency we could add this into python bindings too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58570/new/

[PATCH] D58603: Updated the documentation build instructions for the current CMake build system

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58603 Files: clang-tools-extra/docs/README.txt Index: clang-tools-extra/docs/README.txt

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

bjope added a subscriber: sammccall. bjope added a comment. Maybe @sammccall remembers why it was decided to rewrite the enum into constexpr:s in https://reviews.llvm.org/rCTE319608 ? Do we need a similar solution here? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

kadircet added inline comments. Herald added a subscriber: Charusso. Comment at: clang/include/clang/Sema/Sema.h:294 + /// function_ref, clients should make sure all calls to get() with the same + /// location happen while function_ref is alive. + void

[PATCH] D58571: [libclang] Fix a trivial error introduced in D57946.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Charusso. LGTM! Thanks! I guess we are missing a python test? No idea why we are not testing it though... Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:494 default: assert(false && "unhnalded unary op"); return QualType(); Typo? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D58601: Fixed grammar in index.rst

gribozavr created this revision. Herald added a subscriber: arphaman. Herald added a project: clang. gribozavr added a reviewer: ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58601 Files: clang-tools-extra/docs/index.rst Index:

[PATCH] D58602: Removed an unhelpful comment in index.rst

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added subscribers: jdoerfert, arphaman. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58602 Files: clang-tools-extra/docs/index.rst Index:

[PATCH] D58492: [clangd] Add thread priority lowering for MacOS as well

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354765: [clangd] Add thread priority lowering for MacOS as well (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58492?vs=187908=188106#toc Repository:

[clang-tools-extra] r354765 - [clangd] Add thread priority lowering for MacOS as well

Author: kadircet Date: Mon Feb 25 01:19:26 2019 New Revision: 354765 URL: http://llvm.org/viewvc/llvm-project?rev=354765=rev Log: [clangd] Add thread priority lowering for MacOS as well Reviewers: ilya-biryukov Subscribers: ioeric, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang

r354773 - [SYCL] Add clang front-end option to enable SYCL device compilation flow.

Author: bader Date: Mon Feb 25 03:48:48 2019 New Revision: 354773 URL: http://llvm.org/viewvc/llvm-project?rev=354773=rev Log: [SYCL] Add clang front-end option to enable SYCL device compilation flow. Patch by Mariya Podchishchaeva Added: cfe/trunk/test/Preprocessor/sycl-macro.cpp (with

[PATCH] D58602: Removed an unhelpful comment in index.rst

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58602/new/ https://reviews.llvm.org/D58602

[PATCH] D58603: Updated the documentation build instructions for the current CMake build system

ilya-biryukov added inline comments. Comment at: clang-tools-extra/docs/README.txt:5 -Sphinx and doxygen documentation is generated by executing make. +You can generate documentation in HTML format from files in +clang-tools-extra/docs by building the docs-clang-tools-html

[PATCH] D58603: Updated the documentation build instructions for the current CMake build system

gribozavr updated this revision to Diff 188133. gribozavr marked 2 inline comments as done. gribozavr added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58603/new/ https://reviews.llvm.org/D58603 Files:

[PATCH] D58603: Updated the documentation build instructions for the current CMake build system

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/docs/README.txt:6 +You can generate documentation in HTML format from files in +clang-tools-extra/docs by building the docs-clang-tools-html target.

[PATCH] D58602: Removed an unhelpful comment in index.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rL354777: Removed an unhelpful comment in index.rst (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

  1   2   >