[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro added a comment. >> @lebedev.ri I agree, thank you! I needed to be more precise in my previous >> reply, sorry for that. I thought it will be (somehow) overhead if I change >> existing, very basic, matchers. > > I indeed don't think the existing matchers should be changed to ignore

[PATCH] D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890)

This revision was automatically updated to reflect the committed changes. Closed by commit rC355491: Inline asm constraints: allow ICE-like pointers for the n constraint (PR40890) (authored by hans, committed by ). Herald added a project: clang. Changed prior to commit:

[PATCH] D59022: [clangd] Strip plugin arguments in clangd-indexer.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. This would allow clangd-indexer runs on chromium repo. Repository: rCTE Clang Tools Extra

r355491 - Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890)

Author: hans Date: Wed Mar 6 02:26:19 2019 New Revision: 355491 URL: http://llvm.org/viewvc/llvm-project?rev=355491=rev Log: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890) Apparently GCC allows this, and there's code relying on it (see bug). The idea is to

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

lebedev.ri added a comment. Nice, i like this! I think the test coverage is good. But what about other `equalsNode()` that you didn't change? Do some of them need this change too? Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:27 +AST_MATCHER_P(Expr, skipCommaOps, +

[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

gribozavr added a comment. > My understanding is that the storage space taken up for Refs is currently 8 > bytes per Ref (4 each for the start and end positions), plus filename strings > which are deduplicated across all refs. If we add a SymbolID, that adds an > additional 8 bytes to each

[clang-tools-extra] r355493 - [clangd] Add Source to clangd::Diagnostic.

Author: hokein Date: Wed Mar 6 02:51:38 2019 New Revision: 355493 URL: http://llvm.org/viewvc/llvm-project?rev=355493=rev Log: [clangd] Add Source to clangd::Diagnostic. Summary: clangd embedder can distinguish diagnostics from clang or clang-tidy. Reviewers: ilya-biryukov Subscribers:

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro updated this revision to Diff 189461. djtodoro added a comment. -add AST matcher that skips operands in comma expression -add unit tests for extended support CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58894/new/ https://reviews.llvm.org/D58894 Files:

[PATCH] D58600: [clangd] Emit source to Diagnostic.

This revision was automatically updated to reflect the committed changes. Closed by commit rL355493: [clangd] Add Source to clangd::Diagnostic. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:27 +AST_MATCHER_P(Expr, skipCommaOps, + ast_matchers::internal::Matcher, InnerMatcher) { lebedev.ri wrote: > djtodoro

[PATCH] D58634: [PR40778] Generate address space conversion when binding reference to a temporary value in different address space

This revision was automatically updated to reflect the committed changes. Closed by commit rC355499: [PR40778] Add addr space conversion when binding reference to a temporary. (authored by stulova, committed by ). Herald added a project: clang. Changed prior to commit:

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

MaskRay abandoned this revision. MaskRay added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. The DT_GNU_HASH objection is so strong that I think I have to abandon this. I can do nothing but to blame the original sysv hash is so bad (it may be unfair to blame it

r355499 - [PR40778] Add addr space conversion when binding reference to a temporary.

Author: stulova Date: Wed Mar 6 05:02:41 2019 New Revision: 355499 URL: http://llvm.org/viewvc/llvm-project?rev=355499=rev Log: [PR40778] Add addr space conversion when binding reference to a temporary. This change fixes temporary materialization to happen in the right (default) address space

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro marked an inline comment as done. djtodoro added a comment. > Nice, i like this! > I think the test coverage is good. @lebedev.ri Thanks! > But what about other equalsNode() that you didn't change? > Do some of them need this change too? For sure some of them (maybe all of them) needs

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia updated this revision to Diff 189474. Anastasia added a comment. Restructure code with early return. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58346/new/ https://reviews.llvm.org/D58346 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCast.cpp

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

lebedev.ri added inline comments. Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:27 +AST_MATCHER_P(Expr, skipCommaOps, + ast_matchers::internal::Matcher, InnerMatcher) { djtodoro wrote: > lebedev.ri wrote: > > (Can anyone suggest a better name

[PATCH] D58708: [PR40778] Preserve addr space in Derived to Base cast

Anastasia updated this revision to Diff 189470. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58708/new/ https://reviews.llvm.org/D58708 Files: lib/CodeGen/CGClass.cpp lib/Sema/SemaExpr.cpp test/CodeGenOpenCLCXX/addrspace-derived-base.cl Index:

[PATCH] D58708: [PR40778] Preserve addr space in Derived to Base cast

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaExpr.cpp:2671 DestType = Context.getPointerType(DestRecordType); FromRecordType = FromType->getPointeeType(); PointerConversions = true;

[PATCH] D58236: Make address space conversions a bit stricter.

Anastasia added a comment. In D58236#1417429 , @efriedma wrote: > In D58236#1416765 , @Anastasia wrote: > > > In D58236#1414069 , @efriedma > > wrote: > > > > > > I think

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:365 Callback CB) { - auto Action = [Sel](decltype(CB) CB, std::string File, -std::string TweakID, -

r355489 - clang-cl: Parse /Qspectre and a few other missing options (PR40964)

Author: hans Date: Wed Mar 6 01:38:04 2019 New Revision: 355489 URL: http://llvm.org/viewvc/llvm-project?rev=355489=rev Log: clang-cl: Parse /Qspectre and a few other missing options (PR40964) Modified: cfe/trunk/include/clang/Driver/CLCompatOptions.td cfe/trunk/test/Driver/cl-options.c

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

phosek created this revision. phosek added reviewers: smeenai, beanz, jdenny. Herald added subscribers: llvm-commits, libcxx-commits, cfe-commits, jdoerfert, kadircet, christof, ioeric, ilya-biryukov, mgorny. Herald added a reviewer: EricWF. Herald added projects: clang, libc++, LLVM. This

[PATCH] D58600: [clangd] Emit source to Diagnostic.

hokein updated this revision to Diff 189455. hokein added a comment. Don't emit the source to LSP level (as this is a UI change as least in vscode) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58600/new/ https://reviews.llvm.org/D58600 Files:

[PATCH] D58992: [CUDA][HIP][DebugInfo] Skip reference device function

hliao updated this revision to Diff 189488. hliao added a comment. make the test more robust to potential metadata identifier change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58992/new/ https://reviews.llvm.org/D58992 Files:

[PATCH] D52835: [Diagnostics] Check integer to floating point number implicit conversions

aaron.ballman added a comment. In D52835#1412416 , @xbolva00 wrote: > @aaron.ballman does it make sense to warn for this case only in C/pre-C++11 > mode? Since this case in C++11/14/17 is handled by -Wnarrowing, as we see > from tests. I don't think

[PATCH] D58708: [PR40778] Preserve addr space in Derived to Base cast

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58708/new/ https://reviews.llvm.org/D58708 ___ cfe-commits mailing list

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58346/new/ https://reviews.llvm.org/D58346 ___ cfe-commits mailing list

[PATCH] D58996: [Remarks] Refactor remark diagnostic emission in a RemarkStreamer

This revision was automatically updated to reflect the committed changes. Closed by commit rC355507: [Remarks] Refactor remark diagnostic emission in a RemarkStreamer (authored by thegameg, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

r355507 - [Remarks] Refactor remark diagnostic emission in a RemarkStreamer

Author: thegameg Date: Wed Mar 6 06:32:08 2019 New Revision: 355507 URL: http://llvm.org/viewvc/llvm-project?rev=355507=rev Log: [Remarks] Refactor remark diagnostic emission in a RemarkStreamer This allows us to store more info about where we're emitting the remarks without cluttering

[PATCH] D58154: Add support for -fpermissive.

aaron.ballman added a comment. In D58154#1418594 , @jyknight wrote: > The errors disabled by this feature are default-error warnings -- you can > already get the same effect by using -Wno-. Why is it bad to > additionally allow -fpermissive to disable

r355511 - Revert "[Remarks] Refactor remark diagnostic emission in a RemarkStreamer"

Author: thegameg Date: Wed Mar 6 06:52:37 2019 New Revision: 355511 URL: http://llvm.org/viewvc/llvm-project?rev=355511=rev Log: Revert "[Remarks] Refactor remark diagnostic emission in a RemarkStreamer" This reverts commit 2e8c4997a2089f8228c843fd81b148d903472e02. Breaks bots. Modified:

r355514 - Reland "[Remarks] Refactor remark diagnostic emission in a RemarkStreamer"

Author: thegameg Date: Wed Mar 6 07:20:13 2019 New Revision: 355514 URL: http://llvm.org/viewvc/llvm-project?rev=355514=rev Log: Reland "[Remarks] Refactor remark diagnostic emission in a RemarkStreamer" This allows us to store more info about where we're emitting the remarks without cluttering

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

rdwampler added a comment. Ping? Can somebody commit this for me? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58186/new/ https://reviews.llvm.org/D58186 ___ cfe-commits mailing list

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

Szelethus marked an inline comment as done. Szelethus added inline comments. Herald added a subscriber: Charusso. Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:352-355 + if (Checker->AllowedPad < 0) +

[PATCH] D58757: Add a version of the pass_object_size attribute that works with builtin_dynamic_object_size

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1570 +def PassDynamicObjectSize : InheritableParamAttr { + let Spellings = [Clang<"pass_dynamic_object_size">]; + let Args = [IntArgument<"Type">]; Why use a separate attribute

[PATCH] D58977: [clang-tidy] Add the abseil-time-comparison check

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/abseil-time-comparison.rst:6 + +Checks for comparisons which should be in the ``absl::Time`` domain instead +of the integer domains. Please synchronize with Release Notes.

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu updated this revision to Diff 189514. jasonliu added a comment. Address comments in last revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58930/new/ https://reviews.llvm.org/D58930 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D58719: [PR40778][Sema] Adjust address space of operands in builtin operators

Anastasia updated this revision to Diff 189527. Anastasia added a comment. Herald added a subscriber: jdoerfert. I now create overloads for all address spaces that are being called. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58719/new/ https://reviews.llvm.org/D58719 Files:

[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:707 CmdArgs.push_back(StaticLibName); +} else if (OrigInputFileName.endswith(".so")) { + // Only static libraries are supported. I would suggest to use

[PATCH] D59032: Passthrough compiler launcher

jfb created this revision. jfb added reviewers: ddunbar, dexonsmith. Herald added subscribers: cfe-commits, jdoerfert, jkorous, mgorny. Herald added a project: clang. Not having this seems like an oversight, and makes stage2 builds odd. Repository: rC Clang https://reviews.llvm.org/D59032

[PATCH] D58992: [CUDA][HIP][DebugInfo] Skip reference device function

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1755 +} +V = V->stripPointerCasts(); } aprantl wrote: > This wasn't there before... why is this necessary? That's from the

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

This revision was automatically updated to reflect the committed changes. Closed by commit rL355522: [IR][ARM] Add function pointer alignment to datalayout (authored by michaelplatings, committed by ). Changed prior to commit: https://reviews.llvm.org/D57335?vs=188325=189524#toc Repository:

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

smeenai added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:89 + P.assign(D.Dir); + llvm::sys::path::append(P, "..", "lib", D.getTargetTriple(), "lib"); + if (getVFS().exists(P)) Is this supposed to append lib twice? Comment

[PATCH] D39050: Add index-while-building support to Clang

jkorous added a comment. I'll address comments for this patch in the new set of patches. @gribozavr I haven't put up this part of code for the new round of review yet. I will keep this on mind. @mgrang This already landed in edbbe470f66

[PATCH] D58216: Support attribute used in member funcs of class templates II

rafauler added a subscriber: davezarzycki. rafauler added a comment. Both approaches make sense to me. I'll re-land the previous patch in favor of gcc compatibility, since the semantics of attribute used in member functions of class templates were first implemented in gcc. @davezarzycki Heads

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked 2 inline comments as done. jasonliu added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false;

[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:707 CmdArgs.push_back(StaticLibName); +} else if (OrigInputFileName.endswith(".so")) { + // Only static libraries are supported.

[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:707 CmdArgs.push_back(StaticLibName); +} else if (OrigInputFileName.endswith(".so")) { + // Only static libraries are supported.

[PATCH] D58977: [clang-tidy] Add the abseil-time-comparison check

ioeric added inline comments. Comment at: clang-tidy/abseil/TimeComparisonCheck.cpp:23 + auto Matcher = + binaryOperator(anyOf(hasOperatorName(">"), hasOperatorName(">="), + hasOperatorName("=="), hasOperatorName("<="),

[PATCH] D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:261 +/// necessary. +QualType ReplaceAutoType(QualType TypeWithAuto, QualType Replacement) { + QualType T = sema.ReplaceAutoType(TypeWithAuto, Replacement); I think this

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Anyways, this looks good in this state. Thank you for working on this! If you don't intend to immediately work on fixing the rest of `,` cases here, *please* do file a bug so it won't

[PATCH] D58890: Modules: Rename MemoryBufferCache to InMemoryModuleCache

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. > `ninja check-clang` passes... is there anything else I should be testing? I'm not sure, just double checking :) The general approach LGTM though. CHANGES SINCE LAST ACTION

[PATCH] D59034: Delete x86_64 ShadowCallStack support

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. Thanks for cleaning this up. Comment at: clang/docs/ShadowCallStack.rst:23 +to have critical performance and security deficiencies--it was removed in +LLVM 9.0.

[PATCH] D58992: [CUDA][HIP][DebugInfo] Skip reference device function

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1755 +} +V = V->stripPointerCasts(); } This wasn't there before... why is this necessary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D58216: Support attribute used in member funcs of class templates II

aaron.ballman added a comment. In D58216#1414864 , @modocache wrote: > Friendly ping! @aaron.ballman it looks like you accepted D56928 > , could you take a look at this as well? Sorry for the delay -- I was at WG21

[PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; davide wrote: >

[PATCH] D57855: [analyzer] Reimplement checker options

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits, but you should wait for someone more well-versed in the static analyzer to sign off before committing. Comment at:

[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:707 CmdArgs.push_back(StaticLibName); +} else if (OrigInputFileName.endswith(".so")) { + // Only static libraries are supported. gtbercea wrote: > ABataev wrote: > > I

[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:707 CmdArgs.push_back(StaticLibName); +} else if (OrigInputFileName.endswith(".so")) { + // Only static libraries are supported. gtbercea wrote: > ABataev wrote: > >

[PATCH] D58930: Add XCOFF triple object format type for AIX

davide requested changes to this revision. davide added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented

[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

gtbercea created this revision. gtbercea added reviewers: ABataev, Hahnfeld, caomhin. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. NVLINK does not support dynamic linking so passing dynamic libraries to NVLINK should be avoided. This patch fixes a

[PATCH] D58154: Add support for -fpermissive.

jyknight added a comment. Ah -- I now understand your concern, and managing user expectations appropriately does seem like a potential concern. I did not look too closely before into what exactly GCC categorized as "permerror" (errors that can be disabled with -fpermissive) vs what Clang

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

aaron.ballman added a comment. Do you have some evidence that the current behavior is causing a lot of false positives in the wild? For ASCII character literals, I can sort of guess at why people might want to do this, but for things like wide character literals, or character literals relying

r355522 - [IR][ARM] Add function pointer alignment to datalayout

Author: michaelplatings Date: Wed Mar 6 09:24:11 2019 New Revision: 355522 URL: http://llvm.org/viewvc/llvm-project?rev=355522=rev Log: [IR][ARM] Add function pointer alignment to datalayout Use this feature to fix a bug on ARM where 4 byte alignment is incorrectly assumed. Differential

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:34 + bool VisitUnqualName(StringRef UnqualName) { +// Check for collisions with function arguments +for (ParmVarDecl *Param : F.parameters()) Missing

[PATCH] D58930: Add XCOFF triple object format type for AIX

sfertile added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:165 +case MCObjectFileInfo::IsXCOFF: + // TODO: Need to implement class MCSymbolXCOFF. + break; jasonliu wrote: > JDevlieghere wrote: > > See previous comment. > It is certain

[PATCH] D39050: Add index-while-building support to Clang

mgrang added inline comments. Comment at: lib/Index/FileIndexData.cpp:31 + std::vector Sorted(Decls); + std::sort(Sorted.begin(), Sorted.end()); + return Sorted; Please use range-based llvm::sort instead of std::sort: ``` llvm::sort(Sorted); ``` See

[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:707 CmdArgs.push_back(StaticLibName); +} else if (OrigInputFileName.endswith(".so")) { + // Only static libraries are supported.

[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:707 CmdArgs.push_back(StaticLibName); +} else if (OrigInputFileName.endswith(".so")) { + // Only static libraries are supported. gtbercea wrote: > ABataev wrote: > >

[PATCH] D39050: Add index-while-building support to Clang

jkorous abandoned this revision. jkorous added a comment. It's time to officially abandon these patches in favor of new push for upstreaming index-while-building. Current reviews in progress https://reviews.llvm.org/D58749 https://reviews.llvm.org/D58418 RFC

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

phosek marked an inline comment as done. phosek added inline comments. Comment at: libcxx/CMakeLists.txt:421 + set(DEFAULT_INSTALL_PREFIX lib${LLVM_LIBDIR_SUFFIX}/${LLVM_DEFAULT_TARGET_TRIPLE}/) + set(LIBCXX_LIBRARY_DIR

r355547 - Passthrough compiler launcher

Author: jfb Date: Wed Mar 6 12:36:00 2019 New Revision: 355547 URL: http://llvm.org/viewvc/llvm-project?rev=355547=rev Log: Passthrough compiler launcher Summary: Not having this seems like an oversight, and makes stage2 builds odd. Reviewers: ddunbar, dexonsmith Subscribers: mgorny, jkorous,

[PATCH] D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()"

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM other than removing the destructor. Comment at: src/experimental/memory_resource.cpp:29 -public: -~__new_delete_memory_resource_imp() = default; -

[PATCH] D59032: Passthrough compiler launcher

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59032/new/ https://reviews.llvm.org/D59032

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

phosek updated this revision to Diff 189552. phosek marked 2 inline comments as done. Herald added a subscriber: jdoerfert. Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56044/new/ https://reviews.llvm.org/D56044 Files:

r355549 - AMDGPU: Fix the mapping of sub group sync scope

Author: kzhuravl Date: Wed Mar 6 12:54:48 2019 New Revision: 355549 URL: http://llvm.org/viewvc/llvm-project?rev=355549=rev Log: AMDGPU: Fix the mapping of sub group sync scope Map memory_scope_sub_group to "wavefront" sync scope Differential Revision: https://reviews.llvm.org/D58847

[PATCH] D39050: Add index-while-building support to Clang

akyrtzi added inline comments. Comment at: include/clang/Frontend/FrontendOptions.h:380 + /// Whether to ignore system files when writing out index data + unsigned IndexIgnoreSystemSymbols : 1; + /// Whether to include the codegen name of symbols in the index data

[PATCH] D58992: [CUDA][HIP][DebugInfo] Skip reference device function

This revision was automatically updated to reflect the committed changes. Closed by commit rL31: [CUDA][HIP][DebugInfo] Skip reference device function (authored by hliao, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r355551 - [CUDA][HIP][DebugInfo] Skip reference device function

Author: hliao Date: Wed Mar 6 13:16:27 2019 New Revision: 31 URL: http://llvm.org/viewvc/llvm-project?rev=31=rev Log: [CUDA][HIP][DebugInfo] Skip reference device function Summary: - A device functions could be used as a non-type template parameter in a global/host function template.

[PATCH] D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()"

EricWF added inline comments. Comment at: src/experimental/memory_resource.cpp:29 -public: -~__new_delete_memory_resource_imp() = default; - Quuxplusone wrote: > EricWF wrote: > > Why are you removing this? > Just removing unnecessary cruft. Same reason I

[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

gtbercea added a comment. For now this patch doesn't make sense until the main linking patch lands but it's a case we need to keep in mind. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59028/new/ https://reviews.llvm.org/D59028

[PATCH] D59034: Delete x86_64 ShadowCallStack support

vlad.tsyrklevich created this revision. vlad.tsyrklevich added a reviewer: pcc. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, jdoerfert, hiraditya, javed.absar, mgorny. Herald added projects: clang, Sanitizers, LLVM. ShadowCallStack on x86_64 suffered from the same racy

r355537 - Revert "[IR][ARM] Add function pointer alignment to datalayout"

Author: hctim Date: Wed Mar 6 11:17:18 2019 New Revision: 355537 URL: http://llvm.org/viewvc/llvm-project?rev=355537=rev Log: Revert "[IR][ARM] Add function pointer alignment to datalayout" This reverts commit 2391bfca97290181ae65796ea6da135d1b6d037b. This reverts rL355522

[PATCH] D58154: Add support for -fpermissive.

rsmith added a comment. In D58154#1419956 , @jyknight wrote: > I also can't really tell what the intent is behind classifying some > diagnostics in Clang as ExtWarn,DefaultError and others Warning,DefaultError > -- or if there even is any useful purpose

[PATCH] D58216: Support attribute used in member funcs of class templates II

aaron.ballman added a comment. In D58216#1420149 , @rafauler wrote: > Both approaches make sense to me. I'll re-land the previous patch in favor of > gcc compatibility, since the semantics of attribute used in member functions > of class templates were

[PATCH] D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()"

Quuxplusone marked an inline comment as done. Quuxplusone added inline comments. Comment at: src/experimental/memory_resource.cpp:29 -public: -~__new_delete_memory_resource_imp() = default; - EricWF wrote: > Why are you removing this? Just removing

[PATCH] D59048: Add AIX Target Info

andusy created this revision. andusy added reviewers: apaprocki, chandlerc, hubert.reinterpretcast, jasonliu, xingxue, sfertile. Herald added subscribers: jsji, jfb, kbarton, nemanjai. Herald added a project: clang. A first pass over platform-specific properties of the C API/ABI on AIX for both

[PATCH] D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()"

zoecarver added a comment. @Quuxplusone if this fixes 2843 can you update it in `www/cxx2a_status.html`? Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47344/new/ https://reviews.llvm.org/D47344 ___ cfe-commits

[PATCH] D58154: Add support for -fpermissive.

aaron.ballman added a comment. In D58154#1420344 , @rsmith wrote: > I don't have particularly strong feelings one way or the other about > accepting `-fpermissive` at all. For GCC compatibility, it seems like a > moderately useful thing to support, but

[PATCH] D59054: [analyzer] C++17: PR40022: Support aggregate initialization with compound values in presence of base classes.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware. Herald added subscribers: cfe-commits, Charusso, jdoerfert, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. I'll add more tests soon,

[PATCH] D59055: [analyzer] Prepare generic taint checker for new sources

boga95 created this revision. boga95 added reviewers: gerazo, xazax.hun, Szelethus, a_sidorin, dcoughlin, george.karpenkov, NoQ. boga95 added a project: clang. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware,

r355563 - [PGO] Re-submit: Clang part of change for context-sensitive PGO (part2)

Author: xur Date: Wed Mar 6 15:00:38 2019 New Revision: 355563 URL: http://llvm.org/viewvc/llvm-project?rev=355563=rev Log: [PGO] Re-submit: Clang part of change for context-sensitive PGO (part2) Part 2 of CSPGO change in Clang: Add test cases. Differential Revision:

[PATCH] D58216: Support attribute used in member funcs of class templates II

rafauler added a comment. I'm not an expert in swift either. I'll wait for @davezarzycki input on what's happening, but I suspect the code base is indeed incompatible with gcc due to the nature of the error they experienced. This testcase is creduce-d from what I observed in swift.

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. I'm fine merging in this state... but please wait for rsmith to respond before you merge. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

nickdesaulniers added a comment. > which is making things hard for the folks testing this with the Linux kernel > and needing to apply this patch themselves. If we can get inlining of callbr working first before landing this, then all of our CI won't go immediately red (as it would from

[PATCH] D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()"

Quuxplusone updated this revision to Diff 189600. Quuxplusone added a comment. Herald added a subscriber: jdoerfert. - Replace the unnecessary destructor in `class __new_delete_resource_imp`. - Add LWG2843 to the list of completed issues (thanks @zoecarver!) Repository: rCXX libc++ CHANGES

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

craig.topper added a comment. @rsmith, @efriedma, @chandlerc, is this in good enough shape that we can commit and move to incremental fixes/improvement? Jennifer has had to rebase this a couple times which is making things hard for the folks testing this with the Linux kernel and needing to

[PATCH] D58320: [Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the builtins library.

ab added a comment. Please check the embedded thing (the other comments are minor). Otherwise, LGTM; if you have found this flag to be necessary, this looks like a reasonable way to implement it Comment at: clang/include/clang/Driver/Options.td:1252 +def fapple_link_rtlib :

[PATCH] D58154: Add support for -fpermissive.

rsmith abandoned this revision. rsmith added a comment. In D58154#1420565 , @aaron.ballman wrote: > If we go with a different name for the flag, then the user has to update > their build scripts to get code to compile with Clang, which means it >

[PATCH] D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()"

Quuxplusone updated this revision to Diff 189602. Quuxplusone added a comment. Oops, really replace the destructor this time. (Hadn't `git commit`ed.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47344/new/ https://reviews.llvm.org/D47344 Files: src/experimental/memory_resource.cpp

  1   2   >