[PATCH] D59628: Add support for __attribute__((objc_class_stub))

slavapestov updated this revision to Diff 192378. slavapestov marked 2 inline comments as done. slavapestov added a comment. Second revision adds the following: - Validation of the attribute in Sema - Sema tests for the above - Correct behavior of super method calls of a class with the attribute

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

rjmccall added inline comments. Comment at: lib/CodeGen/CGObjCMac.cpp:7274 +// Classrefs pointing at Objective-C stub classes have the least +// significant bit set to 1. +auto *Tag = llvm::ConstantInt::get(CGM.IntPtrTy, 1); slavapestov

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

erik.pilkington added a comment. In D58797#1443411 , @efriedma wrote: > For that particular case, I think we could suppress the false positive using > DiagRuntimeBehavior. How many total false positives are we talking about, > and how many can the

r357040 - [Sema] Fix an assert when a block captures a constexpr local

Author: epilk Date: Tue Mar 26 16:21:19 2019 New Revision: 357040 URL: http://llvm.org/viewvc/llvm-project?rev=357040=rev Log: [Sema] Fix an assert when a block captures a constexpr local MarkVarDeclODRUsed indirectly calls captureInBlock, which creates a copy expression. The copy expression is

r357041 - Emit -Wfortify-source using DiagRuntimeBehaviour

Author: epilk Date: Tue Mar 26 16:21:22 2019 New Revision: 357041 URL: http://llvm.org/viewvc/llvm-project?rev=357041=rev Log: Emit -Wfortify-source using DiagRuntimeBehaviour This fixes a false positive on the following, where st is configured to have different sizes based on some preprocessor

[PATCH] D59407: [clangd] Add RelationSlab

nridge added a comment. As this is the first of a series of patches adding support for relations, and then building type hierarchy subtypes on top (as discussed here ), how should we go about landing this -- should we land each patch in the series as

[PATCH] D59670: [Sema] Fix an assert when a block captures a constexpr local

erik.pilkington closed this revision. erik.pilkington added a comment. Landed in r357040. (I forgot to write Differential revision:!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59670/new/ https://reviews.llvm.org/D59670 ___ cfe-commits

[clang-tools-extra] r357037 - Frontend: Remove CompilerInstance::VirtualFileSystem, NFC

Author: dexonsmith Date: Tue Mar 26 15:18:52 2019 New Revision: 357037 URL: http://llvm.org/viewvc/llvm-project?rev=357037=rev Log: Frontend: Remove CompilerInstance::VirtualFileSystem, NFC Remove CompilerInstance::VirtualFileSystem and CompilerInstance::setVirtualFileSystem, instead relying on

r357037 - Frontend: Remove CompilerInstance::VirtualFileSystem, NFC

Author: dexonsmith Date: Tue Mar 26 15:18:52 2019 New Revision: 357037 URL: http://llvm.org/viewvc/llvm-project?rev=357037=rev Log: Frontend: Remove CompilerInstance::VirtualFileSystem, NFC Remove CompilerInstance::VirtualFileSystem and CompilerInstance::setVirtualFileSystem, instead relying on

[PATCH] D59377: Frontend: Remove CompilerInstance::VirtualFileSystem, NFC

dexonsmith closed this revision. dexonsmith added a comment. Committed r357037. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59377/new/ https://reviews.llvm.org/D59377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore updated this revision to Diff 192373. stephanemoore added a comment. Use double backticks rather than single backticks for symbols in documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59806/new/

r357038 - Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

Author: dexonsmith Date: Tue Mar 26 15:32:06 2019 New Revision: 357038 URL: http://llvm.org/viewvc/llvm-project?rev=357038=rev Log: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC FileManager constructs a VFS in its constructor if it isn't passed one, and there's no way to

[PATCH] D59388: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

dexonsmith closed this revision. dexonsmith added a comment. Committed r357038. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59388/new/ https://reviews.llvm.org/D59388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r357038 - Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

Author: dexonsmith Date: Tue Mar 26 15:32:06 2019 New Revision: 357038 URL: http://llvm.org/viewvc/llvm-project?rev=357038=rev Log: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC FileManager constructs a VFS in its constructor if it isn't passed one, and there's no way to

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore updated this revision to Diff 192383. stephanemoore added a comment. Update tests to match updated diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59806/new/ https://reviews.llvm.org/D59806 Files:

[PATCH] D46140: [coroutines] Add std::experimental::task type

lewissbaker reopened this revision. lewissbaker added a comment. This revision is now accepted and ready to land. Reopening as the commit for this diff was reverted due to it breaking the buildbot module builds. Repository: rCXX libc++ CHANGES SINCE LAST ACTION

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 added a comment. I add a new taint type, which represents a lack of taintedness. That's why I changed the name of `addTaint()` to `setTaint()`. Of course, it's not an important change, I can move it to another patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/

[PATCH] D59838: gn build: Add build files for clang-include-fixer and find-all-symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rL357042: gn build: Add build files for clang-include-fixer and find-all-symbols (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D59838?vs=192334=192387#toc

[PATCH] D59407: [clangd] Add RelationSlab

gribozavr added a comment. Submitting code as it becomes ready is the usual practice here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59407/new/ https://reviews.llvm.org/D59407 ___ cfe-commits

[PATCH] D59857: [analyzer] PR37501: Disable the assertion for reverse-engineering logical op short circuits.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso, alexfh. Herald added subscribers: cfe-commits, jdoerfert, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. Replace the

[PATCH] D59859: [clang-tidy] FIXIT for implicit bool conversion now obeys upper case suffixes if enforced.

pnappa created this revision. pnappa added a reviewer: lebedev.ri. pnappa added a project: clang-tools-extra. Herald added subscribers: cfe-commits, jdoerfert, xazax.hun. Herald added a project: clang. Fix for https://bugs.llvm.org/show_bug.cgi?id=41199#c1 Previously, if a user implicitly cast

Buildbot numbers for the week of 03/17/2019 - 03/23/2019

Hello everyone, Below are some buildbot numbers for the last week of 03/17/2019 - 03/23/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 03/10/2019 - 03/16/2019

Hello everyone, Below are some buildbot numbers for the week of 03/10/2019 - 03/16/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso, alexfh. Herald added subscribers: cfe-commits, jdoerfert, dkrupp, donat.nagy, a.sidorin, szepet, mgorny. Herald added a project: clang. Given how

[PATCH] D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?

NoQ added a comment. (whoops sry nvm typo in reviewer list) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59861/new/ https://reviews.llvm.org/D59861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r356598 - Recommit "Support attribute used in member funcs of class templates"

On Wed, Mar 20, 2019 at 12:21 PM Rafael Auler via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rafauler > Date: Wed Mar 20 12:22:24 2019 > New Revision: 356598 > > URL: http://llvm.org/viewvc/llvm-project?rev=356598=rev > Log: > Recommit "Support attribute used in member funcs of

[PATCH] D59863: [HIP] Support gpu arch gfx906+sram-ecc

yaxunl created this revision. yaxunl added reviewers: tra, ashi1. Herald added a subscriber: jholewinski. Add a new gpu arch gfx906+sram-ecc for HIP. It is similar to gfx906 but implies target feature sram-ecc enabled, whereas gfx906 implies target sram-ecc disabled. Corresponding option

[PATCH] D59407: [clangd] Add RelationSlab

nridge added a comment. Ok, cool. In that case, I think this patch is ready to be committed, and would appreciate it if someone could commit it. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59407/new/ https://reviews.llvm.org/D59407

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang updated this revision to Diff 192394. axzhang added a comment. Add documentation about the added option for `modernize-make-unique`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D59725: Additions to creduce script

george.burgess.iv added a comment. Only a few more nits on my side, and this LGTM. WDYT, arichardson? Comment at: clang/utils/creduce-clang-crash.py:137 + +# If no message was found, use the top five stack trace functions, +# ignoring some common functions

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

NoQ added a comment. Hi, i wanted to squeeze in D59861 somewhere in the middle of your work, would you mind? I'll definitely have a look at your patches soon :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516

Re: r356598 - Recommit "Support attribute used in member funcs of class templates"

I’m familiar with this issue as I had to fix a memory bug in LLVM IRLinker that was exposed by this commit. That’s why I initially reverted it. However, after fixing it, I was able to do the full clang LTO self-hosting with lld on Linux. Is there any way I can repro this issue? It’s probably a

<    1   2