[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai added a comment. In D58497#1449306 , @dblaikie wrote: > In D58497#1449243 , @nemanjai wrote: > > > Ping. > > > Unfortunately Richard Smith is out for a few weeks at the moment, so might > take a little

[clang-tools-extra] r357371 - Spelling correction for docs for cppcoreguidelines-owning-memory

Author: sylvestre Date: Sun Mar 31 14:53:00 2019 New Revision: 357371 URL: http://llvm.org/viewvc/llvm-project?rev=357371=rev Log: Spelling correction for docs for cppcoreguidelines-owning-memory Summary: There's a typo in the docs, as mentioned in the title. Please see the diff. Reviewers:

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

NoQ added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2208 +} + CFGBlock *CFGBuilder::VisitStmt(Stmt *S, AddStmtChoice asc) { Tyker wrote: > riccibruno wrote: > > I don't understand why this is needed. Can you explain it ? Also I think > > that

[PATCH] D60050: Spelling correction for docs for cppcoreguidelines-owning-memory

gobennyb created this revision. gobennyb added a reviewer: JonasToth. gobennyb created this object with edit policy "Administrators". gobennyb added a project: clang-tools-extra. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. There's a typo in the docs,

[PATCH] D60040: [clangd] Use capacity() instead of size() in RefSlab::bytes()

nridge added a comment. I do not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60040/new/ https://reviews.llvm.org/D60040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60050: Spelling correction for docs for cppcoreguidelines-owning-memory

sylvestre.ledru added a comment. If you have permissions on the repo, no need for a review for such change! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60050/new/ https://reviews.llvm.org/D60050 ___

[PATCH] D60050: Spelling correction for docs for cppcoreguidelines-owning-memory

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL357371: Spelling correction for docs for cppcoreguidelines-owning-memory (authored by sylvestre, committed by ). Herald

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As was already stated in a previous comment, the parameter isn't necessarily referring to one of the DeclContext's parameter. We should check the index is within the range to avoid out-of-boundary

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet updated this revision to Diff 193041. Violet added a comment. Wrong bug number Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 Files: clang/lib/Sema/SemaTemplateInstantiate.cpp

[PATCH] D60050: Spelling correction for docs for cppcoreguidelines-owning-memory

gobennyb added a comment. In D60050#1449392 , @sylvestre.ledru wrote: > If you have permissions on the repo, no need for a review for such change! I do not, so if someone could please commit for me, that'd be great. Thanks! Repository: rCTE Clang

r357366 - [InstCombine] canonicalize select shuffles by commuting

Author: spatel Date: Sun Mar 31 08:01:30 2019 New Revision: 357366 URL: http://llvm.org/viewvc/llvm-project?rev=357366=rev Log: [InstCombine] canonicalize select shuffles by commuting In PR41304: https://bugs.llvm.org/show_bug.cgi?id=41304 ...we have a case where we want to fold a binop of

[PATCH] D60016: [InstCombine] canonicalize select shuffles by commuting

This revision was automatically updated to reflect the committed changes. Closed by commit rC357366: [InstCombine] canonicalize select shuffles by commuting (authored by spatel, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker updated this revision to Diff 193015. Tyker added a comment. Herald added a reviewer: martong. Herald added a reviewer: shafik. @riccibruno i fixed based on feedback everything except the CFG edit as i still need to analyse the situation. added AST and CodeGen for For, While, Do and

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker marked an inline comment as done. Tyker added inline comments. Herald added a subscriber: rnkovacs. Comment at: clang/test/SemaCXX/cxx2a-likelihood-attr.cpp:70 + +// clang-format off just saw the //clang format off at the bottom ill remove it CHANGES

r357359 - Range-style std::find{,_if} -> llvm::find{,_if}. NFC

Author: maskray Date: Sun Mar 31 01:48:19 2019 New Revision: 357359 URL: http://llvm.org/viewvc/llvm-project?rev=357359=rev Log: Range-style std::find{,_if} -> llvm::find{,_if}. NFC Modified: cfe/trunk/include/clang/AST/DeclContextInternals.h

[PATCH] D60046: [python, tests] Disable Clang Python tests on Solaris/SPARC

ro created this revision. ro added a reviewer: rsmith. ro added a project: clang. Herald added subscribers: fedor.sergeev, mgorny, jyknight. Running `make check-all` fails on Solaris 11/SPARC since the clang python tests FAIL:

[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

theraven updated this revision to Diff 193002. theraven marked 2 inline comments as done. theraven added a comment. - Fix ownership with Twine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58724/new/ https://reviews.llvm.org/D58724 Files:

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

Szelethus added a comment. I would still like to learn more about this issue. I am somewhat afraid that the our macro expansion is faulty. Can you provide a stacktrace maybe? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59934/new/

[PATCH] D60040: [clangd] Use capacity() instead of size() in RefSlab::bytes()

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60040/new/ https://reviews.llvm.org/D60040

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

gamesh411 added a comment. In D59934#1449109 , @Szelethus wrote: > I would still like to learn more about this issue. I am somewhat afraid that > the our macro expansion is faulty. Can you provide a stacktrace maybe? The stack trace that belongs to the

[PATCH] D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py

zinovy.nis updated this revision to Diff 193023. zinovy.nis added a comment. Herald added a subscriber: jdoerfert. Added a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59449/new/ https://reviews.llvm.org/D59449 Files: clang-tidy/tool/run-clang-tidy.py

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:528 +if (ElseLikelihoodAttr && ThenLikelihoodAttr->isEqual(ElseLikelihoodAttr)) { + Diag(ElseLikelihoodAttr->getLocation(), +

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker updated this revision to Diff 193016. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 Files: clang/include/clang/AST/Stmt.h clang/include/clang/AST/StmtCXX.h clang/include/clang/AST/TextNodeDumper.h clang/include/clang/Basic/Attr.td

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

dblaikie added a comment. In D58497#1449243 , @nemanjai wrote: > Ping. Unfortunately Richard Smith is out for a few weeks at the moment, so might take a little bit before he can get to this. It's odd to me that this lacks a test case - but you mention

[PATCH] D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable

ztamas updated this revision to Diff 193017. ztamas added a comment. Make 16 the default value of MagnitudeBitsUpperLimit option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59870/new/ https://reviews.llvm.org/D59870 Files:

[PATCH] D60038: gn build: Add build files for most clang-tools-extra unit tests

thakis marked an inline comment as done. thakis added a comment. Thanks! Comment at: llvm/utils/gn/secondary/clang-tools-extra/unittests/clang-apply-replacements/BUILD.gn:3 + +unittest("ClangApplyReplacementsTests") { + configs += [ "//llvm/utils/gn/build:clang_code" ]

[clang-tools-extra] r357369 - gn build: Add build files for most clang-tools-extra unit tests

Author: nico Date: Sun Mar 31 09:49:54 2019 New Revision: 357369 URL: http://llvm.org/viewvc/llvm-project?rev=357369=rev Log: gn build: Add build files for most clang-tools-extra unit tests Differential Revision: https://reviews.llvm.org/D60038 Modified:

[PATCH] D60038: gn build: Add build files for most clang-tools-extra unit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL357369: gn build: Add build files for most clang-tools-extra unit tests (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D60038?vs=192995=193019#toc Repository:

r357363 - COMDAT-fold block descriptors.

Author: theraven Date: Sun Mar 31 04:22:26 2019 New Revision: 357363 URL: http://llvm.org/viewvc/llvm-project?rev=357363=rev Log: COMDAT-fold block descriptors. Without this change, linking multiple objects containing block descriptors together on Windows will generate duplicate symbol errors.

r357364 - [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

Author: theraven Date: Sun Mar 31 04:22:33 2019 New Revision: 357364 URL: http://llvm.org/viewvc/llvm-project?rev=357364=rev Log: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs. Summary: Based on a patch by Dustin Howett, modified to not change the ABI for ELF platforms. Use more

[PATCH] D58807: [CodeGen] COMDAT-fold block descriptors

This revision was automatically updated to reflect the committed changes. Closed by commit rL357363: COMDAT-fold block descriptors. (authored by theraven, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC357364: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs. (authored by theraven, committed by ). Changed

r357362 - [objc-gnustep] Use .init_array not .ctors when requested.

Author: theraven Date: Sun Mar 31 04:22:19 2019 New Revision: 357362 URL: http://llvm.org/viewvc/llvm-project?rev=357362=rev Log: [objc-gnustep] Use .init_array not .ctors when requested. This doesn't make a difference most of the time but FreeBSD/ARM doesn't run anything in the .ctors array.

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

Szelethus added a subscriber: bruntib. Szelethus added a comment. Hmm. Is your clang recent enough to contain @bruntib's patch D57892 ? Is it possible that this patch solves the same issue? With this patch applied, are you able to get a macro expansions from a

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

nemanjai added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. Do you plan to follow-up on these questions and comments? At least the full context is needed and for the test case, I imagine it can be similar to other driver test cases. I imagine

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker marked 2 inline comments as done. Tyker added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2208 +} + CFGBlock *CFGBuilder::VisitStmt(Stmt *S, AddStmtChoice asc) { riccibruno wrote: > I don't understand why this is needed. Can you explain it ?

[PATCH] D59934: Compare SourceLocations from different TUs by FileID

gamesh411 added a comment. In D59934#1449221 , @Szelethus wrote: > Hmm. Is your clang recent enough to contain @bruntib's patch D57892 > ? Is it possible that this patch solves the > same issue? With this patch applied,

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

riccibruno added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:705 +} + void CodeGenFunction::EmitWhileStmt(const WhileStmt , Tyker wrote: > riccibruno wrote: > > I believe that the lowering is incorrect. I applied your patch and here > >

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai added a comment. Ping. If there are no objections in the next week or so, I'll commit this and it can be reviewed post-commit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58497/new/ https://reviews.llvm.org/D58497

[PATCH] D60038: gn build: Add build files for most clang-tools-extra unit tests

mbonadei accepted this revision. mbonadei added a comment. This revision is now accepted and ready to land. LGTM, just a small style comment. Comment at: llvm/utils/gn/secondary/clang-tools-extra/unittests/clang-apply-replacements/BUILD.gn:3 +

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

glaubitz added a comment. Well, I don't really know what to add here. The GCCDIST path on 32-bit PowerPC SUSE distributions has always been "powerpc64-suse-linux" according to SUSE's gcc maintainer Richard Biener and my patch just fixes that. We're already using this patch in openSUSE without

[PATCH] D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable

ztamas added a comment. In D59870#1446537 , @JonasToth wrote: > > I think it's the easiest way to specify the bits of the ineteger type to > > limit the catches. In real life, I met with this overflow / infinite loop > > problem with 16-bit short type,