Re: [PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

https://reviews.llvm.org/D60213 for the record On Wed, Apr 3, 2019 at 12:55 PM Yitzhak Mandelbaum wrote: > Thanks. Do you have build command I can run before/after to verify my fix > before I submit? > > On Wed, Apr 3, 2019 at 12:43 PM Alexey Bataev via Phabricator < >

[PATCH] D60213: Add clangTooling dependency to fix the build.

ymandel added a comment. In D60213#1453516 , @ABataev wrote: > Nope, it won't work. There is a cyclic dependency, unfortunately. > clangTooling depends on clangToolingRefactor already. You need to revert your > commit and refactor it to remove the

Re: [PATCH] D60213: Add clangTooling dependency to fix the build.

That would be great, thank you. On Wed, Apr 3, 2019 at 1:28 PM Alexey Bataev via Phabricator < revi...@reviews.llvm.org> wrote: > ABataev added a comment. > > I can revert it for you, if you want > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION >

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using HeaderFileExtensionsSet = SmallSet; aaron.ballman

r357617 - [OPENMP]Add codegen for firstprivate vars with allocate clause.

Author: abataev Date: Wed Apr 3 10:57:06 2019 New Revision: 357617 URL: http://llvm.org/viewvc/llvm-project?rev=357617=rev Log: [OPENMP]Add codegen for firstprivate vars with allocate clause. Added codegen/test for the firstprivatized variables with the allocate clause. Modified:

Re: [PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

Thanks. Any idea why AtomicChange.cpp's inclusion of clang/Tooling/ReplacementsYaml.h doesn't cause the same problem? https://github.com/llvm/llvm-project/blob/master/clang/lib/Tooling/Refactoring/AtomicChange.cpp On Wed, Apr 3, 2019 at 2:11 PM Alexey Bataev wrote: > The problem is that

[PATCH] D60235: [CMake] Disable libc++ and libc++abi new/delete definitions when built with ASan

phosek added a subscriber: ldionne. phosek added a comment. In D60235#1454152 , @mcgrathr wrote: > IMHO the library code should use `#if !__has_feature(...)` to avoid the > definitions entirely when built with a sanitizer whose runtime provides them. >

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

akhuang created this revision. akhuang added a reviewer: rnk. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. Emit !heapallocsite in the metadata for calls to functions marked with __declspec(allocator). Eventually this will be emitted as S_HEAPALLOCSITE debug info in

[clang-tools-extra] r357654 - Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery

Author: nico Date: Wed Apr 3 17:05:53 2019 New Revision: 357654 URL: http://llvm.org/viewvc/llvm-project?rev=357654=rev Log: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery This allows building it even if no fuzzer is enabled. (Sadly, it only builds on Linux at the moment.)

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay added a comment. Ping :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 added a comment. Dear reviewers, any comments? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:145 + +diag(MatchedDecl->getBeginLoc(), "use dyn_cast_or_null") +<<

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:18 + +AST_MATCHER(Expr, isMacroID) { return Node.getExprLoc().isMacroID(); } +} // namespace ast_matchers

[PATCH] D60235: [CMake] Disable libc++ and libc++abi new/delete definitions when built with ASan

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. IMHO the library code should use `#if !__has_feature(...)` to avoid the definitions entirely when built with a sanitizer whose runtime provides them. But this is a fine way to achieve that

r357643 - add periods

Author: akhuang Date: Wed Apr 3 15:19:07 2019 New Revision: 357643 URL: http://llvm.org/viewvc/llvm-project?rev=357643=rev Log: add periods Modified: cfe/trunk/lib/CodeGen/CGAtomic.cpp Modified: cfe/trunk/lib/CodeGen/CGAtomic.cpp URL:

[PATCH] D60238: Verify that Android targets generate DWARF 4 by default.

aprantl added inline comments. Comment at: clang/test/Driver/debug-options.c:280 // G_STANDALONE: "-debug-info-kind=standalone" +// G_DWARF2: "-dwarf-version=2" // G_DWARF4: "-dwarf-version=4" What's that for? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D60238: Verify that Android targets generate DWARF 4 by default.

srhines marked an inline comment as done. srhines added inline comments. Comment at: clang/test/Driver/debug-options.c:280 // G_STANDALONE: "-debug-info-kind=standalone" +// G_DWARF2: "-dwarf-version=2" // G_DWARF4: "-dwarf-version=4" aprantl wrote: > What's

[PATCH] D60201: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE357654: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit:

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

thakis added a comment. ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60120/new/ https://reviews.llvm.org/D60120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

rnk added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:1691 } else { -// Build new lvalue for temp address +// Build new lvalue for temp address. Address Ptr = Atomics.materializeRValue(OldRVal); I don't have an issue with these

[PATCH] D60018: [codeview] Remove Type member from CVRecord

This revision was automatically updated to reflect the committed changes. Closed by commit rLLD357658: [codeview] Remove Type member from CVRecord (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D60018?vs=193526=193633#toc Repository: rLLD LLVM Linker

r357667 - Revert r357452 - 'SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)'

Author: dlj Date: Wed Apr 3 19:27:57 2019 New Revision: 357667 URL: http://llvm.org/viewvc/llvm-project?rev=357667=rev Log: Revert r357452 - 'SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)' This revision causes tests to fail under ASAN.

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:145 + +diag(MatchedDecl->getBeginLoc(), "use dyn_cast_or_null") +<<

[PATCH] D60238: Verify that Android targets generate DWARF 4 by default.

srhines created this revision. srhines added a reviewer: aprantl. Herald added a project: clang. Herald added a subscriber: cfe-commits. srhines added subscribers: pirama, chh. In the future, Android releases will support DWARF 5, but we need to ensure that older targets only have DWARF 4

[PATCH] D60238: Verify that Android targets generate DWARF 4 by default.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60238/new/ https://reviews.llvm.org/D60238

[libunwind] r357671 - [libunwind] Export the weak alias in Mach-O

Author: phosek Date: Wed Apr 3 20:36:35 2019 New Revision: 357671 URL: http://llvm.org/viewvc/llvm-project?rev=357671=rev Log: [libunwind] Export the weak alias in Mach-O This is not necessary for ELF since .globl and .weak are mutually exclusive, but is necessary for Mach-O otherwise the

[PATCH] D60236: add periods

akhuang created this revision. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. emit metadata for __declspec(allocator) add tests for heapallocsite metadata Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60236 Files: clang/lib/CodeGen/CGAtomic.cpp

[PATCH] D60247: Make SourceManager::createFileID(UnownedTag, ...) take a const llvm::MemoryBuffer*

thakis created this revision. thakis added a reviewer: rnk. Herald added subscribers: llvm-commits, arphaman. Herald added a project: LLVM. Requires making the llvm::MemoryBuffer* stored by SourceManager const, which in turn requires making the accessors for that return const

[PATCH] D59987: Add support for detection of devtoolset-8

tstellar added a comment. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59987/new/ https://reviews.llvm.org/D59987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21 -typedef llvm::SmallSet HeaderFileExtensionsSet; +using

r357579 - Fixing a typo; NFC.

Author: aaronballman Date: Wed Apr 3 06:37:56 2019 New Revision: 357579 URL: http://llvm.org/viewvc/llvm-project?rev=357579=rev Log: Fixing a typo; NFC. Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h Modified:

[PATCH] D59646: [PR40778][PR41157][OpenCL] Prevent implicit initialization of local address space objects

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59646/new/ https://reviews.llvm.org/D59646 ___ cfe-commits mailing list

[PATCH] D59988: [PR41276] Generate address space cast of 'this' for objects attributed by an address space in C++

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59988/new/ https://reviews.llvm.org/D59988 ___ cfe-commits mailing list

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir added a reviewer: ioeric. Currently clang-format would always emit a replacement for multi-block #include sections if `IBS_Regroup`, even if the sections are correct: % cat ~/test.h

[clang-tools-extra] r357582 - [clang-tidy] Remove the old ClangTidyCheck::registerPPCallbacks method

Author: alexfh Date: Wed Apr 3 07:03:43 2019 New Revision: 357582 URL: http://llvm.org/viewvc/llvm-project?rev=357582=rev Log: [clang-tidy] Remove the old ClangTidyCheck::registerPPCallbacks method Summary: All in-tree clang-tidy checks have been migrated to the new

[PATCH] D60197: [clang-tidy] Remove the old ClangTidyCheck::registerPPCallbacks method

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE357582: [clang-tidy] Remove the old ClangTidyCheck::registerPPCallbacks method (authored by alexfh, committed by ). Changed prior to commit: https://reviews.llvm.org/D60197?vs=193481=193486#toc

[PATCH] D60139: [clang-tidy] Add misc-placement-new-target-size check

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/misc-placement-new-target-size.rst:5 +== + + Eugene.Zelenko wrote: > Unnecessary empty line. Somehow empty line is still there. CHANGES SINCE LAST ACTION

[clang-tools-extra] r357574 - gn build: Add build files for clangd xpc framework code

Author: nico Date: Wed Apr 3 05:33:19 2019 New Revision: 357574 URL: http://llvm.org/viewvc/llvm-project?rev=357574=rev Log: gn build: Add build files for clangd xpc framework code This is a bit of a larger change since this is the first (and as far as I can tell only) place where the LLVM

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:145 + +diag(MatchedDecl->getBeginLoc(), "use dyn_cast_or_null") +<< FixItHint::CreateReplacement(SourceRange(MatchedDecl->getBeginLoc(),

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

This revision was automatically updated to reflect the committed changes. Closed by commit rC357576: [LibTooling] Add Transformer, a library for source-to-source transformations. (authored by ymandel, committed by ). Changed prior to commit: https://reviews.llvm.org/D59376?vs=193306=193480#toc

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. The change looks fine, but I don't understand the description of this revision. Could you clarify which checkers you're talking about and which bug you observe? Repository: rG LLVM Github

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

alexfh added a comment. Can you verify that the add_new_check.py script works fine with this new module? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59963/new/ https://reviews.llvm.org/D59963

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/SuperSelfCheck.cpp:112 + << Message->getMethodDecl() + << FixItHint::CreateReplacement(Message->getSourceRange(), + StringRef("[super init]"));

[PATCH] D60130: gn build: Add build files for clangd xpc framework code

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE357574: gn build: Add build files for clangd xpc framework code (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit:

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:18 + +AST_MATCHER(Expr, isMacroID) { return Node.getExprLoc().isMacroID(); } +} // namespace ast_matchers hintonda wrote: > @aaron.ballman: This

[PATCH] D59646: [PR40778][PR41157][OpenCL] Prevent implicit initialization of local address space objects

Anastasia updated this revision to Diff 193474. Anastasia added a comment. Improved comment about initializers in __local addr space. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59646/new/ https://reviews.llvm.org/D59646 Files: lib/Sema/SemaDecl.cpp

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:293 bit Negated = negated; + string CustomCode = customCode; } I think the type here should be `code` instead of `string` since the user is passing in code snippets, no?

r357576 - [LibTooling] Add Transformer, a library for source-to-source transformations.

Author: ymandel Date: Wed Apr 3 06:05:19 2019 New Revision: 357576 URL: http://llvm.org/viewvc/llvm-project?rev=357576=rev Log: [LibTooling] Add Transformer, a library for source-to-source transformations. Summary: Adds a basic version of Transformer, a library supporting the concise

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3711 + EventList = EventList->getType()->isIntegerTy() + ? Builder.CreateIntToPtr(EventList, EventPtrTy) + :

[PATCH] D60183: Fix typos in tests. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357577: Fix typos in tests. NFC. (authored by Higuoxing, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D60183?vs=193439=193482#toc Repository:

[PATCH] D60197: [clang-tidy] Remove the old ClangTidyCheck::registerPPCallbacks method

alexfh created this revision. alexfh added reviewers: sammccall, hokein. Herald added subscribers: kadircet, arphaman, jkorous, xazax.hun. Herald added a project: clang. All in-tree clang-tidy checks have been migrated to the new ClangTidyCheck::registerPPCallbacks method. Time to drop the old

[PATCH] D59985: Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3711 + EventList = EventList->getType()->isIntegerTy() + ? Builder.CreateIntToPtr(EventList, EventPtrTy) + :

r357577 - Fix typos in tests. NFC.

Author: higuoxing Date: Wed Apr 3 06:15:09 2019 New Revision: 357577 URL: http://llvm.org/viewvc/llvm-project?rev=357577=rev Log: Fix typos in tests. NFC. Reviewers: Higuoxing Reviewed By: Higuoxing Subscribers: kubamracek, cfe-commits, #sanitizers, llvm-commits Tags: #clang, #sanitizers,

<    1   2