[PATCH] D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

gribozavr accepted this revision. gribozavr added a comment. Thanks for the fix! Comment at: test/Analysis/cxx-uninitialized-object.cpp:1145 + +void entry() { + MyAtomicInt b; `c11atomicTest()` Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D61118: [MinGW] Fix dllexport of explicit template instantiation

smeenai added a comment. LGTM, though I'd wait for Hans and/or Reid too. I like the GCC/MinGW behavior here much more than the MSVC behavior. Having to mark the definitions only in the explicit instantiations case (for MSVC) whereas everything else requires you to mark the declarations is a

r359172 - [NFC] test commit removing excess line

Author: nik Date: Thu Apr 25 01:14:39 2019 New Revision: 359172 URL: http://llvm.org/viewvc/llvm-project?rev=359172=rev Log: [NFC] test commit removing excess line Modified: cfe/trunk/tools/libclang/CIndex.cpp Modified: cfe/trunk/tools/libclang/CIndex.cpp URL:

[PATCH] D61120: [clangd] Optimize "don't include me" check.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. llvm::Regex is really slow, and regex evaluation during preamble indexing was showing up as 25% on a profile of

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre updated this revision to Diff 196591. Pierre marked 10 inline comments as done. Pierre added a comment. In this new patch: - Documentation has been added - The multiclasses in OpenCLBuiltins.td filehave been slighly changed to have a more generic way to generate function prototypes - In

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre added a comment. Other comments: 1- When a header file is included, its function declarations are decorated with the "nounwind" attribute, meaning that the function is not supposed to throw an exception. This decorator is currently not added with the new mechanism. The "readnone"

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

sammccall accepted this revision. sammccall added inline comments. Comment at: llvm/lib/Testing/Support/Annotations.cpp:94 +const llvm::Annotations::Range ) { + return O << llvm::formatv("[{0}, {1})", R.Begin, R.End); +} You

[PATCH] D61122: [clangd] Don't build clangd or run its tests when LLVM_ENABLE_THREADS is off, unless specifically directed to do so

sammccall created this revision. sammccall added reviewers: thakis, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, mgorny. Herald added a project: clang. Introduce a new CLANGD_BUILD option, only default to true if threads are on. (the name doesn't

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

ilya-biryukov updated this revision to Diff 196599. ilya-biryukov added a comment. - Added a death test for error conditions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59814/new/ https://reviews.llvm.org/D59814 Files:

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

This revision was automatically updated to reflect the committed changes. Closed by commit rL359179: [Testing] Move clangd::Annotations to llvm testing support (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D59814?vs=196599=196602#toc Repository:

[PATCH] D60764: Add clang cc1 option to generate OpenCL builtin functions

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60764/new/ https://reviews.llvm.org/D60764 ___ cfe-commits mailing

[PATCH] D61118: [MinGW] Fix dllexport of explicit template instantiation

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61118/new/ https://reviews.llvm.org/D61118 ___

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Rakete added a comment. Thanks for working on this! :) Comment at: clang/lib/Parse/ParseDecl.cpp:3533 + if (ExplicitExpr.isInvalid()) { +Diag(ParenLoc, diag::note_explicit_bool_breaking_change_cxx2a) +<< FixItHint::CreateReplacement(

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro marked 2 inline comments as done. djtodoro added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3402 +CmdArgs.push_back("-femit-param-entry-values"); + RenderDebugInfoCompressionArgs(Args, CmdArgs, D, TC); probinson wrote: > If this

[clang-tools-extra] r359179 - [Testing] Move clangd::Annotations to llvm testing support

Author: ibiryukov Date: Thu Apr 25 03:08:31 2019 New Revision: 359179 URL: http://llvm.org/viewvc/llvm-project?rev=359179=rev Log: [Testing] Move clangd::Annotations to llvm testing support Summary: Annotations allow writing nice-looking unit test code when one needs access to locations from the

r359179 - [Testing] Move clangd::Annotations to llvm testing support

Author: ibiryukov Date: Thu Apr 25 03:08:31 2019 New Revision: 359179 URL: http://llvm.org/viewvc/llvm-project?rev=359179=rev Log: [Testing] Move clangd::Annotations to llvm testing support Summary: Annotations allow writing nice-looking unit test code when one needs access to locations from the

[PATCH] D61118: [MinGW] Fix dllexport of explicit template instantiation

mstorsjo created this revision. mstorsjo added reviewers: rnk, hans, smeenai. Herald added a project: clang. Contrary to MSVC, GCC/MinGW needs to have the dllexport attribute on the template instantiation declaration, not on the definition. Previously clang never marked explicit template

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

ilya-biryukov updated this revision to Diff 196592. ilya-biryukov added a comment. - Add simple tests - Add equality and stream output operators for Range Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59814/new/ https://reviews.llvm.org/D59814

[PATCH] D61121: [Windows] Separate elements in -print-search-dirs with semicolons

mstorsjo created this revision. mstorsjo added reviewers: rnk, hans, smeenai, thakis. Herald added a project: clang. Path lists on windows should always be separated by semicolons, not colons. Reuse llvm::sys::EnvPathSeparator for this purpose (as that's also a path list that is separated in

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 196595. djtodoro marked an inline comment as done. djtodoro edited the summary of this revision. djtodoro added a comment. -Remove unneeded code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files:

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1477761 , @jakehehrlich wrote: > In D60974#1477690 , @compnerd wrote: > > > @jakehehrlich - when do you expect to have your idea put up? I don't think > > that it is fair to

[PATCH] D60764: Add clang cc1 option to generate OpenCL builtin functions

Pierre updated this revision to Diff 196590. Pierre added a comment. Forgot to update one argument CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60764/new/ https://reviews.llvm.org/D60764 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/CC1Options.td

[PATCH] D61120: [clangd] Optimize "don't include me" check.

sammccall added inline comments. Comment at: clangd/index/SymbolCollector.cpp:669 +return false; + return Line.contains_lower("includ"); +} ilya-biryukov wrote: > A typo? Should it be `include`. it's meant to match "include" or "including". I'll add a

[PATCH] D61015: [LibTooing] Change Transformer's TextGenerator to a partial function.

ilya-biryukov added a comment. Why would we consider this a legitimate failure, rather than a programming error? Same argument could be made about any form of format-string-like functions, e.g. `llvm::formatv` or `sprintf`. Yet, they return strings and not `Expected` or their equivalent.

[PATCH] D61120: [clangd] Optimize "don't include me" check.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM (see the comment about a typo, though) Comment at: clangd/index/SymbolCollector.cpp:669 +return false; + return Line.contains_lower("includ"); +}

[PATCH] D61122: [clangd] Don't build clangd or run its tests when LLVM_ENABLE_THREADS is off, unless specifically directed to do so

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. A better name could definitely be nice, e.g. `BUILD_CLANGD` would've been much nicer. But the current one is also okayish, being consistent with existing names is a good reason

[PATCH] D61120: [clangd] Optimize "don't include me" check.

ilya-biryukov added inline comments. Comment at: clangd/index/SymbolCollector.cpp:669 +return false; + return Line.contains_lower("includ"); +} sammccall wrote: > ilya-biryukov wrote: > > A typo? Should it be `include`. > it's meant to match "include" or

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

javed.absar marked an inline comment as done. javed.absar added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:7129-7131 +// Although it is possible to supply a different return +// address (first arg) to this intrinsic, for now we set +// return address same

[PATCH] D60925: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden

Szelethus added a comment. I plan to do the same for non-checker and checker options too. I'll leave this up for just a little while to give people time to object. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60925/new/ https://reviews.llvm.org/D60925

[PATCH] D61077: [clangd] Query index in code completion no-compile mode.

kadircet added inline comments. Comment at: clangd/SourceCode.cpp:503 +case tok::l_brace: + if (State == NamespaceName) { +// Parsed: namespace { I believe it is safe to ignore(just mark the opening brace) anonymous namespaces here. Since

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

martong added a comment. In D60934#1475908 , @Tyker wrote: > Fixed issues form feedback by @martong Thank you for addressing the comments. `ASTImporter.cpp` and `ASTStructuralEquivalence.cpp` looks good to me now. However, about the equivalence check,

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

ilya-biryukov added inline comments. Comment at: clangd/Diagnostics.cpp:78 +// offsets when displaying that information to users. +Position toOneBased(Position P) { + ++P.line; Could we avoid introducing a function that breaks the invariant of a type? Having a

Re: r358490 - [AArch64] Implement Vector Funtion ABI name mangling.

Hi Russel, thanks for the report, will fix this problem. Best regards, Alexey Bataev 25 апр. 2019 г., в 7:24, Russell Gallop mailto:russell.gal...@gmail.com>> написал(а): Hi Alexey, The new test "declare_simd_aarch64_sve.c" intermittently fails when the git revision contains "a01".

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1074 + if (!RD->hasTrivialCopyAssignment()) +return true; + return false; Should this function also check for user-provided constructors? CHANGES SINCE LAST ACTION

Re: r358490 - [AArch64] Implement Vector Funtion ABI name mangling.

Hi Alexey, The new test "declare_simd_aarch64_sve.c" intermittently fails when the git revision contains "a01". .../llvm/tools/clang/test/OpenMP/declare_simd_aarch64_sve.c:38:15: error: CHECK-NOT: excluded string found in input // CHECK-NOT: a01 ^ :75:102: note: found

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Nicola added inline comments. Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:140-144 +class RoundingModes { + list Modes = !if(!or(_Ty1.HasRounding, _Ty2.HasRounding), + ["", "_rte", "_rtz", "_rtp", "_rtn"], + [""]); +}

[PATCH] D61126: [clangd] Also perform merging for symbol definitions

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. clangd currently prefers declarations from codegen files. This patch implements that behavior for definition

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/Background.h:113 + // Note that FileSymbols counts References by incrementing it per each file + // mentioning the symbol, including headers. This contradicts with the We should

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

sammccall added a comment. You may be interested in D60605 , which is a related idea (adding incremental format-and-indent-on-type to clangd). These are opposite extremes in some sense: this patch integrates deeply into clang-format and that patch entirely

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

ilya-biryukov added a comment. Input: int test() { }^ Expected: int test() { } ^ Actual: int test() {} ^ Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60605/new/ https://reviews.llvm.org/D60605

[PATCH] D61015: [LibTooing] Change Transformer's TextGenerator to a partial function.

ilya-biryukov added a comment. I'd argue it's the server's job to validate the inputs in that case. The code that landed so far clearly looks like a C++ DSL to describe transformations of the source. While it **can** be used a dependency in the server-side, I don't see why doing user-input

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre added a comment. I also think we could reduce the size of the tables. To sum up how this is working right now: 1. The isOpenCLBuiltin(char* functionName) funcion is called to determine if a function is part of OpenCL builtin functions. If so, it returns its associated pair (index,

[PATCH] D61112: AMDGPU: Enable _Float16

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61112/new/ https://reviews.llvm.org/D61112 ___ cfe-commits mailing list

[PATCH] D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading

gtbercea updated this revision to Diff 196619. gtbercea added a comment. - Use macros. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60907/new/ https://reviews.llvm.org/D60907 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChains/Clang.cpp

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

yvvan added a comment. @sammccall Having a separate tool is nice because it allows the client to make it plugable. clang-format sometimes changes options quite significantly and it can be nice if you have a choice which version to pick, otherwise it might be unable to read the configuration

[PATCH] D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext

gribozavr added a comment. > The FIXME in tests is fixed now. ... so instead of deleting the test, could you change it to show the current, better diagnostic? Comment at: clang/include/clang/AST/ASTContext.h:818 + /// For every comment not attached to any decl check if it

[PATCH] D61015: [LibTooing] Change Transformer's TextGenerator to a partial function.

ymandel added a comment. In D61015#1478539 , @ilya-biryukov wrote: > Why would we consider this a legitimate failure, rather than a programming > error? > Same argument could be made about any form of format-string-like functions, > e.g.

[PATCH] D61112: AMDGPU: Enable _Float16

b-sumner added a comment. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61112/new/ https://reviews.llvm.org/D61112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r359193 - [OPENMP][AARCH64]Fix the test for declare simd, NFC.

Author: abataev Date: Thu Apr 25 07:04:37 2019 New Revision: 359193 URL: http://llvm.org/viewvc/llvm-project?rev=359193=rev Log: [OPENMP][AARCH64]Fix the test for declare simd, NFC. Renamed function a01 in the test to fix possible problems with the git hash match during testing. Modified:

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1074 + if (!RD->hasTrivialCopyAssignment()) +return true; + return false; richard.townsend.arm wrote: > Should this function also check for user-provided constructors?

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

ilya-biryukov added a comment. Another example: int test() { ^ } Expected: a newline was added. Actual: newline does not allow to be added. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60605/new/ https://reviews.llvm.org/D60605

[PATCH] D48292: use modern type trait implementations when available

ldionne added a comment. I think this broke the C++03 bots: http://green.lab.llvm.org/green/view/Libcxx/job/libc++%20and%20libc++abi%20trunk/CI_ARCH=64,CI_EXCEPTIONS=ON,CI_STD=c++03/103/consoleFull Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48292/new/

[PATCH] D61097: [Sema] Emit warning for visibility attribute on internal-linkage declaration

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:2619 + // Visibility attributes have no effect on symbols with internal linkage. + if (auto ND = dyn_cast(D)) { +if (!ND->isExternallyVisible()) {

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

probinson added a comment. I'm okay with the PS4-specific bits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60274/new/ https://reviews.llvm.org/D60274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61118: [MinGW] Fix dllexport of explicit template instantiation

mstorsjo updated this revision to Diff 196704. mstorsjo edited the summary of this revision. mstorsjo added a comment. Adjusted the patch to not warn if there is no previous declaration of the instantiation, allowing the dllexport attribute on the definition in that case. CHANGES SINCE LAST

[PATCH] D61121: [Windows] Separate elements in -print-search-dirs with semicolons

This revision was automatically updated to reflect the committed changes. Closed by commit rL359233: [Windows] Separate elements in -print-search-dirs with semicolons (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

gtbercea added a comment. In D60907#1479142 , @hfinkel wrote: > In D60907#1479118 , @gtbercea wrote: > > > Ping @hfinkel @tra > > > The last two comments in D47849 indicated >

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

gtbercea added a comment. In D60907#1479298 , @gtbercea wrote: > In D60907#1479142 , @hfinkel wrote: > > > In D60907#1479118 , @gtbercea > > wrote: > > > > > Ping @hfinkel

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

erik.pilkington added a comment. > but don't want to annotate each unused ObjC method parameters with > `__attribute__((unused))` or insert `(void)unused_param` into the body of the > method to silence the warning since, unlike C/C++ functions, it's not > possible to comment out the unused

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

gtbercea updated this revision to Diff 196725. gtbercea added a comment. - Update patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60907/new/ https://reviews.llvm.org/D60907 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChains/Clang.cpp

[PATCH] D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

Szelethus added a comment. In D61106#1479336 , @jfb wrote: > Have you checked what the C and C++ standards say about `_Atomic` / > `std::atomic` initialization, and how they should actually be initialized by > developers? No, I have not, I'll admit.

r359241 - [PGO] Fix buildbot failure in 359215

Author: xur Date: Thu Apr 25 14:16:41 2019 New Revision: 359241 URL: http://llvm.org/viewvc/llvm-project?rev=359241=rev Log: [PGO] Fix buildbot failure in 359215 Revert the part of changes in r359215 that failing in some platforms. I will re-enable them later. Modified:

[PATCH] D48292: use modern type trait implementations when available

rsmith added a comment. In D48292#1478617 , @ldionne wrote: > I think this broke the C++03 bots: > http://green.lab.llvm.org/green/view/Libcxx/job/libc++%20and%20libc++abi%20trunk/CI_ARCH=64,CI_EXCEPTIONS=ON,CI_STD=c++03/103/consoleFull Thanks, should

[PATCH] D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

This revision was automatically updated to reflect the committed changes. Closed by commit rC359230: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as… (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

r359230 - [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

Author: szelethus Date: Thu Apr 25 13:00:51 2019 New Revision: 359230 URL: http://llvm.org/viewvc/llvm-project?rev=359230=rev Log: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive https://bugs.llvm.org/show_bug.cgi?id=41590 For the following code snippet,

r359233 - [Windows] Separate elements in -print-search-dirs with semicolons

Author: mstorsjo Date: Thu Apr 25 13:03:20 2019 New Revision: 359233 URL: http://llvm.org/viewvc/llvm-project?rev=359233=rev Log: [Windows] Separate elements in -print-search-dirs with semicolons Path lists on windows should always be separated by semicolons, not colons. Reuse

r359235 - Skip type units/type uniquing when we know we're only emitting the type once (vtable-based emission when triggered by a strong vtable, with -fno-standalone-debug)

Author: dblaikie Date: Thu Apr 25 13:05:47 2019 New Revision: 359235 URL: http://llvm.org/viewvc/llvm-project?rev=359235=rev Log: Skip type units/type uniquing when we know we're only emitting the type once (vtable-based emission when triggered by a strong vtable, with -fno-standalone-debug)

[PATCH] D61079: Skip type units/type uniquing when we know we're only emitting the type once (vtable-based emission when triggered by a strong vtable, with -fno-standalone-debug)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC359235: Skip type units/type uniquing when we know were only emitting the type once… (authored by dblaikie, committed by

r359237 - [analyzer] Add FIXMEs for alpha.unix.cstring.OutOfBounds false positives.

Author: dergachev Date: Thu Apr 25 13:30:14 2019 New Revision: 359237 URL: http://llvm.org/viewvc/llvm-project?rev=359237=rev Log: [analyzer] Add FIXMEs for alpha.unix.cstring.OutOfBounds false positives. Caused by incorrect strlcat() modeling in r332303, cf.

[PATCH] D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

jfb added a comment. Have you checked what the C and C++ standards say about `_Atomic` / `std::atomic` initialization, and how they should actually be initialized by developers? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61106/new/

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

ahatanak created this revision. ahatanak added reviewers: erik.pilkington, rjmccall. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. The new warning `-Wunused-parameter-non-objc-method` works exactly the same as `-Wunused-parameter ` except for unused parameters

[PATCH] D61134: [Analyzer] Iterator Checkers - Do an early return after handling calls

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thx, this is safer! Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:566 const auto *InstCall = dyn_cast(); if

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

gtbercea added a comment. In D60907#1479142 , @hfinkel wrote: > In D60907#1479118 , @gtbercea wrote: > > > Ping @hfinkel @tra > > > The last two comments in D47849 indicated >

[PATCH] D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

Szelethus added a comment. Upon further investigation, this still seems to be okay. This is not a bug-finding checker, but rather a tool to enforce the idiom of every non-trivial object should be fully initialized after construction. From what I've seen, `ATOMIC_VAR_INIT` should be used here,

[PATCH] D61136: [Analyzer] IteratorChecker - Ensure end()>=begin() and refactor begin and end symbol creation

NoQ added a comment. Aha, yup, thx! Do you plan to centralize other code paths on which you conjure symbols? 'Cause i still believe that given that we now support C++ (our prvalues are now properly materialized) (most of the time), you should be able to remove support for symbol-like

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

rjmccall added a comment. Yeah, I tend to think we should just suppress this unconditionally in Objective-C. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61147/new/ https://reviews.llvm.org/D61147 ___ cfe-commits

[PATCH] D58033: Add option for emitting dbg info for call site parameters

vsk added a comment. I think a small extension to `test/CodeGenCXX/dbg-info-all-calls-described.cpp` for the 'Supported: DWARF4 + -femit_param_entry_values' case would be appropriate here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. There seems to be some confusion about the term "format" here. There's the YAML format but within that there are specific YAML formats. My proposal will be to have a specific YAML format that just isn't the one used by yaml2obj. YAML isn't the issue, it's the

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. As an example, .tbe and .tbd files use YAML but in a very specific well defined structure. yaml2obj also uses a specific format which is actually well defined, it just doesn't map on very well here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

erik.pilkington added a comment. > Yeah, I tend to think we should just suppress this unconditionally in > Objective-C. IMO this warning still makes sense for normal functions, or methods that are only declared in an @implementation. Adding a fix-it to cast to void in the function/method body

Re: r359067 - [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

On Wed, 24 Apr 2019 at 19:28, Eric Fiselier via cfe-commits wrote: > Do I just edit the HTML file directly? > Or is it generated by something? Just edit the HTML file directly. > On Wed, Apr 24, 2019 at 3:35 PM Richard Smith wrote: >> >> Thanks! Can you update cxx_status.html to mark P0595R2

[PATCH] D59725: Additions to creduce script

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: cfe/trunk/utils/creduce-clang-crash.py:185 +for msg in self.expected_output: + output += 'grep %s t.log || exit 1\n' % pipes.quote(msg) + lebedev.ri wrote: > akhuang

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus added a comment. Ping^3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. Ping^3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

NoQ added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:4684 + if (size() <= 3) +return true; + Szelethus wrote: > What are the cases for the size being 2 or 1? Empty function? Is a size of 1 > even possible? Can we enforce something here with

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

NoQ updated this revision to Diff 196733. NoQ marked 4 inline comments as done. NoQ added a comment. Fxd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61051/new/ https://reviews.llvm.org/D61051 Files: clang/include/clang/Analysis/CFG.h

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

rjmccall added a comment. Sorry, yes, I meant in Objective-C methods, of course, not unconditionally even in C-like code whenever Objective-C is enabled. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61147/new/ https://reviews.llvm.org/D61147

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

TomTan added a comment. In D60349#140 , @TomTan wrote: > In D60349#1477183 , @efriedma wrote: > > > > For NotPod, it is aggregate which is specific in the document > > > > Yes, it's an aggregate which is

r359248 - [CUDA] Implemented _[bi]mma* builtins.

Author: tra Date: Thu Apr 25 15:28:09 2019 New Revision: 359248 URL: http://llvm.org/viewvc/llvm-project?rev=359248=rev Log: [CUDA] Implemented _[bi]mma* builtins. These builtins provide access to the new integer and sub-integer variants of MMA (matrix multiply-accumulate) instructions provided

[PATCH] D60279: [CUDA] Implemented _[bi]mma* builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359248: [CUDA] Implemented _[bi]mma* builtins. (authored by tra, committed by ). Herald added a subscriber: kristina. Herald added a project: clang. Changed prior to commit:

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

ahatanak added a comment. In D61147#1479468 , @erik.pilkington wrote: > > Yeah, I tend to think we should just suppress this unconditionally in > > Objective-C. > > IMO this warning still makes sense for normal functions, or methods that are > only

[PATCH] D61147: [Sema][ObjC] Add a flavor of -Wunused-parameter that doesn't diagnose unused parameters of ObjC methods

erik.pilkington added a comment. In D61147#1479530 , @ahatanak wrote: > In D61147#1479468 , @erik.pilkington > wrote: > > > > Yeah, I tend to think we should just suppress this unconditionally in > > >

[PATCH] D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

a_sidorin added a comment. Hello Shafik! The patch itself is fine, but, as other reviewers pointed, tests are appreciated. I suggest to add a test into ASTImporterTests.cpp - you will find several ways to write tests of different complexity here. I think this change can be tested even with the

[PATCH] D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext

jkorous marked 5 inline comments as done. jkorous added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:494 + // Explicitly not calling ExternalSource->ReadComments() as we're not + // interested in those. + ArrayRef RawComments = Comments.getComments();

[PATCH] D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext

jkorous updated this revision to Diff 196744. jkorous added a comment. - clang-format - comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61103/new/ https://reviews.llvm.org/D61103 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp

[PATCH] D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext

jkorous added a comment. Also, IIUC the test case that I deleted wasn't actually supposed to produce any diagnostics and the fact that it did was a bug. We could keep it as a regression test but I think it has a rather low value. WDYT? CHANGES SINCE LAST ACTION

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Some cleanups and simplifications, but LGTM with those applied. Thank you! Comment at: docs/LanguageExtensions.rst:2335 + +When the

[PATCH] D61015: [LibTooing] Change Transformer's TextGenerator to a partial function.

ymandel added a comment. In D61015#1478586 , @ilya-biryukov wrote: > I'd argue it's the server's job to validate the inputs in that case. > > The code that landed so far clearly looks like a C++ DSL to describe > transformations of the source. While it

r359200 - [OPENMP] Improved check for the linear dependency in the non-rectangular

Author: abataev Date: Thu Apr 25 09:21:13 2019 New Revision: 359200 URL: http://llvm.org/viewvc/llvm-project?rev=359200=rev Log: [OPENMP] Improved check for the linear dependency in the non-rectangular loop nests. Added a checks that the initializer/condition expressions depend only only of the

r359212 - Fix bug 37903:MS ABI: handle inline static data member and inline variable as template static data member

Author: jyu2 Date: Thu Apr 25 10:45:45 2019 New Revision: 359212 URL: http://llvm.org/viewvc/llvm-project?rev=359212=rev Log: Fix bug 37903:MS ABI: handle inline static data member and inline variable as template static data member Added:

  1   2   >