[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

2019-04-28 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan added a comment. Could you please also upload diff with the full context? It's -U for git and quite similar for svn. Otherwise looks ok. Comment at: test/Index/print-type.c:70 // CHECK: TypeRef=struct Struct:16:8 [type=struct Struct] [typekind=Record] [isPOD=1]

r359393 - [PowerPC][Clang] Add tests for PowerPC MMX intrinsics

2019-04-28 Thread Qiu Chaofan via cfe-commits
Author: chaofan Date: Sat Apr 27 23:27:33 2019 New Revision: 359393 URL: http://llvm.org/viewvc/llvm-project?rev=359393=rev Log: [PowerPC][Clang] Add tests for PowerPC MMX intrinsics Add the rest of test cases covering functions defined in mmintrin.h on PowerPC. Reviewed By: Jinsong Ji

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

2019-04-28 Thread Jorn Vernee via Phabricator via cfe-commits
JornVernee created this revision. JornVernee added reviewers: akyrtzi, aaron.ballman, rsmith. JornVernee added a project: clang. Herald added subscribers: arphaman, dexonsmith. Currently, looking up the offset of a field in a type with an incomplete array, using `clang_Type_getOffsetOf` always

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

2019-04-28 Thread Jorn Vernee via Phabricator via cfe-commits
JornVernee updated this revision to Diff 197024. JornVernee added a comment. Fixed the similar problem with `clang_Type_getAlignOf` since the patch is pretty small any ways. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61239/new/ https://reviews.llvm.org/D61239 Files:

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

2019-04-28 Thread Mateusz Maćkowski via Phabricator via cfe-commits
m4tx updated this revision to Diff 197025. m4tx added a comment. Updated per @aaron.ballman comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55793/new/ https://reviews.llvm.org/D55793 Files: 0001-clang-tidy-Add-duplicated-access-specifier-readabili.patch

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

2019-04-28 Thread Jorn Vernee via Phabricator via cfe-commits
JornVernee updated this revision to Diff 197018. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232 Files: include/clang-c/Index.h test/Index/print-type.c tools/c-index-test/c-index-test.c tools/libclang/CXType.cpp Index:

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

2019-04-28 Thread Tamás Zolnai via Phabricator via cfe-commits
ztamas updated this revision to Diff 197014. ztamas added a comment. Better handling of template and non-template self-copy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60507/new/ https://reviews.llvm.org/D60507 Files:

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

2019-04-28 Thread Mateusz Maćkowski via Phabricator via cfe-commits
m4tx marked 15 inline comments as done. m4tx added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantAccessSpecifiersCheck.cpp:35-36 + for (DeclContext::specific_decl_iterator + AS(MatchedDecl->decls_begin()), +

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

2019-04-28 Thread Jorn Vernee via Phabricator via cfe-commits
JornVernee updated this revision to Diff 197019. JornVernee marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232 Files: include/clang-c/Index.h test/Index/print-type.c tools/c-index-test/c-index-test.c

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

2019-04-28 Thread Mateusz Maćkowski via Phabricator via cfe-commits
m4tx updated this revision to Diff 197028. m4tx marked 5 inline comments as done. m4tx added a comment. Remove the accidentally added patch file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55793/new/ https://reviews.llvm.org/D55793 Files:

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

2019-04-28 Thread Jorn Vernee via Phabricator via cfe-commits
JornVernee marked an inline comment as done. JornVernee added a comment. No worries! I'm already glad there's someone who picked up the review for this so quickly ;) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232

[PATCH] D61246: [analyzer][UninitializedObjectChecker] PR41611: Regard vector types as primitive

2019-04-28 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, xazax.hun, rnkovacs, baloghadamsoftware, Charusso, alexfh, gribozavr. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, jfb, mikhail.ramalho, a.sidorin, szepet,

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

2019-04-28 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan added a comment. Thank you! Sorry that I forgot about the required minor version increment. I will run tests tomorrow and then I can commit it for you. Comment at: include/clang-c/Index.h:35 #define CINDEX_VERSION_MAJOR 0 #define CINDEX_VERSION_MINOR 55

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

2019-04-28 Thread Jorn Vernee via Phabricator via cfe-commits
JornVernee updated this revision to Diff 197038. JornVernee added a comment. Incremented minor version CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61232/new/ https://reviews.llvm.org/D61232 Files: include/clang-c/Index.h test/Index/print-type.c

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

2019-04-28 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 197040. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60953/new/ https://reviews.llvm.org/D60953 Files:

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

2019-04-28 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:395 + DiagLevel != DiagnosticsEngine::Fatal && + LineIsMarkedWithNOLINTinMacro(Info.getSourceManager(), +

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

2019-04-28 Thread Tyker via Phabricator via cfe-commits
Tyker marked an inline comment as done. Tyker added a comment. Fixed based on Feedback from @rsmith @martong @Rakete. feedback that weren't fixed have comment explaining why. Comment at: clang/include/clang/AST/DeclCXX.h:2033 + + void

[PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

2019-04-28 Thread Ian Sunamura via Phabricator via cfe-commits
kent08ian added a comment. In D10833#1366117 , @schroedersi wrote: > Ping. It would indeed be very helpful to have information about the kind of > an operator :-) Any updates on this? Repository: rC Clang CHANGES SINCE LAST ACTION