[PATCH] D61545: [analyzer] Fix a crash in RVO from within blocks.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I think the entire `LocationContext` stuff is a huge design issue, and you used its functionality without any hack. If you would rename the `getStackFrame` to `getNextStackFrame` or

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

rsmith accepted this revision. rsmith marked an inline comment as done. rsmith added a comment. This revision is now accepted and ready to land. Thank you, please go ahead and land this! (We'll need to parse and handle //requires-clause//s here too, but that can wait for another patch.) (Please

r359964 - [c++20] Implement tweaked __VA_OPT__ rules from P1042R1:

Author: rsmith Date: Fri May 3 23:46:18 2019 New Revision: 359964 URL: http://llvm.org/viewvc/llvm-project?rev=359964=rev Log: [c++20] Implement tweaked __VA_OPT__ rules from P1042R1: * __VA_OPT__ is expanded if the *expanded* __VA_ARGS__ is non-empty, not if the original argument contained

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:274 + + if (F->getLocation().isInvalid()) +return; aaron.ballman wrote: > bernhardmgruber wrote: > > aaron.ballman wrote: > > > bernhardmgruber wrote: > >

[PATCH] D61424: [ASTImporter] Fix inequivalence of unresolved exception spec

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Looks good! Comment at: clang/lib/AST/ASTImporter.cpp:3107 +// noexcept-unevaluated, while the newly imported function may have an +// evaluated noexcept. }

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land.  Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:277 merger.RemoveSources(importer_source); - return ret; + if (ret_or_error)

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete updated this revision to Diff 198142. Rakete added a comment. friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36357/new/ https://reviews.llvm.org/D36357 Files: clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D61549: Fix use of 'is' operator for comparison

tambre created this revision. tambre added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. The 'is' operator is not meant to be used for comparisons. It currently working is an implementation detail of CPython. CPython 3.8 has added a SyntaxWarning for

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hello Gabor! This looks good to me, but let's wait for LLDB guys to take a look at the patch. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker created this revision. Tyker added a reviewer: klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. Changes: - add an ast matcher for deductiong guide. - allow isExplicit matcher for deductiong guide. - add hasExplicitSpecifier matcher which matches for

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

sgraenitz added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:1980 + } + return *type_or_error; } >>! In D61438#1490102, @jingham wrote: > [...] include the contents of that error n the log message? e.g: ``` if

[PATCH] D59692: [ASTImporter] Fix name conflict handling

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59692/new/ https://reviews.llvm.org/D59692

r359968 - [NFC] Add parentheses to avoid -Wparentheses.

Author: rakete Date: Sat May 4 04:28:11 2019 New Revision: 359968 URL: http://llvm.org/viewvc/llvm-project?rev=359968=rev Log: [NFC] Add parentheses to avoid -Wparentheses. Modified: cfe/trunk/lib/Parse/ParseDecl.cpp Modified: cfe/trunk/lib/Parse/ParseDecl.cpp URL:

[PATCH] D58573: [analyzer] Move UninitializedObjectChecker out of alpha

gribozavr added a comment. Thank you for the fixes! Another crash: https://bugs.llvm.org/show_bug.cgi?id=41741 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573 ___

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete updated this revision to Diff 198139. Rakete added a comment. Don't leak memory and friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files:

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber updated this revision to Diff 198143. bernhardmgruber marked 9 inline comments as done. bernhardmgruber added a comment. It took a long while to figure out how to handle certain macro cases. Here is what I came up with: When tokenizing the source code from the beginning of the

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall updated this revision to Diff 198129. sammccall added a comment. Tune magic numbers Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61537/new/ https://reviews.llvm.org/D61537 Files: clangd/CodeComplete.cpp clangd/FindSymbols.cpp

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rL359967: [c++20] Implement P0428R2 - Familiar template syntax for generic lambdas (authored by hamzasood, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r359967 - [c++20] Implement P0428R2 - Familiar template syntax for generic lambdas

Author: hamzasood Date: Sat May 4 03:49:46 2019 New Revision: 359967 URL: http://llvm.org/viewvc/llvm-project?rev=359967=rev Log: [c++20] Implement P0428R2 - Familiar template syntax for generic lambdas Differential Revision: https://reviews.llvm.org/D36527 Added:

[PATCH] D61464: [RiscV] Typo in register aliases

JohnLLVM added a comment. What should I do now? I do not have rights to commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61464/new/ https://reviews.llvm.org/D61464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r359960 - Reduce amount of work ODR hashing does.

Does the ODR hashing have some sort of cycle breaking infrastructure - so that if the same type is seen more than once (eg: classes have members that have pointers back to the outer class type, etc) they don't cause indefinite cycles? Should that infrastructure have caught these cases & avoided

[PATCH] D40381: Parse concept definition

saar.raz added a comment. @rsmith are we done with CR on this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40381/new/ https://reviews.llvm.org/D40381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

jdoerfert added a comment. Alexey, is this is good to go now? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61399/new/ https://reviews.llvm.org/D61399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

rsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1784 bool IsClassTemplateDeductionContext = true, + bool AllowImplicitTypename = false, IdentifierInfo **CorrectedII = nullptr);

[PATCH] D40381: Parse concept definition

rsmith accepted this revision. rsmith added a comment. LGTM with a few mechanical updates. Comment at: include/clang/Basic/DiagnosticParseKinds.td:1262 + "name defined in concept definition must be an identifier">; +def err_concept_legacy_bool_keyword : ExtWarn< + "ISO C++2a

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Some minor nits, please feel free to commit once they're addressed. In D36357#1177852 , @Rakete wrote: > Note that clang doesn't support

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 198152. plotfi added a comment. Herald added subscribers: llvm-commits, MaskRay, hiraditya, arichardson, emaste. Herald added a reviewer: espindola. Herald added a project: LLVM. Adding support for multiple formats using -interface-stubs-version=. I'll add

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

rsmith added a comment. This seems reasonable to me, but I'll leave it to @klimek or someone else to judge whether the `isExplicit` / `hasExplicitSpecifier` approach is the right way to expose this functionality to matcher users. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 198157. plotfi added a comment. Changing experimental flag to -interface-stubs-version=experimental-ifo-elf-v1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files:

[PATCH] D61559: Fix the crash when formatting unsupported encodings

owenpan created this revision. owenpan added reviewers: klimek, djasper, sammccall, MyDeveloperDay, krasimir. owenpan added a project: clang. Herald added a subscriber: cfe-commits. See PR33946 . Repository: rC Clang

[PATCH] D61508: [clang-tidy] misc-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 198146. trixirt edited the summary of this revision. trixirt added a comment. Addressed issue with returning early and using backtick in doc. Since misc-header-guard doc was a cut-n-paste of llvm-header-guard, that and other similar docs were changed.