[PATCH] D61615: [COFF] Use COFF stubs for extern_weak functions

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, it's nice if this mechanism comes in handy in other cases than the one it was originally made for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rsmith added a comment. In D61165#1490417 , @erik.pilkington wrote: > In D61165#1490168 , @rjmccall wrote: > > > I think the intuitive rule is that initialization is complete when the > > full-expression

r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

Author: leonardchan Date: Mon May 6 20:20:17 2019 New Revision: 360109 URL: http://llvm.org/viewvc/llvm-project?rev=360109=rev Log: Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration" Updated with fix for read of uninitialized memory. Added:

[PATCH] D61464: [RiscV] Typo in register aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL360104: Fix typo in risc-v register aliases. (authored by echristo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r360104 - Fix typo in risc-v register aliases.

Author: echristo Date: Mon May 6 17:45:47 2019 New Revision: 360104 URL: http://llvm.org/viewvc/llvm-project?rev=360104=rev Log: Fix typo in risc-v register aliases. Patch by John. Differential Revision: https://reviews.llvm.org/D61464 Modified: cfe/trunk/lib/Basic/Targets/RISCV.cpp

[PATCH] D61365: [libcxx] [test] Suppress float->int narrowing warning in vector range-construction test.

BillyONeal marked an inline comment as done. BillyONeal added inline comments. Comment at: test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:159 float array[3] = {0.0f, 1.0f, 2.0f}; +#pragma warning(suppress: 4244) // narrowing float to int

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

vsapsai added a comment. Discussed with the team different approaches and suggesting https://reviews.llvm.org/D61621 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44387/new/ https://reviews.llvm.org/D44387 ___ cfe-commits mailing list

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

dexonsmith added a comment. In D61165#1492724 , @rjmccall wrote: > In D61165#1492582 , @erik.pilkington > wrote: > > > Duncan pointed out eel.is/c++draft/class.init#class.base.init-13, which > > appears to claim

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. In D61165#1492780 , @dexonsmith wrote: > In D61165#1492724 , @rjmccall wrote: > > > In D61165#1492582 , > > @erik.pilkington wrote: > > > > >

Re: r359960 - Reduce amount of work ODR hashing does.

On Mon, May 6, 2019 at 4:24 PM Richard Trieu wrote: > > There was no cycle for this crash. Oh, yeah, didn't mean to imply there were - but that a system designed to prevent cycles might also be used/help prevent redundant work like this. > What happened is that an exponential runtime is reduced

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. In D61165#1492582 , @erik.pilkington wrote: > Duncan pointed out eel.is/c++draft/class.init#class.base.init-13, which > appears to claim that initialization ends with the execution of the > constructor, excluding temporary

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. In D61165#1492781 , @rsmith wrote: > In D61165#1490417 , @erik.pilkington > wrote: > > > In D61165#1490168 , @rjmccall > > wrote: > > > > > I

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

rsmith reopened this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:373-374 + ExplicitSpecifier ES, FunctionDecl *New) { + if (!ES.getExpr() ||

[PATCH] D61545: [analyzer] Fix a crash in RVO from within blocks.

NoQ updated this revision to Diff 198342. NoQ added a comment. No, this is all wrong. We shouldn't unwrap to the parent stack frame here. We should end up exactly in the location context in which the call has happened. But we should still unwrap the block invocation context, as an exception,

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 198352. trixirt retitled this revision from "[clang-tidy] misc-header-guard : a simple version of llvm-header-guard" to "[clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard". trixirt added a comment. Move from misc to bugprone

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt added a comment. All of the real work is the header-guard checks is done by their common base class utils/HeaderGuard. The much smaller llvm and bugprone subclasses are only concerned with the style of the fix. My understanding of the directory layout guidance in the docs is that

[PATCH] D61617: [NewPassManager] Add tuning option: SLPVectorization [clang-change]

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Can you update some Clang IR generation test that uses these flags to run w/ the new PM? It should fail without this and pass with this. LGTM w/ that test updated. Repository: rC

[PATCH] D61591: [MinGW] Use SEH by default on AArch64

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61591/new/ https://reviews.llvm.org/D61591 ___ cfe-commits mailing

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D61601 Files:

[PATCH] D61592: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61592/new/ https://reviews.llvm.org/D61592 ___ cfe-commits mailing

r360073 - [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with

Author: abataev Date: Mon May 6 13:07:20 2019 New Revision: 360073 URL: http://llvm.org/viewvc/llvm-project?rev=360073=rev Log: [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with default(none). If the combined directive has default(none) clause and has clauses for inner directive

[PATCH] D61592: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW

This revision was automatically updated to reflect the committed changes. Closed by commit rC360082: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW (authored by mstorsjo, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61592/new/

r360082 - [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW

Author: mstorsjo Date: Mon May 6 14:19:07 2019 New Revision: 360082 URL: http://llvm.org/viewvc/llvm-project?rev=360082=rev Log: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW In MinGW, setjmp isn't expanded as a builtin in the compiler (like it is for MSVC), but manually hooked

[PATCH] D61591: [MinGW] Use SEH by default on AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rL360081: [MinGW] Use SEH by default on AArch64 (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58374/new/ https://reviews.llvm.org/D58374 ___

[PATCH] D61615: [COFF] Use COFF stubs for extern_weak functions

rnk updated this revision to Diff 198359. rnk added a comment. - fix some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61615/new/ https://reviews.llvm.org/D61615 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D61617: [NewPassManager] Add tuning option: SLPVectorization [clang-change]

asbirlea created this revision. asbirlea added a reviewer: chandlerc. Herald added subscribers: cfe-commits, jlebar. Herald added a project: clang. NewPassManager is not using CodeGenOpts values before this patch. [to be coupled with D61616 ] Repository: rC

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

dblaikie added inline comments. Comment at: lib/Sema/SemaType.cpp:4913-4916 +ExpectNoDerefChunk = false; + } + + ExpectNoDerefChunk = state.didParseNoDeref(); Pointed out in PR41774 there's a dead store to ExpectNoDerefChunk here. Should line

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:85-87 +if (TL.getQualifierLoc()) + if (!TraverseNestedNameSpecifierLoc(TL.getQualifierLoc())) +return false; You can combine these.

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington added a comment. Duncan pointed out eel.is/c++draft/class.init#class.base.init-13, which appears to claim that initialization ends with the execution of the constructor, excluding temporary destructors. > (13) In a non-delegating constructor, initialization proceeds in the >

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

smeenai added inline comments. Comment at: libunwind/src/CMakeLists.txt:160 if (LIBUNWIND_INSTALL_LIBRARY) - install(TARGETS ${LIBUNWIND_INSTALL_TARGETS} + if(libcxxabi IN_LIST LLVM_RUNTIME_DISTRIBUTION_COMPONENTS) +set(export_to_llvmruntimes EXPORT LLVMRuntimes)

[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

vsapsai created this revision. vsapsai added reviewers: craig.topper, GBuella. Herald added subscribers: dexonsmith, jkorous. vsapsai added a parent revision: D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.. Currently `immintrin.h` includes `pconfigintrin.h` and

[PATCH] D61620: [NewPassManager] Add tuning option: LoopUnrolling [clang-change]

chandlerc added a comment. Same comment as on other Clang patch -- let's update an IR generation test to reflect this? Should just be adding a RUN line. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61620/new/ https://reviews.llvm.org/D61620

r360100 - [Clang][NewPM] Don't bail out if the target machine is empty

Author: phosek Date: Mon May 6 16:24:17 2019 New Revision: 360100 URL: http://llvm.org/viewvc/llvm-project?rev=360100=rev Log: [Clang][NewPM] Don't bail out if the target machine is empty This matches the behavior of the old pass manager. There are some targets that don't have target machine at

r360063 - [OpenMP][Clang] Support for target math functions

Author: gbercea Date: Mon May 6 11:19:15 2019 New Revision: 360063 URL: http://llvm.org/viewvc/llvm-project?rev=360063=rev Log: [OpenMP][Clang] Support for target math functions Summary: In this patch we propose a temporary solution to resolving math functions for the NVPTX toolchain,

[PATCH] D33841: [clang-tidy] redundant keyword check

koldaniel marked an inline comment as done. koldaniel added inline comments. Comment at: test/clang-tidy/readability-redundant-extern.cpp:37 + +void another_file_scope(int _extern); aaron.ballman wrote: > koldaniel wrote: > > aaron.ballman wrote: > > > More

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

echristo added reviewers: saugustine, cmatthews. echristo added a comment. Adding Sterling and Chris to this to take a look at the new layout :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59168/new/ https://reviews.llvm.org/D59168 ___

[PATCH] D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.

vsapsai created this revision. vsapsai added reviewers: aaron.ballman, rsmith. Herald added subscribers: dexonsmith, jkorous, eraman. This can be used for better support of `-fno-gnu-inline-asm` builds. rdar://problem/49540880 https://reviews.llvm.org/D61619 Files:

[PATCH] D61620: [NewPassManager] Add tuning option: LoopUnrolling [clang-change]

asbirlea created this revision. asbirlea added a reviewer: chandlerc. Herald added subscribers: cfe-commits, dmgreen, jlebar. Herald added a project: clang. Use CodeGenOpts's setting for loop unrolling. [to be coupled with D61618 ] Repository: rC Clang

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

jdenny added a comment. Thanks for everyone's responses so far. At this point, I'm going to follow the uncontroversial suggestions from @lebedev.ri: create a `struct PragmaIntroducer`, and split the OpenMP work into a second patch. That will hopefully make it easier for @rsmith or others to

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan marked 2 inline comments as done. leonardchan added inline comments. Comment at: lib/Sema/SemaType.cpp:4913-4916 +ExpectNoDerefChunk = false; + } + + ExpectNoDerefChunk = state.didParseNoDeref(); dblaikie wrote: > Pointed out in

r360089 - [Sema] Fix for P41774 where `ExpectNoDerefChunk` is assigned twice

Author: leonardchan Date: Mon May 6 15:09:12 2019 New Revision: 360089 URL: http://llvm.org/viewvc/llvm-project?rev=360089=rev Log: [Sema] Fix for P41774 where `ExpectNoDerefChunk` is assigned twice Modified: cfe/trunk/lib/Sema/SemaType.cpp Modified: cfe/trunk/lib/Sema/SemaType.cpp URL:

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

phosek updated this revision to Diff 198347. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49587/new/ https://reviews.llvm.org/D49587 Files:

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

phosek added a comment. In D49587#1488328 , @smeenai wrote: > Seems like you got the wrong diff. It was the right diff but uploaded to a wrong change ;) In D49587#1484829 , @smeenai wrote: > Sorry, had missed

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel added a comment. Gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r360086 - Revert "Re-commit r357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)"

Author: rupprecht Date: Mon May 6 14:55:05 2019 New Revision: 360086 URL: http://llvm.org/viewvc/llvm-project?rev=360086=rev Log: Revert "Re-commit r357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)" This reverts r357452 (git commit

[PATCH] D61615: [COFF] Use COFF stubs for extern_weak functions

rnk created this revision. rnk added reviewers: smeenai, mstorsjo. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. A COFF stub indirects the reference to a symbol through memory. A .refptr.$sym global variable pointer is created to refer to $sym. Typically

Re: r359960 - Reduce amount of work ODR hashing does.

There was no cycle for this crash. What happened is that an exponential runtime is reduced to a linear runtime. Without this revision, ODR hashing would have worked if the machine had enough memory and the user waited long enough. void foo(int a, int b) {} When computing the ODR hash for

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

This revision was automatically updated to reflect the committed changes. Closed by commit rC360100: [Clang][NewPM] Dont bail out if the target machine is empty (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D58374?vs=188999=198367#toc Repository: rC

r360061 - [OPENMP]Fix PR41768: check DSA for globals with `default(none)` clauses.

Author: abataev Date: Mon May 6 10:49:22 2019 New Revision: 360061 URL: http://llvm.org/viewvc/llvm-project?rev=360061=rev Log: [OPENMP]Fix PR41768: check DSA for globals with `default(none)` clauses. If the `default(none)` was specified for the construct, we might miss diagnostic for the

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea updated this revision to Diff 198311. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61399/new/ https://reviews.llvm.org/D61399 Files: lib/Driver/ToolChains/Clang.cpp lib/Headers/CMakeLists.txt

[PATCH] D33841: [clang-tidy] redundant keyword check

aaron.ballman added inline comments. Comment at: test/clang-tidy/readability-redundant-extern.cpp:37 + +void another_file_scope(int _extern); koldaniel wrote: > aaron.ballman wrote: > > More tests that I figured out: > > ``` > > namespace { > > extern void f();

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

aaron.ballman added a comment. In D60507#1491095 , @ztamas wrote: > Ping. > Is it good to go or is there anything else I need to include in this patch? Sorry for the delay, I was gone for WG14 meetings last week, which made reviewing more involved

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Headers/__clang_cuda_cmath.h:444 using ::roundf; +#ifndef _OPENMP using ::scalblnf; ABataev wrote: > I see that the same guard is used >

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit. Comment at: lib/Headers/__clang_cuda_cmath.h:444 using ::roundf; +#ifndef _OPENMP using ::scalblnf; gtbercea wrote: > ABataev wrote: > >

[PATCH] D61508: [clang-tidy] misc-header-guard : a simple version of llvm-header-guard

aaron.ballman added a comment. In D61508#1491570 , @JonasToth wrote: > Hi trixirt and thanks for the patch! > > I would rather like to generalize the llvm check to allow different styles > and then alias the general version with different configurations.

Re: r360073 - [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with

Thank you! On Mon, May 6, 2019 at 11:05 PM Alexey Bataev via cfe-commits wrote: > > Author: abataev > Date: Mon May 6 13:07:20 2019 > New Revision: 360073 > > URL: http://llvm.org/viewvc/llvm-project?rev=360073=rev > Log: > [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with >

[PATCH] D59711: PR41183: Don't emit Wstrict-prototypes warning for an implicit function declaration.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360084: PR41183: Dont emit strict-prototypes warning for an implicit function (authored by jyknight, committed by ). Changed prior to commit: https://reviews.llvm.org/D59711?vs=191924=198341#toc

r360084 - PR41183: Don't emit strict-prototypes warning for an implicit function

Author: jyknight Date: Mon May 6 14:37:59 2019 New Revision: 360084 URL: http://llvm.org/viewvc/llvm-project?rev=360084=rev Log: PR41183: Don't emit strict-prototypes warning for an implicit function declaration. It should emit _only_ an implicit-function-declaration warning, not both of them.

Re: r360061 - [OPENMP]Fix PR41768: check DSA for globals with `default(none)` clauses.

Thank you! On Mon, May 6, 2019 at 8:46 PM Alexey Bataev via cfe-commits wrote: > > Author: abataev > Date: Mon May 6 10:49:22 2019 > New Revision: 360061 > > URL: http://llvm.org/viewvc/llvm-project?rev=360061=rev > Log: > [OPENMP]Fix PR41768: check DSA for globals with `default(none)` clauses.

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

This revision was automatically updated to reflect the committed changes. Closed by commit rC360063: [OpenMP][Clang] Support for target math functions (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61399?vs=198311=198314#toc Repository: rC Clang

[PATCH] D61260: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to structures)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61260/new/ https://reviews.llvm.org/D61260 ___ cfe-commits mailing

[PATCH] D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"

Quuxplusone added a comment. > We also need to mark this off in the status. I can do that in D58879 > or create a separate patch. Good catch! Either is fine with me but I bet a separate patch would be more appropriate. Repository: rCXX libc++ CHANGES

r360081 - [MinGW] Use SEH by default on AArch64

Author: mstorsjo Date: Mon May 6 14:19:01 2019 New Revision: 360081 URL: http://llvm.org/viewvc/llvm-project?rev=360081=rev Log: [MinGW] Use SEH by default on AArch64 The implementation of SEH is pretty mature at this point. Differential Revision: https://reviews.llvm.org/D61591 Modified:

[PATCH] D61519: [clangd] Support -fallback-style, similar to clang-format.

This revision was automatically updated to reflect the committed changes. Closed by commit rL360016: [clangd] Support -fallback-style, similar to clang-format. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D61508: [clang-tidy] misc-header-guard : a simple version of llvm-header-guard

JonasToth added a comment. Hi trixirt and thanks for the patch! I would rather like to generalize the llvm check to allow different styles and then alias the general version with different configurations. Introducing this code duplication does not sound like a good idea to me. The

[PATCH] D61559: Fix the crash when formatting unsupported encodings

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/tools/clang-format/ClangFormat.cpp:273 +.StartsWith("\xFF\xFE", "UTF-16 (LE)") +.StartsWith("\x2B\x2F\x76", "UTF-7") +

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro added a comment. @probinson @aprantl Thanks! @vsk Thanks for the comment! Sure, we will add that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 ___ cfe-commits mailing list

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. Ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. Ping^4 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus added a comment. Ping^4 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59465: [analyzer] Add a test plugin for checker option handling

Szelethus added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59465/new/ https://reviews.llvm.org/D59465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

lebedev.ri added a comment. In D61509#1491397 , @jdenny wrote: > In D61509#1491209 , @ABataev wrote: > > > In D61509#1491204 , @lebedev.ri > > wrote: > > > > > In

[PATCH] D61559: Fix the crash when formatting unsupported encodings

sammccall added a comment. You might want to add a test for one of these? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61559/new/ https://reviews.llvm.org/D61559 ___ cfe-commits mailing list

[clang-tools-extra] r360016 - [clangd] Support -fallback-style, similar to clang-format.

Author: sammccall Date: Mon May 6 01:11:59 2019 New Revision: 360016 URL: http://llvm.org/viewvc/llvm-project?rev=360016=rev Log: [clangd] Support -fallback-style, similar to clang-format. Reviewers: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

RKSimon added a comment. Where did all the clang diffs come from? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61472/new/ https://reviews.llvm.org/D61472 ___ cfe-commits mailing list

r360022 - [X86] Move files to correct directories after D60552

Author: maskray Date: Mon May 6 02:24:36 2019 New Revision: 360022 URL: http://llvm.org/viewvc/llvm-project?rev=360022=rev Log: [X86] Move files to correct directories after D60552 Added: cfe/trunk/lib/Headers/avx512bf16intrin.h cfe/trunk/lib/Headers/avx512vlbf16intrin.h

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360030: [clangd] Boost code completion results that were named in the last few lines. (authored by sammccall, committed

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall added a comment. In D61537#1491649 , @ilya-biryukov wrote: > Nice! Looking at the numbers, the improvements look worthwhile. > > The stopwords don't seem to be in the patch anymore, but they do seem like a > good idea. Specifically, we might

[clang-tools-extra] r360032 - [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in pointer arithmetic

Author: baloghadamsoftware Date: Mon May 6 03:41:37 2019 New Revision: 360032 URL: http://llvm.org/viewvc/llvm-project?rev=360032=rev Log: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in pointer arithmetic Some programmers tend to forget that subtracting two

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Embedding clients want to experiment with showing such results in e.g. a different color. Repository: rCTE

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Rakete added a comment. @Tyker This broke the Chromium build, could you investigate please? http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190506/270340.html Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934

[PATCH] D60552: [X86] Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

This revision was automatically updated to reflect the committed changes. Closed by commit rL360018: Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper… (authored by LuoYuanke, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[clang-tools-extra] r360020 - [clangd] Always call getFormatStyleForFile().

Author: sammccall Date: Mon May 6 01:39:17 2019 New Revision: 360020 URL: http://llvm.org/viewvc/llvm-project?rev=360020=rev Log: [clangd] Always call getFormatStyleForFile(). This means "format" will no longer return an error if the -fallback-style flag is invalid, it will log and use LLVM

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall added a comment. (doh, sorry - I thought this was accepted. Happy to revert, or try the lexer soon if you think it's important. Case-sensitive matching was still slightly negative within the noise) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

kadircet added a comment. We already have `CodeCompletion::Origin` which is (at least should be)set to `Identifier` in those cases. Is there a reason for not using it? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61588/new/

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

ilya-biryukov added a comment. Nah, it's ok. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61537/new/ https://reviews.llvm.org/D61537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r360030 - [clangd] Boost code completion results that were named in the last few lines.

Author: sammccall Date: Mon May 6 03:25:10 2019 New Revision: 360030 URL: http://llvm.org/viewvc/llvm-project?rev=360030=rev Log: [clangd] Boost code completion results that were named in the last few lines. Summary: The hope is this will catch a few patterns with repetition: SomeClass* S =

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall updated this revision to Diff 198243. sammccall marked 3 inline comments as done. sammccall added a comment. Comment about keywords Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61537/new/ https://reviews.llvm.org/D61537 Files:

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker added a comment. yes i am on it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61566: Fix for bug 41747: AST Printer doesn't print nested name specifier for out of scope record definitions

dyatkovskiy added a comment. @jdenny ? @sepavloff ? ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61566/new/ https://reviews.llvm.org/D61566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

ilya-biryukov added a comment. Nice! Looking at the numbers, the improvements look worthwhile. The stopwords don't seem to be in the patch anymore, but they do seem like a good idea. Specifically, we might want to remove all keywords - the intuition is that they don't provide much value,

Re: r359949 - [clang] adding explicit(bool) from c++2a

On Sat, May 4, 2019 at 2:06 AM Nicolas Lesser via cfe-commits wrote: > > Author: rakete > Date: Fri May 3 17:09:00 2019 > New Revision: 359949 > > URL: http://llvm.org/viewvc/llvm-project?rev=359949=rev > Log: > [clang] adding explicit(bool) from c++2a > > this patch adds support for the

[clang-tools-extra] r360026 - [clangd] Qualify uses of ::testing everywhere. NFC

Author: ibiryukov Date: Mon May 6 03:08:47 2019 New Revision: 360026 URL: http://llvm.org/viewvc/llvm-project?rev=360026=rev Log: [clangd] Qualify uses of ::testing everywhere. NFC Add an initial '::' qualifier to all usages of 'testing' namespace that did not have one. The goal is to make our

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall updated this revision to Diff 198242. sammccall added a comment. address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61537/new/ https://reviews.llvm.org/D61537 Files: clangd/CodeComplete.cpp clangd/FindSymbols.cpp

[PATCH] D61422: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in pointer arithmetic

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360032: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in… (authored by baloghadamsoftware, committed by ). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST

r360018 - Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

Author: luoyuanke Date: Mon May 6 01:25:11 2019 New Revision: 360018 URL: http://llvm.org/viewvc/llvm-project?rev=360018=rev Log: Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake Summary: 1. Enable infrastructure of AVX512_BF16, which is supported for BFLOAT16

[clang-tools-extra] r360039 - [clangd] Expose whether no-compile completion was used.

Author: sammccall Date: Mon May 6 05:03:26 2019 New Revision: 360039 URL: http://llvm.org/viewvc/llvm-project?rev=360039=rev Log: [clangd] Expose whether no-compile completion was used. Summary: Embedding clients want to experiment with showing such results in e.g. a different color.

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks for the info. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61588/new/ https://reviews.llvm.org/D61588

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360039: [clangd] Expose whether no-compile completion was used. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D61588?vs=198246=198251#toc Repository:

  1   2   >