[PATCH] D61589: [CodeComplete] Add a trailing semicolons to some pattern completions

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr. Herald added a project: clang. Where semicolon is required in any case. Here's a list of completions that now have a semicolon: - namespace = ; - using namespace ; - using ::; - continue; - break; - goto ; - return;

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360039: [clangd] Expose whether no-compile completion was used. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D61588?vs=198246=198251#toc Repository:

[clang-tools-extra] r360039 - [clangd] Expose whether no-compile completion was used.

Author: sammccall Date: Mon May 6 05:03:26 2019 New Revision: 360039 URL: http://llvm.org/viewvc/llvm-project?rev=360039=rev Log: [clangd] Expose whether no-compile completion was used. Summary: Embedding clients want to experiment with showing such results in e.g. a different color.

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks for the info. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61588/new/ https://reviews.llvm.org/D61588

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

sammccall added a comment. In D61588#1491728 , @kadircet wrote: > We already have `CodeCompletion::Origin` which is (at least should be)set to > `Identifier` in those cases. Is there a reason for not using it? I'd forgotten about that. A couple I can

[PATCH] D61566: Fix for bug 41747: AST Printer doesn't print nested name specifier for out of scope record definitions

dyatkovskiy added a comment. @jdenny ? @sepavloff ? ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61566/new/ https://reviews.llvm.org/D61566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r360018 - Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

Author: luoyuanke Date: Mon May 6 01:25:11 2019 New Revision: 360018 URL: http://llvm.org/viewvc/llvm-project?rev=360018=rev Log: Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake Summary: 1. Enable infrastructure of AVX512_BF16, which is supported for BFLOAT16

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker added a comment. yes i am on it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Rakete added a comment. @Tyker This broke the Chromium build, could you investigate please? http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190506/270340.html Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

kadircet added a comment. We already have `CodeCompletion::Origin` which is (at least should be)set to `Identifier` in those cases. Is there a reason for not using it? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61588/new/

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

ilya-biryukov added a comment. Nah, it's ok. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61537/new/ https://reviews.llvm.org/D61537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Embedding clients want to experiment with showing such results in e.g. a different color. Repository: rCTE

[clang-tools-extra] r360032 - [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in pointer arithmetic

Author: baloghadamsoftware Date: Mon May 6 03:41:37 2019 New Revision: 360032 URL: http://llvm.org/viewvc/llvm-project?rev=360032=rev Log: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in pointer arithmetic Some programmers tend to forget that subtracting two

[PATCH] D61422: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in pointer arithmetic

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360032: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in… (authored by baloghadamsoftware, committed by ). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall added a comment. (doh, sorry - I thought this was accepted. Happy to revert, or try the lexer soon if you think it's important. Case-sensitive matching was still slightly negative within the noise) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360030: [clangd] Boost code completion results that were named in the last few lines. (authored by sammccall, committed

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall added a comment. In D61537#1491649 , @ilya-biryukov wrote: > Nice! Looking at the numbers, the improvements look worthwhile. > > The stopwords don't seem to be in the patch anymore, but they do seem like a > good idea. Specifically, we might

[clang-tools-extra] r360030 - [clangd] Boost code completion results that were named in the last few lines.

Author: sammccall Date: Mon May 6 03:25:10 2019 New Revision: 360030 URL: http://llvm.org/viewvc/llvm-project?rev=360030=rev Log: [clangd] Boost code completion results that were named in the last few lines. Summary: The hope is this will catch a few patterns with repetition: SomeClass* S =

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall updated this revision to Diff 198243. sammccall marked 3 inline comments as done. sammccall added a comment. Comment about keywords Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61537/new/ https://reviews.llvm.org/D61537 Files:

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall updated this revision to Diff 198242. sammccall added a comment. address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61537/new/ https://reviews.llvm.org/D61537 Files: clangd/CodeComplete.cpp clangd/FindSymbols.cpp

[clang-tools-extra] r360026 - [clangd] Qualify uses of ::testing everywhere. NFC

Author: ibiryukov Date: Mon May 6 03:08:47 2019 New Revision: 360026 URL: http://llvm.org/viewvc/llvm-project?rev=360026=rev Log: [clangd] Qualify uses of ::testing everywhere. NFC Add an initial '::' qualifier to all usages of 'testing' namespace that did not have one. The goal is to make our

Re: r359949 - [clang] adding explicit(bool) from c++2a

On Sat, May 4, 2019 at 2:06 AM Nicolas Lesser via cfe-commits wrote: > > Author: rakete > Date: Fri May 3 17:09:00 2019 > New Revision: 359949 > > URL: http://llvm.org/viewvc/llvm-project?rev=359949=rev > Log: > [clang] adding explicit(bool) from c++2a > > this patch adds support for the

r360022 - [X86] Move files to correct directories after D60552

Author: maskray Date: Mon May 6 02:24:36 2019 New Revision: 360022 URL: http://llvm.org/viewvc/llvm-project?rev=360022=rev Log: [X86] Move files to correct directories after D60552 Added: cfe/trunk/lib/Headers/avx512bf16intrin.h cfe/trunk/lib/Headers/avx512vlbf16intrin.h

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

ilya-biryukov added a comment. Nice! Looking at the numbers, the improvements look worthwhile. The stopwords don't seem to be in the patch anymore, but they do seem like a good idea. Specifically, we might want to remove all keywords - the intuition is that they don't provide much value,

[clang-tools-extra] r360020 - [clangd] Always call getFormatStyleForFile().

Author: sammccall Date: Mon May 6 01:39:17 2019 New Revision: 360020 URL: http://llvm.org/viewvc/llvm-project?rev=360020=rev Log: [clangd] Always call getFormatStyleForFile(). This means "format" will no longer return an error if the -fallback-style flag is invalid, it will log and use LLVM

[PATCH] D60552: [X86] Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

This revision was automatically updated to reflect the committed changes. Closed by commit rL360018: Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper… (authored by LuoYuanke, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D59465: [analyzer] Add a test plugin for checker option handling

Szelethus added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59465/new/ https://reviews.llvm.org/D59465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus added a comment. Ping^4 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. Ping^4 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. Ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

RKSimon added a comment. Where did all the clang diffs come from? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61472/new/ https://reviews.llvm.org/D61472 ___ cfe-commits mailing list

[PATCH] D61519: [clangd] Support -fallback-style, similar to clang-format.

This revision was automatically updated to reflect the committed changes. Closed by commit rL360016: [clangd] Support -fallback-style, similar to clang-format. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[clang-tools-extra] r360016 - [clangd] Support -fallback-style, similar to clang-format.

Author: sammccall Date: Mon May 6 01:11:59 2019 New Revision: 360016 URL: http://llvm.org/viewvc/llvm-project?rev=360016=rev Log: [clangd] Support -fallback-style, similar to clang-format. Reviewers: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang

[PATCH] D61559: Fix the crash when formatting unsupported encodings

sammccall added a comment. You might want to add a test for one of these? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61559/new/ https://reviews.llvm.org/D61559 ___ cfe-commits mailing list

[PATCH] D61559: Fix the crash when formatting unsupported encodings

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/tools/clang-format/ClangFormat.cpp:273 +.StartsWith("\xFF\xFE", "UTF-16 (LE)") +.StartsWith("\x2B\x2F\x76", "UTF-7") +

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro added a comment. @probinson @aprantl Thanks! @vsk Thanks for the comment! Sure, we will add that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 ___ cfe-commits mailing list

[PATCH] D61508: [clang-tidy] misc-header-guard : a simple version of llvm-header-guard

JonasToth added a comment. Hi trixirt and thanks for the patch! I would rather like to generalize the llvm check to allow different styles and then alias the general version with different configurations. Introducing this code duplication does not sound like a good idea to me. The

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

lebedev.ri added a comment. In D61509#1491397 , @jdenny wrote: > In D61509#1491209 , @ABataev wrote: > > > In D61509#1491204 , @lebedev.ri > > wrote: > > > > > In

<    1   2