[PATCH] D61506: [OpenCL] Switch to C++17

Anastasia updated this revision to Diff 198627. Anastasia added a comment. Added `HexFloat`! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61506/new/ https://reviews.llvm.org/D61506 Files: include/clang/Frontend/LangStandards.def test/CodeGenOpenCLCXX/addrspace-of-this.cl Index:

[clang-tools-extra] r360247 - Documentation for bugprone-inaccurate-erase: added an example of a bug that this checker catches

Author: gribozavr Date: Wed May 8 05:02:31 2019 New Revision: 360247 URL: http://llvm.org/viewvc/llvm-project?rev=360247=rev Log: Documentation for bugprone-inaccurate-erase: added an example of a bug that this checker catches Reviewers: alexfh Subscribers: cfe-commits Tags: #clang

[PATCH] D61424: [ASTImporter] Fix inequivalence of unresolved exception spec

martong updated this revision to Diff 198626. martong marked 2 inline comments as done. martong added a comment. - Improve and fix typo in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61424/new/ https://reviews.llvm.org/D61424 Files:

[PATCH] D61644: Documentation for bugprone-inaccurate-erase: added an example of a bug that this checker catches

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61644/new/ https://reviews.llvm.org/D61644

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 198623. martong added a comment. - Use LLDB_LOG_ERROR in ImportDefinitionTo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 Files:

[PATCH] D58236: Make address space conversions a bit stricter.

Anastasia added a comment. In D58236#1494722 , @ebevhan wrote: > This was accepted a while ago, but never landed. I don't have commit access; > could someone commit it? Sure! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58236/new/

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 198618. martong added a comment. - Add braces to 'true' cases when 'false' case has braces - Simplify logging and error handling with LLDB_LOG_ERROR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/

[PATCH] D58236: Make address space conversions a bit stricter.

ebevhan added a comment. This was accepted a while ago, but never landed. I don't have commit access; could someone commit it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58236/new/ https://reviews.llvm.org/D58236 ___ cfe-commits

[PATCH] D61506: [OpenCL] Switch to C++17

Anastasia added a comment. In D61506#1493953 , @keryell wrote: > In D61506#1490555 , @rsmith wrote: > > > Per the OpenCL C++ 1.0 specification, section 2: > > > > > The OpenCL C++ programming language is based on

[PATCH] D61670: [RFC] [MinGW] Allow opting out from .refptr stubs

mstorsjo created this revision. mstorsjo added a reviewer: rnk. Herald added a project: clang. In GCC, the .refptr stubs are only generated for x86_64, and only for code models medium and larger (and medium is the default for x86_64 since this was introduced). They can be omitted (for projects

[PATCH] D61664: [NewPM] Setup Passes for KASan and KMSan

glider added a comment. Rubberstamp LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61664/new/ https://reviews.llvm.org/D61664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61668: [ARM] Fix the extensions implied by a cpu name

DavidSpickett added a comment. LGTM but the use of "intrinsic" in the commit message is confusing. Do you mean feature/implied feature, as in "the implied features defined by"? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61668/new/

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov updated this revision to Diff 198606. ilya-biryukov marked 5 inline comments as done. ilya-biryukov added a comment. - Make traverse() internal to its only use-site. - s/Corpus/Arena. - Address some other comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov updated this revision to Diff 198609. ilya-biryukov added a comment. - s/corpus/arena - Remove an accidental cmake change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61637/new/ https://reviews.llvm.org/D61637 Files:

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Corpus.h:23 +/// token buffers, source manager, etc. +class Corpus { +public: sammccall wrote: > I think plain SyntaxArena might be a better name here :-/ > Corpus refers to

[PATCH] D61668: [ARM] Fix the extensions implied by a cpu name

dnsampaio created this revision. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. dnsampaio added reviewers: keith.walker.arm, DavidSpickett, carwil. When using `clang -mcpu=CPUNAME+FEATURELIST`, the intrinsic features defined by CPUNAME are not

[PATCH] D61485: Added an assert in `isConstantInitializer`: initializer lists must be in semantic form

gribozavr added a comment. @rsmith Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61485/new/ https://reviews.llvm.org/D61485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

gribozavr marked an inline comment as done. gribozavr added a comment. In D61522#1494155 , @rsmith wrote: > The right thing to check in all of these cases should be only > `isValueDependent()`. Every type-dependent expression should generally also > be

[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

gribozavr updated this revision to Diff 198603. gribozavr added a comment. Addressed review comments: - Simplified error handling in SemaOpenMP, - Only check isValueDependent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61522/new/

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

ahatanak created this revision. ahatanak added reviewers: rjmccall, ldionne. ahatanak added a project: clang. Herald added a reviewer: EricWF. Herald added subscribers: dexonsmith, jkorous. This patch resurrects r264998, which was committed to work around a bug in libc++abi that was causing

[clang-tools-extra] r360231 - [clang-tidy] Do not show incorrect fix in modernize-make-unique

Author: ibiryukov Date: Wed May 8 01:52:18 2019 New Revision: 360231 URL: http://llvm.org/viewvc/llvm-project?rev=360231=rev Log: [clang-tidy] Do not show incorrect fix in modernize-make-unique Summary: The case when initialize_list hides behind an implicit case was not handled before.

[PATCH] D61642: [clang-tidy] Do not show incorrect fix in modernize-make-unique

This revision was automatically updated to reflect the committed changes. Closed by commit rL360231: [clang-tidy] Do not show incorrect fix in modernize-make-unique (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

Re: r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

Just wanted to update. My latest revision (r360225) seems to have fixed the bots.  On Tue, May 7, 2019 at 3:50 PM Jonas Devlieghere wrote: > Hi Leonard, > > My personal rule of thumb is that if I can fix it in something like 30 > minutes or less, I'll leave the bot red and commit a fix.

[PATCH] D61664: [NewPM] Setup Passes for KASan and KMSan

philip.pfaffe accepted this revision. philip.pfaffe added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61664/new/ https://reviews.llvm.org/D61664

[PATCH] D61617: [NewPassManager] Add tuning option: SLPVectorization [clang-change]

asbirlea updated this revision to Diff 198587. asbirlea added a comment. Updated test. Improvement suggestions are always *very* much welcome! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61617/new/ https://reviews.llvm.org/D61617 Files:

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

alexandre.isoard added a comment. I'm not convinced by the approach. Can it still recognize the loop idiom into memcpy implementation but use `memmove` (as only `memcpy` has been blacklisted)? Can it do the same for `memmove` (for the case without overlap), and end-up with infinite recursion?

<    1   2