[PATCH] D63397: [clangd] Detect C++ for extension-less source files in vscode extension

This revision was automatically updated to reflect the committed changes. Closed by commit rL363554: [clangd] Detect C++ for extension-less source files in vscode extension (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

lebedev.ri added a comment. In D43500#1546077 , @jdemeule wrote: > In D43500#1244518 , @JonasToth wrote: > > > What is the status here? Will you continue to work on this patch @jdemeule > > (which would be great!)

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:508 def Varargs : DiagGroup<"varargs">; +def XorAsPow : DiagGroup<"xor-as-pow">; GCC folks will do this diagnostic soon too, so I

[PATCH] D63425: [clangd] Perform merge for main file symbols.

hokein added a comment. In D63425#1546010 , @kadircet wrote: > We also make use of `PickOne` in `updatePreamble` shouldn't that also cause > similar troubles? Yeah, we have similar problems in `updatePreamble`, but this is a correctness/performance

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

mibintc added a comment. This works for me, I redid my patches adding fp-model options to work with this newest changeset, (but I haven't yet uploaded them.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53157/new/ https://reviews.llvm.org/D53157

[PATCH] D63164: [HIP] Add option to force lambda nameing following ODR in HIP/CUDA.

hliao added a comment. ping again. not sure my explanation gives more details on why this patch is created. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63164/new/ https://reviews.llvm.org/D63164

[PATCH] D63387: clang: Promote -fdebug-compilation-dir from cc1 flag to driver-level flag

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Driver/Options.td:717 +def fdebug_compilation_dir : Separate<["-"], "fdebug-compilation-dir">, +Group, Flags<[CC1Option, CC1AsOption,

[PATCH] D63335: [HIP] Add the interface deriving the stub name of device kernels.

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63335/new/ https://reviews.llvm.org/D63335 ___ cfe-commits mailing list

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 created this revision. xbolva00 added reviewers: jfb, rsmith. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Motivation: https://twitter.com/jfbastien/status/1139298419988549632 https://twitter.com/mikemx7f/status/1139335901790625793

r363553 - [HIP] Add the interface deriving the stub name of device kernels.

Author: hliao Date: Mon Jun 17 05:51:36 2019 New Revision: 363553 URL: http://llvm.org/viewvc/llvm-project?rev=363553=rev Log: [HIP] Add the interface deriving the stub name of device kernels. Summary: - Revise the interface to derive the stub name and simplify the assertion of it. Reviewers:

[PATCH] D63425: [clangd] Perform merge for main file symbols.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Previously, we randomly pick one main file symbol in dynamic index, we may loose the ideal symbol (with definition location) in the

[PATCH] D63426: [clangd] Narrow rename to local symbols.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Previously, we perform rename for all kinds of symbols (local, global). This patch narrows the scope by only renaming

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule added a comment. In D43500#1244518 , @JonasToth wrote: > What is the status here? Will you continue to work on this patch @jdemeule > (which would be great!) ? Hi, now, this patch contains only tests which are already covered with lit tests.

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 added a comment. Should we also emit a note how to silence it, eg. swap xor operands or add parentheses around 2/10 ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 ___ cfe-commits

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

ro added a comment. In D62944#1542217 , @efriedma wrote: > For format-strings.c, I'm not really happy suggesting `#if defined(__sun) && > !defined(__LP64__)`, but I don't think the alternative is better. We could > restrict the test so it doesn't run

[PATCH] D63387: clang: Promote -fdebug-compilation-dir from cc1 flag to driver-level flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL363548: Promote -fdebug-compilation-dir from a cc1 flag to clang and clang-cl driver… (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r363548 - Promote -fdebug-compilation-dir from a cc1 flag to clang and clang-cl driver flags

Author: nico Date: Mon Jun 17 05:10:40 2019 New Revision: 363548 URL: http://llvm.org/viewvc/llvm-project?rev=363548=rev Log: Promote -fdebug-compilation-dir from a cc1 flag to clang and clang-cl driver flags The flag is useful when wanting to create .o files that are independent from the

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53157/new/ https://reviews.llvm.org/D53157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D62697: AMDGPU: Disable errno by default

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Sorry for the delay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62697/new/ https://reviews.llvm.org/D62697 ___ cfe-commits

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

ro updated this revision to Diff 205012. ro added a comment. Herald added a subscriber: krytarowski. Adapt `Sema/format-strings.c`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62944/new/ https://reviews.llvm.org/D62944 Files: lib/Basic/Targets/OSTargets.h

[PATCH] D63417: [WIP][RISCV] Specify registers used for exception handling

edward-jones created this revision. edward-jones added reviewers: asb, lewis-revill. Herald added subscribers: cfe-commits, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook,

Re: r363116 - [X86] [ABI] Fix i386 ABI "__m64" type bug

This broke Chromium for 32-bit Linux: https://bugs.chromium.org/p/chromium/issues/detail?id=974542#c5 It's not clear what's happening yet, bet just to give a heads up. Since this changes ABI behaviour, it would probably we worth mentioning in docs/ReleaseNotes.rst too. On Wed, Jun 12, 2019 at

[PATCH] D63335: [HIP] Add the interface deriving the stub name of device kernels.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363553: [HIP] Add the interface deriving the stub name of device kernels. (authored by hliao, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[clang-tools-extra] r363554 - [clangd] Detect C++ for extension-less source files in vscode extension

Author: hokein Date: Mon Jun 17 05:59:14 2019 New Revision: 363554 URL: http://llvm.org/viewvc/llvm-project?rev=363554=rev Log: [clangd] Detect C++ for extension-less source files in vscode extension Summary: Extend our extension to support detecting these files as C++ files based on the first

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 updated this revision to Diff 205058. xbolva00 added a comment. More tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td

[clang-tools-extra] r363555 - [clangd] Bump vscode-clangd v0.0.15.

Author: hokein Date: Mon Jun 17 06:18:24 2019 New Revision: 363555 URL: http://llvm.org/viewvc/llvm-project?rev=363555=rev Log: [clangd] Bump vscode-clangd v0.0.15. CHANGELOG: - support detecting C++ language from first line (`-*- C++ -*-`) of the file. Modified:

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Charusso accepted this revision. Charusso added a comment. My opinion based on the Summary, which is the kind of the opposite what we have. No invalidation happens, so no swap happens, so it is kind of misleading like writing out "Returning something" where we cannot be sure what we return

[libunwind] r363545 - [libunwind][AArch64] Fix libunwind::Registers_arm64::jumpto

Author: miyuki Date: Mon Jun 17 04:00:21 2019 New Revision: 363545 URL: http://llvm.org/viewvc/llvm-project?rev=363545=rev Log: [libunwind][AArch64] Fix libunwind::Registers_arm64::jumpto Summary: The AArch64 version of the libunwind function which restores the CPU state and resumes execution is

[PATCH] D59744: Fix i386 ABI "__m64" type bug

hans added a comment. I tried replying on the cfe-commits email, but both Pengfei and Wei's email addresses seem to bounce, so replying here instead: This broke Chromium for 32-bit Linux: https://bugs.chromium.org/p/chromium/issues/detail?id=974542#c5 It's not clear what's happening yet, bet

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added subscribers: aheejin, dschuff. Herald added a project: clang. Add support for the C++2a [[no_unique_address]] attribute for targets using the Itanium C++ ABI. This depends on D63371 .

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 marked 2 inline comments as done. xbolva00 added inline comments. Comment at: lib/Sema/SemaExpr.cpp:10924 + + if (LeftSideValue == 2 || LeftSideValue == 10) { +llvm::APInt XorValue = LeftSideValue ^ RightSideValue; Quuxplusone wrote: > Do you have

[PATCH] D58033: Add option for emitting dbg info for call site parameters

probinson added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:755 + (Arch == llvm::Triple::x86 || Arch == llvm::Triple::x86_64)) +Opts.EnableDebugEntryValues = Args.hasArg(OPT_femit_debug_entry_values); + You want to disable

[PATCH] D59402: Suggestions to fix -Wmissing-{prototypes,variable-declarations}

aaronpuchert added inline comments. Comment at: lib/Sema/SemaDecl.cpp:13345-13346 +<< (FD->getStorageClass() == SC_None +? FixItHint::CreateInsertion(FD->getTypeSpecStartLoc(), + "static ") +

[PATCH] D63438: [analyzer] print() JSONify: ProgramPoint revision

NoQ added a comment. Yes, this would be helpful! Tests? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63438/new/ https://reviews.llvm.org/D63438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn added inline comments. Comment at: include/llvm/IR/IRBuilder.h:1138 + +return MetadataAsValue::get(Context, RoundingMDS); + } rjmccall wrote: > Huh? You build an `MDNode` that wraps an `MDString` and then immediately > extract the `MDString` from it

[PATCH] D63367: [clang-doc] Add basic support for templates and typedef

DiegoAstiazaran updated this revision to Diff 205169. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added a comment. Specify type in declarations where //auto// keyword was used. Initialize pointer to nullptr in empty declaration. CHANGES SINCE LAST ACTION

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 updated this revision to Diff 205136. xbolva00 added a comment. Updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Nice cleanup! Comment at: clang/include/clang/Sema/Sema.h:10298 + bool AllowFold = true, +

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5609 +def warn_mul_in_bool_context : Warning< + "'*' in bool context, maybe you mean '&&'?">, + InGroup; I would appreciate seeing some motivating examples for this

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn marked an inline comment as done. kpn added inline comments. Comment at: include/llvm/IR/IRBuilder.h:1138 + +return MetadataAsValue::get(Context, RoundingMDS); + } rjmccall wrote: > kpn wrote: > > rjmccall wrote: > > > Huh? You build an `MDNode` that

[PATCH] D59402: Suggestions to fix -Wmissing-{prototypes,variable-declarations}

aaronpuchert added inline comments. Comment at: lib/Sema/SemaDecl.cpp:13345-13346 +<< (FD->getStorageClass() == SC_None +? FixItHint::CreateInsertion(FD->getTypeSpecStartLoc(), + "static ") +

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: test/SemaCXX/warn-xor-as-pow.cpp:85 + res = XOR(10, 10); + res = 10^-7; +} What should we suggest here ? :) Nevative shift ? think we should diagnose it. I am not sure

r363606 - PR42205: DebugInfio: Do not attempt to emit debug info metadata for static member variable template partial specializations

Author: dblaikie Date: Mon Jun 17 12:40:52 2019 New Revision: 363606 URL: http://llvm.org/viewvc/llvm-project?rev=363606=rev Log: PR42205: DebugInfio: Do not attempt to emit debug info metadata for static member variable template partial specializations Would cause a crash in an attempt to

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

rjmccall added inline comments. Comment at: include/llvm/IR/IRBuilder.h:1138 + +return MetadataAsValue::get(Context, RoundingMDS); + } kpn wrote: > rjmccall wrote: > > Huh? You build an `MDNode` that wraps an `MDString` and then immediately > > extract

[PATCH] D63454: [OpenMP] Strengthen regression tests for task allocation under nowait depend clauses NFC

Hahnfeld added inline comments. Comment at: test/OpenMP/target_constant_device_codegen.cpp:2-4 +// RUN: %clang_cc1 -verify -fopenmp -x c++ -triple powerpc64le-unknown-unknown -fopenmp-targets=powerpc64le-ibm-linux-gnu -emit-llvm %s -o - | FileCheck %s --check-prefix CHECK

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

rjmccall added a comment. Minor requests, then LGTM. Comment at: lib/CodeGen/CGExprConstant.cpp:73 +/// Incremental builder for an llvm::Constant* holding a structure constant. +class ConstantBuilder : private ConstantBuilderUtils { + llvm::SmallVector Elems;

[PATCH] D63290: Unify DependencyFileGenerator class and DependencyCollector interface

aganea added a reviewer: benlangmuir. aganea added inline comments. Comment at: clang/include/clang/Frontend/Utils.h:118 /// Builds a depdenency file when attached to a Preprocessor (for includes) and /// ASTReader (for module imports), and writes it out at the end of

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ updated this revision to Diff 205177. NoQ added a comment. Add tests, rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62761/new/ https://reviews.llvm.org/D62761 Files: clang/test/Analysis/exploded-graph-rewriter/environment_diff.dot

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

Charusso added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:287 .replace('\\}', '}') \ +.replace('', '\\') \

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 updated this revision to Diff 205140. xbolva00 added a comment. Removed useless else block with return. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 Files: include/clang/Basic/DiagnosticGroups.td

[PATCH] D63454: [OpenMP] Strengthen regression tests for task allocation under nowait depend clauses NFC

gtbercea created this revision. gtbercea added reviewers: ABataev, Hahnfeld, caomhin. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. This patch strengthens the tests introduced in D63009 by: - adding new test for

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62944/new/ https://reviews.llvm.org/D62944 ___

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

efriedma added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:967 // Constant folding is currently missing support for a few features supported // here: CK_ToUnion, CK_ReinterpretMemberPointer, and DesignatedInitUpdateExpr. class ConstExprEmitter :

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

rsmith updated this revision to Diff 205162. rsmith added a comment. - Fix somewhat-incorrect comment on Size member. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63371/new/ https://reviews.llvm.org/D63371 Files: lib/CodeGen/CGExprConstant.cpp

r363612 - Clang :: Sema/wchar.c has long been failing on Solaris:

Author: ro Date: Mon Jun 17 13:21:25 2019 New Revision: 363612 URL: http://llvm.org/viewvc/llvm-project?rev=363612=rev Log: Clang :: Sema/wchar.c has long been failing on Solaris: error: 'error' diagnostics expected but not seen: File /vol/llvm/src/clang/local/test/Sema/wchar.c Line 22:

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL363612: Clang :: Sema/wchar.c has long been failing on Solaris: (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63369: [AST] Fixed extraneous warnings for binary conditional operator

nickdesaulniers accepted this revision. nickdesaulniers added a comment. Thanks for the patch and following up on the review comments. Let's work on getting you commit access now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63369/new/

[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

aaron.ballman added inline comments. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:1279 continue; - if (S.getLangOpts().CPlusPlus11) { + if (S.getLangOpts().CPlusPlus11 || S.getLangOpts().C99) { const Stmt *Term = B->getTerminatorStmt();

[PATCH] D63367: [clang-doc] Add basic support for templates and typedef

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:244 // interface). + bool IsTypeDef = false; // Indicates if record was declared using typedef llvm::SmallVector

[PATCH] D59402: Suggestions to fix -Wmissing-{prototypes,variable-declarations}

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:13345-13346 +<< (FD->getStorageClass() == SC_None +? FixItHint::CreateInsertion(FD->getTypeSpecStartLoc(), + "static ") +

[PATCH] D63436: [analyzer] Fix JSON dumps for ExplodedNodes

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Analysis/dump_egraph.c:3 // RUN: cat %t.dot | FileCheck %s -// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-dump-egraph=%t.dot

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn updated this revision to Diff 205151. kpn marked 3 inline comments as done. kpn added a comment. Address review comments. Run the changes through clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53157/new/ https://reviews.llvm.org/D53157 Files:

[PATCH] D63367: [clang-doc] Add basic support for templates and typedef

DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:244 // interface). + bool IsTypeDef = false; // Indicates if record was declared

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

rjmccall added a comment. In D63371#1546587 , @rsmith wrote: > In D63371#1546500 , @rjmccall wrote: > > > Isn't `[[no_unique_address]]` only significant for empty members? I'm not > > sure why they need

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

regehr added a comment. Just wanted to say that I think I agree with the design choices here! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62750: Show note for -Wmissing-prototypes for functions with parameters

aaronpuchert added inline comments. Comment at: lib/Sema/SemaDecl.cpp:13335 +? FixItHint::CreateInsertion(FTL.getRParenLoc(), "void") +: FixItHint{}); } aaron.ballman wrote: > In this case, we could

[PATCH] D62750: Show note for -Wmissing-prototypes for functions with parameters

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:13335 +? FixItHint::CreateInsertion(FTL.getRParenLoc(), "void") +: FixItHint{}); } aaronpuchert wrote: > aaron.ballman wrote: > > In

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

rsmith updated this revision to Diff 205161. rsmith marked 13 inline comments as done. rsmith added a comment. - Address review comments from rjmccall. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63371/new/ https://reviews.llvm.org/D63371 Files:

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

rsmith added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:73 +/// Incremental builder for an llvm::Constant* holding a structure constant. +class ConstantBuilder : private ConstantBuilderUtils { + llvm::SmallVector Elems; rjmccall wrote: > This

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

rjmccall added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:73 +/// Incremental builder for an llvm::Constant* holding a structure constant. +class ConstantBuilder : private ConstantBuilderUtils { + llvm::SmallVector Elems; This seems like a very

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 marked 3 inline comments as done. xbolva00 added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5609 +def warn_mul_in_bool_context : Warning< + "'*' in bool context, maybe you mean '&&'?">, + InGroup; aaron.ballman wrote: > I

[PATCH] D60974: Clang IFSO driver action.

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:91 + std::vector MangledNames = CGNameGen.getAllManglings(ND); + if (isa(ND) || isa(ND))

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:967 // Constant folding is currently missing support for a few features supported // here: CK_ToUnion, CK_ReinterpretMemberPointer, and DesignatedInitUpdateExpr.

[PATCH] D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior

compnerd added a comment. Could you please add a test to ensure that Darwin defaults to the old behaviour? Comment at: include/clang/Basic/LangOptions.h:142 +/// Attempt to be ABI-compatible with code generated by Clang 8.0.x +/// (https://reviews.llvm.org/D59744).

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 3 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/lib/Frontend/CMakeLists.txt:58 clangDriver + clangIndex clangEdit asb wrote: > plotfi wrote: > > MaskRay wrote: > > > This is a layering issue. clangIndex depends

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

rsmith updated this revision to Diff 205182. rsmith marked 2 inline comments as done. rsmith added a comment. - Address additional review comments from rjmccall. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63371/new/ https://reviews.llvm.org/D63371 Files:

[PATCH] D59744: Fix i386 ABI "__m64" type bug

thakis added a comment. In D59744#1547445 , @wxiao3 wrote: > @hans > > Please make sure all Chromium for 32-bit Linux libraries are following System > V ABI (i.e., m64 is passed on mmx register). I suspect that there are some > hand written assembly

[PATCH] D60974: Clang IFSO driver action.

MaskRay added inline comments. Comment at: cfe/trunk/lib/Frontend/CMakeLists.txt:58 clangDriver + clangIndex clangEdit This is a layering issue. clangIndex depends on clangFrontend so clangFrontend should not depend on clangIndex. The circular

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 added a comment. I have created a patch for you: https://reviews.llvm.org/D63473 Is it ok? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 ___ cfe-commits mailing list

[PATCH] D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior

wxiao3 created this revision. wxiao3 added reviewers: annita.zhang, LuoYuanke, smaslov, craig.topper, hjl.tools, rnk, andreadb, gbedwell, rjmccall, krytarowski, mgorny, joerg, RKSimon, hans, thakis. Herald added a project: clang. Herald added a subscriber: cfe-commits. The System V i386 bug fix

[PATCH] D60974: Clang IFSO driver action.

asb added inline comments. Comment at: cfe/trunk/lib/Frontend/CMakeLists.txt:58 clangDriver + clangIndex clangEdit plotfi wrote: > MaskRay wrote: > > This is a layering issue. clangIndex depends on clangFrontend so > > clangFrontend should not depend on

r363648 - [NFC] Undoing r363646 to fix bots.

Author: zer0 Date: Mon Jun 17 22:15:59 2019 New Revision: 363648 URL: http://llvm.org/viewvc/llvm-project?rev=363648=rev Log: [NFC] Undoing r363646 to fix bots. -DBUILD_SHARED_LIBS=ON is still having problem caused by layering issues with D60974. Locally there weren't problems building with

[PATCH] D60974: Clang IFSO driver action.

MaskRay added inline comments. Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:12 +#include "clang/Frontend/FrontendActions.h" +#include "clang/Index/CodegenNameGenerator.h" +#include "clang/Sema/TemplateInstCallback.h" > rL363646 This

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 3 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:22 + StringRef Format; + std::set ParsedTemplates; + MaskRay wrote: > Does `StringSet<>` work? It probably could work.

RE: r363548 - Promote -fdebug-compilation-dir from a cc1 flag to clang and clang-cl driver flags

Hi Nico, The test you added in cfe/trunk/test/Driver/clang_f_opts.c fails if a target does not use the integrated assembler. You can see what happens if you add "-fno-integrated-as" to the command line: /home/dyung/src/upstream/363548-linux/bin/clang -### -fno-integrated-as

r363646 - [NFC] Fixing -DBUILD_SHARED_LIBS=ON problem caused by layering issue in D60974

Author: zer0 Date: Mon Jun 17 21:40:03 2019 New Revision: 363646 URL: http://llvm.org/viewvc/llvm-project?rev=363646=rev Log: [NFC] Fixing -DBUILD_SHARED_LIBS=ON problem caused by layering issue in D60974 Modified: cfe/trunk/lib/Frontend/CMakeLists.txt Modified:

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. I had to back out r363646. While it worked for me building locally with and without shared lib, it appears to have caused bots to break. I will take another look at fixing it in about 10 hours. Repository: rL LLVM CHANGES SINCE LAST ACTION

r363649 - Revert D60974 "[clang-ifs] Clang Interface Stubs, first version."

Author: maskray Date: Mon Jun 17 22:52:39 2019 New Revision: 363649 URL: http://llvm.org/viewvc/llvm-project?rev=363649=rev Log: Revert D60974 "[clang-ifs] Clang Interface Stubs, first version." This reverts commit rC363626. clangIndex depends on clangFrontend. r363626 adds a dependency from

[PATCH] D60974: Clang IFSO driver action.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: cfe/trunk/lib/Frontend/CMakeLists.txt:58 clangDriver + clangIndex clangEdit MaskRay wrote: > This is a layering issue. clangIndex depends on clangFrontend so >

[PATCH] D60974: Clang IFSO driver action.

MaskRay added inline comments. Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:22 + StringRef Format; + std::set ParsedTemplates; + Does `StringSet<>` work? Comment at:

[PATCH] D60974: Clang IFSO driver action.

MaskRay added a comment. @plotfi Sorry I have to revert this patch. This can also cause problems in `-DBUILD_SHARED_LIBS=off` builds. clangFrontend files cannot `#include "clang/Index/CodegenNameGenerator.h"`, I think you may have to move files around. Repository: rL LLVM CHANGES SINCE

r363620 - Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

Author: rsmith Date: Mon Jun 17 14:08:30 2019 New Revision: 363620 URL: http://llvm.org/viewvc/llvm-project?rev=363620=rev Log: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants. Summary: This adds a ConstantBuilder class that deals with

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1640-1642 + CFGBlock *OriginB = GetRelevantBlock(Origin); + if (!OriginB || !NB) +return nullptr; Szelethus wrote: > NoQ wrote: > > `// TODO: This can be cached.`

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 updated this revision to Diff 205198. xbolva00 added a comment. Addressed review notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 added a comment. In D63423#1547244 , @regehr wrote: > In D63423#1547216 , @xbolva00 wrote: > > > The only remaining question is, as your said, whether or not to diagnose > > xors in macros. @regerh @jfb ?

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. - Repository: rC Clang https://reviews.llvm.org/D63462

[PATCH] D63436: [analyzer] Fix JSON dumps for ExplodedNodes

Charusso marked 2 inline comments as done. Charusso added a comment. Thanks for the review! Comment at: clang/test/Analysis/dump_egraph.c:3 // RUN: cat %t.dot | FileCheck %s -// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-dump-egraph=%t.dot -trim-egraph %s //

[PATCH] D63438: [analyzer] print() JSONify: ProgramPoint revision

Charusso updated this revision to Diff 205209. Charusso added a comment. - Added a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63438/new/ https://reviews.llvm.org/D63438 Files: clang/lib/Analysis/ProgramPoint.cpp clang/test/Analysis/dump_egraph.c Index:

[PATCH] D62635: Add enums as global variables in the IR metadata.

akhuang added a comment. They should all be there, but emitting the unused enums makes the binary sizes larger. (I think around 6% increase? I forget the size difference for only emitting used enums) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62635/new/

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 205191. plotfi marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

  1   2   >