r365445 - Add AlignConsecutiveMacros to the clang release notes

Author: sylvestre Date: Tue Jul 9 01:45:55 2019 New Revision: 365445 URL: http://llvm.org/viewvc/llvm-project?rev=365445=rev Log: Add AlignConsecutiveMacros to the clang release notes Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

r365446 - Remove trailing whitespaces in the Language Extensions doc

Author: sylvestre Date: Tue Jul 9 01:50:17 2019 New Revision: 365446 URL: http://llvm.org/viewvc/llvm-project?rev=365446=rev Log: Remove trailing whitespaces in the Language Extensions doc Modified: cfe/trunk/docs/LanguageExtensions.rst Modified: cfe/trunk/docs/LanguageExtensions.rst URL:

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:279 + HelpText<"Model implementation of custom RTTIs">, + Documentation; + This checker only does modeling, but isn't hidden. Should we hide it? CHANGES

[PATCH] D64257: [clangd] Added highlighting for non-builtin types

hokein added a comment. could you please also update the patch description? "non-builtin" types are not precise, this patch only highlights the class and enum types. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:71 + +TagDecl *D =

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

MaskRay updated this revision to Diff 208616. MaskRay added a comment. Simplify and add another test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64294/new/ https://reviews.llvm.org/D64294 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/cl-options.c

[PATCH] D64062: Remove both -dumpversion and __VERSION__

sylvestre.ledru updated this revision to Diff 208619. sylvestre.ledru added a comment. Update of the release note. thanks to @rnk for the suggestion Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64062/new/ https://reviews.llvm.org/D64062 Files:

[PATCH] D64257: [clangd] Added highlighting for non-builtin types

jvikstrom updated this revision to Diff 208621. jvikstrom marked 5 inline comments as done. jvikstrom added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64257/new/ https://reviews.llvm.org/D64257 Files:

[PATCH] D64257: [clangd] Added highlighting for non-builtin types

jvikstrom updated this revision to Diff 208622. jvikstrom added a comment. Changed commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64257/new/ https://reviews.llvm.org/D64257 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D64243: [NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64243/new/ https://reviews.llvm.org/D64243 ___

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

Hahnfeld added a subscriber: protze.joachim. Hahnfeld added inline comments. Comment at: clang/docs/OpenMPSupport.rst:165 ++--+--+--++

[clang-tools-extra] r365460 - Fixed assertion

Author: sureyeaah Date: Tue Jul 9 03:30:18 2019 New Revision: 365460 URL: http://llvm.org/viewvc/llvm-project?rev=365460=rev Log: Fixed assertion Modified: clang-tools-extra/trunk/clangd/refactor/tweaks/ExtractVariable.cpp Modified:

[PATCH] D64257: [clangd] Added highlighting for class and enum types

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:81 void addToken(SourceLocation Loc, const Decl *D) { +if (isa(D)) { + addToken(Loc, HighlightingKind::Class); jvikstrom wrote: > hokein wrote: > > nit: move

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang-tools-extra/test/clang-tidy/abseil-faster-strsplit-delimiter.cpp:55 + + absl::StrSplit("ABC", R"(A)"); + // CHECK-MESSAGES: [[@LINE-1]]:25: warning: absl::StrSplit() called with a

[clang-tools-extra] r365463 - Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

Author: gribozavr Date: Tue Jul 9 04:04:04 2019 New Revision: 365463 URL: http://llvm.org/viewvc/llvm-project?rev=365463=rev Log: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters. Summary: Currently it fails on cases like '\001'. Note: Since

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365463: Enhance abseil-faster-strsplit-delimiter to handle other non-printable… (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r365464 - [ASTImporter] Added visibility context check for EnumDecl.

Author: balazske Date: Tue Jul 9 04:08:18 2019 New Revision: 365464 URL: http://llvm.org/viewvc/llvm-project?rev=365464=rev Log: [ASTImporter] Added visibility context check for EnumDecl. Summary: ASTImporter makes now difference between enums with same name in different translation units if

[PATCH] D62484: [ASTImporter] Added visibility context check for EnumDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365464: [ASTImporter] Added visibility context check for EnumDecl. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D61637: [Syntax] Introduce syntax trees

RKSimon added a comment. @ilya-biryukov We're seeing buildbot failures in SyntaxTests.exe : http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/50927 http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26822 Failing Tests

[PATCH] D64391: [CodeComplete] an option to suppress endings for header completion

richard9404 created this revision. richard9404 added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Header completion in clang always apppends endings to the results, i.e. `/` for folders and `"` (or `>`)

[PATCH] D64391: [CodeComplete] an option to suppress endings for header completion

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1088 + + if (Trigger == "/") { // trigger only on '#include.../' +auto StartOfLine = Code->rfind('\n', *Offset); i think instead of regex, it would be better to just

[PATCH] D64278: Rename libclang_shared to libclang-cpp

sylvestre.ledru added a comment. @beanz works for you? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64278/new/ https://reviews.llvm.org/D64278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

MaskRay updated this revision to Diff 208615. MaskRay edited the summary of this revision. MaskRay added a comment. Implement the GCC behavior: -fomit-frame-pointer wins over -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer loses out to -momit-leaf-frame-pointer Repository: rC Clang

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

vitalybuka updated this revision to Diff 208617. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64382/new/ https://reviews.llvm.org/D64382 Files: clang/lib/CodeGen/CGDecl.cpp Index:

[PATCH] D64257: [clangd] Added highlighting for class and enum types

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:81 void addToken(SourceLocation Loc, const Decl *D) { +if (isa(D)) { + addToken(Loc, HighlightingKind::Class); hokein wrote: > nit: move this around `if

[PATCH] D64392: CodeGen: Use memset for bytewise values with any size

vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc, jfb. Herald added subscribers: cfe-commits, dexonsmith, javed.absar. Herald added a project: clang. It was already done for zeros, now we support any bytes Repository: rG LLVM Github Monorepo

[PATCH] D64257: [clangd] Added highlighting for non-builtin types

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:87 + typedef abc::$Class[[A]] AAA; + enum class $Enum[[E]] {}; + enum $Enum[[EE]] {}; hokein wrote: > could we split the enum case into a

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

vitalybuka marked 4 inline comments as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:865 +/// initializer with equal or fewer than NumStores scalar stores. +static bool canEmitStoresForInitAfterMemset(CodeGenModule , +

r365454 - Retire VS2015 Support

Author: rksimon Date: Tue Jul 9 03:12:37 2019 New Revision: 365454 URL: http://llvm.org/viewvc/llvm-project?rev=365454=rev Log: Retire VS2015 Support As proposed here: https://lists.llvm.org/pipermail/llvm-dev/2019-June/133147.html This patch raises the minimum supported version to build

[clang-tools-extra] r365453 - dummy variable extraction on a function scope

Author: sureyeaah Date: Tue Jul 9 03:12:26 2019 New Revision: 365453 URL: http://llvm.org/viewvc/llvm-project?rev=365453=rev Log: dummy variable extraction on a function scope Summary: - Added extraction to a dummy variable - using auto for the dummy variable type for now - Works on a function

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

This revision was automatically updated to reflect the committed changes. SureYeaah marked 8 inline comments as done. Closed by commit rL365453: dummy variable extraction on a function scope (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber:

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:873 return true; - if (isa(Init) || isa(Init) || + if (BWInit || isa(Init) || isa(Init) || isa(Init) || isa(Init) || vitalybuka

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:187 + std::string ExtractedVarDecl = std::string("auto ") + VarName.str() + " = " + + ExtractionCode.str() + "; "; + return

r365479 - [Syntax] Move roles into a separate enum

Author: ibiryukov Date: Tue Jul 9 06:31:43 2019 New Revision: 365479 URL: http://llvm.org/viewvc/llvm-project?rev=365479=rev Log: [Syntax] Move roles into a separate enum To align with reviewer's suggestions. Modified: cfe/trunk/include/clang/Tooling/Syntax/Nodes.h

r365480 - [ItaniumMangle] Refactor long double/__float128 mangling and fix the mangled code

Author: maskray Date: Tue Jul 9 06:32:26 2019 New Revision: 365480 URL: http://llvm.org/viewvc/llvm-project?rev=365480=rev Log: [ItaniumMangle] Refactor long double/__float128 mangling and fix the mangled code In gcc PowerPC, long double has 3 mangling schemes: -mlong-double-64: `e`

[PATCH] D64276: [ItaniumMangle] Refactor long double/__float128 mangling and fix the mangled code

This revision was automatically updated to reflect the committed changes. Closed by commit rL365480: [ItaniumMangle] Refactor long double/__float128 mangling and fix the mangled… (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D61637: [Syntax] Introduce syntax trees

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:43 + + struct Roles { +static constexpr NodeRole eof = 1; ilya-biryukov wrote: > sammccall wrote: > > we discussed offline - with 256 values, is it possible to come up

[PATCH] D64257: [clangd] Added highlighting for class and enum types

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:38 bool VisitNamedDecl(NamedDecl *ND) { -// FIXME: (De)Constructors/operator need to be highlighted some other way. +// Constructors have a TypePtr TagDecl that is a

[PATCH] D64257: [clangd] Added highlighting for class and enum types

jvikstrom updated this revision to Diff 208670. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. No longer highlighting anonymous structs as types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64257/new/

[PATCH] D64257: [clangd] Added highlighting for class and enum types

jvikstrom updated this revision to Diff 208671. jvikstrom added a comment. Changed comment in addToken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64257/new/ https://reviews.llvm.org/D64257 Files:

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

thakis added inline comments. Comment at: clang-tools-extra/trunk/clangd/refactor/tweaks/CMakeLists.txt:20 SwapIfBranches.cpp + ExtractVariable.cpp (nit: keep in alphabetical order) Repository: rL LLVM CHANGES SINCE LAST ACTION

r365485 - [OPENMP]Fix the float point semantics handling on the device.

Author: abataev Date: Tue Jul 9 07:09:53 2019 New Revision: 365485 URL: http://llvm.org/viewvc/llvm-project?rev=365485=rev Log: [OPENMP]Fix the float point semantics handling on the device. The device should use the same float point representation as the host. Previous patch fixed the handling

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:161 ++--+--+--++ +| memory mangagement | memory

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

ABataev added inline comments. Comment at: test/OpenMP/nvptx_unsupported_type_codegen.cpp:79 } - -// CHECK: define weak void @__omp_offloading_{{.+}}foo{{.+}}_l75([[BIGTYPE:.+]]* ABataev wrote: > MaskRay wrote: > > ABataev wrote: > > > MaskRay wrote: > > > >

[PATCH] D64123: Add clang-llvm-rename tool.

ruiu added a comment. I wasn't aware that clang-tidy had a such feature. readability-identifier-naming rule doesn't seem to work for this purpose out of the box. That being said, in hindsight, maybe I should have written this as a patch to clang-tidy instead of a new tool (which should have

[PATCH] D64389: [NFC] [X86] Fix scan-build complaining

pengfei created this revision. pengfei added reviewers: RKSimon, xiangzhangllvm, craig.topper. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove unused variable. This fixes bug: https://bugs.llvm.org/show_bug.cgi?id=42526 Signed-off-by: pengfei Repository: rG

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

Szelethus added a comment. In D64274#1574118 , @NoQ wrote: > Mmm, no, not really; it seems that if i introduce a checker dependency, i > also have to put the option onto the base checker, otherwise the checker name > wouldn't match when i do >

[PATCH] D60943: Delay diagnosing asm constraints that require immediates until after inlining

void added a comment. Friendly ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60943/new/ https://reviews.llvm.org/D60943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

lebedev.ri added a comment. Nice, thank you for working on this! It would be also good to have a not OpenMP-5 specific, but an overview table - which OpenMP thingy was supported starting with which Clang version, very much like https://clang.llvm.org/cxx_status.html /

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

lebedev.ri added inline comments. Comment at: clang-tools-extra/test/clang-tidy/abseil-faster-strsplit-delimiter.cpp:55 + + absl::StrSplit("ABC", R"(A)"); + // CHECK-MESSAGES: [[@LINE-1]]:25: warning: absl::StrSplit() called with a string literal consisting of a single

r365473 - [NFC] [X86] Fix scan-build complaining

Author: pengfei Date: Tue Jul 9 05:41:12 2019 New Revision: 365473 URL: http://llvm.org/viewvc/llvm-project?rev=365473=rev Log: [NFC] [X86] Fix scan-build complaining Summary: Remove unused variable. This fixes bug: https://bugs.llvm.org/show_bug.cgi?id=42526 Signed-off-by: pengfei

[PATCH] D64389: [NFC] [X86] Fix scan-build complaining

This revision was automatically updated to reflect the committed changes. Closed by commit rL365473: [NFC] [X86] Fix scan-build complaining (authored by pengfei, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6549 +static bool +pathInitializeLifetimePointer(llvm::ArrayRef Path) { + return Path.size() > 0 && llvm::all_of(Path, [=](IndirectLocalPathEntry E) { Move closer to the point of usage?

[PATCH] D64409: [libclang] Fix hang in release / assertion in debug when evaluating value-dependent types.

emilio created this revision. emilio added reviewers: Anastasia, arphaman. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. emilio edited the summary of this revision. Expression evaluator doesn't work in value-dependent types, so ensure that the precondition it

[PATCH] D64410: [WIP] Intrinsics side effects

chill created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls, javed.absar. Herald added projects: clang, LLVM. Change-Id: I49f5612ce6899004fa84b9a83c34dcd2d9af8224 Consistent types and naming for AArch64 target features (NFC) Change-Id:

[PATCH] D64410: [WIP] Intrinsics side effects

chill abandoned this revision. chill added a comment. I fail at arcanist. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64410/new/ https://reviews.llvm.org/D64410 ___ cfe-commits mailing list

r365465 - Revert rL365355 : [Syntax] Introduce syntax trees

Author: rksimon Date: Tue Jul 9 04:26:35 2019 New Revision: 365465 URL: http://llvm.org/viewvc/llvm-project?rev=365465=rev Log: Revert rL365355 : [Syntax] Introduce syntax trees Summary: A tooling-focused alternative to the AST. This commit focuses on the memory-management strategy and the

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang-tools-extra/test/clang-tidy/abseil-faster-strsplit-delimiter.cpp:55 + + absl::StrSplit("ABC", R"(A)"); + // CHECK-MESSAGES: [[@LINE-1]]:25: warning: absl::StrSplit() called with a

[PATCH] D61637: [Syntax] Introduce syntax trees

RKSimon reopened this revision. RKSimon added a comment. This revision is now accepted and ready to land. @ilya-biryukov I'm sorry but I've reverted this at rL365465 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov added a comment. In D61637#1575542 , @RKSimon wrote: > @ilya-biryukov We're seeing buildbot failures in SyntaxTests.exe : > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/50927 > >

r365466 - Reland r365355: [Syntax] Introduce syntax trees

Author: ibiryukov Date: Tue Jul 9 04:32:13 2019 New Revision: 365466 URL: http://llvm.org/viewvc/llvm-project?rev=365466=rev Log: Reland r365355: [Syntax] Introduce syntax trees With a fix to a PS4 buildbot crash. Added: cfe/trunk/include/clang/Tooling/Syntax/BuildTree.h

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov added a comment. Relanded in rL365466 with a fix to the crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61637/new/ https://reviews.llvm.org/D61637

[PATCH] D64400: [OpenCL][PR42390] Deduce addr space for templ specialization

Anastasia created this revision. Anastasia added reviewers: rjmccall, mantognini. Herald added subscribers: ebevhan, yaxunl. Addr space of a template arg doesn't affect the `QualType` of template specialization. Therefore addr space of a template specialization can be deduced during parsing of

[PATCH] D64391: [CodeComplete] an option to suppress endings for header completion

sammccall added a comment. Thanks for digging through this! Adding an option doesn't avoid a decision about what the behavior will be. >99% of users will use the default for something as fine-grained as this. So we need to find a default that works well for most people. And if it's good enough

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

sylvestre.ledru added a comment. Sure, done in r365445 thanks for your work! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 ___ cfe-commits mailing list

Dumping Clang AST to a file

Hello, Currently I am dumping the Clang AST to the console but I want to write it to a file. I have pasted the code snippet. bool HandleTopLevelDecl(DeclGroupRef DR) override { for (DeclGroupRef::iterator b = DR.begin(), e = DR.end(); b != e; ++b) { (*b)->dump(llvm::errs(),

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added a comment. In D28462#1575262 , @sylvestre.ledru wrote: > @VelocityRa could you please add it to the release notes? > https://github.com/llvm-mirror/clang/blob/master/docs/ReleaseNotes.rst > I can commit the change if you need Yeah

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

sylvestre.ledru added a comment. @VelocityRa could you please add it to the release notes? https://github.com/llvm-mirror/clang/blob/master/docs/ReleaseNotes.rst I can commit the change if you need Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/

Re: Dumping Clang AST to a file

On Tue, Jul 9, 2019 at 8:11 AM Monalisa Rout via cfe-commits wrote: > > Hello, Currently I am dumping the Clang AST to the console but I want to > write it to a file. > > I have pasted the code snippet. > > bool HandleTopLevelDecl(DeclGroupRef DR) override { > for (DeclGroupRef::iterator b =

[PATCH] D64389: [NFC] [X86] Fix scan-build complaining

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64389/new/ https://reviews.llvm.org/D64389

[PATCH] D64409: [libclang] Fix hang in release / assertion in debug when evaluating value-dependent types.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365490: [libclang] Fix hang in release / assertion in debug when evaluating value… (authored by emilio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev marked an inline comment as done. ABataev added a comment. In D64356#1574981 , @NoQ wrote: > Ok, so i think i more or less understand where this is going and i like it! > My only concern about making sure that used-expressions don't appear in

r365498 - Ignore trailing NullStmts in StmtExprs for GCC compatibility.

Author: aaronballman Date: Tue Jul 9 08:02:07 2019 New Revision: 365498 URL: http://llvm.org/viewvc/llvm-project?rev=365498=rev Log: Ignore trailing NullStmts in StmtExprs for GCC compatibility. Ignore trailing NullStmts in compound expressions when determining the result type and value. This

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rL365500: [OpenCL][Sema] Improve address space support for blocks (authored by mantognini, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64409: [libclang] Fix hang in release / assertion in debug when evaluating value-dependent types.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64409/new/ https://reviews.llvm.org/D64409

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia created this revision. Anastasia added reviewers: svenvh, mantognini, stuart, neil.hickey. Herald added subscribers: ebevhan, yaxunl. Added documentation of C++ for OpenCL mode into Clang User Manual and Language Extensions document. https://reviews.llvm.org/D64418 Files:

r365490 - [libclang] Fix hang in release / assertion in debug when evaluating value-dependent types.

Author: emilio Date: Tue Jul 9 07:27:01 2019 New Revision: 365490 URL: http://llvm.org/viewvc/llvm-project?rev=365490=rev Log: [libclang] Fix hang in release / assertion in debug when evaluating value-dependent types. Expression evaluator doesn't work in value-dependent types, so ensure that

[PATCH] D64409: [libclang] Fix hang in release / assertion in debug when evaluating value-dependent types.

emilio added a comment. Thanks for the review as always @Anastasia ^.^ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64409/new/ https://reviews.llvm.org/D64409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64257: [clangd] Added highlighting for class and enum types

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:38 bool VisitNamedDecl(NamedDecl *ND) { -// FIXME: (De)Constructors/operator need to be highlighted some other way. +// Constructors have a TypePtr TagDecl that is a Function,

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev marked 3 inline comments as done. ABataev added inline comments. Comment at: lib/Analysis/CFG.cpp:4746-4750 + D->for_each_used_expr([this, ](Expr *E) { +assert(E && "Expected expression."); +if (CFGBlock *R = Visit(E)) + B = R; + }); NoQ

[PATCH] D64383: build: use multiple `install` rather than building up a list

ldionne added a comment. I like that. Almost anything that helps us abolish global variables and lists (here `LIBCXX_INSTALL_TARGETS`) in the CMake scripts is a good thing. Comment at: src/CMakeLists.txt:441 + if (LIBCXX_INSTALL_STATIC_LIBRARY) +install(TARGETS

[PATCH] D63835: [Syntax] Add nodes for most common statements

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. Submitting a few comments to start up the discussions. The actual changes will follow. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:99 /// An abstract node for C++ statements, e.g.

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in r365498. Thank you for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57086/new/ https://reviews.llvm.org/D57086 ___ cfe-commits

[PATCH] D64383: build: use multiple `install` rather than building up a list

compnerd marked an inline comment as done. compnerd added a comment. @ldionne - that was exactly the motivation for this change - it always takes me a couple of reads to figure out what we are trying to do here. Comment at: src/CMakeLists.txt:441 + if

r365499 - [OpenCL][Sema] Fix builtin rewriting

Author: mantognini Date: Tue Jul 9 08:04:23 2019 New Revision: 365499 URL: http://llvm.org/viewvc/llvm-project?rev=365499=rev Log: [OpenCL][Sema] Fix builtin rewriting This patch ensures built-in functions are rewritten using the proper parent declaration. Existing tests are modified to run in

r365500 - [OpenCL][Sema] Improve address space support for blocks

Author: mantognini Date: Tue Jul 9 08:04:27 2019 New Revision: 365500 URL: http://llvm.org/viewvc/llvm-project?rev=365500=rev Log: [OpenCL][Sema] Improve address space support for blocks Summary: This patch ensures that the following code is compiled identically with -cl-std=CL2.0 and -fblocks

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

kadircet updated this revision to Diff 208686. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64247/new/ https://reviews.llvm.org/D64247 Files:

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:653 +auto PI = CDB.getProjectInfo(File); +assert(PI && "Found CDB but no ProjectInfo!"); + sammccall wrote: > This looks like a bad assertion: it should be OK to

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

kadircet updated this revision to Diff 208697. kadircet added a comment. - Rearrange changes to get a better diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64247/new/ https://reviews.llvm.org/D64247 Files:

[libunwind] r365505 - [libunwind] Fix Unwind-EHABI.cpp:getByte on big-endian targets

Author: miyuki Date: Tue Jul 9 08:29:06 2019 New Revision: 365505 URL: http://llvm.org/viewvc/llvm-project?rev=365505=rev Log: [libunwind] Fix Unwind-EHABI.cpp:getByte on big-endian targets Summary: The function getByte is dependent on endianness and the current behavior is incorrect on

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

MaskRay updated this revision to Diff 208704. MaskRay added a comment. Rebase The openmp issue was fixed by r365485 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64277/new/ https://reviews.llvm.org/D64277 Files: include/clang/Driver/Options.td

[PATCH] D62855: [clangd] Implementation of auto type expansion.

kuhnel added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:172 +namespace { +/// Computes the deduced type at a given location by visiting the relevant sammccall wrote: > It looks like this has been moved from somewhere (at least code looks >

[PATCH] D62855: [clangd] Implementation of auto type expansion.

kuhnel updated this revision to Diff 208705. kuhnel marked 22 inline comments as done. kuhnel added a comment. Allrighty then, next update: - moved 2 helper funtions to `AST.cpp` - added `ASTTests.cpp` - added more tests - removed a lot of redundant code - implemented corner case for not

[PATCH] D62855: [clangd] Implementation of auto type expansion.

kuhnel updated this revision to Diff 208706. kuhnel added a comment. fixed typo on "Deducted" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62855/new/ https://reviews.llvm.org/D62855 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdenny added inline comments. Comment at: cfe/trunk/unittests/Rewrite/CMakeLists.txt:12 clangRewrite + clangTooling ) jdenny wrote: > thakis wrote: > > This makes RewriteTests depend on clangTooling, and in follow-ups on > > clangFrontend and

[PATCH] D64423: [OpenMP] Simplify getFloatTypeSemantics

MaskRay created this revision. MaskRay added a reviewer: ABataev. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D64423 Files: lib/AST/ASTContext.cpp Index: lib/AST/ASTContext.cpp

r365509 - Revert Revert Devirtualize destructor of final class.

Author: yamauchi Date: Tue Jul 9 08:57:29 2019 New Revision: 365509 URL: http://llvm.org/viewvc/llvm-project?rev=365509=rev Log: Revert Revert Devirtualize destructor of final class. Revert r364359 and recommit r364100. r364100 was reverted as r364359 due to an internal test failure, but it

[PATCH] D64257: [clangd] Added highlighting for class and enum types

jvikstrom updated this revision to Diff 208708. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64257/new/ https://reviews.llvm.org/D64257 Files:

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:39 +return; + Finder->addMatcher(varDecl(hasGlobalStorage()).bind("var"), this); +} czhang wrote: > aaron.ballman wrote: > > Do you

[PATCH] D63857: [clang-doc] Add a structured HTML generator

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM, unless Jake has further comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:503 + } + // std::move(Nodes.begin(), Nodes.end(),

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun marked 6 inline comments as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:7076 +auto Prefix = llvm::makeArrayRef(Path).drop_back(); + if (pathInitializeLifetimePointer(Prefix)) +IsLifetimePtrInitWithTempOwner =

  1   2   3   >