[clang-tools-extra] r365778 - [clangd] Remove an extra ";", NFC

Author: hokein Date: Thu Jul 11 06:58:56 2019 New Revision: 365778 URL: http://llvm.org/viewvc/llvm-project?rev=365778&view=rev Log: [clangd] Remove an extra ";", NFC Modified: clang-tools-extra/trunk/clangd/index/Background.h Modified: clang-tools-extra/trunk/clangd/index/Background.h URL:

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

This revision was automatically updated to reflect the committed changes. Closed by commit rL365777: Added mapping for pointers captured in Lambdas in OpenMP target regions, (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D64400: [OpenCL][PR42390] Deduce addr space for templ specialization

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaType.cpp:7421 + // - template specialization as addr space in template argument doesn't + // affect specialization. + (T->isDependentType() && (!T->isPointerType

r365777 - Added mapping for pointers captured in Lambdas in OpenMP target regions,

Author: abataev Date: Thu Jul 11 06:54:26 2019 New Revision: 365777 URL: http://llvm.org/viewvc/llvm-project?rev=365777&view=rev Log: Added mapping for pointers captured in Lambdas in OpenMP target regions, by David Truby. Summary: This adds a zero length array section mapping for each pointer ca

[PATCH] D64489: [clangd][QueryDriver] Use language from underlying database if possible

This revision was automatically updated to reflect the committed changes. Closed by commit rL365776: [clangd][QueryDriver] Use language from underlying database if possible (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D64565: [clangd] Don't run the prepare for tweaks that are disabled.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Previously, we ran the prepare, even for the tweaks that are disabled. Repository: rG LLVM Github Monorepo https://re

[clang-tools-extra] r365776 - [clangd][QueryDriver] Use language from underlying database if possible

Author: kadircet Date: Thu Jul 11 06:47:46 2019 New Revision: 365776 URL: http://llvm.org/viewvc/llvm-project?rev=365776&view=rev Log: [clangd][QueryDriver] Use language from underlying database if possible Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits

[PATCH] D64400: [OpenCL][PR42390] Deduce addr space for templ specialization

Anastasia updated this revision to Diff 209205. Anastasia added a comment. - Moved addr space inference of pointee type into template instantiation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64400/new/ https://reviews.llvm.org/D64400 Files: lib/Sema/TreeTransform.h test/SemaOpe

[PATCH] D64504: Various minor tweaks to CLCompatOptions.td

thakis closed this revision. thakis added a comment. r365721 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64504/new/ https://reviews.llvm.org/D64504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang-tools-extra] r365773 - [clangd] Add priorities to background index queue, extract to separate class

Author: sammccall Date: Thu Jul 11 06:34:38 2019 New Revision: 365773 URL: http://llvm.org/viewvc/llvm-project?rev=365773&view=rev Log: [clangd] Add priorities to background index queue, extract to separate class Reviewers: kadircet Subscribers: mgorny, ilya-biryukov, MaskRay, jkorous, arphaman,

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer marked an inline comment as done. SjoerdMeijer added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1015 + .Default(""); + assert(Str.size() && "Unexpected pragma name"); + return Str; I guess this does behave slightly d

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

ABataev added a comment. In D64558#1580361 , @DavidTruby wrote: > I don't have commit access so can't commit this myself, could you do it for > me? Thanks Sure, thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64558/new/ ht

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 209199. SureYeaah marked 6 inline comments as done. SureYeaah added a comment. Changed claimRange to use toHalfOpenFileRange Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: samparker, dmgreen, Meinersbur. Yesterday I was a bit distracted by loop pragma parsing (D64471 ), but still am a bit today too (this patch). https://reviews.llvm.org/D64564 Files: clang/lib/Pa

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

SureYeaah updated this revision to Diff 209193. SureYeaah added a comment. Minor fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64562/new/ https://reviews.llvm.org/D64562 Files: clang-tools-extra/clangd/SourceCode.cpp clang-tools-extra/cl

[PATCH] D64563: Updated the signature for some stack related intrinsics (CLANG)

cdevadas created this revision. cdevadas added a reviewer: arsenm. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. This patch includes the intrinsics int_addressofreturnaddress, int_frameaddress & int_sponentry. This patch should go along with the changes in https://re

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - Fixed toHalfOpenFileRange to work for macros as well as template instantiations - Added unit tests

[PATCH] D64489: [clangd][QueryDriver] Use language from underlying database if possible

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:121 // Should we also preserve flags like "-sysroot", "-nostdinc" ? - const llvm::StringRef Args[] = { - Driver, "-E", "-x", driver::ty

[PATCH] D64489: [clangd][QueryDriver] Use language from underlying database if possible

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:121 // Should we also preserve flags like "-sysroot", "-nostdinc" ? - const llvm::StringRef Args[]

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

DavidTruby added a comment. I don't have commit access so can't commit this myself, could you do it for me? Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64558/new/ https://reviews.llvm.org/D64558 ___ cfe-commits mailing list cfe-co

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64558/new/ https://reviews.llvm.org/D64558 ___ cfe-commits mailing list cfe-commits@l

[clang-tools-extra] r365764 - [clangd] Remove the extra ";", NFC

Author: hokein Date: Thu Jul 11 05:31:18 2019 New Revision: 365764 URL: http://llvm.org/viewvc/llvm-project?rev=365764&view=rev Log: [clangd] Remove the extra ";", NFC Modified: clang-tools-extra/trunk/clangd/unittests/TestFS.cpp Modified: clang-tools-extra/trunk/clangd/unittests/TestFS.cpp

[PATCH] D64556: [clangd] Fix an assertion crash in "ExtractVariable" tweak

This revision was automatically updated to reflect the committed changes. Closed by commit rL365763: [clangd] Fix an assertion crash in "ExtractVariable" tweak (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

DavidTruby updated this revision to Diff 209184. DavidTruby added a comment. Moved common VarLVal initialisation out of the if/else statement CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64558/new/ https://reviews.llvm.org/D64558 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/

[clang-tools-extra] r365763 - [clangd] Fix an assertion crash in "ExtractVariable" tweak

Author: hokein Date: Thu Jul 11 05:29:01 2019 New Revision: 365763 URL: http://llvm.org/viewvc/llvm-project?rev=365763&view=rev Log: [clangd] Fix an assertion crash in "ExtractVariable" tweak Summary: GetTypePtr requires that the type should not be null, otherwise we hit an assertion, we should u

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8114 + } else { +LValue VarLVal = CGF.EmitLValueForField(VDLVal, It->second); +RValue VarRVal = CGF.EmitLoadOfLValue(VarLVal, RD->getLocation()); I think you csn use `

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

DavidTruby created this revision. DavidTruby added a reviewer: ABataev. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. This adds a zero length array section mapping for each pointer captured by a lambda that is used in a target region, as per section 2.

[PATCH] D64556: [clangd] Fix an assertion crash in "ExtractVariable" tweak

hokein updated this revision to Diff 209172. hokein marked an inline comment as done. hokein added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64556/new/ https://reviews.llvm.org/D64556 Files: clang-tools-extra/clan

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro added a comment. In D64482#1579850 , @MaskRay wrote: > > Honestly I find such enforced C/C++ difference very unfortunate... e.g. > > if (Opts.CPlusPlus) > Builder.defineMacro("_GNU_SOURCE"); You may not like them, but there are plenty of exa

[PATCH] D64556: [clangd] Fix an assertion crash in "ExtractVariable" tweak

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Selection.cpp:361 return nullptr; for (const Node *Ancestor = Root;; Ancestor = Ancestor->Children.front()) { +asse

[PATCH] D64556: [clangd] Fix an assertion crash in "ExtractVariable" tweak

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:367 } - return nullptr; } sorry, the previous patch rL365751 didn't fix the crash, and I re-read the code more thoroughly, I think we w

[PATCH] D64556: [clangd] Fix an assertion crash in "ExtractVariable" tweak

hokein created this revision. hokein added reviewers: sammccall, SureYeaah. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. GetTypePtr requires that the type should not be null, otherwise we hit an assertion, we should use getTypePtrOrN

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: clang. A new function will be added to get the original SourceLocation for a SourceLocation that was impor

[clang-tools-extra] r365756 - [clangd] Fix windows buildbots

Author: kadircet Date: Thu Jul 11 03:41:58 2019 New Revision: 365756 URL: http://llvm.org/viewvc/llvm-project?rev=365756&view=rev Log: [clangd] Fix windows buildbots Modified: clang-tools-extra/trunk/clangd/unittests/GlobalCompilationDatabaseTests.cpp Modified: clang-tools-extra/trunk/clang

[PATCH] D64540: [CGDebugInfo] Simplfiy EmitFunctionDecl parameters, NFC

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. LGTM! Thanks @vsk! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64540/new/ https://reviews.llvm.org/D64540 ___ cfe-commits mailing

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:172 + const HighlightingToken &Rhs) { + return Lhs.R.start.line == Rhs.R.start.line + ? Lhs.R.start.character < Rhs.R.start.character -

[clang-tools-extra] r365751 - [clangd] Add a missing "return nullptr; " to the SelectionTree::commonAncestor.

Author: hokein Date: Thu Jul 11 03:06:24 2019 New Revision: 365751 URL: http://llvm.org/viewvc/llvm-project?rev=365751&view=rev Log: [clangd] Add a missing "return nullptr;" to the SelectionTree::commonAncestor. This would fix some mysterious crashes on codeAction in clangd. Modified: clang-

[clang-tools-extra] r365748 - [clangd] Reland rL365634

Author: kadircet Date: Thu Jul 11 02:54:31 2019 New Revision: 365748 URL: http://llvm.org/viewvc/llvm-project?rev=365748&view=rev Log: [clangd] Reland rL365634 This was reverted in rL365678, the failure was due to YAML parsing of compile_commands.json. Converting backslashes to forward slashes t

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

ktkachov updated this revision to Diff 209149. ktkachov added a comment. Fix comments plus an offline comment I had (copy-pasto in an assert message) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64495/new/ https://reviews.llvm.org/D64495 Files: clang/include/clang/Basic/BuiltinsAArc

[PATCH] D64492: [clangd] Added highlightings for namespace specifiers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365745: [clangd] Added highlightings for namespace specifiers. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[clang-tools-extra] r365745 - [clangd] Added highlightings for namespace specifiers.

Author: jvikstrom Date: Thu Jul 11 02:29:16 2019 New Revision: 365745 URL: http://llvm.org/viewvc/llvm-project?rev=365745&view=rev Log: [clangd] Added highlightings for namespace specifiers. Summary: Added highlightings for namespace specifiers. Reviewers: hokein, sammccall, ilya-biryukov Subsc

[clang-tools-extra] r365742 - Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class."

Author: hokein Date: Thu Jul 11 01:54:28 2019 New Revision: 365742 URL: http://llvm.org/viewvc/llvm-project?rev=365742&view=rev Log: Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class." This reverts r365675 (git commit 43d75f977853c3ec891a440c362b2df

r365742 - Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class."

Author: hokein Date: Thu Jul 11 01:54:28 2019 New Revision: 365742 URL: http://llvm.org/viewvc/llvm-project?rev=365742&view=rev Log: Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class." This reverts r365675 (git commit 43d75f977853c3ec891a440c362b2df

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

nathanchance added a comment. This change breaks building the Linux kernel for arm32 (at least): ... YACCscripts/dtc/dtc-parser.tab.c HOSTCC scripts/dtc/yamltree.o HOSTCC scripts/dtc/dtc-parser.tab.o HOSTCC scripts/dtc/dtc-lexer.lex.o HOSTLD scripts/dtc/dtc UPD

[PATCH] D64492: [clangd] Added highlightings for namespace specifiers.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good from my side, just a comment for the TM scope name. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:73 // This check is for not getting two entr

[PATCH] D61909: Add Clang shared library with C++ exports

aheejin added a comment. `CLANG_LINK_CLANG_DYLIB=ON` does not seem to work with `LLVM_INSTALL_TOOLCHAIN_ONLY=ON`. I filed a bug report: https://bugs.llvm.org/show_bug.cgi?id=42575 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61909/new/ https://reviews.llvm.org

[PATCH] D63503: cmake: Add CLANG_LINK_CLANG_DYLIB option

aheejin added a comment. `CLANG_LINK_CLANG_DYLIB=ON` does not seem to work with `LLVM_INSTALL_TOOLCHAIN_ONLY=ON`. I filed a bug report: https://bugs.llvm.org/show_bug.cgi?id=42575 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63503/new/ https://reviews.llvm.org/

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/CodeGen/CGDeclCXX.cpp:132 + Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast( + CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy); r

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

hokein added a comment. Thanks for bringing this up and implementing it. I haven't looked into the details of the patch, just some high-level comments: - the scope of the patch seems a bit unclear to me, what's the problem we are trying to solve? - the patch looks like calculating the diff/delt

[PATCH] D64492: [clangd] Added highlightings for namespace specifiers.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:87 + bool TraverseNestedNameSpecifierLoc(NestedNameSpecifierLoc NNSLoc) { +if (NestedNameSpecifier *NNS = NNSLoc.getNestedNameSpecifier()) + if (NNS->getKind() == NestedNameSp

[PATCH] D64492: [clangd] Added highlightings for namespace specifiers.

jvikstrom updated this revision to Diff 209139. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Moved alias target namespace add token to another function and added testcase for global namespace specifier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: r364424 - [clang/DIVar] Emit the flag for params that have unmodified value

Hi Vedant, This looks good! Thanks! Regards, Djordje On 11.7.19. 02:11, Vedant Kumar wrote: > Hi Djordje, > > Just a heads-up that I’ve landed r365716 to fix a crash in a stage2 build of > AppleClang with -femit-debug-entry-values enabled. > > I went ahead and landed the fix as it seemed simp

<    1   2   3