[PATCH] D64687: [clang] Revert "Remove __VERSION__"

MaskRay closed this revision. MaskRay added a comment. In D64687#1584337 , @sylvestre.ledru wrote: > I went ahead and committed your revert in r365992. Thanks! > > Next time, please remove the clang/ from your patch > arc could not apply it: I think

[PATCH] D64062: Remove __VERSION__

sylvestre.ledru reopened this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. @rnk looks like it is too risky to remove it. What about changing it from #define __VERSION__ "4.2.1 Compatible Clang 7.0.1 (tags/RELEASE_701/final)" to #define

[PATCH] D64687: [clang] Revert "Remove __VERSION__"

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. I went ahead and committed your revert in r365992. Thanks! Next time, please remove the clang/ from your patch arc could not apply it: Committing 'D64687: [clang] Revert

[PATCH] D64676: Support __seg_fs and __seg_gs on x86

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64676/new/ https://reviews.llvm.org/D64676

[clang-tools-extra] r365993 - Simplify with llvm::is_contained. NFC

Author: maskray Date: Sat Jul 13 00:23:12 2019 New Revision: 365993 URL: http://llvm.org/viewvc/llvm-project?rev=365993=rev Log: Simplify with llvm::is_contained. NFC Modified: clang-tools-extra/trunk/clang-tidy/bugprone/AssertSideEffectCheck.cpp

r365992 - This reverts commit 632a36bfcfc8273c1861f04ff6758d863c47c784.

Author: sylvestre Date: Fri Jul 12 23:27:35 2019 New Revision: 365992 URL: http://llvm.org/viewvc/llvm-project?rev=365992=rev Log: This reverts commit 632a36bfcfc8273c1861f04ff6758d863c47c784. Some targets such as Python 2.7.16 still use VERSION in their builds. Without VERSION defined, the

[PATCH] D64656: Ensure placeholder instruction for cleanup is created

oydale updated this revision to Diff 209690. oydale added a comment. Initial attempt at IR output checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64656/new/ https://reviews.llvm.org/D64656 Files: clang/lib/CodeGen/CGExprAgg.cpp

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz updated this revision to Diff 209686. saar.raz added a comment. Herald added a subscriber: erik.pilkington. Rebase onto trunk. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41217/new/ https://reviews.llvm.org/D41217 Files: include/clang/AST/ExprCXX.h

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 209689. saar.raz added a comment. Create ASTConstraintSatisfaction for correctly storing constraint satisfaction data in AST nodes, add support for mangling of ConceptSpecializtationExprs Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D64391: [CodeComplete] an option to suppress endings for header completion

richard9404 added a comment. I think we should first think about what are participating in a modularised development environment. In terms of code completion, there are usually four layers: - a "backend" which knows everything about the language, e.g. ClangSema - a "frontend" which follows

[PATCH] D64656: Ensure placeholder instruction for cleanup is created

oydale updated this revision to Diff 209683. oydale added a comment. Replaced -emit-obj with -emit-llvm-only in test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64656/new/ https://reviews.llvm.org/D64656 Files:

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 209685. Manikishan added a comment. This is the squashed commit of both Adding NetBSD Style and adding sortNetBSDIncludes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 Files:

[PATCH] D64656: Ensure placeholder instruction for cleanup is created

oydale added a comment. I have added my initial attempt at verifying the cleanup code generated in this scenario, it's probably going to require modifications. The original IR can be found at https://reviews.llvm.org/P8156. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r365994 - [CMake][Fuchsia] Define asan+noexcept multilib

Author: phosek Date: Sat Jul 13 01:07:10 2019 New Revision: 365994 URL: http://llvm.org/viewvc/llvm-project?rev=365994=rev Log: [CMake][Fuchsia] Define asan+noexcept multilib Using noexcept multilib with -fno-exceptions can lead to significant space savings when statically linking libc++abi

[PATCH] D41284: [Concepts] Associated constraints infrastructure.

saar.raz updated this revision to Diff 209688. saar.raz added a comment. Rebase onto trunk. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41284/new/ https://reviews.llvm.org/D41284 Files: include/clang/AST/ASTNodeTraverser.h include/clang/AST/DeclTemplate.h

[PATCH] D64656: Ensure placeholder instruction for cleanup is created

lebedev.ri added a comment. Hm, i have a question about this fix. As it can be seen the C++17 code is successfully codegened by clang to LLVM IR, and the actual failure is in LLVM middle-end optimization pass: https://godbolt.org/z/P3RB23 1. Please file a bug about that pass crash, include that

[PATCH] D64140: [CMake][Fuchsia] Define asan+noexcept multilib

This revision was automatically updated to reflect the committed changes. Closed by commit rL365994: [CMake][Fuchsia] Define asan+noexcept multilib (authored by phosek, committed by ). Herald added subscribers: llvm-commits, javed.absar. Herald added a project: LLVM. Changed prior to commit:

r365995 - Fix -Wdocumentation warning. NFCI.

Author: rksimon Date: Sat Jul 13 01:08:43 2019 New Revision: 365995 URL: http://llvm.org/viewvc/llvm-project?rev=365995=rev Log: Fix -Wdocumentation warning. NFCI. Modified: cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.h Modified:

[PATCH] D64656: Ensure placeholder instruction for cleanup is created

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. Sorry, i still don't like the test. You want to check the produced IR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan created this revision. Manikishan added reviewers: cfe-commits, mgorny, christos, MyDeveloperDay. Herald added a subscriber: krytarowski. Herald added a project: clang. Manikishan added subscribers: mgorny, christos. This new Style rule is made as a part of adding support for NetBSD

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane updated this revision to Diff 209705. jpakkane added a comment. Fixed issues found in code review. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671 Files:

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane marked 10 inline comments as done. jpakkane added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/InitLocalVariablesCheck.cpp:26-29 + if(!MatchedDecl->isLocalVarDecl()) +return; + if(MatchedDecl->hasInit()) +return; lebedev.ri

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane updated this revision to Diff 209706. jpakkane marked an inline comment as done. jpakkane added a comment. Fix missing spaces in documentation. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 209695. saar.raz added a comment. Move ConstraintSatisfaction to ASTConcept.h Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41569/new/ https://reviews.llvm.org/D41569 Files: include/clang/AST/ASTConcept.h

[PATCH] D64656: Ensure placeholder instruction for cleanup is created

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. In D64656#1584437 , @oydale wrote: > My understanding of the issue is that clang emits incorrect IR. Without my > fix and when disabling

[PATCH] D64696: Adds a warning when an inline Doxygen comment has no argument

Mordante created this revision. Mordante added reviewers: gribozavr, rsmith. Mordante added a project: clang. It warns for for comments like /** \pre \em */ where \em has no argument This warning is enabled with the -Wdocumentation option. Repository: rG LLVM Github Monorepo

[PATCH] D64656: Ensure placeholder instruction for cleanup is created

oydale accepted this revision. oydale added a comment. Feel free to commit this patch on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64656/new/ https://reviews.llvm.org/D64656 ___

r366010 - Remove extra ';' to silent compiler warning.

Author: hliao Date: Sat Jul 13 12:49:39 2019 New Revision: 366010 URL: http://llvm.org/viewvc/llvm-project?rev=366010=rev Log: Remove extra ';' to silent compiler warning. - Plus extra style formatting. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp

r366007 - Template-related improvements to Visual Studio visualizers

Author: mps Date: Sat Jul 13 08:27:53 2019 New Revision: 366007 URL: http://llvm.org/viewvc/llvm-project?rev=366007=rev Log: Template-related improvements to Visual Studio visualizers Modified: cfe/trunk/utils/ClangVisualizers/clang.natvis Modified:

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

Mordante updated this revision to Diff 209703. Mordante added a comment. Addresses @rjmccall's remarks. Fixes the tests for the nested lambda's. As suspected the blocks also have the same nesting limit, thus added a test for them. CHANGES SINCE LAST ACTION

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

Mordante added a comment. Thanks for the review. I don't have SVN access, can you commit these changes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63975/new/ https://reviews.llvm.org/D63975 ___ cfe-commits mailing list

[PATCH] D64656: Ensure placeholder instruction for cleanup is created

lebedev.ri added a comment. In D64656#1584424 , @lebedev.ri wrote: > Hm, i have a question about this fix. > As it can be seen the C++17 code is successfully codegened by clang to LLVM > IR, and the actual failure is in LLVM middle-end optimization

[PATCH] D64656: Ensure placeholder instruction for cleanup is created

oydale added a comment. My understanding of the issue is that clang emits incorrect IR. Without my fix and when disabling the assertion mentioned in the commit message by commenting it out, llvm-lit gives the following output when executed against the minimal test case in the current version

[PATCH] D64656: Ensure placeholder instruction for cleanup is created

oydale updated this revision to Diff 209701. oydale added a comment. Changed test to use CHECK-NEXT, -discard-value-names, and pattern matching Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64656/new/ https://reviews.llvm.org/D64656 Files:

[PATCH] D64062: Remove __VERSION__

saugustine added a comment. From the failure mode I was seeing, any value at all for __VERSION__ will be fine, as long as it is a valid preprocessor string. It would also solve this particular problem to not define __GNUC__, but I as that would create other, more severe, problems, as long as

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao added a comment. Could someone please take a look? I think I've addressed all of Jonas's comments above. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61989/new/ https://reviews.llvm.org/D61989

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63975/new/ https://reviews.llvm.org/D63975 ___ cfe-commits mailing list

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan updated this revision to Diff 209710. ziangwan added a comment. Update diff: 1. fix the spelling issue `may loses integer precision` -> `may lose precision` 2. issue more accurate warnings when `int->float` conversion involves constant integer. CHANGES SINCE LAST ACTION

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan marked 9 inline comments as done. ziangwan added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:11430 +SmallString<32> PrettyTargetValue; +TargetFloatValue.toString(PrettyTargetValue, + TargetPrecision);