r366165 - reland "add -fthinlto-index= option to clang-cl"

2019-07-15 Thread Bob Haarman via cfe-commits
Author: inglorion Date: Mon Jul 15 18:35:49 2019 New Revision: 366165 URL: http://llvm.org/viewvc/llvm-project?rev=366165&view=rev Log: reland "add -fthinlto-index= option to clang-cl" Summary: This is a reland of r366146, adding in the previously missing '--' flag that prevents filenames from be

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'

2019-07-15 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1728 } +assert(!FpKind.empty() && "unknown frame-pointer"); +FuncAttrs.addAttribute("frame-pointer", FpKind); The `assert` here is not very necessary. Comment

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

2019-07-15 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64089/new/ https://reviews.llvm.org/D64089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'

2019-07-15 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen updated this revision to Diff 210014. ychen marked an inline comment as done. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56353/new/ https://reviews.llvm.org/D56353 Files: clang/include/clang/Basic/CodeGen

r366169 - Revert "[OPENMP]Add support for analysis of if clauses."

2019-07-15 Thread Ali Tamur via cfe-commits
Author: tamur Date: Mon Jul 15 20:20:15 2019 New Revision: 366169 URL: http://llvm.org/viewvc/llvm-project?rev=366169&view=rev Log: Revert "[OPENMP]Add support for analysis of if clauses." This reverts commit rL366068. The patch broke 86 tests under clang/test/OpenMP/ when run with address sanit

Re: r366123 - ARM MTE stack sanitizer.

2019-07-15 Thread Amara Emerson via cfe-commits
Hi Evgeniy, This commit looks like it broke the lldb bot: http://green.lab.llvm.org/green/job/lldb-cmake/31011/ Can you take a look? Amara > On Jul 15, 2019, at 1:02 PM, Evgeniy Stepanov via cfe-commits > wrote: > > Author: eugenis >

[PATCH] D63954: Add lifetime categories attributes

2019-07-15 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4164 + let Content = [{ +When annotating a class ``O`` with ``[[gsl::Owner(T)]]``, then each function +that returns cv-qualified ``T&`` or ``T*`` is assumed to return a mgehre wro

[PATCH] D64680: [analyzer] MallocChecker: Prevent Integer Set Library false positives

2019-07-15 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2547-2548 + StringRef FunctionStr = ""; + if (const Decl *D = C.getStackFrame()->getDecl()) +if (const FunctionDecl *FD = D->getAsFunction()) + FunctionStr = Lexer::getSourceText

r366159 - Allow for vendor prefixes in a list test

2019-07-15 Thread Nathan Lanza via cfe-commits
Author: lanza Date: Mon Jul 15 17:57:50 2019 New Revision: 366159 URL: http://llvm.org/viewvc/llvm-project?rev=366159&view=rev Log: Allow for vendor prefixes in a list test Summary: Preprocessor/init.c contains a line that explicitly checks for the string __VERSION__ "Clang{{.*}} It's valid to

r366166 - Change a lit test to permit vendor specific clang version

2019-07-15 Thread Nathan Lanza via cfe-commits
Author: lanza Date: Mon Jul 15 19:05:52 2019 New Revision: 366166 URL: http://llvm.org/viewvc/llvm-project?rev=366166&view=rev Log: Change a lit test to permit vendor specific clang version A test manually checks for the string `__VERSION__ "Clang`. This needs to permit vendor specific variants.

[PATCH] D41412: [libcxx] implement concat() and split()

2019-07-15 Thread Tobias Grosser via Phabricator via cfe-commits
grosser added a comment. Hi @timshen, I am very interested in these patches. Any chance you can take up the upstreaming process again? Best, Tobias CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41412/new/ https://reviews.llvm.org/D41412

r366186 - Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO"

2019-07-15 Thread Stephan Bergmann via cfe-commits
Author: sberg Date: Mon Jul 15 23:23:27 2019 New Revision: 366186 URL: http://llvm.org/viewvc/llvm-project?rev=366186&view=rev Log: Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO" i.e., recent 5745eccef54ddd3caca278d1d292a88b2281528b: * Bump the function_type_mismatch handler

[PATCH] D61479: Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO"

2019-07-15 Thread Stephan Bergmann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366186: Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO" (authored by sberg, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D6

Re: r365954 - Reland [clang] DirectoryWatcher

2019-07-15 Thread Mikael Holmén via cfe-commits
Hi, On 2019-07-15 20:26, Jan Korous wrote: > Hi Mikael, > > Thanks for the notice. > > How about this? > https://reviews.llvm.org/D64764 > Yes that works for me! Thanks! Mikael > Jan > >> On Jul 14, 2019, at 11:45 PM, Mikael Holmén >> mailto:mikael.hol...@ericsson.com>> wrote: >> >> Hi Jan

[PATCH] D61479: Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO"

2019-07-15 Thread Stephan Bergmann via Phabricator via cfe-commits
sberg added a comment. eh, the summary here doesn't get updated from the actual git commit message :( thanks for the reviews! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61479/new/ https://reviews.llvm.org/D61479 _

<    1   2   3