[PATCH] D65153: [clangd] Also accept flags from CLANGD_FLAGS variable.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/test/log.test:9 +CHECK: Starting LSP over stdin/stdout + nit: remove the extra trailing blank line? Repository:

[clang-tools-extra] r366991 - [clangd] Also accept flags from CLANGD_FLAGS variable.

Author: sammccall Date: Thu Jul 25 00:54:48 2019 New Revision: 366991 URL: http://llvm.org/viewvc/llvm-project?rev=366991=rev Log: [clangd] Also accept flags from CLANGD_FLAGS variable. This simplifies various workflows, particularly in debugging/development. e.g. editors will tend to propagate

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

xbolva00 resigned from this revision. xbolva00 added a comment. This is not okay. Your patch has also same C++11 and higher issues related to narrowing (multiple warnings) as my old patch. I told you about it my issue. I asked you if your patch has no such issues - you said no. I has asked

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

balazske updated this revision to Diff 211689. balazske added a comment. Herald added a subscriber: mgorny. Added clangFrontend to CMakeLists.txt. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64638/new/ https://reviews.llvm.org/D64638 Files:

r366989 - [Clang] New loop pragma vectorize_predicate

Author: sjoerdmeijer Date: Thu Jul 25 00:33:13 2019 New Revision: 366989 URL: http://llvm.org/viewvc/llvm-project?rev=366989=rev Log: [Clang] New loop pragma vectorize_predicate This adds a new vectorize predication loop hint: #pragma clang loop vectorize_predicate(enable) that can be used

[PATCH] D64744: #pragma clang loop vectorize_predicate(enable|disable)

SjoerdMeijer added a comment. Many thanks for reviewing! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64744/new/ https://reviews.llvm.org/D64744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64744: #pragma clang loop vectorize_predicate(enable|disable)

This revision was automatically updated to reflect the committed changes. Closed by commit rL366989: [Clang] New loop pragma vectorize_predicate (authored by SjoerdMeijer, committed by ). Changed prior to commit: https://reviews.llvm.org/D64744?vs=211096=211678#toc Repository: rL LLVM

[PATCH] D65139: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

sammccall updated this revision to Diff 211679. sammccall added a comment. Rather than handling arbitrary trees, exploit the fact that the operator is left-associative. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65139/new/

[PATCH] D65153: [clangd] Also accept flags from CLANGD_FLAGS variable.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366991: [clangd] Also accept flags from CLANGD_FLAGS variable. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65201: [clangd] Provide help text to users who run `clangd` in a terminal.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rL366992: [clangd] Provide help text to users who run `clangd` in a terminal. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a

[clang-tools-extra] r366992 - [clangd] Provide help text to users who run `clangd` in a terminal.

Author: sammccall Date: Thu Jul 25 01:00:54 2019 New Revision: 366992 URL: http://llvm.org/viewvc/llvm-project?rev=366992=rev Log: [clangd] Provide help text to users who run `clangd` in a terminal. Reviewers: hokein Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits

[PATCH] D65263: [clangd] a prototype for triggering rename after extracting.

hokein created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is a prototype patch. LSP doesn't have support for asking user input currently. Other language servers (Typescript, Java) will trigger

[PATCH] D65139: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

sammccall marked 2 inline comments as done. sammccall added a comment. This is ready for another round, I think. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:393 std::string VarName = "dummy"; + SourceRange Range = Target->getExtractionChars();

[PATCH] D65201: [clangd] Provide help text to users who run `clangd` in a terminal.

sammccall added a comment. Oops, forgot to hit send. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:430 + if (llvm::outs().is_displayed() && llvm::errs().is_displayed()) +llvm::errs() << Overview << "\n"; // Use buffered stream to stderr (we still flush each

[PATCH] D65263: [clangd] a prototype for triggering rename after extracting.

sammccall added a comment. This is really cool! Hm, formatting is troublesome, well spotted :-) As you're defining a generic mechanism, it'd be useful to have more examples to verify that this actually generalizes. We might have to make them up (e.g.

[PATCH] D65210: [clangd] Fix the annotate tweak after rL366893

hokein updated this revision to Diff 211692. hokein marked 2 inline comments as done. hokein added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65210/new/ https://reviews.llvm.org/D65210 Files:

[PATCH] D65210: [clangd] Fix the annotate tweak after rL366893

This revision was automatically updated to reflect the committed changes. Closed by commit rL366996: [clangd] Fix the annotate tweak after rL366893 (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r366996 - [clangd] Fix the annotate tweak after rL366893

Author: hokein Date: Thu Jul 25 01:48:05 2019 New Revision: 366996 URL: http://llvm.org/viewvc/llvm-project?rev=366996=rev Log: [clangd] Fix the annotate tweak after rL366893 Summary: After rL366893, the annoate tweak is not activated when we select the whole file (the commonAncestor is TUDecl

r366997 - [ASTImporter] Reorder fields after structure import is finished

Author: martong Date: Thu Jul 25 02:07:17 2019 New Revision: 366997 URL: http://llvm.org/viewvc/llvm-project?rev=366997=rev Log: [ASTImporter] Reorder fields after structure import is finished We reorder declarations in RecordDecls because they may have another order in the "to" context than

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

This revision was automatically updated to reflect the committed changes. Closed by commit rL366997: [ASTImporter] Reorder fields after structure import is finished (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D65269: [ASTImporter] Fix for import of friend class template with definition.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. If there is a friend class template "prototype" (forward

[PATCH] D65270: [CMake] Fix source path generation for install in multi-config (MSBuild)

risa2000 created this revision. risa2000 added a reviewer: phosek. risa2000 added a project: LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, mgorny. Herald added projects: clang, Sanitizers. The folder expansion in install scripts created by CMake for "Visual Studio"

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

grandinj added a comment. There is no need to wrap SVG in HTML if you want to display it in a web-browser, you can just open the web-browser explicitly, they already support opening SVG, use something like webbrowser.open_new(url) i.e. https://docs.python.org/2/library/webbrowser.html

r367006 - [CrossTU] Fix plist macro expansion if macro in other file.

Author: balazske Date: Thu Jul 25 03:53:22 2019 New Revision: 367006 URL: http://llvm.org/viewvc/llvm-project?rev=367006=rev Log: [CrossTU] Fix plist macro expansion if macro in other file. Summary: When cross TU analysis is used it is possible that a macro expansion is generated for a macro

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367006: [CrossTU] Fix plist macro expansion if macro in other file. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D65201: [clangd] Provide help text to users who run `clangd` in a terminal.

hokein added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:430 + if (llvm::outs().is_displayed() && llvm::errs().is_displayed()) +llvm::errs() << Overview << "\n"; // Use buffered stream to stderr (we still flush each log message). Unbuffered

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:2110 + /// Emit code for the user defined mapper construct. + void emitUserDefinedMapper(const OMPDeclareMapperDecl *D, +

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:2110 + /// Emit code for the user defined mapper construct. + void emitUserDefinedMapper(const OMPDeclareMapperDecl *D, +

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong added a comment. Jenkins is green: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/31743/ The previous build caught up the change, but http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/31742/ was stopped, perhaps a test got stucked. Repository: rL LLVM CHANGES

[PATCH] D65102: [OpenCL] Rename lang mode flag for C++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL367008: [OpenCL] Rename lang mode flag for C++ mode (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r367008 - [OpenCL] Rename lang mode flag for C++ mode

Author: stulova Date: Thu Jul 25 04:04:29 2019 New Revision: 367008 URL: http://llvm.org/viewvc/llvm-project?rev=367008=rev Log: [OpenCL] Rename lang mode flag for C++ mode Rename lang mode flag to -cl-std=clc++/-cl-std=CLC++ or -std=clc++/-std=CLC++. This aligns with OpenCL C conversion and

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367010: [clang] Add isDirectlyDerivedFrom AST matcher. (authored by AntonBikineev, committed by ). Herald added a

r367010 - [clang] Add isDirectlyDerivedFrom AST matcher.

Author: antonbikineev Date: Thu Jul 25 04:54:13 2019 New Revision: 367010 URL: http://llvm.org/viewvc/llvm-project?rev=367010=rev Log: [clang] Add isDirectlyDerivedFrom AST matcher. Differential Revision: https://reviews.llvm.org/D65092 Modified: cfe/trunk/docs/LibASTMatchersReference.html

[PATCH] D65272: Update some tests after r366702

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This looks safe and consistent with the old tests and intent. Approving to unblock CI Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65272/new/

[PATCH] D65272: Update some tests after r366702

This revision was automatically updated to reflect the committed changes. Closed by commit rL367012: Update some tests after r366702 (authored by krasimir, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

r367013 - Fix failing test plist-macros-with-expansion-ctu.c

Author: balazske Date: Thu Jul 25 05:46:42 2019 New Revision: 367013 URL: http://llvm.org/viewvc/llvm-project?rev=367013=rev Log: Fix failing test plist-macros-with-expansion-ctu.c Modified: cfe/trunk/test/Analysis/plist-macros-with-expansion-ctu.c Modified:

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

aaron.ballman added a comment. In D64838#1597771 , @xbolva00 wrote: > >> they parse the attributes first then attempt to parse a declaration; if > >> that fails, they fall back to parsing a statement > > Well, I don’t think this reparsing is ideal in

[PATCH] D65272: Update some tests after r366702

krasimir created this revision. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. r366702 added a set of new clang-cl -- specific openmp flags together with tests. The way the newly added tests work is problematic: consider for example

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. If either checker emits an error, the current implementation would say it originates from `cplusplus.PureVirtualCall`. Could you please create a new `ProgramPointTag` with the

r367012 - Update some tests after r366702

Author: krasimir Date: Thu Jul 25 05:15:46 2019 New Revision: 367012 URL: http://llvm.org/viewvc/llvm-project?rev=367012=rev Log: Update some tests after r366702 Summary: r366702 added a set of new clang-cl -- specific openmp flags together with tests. The way the newly added tests work is

[PATCH] D65263: [clangd] a prototype for triggering rename after extracting.

hokein marked 4 inline comments as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/Protocol.h:777 + // each command has a certain llvm::Optional structure for its arguments. + llvm::Optional renamePosition; // for LSP_RENAME +};

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added a comment. In D64454#1598043 , @Nathan-Huckleberry wrote: > In D64454#1587102 , @aaron.ballman > wrote: > > > I think this looks reasonable to me, though I am still not certain if the > >

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

RKSimon added a comment. @balazske This is causing buildbot failures - revert? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64638/new/ https://reviews.llvm.org/D64638 ___ cfe-commits mailing list

[PATCH] D50256: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager (for == and != only)

baloghadamsoftware updated this revision to Diff 211726. baloghadamsoftware added a comment. Intersecting an empty set caused an assertion. Early return inserted to prevent this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50256/new/ https://reviews.llvm.org/D50256 Files:

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

baloghadamsoftware added a comment. I evaluated this patch on different open-source projects, with Z3 refutation off and on: F9660704: MulDivEvaluation.xlsx I cannot always decide whether a bug is false positive or true positive. Most of them seem false

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

baloghadamsoftware updated this revision to Diff 211727. baloghadamsoftware added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49074/new/ https://reviews.llvm.org/D49074 Files: include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h

[PATCH] D65000: [ARM] Set default alignment to 64bits

carwil added a comment. In D65000#1595920 , @peter.smith wrote: > test case missing A8 aside this looks ok to me. Would like to see if there > are any comments from the Pacific time zone. Are you happy to approve this now @peter.smith? Repository:

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

balazske added a comment. Problem should be fixed now (r367013). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64638/new/ https://reviews.llvm.org/D64638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65279: [clang] Fail for empty names in is*DerivedFrom matchers.

AntonBikineev created this revision. AntonBikineev added a reviewer: aaron.ballman. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D65279 Files: clang/include/clang/ASTMatchers/ASTMatchers.h clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp Index:

[PATCH] D65263: [clangd] a prototype for triggering rename after extracting.

ilya-biryukov added a comment. If we are going down that path, could we consider to pre-selecting a name of the extract variable and its usage (using multi-select)? I.e. the optimal workflow seems to be (`[[code]] marks selected regions`): // Input: foo([[10+10]]); // 'extract'

[PATCH] D64914: Implement P1771

erichkeane updated this revision to Diff 211740. erichkeane marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64914/new/ https://reviews.llvm.org/D64914 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus updated this revision to Diff 211744. Szelethus added a comment. - Be even more strict on the rule: mark the note as prunable even if the note message says `.*(loaded from '')`. This is okay, because `ReturnVisitor` will track the return value anyways, and if at least a single

[PATCH] D64914: Implement P1771

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor naming nit. Comment at: clang/lib/Sema/SemaStmt.cpp:201 + SourceLocation Loc, SourceRange R1, +

[PATCH] D65279: [clang] Fail for empty names in is*DerivedFrom matchers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367022: [clang] Fail for empty names in is*DerivedFrom matchers. (authored by AntonBikineev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

Szelethus updated this revision to Diff 211752. Szelethus added a comment. - Make sure that the tracking kind is forwarded for each invocation of `trackExpressionValue` in `BugReporterVisitor.cpp` - Expose the tracking kind to all users - Add some more docs CHANGES SINCE LAST ACTION

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

jdoerfert added a comment. I'll add @Hahnfeld comments, anything else? If not, can someone approve this and we do separate reviews for improvements? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64375/new/ https://reviews.llvm.org/D64375

r367027 - Implement P1771

Author: erichkeane Date: Thu Jul 25 08:10:56 2019 New Revision: 367027 URL: http://llvm.org/viewvc/llvm-project?rev=367027=rev Log: Implement P1771 As passed in the Cologne meeting and treated by Core as a DR, [[nodiscard]] was applied to constructors so that they can be diagnosed in cases where

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:2110 + /// Emit code for the user defined mapper construct. + void emitUserDefinedMapper(const OMPDeclareMapperDecl *D, +

[PATCH] D64958: [clang-doc] Fix link generation

juliehockett added a comment. Under what circumstances, exactly, is the path not set where you would need to create a link despite that? Is it only in the global namespace case? If so, could you special-case that and ignore other empty paths? Comment at:

[PATCH] D65003: [clang-doc] Add index in each info html file

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Generators.h:28 + static Index genIndex(const std::vector> ); + Add a comment here indicating that this should be created before calling any `generateDocForInfo`s. Also add a fix-it

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:75 + + Checks Linux Kernel code to see if it uses the results from the functions in + linux/err.h. Also checks to see if code uses the results from functions that Please

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

rjmccall added a comment. These were unavailable in system headers before because otherwise we would've had to make them invalid. Since these unions are no longer otherwise invalid, there shouldn't be a problem with allowing them in system headers, and in fact making the semantics vary that

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

kpn added a comment. In D62731#1601310 , @mibintc wrote: > I think it would be convenient to have an "unset" setting for the different > constrained modes, otherwise you need a boolean that says "no value was > provided for this option". But i'm a

[PATCH] D65279: [clang] Fail for empty names in is*DerivedFrom matchers.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65279/new/ https://reviews.llvm.org/D65279

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

NoQ added a comment. In D65250#1600776 , @grandinj wrote: > There is no need to wrap SVG in HTML if you want to display it in a > web-browser, you can just open the web-browser explicitly, they already > support opening SVG, use something like > >

[PATCH] D65000: [ARM] Set default alignment to 64bits

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. I've not seen any objections so I've approved LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, Charusso, a_sidorin, rnkovacs, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Well,

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

juliehockett added a comment. Looks mostly good to me, with a small formatting thing Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:490 Out.emplace_back(llvm::make_unique(HTMLTag::TAG_H3, I.Name)); + Out.back()->Attributes.try_emplace("id", +

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

ahatanak updated this revision to Diff 211778. ahatanak added a comment. Mark fields that don't have an explicit `__strong` qualifier as unavailable. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65256/new/ https://reviews.llvm.org/D65256 Files:

RE: r367027 - Implement P1771

Ah! Thanks. I’ll fix it now. From: Richard Smith [mailto:rich...@metafoo.co.uk] Sent: Thursday, July 25, 2019 9:26 AM To: Keane, Erich Cc: cfe-commits Subject: Re: r367027 - Implement P1771 On Thu, 25 Jul 2019, 08:10 Erich Keane via cfe-commits, mailto:cfe-commits@lists.llvm.org>> wrote:

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan added a comment. My bad. I omit these two test cases. I apologize for my carelessness. Yes, this warning definitely is a duplicate of c++11 narrowing, *when the code actually uses initialization-list syntax. For example, the following code would issue duplicated warnings for now:

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:137 +// saved (possibly unresolved) + bool IsPathValid = false; // Indicates if a value has been assigned to Path, +

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

nickdesaulniers added a comment. In D64454#1600922 , @aaron.ballman wrote: > I use svn in-tree, so I tried it out and it does not seem to work for me. > > c:\llvm\tools\clang\tools\extra\docs\clang-tidy\checks>python > gen-static-analyzer-docs.py >

r367022 - [clang] Fail for empty names in is*DerivedFrom matchers.

Author: antonbikineev Date: Thu Jul 25 07:48:55 2019 New Revision: 367022 URL: http://llvm.org/viewvc/llvm-project?rev=367022=rev Log: [clang] Fail for empty names in is*DerivedFrom matchers. Differential Revision: https://reviews.llvm.org/D65279 Modified:

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 211757. dgoldman added a comment. - Fix test failure: typo-correction-cxx11.cpp Make sure that `TryTransform` clears any TypoExprs that are created if it returns an invalid ExprResult (as the new TypoExprs are unreachable from the result). Repository:

[PATCH] D65290: [analyzer][NFC] Prove that we only track the evaluated part of the condition

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, Charusso, rnkovacs, baloghadamsoftware, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Szelethus added a

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: test/SemaObjC/Inputs/non-trivial-c-union.h:10 + _Nonnull id f1; + __weak id f2; +} U0_SystemHeader; Rather than making an exception for explicit `__strong` fields, should we

r367038 - Fix cxx_status html for r367027

Author: erichkeane Date: Thu Jul 25 10:14:37 2019 New Revision: 367038 URL: http://llvm.org/viewvc/llvm-project?rev=367038=rev Log: Fix cxx_status html for r367027 Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL:

[PATCH] D65139: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:50 // Generate Replacement for declaring the selected Expr as a new variable - tooling::Replacement insertDeclaration(llvm::StringRef VarName) const; +

[PATCH] D64272: [analyzer] Note last writes to a condition only in a nested stackframe

Szelethus updated this revision to Diff 211758. Szelethus added a comment. - Only in a **nested** stackframe. Not different stackframe. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64272/new/ https://reviews.llvm.org/D64272 Files:

[PATCH] D64914: Implement P1771

This revision was automatically updated to reflect the committed changes. Closed by commit rL367027: Implement P1771 (authored by erichkeane, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

Charusso added a comment. In D65250#1601187 , @NoQ wrote: > In D65250#1600776 , @grandinj wrote: > > > There is no need to wrap SVG in HTML if you want to display it in a > > web-browser > > > I guess it's worth

Re: r367027 - Implement P1771

On Thu, 25 Jul 2019, 08:10 Erich Keane via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Thu Jul 25 08:10:56 2019 > New Revision: 367027 > > URL: http://llvm.org/viewvc/llvm-project?rev=367027=rev > Log: > Implement P1771 > > As passed in the Cologne meeting and

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia created this revision. Anastasia added reviewers: rjmccall, rsmith, mantognini. Herald added subscribers: ebevhan, yaxunl. I am recreating the review from https://reviews.llvm.org/D59426 that seem to get lost somehow. The idea is to be able to allow creating vector literals from other

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

mibintc added a comment. The proposed llvm changes are now part of https://reviews.llvm.org/D62731 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53157/new/ https://reviews.llvm.org/D53157 ___ cfe-commits mailing list

[PATCH] D65254: Allow prefetching from non-zero address spaces

This revision was automatically updated to reflect the committed changes. Closed by commit rL367032: Allow prefetching from non-zero address spaces (authored by jfb, committed by ). Changed prior to commit: https://reviews.llvm.org/D65254?vs=211637=211774#toc Repository: rL LLVM CHANGES

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

jordan_rose added a comment. In D65256#1601410 , @rjmccall wrote: > These were unavailable in system headers before because otherwise we would've > had to make them invalid. Since these unions are no longer otherwise > invalid, there shouldn't be a

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

jordan_rose added a comment. I'm personally still of the opinion that allowing non-trivial fields in unions was a mistake, but it's too late to change that as well. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65256/new/ https://reviews.llvm.org/D65256

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:2110 + /// Emit code for the user defined mapper construct. + void emitUserDefinedMapper(const OMPDeclareMapperDecl *D, + CodeGenFunction *CGF = nullptr) override;

r367026 - [clang] Remove IsDerivedFromDeathTest.DiesOnEmptyBaseName test.

Author: antonbikineev Date: Thu Jul 25 08:09:37 2019 New Revision: 367026 URL: http://llvm.org/viewvc/llvm-project?rev=367026=rev Log: [clang] Remove IsDerivedFromDeathTest.DiesOnEmptyBaseName test. The semantics of an empty basename passed to isDerivedFrom matchers changed in r367022, so this

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:2110 + /// Emit code for the user defined mapper construct. + void emitUserDefinedMapper(const OMPDeclareMapperDecl *D, + CodeGenFunction *CGF = nullptr) override;

[PATCH] D59426: [PR41010][OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia abandoned this revision. Anastasia added a comment. Created a follow up review in https://reviews.llvm.org/D65286 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59426/new/ https://reviews.llvm.org/D59426 ___ cfe-commits mailing

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 211770. mibintc added a comment. Herald added subscribers: hiraditya, mgorny. The IRBuilder now has been taught about constrained fadd and friends. I simply updated my patches to work with the committed revision. Note that this diff now contains what was

r367032 - Allow prefetching from non-zero address spaces

Author: jfb Date: Thu Jul 25 09:11:57 2019 New Revision: 367032 URL: http://llvm.org/viewvc/llvm-project?rev=367032=rev Log: Allow prefetching from non-zero address spaces Summary: This is useful for targets which have prefetch instructions for non-default address spaces. Subscribers:

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

rjmccall added a comment. Wait, plain C++? Do we currently allow this syntax outside of OpenCL? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65286/new/ https://reviews.llvm.org/D65286 ___ cfe-commits mailing list

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

ziyig added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1172 return ExprError(); +LLVM_FALLTHROUGH; + case Builtin::BI__builtin_alloca: aaron.ballman wrote: > Do we want to warn on all uses of alloca(), or just the ones that get past

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

ziyig updated this revision to Diff 211785. ziyig marked 9 inline comments as done. ziyig added a comment. Updated the warning message and the test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64883/new/ https://reviews.llvm.org/D64883 Files:

RE: [PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

Thanks for your review. I put some quick replies below. I'll work on an update to this. > -Original Message- > From: Kevin P. Neal via Phabricator [mailto:revi...@reviews.llvm.org] > Sent: Thursday, July 25, 2019 1:09 PM > To: Blower, Melanie ; chandl...@gmail.com > Cc:

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran added a comment. In D64958#1601228 , @juliehockett wrote: > Under what circumstances, exactly, is the path not set where you would need > to create a link despite that? Is it only in the global namespace case? If > so, could you

[PATCH] D65203: [ASTImporter] Do not import FunctionTemplateDecl in record twice.

balazske updated this revision to Diff 211743. balazske added a comment. Added missing test fixture, removed not a related change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65203/new/ https://reviews.llvm.org/D65203 Files:

  1   2   >