[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

jordan_rose added a comment. In D65256#1601410 , @rjmccall wrote: > These were unavailable in system headers before because otherwise we would've > had to make them invalid. Since these unions are no longer otherwise > invalid, there shouldn't be a prob

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

jordan_rose added a comment. I'm personally still of the opinion that allowing non-trivial fields in unions was a mistake, but it's too late to change that as well. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65256/new/ https://reviews.llvm.org/D65256 _

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan added a comment. My bad. I omit these two test cases. I apologize for my carelessness. Yes, this warning definitely is a duplicate of c++11 narrowing, *when the code actually uses initialization-list syntax. For example, the following code would issue duplicated warnings for now: fl

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:137 +// saved (possibly unresolved) + bool IsPathValid = false; // Indicates if a value has been assigned to Path, +

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran added a comment. In D64958#1601228 , @juliehockett wrote: > Under what circumstances, exactly, is the path not set where you would need > to create a link despite that? Is it only in the global namespace case? If > so, could you special-

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

nickdesaulniers added a comment. In D64454#1600922 , @aaron.ballman wrote: > I use svn in-tree, so I tried it out and it does not seem to work for me. > > c:\llvm\tools\clang\tools\extra\docs\clang-tidy\checks>python > gen-static-analyzer-docs.py > T

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added a comment. In D64454#1601439 , @nickdesaulniers wrote: > In D64454#1600922 , @aaron.ballman > wrote: > > > I use svn in-tree, so I tried it out and it does not seem to work for me. > > > > c:

r367040 - Add lifetime categories attributes

Author: mgehre Date: Thu Jul 25 10:50:51 2019 New Revision: 367040 URL: http://llvm.org/viewvc/llvm-project?rev=367040&view=rev Log: Add lifetime categories attributes Summary: This is the first part of work announced in "[RFC] Adding lifetime analysis to clang" [0], i.e. the addition of the [[gs

[PATCH] D63954: Add lifetime categories attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rL367040: Add lifetime categories attributes (authored by mgehre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D63954: Add lifetime categories attributes

mgehre added a comment. Thank you very much for dedicating your time for the review. It improved the code a lot! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63954/new/ https://reviews.llvm.org/D63954 ___ cfe-commit

r367042 - CodeGen: ensure placeholder instruction for cleanup is created

Author: compnerd Date: Thu Jul 25 10:59:29 2019 New Revision: 367042 URL: http://llvm.org/viewvc/llvm-project?rev=367042&view=rev Log: CodeGen: ensure placeholder instruction for cleanup is created A placeholder instruction for use in generation of cleanup code for an initializer list would not b

[PATCH] D64656: Ensure placeholder instruction for cleanup is created

compnerd closed this revision. compnerd added a comment. SVN r367042 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64656/new/ https://reviews.llvm.org/D64656 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh updated this revision to Diff 211794. lildmh added a comment. Remove virtual from function declaration CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 Files: include/clang/AST/GlobalDecl.h lib/AST/ASTContext.cpp lib/CodeGen/CGDecl.c

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

rjmccall added a comment. In D65256#1601415 , @jordan_rose wrote: > In D65256#1601410 , @rjmccall wrote: > > > These were unavailable in system headers before because otherwise we > > would've had to make them inva

[PATCH] D65294: Make the CXXABIs respect the target's default calling convention.

erichkeane created this revision. erichkeane added a reviewer: Anastasia. SPIR targets need to have all functions be SPIR calling convention, however the CXXABIs were just returning CC_C in all non-'this-CC' cases. https://reviews.llvm.org/D65294 Files: clang/lib/AST/ItaniumCXXABI.cpp clang

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

jordan_rose added a comment. In D65256#1601509 , @rjmccall wrote: > Sorry, am I missing something? Such a union would've been either ill-formed > or unavailable in ARC (depending on where it was declared) before this recent > work. Apparently that was

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

rjmccall added a comment. In D65256#1601510 , @jordan_rose wrote: > In D65256#1601509 , @rjmccall wrote: > > > Sorry, am I missing something? Such a union would've been either > > ill-formed or unavailable in ARC

[clang-tools-extra] r367045 - [clang-doc] Fix html entities in rendered text

Author: diegoastiazaran Date: Thu Jul 25 13:14:45 2019 New Revision: 367045 URL: http://llvm.org/viewvc/llvm-project?rev=367045&view=rev Log: [clang-doc] Fix html entities in rendered text Replace &, <, >, ", and ' with their corresponding html entities in text rendered by HTML generator. Diffe

[PATCH] D65107: [clang-doc] Fix html entities in rendered text

This revision was automatically updated to reflect the committed changes. Closed by commit rL367045: [clang-doc] Fix html entities in rendered text (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1172 return ExprError(); +LLVM_FALLTHROUGH; + case Builtin::BI__builtin_alloca: ziyig wrote: > aaron.ballman wrote: > > Do

[PATCH] D65290: [analyzer][NFC] Prove that we only track the evaluated part of the condition

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Just as planned! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65290/new/ https://reviews.llvm.org/D65290 _

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2287 assert(RegResults.size() == ResultRegDests.size()); + assert(ResultTypeRequiresCast.size() <= ResultRegDests.size()); for (unsigned i = 0, e = RegResults.size(); i != e; ++i) { N

[PATCH] D65005: [clang-doc] Fix output format of html

DiegoAstiazaran updated this revision to Diff 211812. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65005/new/ https://reviews.llvm.org/D65005 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp Index: clang-tools-extra/un

r367051 - Revert "CodeGen: ensure placeholder instruction for cleanup is created"

Author: jfb Date: Thu Jul 25 13:50:09 2019 New Revision: 367051 URL: http://llvm.org/viewvc/llvm-project?rev=367051&view=rev Log: Revert "CodeGen: ensure placeholder instruction for cleanup is created" Originally in https://reviews.llvm.org/D64656 Causes bot failures: /home/buildslave/buildslav

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

NoQ added a comment. I'm sure i've seen something with a do-while(0) loop. Let's also add the following: #define assert(x) do {\ if (!x) \ __assert_fail (#expr, __FILE__, __LINE__, __func__) \ } w

[PATCH] D64656: Ensure placeholder instruction for cleanup is created

jfb reopened this revision. jfb added a comment. This revision is now accepted and ready to land. Reverted in r367051, it's causing failures: http://lab.llvm.org:8011/builders/clang-cmake-armv8-full/builds/13658/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Apr40771-ctad-with-lambda-copy-captu

[PATCH] D65005: [clang-doc] Fix output format of html

This revision was automatically updated to reflect the committed changes. Closed by commit rL367050: [clang-doc] Fix output format of html (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

r367053 - Reland the "[NewPM] Port Sancov" patch from rL365838. No functional

Author: leonardchan Date: Thu Jul 25 13:53:15 2019 New Revision: 367053 URL: http://llvm.org/viewvc/llvm-project?rev=367053&view=rev Log: Reland the "[NewPM] Port Sancov" patch from rL365838. No functional changes were made to the patch since then. [NewPM] Port Sancov This patch contai

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

ziyig updated this revision to Diff 211816. ziyig marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64883/new/ https://reviews.llvm.org/D64883 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaChecking.cpp clang/test/Sema/warn-

r367055 - Revert "Revert "CodeGen: ensure placeholder instruction for cleanup is created""

Author: compnerd Date: Thu Jul 25 13:59:48 2019 New Revision: 367055 URL: http://llvm.org/viewvc/llvm-project?rev=367055&view=rev Log: Revert "Revert "CodeGen: ensure placeholder instruction for cleanup is created"" This reverts commit fd1274fa78cb0fd32cc1fa2e6f5bb8e62d29df19. Add an explicit tr

[PATCH] D64938: [clang-doc] Add option for user provided stylesheets

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64938/new/ https://reviews.llvm.org/D64938 ___ cfe-commits mailing list c

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64883/new/ https://reviews.llvm.org/D64883 __

[clang-tools-extra] r367050 - [clang-doc] Fix output format of html

Author: diegoastiazaran Date: Thu Jul 25 13:49:00 2019 New Revision: 367050 URL: http://llvm.org/viewvc/llvm-project?rev=367050&view=rev Log: [clang-doc] Fix output format of html The children of a TagNode are rendered in the same line as the parent only if they are all TextNodes. When children

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

DiegoAstiazaran updated this revision to Diff 211820. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/ https://reviews.llvm.org/D64539 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/MDGenerator.cpp

[clang-tools-extra] r367056 - [clang-doc] Add stylesheet to generated html docs

Author: diegoastiazaran Date: Thu Jul 25 14:27:50 2019 New Revision: 367056 URL: http://llvm.org/viewvc/llvm-project?rev=367056&view=rev Log: [clang-doc] Add stylesheet to generated html docs A default css stylesheet is included for docs generated in html format. Differential Revision: https://r

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb5d8e3db253: [clang-doc] Add stylesheet to generated html docs (authored by DiegoAstiazaran). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D65234: [CodeGen]: don't treat structures returned in registers as memory inputs

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:1989 std::vector Args; + std::vector ResultTypeRequiresCast; Are we able to use something other than `std::vector` here from ADT? http://llvm.org/docs/ProgrammersManual.html#bit

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

paulkirth created this revision. paulkirth added reviewers: phosek, leonardchan, jakehehrlich, mcgrathr. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar, mgorny. Herald added a project: clang. **Overview**: This patch contains a prototype of the basic functionality of clang-misex

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

paulkirth updated this revision to Diff 211831. paulkirth added a comment. Refactors some debug code to be more centralized and cleans up some comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65300/new/ https://reviews.llvm.org/D65300 Files: clang/include/clang/Basic/CodeGenOp

r367063 - [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

Author: zer0 Date: Thu Jul 25 15:05:55 2019 New Revision: 367063 URL: http://llvm.org/viewvc/llvm-project?rev=367063&view=rev Log: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2. - Removing a few of the entries in the Flags for the Types.def table. - Removing redundant parts of get

[PATCH] D65106: [OPENMP]Add support for analysis of reduction variables.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Herald added a reviewer: jdoerfert. Great, thanks! That'll be fun to model in the static analyzer :/ Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65106/new/ https:

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367063: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2. (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

xbolva00 added a comment. Nice work! It would be nice if we also have “-fsuggest-expect” so we could fix perf issues thanks to PGO counters even for non-PGO builds. What do you think? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65300/new/ https://reviews.llvm.org/D65300 _

r367067 - [Sema] add -Walloca to flag uses of `alloca`

Author: gbiv Date: Thu Jul 25 15:23:40 2019 New Revision: 367067 URL: http://llvm.org/viewvc/llvm-project?rev=367067&view=rev Log: [Sema] add -Walloca to flag uses of `alloca` This CL adds an optional warning to diagnose uses of the `__builtin_alloca` family of functions. The use of these functio

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder updated this revision to Diff 211836. tmroeder added a comment. Synchronize the documentation, as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59963/new/ https://reviews.llvm.org/D59963 Files: clang-tools-extra/clang-tidy/CM

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

This revision was automatically updated to reflect the committed changes. Closed by commit rL367067: [Sema] add -Walloca to flag uses of `alloca` (authored by gbiv, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked 2 inline comments as done. tmroeder added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:75 + + Checks Linux Kernel code to see if it uses the results from the functions in + linux/err.h. Also checks to see if code uses the results from fun

[PATCH] D65184: [Sema] Thread Safety Analysis: Fix negative capability's LockKind representation.

nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2219-2221 +if (LDat1->kind() == LK_Generic || LDat2->kind() == LK_Generic) { + // No warning is issued in this case. + if (Modify && LDat1->kind() == LK_Generic) { ---

[PATCH] D65184: [Sema] Thread Safety Analysis: Fix negative capability's LockKind representation.

aaronpuchert added a reviewer: aaron.ballman. aaronpuchert added a comment. What distinguishes a shared from an exclusive negative capability? Negative capabilities (as I understand them) express the mutex not being held at all, meaning neither in shared nor in exclusive mode. ===

[clang-tools-extra] r367071 - [clang-tidy] Add a module for the Linux kernel.

Author: tmroeder Date: Thu Jul 25 15:32:50 2019 New Revision: 367071 URL: http://llvm.org/viewvc/llvm-project?rev=367071&view=rev Log: [clang-tidy] Add a module for the Linux kernel. Summary: Now that clang is going to be able to build the Linux kernel again on x86, and we have gen_compile_comman

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

nickdesaulniers requested changes to this revision. nickdesaulniers added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/linuxkernel/MustCheckErrsCheck.cpp:12 +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include + ---

[PATCH] D59692: [ASTImporter] Fix name conflict handling

shafik added a comment. First round of review. Comment at: clang/lib/AST/ASTImporter.cpp:2632 + ExpectedName NameOrErr = Importer.HandleNameConflict( + Name, DC, IDNS, ConflictingDecls.data(), ConflictingDecls.size()); + if (!NameOrErr) `Name

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:77 + + This is important in the Linux kernel because ``ERR_PTR``, ``PTR_ERR``, + ``IS_ERR``, ``IS_ERR_OR_NULL``, ``ERR_CAST``, and ``PTR_ERR_OR_ZERO`` return Release Notes

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. tmroeder marked an inline comment as done. Closed by commit rL367071: [clang-tidy] Add a module for the Linux kernel. (authored by tmroeder

[PATCH] D65302: [clang][docs][release notes] mention asm goto support

nickdesaulniers created this revision. nickdesaulniers added reviewers: hans, tstellar. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/docs/ReleaseNo

[PATCH] D65302: [clang][docs][release notes] mention asm goto support

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/docs/ReleaseNotes.rst:116 + control flow from inline assembly. The main consumer of this construct is the + Linux kernel and glib. There a few long tail bugs in Clang's in

[PATCH] D64938: [clang-doc] Add option for user provided stylesheets

DiegoAstiazaran updated this revision to Diff 211841. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64938/new/ https://reviews.llvm.org/D64938 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/MDGenerator.cpp

[clang-tools-extra] r367072 - [clang-doc] Add option for user provided stylesheets

Author: diegoastiazaran Date: Thu Jul 25 15:46:40 2019 New Revision: 367072 URL: http://llvm.org/viewvc/llvm-project?rev=367072&view=rev Log: [clang-doc] Add option for user provided stylesheets An option has been added to clang-doc to provide a list of css stylesheets that the user wants to use

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

paulkirth added a comment. In D65300#1601733 , @xbolva00 wrote: > Nice work! Glad to hear you like it. > It would be nice if we also have “-fsuggest-expect” so we could fix perf > issues thanks to PGO counters even for non-PGO builds. What do you think

[PATCH] D64938: [clang-doc] Add option for user provided stylesheets

This revision was automatically updated to reflect the committed changes. Closed by commit rL367072: [clang-doc] Add option for user provided stylesheets (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65306: [clang-doc] Fix failing tests on Windows

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. Make sure you update the other stylesheet patch, as well, before landing that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65306/new/ https://reviews.llvm.org/D65306

[PATCH] D65306: [clang-doc] Fix failing tests on Windows

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. DiegoAstiazaran added a project: clang-tools-extra. juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. Make sure you update the other stylesheet p

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 211849. nicolas edited the summary of this revision. nicolas added a comment. I added the SourceLocation of the ellipsis to `FunctionProtoType` in addition to the `Variadic` boolean. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

paulkirth updated this revision to Diff 211853. paulkirth added a comment. Add missing test for switch statements when the expected value is not a compile time constant. Make sure that when the expected value cannot be evaluated, we do not issue any warnings or errors Repository: rG LLVM Gi

[PATCH] D65306: [clang-doc] Fix failing tests on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL367074: [clang-doc] Fix failing tests on Windows (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[clang-tools-extra] r367074 - [clang-doc] Fix failing tests on Windows

Author: diegoastiazaran Date: Thu Jul 25 16:22:55 2019 New Revision: 367074 URL: http://llvm.org/viewvc/llvm-project?rev=367074&view=rev Log: [clang-doc] Fix failing tests on Windows Tests on Windows were failing due to path separator differences. '/' was being used as separator in the expected o

[PATCH] D65308: [NFC][clang] Refactor getCompilationPhases()+Types.def step 3.

plotfi created this revision. plotfi added reviewers: compnerd, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. New improved 'u'-less clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65308 Files: clang/include/clang/Driver/Types.def

[PATCH] D65308: [NFC][clang] Refactor getCompilationPhases()+Types.def step 3.

compnerd added inline comments. Comment at: clang/lib/Driver/Types.cpp:113 + Id == TY_HIP_FATBIN); +// clang-format on } I think this is better written as: ``` static const clang::driver::types::ID kStaticLangageTypes[] = { TY_CUDA_DEVICE, TY_HIP_DE

[PATCH] D65309: [clang-format] Fix style of css file paths

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. CSS files included in HTML should have a path in posix style, it should not be different for Windows. https://reviews.llvm.org/D65309 Files:

r367076 - Revert "[Sema] Diagnose default-initialization, destruction, and copying of"

Author: ahatanak Date: Thu Jul 25 17:02:17 2019 New Revision: 367076 URL: http://llvm.org/viewvc/llvm-project?rev=367076&view=rev Log: Revert "[Sema] Diagnose default-initialization, destruction, and copying of" This reverts commit r365985. Prior to r365985, clang used to mark C union fields tha

[PATCH] D65227: clang-format: Support `if CONSTEXPR` if CONSTEXPR is a macro.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. I am surprised this works as well as it does, but tests seem to indicate it does, so... LG (minus potentially reducing some duplication :) Comment at: clang/lib/Format/Token

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

hiraditya added a comment. Thanks for addressing the feedback @emmettneyman , LGTM, deferring to other reviewers for final call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://reviews.llvm.org/D64380 __

[PATCH] D65003: [clang-doc] Add index in each info html file

DiegoAstiazaran updated this revision to Diff 211866. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Rebase and add comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65003/new/ https://reviews.llvm.org/D65003 Files: clang-tools-extra/clang-do

[PATCH] D65003: [clang-doc] Add index in each info html file

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:337-346 + + A + B + C + + D + E juliehockett wrote: > The indentation here seems a bit off Fixed by D65005. CHANGES SINCE LAST ACTION https://r

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran updated this revision to Diff 211869. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Add comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65030/new/ https://reviews.llvm.org/D65030 Files: clang-tools-extra/clang-doc/HTMLGenera

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

arsenm added inline comments. Comment at: llvm/include/llvm/IR/FPState.h:1 +#ifndef LLVM_FPSTATE_H +#define LLVM_FPSTATE_H Missing license header and c++ mode comment Comment at: llvm/lib/IR/FPState.cpp:1 +#include "llvm/IR/FPState.h" +#include

[PATCH] D41412: [libcxx] implement concat() and split()

grosser added a comment. @EricWF thanks again for offering your help here. We are not in a rush here, but I wonder if you happen to have a rough estimate when you might have the time to look into these patches? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41412/new/ https://reviews.l

<    1   2